feat(service): one image per devcontainer.json, listed in POST /build's images

[alexanderilyin]

Service side of plan 004 (Phase B, step 1). Recorded in ADR-0015.

What changes

• Discovery (service/src/config-discovery.ts):
  • The root config is main. .devcontainer/devcontainer.json wins over .devcontainer.json.
  • Each .devcontainer/<folder>/devcontainer.json is its own item. Its id is the folder name lower-cased, with anything outside [a-z0-9-] turned into - and leading and trailing - trimmed.
  • Order: main first, then the folders by id. Symlinked folders and files are skipped.
  • Id collisions and empty ids are a 400 that names the folders.
• Build (build.ts): one clone, then buildInstance() for each item, one after another.
  • Sub-folder items pass --config. main keeps exactly today's argv.
  • The config label and the remote-user probe use each item's own config.
  • Each item has its own span, log (imageBuildLogId) and timeout.
  • If an item fails, the request fails, and when there are several items the error names the images already pushed.
• API, additive (1.x stays compatible):
  • The response adds images: [{id, configPath, image, registry, name, tag, imageBuildLogId?}]. The existing top-level fields describe images[0].
  • New optional request fields: instances (a filter; an unknown id is a 400 listing the valid ids) and dryRun (clone, discover and name only, with no build or push).
• Naming: main keeps its name. Other items get <name>-<id>, including when image.name is set explicitly. The same tag and registry apply to every item.
• Fallback image: used only when no config exists at any location. Without a fallback image, that case is now a 400 instead of the CLI's 500.
• Metrics: a successful dry run counts as status="dry_run".

GET /devcontainer and GET/DELETE /image are unchanged and still take one image.

Tests

• npm run build && npm run test:unit pass: 76 tests.
• New unit tests cover:
  • discovery: root only, the precedence between the two root locations, folders only, root plus folders, nesting and symlinks, id sanitizing, collisions and empty ids;
  • the instances filter;
  • image naming;
  • the --config argv;
  • the request and response schema.
• devcontainer_config_discovery.feature is rewritten, with new test-git-server seed repos (extraConfigPaths). The BDD suite was not run, because it needs the cluster. cucumber-js --dry-run matches every step.

Next

The provider's images/instances/dry run in ModifyPlan, then the module and the template (plan 004 steps 2-5).

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 05d03237-288f-4182-998c-d2529d35380c

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}