Repository navigation
revert: one image per devcontainer.json (#60) - feature abandoned - #66
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #60 before 1.0, so
images[],instancesanddryRunnever ship in a release and aren't part of the 1.x API promise. Plans 004 and 005 record the feature as abandoned.Why: Coder names an agent after its Terraform resource name and fails with
duplicate agent nameotherwise, so the template couldn't give each image its own agent. Without that, the multiple-image API has no consumer.After this, a repository whose only configs are in
.devcontainer/<folder>/behaves as in 0.5.0: it falls back tofallbackImage, or fails.npm run buildpasses, andnpm run test:unitpasses 106/106 (feat(service): one image per devcontainer.json, listed in POST /build's images #60's own tests are removed with it).🤖 Generated with Claude Code