Repository navigation
wlr: retarget to wlroots 0.20.2 - #3
Merged
Merged
Conversation
DeedleFake
force-pushed
the
wlroots-0.20
branch
6 times, most recently
from
September 28, 2026 15:40
930f7d3 to
36cc5ba
Compare
Pin pkg-config to wlroots-0.20 and drop the removed matrix helpers.
Delete AttachRender/Commit/Rollback and renderer Begin/End/Clear/matrix draw helpers. Add OutputState, CommitState/TestState, BeginRenderPass, and RenderPass.AddTexture/AddRect. CreateGlobal now takes a Display; CreateOutputLayout takes a Display; software cursors go through the render pass.
AutocreateBackend takes an event loop. Fix input device enums and drop vendor/product. Axis/button notify use wl_pointer enums and relative direction. Prefer xdg new_toplevel/new_popup signals. Xwayland cursor uses wlr_buffer; maximized is horz/vert.
Regenerate against current xkbcommon-keysyms.h so the package builds with libxkbcommon 1.8+.
These local copies are unused; wlroots installs its own protocol headers for consumers.
Bump the shared CI pin so the workflow builds wlroots-0.20 from source and pkg-config resolves wlroots-0.20.pc under the install prefix.
DeedleFake
force-pushed
the
wlroots-0.20
branch
from
September 28, 2026 15:49
36cc5ba to
9508232
Compare
Distro wlroots packages omit meson-generated *-protocol.h files that public headers quote-include. cgo puts the package directory on the include path, so keeping the ones this module needs here unblocks builds against /usr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coder created this PR.
Stacks on the CI PR (
ci← base). Bumps.github/wlroots-versionto 0.20.2 so Actions builds wlroots from that tag (wlroots-0.20.pc).Why
Bind against wlroots 0.20.2 so compositors can use the current render-pass / output-state API. The old attach-render + matrix path is gone upstream.
Scope
Big-bang A on
deedles.dev/wlronly (kawa out of scope):#cgo pkg-config: wlroots-0.20 wayland-server pixman-1AttachRender/Rollback/Commit, rendererBegin/End/Clear/RenderTextureWithMatrix/RenderRect, pendingSetScale/SetMode/Enable/SetTransformOutputState+CommitState/TestState,RenderPass(BeginRenderPass,AddTexture/AddRect, software cursors via render pass)AutocreateBackend(EventLoop),CreateOutputLayout(Display),CreateGlobal(Display)OnNewToplevel/OnNewPopup; Xwayland cursor buffer + maximized horz/vert.horphans0.17.4→0.20.2Tradeoffs
SetMaximizedtakes two bools.Blast Radius
Any compositor importing this module (e.g. kawa later) must be updated for the new signatures. No Go toolchain bump.
Verification
Against
/opt/wlroots-0.20(wlroots 0.20.2):No
*_test.goin tree;go test ./...not exercised beyond compile.