Repository navigation
fix: build Perfetto from the chip workload directory - #18
Open
daiyongyuan wants to merge 2 commits into
Open
daiyongyuan wants to merge 2 commits into
daiyongyuan wants to merge 2 commits into
Conversation
daiyongyuan
force-pushed
the
fix/perfetto-workload-build-dir-20260912
branch
from
September 20, 2026 05:36
932ee38 to
3128baa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perfetto generation now builds from the selected chip's workload build directory. This fixes commands that previously invoked the unrelated top-level bb-tests/build directory.
Validation: evaluated the generated command with chip pebble and a repository path containing spaces; the build path and shell quoting matched the workload directory contract.