Repository navigation
Build the OpenCU Android engine into the app - #187
Merged
Merged
Conversation
The first real use over the relay failed: the phone could not reach github.com, and a failed download counted against the 24-hour interval even with no engine, so every later call returned the same error until the interval passed. The jar is 68 KB. Embed it and its manifest, unchanged from the OpenCU release, in the Android build. There is now always an engine, the APK signature covers it, and a refresh that cannot reach the release costs at most 10 seconds and fails nothing. A download is used only if newer than the built-in engine, unless WANCTL_OPENCU_ANDROID_URL chose its source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also replace statements that had gone stale: the Android assets are published, and the engine has been accepted on a real phone, though the relay path has not. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a network that cannot reach GitHub, the first
wanctl acton Android failed withOPENCU_NOT_INSTALLED, and the failed attempt then counted against the 24-hour refresh interval, so retries returned the old error without trying again. Seen on a real phone on v0.29.0.The engine jar is 68 KB, so it now ships inside the Android build (
go:embed, Android builds only), covered by the APK's signature. The daily check against the OpenCU release stays: a newer engine replaces the built-in one, a failed check costs at most 10 seconds and no longer blocks use.Cost: an engine bump means committing a new jar, and on networks without GitHub the engine moves only with wanctl releases. ADR 0020 records the change.
Not verified yet: the built-in engine has not run on a phone through the relay. That is the D group, after the release.
🤖 Generated with Claude Code