fix(release): keep .hydra out of the package - #197
Merged
Conversation
openregister ships a symlink in every release:
openregister/.hydra -> /home/rubenlinde/nextcloud-docker-dev/workspace/
server/apps-extra/hydra
An absolute path on one developer's machine, committed to the repo before
.gitignore covered it, so ignoring it now does not untrack it and rsync
happily copies it into the tarball.
Any extractor that guards against path traversal then refuses the whole
archive. Nextcloud's own does: installing openregister through the App
Versions app fails with
Out-of-path file extraction {…/openregister/.hydra --> /home/rubenlinde/…}
and nothing is installed. The archive is otherwise valid, which is why
`tar tzf` and GNU tar are perfectly happy with it and the problem only
appears at install time.
.hydra is developer tooling and has no business in a release anyway, so
it joins .claude, .cursor and .vscode in the excludes for all three
release workflows. openregister still needs the tracked symlink removed;
this stops any app shipping one by accident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openregister ships a symlink to an absolute path on one developer's machine in every release:
It was committed before
.gitignorecovered it, so ignoring it now doesn't untrack it, and rsync copies it into the tarball.Any extractor guarding against path traversal refuses the whole archive. Nextcloud's does — installing openregister through App Versions fails with
Out-of-path file extractionand nothing installs. The archive is otherwise valid, which is whytar tzfand GNU tar are perfectly happy and the problem only shows at install time..hydrais developer tooling with no business in a release, so it joins.claude,.cursorand.vscodein the excludes across all three release workflows.openregister still needs the tracked symlink removed (separate PR); this stops any app shipping one by accident.