fix: untrack the .hydra dev symlink, it breaks every release archive - #2374
Merged
Conversation
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ⏭️ | ||||
| phpcs | ⏭️ | ||||
| phpmd | ⏭️ | ||||
| psalm | ⏭️ | ||||
| phpstan | ⏭️ | ||||
| phpmetrics | ⏭️ | ||||
| eslint | ⏭️ | ||||
| stylelint | ⏭️ | ||||
| build | ⏭️ | ||||
| composer | ⏭️ | ⏭️ | |||
| npm | ⏭️ | ⏭️ | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ❌ | ||||
| Hydra gates | ❌ |
Quality workflow — 2026-08-06 13:16 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.hydrais a symlink to an absolute path on one developer's machine:It is tracked (mode 120000) and therefore packaged into every release. Any extractor that guards against path traversal refuses the whole archive as a result, so installing OpenRegister through the App Versions app fails with
Out-of-path file extractionand nothing is installed.tar tzfand GNU tar are perfectly happy with it, which is why this only shows up at install time.It was never meant to be committed. It arrived on 2026-07-05 in
4e01030f3, a commit titled "chore: preserve WIP before development sync" — a bulk sweep of the working directory. It was later added to.gitignore, but.gitignoredoes not untrack an already-tracked file, so it stayed.Untracking it here. Anyone who wants the symlink locally still gets it: it remains ignored, so it will not come back.
ConductionNL/.github#197 additionally excludes
.hydrafrom all three release workflows, so no app can ship one by accident.(Checked opencatalogi too — its
.hydrais a submodule gitlink with no working-tree content, so its archives are clean.)