Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/release-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,15 @@ on:
description: "Node.js version for building"
required: false
type: string
default: "18"
# 22, not 18. Node 18 left support in April 2025 and now fails on
# packages the fleet already depends on. Two apps could not release
# because of it: nldesign's icon build loads an ES module from
# @conduction/nextcloud-vue and dies with "Unexpected token 'export'",
# since Node 18 treats it as CommonJS, and app_versions builds with
# Vite 7, which requires 20.19+. Both build fine locally on 22, which
# is the sort of gap that never gets diagnosed because the failure
# only exists on the runner.
default: "22"
verify-vendor-deps:
description: "Enable vendor dependency verification after composer install"
required: false
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/release-stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ on:
description: "Node.js version for building"
required: false
type: string
default: "18"
# 22, matching release-beta.yml. Node 18 is out of support and fails
# on packages the fleet already uses; a stable release must not be
# built on a toolchain the beta of the same code could not use.
default: "22"
verify-vendor-deps:
description: "Enable vendor dependency verification after composer install"
required: false
Expand Down
Loading