fix(release): default to Node 22, not the long-dead Node 18 - #195
Merged
Conversation
Node 18 left support in April 2025 and now fails on packages the fleet already depends on. It cost two apps their releases: nldesign's icon build loads an ES module from @conduction/nextcloud-vue and dies with "SyntaxError: Unexpected token 'export'", because Node 18 treats that file as CommonJS. Node 20.19+ can require ESM, so it builds fine locally and only fails on the runner. app_versions builds with Vite 7, which requires Node 20.19+. Both are the sort of failure that never gets diagnosed, because the thing works on every developer's machine and only the runner disagrees. Callers can still pin their own node-version; this only moves the floor for everyone who does not. release.yml already defaulted to 20 and is left alone, since nothing has failed on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 18 left support in April 2025 and now fails on packages the fleet already depends on. It cost two apps their releases:
@conduction/nextcloud-vueand dies withSyntaxError: Unexpected token 'export', because Node 18 treats it as CommonJS. Node 20.19+ can require ESM, so it builds fine locally and only fails on the runner.Both are the failure mode nobody diagnoses: works on every developer's machine, only the runner disagrees.
Callers can still pin their own
node-version; this only moves the floor for those that don't.release.ymlalready defaulted to 20 and is left alone, since nothing has failed on it.