Skip to content

fix(auth): drop a stored API key when Firebase ends the sign-in on Cloud - #23500

Merged
dante01yoon merged 1 commit into
mainfrom
auth/drop-dormant-api-key-when-sign-in-ends
Nov 16, 2026
Merged

dante01yoon merged 1 commit into
mainfrom
auth/drop-dormant-api-key-when-sign-in-ends

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator
graph LR
  A["PR 22541 (merged): send the stored API key when it is the only cloud login"] --> B["this PR: drop the stored key when Firebase ends the sign-in on Cloud"]
  B --> C["PR 23494 (open): manual backport to core/1.60, takes this fix once it merges"]
  B --> D["PR 23495 (open): manual backport to cloud/1.60, takes this fix once it merges"]
  style B stroke-width:3px
Loading

Follow-up to #22541, from the review of its core/1.60 backport (#23494 (comment)). The finding applies to main as well.

Summary

Why. A Cloud user is signed in with Firebase as account A, and the browser still holds an API key that was stored earlier for account B. Firebase ends A's sign-in on its own, for example because the account was disabled or its refresh token expired. From the next request on, the tab authenticates as B without anyone signing in.

Root cause. #22541 made a stored API key the login once no Firebase user is left, and it removes the key in logout() so that signing out leaves no login behind. Firebase's automatic sign-out does not go through logout(). It only fires the identity callback (firebaseIdentity.onUserChanged), which sets currentUser to null and leaves the key in storage. The request in flight gets no credential, but storedApiKeyAsOnlyLogin then sees an initialized store with no Firebase user and answers with the key. main before #22541 answered null on both header getters in that state.

How. The store watches currentUser synchronously and, on Cloud, removes the stored key whenever a Firebase user is replaced by none. That covers every path that ends a sign-in, not only logout().

  • A first answer of "nobody is signed in" has no previous user, so an API-key-only tab keeps its key and still boots.
  • A switch from one Firebase user to another keeps the key; there is still a Firebase user, so the key is not the login.
  • Off Cloud the key is kept, as before. Partner nodes run on it there.
  • logout() still removes the key before it signs out, so the window during sign-out stays closed. The watcher then finds no key and does nothing.
  • The watcher is a separate unit after the identity callback; the callback itself is not edited.

The user sees the existing "API key cleared" toast when this happens, the same one a Cloud sign-out shows since #22541.

No feature gate: this narrows a credential path that #22541 opened, and waiting behind a flag would leave the path open.

AS IS / TO BE

No UI change, so there is nothing to screenshot. Unified auth on, Cloud, Firebase user A signed in, key B stored:

Moment AS IS TO BE
Request in flight when Firebase ends A's sign-in no credential no credential
Next general request (getAuthHeader) B's key no credential
Next workspace request (getWorkspaceAuthHeader) B's key no credential
Reload after that signed in as B signed out
API-key-only tab (no Firebase user at any time) key sent key sent

Verification

  • Red, with the new cases and without the fix (pnpm test:unit src/stores/__tests__/authTokenPriority.test.ts src/stores/authStore.test.ts -t "<the three new titles>"):

    × answers later requests with no credential after Firebase ends the sign-in on its own
      AssertionError: expected { 'X-API-KEY': 'earlier-key' } to be null
    Tests  1 failed | 2 passed
    

    The two that pass before the fix guard it against removing too much: "keeps the stored API key off Cloud when Firebase ends the sign-in" and "keeps the stored key when the first Firebase answer is that nobody is signed in".

  • Green, with the fix: pnpm test:unit src/platform/auth src/stores src/composables/auth src/platform/workspace src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts gives Test Files 144 passed (144), Tests 3476 passed | 1 expected fail (3477).

  • The commit hook ran oxfmt, oxlint, eslint, lint:server-facts and typecheck:app.

  • Not added: a browser spec that invalidates a Firebase user mid-session. authAccountSwitch.spec.ts runs with unified auth off.

  • Not run: anything against a real Cloud backend, and no real Firebase invalidation.

Not in this PR

The same review has a Should fix: an API-key-only Cloud tab can now queue a run over HTTP, but its WebSocket still carries no credential, so execution events do not arrive. That needs the socket path to carry the key and Cloud to accept it there. It is not changed here.

PR 22541 made a stored API key the login once no Firebase user is left, and
logout() removes the key so that signing out leaves no login behind. Firebase
can also end a sign-in on its own: it signs out a disabled or expired user
from inside the SDK, and that path does not go through logout(). The request
in flight got no credential, but the key stayed in storage, so the next
request was sent with it. That key can belong to another account.

The store now watches currentUser synchronously and removes the stored key
on Cloud whenever a Firebase user is replaced by none, whichever path ended
the sign-in. A first answer of "nobody is signed in" has no previous user, so
an API-key-only tab keeps its key. Off Cloud the key is kept, as before.
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 12.4 MB gzip 🔴 +29 B

Details

Summary

  • Raw size: 55.5 MB baseline 55.5 MB — 🔴 +68 B
  • Gzip: 12.4 MB baseline 12.4 MB — 🔴 +29 B
  • Brotli: 9.72 MB baseline 9.72 MB — 🔴 +202 B
  • Bundles: 1046 current • 1046 baseline • 154 added / 154 removed

Category Glance
User & Accounts 🔴 +68 B (107 kB) · Other ⚪ 0 B (36.6 MB) · Vendor & Third-Party ⚪ 0 B (9.7 MB) · Graph Workspace ⚪ 0 B (3.69 MB) · Data & Services ⚪ 0 B (2.01 MB) · Utilities & Hooks ⚪ 0 B (1.44 MB) · + 5 more

App Entry Points — 7.26 kB (baseline 7.26 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-BSK2_AH_.js (new) — 7.26 kB 🔴 +7.26 kB 🔴 +3.68 kB 🔴 +3.04 kB
assets/index-CjkyYEvt.js (removed) 7.26 kB — 🟢 -7.26 kB 🟢 -3.67 kB 🟢 -3.04 kB

Status: 1 added / 1 removed

Graph Workspace — 3.69 MB (baseline 3.69 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BLf8OMzO.js (new) — 2.71 MB 🔴 +2.71 MB 🔴 +598 kB 🔴 +434 kB
assets/GraphView-SuoO_3z5.js (removed) 2.71 MB — 🟢 -2.71 MB 🟢 -598 kB 🟢 -434 kB
assets/WidgetCompositor-C3_wgJ5r.js (removed) 8.04 kB — 🟢 -8.04 kB 🟢 -2.6 kB 🟢 -2.32 kB
assets/WidgetCompositor-CILGx4t7.js (new) — 8.04 kB 🔴 +8.04 kB 🔴 +2.6 kB 🔴 +2.33 kB

Status: 2 added / 2 removed / 3 unchanged

Views & Navigation — 152 kB (baseline 152 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-BsgNWN5j.js (new) — 26.6 kB 🔴 +26.6 kB 🔴 +6.66 kB 🔴 +5.89 kB
assets/CloudSurveyView-C8QP_VFh.js (removed) 26.6 kB — 🟢 -26.6 kB 🟢 -6.65 kB 🟢 -5.89 kB
assets/OAuthConsentView-B8p_WLII.js (new) — 22.4 kB 🔴 +22.4 kB 🔴 +5.88 kB 🔴 +5.18 kB
assets/OAuthConsentView-Daj7a8ZD.js (removed) 22.4 kB — 🟢 -22.4 kB 🟢 -5.88 kB 🟢 -5.17 kB
assets/CloudLoginView-B2NA88ay.js (new) — 15.9 kB 🔴 +15.9 kB 🔴 +4.22 kB 🔴 +3.71 kB
assets/CloudLoginView-DU__FGMh.js (removed) 15.9 kB — 🟢 -15.9 kB 🟢 -4.22 kB 🟢 -3.71 kB
assets/useCloudAuthPage-Bb3n2T_a.js (removed) 15.4 kB — 🟢 -15.4 kB 🟢 -5.32 kB 🟢 -4.58 kB
assets/useCloudAuthPage-BP2WPrgW.js (new) — 15.4 kB 🔴 +15.4 kB 🔴 +5.32 kB 🔴 +4.58 kB
assets/UserCheckView-A6CgTBF8.js (new) — 8.01 kB 🔴 +8.01 kB 🔴 +2.09 kB 🔴 +1.84 kB
assets/UserCheckView-BLBrwKhO.js (removed) 8.01 kB — 🟢 -8.01 kB 🟢 -2.09 kB 🟢 -1.83 kB
assets/CloudSignupView-BAs25DDe.js (removed) 7.52 kB — 🟢 -7.52 kB 🟢 -2.45 kB 🟢 -2.16 kB
assets/CloudSignupView-dzokMa94.js (new) — 7.52 kB 🔴 +7.52 kB 🔴 +2.45 kB 🔴 +2.17 kB
assets/CloudSubscriptionRedirectView-0mLpVbpA.js (new) — 5.93 kB 🔴 +5.93 kB 🔴 +1.96 kB 🔴 +1.73 kB
assets/CloudSubscriptionRedirectView-PtoiteZ5.js (removed) 5.93 kB — 🟢 -5.93 kB 🟢 -1.96 kB 🟢 -1.73 kB
assets/CloudForgotPasswordView-4jCS3RlP.js (removed) 5.37 kB — 🟢 -5.37 kB 🟢 -1.74 kB 🟢 -1.52 kB
assets/CloudForgotPasswordView-BCQCWQb4.js (new) — 5.37 kB 🔴 +5.37 kB 🔴 +1.74 kB 🔴 +1.52 kB
assets/CloudAuthTimeoutView-CsfBHDUU.js (new) — 4.32 kB 🔴 +4.32 kB 🔴 +1.48 kB 🔴 +1.31 kB
assets/CloudAuthTimeoutView-DkvJCfmn.js (removed) 4.32 kB — 🟢 -4.32 kB 🟢 -1.48 kB 🟢 -1.31 kB
assets/WidgetResolutionPreview-CCW05sSd.js (new) — 3.84 kB 🔴 +3.84 kB 🔴 +1.51 kB 🔴 +1.36 kB
assets/WidgetResolutionPreview-CnmChJ4I.js (removed) 3.84 kB — 🟢 -3.84 kB 🟢 -1.51 kB 🟢 -1.36 kB

Status: 10 added / 10 removed / 8 unchanged

Panels & Settings — 899 kB (baseline 899 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CrdtDevPanel-5zond7Af.js (new) — 85.4 kB 🔴 +85.4 kB 🔴 +24.6 kB 🔴 +21.2 kB
assets/CrdtDevPanel-DF4qHySD.js (removed) 85.4 kB — 🟢 -85.4 kB 🟢 -24.6 kB 🟢 -21.2 kB
assets/CreditsPanel-C3xJmxDM.js (new) — 63.1 kB 🔴 +63.1 kB 🔴 +10.7 kB 🔴 +9.12 kB
assets/CreditsPanel-D19T7rNM.js (removed) 63.1 kB — 🟢 -63.1 kB 🟢 -10.7 kB 🟢 -9.12 kB
assets/SkillPacksPanel-BVaXAufd.js (new) — 23.4 kB 🔴 +23.4 kB 🔴 +5.49 kB 🔴 +4.84 kB
assets/SkillPacksPanel-bz-8BXtJ.js (removed) 23.4 kB — 🟢 -23.4 kB 🟢 -5.49 kB 🟢 -4.83 kB
assets/DockedAgentPanel-BB7VzBYo.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +6.01 kB 🔴 +5.04 kB
assets/DockedAgentPanel-EXQhDvyW.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -6.01 kB 🟢 -5.03 kB
assets/agentPanel-CtbwQR_t.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -3.76 kB 🟢 -3.36 kB
assets/agentPanel-dabXmleI.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +3.76 kB 🔴 +3.38 kB
assets/UserPanel-B40cMUN3.js (removed) 8.33 kB — 🟢 -8.33 kB 🟢 -2.45 kB 🟢 -2.12 kB
assets/UserPanel-Cu4QJ07v.js (new) — 8.33 kB 🔴 +8.33 kB 🔴 +2.45 kB 🔴 +2.13 kB
assets/CreditsPanel-BFQ3864W.js (removed) 59 B — 🟢 -59 B 🟢 -79 B 🟢 -63 B
assets/CreditsPanel-Bms6GUyQ.js (new) — 59 B 🔴 +59 B 🔴 +79 B 🔴 +63 B

Status: 7 added / 7 removed / 28 unchanged

User & Accounts — 107 kB (baseline 107 kB) • 🔴 +68 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/authStore-CR693vAe.js (new) — 39.8 kB 🔴 +39.8 kB 🔴 +10.7 kB 🔴 +9.34 kB
assets/authStore-DvrS3RvP.js (removed) 39.8 kB — 🟢 -39.8 kB 🟢 -10.7 kB 🟢 -9.31 kB
assets/SignUpForm-CU1qXaU6.js (new) — 22.3 kB 🔴 +22.3 kB 🔴 +7.38 kB 🔴 +6.35 kB
assets/SignUpForm-DpmM_a5w.js (removed) 22.3 kB — 🟢 -22.3 kB 🟢 -7.38 kB 🟢 -6.34 kB
assets/useAuthDialogs-B1pno_gF.js (new) — 7.46 kB 🔴 +7.46 kB 🔴 +3.12 kB 🔴 +2.71 kB
assets/useAuthDialogs-DHWrxvb1.js (removed) 7.46 kB — 🟢 -7.46 kB 🟢 -3.12 kB 🟢 -2.7 kB
assets/auth-Boa0yvp5.js (removed) 5.52 kB — 🟢 -5.52 kB 🟢 -1.83 kB 🟢 -1.56 kB
assets/auth-jBEyYrDr.js (new) — 5.52 kB 🔴 +5.52 kB 🔴 +1.83 kB 🔴 +1.56 kB
assets/useAuthActions-Dl2hyFG1.js (removed) 5.17 kB — 🟢 -5.17 kB 🟢 -1.88 kB 🟢 -1.64 kB
assets/useAuthActions-g2b8M45U.js (new) — 5.17 kB 🔴 +5.17 kB 🔴 +1.88 kB 🔴 +1.64 kB
assets/UpdatePasswordContent-CLbLtgax.js (removed) 3.64 kB — 🟢 -3.64 kB 🟢 -1.54 kB 🟢 -1.34 kB
assets/UpdatePasswordContent-ejrHMF7V.js (new) — 3.64 kB 🔴 +3.64 kB 🔴 +1.54 kB 🔴 +1.34 kB
assets/InviteWrongAccountDialogContent-CPd9Qjwm.js (removed) 2.82 kB — 🟢 -2.82 kB 🟢 -1.07 kB 🟢 -934 B
assets/InviteWrongAccountDialogContent-D77OF2oJ.js (new) — 2.82 kB 🔴 +2.82 kB 🔴 +1.07 kB 🔴 +934 B
assets/agentAuth-CLpRTsYi.js (new) — 2.49 kB 🔴 +2.49 kB 🔴 +928 B 🔴 +823 B
assets/agentAuth-DCO661K_.js (removed) 2.49 kB — 🟢 -2.49 kB 🟢 -927 B 🟢 -825 B
assets/useAccountUI-BvR8nyTq.js (new) — 716 B 🔴 +716 B 🔴 +362 B 🔴 +314 B
assets/useAccountUI-D--Uuosl.js (removed) 716 B — 🟢 -716 B 🟢 -363 B 🟢 -315 B
assets/auth-C_65zQVY.js (new) — 68 B 🔴 +68 B 🔴 +88 B 🔴 +72 B
assets/auth-D3P9imrb.js (removed) 68 B — 🟢 -68 B 🟢 -88 B 🟢 -72 B

Status: 10 added / 10 removed / 8 unchanged

Editors & Dialogs — 509 kB (baseline 509 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-B9FhLfPi.js (removed) 86.3 kB — 🟢 -86.3 kB 🟢 -18.6 kB 🟢 -16 kB
assets/ComfyHubPublishDialog-CXAaKTDL.js (new) — 86.3 kB 🔴 +86.3 kB 🔴 +18.6 kB 🔴 +16 kB
assets/BoundingBoxesEditor-Ao6t0OFY.js (new) — 46.7 kB 🔴 +46.7 kB 🔴 +12.5 kB 🔴 +11 kB
assets/BoundingBoxesEditor-DdG_6PnU.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -12.5 kB 🟢 -11 kB
assets/useShareDialog-BDA1a0lK.js (new) — 23.4 kB 🔴 +23.4 kB 🔴 +5.56 kB 🔴 +4.95 kB
assets/useShareDialog-Cf8dggOO.js (removed) 23.4 kB — 🟢 -23.4 kB 🟢 -5.56 kB 🟢 -4.95 kB
assets/useDeployToComfyApiDialog-BU-_IfBp.js (removed) 23.3 kB — 🟢 -23.3 kB 🟢 -6.78 kB 🟢 -6.03 kB
assets/useDeployToComfyApiDialog-Vv4g4Px1.js (new) — 23.3 kB 🔴 +23.3 kB 🔴 +6.78 kB 🔴 +6.03 kB
assets/RunOnCloudDialog-gYJxh0xg.js (new) — 11.7 kB 🔴 +11.7 kB 🔴 +3.47 kB 🔴 +3.11 kB
assets/RunOnCloudDialog-Le2CW2B8.js (removed) 11.7 kB — 🟢 -11.7 kB 🟢 -3.47 kB 🟢 -3.11 kB
assets/layerEditorDialog-ByTRX1EQ.js (new) — 7.97 kB 🔴 +7.97 kB 🔴 +3.81 kB 🔴 +3.23 kB
assets/layerEditorDialog-kN22CkRh.js (removed) 7.97 kB — 🟢 -7.97 kB 🟢 -3.81 kB 🟢 -3.24 kB
assets/useComfyHubPublishDialog-DeWJEpFL.js (removed) 6.66 kB — 🟢 -6.66 kB 🟢 -3.32 kB 🟢 -2.77 kB
assets/useComfyHubPublishDialog-DJplsVnu.js (new) — 6.66 kB 🔴 +6.66 kB 🔴 +3.32 kB 🔴 +2.76 kB
assets/usePaymentRecoveryDialog-DCIwWCYD.js (new) — 6.28 kB 🔴 +6.28 kB 🔴 +2.05 kB 🔴 +1.8 kB
assets/usePaymentRecoveryDialog-DjzGUsBa.js (removed) 6.28 kB — 🟢 -6.28 kB 🟢 -2.05 kB 🟢 -1.8 kB
assets/boundingBoxesDialog-CGNqEMad.js (removed) 4.69 kB — 🟢 -4.69 kB 🟢 -1.66 kB 🟢 -1.44 kB
assets/boundingBoxesDialog-D-p2a7J1.js (new) — 4.69 kB 🔴 +4.69 kB 🔴 +1.66 kB 🔴 +1.44 kB
assets/feedbackDialog-CQ9MwnuK.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.88 kB 🟢 -1.6 kB
assets/feedbackDialog-CZqODNYH.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.88 kB 🔴 +1.6 kB
assets/useSubscriptionDialog-DOnsVReg.js (removed) 4.16 kB — 🟢 -4.16 kB 🟢 -1.44 kB 🟢 -1.28 kB
assets/useSubscriptionDialog-YmD5_0aB.js (new) — 4.16 kB 🔴 +4.16 kB 🔴 +1.44 kB 🔴 +1.29 kB
assets/PlatformPlansLinkDialog-6w2qfxyJ.js (new) — 2.02 kB 🔴 +2.02 kB 🔴 +904 B 🔴 +785 B
assets/PlatformPlansLinkDialog-Dl5h5qQK.js (removed) 2.02 kB — 🟢 -2.02 kB 🟢 -902 B 🟢 -784 B
assets/useLayerEditor-C_XOifxS.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -552 B 🟢 -497 B
assets/useLayerEditor-C3o9QJoI.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +552 B 🔴 +497 B

Status: 13 added / 13 removed / 6 unchanged

UI Components — 374 kB (baseline 374 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-Brve6wKH.js (new) — 64.6 kB 🔴 +64.6 kB 🔴 +16.3 kB 🔴 +14.1 kB
assets/useMoreOptionsMenu-CVcwP3qL.js (removed) 64.6 kB — 🟢 -64.6 kB 🟢 -16.3 kB 🟢 -14.1 kB
assets/ComfyQueueButton-BkWs6xsf.js (removed) 13 kB — 🟢 -13 kB 🟢 -3.48 kB 🟢 -3.12 kB
assets/ComfyQueueButton-D4Ajdg7P.js (new) — 13 kB 🔴 +13 kB 🔴 +3.48 kB 🔴 +3.12 kB
assets/WorkflowNeedsDeploymentCard-b568pc6R.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +3.58 kB 🔴 +3.22 kB
assets/WorkflowNeedsDeploymentCard-CfZ8qCav.js (removed) 12.3 kB — 🟢 -12.3 kB 🟢 -3.58 kB 🟢 -3.22 kB
assets/AgentConsentCard-DBzCaUN-.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.48 kB 🟢 -3.09 kB
assets/AgentConsentCard-Ditt6meu.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.48 kB 🔴 +3.09 kB
assets/cloudFeedbackTopbarButton-BlxfhEFO.js (removed) 945 B — 🟢 -945 B 🟢 -442 B 🟢 -388 B
assets/cloudFeedbackTopbarButton-Ct75lRfo.js (new) — 945 B 🔴 +945 B 🔴 +444 B 🔴 +388 B
assets/ComfyQueueButton-BAX3M6m3.js (removed) 63 B — 🟢 -63 B 🟢 -83 B 🟢 -67 B
assets/ComfyQueueButton-ZrJnm8rF.js (new) — 63 B 🔴 +63 B 🔴 +83 B 🔴 +67 B

Status: 6 added / 6 removed / 28 unchanged

Data & Services — 2.01 MB (baseline 2.01 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/workflowService-CklIiEf_.js (new) — 39 kB 🔴 +39 kB 🔴 +10.5 kB 🔴 +9.23 kB
assets/workflowService-DhflHrrp.js (removed) 39 kB — 🟢 -39 kB 🟢 -10.5 kB 🟢 -9.23 kB
assets/agentConsentStore-ChqB_bk2.js (removed) 36.3 kB — 🟢 -36.3 kB 🟢 -9.01 kB 🟢 -8.03 kB
assets/agentConsentStore-D4Muaoy9.js (new) — 36.3 kB 🔴 +36.3 kB 🔴 +9.02 kB 🔴 +8.03 kB
assets/agentRunModeStore-BRrQ7yIE.js (removed) 34.3 kB — 🟢 -34.3 kB 🟢 -11.9 kB 🟢 -10.3 kB
assets/agentRunModeStore-BXuwWUa5.js (new) — 34.3 kB 🔴 +34.3 kB 🔴 +11.9 kB 🔴 +10.3 kB
assets/cloudWorkflowCheckStore-DJ56pcoO.js (new) — 23.8 kB 🔴 +23.8 kB 🔴 +7.75 kB 🔴 +6.77 kB
assets/cloudWorkflowCheckStore-ZUZ8Vkuq.js (removed) 23.8 kB — 🟢 -23.8 kB 🟢 -7.75 kB 🟢 -6.77 kB
assets/workflowShareService-ChB3OLvl.js (new) — 17.3 kB 🔴 +17.3 kB 🔴 +5.11 kB 🔴 +4.54 kB
assets/workflowShareService-DqM5kyx6.js (removed) 17.3 kB — 🟢 -17.3 kB 🟢 -5.12 kB 🟢 -4.55 kB
assets/workspaceStore-BjKWZmJm.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.97 kB 🟢 -3.54 kB
assets/workspaceStore-pDBNw0wq.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.97 kB 🔴 +3.53 kB
assets/load3dService-3r209kKa.js (removed) 9.3 kB — 🟢 -9.3 kB 🟢 -4.07 kB 🟢 -3.42 kB
assets/load3dService-DdGuDdHX.js (new) — 9.3 kB 🔴 +9.3 kB 🔴 +4.08 kB 🔴 +3.43 kB
assets/skillPacksStore-BUBaF681.js (new) — 8.83 kB 🔴 +8.83 kB 🔴 +2.73 kB 🔴 +2.36 kB
assets/skillPacksStore-CydmgWIb.js (removed) 8.83 kB — 🟢 -8.83 kB 🟢 -2.73 kB 🟢 -2.36 kB
assets/localBillingWebFlagStore-CHn5DhVd.js (removed) 2.75 kB — 🟢 -2.75 kB 🟢 -1.14 kB 🟢 -1.03 kB
assets/localBillingWebFlagStore-CtziNXV5.js (new) — 2.75 kB 🔴 +2.75 kB 🔴 +1.14 kB 🔴 +1.03 kB

Status: 9 added / 9 removed / 37 unchanged

Utilities & Hooks — 1.44 MB (baseline 1.44 MB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useBillingContext-i6IESFm8.js (removed) 452 kB — 🟢 -452 kB 🟢 -100 kB 🟢 -83.3 kB
assets/useBillingContext-OodO1h2d.js (new) — 452 kB 🔴 +452 kB 🔴 +100 kB 🔴 +83.4 kB
assets/useBillingDialogs-8M5P879i.js (removed) 184 kB — 🟢 -184 kB 🟢 -42.9 kB 🟢 -35.3 kB
assets/useBillingDialogs-yd5tIezK.js (new) — 184 kB 🔴 +184 kB 🔴 +42.9 kB 🔴 +35.4 kB
assets/assetFilterUtils-Db2T00aM.js (new) — 91.7 kB 🔴 +91.7 kB 🔴 +20.9 kB 🔴 +17.9 kB
assets/assetFilterUtils-DmBQ3peL.js (removed) 91.7 kB — 🟢 -91.7 kB 🟢 -20.9 kB 🟢 -17.9 kB
assets/useConflictDetection-CPD1F8cN.js (removed) 91.7 kB — 🟢 -91.7 kB 🟢 -23.4 kB 🟢 -20.3 kB
assets/useConflictDetection-DTG--15V.js (new) — 91.7 kB 🔴 +91.7 kB 🔴 +23.4 kB 🔴 +20.3 kB
assets/useLoad3d-g0JuXCS3.js (removed) 32.3 kB — 🟢 -32.3 kB 🟢 -7.46 kB 🟢 -6.67 kB
assets/useLoad3d-TrcV6_sJ.js (new) — 32.3 kB 🔴 +32.3 kB 🔴 +7.46 kB 🔴 +6.67 kB
assets/useBillingCapabilities-BzQDLvO2.js (removed) 29.2 kB — 🟢 -29.2 kB 🟢 -6.94 kB 🟢 -6.15 kB
assets/useBillingCapabilities-D3cpOOTb.js (new) — 29.2 kB 🔴 +29.2 kB 🔴 +6.94 kB 🔴 +6.16 kB
assets/useResubscribe-B4sHIzn1.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.69 kB 🟢 -5.04 kB
assets/useResubscribe-C74QeYnp.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.7 kB 🔴 +5.04 kB
assets/useVideoSourceUrl-2pkGuYGh.js (new) — 19 kB 🔴 +19 kB 🔴 +5.63 kB 🔴 +5.01 kB
assets/useVideoSourceUrl-DdaJu9ax.js (removed) 19 kB — 🟢 -19 kB 🟢 -5.63 kB 🟢 -5.02 kB
assets/useAgentConsent-CqobnsEF.js (new) — 15.9 kB 🔴 +15.9 kB 🔴 +5.16 kB 🔴 +4.41 kB
assets/useAgentConsent-DlG7aMPT.js (removed) 15.9 kB — 🟢 -15.9 kB 🟢 -5.16 kB 🟢 -4.42 kB
assets/useImageCrop-DDkWAN2Z.js (removed) 15.5 kB — 🟢 -15.5 kB 🟢 -3.63 kB 🟢 -3.18 kB
assets/useImageCrop-XDaMwTSt.js (new) — 15.5 kB 🔴 +15.5 kB 🔴 +3.63 kB 🔴 +3.17 kB
assets/useDowngradeToPersonal-_13kFhcO.js (new) — 13.2 kB 🔴 +13.2 kB 🔴 +3.02 kB 🔴 +2.61 kB
assets/useDowngradeToPersonal-1s7cZB-y.js (removed) 13.2 kB — 🟢 -13.2 kB 🟢 -3.02 kB 🟢 -2.62 kB
assets/useWorkspaceDialogs-DfvQrd1A.js (removed) 12.9 kB — 🟢 -12.9 kB 🟢 -3.28 kB 🟢 -2.84 kB
assets/useWorkspaceDialogs-DPNWV-J_.js (new) — 12.9 kB 🔴 +12.9 kB 🔴 +3.28 kB 🔴 +2.85 kB
assets/useCreditsCardCopy-Bv_IbdKC.js (removed) 6.18 kB — 🟢 -6.18 kB 🟢 -2.02 kB 🟢 -1.78 kB
assets/useCreditsCardCopy-DJ618pyP.js (new) — 6.18 kB 🔴 +6.18 kB 🔴 +2.02 kB 🔴 +1.78 kB
assets/usePricingTableUrlLoader-bSWA2p1r.js (new) — 5.3 kB 🔴 +5.3 kB 🔴 +1.63 kB 🔴 +1.44 kB
assets/usePricingTableUrlLoader-DZdjQYMa.js (removed) 5.3 kB — 🟢 -5.3 kB 🟢 -1.64 kB 🟢 -1.43 kB
assets/usePartnerNodesRunGate-B04ONhBh.js (new) — 5.21 kB 🔴 +5.21 kB 🔴 +2.03 kB 🔴 +1.77 kB
assets/usePartnerNodesRunGate-DkI2mLrT.js (removed) 5.21 kB — 🟢 -5.21 kB 🟢 -2.03 kB 🟢 -1.77 kB
assets/useCurrentUser-Bql_jBjs.js (new) — 3.96 kB 🔴 +3.96 kB 🔴 +1.17 kB 🔴 +1.02 kB
assets/useCurrentUser-BvvIiySc.js (removed) 3.96 kB — 🟢 -3.96 kB 🟢 -1.17 kB 🟢 -1.02 kB
assets/useRunButtonTelemetry-5bazXcgQ.js (new) — 3.36 kB 🔴 +3.36 kB 🔴 +1.39 kB 🔴 +1.2 kB
assets/useRunButtonTelemetry-DvAGMWRg.js (removed) 3.36 kB — 🟢 -3.36 kB 🟢 -1.39 kB 🟢 -1.2 kB
assets/useSocialSignIn-BjtIzLfH.js (removed) 3.09 kB — 🟢 -3.09 kB 🟢 -1.33 kB 🟢 -1.14 kB
assets/useSocialSignIn-DjPGwRXk.js (new) — 3.09 kB 🔴 +3.09 kB 🔴 +1.33 kB 🔴 +1.14 kB
assets/useCompositorLayers-CrDdu5QM.js (removed) 2.98 kB — 🟢 -2.98 kB 🟢 -881 B 🟢 -804 B
assets/useCompositorLayers-FtYHDepz.js (new) — 2.98 kB 🔴 +2.98 kB 🔴 +880 B 🔴 +807 B
assets/useScheduledPlanChange-Bcghstx7.js (removed) 2.4 kB — 🟢 -2.4 kB 🟢 -957 B 🟢 -831 B
assets/useScheduledPlanChange-BWVX7Zc3.js (new) — 2.4 kB 🔴 +2.4 kB 🔴 +958 B 🔴 +833 B
assets/useBillingUI-BtYFc1bl.js (new) — 2.16 kB 🔴 +2.16 kB 🔴 +742 B 🔴 +650 B
assets/useBillingUI-HlNw7-4w.js (removed) 2.16 kB — 🟢 -2.16 kB 🟢 -743 B 🟢 -652 B
assets/useSubscriptionPaywall-Ce1aDi07.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -567 B 🟢 -487 B
assets/useSubscriptionPaywall-hLFh_iYa.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +565 B 🔴 +477 B
assets/useAutoTopUpCardViewed-C6valib7.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +604 B 🔴 +518 B
assets/useAutoTopUpCardViewed-DyESgplu.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -605 B 🟢 -517 B
assets/useLiveGraphNode-Drc5Cb9x.js (removed) 633 B — 🟢 -633 B 🟢 -369 B 🟢 -333 B
assets/useLiveGraphNode-DXLPMZKF.js (new) — 633 B 🔴 +633 B 🔴 +368 B 🔴 +330 B
assets/useWidgetHostNode-Dq3AxQns.js (new) — 599 B 🔴 +599 B 🔴 +355 B 🔴 +317 B
assets/useWidgetHostNode-itd6dTNt.js (removed) 599 B — 🟢 -599 B 🟢 -357 B 🟢 -317 B
assets/useLoad3d-D8Syxt-9.js (removed) 215 B — 🟢 -215 B 🟢 -149 B 🟢 -129 B
assets/useLoad3d-u6_8BJWw.js (new) — 215 B 🔴 +215 B 🔴 +149 B 🔴 +130 B
assets/useCurrentUser-DNq_lWIY.js (new) — 68 B 🔴 +68 B 🔴 +76 B 🔴 +72 B
assets/useCurrentUser-DPxIVHKa.js (removed) 68 B — 🟢 -68 B 🟢 -76 B 🟢 -69 B

Status: 27 added / 27 removed / 59 unchanged

Vendor & Third-Party — 9.7 MB (baseline 9.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 36.6 MB (baseline 36.6 MB) • ⚪ 0 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/AgentPanelRoot-B7Czu1w0.js (removed) 782 kB — 🟢 -782 kB 🟢 -190 kB 🟢 -151 kB
assets/AgentPanelRoot-CGupC0IV.js (new) — 782 kB 🔴 +782 kB 🔴 +190 kB 🔴 +151 kB
assets/app-BbOrNRmF.js (new) — 463 kB 🔴 +463 kB 🔴 +123 kB 🔴 +99.9 kB
assets/app-D6UVV0me.js (removed) 463 kB — 🟢 -463 kB 🟢 -123 kB 🟢 -99.9 kB
assets/compositorSession-BMV0s45X.js (new) — 158 kB 🔴 +158 kB 🔴 +40.8 kB 🔴 +34.5 kB
assets/compositorSession-CIM_S1eW.js (removed) 158 kB — 🟢 -158 kB 🟢 -40.8 kB 🟢 -34.5 kB
assets/core-5EDDkIpt.js (removed) 155 kB — 🟢 -155 kB 🟢 -40.5 kB 🟢 -33.6 kB
assets/core-CsMyTl7f.js (new) — 155 kB 🔴 +155 kB 🔴 +40.5 kB 🔴 +33.6 kB
assets/PricingTierHeading-C_9o7k5m.js (removed) 139 kB — 🟢 -139 kB 🟢 -29.8 kB 🟢 -24.8 kB
assets/PricingTierHeading-Cddoc-4T.js (new) — 139 kB 🔴 +139 kB 🔴 +29.7 kB 🔴 +24.8 kB
assets/WorkspaceSettingsPanelContent-Bc3dEDht.js (removed) 107 kB — 🟢 -107 kB 🟢 -21.4 kB 🟢 -18.3 kB
assets/WorkspaceSettingsPanelContent-BoQX8X8J.js (new) — 107 kB 🔴 +107 kB 🔴 +21.4 kB 🔴 +18.2 kB
assets/BillingTab-BVFpIFPd.js (removed) 95.2 kB — 🟢 -95.2 kB 🟢 -20.4 kB 🟢 -17.5 kB
assets/BillingTab-D3Uj5q1y.js (new) — 95.2 kB 🔴 +95.2 kB 🔴 +20.4 kB 🔴 +17.5 kB
assets/BillingTabLegacy-ADepYhh5.js (removed) 93.2 kB — 🟢 -93.2 kB 🟢 -19 kB 🟢 -16.1 kB
assets/BillingTabLegacy-aWucwXuz.js (new) — 93.2 kB 🔴 +93.2 kB 🔴 +19 kB 🔴 +16.1 kB
assets/WidgetSelect-CAkMtn-i.js (removed) 89.6 kB — 🟢 -89.6 kB 🟢 -20.5 kB 🟢 -17.5 kB
assets/WidgetSelect-X2CfDhI6.js (new) — 89.6 kB 🔴 +89.6 kB 🔴 +20.5 kB 🔴 +17.5 kB
assets/main-BTwFojNV.js (removed) 88.5 kB — 🟢 -88.5 kB 🟢 -26.9 kB 🟢 -22.5 kB
assets/main-iaEkyAGU.js (new) — 88.5 kB 🔴 +88.5 kB 🔴 +26.9 kB 🔴 +22.5 kB
assets/Load3D-Bbs6MG1E.js (removed) 84.2 kB — 🟢 -84.2 kB 🟢 -13.9 kB 🟢 -11.7 kB
assets/Load3D-KlhS1jLx.js (new) — 84.2 kB 🔴 +84.2 kB 🔴 +13.9 kB 🔴 +11.7 kB
assets/firstRunEntry-BuLTOeYj.js (new) — 62.9 kB 🔴 +62.9 kB 🔴 +17.5 kB 🔴 +15.1 kB
assets/firstRunEntry-mlragLlZ.js (removed) 62.9 kB — 🟢 -62.9 kB 🟢 -17.5 kB 🟢 -15.1 kB
assets/WidgetVideoEdit-95RDm5Yk.js (removed) 56.8 kB — 🟢 -56.8 kB 🟢 -12.9 kB 🟢 -11.5 kB
assets/WidgetVideoEdit-CVSSMOAE.js (new) — 56.8 kB 🔴 +56.8 kB 🔴 +12.9 kB 🔴 +11.5 kB
assets/SubscriptionRequiredDialogContentUnified-BcUMUcE6.js (new) — 51.5 kB 🔴 +51.5 kB 🔴 +11.7 kB 🔴 +10.2 kB
assets/SubscriptionRequiredDialogContentUnified-D2rC4Et2.js (removed) 51.5 kB — 🟢 -51.5 kB 🟢 -11.7 kB 🟢 -10.2 kB
assets/restoreOpMinter-0Am_U3li.js (new) — 48.1 kB 🔴 +48.1 kB 🔴 +13.2 kB 🔴 +11.6 kB
assets/restoreOpMinter-wU5YgVU_.js (removed) 48.1 kB — 🟢 -48.1 kB 🟢 -13.2 kB 🟢 -11.6 kB
assets/LayerEditorContent-BDafESQo.js (new) — 44.7 kB 🔴 +44.7 kB 🔴 +10.5 kB 🔴 +9.24 kB
assets/LayerEditorContent-Cfx_pxQO.js (removed) 44.7 kB — 🟢 -44.7 kB 🟢 -10.5 kB 🟢 -9.26 kB
assets/LightInfo-Cai8vPtt.js (new) — 43.8 kB 🔴 +43.8 kB 🔴 +11 kB 🔴 +9.79 kB
assets/LightInfo-DdMrEH5S.js (removed) 43.8 kB — 🟢 -43.8 kB 🟢 -11 kB 🟢 -9.79 kB
assets/CameraInfo-CJLs-qv9.js (removed) 42 kB — 🟢 -42 kB 🟢 -10.2 kB 🟢 -9.01 kB
assets/CameraInfo-DJdYvQtJ.js (new) — 42 kB 🔴 +42 kB 🔴 +10.2 kB 🔴 +9.01 kB
assets/WidgetPainter-CAG4vurN.js (new) — 41.8 kB 🔴 +41.8 kB 🔴 +10.5 kB 🔴 +9.29 kB
assets/WidgetPainter-PAGtvEGg.js (removed) 41.8 kB — 🟢 -41.8 kB 🟢 -10.5 kB 🟢 -9.27 kB
assets/floating-ui.vue-DSJCyQhZ.js (removed) 36.9 kB — 🟢 -36.9 kB 🟢 -10.5 kB 🟢 -9.24 kB
assets/floating-ui.vue-tsc2-6E0.js (new) — 36.9 kB 🔴 +36.9 kB 🔴 +10.5 kB 🔴 +9.24 kB
assets/Load3dViewerContent-Cp0NXSmJ.js (removed) 31.1 kB — 🟢 -31.1 kB 🟢 -6.18 kB 🟢 -5.38 kB
assets/Load3dViewerContent-DL3ECT-J.js (new) — 31.1 kB 🔴 +31.1 kB 🔴 +6.18 kB 🔴 +5.37 kB
assets/WidgetVideoConcat-C0cDwvXQ.js (removed) 29.3 kB — 🟢 -29.3 kB 🟢 -8.15 kB 🟢 -7.27 kB
assets/WidgetVideoConcat-SjRHmzac.js (new) — 29.3 kB 🔴 +29.3 kB 🔴 +8.15 kB 🔴 +7.26 kB
assets/CameraAngle-D1vFTBiL.js (removed) 27.8 kB — 🟢 -27.8 kB 🟢 -8.05 kB 🟢 -7.12 kB
assets/CameraAngle-pN2DTjcO.js (new) — 27.8 kB 🔴 +27.8 kB 🔴 +8.05 kB 🔴 +7.12 kB
assets/CancellationFlowDialogContent-BLUu6_hN.js (removed) 26.2 kB — 🟢 -26.2 kB 🟢 -6.27 kB 🟢 -5.52 kB
assets/CancellationFlowDialogContent-PkwO-ILs.js (new) — 26.2 kB 🔴 +26.2 kB 🔴 +6.27 kB 🔴 +5.53 kB
assets/ShareAssetWarningBox-CHczm1Ol.js (new) — 25.6 kB 🔴 +25.6 kB 🔴 +7.65 kB 🔴 +6.55 kB
assets/ShareAssetWarningBox-xV-zhe0m.js (removed) 25.6 kB — 🟢 -25.6 kB 🟢 -7.66 kB 🟢 -6.54 kB
assets/SubscriptionRequiredDialogContentWorkspace-D_AdG0_H.js (removed) 25.1 kB — 🟢 -25.1 kB 🟢 -5.9 kB 🟢 -5.18 kB
assets/SubscriptionRequiredDialogContentWorkspace-lgZuZRyD.js (new) — 25.1 kB 🔴 +25.1 kB 🔴 +5.9 kB 🔴 +5.19 kB
assets/openWorkflowForCheck-B386IuGE.js (new) — 23 kB 🔴 +23 kB 🔴 +7.01 kB 🔴 +6.24 kB
assets/openWorkflowForCheck-B9g3TGDW.js (removed) 23 kB — 🟢 -23 kB 🟢 -7.01 kB 🟢 -6.22 kB
assets/ui-BWLrMXb-.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -6.1 kB 🟢 -5.27 kB
assets/ui-Dnyto7Qu.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +6.1 kB 🔴 +5.28 kB
assets/SignInContent-iDsDdSwg.js (new) — 21.1 kB 🔴 +21.1 kB 🔴 +4.91 kB 🔴 +4.32 kB
assets/SignInContent-QHTOdUjH.js (removed) 21.1 kB — 🟢 -21.1 kB 🟢 -4.91 kB 🟢 -4.32 kB
assets/BillingStatusBanner-BhVx49ID.js (removed) 16.9 kB — 🟢 -16.9 kB 🟢 -4.4 kB 🟢 -3.94 kB
assets/BillingStatusBanner-CuWNMcoN.js (new) — 16.9 kB 🔴 +16.9 kB 🔴 +4.4 kB 🔴 +3.93 kB
assets/WidgetRecordAudio-Cw7p7t5g.js (new) — 16.1 kB 🔴 +16.1 kB 🔴 +4.5 kB 🔴 +4.05 kB
assets/WidgetRecordAudio-DLlGazR7.js (removed) 16.1 kB — 🟢 -16.1 kB 🟢 -4.5 kB 🟢 -4.05 kB
assets/CancelSubscriptionDialogContent-1sD6OH_U.js (new) — 15.1 kB 🔴 +15.1 kB 🔴 +4.1 kB 🔴 +3.66 kB
assets/CancelSubscriptionDialogContent-BZWDfc2Z.js (removed) 15.1 kB — 🟢 -15.1 kB 🟢 -4.1 kB 🟢 -3.65 kB
assets/WidgetRange-B6F7jkVg.js (removed) 14.9 kB — 🟢 -14.9 kB 🟢 -3.92 kB 🟢 -3.46 kB
assets/WidgetRange-BMru4sXA.js (new) — 14.9 kB 🔴 +14.9 kB 🔴 +3.92 kB 🔴 +3.47 kB
assets/load3d-B0AdfcLq.js (new) — 14.9 kB 🔴 +14.9 kB 🔴 +3.7 kB 🔴 +3.23 kB
assets/load3d-BJp7h4gL.js (removed) 14.9 kB — 🟢 -14.9 kB 🟢 -3.7 kB 🟢 -3.25 kB
assets/BillingStatusBanner-D3rCAAGG.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.56 kB 🟢 -3.17 kB
assets/BillingStatusBanner-DhGfpSx_.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.56 kB 🔴 +3.18 kB
assets/onboardingCloudRoutes-BygsNhNq.js (new) — 13.1 kB 🔴 +13.1 kB 🔴 +4.22 kB 🔴 +3.6 kB
assets/onboardingCloudRoutes-qMPymcn0.js (removed) 13.1 kB — 🟢 -13.1 kB 🟢 -4.22 kB 🟢 -3.61 kB
assets/WidgetCurve-B_7zHDV0.js (removed) 12.4 kB — 🟢 -12.4 kB 🟢 -3.85 kB 🟢 -3.49 kB
assets/WidgetCurve-BuB_6Au9.js (new) — 12.4 kB 🔴 +12.4 kB 🔴 +3.84 kB 🔴 +3.49 kB
assets/WidgetTextarea-BeCSLRvY.js (removed) 12.1 kB — 🟢 -12.1 kB 🟢 -3.77 kB 🟢 -3.35 kB
assets/WidgetTextarea-Cu3B_ke8.js (new) — 12.1 kB 🔴 +12.1 kB 🔴 +3.77 kB 🔴 +3.35 kB
assets/createViewport3d-7thSeZQl.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.53 kB 🟢 -3.19 kB
assets/createViewport3d-D3092Zf6.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.53 kB 🔴 +3.18 kB
assets/nodeTemplates-Bq8C9EEG.js (new) — 10.6 kB 🔴 +10.6 kB 🔴 +3.44 kB 🔴 +3.02 kB
assets/nodeTemplates-DRwEHJUU.js (removed) 10.6 kB — 🟢 -10.6 kB 🟢 -3.44 kB 🟢 -3.01 kB
assets/WidgetImageCrop-BhUCvbsf.js (removed) 9.46 kB — 🟢 -9.46 kB 🟢 -2.94 kB 🟢 -2.62 kB
assets/WidgetImageCrop-Cra82Vmg.js (new) — 9.46 kB 🔴 +9.46 kB 🔴 +2.94 kB 🔴 +2.61 kB
assets/Load3DConfiguration-CqVY7eFT.js (new) — 9.2 kB 🔴 +9.2 kB 🔴 +2.83 kB 🔴 +2.5 kB
assets/Load3DConfiguration-zD-O90u4.js (removed) 9.2 kB — 🟢 -9.2 kB 🟢 -2.83 kB 🟢 -2.49 kB
assets/InviteMemberDialogContent-C83U26RZ.js (removed) 9.1 kB — 🟢 -9.1 kB 🟢 -2.69 kB 🟢 -2.44 kB
assets/InviteMemberDialogContent-DOXr9GKL.js (new) — 9.1 kB 🔴 +9.1 kB 🔴 +2.69 kB 🔴 +2.44 kB
assets/WidgetImageCompare-BbEEE21V.js (removed) 8.87 kB — 🟢 -8.87 kB 🟢 -2.61 kB 🟢 -2.32 kB
assets/WidgetImageCompare-Cf9RCOPw.js (new) — 8.87 kB 🔴 +8.87 kB 🔴 +2.62 kB 🔴 +2.32 kB
assets/LayoutDefault-B6jrw52P.js (removed) 8.8 kB — 🟢 -8.8 kB 🟢 -2.57 kB 🟢 -2.27 kB
assets/LayoutDefault-Urrq2alq.js (new) — 8.8 kB 🔴 +8.8 kB 🔴 +2.57 kB 🔴 +2.27 kB
assets/async-B2Tm60GR.js (removed) 8.21 kB — 🟢 -8.21 kB 🟢 -3.32 kB 🟢 -2.82 kB
assets/async-B3wstMC_.js (new) — 8.21 kB 🔴 +8.21 kB 🔴 +3.32 kB 🔴 +2.82 kB
assets/WidgetBoundingBoxes-Do6_xgkL.js (new) — 7.45 kB 🔴 +7.45 kB 🔴 +3.69 kB 🔴 +3.09 kB
assets/WidgetBoundingBoxes-TuhRR2yZ.js (removed) 7.45 kB — 🟢 -7.45 kB 🟢 -3.69 kB 🟢 -3.09 kB
assets/load3dPreviewExtensions-BTqu5iJz.js (new) — 6.49 kB 🔴 +6.49 kB 🔴 +1.89 kB 🔴 +1.68 kB
assets/load3dPreviewExtensions-CQ2pjAaB.js (removed) 6.49 kB — 🟢 -6.49 kB 🟢 -1.89 kB 🟢 -1.68 kB
assets/openPlatformPlans-BwZaTYNL.js (new) — 6.11 kB 🔴 +6.11 kB 🔴 +2.46 kB 🔴 +2.07 kB
assets/openPlatformPlans-ilXNnYeh.js (removed) 6.11 kB — 🟢 -6.11 kB 🟢 -2.47 kB 🟢 -2.07 kB
assets/WidgetBoundingBox-BPKKAx6o.js (new) — 4.63 kB 🔴 +4.63 kB 🔴 +1.43 kB 🔴 +1.27 kB
assets/WidgetBoundingBox-CXv_10Iu.js (removed) 4.63 kB — 🟢 -4.63 kB 🟢 -1.43 kB 🟢 -1.27 kB
assets/SubscribeToRun-DDB-vlM2.js (new) — 4.21 kB 🔴 +4.21 kB 🔴 +1.66 kB 🔴 +1.45 kB
assets/SubscribeToRun-pJjxBeBc.js (removed) 4.21 kB — 🟢 -4.21 kB 🟢 -1.67 kB 🟢 -1.46 kB
assets/saveMesh-BeRcTIwP.js (removed) 3.41 kB — 🟢 -3.41 kB 🟢 -1.08 kB 🟢 -945 B
assets/saveMesh-CyoDiJLz.js (new) — 3.41 kB 🔴 +3.41 kB 🔴 +1.07 kB 🔴 +946 B
assets/launchCancellationFlow-BpqZNNaa.js (new) — 3.31 kB 🔴 +3.31 kB 🔴 +1.14 kB 🔴 +1.01 kB
assets/launchCancellationFlow-CdnBrU5C.js (removed) 3.31 kB — 🟢 -3.31 kB 🟢 -1.15 kB 🟢 -1.01 kB
assets/CloudRunButtonWrapper-Blzb8Egv.js (new) — 2.84 kB 🔴 +2.84 kB 🔴 +1.02 kB 🔴 +909 B
assets/CloudRunButtonWrapper-DWBv0tkB.js (removed) 2.84 kB — 🟢 -2.84 kB 🟢 -1.02 kB 🟢 -912 B
assets/InviteMemberUpsellDialogContent-BL1lCgzy.js (new) — 2.7 kB 🔴 +2.7 kB 🔴 +948 B 🔴 +842 B
assets/InviteMemberUpsellDialogContent-CEvj0v2a.js (removed) 2.7 kB — 🟢 -2.7 kB 🟢 -949 B 🟢 -842 B
assets/WidgetColors-B-W0m2Mp.js (new) — 2.62 kB 🔴 +2.62 kB 🔴 +1.13 kB 🔴 +1.01 kB
assets/WidgetColors-BcGOvqct.js (removed) 2.62 kB — 🟢 -2.62 kB 🟢 -1.13 kB 🟢 -1.01 kB
assets/widgetHistoryScope-D42YLaPl.js (removed) 2.6 kB — 🟢 -2.6 kB 🟢 -1 kB 🟢 -899 B
assets/widgetHistoryScope-LiTpD6xv.js (new) — 2.6 kB 🔴 +2.6 kB 🔴 +1 kB 🔴 +900 B
assets/LocalRunButtonWrapper-ByFD9hAV.js (removed) 2.32 kB — 🟢 -2.32 kB 🟢 -1.05 kB 🟢 -931 B
assets/LocalRunButtonWrapper-Cj2kECnK.js (new) — 2.32 kB 🔴 +2.32 kB 🔴 +1.05 kB 🔴 +938 B
assets/load3dAdvanced-GUfD_LTN.js (removed) 2.18 kB — 🟢 -2.18 kB 🟢 -853 B 🟢 -748 B
assets/load3dAdvanced-p7r2C0HK.js (new) — 2.18 kB 🔴 +2.18 kB 🔴 +852 B 🔴 +749 B
assets/feedback-CdVVzytt.js (new) — 1.73 kB 🔴 +1.73 kB 🔴 +734 B 🔴 +653 B
assets/feedback-xtv06v1k.js (removed) 1.73 kB — 🟢 -1.73 kB 🟢 -732 B 🟢 -654 B
assets/widgetInputSource-BGTE5acF.js (new) — 1.44 kB 🔴 +1.44 kB 🔴 +602 B 🔴 +520 B
assets/widgetInputSource-Tu1aa0Qb.js (removed) 1.44 kB — 🟢 -1.44 kB 🟢 -603 B 🟢 -521 B
assets/Load3DAdvanced-Bd44CDcm.js (removed) 750 B — 🟢 -750 B 🟢 -422 B 🟢 -353 B
assets/Load3DAdvanced-BR47A4Ao.js (new) — 750 B 🔴 +750 B 🔴 +422 B 🔴 +353 B
assets/savedImageUrls-DGxjNG-i.js (removed) 719 B — 🟢 -719 B 🟢 -427 B 🟢 -374 B
assets/savedImageUrls-gysyq21u.js (new) — 719 B 🔴 +719 B 🔴 +426 B 🔴 +372 B
assets/launchCancellationFlow-B-rIE6TD.js (removed) 115 B — 🟢 -115 B 🟢 -107 B 🟢 -100 B
assets/launchCancellationFlow-DEcW3C0_.js (new) — 115 B 🔴 +115 B 🔴 +107 B 🔴 +98 B
assets/CancelSubscriptionDialogContent-5kANKXMS.js (removed) 78 B — 🟢 -78 B 🟢 -98 B 🟢 -74 B
assets/CancelSubscriptionDialogContent-Uiv8nXfC.js (new) — 78 B 🔴 +78 B 🔴 +98 B 🔴 +76 B
assets/Load3dViewerContent-5OvaKo8G.js (removed) 66 B — 🟢 -66 B 🟢 -86 B 🟢 -70 B
assets/Load3dViewerContent-CRatFV8P.js (new) — 66 B 🔴 +66 B 🔴 +86 B 🔴 +70 B
assets/WidgetBoundingBox-C5fUIZfq.js (new) — 64 B 🔴 +64 B 🔴 +84 B 🔴 +68 B
assets/WidgetBoundingBox-CbyTaz1Q.js (removed) 64 B — 🟢 -64 B 🟢 -84 B 🟢 -68 B
assets/LayoutDefault-DoNPrckm.js (new) — 60 B 🔴 +60 B 🔴 +76 B 🔴 +63 B
assets/LayoutDefault-jmo2WfdU.js (removed) 60 B — 🟢 -60 B 🟢 -76 B 🟢 -64 B
assets/Load3D-C2yRzlY2.js (removed) 53 B — 🟢 -53 B 🟢 -73 B 🟢 -57 B
assets/Load3D-C7zlcxPP.js (new) — 53 B 🔴 +53 B 🔴 +73 B 🔴 +57 B

Status: 69 added / 69 removed / 699 unchanged

⚡ Performance: ⏳ Performance tests in progress…

🎭 Playwright: ✅ 3329 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 867 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 17 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 20 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

❌ Browser reports are missing. Open the workflow run, fix report generation or deployment and re-run the job.

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/16/2026, 09:55:24 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 1baae5f1cfdc5bbf2502066e1b5f842568effb87

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (518)

  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/generated/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/generated/types.gen.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 468 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The auth store now clears an existing stored API key when a Cloud Firebase user signs out. Tests cover initial signed-out state, non-Cloud sign-out, and auth header requests after Cloud sign-out.

Changes: Cloud sign-out API key handling

Layer / File(s) Summary
Clear stored API keys on Cloud sign-out
src/stores/authStore.ts, src/stores/authStore.test.ts, src/stores/__tests__/authTokenPriority.test.ts
A synchronous watcher clears an existing stored API key when a Cloud user changes from signed in to signed out. Tests verify that an initially signed-out user and a non-Cloud sign-out do not clear the key, and that generic and workspace auth headers return no credential after Cloud sign-out.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: christian-byrne, drjkl, vqt123

Merge Risk: Minimal · up to e338e

On Cloud, when a Firebase user is replaced by none, the stored API key is now removed, so later requests no longer reuse a key from another account. The key is kept when the first Firebase state is signed out, when one user switches to another, and off Cloud. No unresolved defects remain, so the change looks safe to merge.

Pre-merge checks: Passed 5 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
End-To-End Test Suggestion For User-Facing Changes Warning This is a suggestion, not a merge requirement. Check result: the check fails. All three failure conditions hold, judged from the PR title, the changed-file list, and the diff summary. 1. **Fix in … Consider adding a Playwright spec under browser_tests/, or extending authAccountSwitch.spec.ts with a unified-auth-on case. The spec should cover the trigger above: Firebase ends the Cloud sign-in while a stored API key for another acco…
Passed Passed checks: 5 passed

Check name Status Explanation
Title check Passed The title names the main change: a stored API key is dropped when Firebase ends the sign-in on Cloud. It matches the raw summary, which describes a synchronous currentUser watcher that clears the stor…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the repository template closely. It has a Summary section that explains the problem (Firebase ends a Cloud sign-in on its own, and a stored API key for another account then ans…
Adr Compliance For Entity/Litegraph Changes Passed The check applies only when the PR changes files under src/lib/litegraph/ or src/ecs/, or files related to graph entities (nodes, links, widgets, slots, reroutes, groups, subgraphs). The changed-f…
Full details: Title check

Explanation

The title names the main change: a stored API key is dropped when Firebase ends the sign-in on Cloud. It matches the raw summary, which describes a synchronous currentUser watcher that clears the stored key on Cloud when a Firebase user is replaced by none. The title is specific and concise, and it follows the conventional commit style.

Full details: Description check

Explanation

The description follows the repository template closely. It has a Summary section that explains the problem (Firebase ends a Cloud sign-in on its own, and a stored API key for another account then answers later requests), the root cause, the fix, and the design decisions and known limits. It has a Verification section with red and green test runs, the commands used, the hook checks, and the test gaps (no browser spec for mid-session invalidation, no run against a real Cloud backend or real Firebase invalidation). It also lists a related follow-up that is out of scope. The Summary has no 'Fixes #ISSUE_NUMBER' line, but the template marks that line as optional, and the description links the related PRs. The After release section is absent, which is acceptable because the template says to include only what applies.

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The check applies only when the PR changes files under src/lib/litegraph/ or src/ecs/, or files related to graph entities (nodes, links, widgets, slots, reroutes, groups, subgraphs). The changed-file list in the review context contains three files, all in the auth domain: - src/stores/authStore.ts: adds a synchronous watcher on currentUser that clears a stored API key when a Cloud Firebase user signs out. - src/stores/authStore.test.ts: adds one test. - src/stores/__tests__/authTokenPriority.test.ts: adds unified Cloud auth tests. None of these paths are under the litegraph or ECS trees, and none relate to graph entities. The check is therefore not applicable. Per the check's own rule, it passes immediately. I used only the PR metadata and the summary's changed-file list, as the check instructs. No shell commands were run. The PR's primary author is dante01yoon. The author does not affect this check.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

This is a suggestion, not a merge requirement. Check result: the check fails. All three failure conditions hold, judged from the PR title, the changed-file list, and the diff summary. 1. Fix in src/. The title is fix(auth): drop a stored API key when Firebase ends the sign-in on Cloud. The changed files are src/stores/authStore.ts (+13, a new synchronous watcher on currentUser), src/stores/authStore.test.ts, and src/stores/__tests__/authTokenPriority.test.ts. The diff summary confirms a behavior fix in the main frontend. The watcher clears a stored API key when a Cloud Firebase user is replaced by none. 2. Describable user-visible trigger. A Cloud user is signed in to Firebase as account A. The browser also holds an API key stored earlier for account B. Firebase then ends A's sign-in, for example because the account was disabled or its refresh token expired. After that, requests authenticate as B. The PR description says the tab keeps sending B's key. This is a real session event, not a contrived fixture or internal state. 3. No browser spec. The changed-file list has no file under browser_tests/. The PR description says a browser spec for mid-session Firebase invalidation was "Not added." It also names authAccountSwitch.spec.ts as the nearest spec. That spec runs with unified auth off, so it does not cover this path. Suggested test. A Playwright spec could cover this bug. The changed files do not point to an existing browser spec. The nearest existing spec is authAccountSwitch.spec.ts, as named in the PR description. Extending it would need a unified-auth-on variant. A new spec is also acceptable. Feature or trigger: a Cloud session with a Firebase user A and a stored API key for account B, where Firebase ends A's sign-in on its own. Test outline: - Enable Cloud mode with unified auth on. - Sign in to Firebase as account A. - Store an API key for account B in browser storage. - Make Firebase end account A's sign-in without a user action. - Expect the "API key cleared" toast to appear. - Expect the stored API key to be absent from browser storage. - Send a general API request and expect no X-API-KEY header. - Send a workspace API request and expect no credential header. - Reload the page and expect the signed-out state. Control case, as a separate test: - Start a session with no Firebase user and a stored API key. - Send a general API request and expect the X-API-KEY header to carry the stored key.

Resolution

Consider adding a Playwright spec under browser_tests/, or extending authAccountSwitch.spec.ts with a unified-auth-on case. The spec should cover the trigger above: Firebase ends the Cloud sign-in while a stored API key for another account exists. Follow the test outline in the explanation. This is a suggestion only. It is not a merge requirement.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1baae5f and e338e25.

Files selected for processing: 3

  • src/stores/__tests__/authTokenPriority.test.ts
  • src/stores/authStore.test.ts
  • src/stores/authStore.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Nov 16, 2026
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #23500      +/-   ##
==========================================
- Coverage   88.02%   87.94%   -0.08%     
==========================================
  Files        3173     3061     -112     
  Lines      169943   166309    -3634     
  Branches    45873    44648    -1225     
==========================================
- Hits       149592   146267    -3325     
+ Misses      19379    19239     -140     
+ Partials      972      803     -169     
Flag Coverage Δ
billing-web-unit ?
e2e 59.01% <100.00%> (-0.01%) ⬇️
unit 87.48% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/authStore.ts 99.04% <100.00%> (+0.01%) ⬆️

... and 137 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vqt123

vqt123 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Starting review at e338e25.

@vqt123

vqt123 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Approving at e338e25.

Clean: Correctness, Resilience, Access, Words, Contract, Vendor, Rollout, Rules, Cause.

Not covered: Access/Vendor - real Firebase invalidation with an older stored key, followed by reload (Cloud staging read). Related browser command: pnpm exec playwright test browser_tests/tests/authAccountSwitch.spec.ts --project=cloud; the existing spec does not seed the older key.

Checked: read, not run: the Cloud identity transition at src/stores/authStore.ts:252; synchronous key removal at src/stores/apiKeyAuthStore.ts:155; both credential fallbacks against the merge base; Firebase's invalidation/sign-out implementation and identity adapter.

~1.2M effective tokens for this review (7.0M raw; cache reads weighted 0.1x, cache writes 1.25-2x)

@dante01yoon
dante01yoon added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 103d6a8 Nov 16, 2026
108 checks passed
@dante01yoon
dante01yoon deleted the auth/drop-dormant-api-key-when-sign-in-ends branch November 16, 2026 22:45
dante01yoon added a commit that referenced this pull request Nov 16, 2026
…nds the sign-in on Cloud (#23500)

Follow-up to the #22541 backport on this branch. Applied without conflict;
every added line is the one from the merged commit.

(cherry picked from commit 103d6a8)
dante01yoon added a commit that referenced this pull request Nov 16, 2026
…ends the sign-in on Cloud (#23500)

Follow-up to the #22541 backport on this branch. Applied without conflict;
every added line is the one from the merged commit.

(cherry picked from commit 103d6a8)
dante01yoon added a commit that referenced this pull request Nov 16, 2026
…e only cloud login (#22541, #23500) (#23494)

```mermaid
graph LR
  A["PR 22541 (merged): send the stored API key when it is the only cloud login"] --> B["this PR: manual backport of both to core/1.60"]
  F["PR 23500 (merged): drop the stored key when Firebase ends the sign-in on Cloud"] --> B
  A --> C["PR 23495 (open): the same backport to cloud/1.60"]
  F --> C
  style B stroke-width:3px
```

Manual backport to `core/1.60` of #22541 and its follow-up #23500, one
commit each.

## Summary

**Why.** #22541 fixes a Cloud tab that is signed in only with a stored
API key: every API call returned 401 and Run did nothing. It carries
`needs-backport` for the 1.60 line. The review of this backport then
found that Firebase's own sign-out left an earlier stored key in place
as the next login; #23500 fixes that on `main`, and this branch takes it
so that the 1.60 line does not ship the first change without the second.

**Root cause of the failed cherry-pick.** On `main` the #22541 change
sits directly below `getFreshIdToken`, which arrived with #23402 (1.61)
and does not exist on `core/1.60`. Git reported that block as a conflict
in `src/stores/authStore.ts`.

**How.**

- Commit 1 (`9e9382f394`, #22541): the `getFreshIdToken` block is left
out, so no 1.61 code comes along. The added and removed lines in all
seven files are the same as in the merged commit; only the surrounding
context in `authStore.ts` differs.
- Commit 2 (`103d6a8d02`, #23500): applied without conflict. Its three
files carry the same added lines as the merged commit.
- `core/1.60` and `cloud/1.60` are identical in every file touched, so
both backports carry the same diff.

What the two changes do, as on `main`:

- With unified auth on, an API-key-only session sends the stored key
from `getAuthHeader` and `getWorkspaceAuthHeader`, and only after
Firebase has confirmed that nobody is signed in.
- Remote widgets send the Cloud credential only to same-origin routes.
- On Cloud a stored API key is removed whenever a Firebase sign-in ends:
in `logout()` before it signs out, and when Firebase ends the sign-in on
its own.

## AS IS / TO BE

Same as #22541 and #23500; see the screenshots and the table there. Not
captured again on this branch.

## Verification

- `pnpm install --frozen-lockfile` on this branch, then `pnpm test:unit
src/platform/auth src/stores src/composables/auth src/platform/workspace
src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts`:
`Test Files 141 passed (141)`, `Tests 3278 passed | 1 expected fail
(3279)`.
- Each commit's diff was compared with its merged commit: the added and
removed lines match.
- The commit hook ran oxfmt, oxlint, eslint, `lint:server-facts` and
`typecheck:app`.
- Not run: the Playwright suites, and nothing against a real Cloud
backend with a real API key.

## Not in this backport

The socket credential for an API-key-only tab (the Should fix from the
review). It is not fixed on `main` either.
dante01yoon added a commit that referenced this pull request Nov 17, 2026
…ey test on the unified path

Rebasing onto main brought in #22541 and #23500, which send a stored API
key when it is the only Cloud login and drop it when Firebase ends a
sign-in. The flag-removal commit had deleted the three stored-key boot
rows that main still runs; they pass again, and the new #23500 suite no
longer sets the removed flag.
dante01yoon added a commit that referenced this pull request Nov 17, 2026
…ey test on the unified path

Rebasing onto main brought in #22541 and #23500, which send a stored API
key when it is the only Cloud login and drop it when Firebase ends a
sign-in. The flag-removal commit had deleted the three stored-key boot
rows that main still runs; they pass again, and the new #23500 suite no
longer sets the removed flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants