Repository navigation
[backport cloud/1.60] fix(auth): send the stored API key when it is the only cloud login (#22541, #23500) - #23495
dante01yoon wants to merge 2 commits into
Conversation
…he only cloud login (#22541) Manual backport of 9e9382f. The bot could not cherry-pick it: on main the change sits next to getFreshIdToken, which came with PR 23402 and is not on 1.60. That block is left out. Every added and removed line is the one from the merged commit. (cherry picked from commit 9e9382f)
⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-16T23:01:11.656Z",
"gitSha": "13c99b0a3159622ba98e8ba223a53c0118b93520",
"branch": "backport-22541-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.4550000000227,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.543,
"layouts": 9,
"layoutDurationMs": 2.233,
"taskDurationMs": 569.283,
"heapDeltaBytes": 15112788,
"heapUsedBytes": 75867388,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.515999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2056.504000000018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.438999999999999,
"layouts": 9,
"layoutDurationMs": 2.349,
"taskDurationMs": 547.5459999999999,
"heapDeltaBytes": -4495940,
"heapUsedBytes": 65127748,
"domNodes": -178,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 10.319999999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.3739999999716,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.857000000000001,
"layouts": 9,
"layoutDurationMs": 2.224,
"taskDurationMs": 899.464,
"heapDeltaBytes": -5587832,
"heapUsedBytes": 56831156,
"domNodes": -178,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 144.69700000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.3889999999947,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.003,
"layouts": 8,
"layoutDurationMs": 1.975,
"taskDurationMs": 856.643,
"heapDeltaBytes": 5342728,
"heapUsedBytes": 66901740,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 139.464,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.5519999999879,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.4750000000000005,
"layouts": 10,
"layoutDurationMs": 2.3209999999999997,
"taskDurationMs": 388.54299999999995,
"heapDeltaBytes": 4755772,
"heapUsedBytes": 67568088,
"domNodes": 57,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 12.312999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.180000000084,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.852,
"layouts": 11,
"layoutDurationMs": 2.8800000000000003,
"taskDurationMs": 416.385,
"heapDeltaBytes": 8261892,
"heapUsedBytes": 84652052,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 13.029,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 726.457000000039,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.5899999999999994,
"layouts": 9,
"layoutDurationMs": 2.2560000000000002,
"taskDurationMs": 466.659,
"heapDeltaBytes": -15710024,
"heapUsedBytes": 61095940,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 153.397,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662790697674417,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 680.4730000000063,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.329,
"layouts": 9,
"layoutDurationMs": 2.33,
"taskDurationMs": 477.249,
"heapDeltaBytes": 9863140,
"heapUsedBytes": 88621696,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 159.53400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1115.1070000000232,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 800.4089999999999,
"heapDeltaBytes": 20236864,
"heapUsedBytes": 86004056,
"domNodes": 0,
"jsHeapTotalBytes": 12746752,
"scriptDurationMs": 53.33599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 489,
"frameDurationMs": 32.841176470588245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1131.2980000000152,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.1339999999999,
"heapDeltaBytes": -10126812,
"heapUsedBytes": 77891600,
"domNodes": -208,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 51.989000000000004,
"eventListeners": -107,
"totalBlockingTimeMs": 452,
"frameDurationMs": 30.629729729729736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 775.3730000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.705,
"heapDeltaBytes": -2972728,
"heapUsedBytes": 73422952,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.09600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 144,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 809.976000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.787,
"heapDeltaBytes": -28646132,
"heapUsedBytes": 65211896,
"domNodes": -208,
"jsHeapTotalBytes": 5636096,
"scriptDurationMs": 124.37099999999998,
"eventListeners": -107,
"totalBlockingTimeMs": 152,
"frameDurationMs": 22.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10058.809999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9054.417000000001,
"heapDeltaBytes": 66055416,
"heapUsedBytes": 160486972,
"domNodes": -274,
"jsHeapTotalBytes": 85061632,
"scriptDurationMs": 6966.55,
"eventListeners": -69,
"totalBlockingTimeMs": 374,
"frameDurationMs": 27.83850415512465,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9206.891000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8230.983999999999,
"heapDeltaBytes": 44521408,
"heapUsedBytes": 128800300,
"domNodes": -274,
"jsHeapTotalBytes": 64352256,
"scriptDurationMs": 6228.839,
"eventListeners": -69,
"totalBlockingTimeMs": 119,
"frameDurationMs": 26.25754985754985,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9115.732000000009,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.28800000000000003,
"layouts": 1,
"layoutDurationMs": 0.2639999999999999,
"taskDurationMs": 8151.64,
"heapDeltaBytes": 42797580,
"heapUsedBytes": 137128008,
"domNodes": -274,
"jsHeapTotalBytes": 72478720,
"scriptDurationMs": 6211.243,
"eventListeners": -69,
"totalBlockingTimeMs": 270,
"frameDurationMs": 26.271757925072045,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9259.944000000018,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5770000000000003,
"layouts": 2,
"layoutDurationMs": 0.585,
"taskDurationMs": 8317.032000000001,
"heapDeltaBytes": 56353992,
"heapUsedBytes": 132103020,
"domNodes": -274,
"jsHeapTotalBytes": 64876544,
"scriptDurationMs": 6362.748,
"eventListeners": -69,
"totalBlockingTimeMs": 120,
"frameDurationMs": 26.276988636363637,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 263.4649999999965,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.373999999999999,
"layouts": 11,
"layoutDurationMs": 3.4250000000000003,
"taskDurationMs": 217.824,
"heapDeltaBytes": -4577224,
"heapUsedBytes": 69607848,
"domNodes": -2427,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 11.068999999999999,
"eventListeners": -604,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 259.4829999999888,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.179,
"layouts": 11,
"layoutDurationMs": 3.7849999999999997,
"taskDurationMs": 231.781,
"heapDeltaBytes": -7007036,
"heapUsedBytes": 67517312,
"domNodes": -2427,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.866999999999997,
"eventListeners": -604,
"totalBlockingTimeMs": 4,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2056.9939999999747,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4949999999999997,
"layouts": 9,
"layoutDurationMs": 2.332,
"taskDurationMs": 652.4420000000001,
"heapDeltaBytes": -4309196,
"heapUsedBytes": 79144316,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.169000000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2057.231999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0160000000000005,
"layouts": 7,
"layoutDurationMs": 2.151,
"taskDurationMs": 640.158,
"heapDeltaBytes": 7786240,
"heapUsedBytes": 83158792,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 40.07300000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2260.426999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.827,
"layouts": 7,
"layoutDurationMs": 1.8160000000000003,
"taskDurationMs": 1652.4869999999999,
"heapDeltaBytes": -10900100,
"heapUsedBytes": 72929528,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 755.8999999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2234.348999999952,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.026,
"layouts": 7,
"layoutDurationMs": 1.8730000000000004,
"taskDurationMs": 1640.904,
"heapDeltaBytes": 3933068,
"heapUsedBytes": 79600276,
"domNodes": -274,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 759.374,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533836,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3597.919999999988,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.328,
"layouts": 65,
"layoutDurationMs": 11.654,
"taskDurationMs": 1734.643,
"heapDeltaBytes": -19186996,
"heapUsedBytes": 66973776,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 725.7410000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3694.5810000000847,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.528,
"layouts": 64,
"layoutDurationMs": 12.103,
"taskDurationMs": 1757.613,
"heapDeltaBytes": 11822520,
"heapUsedBytes": 94088024,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 759.4929999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3065.2810000000272,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.504,
"layouts": 5,
"layoutDurationMs": 1.1320000000000001,
"taskDurationMs": 1944.189,
"heapDeltaBytes": -3366088,
"heapUsedBytes": 91223636,
"domNodes": 0,
"jsHeapTotalBytes": 5435392,
"scriptDurationMs": 907.141,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755978260869565,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3198.00900000007,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.8549999999999995,
"layouts": 5,
"layoutDurationMs": 1.182,
"taskDurationMs": 2049.821,
"heapDeltaBytes": -1371788,
"heapUsedBytes": 70701500,
"domNodes": 0,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 1011.754,
"eventListeners": 182,
"totalBlockingTimeMs": 16,
"frameDurationMs": 16.927748691099477,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3087.368999999967,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7929999999999995,
"layouts": 7,
"layoutDurationMs": 1.774,
"taskDurationMs": 784.906,
"heapDeltaBytes": -3635628,
"heapUsedBytes": 81735752,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 337.097,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3055.4890000000796,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.21,
"layouts": 8,
"layoutDurationMs": 2.1029999999999998,
"taskDurationMs": 767.866,
"heapDeltaBytes": -11009968,
"heapUsedBytes": 74818352,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 337.539,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.5550000000121,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1060000000000003,
"layouts": 7,
"layoutDurationMs": 1.9780000000000002,
"taskDurationMs": 630.8420000000001,
"heapDeltaBytes": 7788832,
"heapUsedBytes": 83951948,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 41.193,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.5599999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.112,
"layouts": 8,
"layoutDurationMs": 1.954,
"taskDurationMs": 646.8230000000001,
"heapDeltaBytes": -28668536,
"heapUsedBytes": 64472076,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 37.087999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2777.188999999993,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.648,
"layouts": 7,
"layoutDurationMs": 2.154,
"taskDurationMs": 621.5639999999999,
"heapDeltaBytes": -2902956,
"heapUsedBytes": 82601300,
"domNodes": -256,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 181.036,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2772.7859999999396,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.393999999999998,
"layouts": 7,
"layoutDurationMs": 1.865,
"taskDurationMs": 556.368,
"heapDeltaBytes": -18125736,
"heapUsedBytes": 74599988,
"domNodes": 19,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 175.44799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240967,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3277.0629999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.784,
"layouts": 8,
"layoutDurationMs": 1.6999999999999997,
"taskDurationMs": 939.8389999999999,
"heapDeltaBytes": -12787968,
"heapUsedBytes": 63613396,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 352.814,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3310.7840000000124,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.321,
"layouts": 9,
"layoutDurationMs": 2.389,
"taskDurationMs": 921.9019999999999,
"heapDeltaBytes": -14000508,
"heapUsedBytes": 78080732,
"domNodes": 0,
"jsHeapTotalBytes": 7376896,
"scriptDurationMs": 375.142,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616161616162,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 617.572999999993,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.487000000000001,
"layouts": 10,
"layoutDurationMs": 2.81,
"taskDurationMs": 425.744,
"heapDeltaBytes": -1493124,
"heapUsedBytes": 68962312,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 133.868,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.8040000000392,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.253000000000001,
"layouts": 10,
"layoutDurationMs": 2.5399999999999996,
"taskDurationMs": 430.698,
"heapDeltaBytes": 24037268,
"heapUsedBytes": 86279228,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 136.091,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.4969999999926,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.111000000000001,
"layouts": 9,
"layoutDurationMs": 2.408,
"taskDurationMs": 587.324,
"heapDeltaBytes": 9660884,
"heapUsedBytes": 72154384,
"domNodes": -200,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 10.323,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.2689999999666,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8840000000000003,
"layouts": 10,
"layoutDurationMs": 2.5899999999999994,
"taskDurationMs": 573.6859999999999,
"heapDeltaBytes": -17353140,
"heapUsedBytes": 63570776,
"domNodes": -200,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 10.421,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.505000000022,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.840999999999998,
"layouts": 10,
"layoutDurationMs": 2.6510000000000002,
"taskDurationMs": 872.617,
"heapDeltaBytes": 470444,
"heapUsedBytes": 76452068,
"domNodes": -200,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 104.85,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.2960000000185,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.045000000000002,
"layouts": 10,
"layoutDurationMs": 2.6510000000000002,
"taskDurationMs": 843.349,
"heapDeltaBytes": -5469320,
"heapUsedBytes": 64707412,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 104.673,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1536.2799999999766,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.495999999999995,
"layouts": 5,
"layoutDurationMs": 14.706000000000003,
"taskDurationMs": 1212.809,
"heapDeltaBytes": 7095460,
"heapUsedBytes": 84150208,
"domNodes": 9212,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 31.32700000000001,
"eventListeners": 3566,
"totalBlockingTimeMs": 186,
"frameDurationMs": 20.128571428571423,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8387.27799999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.846000000000004,
"layouts": 8,
"layoutDurationMs": 2.2089999999999996,
"taskDurationMs": 5754.148000000001,
"heapDeltaBytes": -18885872,
"heapUsedBytes": 75195376,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2528.487,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593625498008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8373.538999999937,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.452000000000005,
"layouts": 8,
"layoutDurationMs": 2.235,
"taskDurationMs": 5877.4220000000005,
"heapDeltaBytes": -19091428,
"heapUsedBytes": 74801268,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 2553.0620000000004,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19756.326,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19237.650999999998,
"heapDeltaBytes": -14408448,
"heapUsedBytes": 283917356,
"domNodes": -3482,
"jsHeapTotalBytes": 4177920,
"scriptDurationMs": 290.264,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.93333333333334,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20348.00299999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19553.295000000002,
"heapDeltaBytes": -50821064,
"heapUsedBytes": 258982260,
"domNodes": -3482,
"jsHeapTotalBytes": 7323648,
"scriptDurationMs": 270.348,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.42264808362369,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24768.07600000001,
"styleRecalcs": 180,
"styleRecalcDurationMs": 24.511000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24393.254,
"heapDeltaBytes": -49456092,
"heapUsedBytes": 254568204,
"domNodes": -3482,
"jsHeapTotalBytes": 9158656,
"scriptDurationMs": 890.404,
"eventListeners": -659,
"totalBlockingTimeMs": 18,
"frameDurationMs": 45.609023941068145,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24689.572,
"styleRecalcs": 180,
"styleRecalcDurationMs": 26.12800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24249.034000000003,
"heapDeltaBytes": 11184968,
"heapUsedBytes": 268800416,
"domNodes": 0,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 910.166,
"eventListeners": 2,
"totalBlockingTimeMs": 36,
"frameDurationMs": 45.45543278084715,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7313.165000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.012,
"layouts": 20,
"layoutDurationMs": 27.52600000000001,
"taskDurationMs": 7141.486000000001,
"heapDeltaBytes": -20161140,
"heapUsedBytes": 270188872,
"domNodes": -3482,
"jsHeapTotalBytes": 15450112,
"scriptDurationMs": 141.442,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.808,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 7236.960000000067,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.089999999999996,
"layouts": 20,
"layoutDurationMs": 23.799,
"taskDurationMs": 7129.242,
"heapDeltaBytes": -33751980,
"heapUsedBytes": 270601512,
"domNodes": -3482,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 108.083,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.905202312138734,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9756.541000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9486.219000000003,
"heapDeltaBytes": -2263820,
"heapUsedBytes": 291293608,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 137.92100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.218707482993196,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10241.396000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9899.238,
"heapDeltaBytes": 2767784,
"heapUsedBytes": 261236480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.03400000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.60571428571428,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 491.32900000000745,
"styleRecalcs": 19,
"styleRecalcDurationMs": 10.725,
"layouts": 11,
"layoutDurationMs": 3.9690000000000003,
"taskDurationMs": 164.284,
"heapDeltaBytes": -9813468,
"heapUsedBytes": 64405056,
"domNodes": 140,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 15.581999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 495.728999999983,
"styleRecalcs": 18,
"styleRecalcDurationMs": 10.922999999999998,
"layouts": 11,
"layoutDurationMs": 4.356999999999999,
"taskDurationMs": 133.899,
"heapDeltaBytes": -9264480,
"heapUsedBytes": 65013412,
"domNodes": 133,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.105,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 468.46099999993385,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6859999999999999,
"layouts": 76,
"layoutDurationMs": 15.389,
"taskDurationMs": 431.522,
"heapDeltaBytes": -3592064,
"heapUsedBytes": 43334256,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 196.788,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 527.7020000000903,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6980000000000001,
"layouts": 76,
"layoutDurationMs": 14.857000000000001,
"taskDurationMs": 487.15000000000003,
"heapDeltaBytes": -2601228,
"heapUsedBytes": 44187744,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 230.13799999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 519.2620000000261,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.859,
"layouts": 76,
"layoutDurationMs": 16.1,
"taskDurationMs": 488.92,
"heapDeltaBytes": 733460,
"heapUsedBytes": 103277084,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 185.56599999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 634.3419999999469,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.661,
"layouts": 76,
"layoutDurationMs": 16.043000000000003,
"taskDurationMs": 568.643,
"heapDeltaBytes": 1579384,
"heapUsedBytes": 106179256,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 234.48499999999999,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.591666666666647,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage: 🟡 59.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3239 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 30d1b618ecbbf2cd54b83981eb67a0f6a82a9dd6
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (394)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
|
Starting review at 0f7f22f. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #23495 +/- ##
===============================================
+ Coverage 59.33% 87.32% +27.99%
===============================================
Files 2356 2942 +586
Lines 103544 161788 +58244
Branches 0 43222 +43222
===============================================
+ Hits 61434 141279 +79845
+ Misses 42110 19744 -22366
- Partials 0 765 +765
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2588 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Holding at 0f7f22f on 1 Must: Firebase invalidation reactivates an older account's key. Must
Clean: Correctness, Resilience, Words, Contract, Vendor, Rollout, Rules, Cause, within source review. Not covered:
Checked: Read, not run: Firebase invalidation source and both header providers against the base; credential readers and the remote-widget origin restriction. ~1.4M effective tokens for this review (7.9M raw; cache reads weighted 0.1x, cache writes 1.25-2x) |
|
The Must is real, and it is not specific to the backport: Fixed on This backport stays as it is until #23500 merges. Then its commit comes into this branch and into #23494, and I will ask for a re-review. I am not putting a change into a release branch before it is on |
|
#23500 merged on |
|
Starting re-review at 86138cb. |
|
Reviewed at 86138cb (since 0f7f22f): synchronous cleanup when Firebase ends a sign-in. Fixed: observed Firebase user-to-null transitions now clear the key before later requests. Still open: the same credential-selection mechanism revives an older key when Firebase rejects its saved login during startup. Must
Source-traced inputs below cover both unified HTTP header providers. A is the older valid key; B and C are Firebase accounts.
The warned storage failure and explicit SSO choice are not additional defects. The blocking input is Firebase discarding an established saved login before the app observes it. Clean: Correctness, Resilience, Words, within source review. Not covered:
~774k effective tokens for this review (4.6M raw; cache reads weighted 0.1x, cache writes 1.25-2x) |
|
Real. The watcher only sees a sign-in end that happens while the tab is open. When Firebase discards a saved login before its first callback, there is no previous user to compare with, and the older key is selected. It is not specific to this branch: The fix is a persisted decision, as the rule says, and it has a cost I cannot settle alone:
I am taking that choice to the PR owner. The next change will land on |
|
Closing unmerged. #22541 is not going to the 1.60 line: #23512 turns its stored-key login back off on |
|
Correction to my closing note: |
|
Update: #23512 is closed unmerged. Turning the stored-key login off needs the login state and the route guards changed too, so the owner decided to leave |
Manual backport to
cloud/1.60of #22541 and its follow-up #23500, one commit each.Summary
Why. #22541 fixes a Cloud tab that is signed in only with a stored API key: every API call returned 401 and Run did nothing. It carries
needs-backportfor the 1.60 line. The review of this backport then found that Firebase's own sign-out left an earlier stored key in place as the next login; #23500 fixes that onmain, and this branch takes it so that the 1.60 line does not ship the first change without the second.Root cause of the failed cherry-pick. On
mainthe #22541 change sits directly belowgetFreshIdToken, which arrived with #23402 (1.61) and does not exist oncloud/1.60. Git reported that block as a conflict insrc/stores/authStore.ts.How.
9e9382f394, fix(auth): send the stored API key when it is the only cloud login #22541): thegetFreshIdTokenblock is left out, so no 1.61 code comes along. The added and removed lines in all seven files are the same as in the merged commit; only the surrounding context inauthStore.tsdiffers.103d6a8d02, fix(auth): drop a stored API key when Firebase ends the sign-in on Cloud #23500): applied without conflict. Its three files carry the same added lines as the merged commit.core/1.60andcloud/1.60are identical in every file touched, so both backports carry the same diff.What the two changes do, as on
main:getAuthHeaderandgetWorkspaceAuthHeader, and only after Firebase has confirmed that nobody is signed in.logout()before it signs out, and when Firebase ends the sign-in on its own.AS IS / TO BE
Same as #22541 and #23500; see the screenshots and the table there. Not captured again on this branch.
Verification
pnpm install --frozen-lockfileon this branch, thenpnpm test:unit src/platform/auth src/stores src/composables/auth src/platform/workspace src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts:Test Files 141 passed (141),Tests 3334 passed | 1 expected fail (3335).lint:server-factsandtypecheck:app.Not in this backport
The socket credential for an API-key-only tab (the Should fix from the review). It is not fixed on
maineither.