Skip to content

[backport cloud/1.60] fix(auth): send the stored API key when it is the only cloud login (#22541, #23500) - #23495

Closed
dante01yoon wants to merge 2 commits into
cloud/1.60from
backport-22541-to-cloud-1.60
Closed

dante01yoon wants to merge 2 commits into
cloud/1.60from
backport-22541-to-cloud-1.60

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator
graph LR
  A["PR 22541 (merged): send the stored API key when it is the only cloud login"] --> B["this PR: manual backport of both to cloud/1.60"]
  F["PR 23500 (merged): drop the stored key when Firebase ends the sign-in on Cloud"] --> B
  A --> C["PR 23494 (open): the same backport to core/1.60"]
  F --> C
  style B stroke-width:3px
Loading

Manual backport to cloud/1.60 of #22541 and its follow-up #23500, one commit each.

Summary

Why. #22541 fixes a Cloud tab that is signed in only with a stored API key: every API call returned 401 and Run did nothing. It carries needs-backport for the 1.60 line. The review of this backport then found that Firebase's own sign-out left an earlier stored key in place as the next login; #23500 fixes that on main, and this branch takes it so that the 1.60 line does not ship the first change without the second.

Root cause of the failed cherry-pick. On main the #22541 change sits directly below getFreshIdToken, which arrived with #23402 (1.61) and does not exist on cloud/1.60. Git reported that block as a conflict in src/stores/authStore.ts.

How.

What the two changes do, as on main:

  • With unified auth on, an API-key-only session sends the stored key from getAuthHeader and getWorkspaceAuthHeader, and only after Firebase has confirmed that nobody is signed in.
  • Remote widgets send the Cloud credential only to same-origin routes.
  • On Cloud a stored API key is removed whenever a Firebase sign-in ends: in logout() before it signs out, and when Firebase ends the sign-in on its own.

AS IS / TO BE

Same as #22541 and #23500; see the screenshots and the table there. Not captured again on this branch.

Verification

  • pnpm install --frozen-lockfile on this branch, then pnpm test:unit src/platform/auth src/stores src/composables/auth src/platform/workspace src/renderer/extensions/vueNodes/widgets/composables/useRemoteWidget.test.ts: Test Files 141 passed (141), Tests 3334 passed | 1 expected fail (3335).
  • Each commit's diff was compared with its merged commit: the added and removed lines match.
  • The commit hook ran oxfmt, oxlint, eslint, lint:server-facts and typecheck:app.
  • Not run: the Playwright suites, and nothing against a real Cloud backend with a real API key.

Not in this backport

The socket credential for an API-key-only tab (the Should fix from the review). It is not fixed on main either.

…he only cloud login (#22541)

Manual backport of 9e9382f. The bot could not cherry-pick it: on main
the change sits next to getFreshIdToken, which came with PR 23402 and is
not on 1.60. That block is left out. Every added and removed line is the
one from the merged commit.

(cherry picked from commit 9e9382f)
@dante01yoon
dante01yoon requested a review from a team as a code owner November 16, 2026 21:31
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
End-To-End Test Suggestion For User-Facing Changes Inconclusive The check can be decided only from the PR title, commit subjects, the changed-file list relative to the base, and the diff. Here the commit subjects are unavailable, and neither the changed-file list … Provide the PR's changed-file list relative to its base (base...head) and the diff text, and confirm the commit subjects. Then re-run this check. If the list shows no browser_tests/ change, the expected result is a non-blocking suggesti…
Passed Passed checks: 1 passed

Check name Status Explanation
Adr Compliance For Entity/Litegraph Changes Passed The check is conditionally applicable. The changed files named in the PR description are auth and store files (src/stores/authStore.ts, plus the auth, workspace, and composables/auth test and source…
Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The check is conditionally applicable. The changed files named in the PR description are auth and store files (src/stores/authStore.ts, plus the auth, workspace, and composables/auth test and source files). One file, useRemoteWidget.test.ts, sits in a widget area (src/renderer/extensions/vueNodes/widgets/composables/). That may bring the check into scope, but the check does not require a verdict on that basis. Per the check's instructions, I reviewed only the PR metadata available in the context: the description, the title, and the stated scope. I did not run shell commands. Against that evidence, none of the four failure patterns appears in the described changes: 1. Command pattern (ADR-LAYOUT): The changes add no node.pos =, node.size =, or group.pos = mutation. They change auth header selection, credential removal on sign-out, and same-origin credential routing for remote widgets. 2. God-object growth (ADR-ECS): No new methods or properties are described on LGraphNode, LGraphCanvas, LGraph, or Subgraph. 3. ECS data/behavior separation: No component-like data structures or OOP instance patterns are described. 4. Extension ecosystem: The description does not mention changes to extension callbacks, node.widgets access, node.serialize overrides, or graph._version++. The PR description states that the diff matches the merged commits #22541 and #23500. Those commits are described as auth-only changes. I did not inspect the diff itself, so this verdict rests on the description. No finding in the supplied review context points to any of the listed patterns.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

The check can be decided only from the PR title, commit subjects, the changed-file list relative to the base, and the diff. Here the commit subjects are unavailable, and neither the changed-file list nor the diff text is in the review context. The check says to mark the result inconclusive when the changed-file list is unavailable, so I did not infer it. Partial evidence from the PR description (not a substitute for the file list): - Criterion 1 (fix under src/): The description says the change touches src/stores/authStore.ts and "all seven files". It also says it is a backport of #22541 (with follow-up #23500). The title is fix(auth). This likely meets criterion 1, but the diff is not in context to confirm it. - Criterion 2 (user-visible trigger): The description gives a clear trigger. A Cloud tab is signed in only with a stored API key. Every API call returns 401, and Run does nothing. This likely meets criterion 2. - Criterion 3 (no browser_tests spec): The description lists verification with unit tests (pnpm test:unit ...) and says "Not run: the Playwright suites". It does not mention any browser_tests/ file. This is not proof that none changed, because the file list is unavailable. If the changed-file list confirms that no file under browser_tests/ changed, the check would most likely FAIL as a suggestion (not a merge requirement). If a browser_tests/ spec changed, or the changed files are only tests, docs, tooling, or CI, the check would PASS.

Resolution

Provide the PR's changed-file list relative to its base (base...head) and the diff text, and confirm the commit subjects. Then re-run this check. If the list shows no browser_tests/ change, the expected result is a non-blocking suggestion, not a merge requirement. Suggested test, to be checked against the diff: Feature or trigger (one sentence): A user signs in to Cloud with only a stored API key, and then clicks Run. Suggested test outline (extend an existing spec under browser_tests/ for the auth or Cloud login flow if one exists): - Set up the browser state so that only a stored API key exists and no Firebase session exists. - Open the Cloud tab. - Verify that API requests include the stored API key in the authorization header. - Verify that the Run action starts a workflow and does not fail with 401. - Sign out through Firebase, or start a logout, with a stored API key present. - Verify that the stored API key is removed from storage after the sign-in ends.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-order-dense-n200-w200-i120: 31.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 471ms TBT · 78.2 MB heap
dom-widget-order-sparse-n1000-w20-i120: 43.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 148ms TBT · 66.1 MB heap
extension-clean-combined-draw: 37.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 247ms TBT · 137.9 MB heap
extension-rgthree-prototype-draw: 38.1 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 195ms TBT · 128.4 MB heap
large-combo-open: 43.6 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 2ms TBT · 65.4 MB heap
large-graph-idle: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
large-graph-pan: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
large-graph-zoom: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
legacy-node-drag: 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 8ms TBT · 77.2 MB heap
minimap-geometry-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
minimap-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
minimap-progress-execution-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
minimap-topology-cadence: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
subgraph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
subgraph-transition-enter: 49.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 186ms TBT · 80.3 MB heap
viewport-pan-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
vue-large-graph-idle: 28.8 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 258.9 MB heap
vue-large-graph-pan: 22.0 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 27ms TBT · 249.6 MB heap
vue-node-resize-workload: 23.9 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 257.9 MB heap
vue-zoom-out-idle: 28.6 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 263.5 MB heap
workflow-execution: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 41.7 MB heap
agent-composer-long-conversation-typing: 58.4 avg FPS · 40.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 99.9 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 9
canvas-idle: style recalc count 10
canvas-idle: task duration 558ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.2 MB
canvas-idle: DOM nodes -178
canvas-idle: event listeners -69
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 878ms
canvas-mouse-sweep: script duration 142ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.0 MB
canvas-mouse-sweep: DOM nodes -178
canvas-mouse-sweep: event listeners -69
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 402ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.6 MB
canvas-zoom-sweep: DOM nodes 57
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 472ms
dom-widget-clipping: script duration 156ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.4 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 32ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 808ms
dom-widget-order-dense-n200-w200-i120: script duration 53ms
dom-widget-order-dense-n200-w200-i120: TBT 471ms
dom-widget-order-dense-n200-w200-i120: heap used 78.2 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -104
dom-widget-order-dense-n200-w200-i120: event listeners -54
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 446ms
dom-widget-order-sparse-n1000-w20-i120: script duration 123ms
dom-widget-order-sparse-n1000-w20-i120: TBT 148ms
dom-widget-order-sparse-n1000-w20-i120: heap used 66.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -104
dom-widget-order-sparse-n1000-w20-i120: event listeners -54
extension-clean-combined-draw: avg frame time 27ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8643ms
extension-clean-combined-draw: script duration 6598ms
extension-clean-combined-draw: TBT 247ms
extension-clean-combined-draw: heap used 137.9 MB
extension-clean-combined-draw: DOM nodes -274
extension-clean-combined-draw: event listeners -69
extension-rgthree-prototype-draw: avg frame time 26ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 2
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 8234ms
extension-rgthree-prototype-draw: script duration 6287ms
extension-rgthree-prototype-draw: TBT 195ms
extension-rgthree-prototype-draw: heap used 128.4 MB
extension-rgthree-prototype-draw: DOM nodes -274
extension-rgthree-prototype-draw: event listeners -69
large-combo-open: avg frame time 23ms
large-combo-open: p95 frame time 83ms
large-combo-open: layout duration 4ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 11
large-combo-open: style recalc count 24
large-combo-open: task duration 225ms
large-combo-open: script duration 11ms
large-combo-open: TBT 2ms
large-combo-open: heap used 65.4 MB
large-combo-open: DOM nodes -2427
large-combo-open: event listeners -604
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 646ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 77.4 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -69
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1647ms
large-graph-pan: script duration 758ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.7 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -67
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 65
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1746ms
large-graph-zoom: script duration 743ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 76.8 MB
large-graph-zoom: DOM nodes -113
large-graph-zoom: event listeners -35
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1997ms
legacy-node-drag: script duration 959ms
legacy-node-drag: TBT 8ms
legacy-node-drag: heap used 77.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 8
minimap-geometry-cadence: style recalc count 9
minimap-geometry-cadence: task duration 776ms
minimap-geometry-cadence: script duration 337ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 74.7 MB
minimap-geometry-cadence: DOM nodes -274
minimap-geometry-cadence: event listeners -69
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 8
minimap-idle: style recalc count 8
minimap-idle: task duration 639ms
minimap-idle: script duration 39ms
minimap-idle: TBT 0ms
minimap-idle: heap used 70.8 MB
minimap-idle: DOM nodes -274
minimap-idle: event listeners -69
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 2ms
minimap-progress-execution-cadence: style recalc duration 13ms
minimap-progress-execution-cadence: layout count 7
minimap-progress-execution-cadence: style recalc count 26
minimap-progress-execution-cadence: task duration 589ms
minimap-progress-execution-cadence: script duration 178ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 75.0 MB
minimap-progress-execution-cadence: DOM nodes -119
minimap-progress-execution-cadence: event listeners -35
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 2ms
minimap-topology-cadence: layout count 9
minimap-topology-cadence: style recalc count 9
minimap-topology-cadence: task duration 931ms
minimap-topology-cadence: script duration 364ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 67.6 MB
minimap-topology-cadence: DOM nodes -137
minimap-topology-cadence: event listeners -35
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 428ms
subgraph-dom-widget-clipping: script duration 135ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 74.0 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 581ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.7 MB
subgraph-idle: DOM nodes -200
subgraph-idle: event listeners -116
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 858ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.3 MB
subgraph-mouse-sweep: DOM nodes -100
subgraph-mouse-sweep: event listeners -55
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1213ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 186ms
subgraph-transition-enter: heap used 80.3 MB
subgraph-transition-enter: DOM nodes 9212
subgraph-transition-enter: event listeners 3566
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 5816ms
viewport-pan-sweep: script duration 2541ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.5 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -67
vue-large-graph-idle: avg frame time 35ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 19395ms
vue-large-graph-idle: script duration 280ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 258.9 MB
vue-large-graph-idle: DOM nodes -3482
vue-large-graph-idle: event listeners -661
vue-large-graph-pan: avg frame time 46ms
vue-large-graph-pan: p95 frame time 100ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 25ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 180
vue-large-graph-pan: task duration 24321ms
vue-large-graph-pan: script duration 900ms
vue-large-graph-pan: TBT 27ms
vue-large-graph-pan: heap used 249.6 MB
vue-large-graph-pan: DOM nodes -1741
vue-large-graph-pan: event listeners -329
vue-node-resize-workload: avg frame time 42ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 64ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 7135ms
vue-node-resize-workload: script duration 125ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 257.9 MB
vue-node-resize-workload: DOM nodes -3482
vue-node-resize-workload: event listeners -661
vue-zoom-out-idle: avg frame time 35ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9693ms
vue-zoom-out-idle: script duration 145ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 263.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 11
workflow-execution: style recalc count 19
workflow-execution: task duration 149ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 61.7 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 7
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 15ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 459ms
agent-composer-empty-conversation-typing: script duration 213ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 41.7 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 25ms
agent-composer-long-conversation-typing: layout duration 16ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 529ms
agent-composer-long-conversation-typing: script duration 210ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 99.9 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 296
Raw data
{
  "timestamp": "2026-11-16T23:01:11.656Z",
  "gitSha": "13c99b0a3159622ba98e8ba223a53c0118b93520",
  "branch": "backport-22541-to-cloud-1.60",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2037.4550000000227,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.543,
      "layouts": 9,
      "layoutDurationMs": 2.233,
      "taskDurationMs": 569.283,
      "heapDeltaBytes": 15112788,
      "heapUsedBytes": 75867388,
      "domNodes": -178,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 10.515999999999998,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.504000000018,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.438999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.349,
      "taskDurationMs": 547.5459999999999,
      "heapDeltaBytes": -4495940,
      "heapUsedBytes": 65127748,
      "domNodes": -178,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 10.319999999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1793.3739999999716,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 12.857000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.224,
      "taskDurationMs": 899.464,
      "heapDeltaBytes": -5587832,
      "heapUsedBytes": 56831156,
      "domNodes": -178,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 144.69700000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666667,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1776.3889999999947,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 12.003,
      "layouts": 8,
      "layoutDurationMs": 1.975,
      "taskDurationMs": 856.643,
      "heapDeltaBytes": 5342728,
      "heapUsedBytes": 66901740,
      "domNodes": -178,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 139.464,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666037735849052,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.5519999999879,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 4.4750000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.3209999999999997,
      "taskDurationMs": 388.54299999999995,
      "heapDeltaBytes": 4755772,
      "heapUsedBytes": 67568088,
      "domNodes": 57,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 12.312999999999997,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.180000000084,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 4.852,
      "layouts": 11,
      "layoutDurationMs": 2.8800000000000003,
      "taskDurationMs": 416.385,
      "heapDeltaBytes": 8261892,
      "heapUsedBytes": 84652052,
      "domNodes": 57,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 13.029,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 726.457000000039,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.5899999999999994,
      "layouts": 9,
      "layoutDurationMs": 2.2560000000000002,
      "taskDurationMs": 466.659,
      "heapDeltaBytes": -15710024,
      "heapUsedBytes": 61095940,
      "domNodes": 0,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 153.397,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662790697674417,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 680.4730000000063,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.329,
      "layouts": 9,
      "layoutDurationMs": 2.33,
      "taskDurationMs": 477.249,
      "heapDeltaBytes": 9863140,
      "heapUsedBytes": 88621696,
      "domNodes": 0,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 159.53400000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1115.1070000000232,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 800.4089999999999,
      "heapDeltaBytes": 20236864,
      "heapUsedBytes": 86004056,
      "domNodes": 0,
      "jsHeapTotalBytes": 12746752,
      "scriptDurationMs": 53.33599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 489,
      "frameDurationMs": 32.841176470588245,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1131.2980000000152,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 815.1339999999999,
      "heapDeltaBytes": -10126812,
      "heapUsedBytes": 77891600,
      "domNodes": -208,
      "jsHeapTotalBytes": 20717568,
      "scriptDurationMs": 51.989000000000004,
      "eventListeners": -107,
      "totalBlockingTimeMs": 452,
      "frameDurationMs": 30.629729729729736,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 775.3730000000019,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.705,
      "heapDeltaBytes": -2972728,
      "heapUsedBytes": 73422952,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 122.09600000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 809.976000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.787,
      "heapDeltaBytes": -28646132,
      "heapUsedBytes": 65211896,
      "domNodes": -208,
      "jsHeapTotalBytes": 5636096,
      "scriptDurationMs": 124.37099999999998,
      "eventListeners": -107,
      "totalBlockingTimeMs": 152,
      "frameDurationMs": 22.68333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10058.809999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9054.417000000001,
      "heapDeltaBytes": 66055416,
      "heapUsedBytes": 160486972,
      "domNodes": -274,
      "jsHeapTotalBytes": 85061632,
      "scriptDurationMs": 6966.55,
      "eventListeners": -69,
      "totalBlockingTimeMs": 374,
      "frameDurationMs": 27.83850415512465,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9206.891000000041,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8230.983999999999,
      "heapDeltaBytes": 44521408,
      "heapUsedBytes": 128800300,
      "domNodes": -274,
      "jsHeapTotalBytes": 64352256,
      "scriptDurationMs": 6228.839,
      "eventListeners": -69,
      "totalBlockingTimeMs": 119,
      "frameDurationMs": 26.25754985754985,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9115.732000000009,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.28800000000000003,
      "layouts": 1,
      "layoutDurationMs": 0.2639999999999999,
      "taskDurationMs": 8151.64,
      "heapDeltaBytes": 42797580,
      "heapUsedBytes": 137128008,
      "domNodes": -274,
      "jsHeapTotalBytes": 72478720,
      "scriptDurationMs": 6211.243,
      "eventListeners": -69,
      "totalBlockingTimeMs": 270,
      "frameDurationMs": 26.271757925072045,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9259.944000000018,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5770000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.585,
      "taskDurationMs": 8317.032000000001,
      "heapDeltaBytes": 56353992,
      "heapUsedBytes": 132103020,
      "domNodes": -274,
      "jsHeapTotalBytes": 64876544,
      "scriptDurationMs": 6362.748,
      "eventListeners": -69,
      "totalBlockingTimeMs": 120,
      "frameDurationMs": 26.276988636363637,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-combo-open",
      "durationMs": 263.4649999999965,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 13.373999999999999,
      "layouts": 11,
      "layoutDurationMs": 3.4250000000000003,
      "taskDurationMs": 217.824,
      "heapDeltaBytes": -4577224,
      "heapUsedBytes": 69607848,
      "domNodes": -2427,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 11.068999999999999,
      "eventListeners": -604,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.833333333333332,
      "p95FrameDurationMs": 66.59999999999991
    },
    {
      "name": "large-combo-open",
      "durationMs": 259.4829999999888,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 14.179,
      "layouts": 11,
      "layoutDurationMs": 3.7849999999999997,
      "taskDurationMs": 231.781,
      "heapDeltaBytes": -7007036,
      "heapUsedBytes": 67517312,
      "domNodes": -2427,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.866999999999997,
      "eventListeners": -604,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.9939999999747,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.4949999999999997,
      "layouts": 9,
      "layoutDurationMs": 2.332,
      "taskDurationMs": 652.4420000000001,
      "heapDeltaBytes": -4309196,
      "heapUsedBytes": 79144316,
      "domNodes": -274,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 33.169000000000004,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.231999999999,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.0160000000000005,
      "layouts": 7,
      "layoutDurationMs": 2.151,
      "taskDurationMs": 640.158,
      "heapDeltaBytes": 7786240,
      "heapUsedBytes": 83158792,
      "domNodes": -274,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 40.07300000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2260.426999999993,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.827,
      "layouts": 7,
      "layoutDurationMs": 1.8160000000000003,
      "taskDurationMs": 1652.4869999999999,
      "heapDeltaBytes": -10900100,
      "heapUsedBytes": 72929528,
      "domNodes": -274,
      "jsHeapTotalBytes": 4284416,
      "scriptDurationMs": 755.8999999999999,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665925925925922,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2234.348999999952,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 10.026,
      "layouts": 7,
      "layoutDurationMs": 1.8730000000000004,
      "taskDurationMs": 1640.904,
      "heapDeltaBytes": 3933068,
      "heapUsedBytes": 79600276,
      "domNodes": -274,
      "jsHeapTotalBytes": 5070848,
      "scriptDurationMs": 759.374,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666165413533836,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3597.919999999988,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 11.328,
      "layouts": 65,
      "layoutDurationMs": 11.654,
      "taskDurationMs": 1734.643,
      "heapDeltaBytes": -19186996,
      "heapUsedBytes": 66973776,
      "domNodes": -250,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 725.7410000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665581395348838,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3694.5810000000847,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 11.528,
      "layouts": 64,
      "layoutDurationMs": 12.103,
      "taskDurationMs": 1757.613,
      "heapDeltaBytes": 11822520,
      "heapUsedBytes": 94088024,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 759.4929999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665765765765766,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3065.2810000000272,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 5.504,
      "layouts": 5,
      "layoutDurationMs": 1.1320000000000001,
      "taskDurationMs": 1944.189,
      "heapDeltaBytes": -3366088,
      "heapUsedBytes": 91223636,
      "domNodes": 0,
      "jsHeapTotalBytes": 5435392,
      "scriptDurationMs": 907.141,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.755978260869565,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3198.00900000007,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.8549999999999995,
      "layouts": 5,
      "layoutDurationMs": 1.182,
      "taskDurationMs": 2049.821,
      "heapDeltaBytes": -1371788,
      "heapUsedBytes": 70701500,
      "domNodes": 0,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 1011.754,
      "eventListeners": 182,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 16.927748691099477,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3087.368999999967,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.7929999999999995,
      "layouts": 7,
      "layoutDurationMs": 1.774,
      "taskDurationMs": 784.906,
      "heapDeltaBytes": -3635628,
      "heapUsedBytes": 81735752,
      "domNodes": -274,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 337.097,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665945945945946,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3055.4890000000796,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.21,
      "layouts": 8,
      "layoutDurationMs": 2.1029999999999998,
      "taskDurationMs": 767.866,
      "heapDeltaBytes": -11009968,
      "heapUsedBytes": 74818352,
      "domNodes": -274,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 337.539,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666120218579234,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.5550000000121,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.1060000000000003,
      "layouts": 7,
      "layoutDurationMs": 1.9780000000000002,
      "taskDurationMs": 630.8420000000001,
      "heapDeltaBytes": 7788832,
      "heapUsedBytes": 83951948,
      "domNodes": -274,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 41.193,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666667,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.5599999999995,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.112,
      "layouts": 8,
      "layoutDurationMs": 1.954,
      "taskDurationMs": 646.8230000000001,
      "heapDeltaBytes": -28668536,
      "heapUsedBytes": 64472076,
      "domNodes": -274,
      "jsHeapTotalBytes": 3571712,
      "scriptDurationMs": 37.087999999999994,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2777.188999999993,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 12.648,
      "layouts": 7,
      "layoutDurationMs": 2.154,
      "taskDurationMs": 621.5639999999999,
      "heapDeltaBytes": -2902956,
      "heapUsedBytes": 82601300,
      "domNodes": -256,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 181.036,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66566265060241,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2772.7859999999396,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 12.393999999999998,
      "layouts": 7,
      "layoutDurationMs": 1.865,
      "taskDurationMs": 556.368,
      "heapDeltaBytes": -18125736,
      "heapUsedBytes": 74599988,
      "domNodes": 19,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 175.44799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666265060240967,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3277.0629999999983,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.784,
      "layouts": 8,
      "layoutDurationMs": 1.6999999999999997,
      "taskDurationMs": 939.8389999999999,
      "heapDeltaBytes": -12787968,
      "heapUsedBytes": 63613396,
      "domNodes": -274,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 352.814,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666326530612245,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3310.7840000000124,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.321,
      "layouts": 9,
      "layoutDurationMs": 2.389,
      "taskDurationMs": 921.9019999999999,
      "heapDeltaBytes": -14000508,
      "heapUsedBytes": 78080732,
      "domNodes": 0,
      "jsHeapTotalBytes": 7376896,
      "scriptDurationMs": 375.142,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66616161616162,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 617.572999999993,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.487000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.81,
      "taskDurationMs": 425.744,
      "heapDeltaBytes": -1493124,
      "heapUsedBytes": 68962312,
      "domNodes": 0,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 133.868,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567563,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 600.8040000000392,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.253000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.5399999999999996,
      "taskDurationMs": 430.698,
      "heapDeltaBytes": 24037268,
      "heapUsedBytes": 86279228,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 136.091,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2041.4969999999926,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.111000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.408,
      "taskDurationMs": 587.324,
      "heapDeltaBytes": 9660884,
      "heapUsedBytes": 72154384,
      "domNodes": -200,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 10.323,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.2689999999666,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.8840000000000003,
      "layouts": 10,
      "layoutDurationMs": 2.5899999999999994,
      "taskDurationMs": 573.6859999999999,
      "heapDeltaBytes": -17353140,
      "heapUsedBytes": 63570776,
      "domNodes": -200,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 10.421,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667213114754095,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.505000000022,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 14.840999999999998,
      "layouts": 10,
      "layoutDurationMs": 2.6510000000000002,
      "taskDurationMs": 872.617,
      "heapDeltaBytes": 470444,
      "heapUsedBytes": 76452068,
      "domNodes": -200,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 104.85,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.2960000000185,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 15.045000000000002,
      "layouts": 10,
      "layoutDurationMs": 2.6510000000000002,
      "taskDurationMs": 843.349,
      "heapDeltaBytes": -5469320,
      "heapUsedBytes": 64707412,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 104.673,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1536.2799999999766,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 22.495999999999995,
      "layouts": 5,
      "layoutDurationMs": 14.706000000000003,
      "taskDurationMs": 1212.809,
      "heapDeltaBytes": 7095460,
      "heapUsedBytes": 84150208,
      "domNodes": 9212,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 31.32700000000001,
      "eventListeners": 3566,
      "totalBlockingTimeMs": 186,
      "frameDurationMs": 20.128571428571423,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8387.27799999998,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 33.846000000000004,
      "layouts": 8,
      "layoutDurationMs": 2.2089999999999996,
      "taskDurationMs": 5754.148000000001,
      "heapDeltaBytes": -18885872,
      "heapUsedBytes": 75195376,
      "domNodes": -274,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 2528.487,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66593625498008,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8373.538999999937,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 33.452000000000005,
      "layouts": 8,
      "layoutDurationMs": 2.235,
      "taskDurationMs": 5877.4220000000005,
      "heapDeltaBytes": -19091428,
      "heapUsedBytes": 74801268,
      "domNodes": -274,
      "jsHeapTotalBytes": 5632000,
      "scriptDurationMs": 2553.0620000000004,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66586826347305,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19756.326,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19237.650999999998,
      "heapDeltaBytes": -14408448,
      "heapUsedBytes": 283917356,
      "domNodes": -3482,
      "jsHeapTotalBytes": 4177920,
      "scriptDurationMs": 290.264,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.93333333333334,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 20348.00299999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19553.295000000002,
      "heapDeltaBytes": -50821064,
      "heapUsedBytes": 258982260,
      "domNodes": -3482,
      "jsHeapTotalBytes": 7323648,
      "scriptDurationMs": 270.348,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 35.42264808362369,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24768.07600000001,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 24.511000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24393.254,
      "heapDeltaBytes": -49456092,
      "heapUsedBytes": 254568204,
      "domNodes": -3482,
      "jsHeapTotalBytes": 9158656,
      "scriptDurationMs": 890.404,
      "eventListeners": -659,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 45.609023941068145,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24689.572,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 26.12800000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24249.034000000003,
      "heapDeltaBytes": 11184968,
      "heapUsedBytes": 268800416,
      "domNodes": 0,
      "jsHeapTotalBytes": -2621440,
      "scriptDurationMs": 910.166,
      "eventListeners": 2,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 45.45543278084715,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7313.165000000026,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.012,
      "layouts": 20,
      "layoutDurationMs": 27.52600000000001,
      "taskDurationMs": 7141.486000000001,
      "heapDeltaBytes": -20161140,
      "heapUsedBytes": 270188872,
      "domNodes": -3482,
      "jsHeapTotalBytes": 15450112,
      "scriptDurationMs": 141.442,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 41.808,
      "p95FrameDurationMs": 83.30000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7236.960000000067,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.089999999999996,
      "layouts": 20,
      "layoutDurationMs": 23.799,
      "taskDurationMs": 7129.242,
      "heapDeltaBytes": -33751980,
      "heapUsedBytes": 270601512,
      "domNodes": -3482,
      "jsHeapTotalBytes": 16240640,
      "scriptDurationMs": 108.083,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 41.905202312138734,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9756.541000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9486.219000000003,
      "heapDeltaBytes": -2263820,
      "heapUsedBytes": 291293608,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 137.92100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.218707482993196,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 10241.396000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9899.238,
      "heapDeltaBytes": 2767784,
      "heapUsedBytes": 261236480,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 153.03400000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.60571428571428,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "workflow-execution",
      "durationMs": 491.32900000000745,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 10.725,
      "layouts": 11,
      "layoutDurationMs": 3.9690000000000003,
      "taskDurationMs": 164.284,
      "heapDeltaBytes": -9813468,
      "heapUsedBytes": 64405056,
      "domNodes": 140,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 15.581999999999999,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 495.728999999983,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 10.922999999999998,
      "layouts": 11,
      "layoutDurationMs": 4.356999999999999,
      "taskDurationMs": 133.899,
      "heapDeltaBytes": -9264480,
      "heapUsedBytes": 65013412,
      "domNodes": 133,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 11.105,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 468.46099999993385,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6859999999999999,
      "layouts": 76,
      "layoutDurationMs": 15.389,
      "taskDurationMs": 431.522,
      "heapDeltaBytes": -3592064,
      "heapUsedBytes": 43334256,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 196.788,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379284,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 527.7020000000903,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6980000000000001,
      "layouts": 76,
      "layoutDurationMs": 14.857000000000001,
      "taskDurationMs": 487.15000000000003,
      "heapDeltaBytes": -2601228,
      "heapUsedBytes": 44187744,
      "domNodes": 4,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 230.13799999999998,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 519.2620000000261,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.859,
      "layouts": 76,
      "layoutDurationMs": 16.1,
      "taskDurationMs": 488.92,
      "heapDeltaBytes": 733460,
      "heapUsedBytes": 103277084,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 185.56599999999997,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 634.3419999999469,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.661,
      "layouts": 76,
      "layoutDurationMs": 16.043000000000003,
      "taskDurationMs": 568.643,
      "heapDeltaBytes": 1579384,
      "heapUsedBytes": 106179256,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 234.48499999999999,
      "eventListeners": 300,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.591666666666647,
      "p95FrameDurationMs": 33.29999999999927
    }
  ]
}

🔬 E2E Coverage: 🟡 59.1% of lines

Coverage totals
Metric Covered Total Pct
Lines 62111 105125 59.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1179
src/workbench/extensions/agent/composables/agent/useAgentSession.ts 12.0% 980
src/workbench/extensions/agent/crdt/liveGraphApplier.ts 2.4% 882
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts 11.7% 669
src/workbench/extensions/agent/AgentPanelRoot.vue 26.6% 623
src/workbench/extensions/agent/crdt/docOpMinter.ts 4.2% 438
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts 25.5% 391
src/LGraphNode.ts 71.4% 377
src/platform/billing/stores/billingOperationStore.ts 9.3% 333
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332

🎭 Playwright: ✅ 3239 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2362 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 841 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/16/2026, 10:50:41 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 30d1b618ecbbf2cd54b83981eb67a0f6a82a9dd6

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (394)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentSidebarTabs.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 344 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@vqt123

vqt123 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Starting review at 0f7f22f.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Nov 16, 2026
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/stores/authStore.ts 95.00% 1 Missing ⚠️
@@               Coverage Diff               @@
##           cloud/1.60   #23495       +/-   ##
===============================================
+ Coverage       59.33%   87.32%   +27.99%     
===============================================
  Files            2356     2942      +586     
  Lines          103544   161788    +58244     
  Branches            0    43222    +43222     
===============================================
+ Hits            61434   141279    +79845     
+ Misses          42110    19744    -22366     
- Partials            0      765      +765     
Flag Coverage Δ
e2e 59.24% <30.00%> (-0.09%) ⬇️
unit 86.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ns/vueNodes/widgets/composables/useRemoteWidget.ts 95.91% <100.00%> (+6.04%) ⬆️
src/stores/authStore.ts 99.02% <95.00%> (+42.14%) ⬆️

... and 2588 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vqt123

vqt123 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Holding at 0f7f22f on 1 Must: Firebase invalidation reactivates an older account's key.

Must

  • Access: A Cloud tab signed in as B can silently resume A's stored API key after Firebase invalidates B's login src/stores/authStore.ts:350, also :456. Clear or disqualify the older key when an established Firebase login ends, while preserving fallback on initially signed-out startup. Evidence: read, not run. Firebase signs out on auth/user-disabled and auth/user-token-expired. The callback at :231 clears workspace state but retains the key; key removal at :852 runs only through explicit logout. The next independent call to either header provider sends A's key at the head. At base 30d1b618ec, both unified providers return no credential for that same input (:354, :471). The added invalidation test checks only the in-flight request; also check subsequent calls to both providers.

Clean: Correctness, Resilience, Words, Contract, Vendor, Rollout, Rules, Cause, within source review.

Not covered:

  • Resilience: unit / test-shards jobs 1, 2, 6, 7 and 8 are pending. Relevant command: pnpm test:unit src/stores/authStore.test.ts src/stores/__tests__/authTokenPriority.test.ts src/platform/auth.
  • Access and Contract: Chromium shards 1-16 and Cloud shards 1-4 are pending. Browser command: pnpm exec playwright test --project=cloud browser_tests/tests/cloudApiKeyBoot.spec.ts browser_tests/tests/remoteWidgetWebSession.spec.ts. Real Cloud acceptance also needs a stored-key-only login and a workflow run through completion.
  • Rollout: pr-risk / Grade PR risk is pending; its completed job result settles this item.

Checked: Read, not run: Firebase invalidation source and both header providers against the base; credential readers and the remote-widget origin restriction.

~1.4M effective tokens for this review (7.9M raw; cache reads weighted 0.1x, cache writes 1.25-2x)

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

The Must is real, and it is not specific to the backport: main has it since #22541 merged.

Fixed on main first, in #23500. The store watches currentUser synchronously and, on Cloud, removes the stored key whenever a Firebase user is replaced by none, so Firebase's own sign-out is covered and not only logout(). A first answer of "nobody is signed in" has no previous user, so an API-key-only tab keeps its key. The new case checks the calls after the invalidation on both header providers, as asked, and fails without the fix:

× answers later requests with no credential after Firebase ends the sign-in on its own
  AssertionError: expected { 'X-API-KEY': 'earlier-key' } to be null

This backport stays as it is until #23500 merges. Then its commit comes into this branch and into #23494, and I will ask for a re-review. I am not putting a change into a release branch before it is on main.

…ends the sign-in on Cloud (#23500)

Follow-up to the #22541 backport on this branch. Applied without conflict;
every added line is the one from the merged commit.

(cherry picked from commit 103d6a8)
@dante01yoon dante01yoon changed the title [backport cloud/1.60] fix(auth): send the stored API key when it is the only cloud login (#22541) [backport cloud/1.60] fix(auth): send the stored API key when it is the only cloud login (#22541, #23500) Nov 16, 2026
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

#23500 merged on main at 2026-11-16T22:45Z, approved with no findings. Its commit is now on this branch as the second commit. It applied without conflict and its added lines match the merged commit. On this branch with its own dependencies, the auth, store and workspace folders plus the useRemoteWidget file give Test Files 141 passed (141), Tests 3334 passed | 1 expected fail (3335). The title and description now name both PRs. The socket credential Should fix is unchanged, here and on main.

@dante01yoon
dante01yoon requested review from vqt123 and removed request for vqt123 November 16, 2026 22:49
@vqt123

vqt123 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Starting re-review at 86138cb.

@vqt123

vqt123 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Reviewed at 86138cb (since 0f7f22f): synchronous cleanup when Firebase ends a sign-in.

Fixed: observed Firebase user-to-null transitions now clear the key before later requests. answers later requests with no credential after Firebase ends the sign-in on its own checks both providers (src/stores/__tests__/authTokenPriority.test.ts:582). Read against the previous head, not run.

Still open: the same credential-selection mechanism revives an older key when Firebase rejects its saved login during startup.

Must

  • Access: Close a Cloud tab with Firebase account B and account A's dormant key saved, revoke B's refresh token or disable B, then reopen it. Firebase can discard B before its first callback. That callback is only null, so previousUser at src/stores/authStore.ts:255 is null and A's key survives. Both unified header providers then send A's key (:363, :372, :469). Rule: ending a Firebase login must not silently select an older key, while genuine key-only startup must remain supported. Persist the selected login and the saved key's eligibility when a login takes over, then make restoration and both providers use that one decision. Unclassifiable legacy combinations must require sign-in rather than selecting an old key. Evidence: read, not run. Firebase Auth 1.10.8's reloadAndSetCurrentUserOrClear discards an invalid saved user before registerStateListener delivers its initial callback; the adapter forwards it at packages/account-core/src/firebase/index.ts:305. At head both providers return A's key; at merge base 30d1b618ec they return null (authStore.ts:354, :471).

Source-traced inputs below cover both unified HTTP header providers. A is the older valid key; B and C are Firebase accounts.

Input Head Main merge base
Restoration pending, key present or absent No key header No key header
Genuine key-only startup; first or repeated null A Null; intended improvement
Saved B restores; same-user refresh succeeds B, never A B, never A
Saved B disabled during restoration; first callback null A, wrong account Null
Saved B revoked/expired/deleted during restoration; first callback null A, wrong account Null
Restoration has a network failure B stays selected; never A Same
Observed B becomes disabled or token-expired, then null Key cleared; null Null
B remains signed in but token retrieval or mint fails Firebase where permitted, otherwise null; never A Same
B-to-C, B-to-null-to-C, then C-to-null Current account, then null Same HTTP result
Explicit logout, open sibling's Firebase sign-out, overlapping or later request Key cleared; stale request refused No key fallback
No key or empty key, any sign-out No key header No key header
Storage unreadable or removal fails during sign-out Memory cleared; warning; no key header No unified key header
Reload after warned persistence failure, retained key readable Key may return; explicitly warned behavior No unified key header
Explicit new key selection after sign-out, including another tab New key selected Unified key-only bug
Other tab's key change/removal delivered before observed sign-out Incoming key cleared No unified key header
Key validation completes after clearing Stale result ignored No unified key header
Local/Desktop Firebase sign-out Cloud watcher does nothing Same
SSO-only startup with revoked cookie, no saved Firebase login Key fallback is an explicit choice No unified key header

The warned storage failure and explicit SSO choice are not additional defects. The blocking input is Firebase discarding an established saved login before the app observes it.

Clean: Correctness, Resilience, Words, within source review.

Not covered:

  • Resilience: suites read, not run. Relevant command: pnpm test:unit src/stores/authStore.test.ts src/stores/__tests__/authTokenPriority.test.ts src/platform/auth. Pending: lint-pr / lint, lint-pr / typecheck, lint-pr / typecheck-aux, lint-pr / repo-checks, check.
  • Access and Contract: browser restoration and real Cloud acceptance. Browser command, including the missing persisted-invalid-login cases: pnpm exec playwright test --project=cloud browser_tests/tests/cloudApiKeyBoot.spec.ts browser_tests/tests/authAccountSwitch.spec.ts. Real Cloud acceptance also needs a stored-key-only workflow through completion.
  • Rollout: pr-risk / Grade PR risk, perf-tests, deploy-and-comment, setup, and Apply the backport label remain pending; read their completed CI results.

~774k effective tokens for this review (4.6M raw; cache reads weighted 0.1x, cache writes 1.25-2x)

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Real. The watcher only sees a sign-in end that happens while the tab is open. When Firebase discards a saved login before its first callback, there is no previous user to compare with, and the older key is selected.

It is not specific to this branch: main has it since #22541 and #23500, and #23494 carries the same diff. #23494 was approved on that diff; I am not merging it, and this PR stays unmerged too, until the fix is on main and in both backports.

The fix is a persisted decision, as the rule says, and it has a cost I cannot settle alone:

  • If a stored key counts as the login only when a persisted marker says it was chosen as the login, a browser where automation seeds comfy_api_key into storage directly stops being signed in until it seeds the marker too. cloudApiKeyBoot.spec.ts signs in that way, and the fix(auth): send the stored API key when it is the only cloud login #22541 description says QA and live checks do as well.
  • If the marker instead records "a Firebase login has taken over", seeded keys keep working, but a browser that had both a saved Firebase login and an older key before the new code ever ran is unclassifiable on its first load, which the rule says must require sign-in.

I am taking that choice to the PR owner. The next change will land on main first, then come into both backports.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Closing unmerged. #22541 is not going to the 1.60 line: #23512 turns its stored-key login back off on main, because the case found in the review of #23495 (a saved Firebase login discarded before the first callback) needs a persisted login choice that does not exist yet. The 1.60 branches never received #22541, so nothing has to be undone there. The branch is left in place.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Correction to my closing note: core/1.60 did receive #22541 and #23500. #23494 was merged at 2026-11-16T23:31Z by the Backport Auto-Merge sweep while I was holding it with a comment only. cloud/1.60 did not receive them, and this PR stays closed. #23512 carries needs-backport + core/1.60 so that core/1.60 gets the turn-off as well.

@dante01yoon

Copy link
Copy Markdown
Collaborator Author

Update: #23512 is closed unmerged. Turning the stored-key login off needs the login state and the route guards changed too, so the owner decided to leave main as it is. main and core/1.60 keep #22541 and #23500; cloud/1.60 does not have them. The startup case from the review of #23495 and the socket credential are tracked in FRONT-4130.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants