Repository navigation
[backport cloud/1.60] fix: keep workflow-id links private and current (#23269) - #23270
Conversation
UserFile.load put the file path in the Error it throws when the userdata GET fails. The workflow load queue reports that Error to Sentry and Datadog before any caller can sanitize it, so a workflow-id link (or any open) whose file read returns 500 sent the private file name to error reporting. The message now carries only the status. (cherry picked from commit 110e82f)
openWorkflow checked its isCurrent predicate before calling loadGraphData but did not pass it on. loadGraphData awaits beforeConfigureGraph (Load3D awaits its module imports there), so a workflow-id link replaced by a newer link during that wait still configured and activated its graph under the newer link's URL. loadGraphData now takes isCurrent and, when it turns false before the graph is configured, ends the load as replaced and resolves false. openWorkflow forwards the predicate when it replaces another workflow, then unloads the superseded file and repaints the retained workflow. A reload of the active workflow keeps its current behaviour, since there is no other workflow to repaint. (cherry picked from commit 863f7fe)
…tings With a link A that also carries settings=plan-credits, A's workflow-link URL cleanup can be cancelled by a newer link B that a navigation guard holds. The URL actions then went on to the Settings loader, whose router.replace was built from A's query. That replace wrote A back over B's stash and cancelled B's navigation, so B never opened. Only the final sweep checked for a newer link in flight. The loaders after the workflow-id link now share the sweep's check: while the stash holds a newer link the loader never started, none of them run, so none of their URL cleanup cancels that navigation. Their params stay in their own stashes for the next page load. The steps before the link (deployment, workspace) are unchanged, since a link waiting to be opened looks the same as one in flight before the link step runs. (cherry picked from commit 503a08b)
⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-11T06:16:37.811Z",
"gitSha": "1c850f839273d329a4a436007594cc91c0bf46d7",
"branch": "backport-dplat-3900-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.3810000000103,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.354,
"layouts": 8,
"layoutDurationMs": 2.059,
"taskDurationMs": 533.049,
"heapDeltaBytes": 6973956,
"heapUsedBytes": 67373844,
"domNodes": -178,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.096999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664754098360653,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2032.935000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5899999999999999,
"layouts": 8,
"layoutDurationMs": 1.5479999999999998,
"taskDurationMs": 463.202,
"heapDeltaBytes": -6737544,
"heapUsedBytes": 54625428,
"domNodes": -178,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.761999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.779999999991,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.152000000000001,
"layouts": 9,
"layoutDurationMs": 3.008,
"taskDurationMs": 840.36,
"heapDeltaBytes": 6681168,
"heapUsedBytes": 85282388,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 135.95800000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.653000000007,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.626999999999999,
"layouts": 9,
"layoutDurationMs": 2.265,
"taskDurationMs": 760.17,
"heapDeltaBytes": 7316000,
"heapUsedBytes": 83193824,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 128.204,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1690.9840000000145,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.7860000000000005,
"layouts": 10,
"layoutDurationMs": 2.7670000000000003,
"taskDurationMs": 366.77900000000005,
"heapDeltaBytes": 4183004,
"heapUsedBytes": 66147760,
"domNodes": 57,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 10.696000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.454000000037,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.270999999999999,
"layouts": 11,
"layoutDurationMs": 2.229,
"taskDurationMs": 355.046,
"heapDeltaBytes": 7529664,
"heapUsedBytes": 84276076,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 10.239,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 582.1599999999876,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.137,
"layouts": 10,
"layoutDurationMs": 2.621,
"taskDurationMs": 442.84399999999994,
"heapDeltaBytes": 8397872,
"heapUsedBytes": 70557648,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 145.31,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 584.5260000000394,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.5669999999999997,
"layouts": 9,
"layoutDurationMs": 2.183,
"taskDurationMs": 406.99699999999996,
"heapDeltaBytes": 8095888,
"heapUsedBytes": 71332164,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 135.479,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1084.4249999999818,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.023,
"heapDeltaBytes": -7398228,
"heapUsedBytes": 77911856,
"domNodes": -208,
"jsHeapTotalBytes": 15998976,
"scriptDurationMs": 47.543,
"eventListeners": -107,
"totalBlockingTimeMs": 408,
"frameDurationMs": 29.27837837837837,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1085.839999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.2950000000002,
"heapDeltaBytes": 13973088,
"heapUsedBytes": 103975748,
"domNodes": -148,
"jsHeapTotalBytes": 22048768,
"scriptDurationMs": 45.808,
"eventListeners": -107,
"totalBlockingTimeMs": 440,
"frameDurationMs": 31.864705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.34399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.29499999999973,
"heapDeltaBytes": -1495616,
"heapUsedBytes": 70891052,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.93800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.4780000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.381,
"heapDeltaBytes": -24393620,
"heapUsedBytes": 65798608,
"domNodes": -208,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 144.69099999999997,
"eventListeners": -107,
"totalBlockingTimeMs": 162,
"frameDurationMs": 22.518918918918914,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7901.330999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.28600000000000064,
"layouts": 1,
"layoutDurationMs": 0.32400000000000007,
"taskDurationMs": 7033.856999999999,
"heapDeltaBytes": 46513184,
"heapUsedBytes": 140800696,
"domNodes": -274,
"jsHeapTotalBytes": 63565824,
"scriptDurationMs": 5408.701,
"eventListeners": -69,
"totalBlockingTimeMs": 72,
"frameDurationMs": 24.084451219512193,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8401.252999999997,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.39700000000000063,
"layouts": 1,
"layoutDurationMs": 0.278,
"taskDurationMs": 7473.110999999999,
"heapDeltaBytes": 65268912,
"heapUsedBytes": 142340284,
"domNodes": -274,
"jsHeapTotalBytes": 60944384,
"scriptDurationMs": 5768.167,
"eventListeners": -69,
"totalBlockingTimeMs": 77,
"frameDurationMs": 24.046571428571426,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8431.791000000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.24500000000000044,
"layouts": 1,
"layoutDurationMs": 0.24799999999999994,
"taskDurationMs": 7582.595,
"heapDeltaBytes": 69234604,
"heapUsedBytes": 145701736,
"domNodes": -274,
"jsHeapTotalBytes": 75886592,
"scriptDurationMs": 5931.888,
"eventListeners": -69,
"totalBlockingTimeMs": 123,
"frameDurationMs": 24.73020527859237,
"p95FrameDurationMs": 33.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7677.137000000016,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5820000000000001,
"layouts": 2,
"layoutDurationMs": 0.4810000000000001,
"taskDurationMs": 6874.586000000001,
"heapDeltaBytes": 57747176,
"heapUsedBytes": 134147836,
"domNodes": -274,
"jsHeapTotalBytes": 51507200,
"scriptDurationMs": 5303.456,
"eventListeners": -69,
"totalBlockingTimeMs": 79,
"frameDurationMs": 24.10817610062893,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 193.00499999999943,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.198,
"layouts": 8,
"layoutDurationMs": 2.3259999999999996,
"taskDurationMs": 146.72000000000003,
"heapDeltaBytes": 14925132,
"heapUsedBytes": 73721772,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.087000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912499999999966,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 221.38799999999037,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.426,
"layouts": 10,
"layoutDurationMs": 2.6569999999999996,
"taskDurationMs": 184.63400000000001,
"heapDeltaBytes": 14804792,
"heapUsedBytes": 90645148,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 13.613999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.199999999999985,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2042.1040000000232,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0509999999999997,
"layouts": 8,
"layoutDurationMs": 1.769,
"taskDurationMs": 562.899,
"heapDeltaBytes": -17659576,
"heapUsedBytes": 63760892,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.42400000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.0269999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9960000000000004,
"layouts": 9,
"layoutDurationMs": 1.8809999999999998,
"taskDurationMs": 560.4449999999999,
"heapDeltaBytes": -17874192,
"heapUsedBytes": 65238528,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.686000000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2417.494000000005,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.995,
"layouts": 8,
"layoutDurationMs": 1.838,
"taskDurationMs": 1410.95,
"heapDeltaBytes": 215120,
"heapUsedBytes": 82874492,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 670.526,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2538.0010000000084,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.066999999999998,
"layouts": 7,
"layoutDurationMs": 1.711,
"taskDurationMs": 1426.194,
"heapDeltaBytes": -21087756,
"heapUsedBytes": 62726508,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 672.052,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3634.3259999999873,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.151,
"layouts": 65,
"layoutDurationMs": 10.37,
"taskDurationMs": 1547.955,
"heapDeltaBytes": -5149088,
"heapUsedBytes": 71752876,
"domNodes": -250,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 663.118,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3550.3049999999803,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.276,
"layouts": 65,
"layoutDurationMs": 9.832,
"taskDurationMs": 1471.823,
"heapDeltaBytes": 11611320,
"heapUsedBytes": 97016132,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 649.8580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2627.8599999999983,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.293000000000001,
"layouts": 6,
"layoutDurationMs": 1.424,
"taskDurationMs": 1701.506,
"heapDeltaBytes": -6730248,
"heapUsedBytes": 82369484,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 834.108,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.772611464968154,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2696.472999999969,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.397,
"layouts": 6,
"layoutDurationMs": 1.4170000000000003,
"taskDurationMs": 1707.344,
"heapDeltaBytes": -5693872,
"heapUsedBytes": 81192756,
"domNodes": 0,
"jsHeapTotalBytes": 5992448,
"scriptDurationMs": 826.4560000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.770625000000003,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2983.6360000000186,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0010000000000003,
"layouts": 7,
"layoutDurationMs": 1.7409999999999999,
"taskDurationMs": 693.1619999999999,
"heapDeltaBytes": 7675556,
"heapUsedBytes": 80760680,
"domNodes": -274,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 304.29200000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2954.6060000000125,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9960000000000004,
"layouts": 7,
"layoutDurationMs": 1.7080000000000002,
"taskDurationMs": 658.387,
"heapDeltaBytes": -10110200,
"heapUsedBytes": 74924112,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 288.32599999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665730337078653,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.9250000000106,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.699,
"layouts": 8,
"layoutDurationMs": 1.6219999999999997,
"taskDurationMs": 567.895,
"heapDeltaBytes": -4028896,
"heapUsedBytes": 78627732,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.37800000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2032.6290000000427,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4810000000000005,
"layouts": 6,
"layoutDurationMs": 1.375,
"taskDurationMs": 545.591,
"heapDeltaBytes": 8126472,
"heapUsedBytes": 84547964,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 28.803999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2787.2200000000194,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.345999999999998,
"layouts": 8,
"layoutDurationMs": 1.8899999999999997,
"taskDurationMs": 505.29100000000005,
"heapDeltaBytes": -7598588,
"heapUsedBytes": 65665648,
"domNodes": -260,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 154.978,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665868263473055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2687.8299999999626,
"styleRecalcs": 26,
"styleRecalcDurationMs": 10.752,
"layouts": 7,
"layoutDurationMs": 1.609,
"taskDurationMs": 465.588,
"heapDeltaBytes": 7979844,
"heapUsedBytes": 93168336,
"domNodes": 19,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 154.838,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66645962732919,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3046.849000000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.855,
"layouts": 8,
"layoutDurationMs": 1.52,
"taskDurationMs": 787.517,
"heapDeltaBytes": -3970848,
"heapUsedBytes": 81736920,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 303.51800000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3085.4980000000296,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9269999999999998,
"layouts": 9,
"layoutDurationMs": 1.7690000000000001,
"taskDurationMs": 790.1709999999999,
"heapDeltaBytes": -14473484,
"heapUsedBytes": 62375284,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 293.20199999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.4939999999597,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.4350000000000005,
"layouts": 10,
"layoutDurationMs": 2.5260000000000002,
"taskDurationMs": 400.015,
"heapDeltaBytes": 24886744,
"heapUsedBytes": 88060184,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 130.384,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.9209999999848,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.636,
"layouts": 10,
"layoutDurationMs": 2.3249999999999997,
"taskDurationMs": 379.015,
"heapDeltaBytes": 25011552,
"heapUsedBytes": 87696304,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 124.229,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2025.6129999999928,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6470000000000002,
"layouts": 9,
"layoutDurationMs": 2.3989999999999996,
"taskDurationMs": 547.913,
"heapDeltaBytes": -5645536,
"heapUsedBytes": 69618356,
"domNodes": -200,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 10.556000000000001,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.723999999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.836,
"layouts": 9,
"layoutDurationMs": 2.4850000000000003,
"taskDurationMs": 517.381,
"heapDeltaBytes": -12745624,
"heapUsedBytes": 66012128,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.317,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.2430000000113,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.825000000000001,
"layouts": 9,
"layoutDurationMs": 2.1519999999999997,
"taskDurationMs": 776.766,
"heapDeltaBytes": 12198588,
"heapUsedBytes": 74277200,
"domNodes": -200,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 96.618,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.1069999999977,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.622000000000002,
"layouts": 10,
"layoutDurationMs": 2.4029999999999996,
"taskDurationMs": 769.9749999999999,
"heapDeltaBytes": 3773468,
"heapUsedBytes": 67353516,
"domNodes": -192,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 96.51799999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1457.9889999999978,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.859,
"layouts": 5,
"layoutDurationMs": 14.427,
"taskDurationMs": 1091.888,
"heapDeltaBytes": -9870808,
"heapUsedBytes": 81284876,
"domNodes": 9212,
"jsHeapTotalBytes": 18874368,
"scriptDurationMs": 27.909999999999997,
"eventListeners": -262,
"totalBlockingTimeMs": 143,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9694.08500000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.982000000000003,
"layouts": 9,
"layoutDurationMs": 2.2009999999999996,
"taskDurationMs": 5131.265,
"heapDeltaBytes": -7902892,
"heapUsedBytes": 74262888,
"domNodes": -274,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2299.375,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10551.238999999952,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.871000000000002,
"layouts": 9,
"layoutDurationMs": 2.0289999999999995,
"taskDurationMs": 5240.6179999999995,
"heapDeltaBytes": -18884872,
"heapUsedBytes": 64270636,
"domNodes": -274,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 2335.659,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665930599369087,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21415.10599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20969.031,
"heapDeltaBytes": -12396316,
"heapUsedBytes": 286214100,
"domNodes": -3482,
"jsHeapTotalBytes": 12828672,
"scriptDurationMs": 294.99600000000004,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.626534296028886,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 21148.72300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20608.903,
"heapDeltaBytes": -30652704,
"heapUsedBytes": 280175364,
"domNodes": -3482,
"jsHeapTotalBytes": 13352960,
"scriptDurationMs": 271.653,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.30035273368607,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 25898.10399999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.703000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25587.529,
"heapDeltaBytes": -26415592,
"heapUsedBytes": 270590632,
"domNodes": -3482,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 835.48,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.74203454894434,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25627.41399999993,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.311000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25396.703,
"heapDeltaBytes": -42602540,
"heapUsedBytes": 260154636,
"domNodes": -3482,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 807.9269999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.97839388145315,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7607.011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.71699999999999,
"layouts": 20,
"layoutDurationMs": 23.66700000000001,
"taskDurationMs": 7543.480999999999,
"heapDeltaBytes": -6157252,
"heapUsedBytes": 278775468,
"domNodes": -2408,
"jsHeapTotalBytes": 16498688,
"scriptDurationMs": 142.149,
"eventListeners": -431,
"totalBlockingTimeMs": 111,
"frameDurationMs": 46.160000000000004,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7578.234000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.824,
"layouts": 20,
"layoutDurationMs": 27.342999999999993,
"taskDurationMs": 7460.088999999999,
"heapDeltaBytes": -31151788,
"heapUsedBytes": 257507216,
"domNodes": -3482,
"jsHeapTotalBytes": 18857984,
"scriptDurationMs": 107.94999999999999,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.87041420118343,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10675.085000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10500.508,
"heapDeltaBytes": 10398644,
"heapUsedBytes": 267772392,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.08400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.504444444444445,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10575.436000000082,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10423.72,
"heapDeltaBytes": -24803236,
"heapUsedBytes": 260150772,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.86499999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.931541218637996,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 119.69699999997374,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.359000000000002,
"layouts": 7,
"layoutDurationMs": 2.9760000000000004,
"taskDurationMs": 91.672,
"heapDeltaBytes": -11442888,
"heapUsedBytes": 63650108,
"domNodes": 135,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7.494000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 132.14700000003177,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.757,
"layouts": 9,
"layoutDurationMs": 3.0889999999999995,
"taskDurationMs": 73.64399999999999,
"heapDeltaBytes": 4921908,
"heapUsedBytes": 66646428,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.471000000000002,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 327.33299999995324,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.628,
"layouts": 76,
"layoutDurationMs": 12.318000000000001,
"taskDurationMs": 297.796,
"heapDeltaBytes": -4115836,
"heapUsedBytes": 40019108,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 134.46800000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 372.26399999997284,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.605,
"layouts": 76,
"layoutDurationMs": 12.161999999999999,
"taskDurationMs": 333.495,
"heapDeltaBytes": -4123992,
"heapUsedBytes": 40050680,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 156.915,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660869565217382,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 375.6500000000642,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.509,
"layouts": 76,
"layoutDurationMs": 11.379,
"taskDurationMs": 343.782,
"heapDeltaBytes": -823136,
"heapUsedBytes": 95617388,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 129.388,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660869565217382,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 428.9569999999685,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.183,
"layouts": 76,
"layoutDurationMs": 12.764,
"taskDurationMs": 395.552,
"heapDeltaBytes": -179808,
"heapUsedBytes": 102319944,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 149.67,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3238 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c1e082bb913e151b5ba39b6ad32be32ca8397cd0
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (394)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #23270 +/- ##
===============================================
+ Coverage 59.33% 87.46% +28.13%
===============================================
Files 2356 2921 +565
Lines 103544 161162 +57618
Branches 0 43201 +43201
===============================================
+ Hits 61434 140955 +79521
+ Misses 42110 19444 -22666
- Partials 0 763 +763
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2564 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… open When a workflow-id link was replaced while its graph loaded, the workflow that stayed open was reloaded and its tracker reset, so its unsaved edits became the saved state. An Undo then marked it clean and closing it dropped the draft without asking. The restore now keeps the saved baseline of a modified workflow, as a reload already does.
…ed open A cancelled open cleans the canvas before it stops, and the restore of the workflow that stayed open saved that empty canvas over the outputs and preview images it had already put aside, then released them. Loading a new graph now skips saving the outgoing workflow when the canvas no longer shows it.
… open The restore of the workflow that stayed open was queued behind any graph load already waiting, such as a pasted workflow, and then replaced it on the canvas. A graph load given isCurrent now skips when it is no longer current by the time its turn comes, and the restore is current only while that workflow is still selected and the canvas does not show it.
…restored after a cancelled open
… subgraph While workflow A runs and an open of B is pending, a preview frame for a node inside one of A's subgraphs is resolved against B's graph, which is already on the canvas, so it lands under B's subgraph id. When the open is superseded and A is restored, that entry was merged into A's stash and copied back, where A's later frames never replace it and its blob stays retained. Restoring a workflow's previews now drops and releases any stashed preview whose subgraph is not in the restored graph. The subgraph frame that arrived in that window is lost; the subgraph container node on A's root keeps it, and A's next frame for that node replaces it.
## Summary A workflow-id link whose file read fails (the server returns 500) sent the file name, for example `workflows/Customer Jane Doe.json`, to Sentry and Datadog. The file read's error named the path, and the workflow load queue reported that error before the link loader could replace it with a fixed message. Now the error carries only the status: `Failed to load file: 500 Internal Server Error`. Open link A to a workflow with a Load3D node, then link B while A is still loading: A's graph appeared on the canvas under B's address. Load3D loads its code before the graph is set up, and the open did not check again after that wait. Now `loadGraphData` checks that the open is still current after that wait. A replaced open stops before the graph is set up, and the workflow that was open is painted back. That repaint keeps its saved state, so unsaved edits stay marked unsaved. It keeps its outputs and preview images. It is skipped when a newer load, such as a pasted workflow, has taken the canvas. A graph load whose open was replaced while it waited in the queue now skips without touching the canvas. Open link A that also has `settings=plan-credits`, then link B that the sign-in guard holds: B never opened. After A's URL cleanup was cancelled, the Settings loader replaced the URL with A's query. That wrote A over B's saved link and cancelled B's navigation. Now, while a newer link waits, the loaders after the workflow-id link (Settings, top-up, pricing, invite, assets, local handoff) and the final sweep do not run, so B lands. Their params stay saved for the next page load. Type in the expanded text editor, then open link A and link B before A's graph load starts: the workflow lost its unsaved mark. The draft saver then deleted the unsaved copy, and reloading the page no longer warned, so the text was lost. The editor marks the workflow unsaved without recording the edit, and the skipped repaint reset that mark. Now a repaint that is skipped leaves the workflow as it was. The saved state is put back only when the repaint ran. A running workflow's node preview could go back to an older frame after a replaced open. A frame that arrived while the replaced open was loading was dropped, and the repaint showed the frame stored before it. Now that frame is added to the stored previews and wins over the older one. An open replaced while an extension's `afterConfigureGraph` hook ran still activated its workflow. Now the load checks again after that hook, stops, and the workflow that was open is painted back. A preview frame for a node inside a subgraph that arrived while a replaced open loaded was kept under the other workflow's subgraph. The running workflow's later frames never replaced it, so its image stayed in memory. Now the repaint drops previews for subgraphs the workflow does not have, and that node shows the next frame. **Why**: the self-review of the `cloud/1.60` backport (Comfy-Org#23265) found the first three. The self-reviews of this PR and Comfy-Org#23270 found the unsaved mark and the preview frame, and CodeRabbit found the `afterConfigureGraph` case. The same code is on `main`. Ref DPLAT-3900 ## Verification Tested (focused vitest files; each new test failed with its fix reverted and passes with it): - `src/platform/workflow/core/services/workflowService.test.ts`: "reports the failed read without the file name" (real workflow service and file store, HTTP 500). - `src/scripts/app.test.ts`: "does not configure or activate a graph whose load stopped being current during beforeConfigureGraph". - `src/platform/workflow/core/services/workflowService.test.ts`: "keeps the current workflow when the open is superseded while its graph loads". - `src/platform/workflow/core/services/workflowService.test.ts`: "keeps the saved baseline of a modified workflow kept by a superseded open", "keeps the outputs and previews of a workflow kept by a superseded open", "keeps a workflow pasted while a superseded open was loading". - `src/scripts/app.test.ts`: "leaves the canvas untouched for a load that stopped being current while it waited its turn". - `src/platform/workflow/core/services/workflowService.test.ts`: "keeps an uncaptured edit modified when a superseded open skips restoring its workflow", "keeps a preview that arrived while a superseded open was loading". - `src/stores/nodeOutputStore.workflowSwitch.test.ts`: "adds a frame that arrived while the workflow was off the canvas to its stash". - `src/scripts/app.test.ts`: "does not activate a graph whose load stopped being current during afterConfigureGraph". - `src/platform/workflow/core/services/workflowService.test.ts`: "does not keep a subgraph preview resolved against a superseded open". - "reports the failed read without the file name" now also checks the error's `cause`. It fails when the path is put in the cause, and passes on this code. - `src/platform/workflow/management/composables/useWorkflowLinkUrlLoader.test.ts`: "lets a newer link held in a navigation guard land when the older link also opens Settings" (real router, query tracker and Settings loader; only the Settings dialog is mocked). - Also passing: `src/stores/userFileStore.test.ts`, `src/composables/useUrlActionLoaders.test.ts`, `src/platform/settings/composables/useSettingsUrlLoader.test.ts`, `src/platform/settings/composables/useSettingsUrlLoader.integration.test.ts`. Not run: browser e2e (`browser_tests/tests/workflow/cloudWorkflowLink.spec.ts`).
Backport of #23269 to
cloud/1.60.#23265 brought workflow-id links to
cloud/1.60. Its self-review found problems in that code, and the self-reviews of #23269 and this PR found more. #23269 fixes them onmain:afterConfigureGraphhook stops before it activates.Why: #23265 put this code on
cloud/1.60, so the file name in failed-read error reports and the other bugs above are on that branch too. Waiting for #23269 to merge before backporting would leave them there longer.The first three commits are cherry-picked with
-x. One conflict:workflowService.test.tskeepscloud/1.60's tests and adds only the new failed-read test. The next three commits follow #23269's repaint fixes.cloud/1.60has no canvas ownership tracking, so the workflow service keeps one flag for whether the canvas still shows the selected workflow. The next four commits are cherry-picked from #23269's later fixes; their tests drop the canvas ownership calls thatcloud/1.60does not have. One more commit makes the saved-baseline test run the outgoing load first: before, the repaint never ran in that test, so it passed without the fix. Each new test failed with its fix reverted and passes with it on this branch.Linear: https://linear.app/comfyorg/issue/DPLAT-3900
Not run: browser e2e (
browser_tests/tests/workflow/cloudWorkflowLink.spec.ts).