Repository navigation
[backport cloud/1.59] feat: relay a Desktop workflow to Comfy Cloud through the system browser (#23075) - #23154
Conversation
…hrough the system browser (#23075) Backport of #23075 (05821fe) to cloud/1.59. Adapted for cloud/1.59: - AddCreditsDialogContent.vue is dropped: it was added on main by #22760, which is not on cloud/1.59, so its handsPopupsToSystemBrowser import move has nothing to apply to. - Imports point at in-tree modules instead of the packages extracted on main: @comfyorg/telemetry/reportError and @comfyorg/graph-model/workflowSchema. (cherry picked from commit 05821fe)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-09T16:20:46.099Z",
"gitSha": "bb54f07fd494232761797af78ee8efa5c5647bfa",
"branch": "backport-23075-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2036.4320000000191,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4210000000000003,
"layouts": 10,
"layoutDurationMs": 2.4229999999999996,
"taskDurationMs": 442.85200000000003,
"heapDeltaBytes": -8819844,
"heapUsedBytes": 53361124,
"domNodes": -161,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 7.7349999999999985,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2009.157000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.899,
"layouts": 9,
"layoutDurationMs": 2.627,
"taskDurationMs": 443.30099999999993,
"heapDeltaBytes": 2221452,
"heapUsedBytes": 63483544,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.032,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.909999999993,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.42,
"layouts": 10,
"layoutDurationMs": 2.433,
"taskDurationMs": 720.318,
"heapDeltaBytes": 22048024,
"heapUsedBytes": 82548264,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 122.824,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.9619999999536,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.862000000000002,
"layouts": 10,
"layoutDurationMs": 2.6639999999999997,
"taskDurationMs": 784.053,
"heapDeltaBytes": -7798720,
"heapUsedBytes": 55127260,
"domNodes": -161,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 128.761,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.6490000000422,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.367999999999999,
"layouts": 10,
"layoutDurationMs": 2.496,
"taskDurationMs": 348.54699999999997,
"heapDeltaBytes": 24437196,
"heapUsedBytes": 86617868,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.844,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.7060000000356,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.8709999999999996,
"layouts": 11,
"layoutDurationMs": 2.848,
"taskDurationMs": 433.22700000000003,
"heapDeltaBytes": 2628480,
"heapUsedBytes": 79716500,
"domNodes": 56,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 15.419000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 549.2670000000146,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.474,
"layouts": 9,
"layoutDurationMs": 2.0949999999999998,
"taskDurationMs": 406.67299999999994,
"heapDeltaBytes": 3361792,
"heapUsedBytes": 65156492,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 138.52100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 568.0780000000141,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.595,
"layouts": 9,
"layoutDurationMs": 2.275,
"taskDurationMs": 415.28999999999996,
"heapDeltaBytes": 8320164,
"heapUsedBytes": 78315580,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 138.02700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1067.5080000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 726.341,
"heapDeltaBytes": -12010612,
"heapUsedBytes": 75862704,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 50.184999999999995,
"eventListeners": -107,
"totalBlockingTimeMs": 393,
"frameDurationMs": 28.82972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1035.694000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.491,
"heapDeltaBytes": -1626132,
"heapUsedBytes": 75808516,
"domNodes": -191,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 47.52199999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 366,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.567000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.8100000000001,
"heapDeltaBytes": -4747236,
"heapUsedBytes": 70209580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.733,
"eventListeners": 0,
"totalBlockingTimeMs": 153,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.084999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.2899999999998,
"heapDeltaBytes": -4147624,
"heapUsedBytes": 70967956,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.56799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.04117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7962.878000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7093.457,
"heapDeltaBytes": 17579656,
"heapUsedBytes": 78853840,
"domNodes": -257,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 5568.5869999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 99,
"frameDurationMs": 24.31100917431193,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7588.783999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6738.483,
"heapDeltaBytes": 740776,
"heapUsedBytes": 79846396,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5251.877,
"eventListeners": 0,
"totalBlockingTimeMs": 83,
"frameDurationMs": 24.30480769230769,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7100.324999999998,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7279999999999995,
"layouts": 3,
"layoutDurationMs": 0.6129999999999999,
"taskDurationMs": 6433.241000000001,
"heapDeltaBytes": -10149516,
"heapUsedBytes": 78633632,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 5034.198,
"eventListeners": -69,
"totalBlockingTimeMs": 145,
"frameDurationMs": 24.910877192982454,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8139.246000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6939999999999993,
"layouts": 3,
"layoutDurationMs": 0.849,
"taskDurationMs": 7332.188999999999,
"heapDeltaBytes": 63194548,
"heapUsedBytes": 136298384,
"domNodes": -257,
"jsHeapTotalBytes": 55439360,
"scriptDurationMs": 5735.316,
"eventListeners": -69,
"totalBlockingTimeMs": 85,
"frameDurationMs": 24.06213017751479,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 207.83199999999624,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.566000000000003,
"layouts": 10,
"layoutDurationMs": 2.413,
"taskDurationMs": 167.425,
"heapDeltaBytes": -7346220,
"heapUsedBytes": 75538824,
"domNodes": 936,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.442,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 180.7099999999764,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.169999999999998,
"layouts": 10,
"layoutDurationMs": 2.676,
"taskDurationMs": 144.66400000000002,
"heapDeltaBytes": 14524172,
"heapUsedBytes": 90603124,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 6.9270000000000005,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.233333333333324,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2037.8939999999943,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4450000000000003,
"layouts": 8,
"layoutDurationMs": 2.29,
"taskDurationMs": 582.851,
"heapDeltaBytes": 10231432,
"heapUsedBytes": 84274172,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 32.035999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.7410000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.489,
"layouts": 8,
"layoutDurationMs": 2.227,
"taskDurationMs": 593.2780000000001,
"heapDeltaBytes": -12173016,
"heapUsedBytes": 62758636,
"domNodes": -257,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 35.895,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2937.956000000014,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.229000000000001,
"layouts": 5,
"layoutDurationMs": 1.1539999999999997,
"taskDurationMs": 1435.8459999999998,
"heapDeltaBytes": 15577872,
"heapUsedBytes": 76316096,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 688.352,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666477272727274,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2767.3369999999977,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.835,
"layouts": 8,
"layoutDurationMs": 2.129,
"taskDurationMs": 1488.0460000000003,
"heapDeltaBytes": -3472684,
"heapUsedBytes": 72422312,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 699.218,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3752.4669999999674,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.017000000000001,
"layouts": 64,
"layoutDurationMs": 10.44,
"taskDurationMs": 1564.599,
"heapDeltaBytes": -2588040,
"heapUsedBytes": 74935684,
"domNodes": -233,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 682.7220000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622222222222,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3639.4059999999513,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.499999999999998,
"layouts": 66,
"layoutDurationMs": 10.945,
"taskDurationMs": 1549.2140000000002,
"heapDeltaBytes": -9901080,
"heapUsedBytes": 70522136,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 656.749,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66559633027523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2996.2679999999864,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.905,
"layouts": 7,
"layoutDurationMs": 1.823,
"taskDurationMs": 1755.7849999999999,
"heapDeltaBytes": 20634380,
"heapUsedBytes": 99881188,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 850.2379999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759550561797756,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2842.4550000000295,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.42,
"layouts": 5,
"layoutDurationMs": 1.8950000000000005,
"taskDurationMs": 1778.63,
"heapDeltaBytes": -9194956,
"heapUsedBytes": 64030220,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 868.9010000000001,
"eventListeners": 113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.764117647058825,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2941.3680000000113,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8290000000000008,
"layouts": 9,
"layoutDurationMs": 1.7969999999999997,
"taskDurationMs": 608.3079999999999,
"heapDeltaBytes": -7345348,
"heapUsedBytes": 68945832,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 282.46900000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915255,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2973.973000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4619999999999997,
"layouts": 8,
"layoutDurationMs": 2.11,
"taskDurationMs": 665.749,
"heapDeltaBytes": 3092184,
"heapUsedBytes": 79441440,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 295.39099999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.264999999958,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.862999999999999,
"layouts": 8,
"layoutDurationMs": 2.5140000000000002,
"taskDurationMs": 654.6950000000002,
"heapDeltaBytes": -19241060,
"heapUsedBytes": 63527472,
"domNodes": -257,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 35.458000000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.079000000067,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.306,
"layouts": 8,
"layoutDurationMs": 2.132,
"taskDurationMs": 525.014,
"heapDeltaBytes": 1359356,
"heapUsedBytes": 81884164,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 32.275,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2686.408999999998,
"styleRecalcs": 24,
"styleRecalcDurationMs": 9.732000000000001,
"layouts": 5,
"layoutDurationMs": 0.98,
"taskDurationMs": 427.265,
"heapDeltaBytes": 1250124,
"heapUsedBytes": 62688348,
"domNodes": 19,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2758.2909999999856,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.289,
"layouts": 8,
"layoutDurationMs": 2.2270000000000003,
"taskDurationMs": 511.92100000000005,
"heapDeltaBytes": -26493008,
"heapUsedBytes": 66547420,
"domNodes": -241,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 157.66,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240963,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2999.281999999994,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1149999999999998,
"layouts": 5,
"layoutDurationMs": 1.0090000000000003,
"taskDurationMs": 683.1350000000001,
"heapDeltaBytes": 6259836,
"heapUsedBytes": 68338372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 271.843,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665555555555553,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3076.6480000000342,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8650000000000004,
"layouts": 7,
"layoutDurationMs": 1.6940000000000002,
"taskDurationMs": 794.5409999999999,
"heapDeltaBytes": -7523036,
"heapUsedBytes": 69846544,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 304.15700000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.1030000000064,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.984,
"layouts": 11,
"layoutDurationMs": 2.7550000000000003,
"taskDurationMs": 361.556,
"heapDeltaBytes": -13596,
"heapUsedBytes": 62801444,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 120.00300000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.2840000000433,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.494999999999999,
"layouts": 9,
"layoutDurationMs": 2.198,
"taskDurationMs": 361.73699999999997,
"heapDeltaBytes": 342636,
"heapUsedBytes": 62727192,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 119.52,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2035.0050000000124,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8130000000000006,
"layouts": 9,
"layoutDurationMs": 2.706,
"taskDurationMs": 563.183,
"heapDeltaBytes": -9769812,
"heapUsedBytes": 52729592,
"domNodes": -183,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.649,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.680000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.933,
"layouts": 11,
"layoutDurationMs": 2.562,
"taskDurationMs": 481.28399999999993,
"heapDeltaBytes": -14139256,
"heapUsedBytes": 58084332,
"domNodes": -183,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 8.849999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8089999999875,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.326,
"layouts": 9,
"layoutDurationMs": 2.394,
"taskDurationMs": 743.6590000000001,
"heapDeltaBytes": 19720716,
"heapUsedBytes": 82777852,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 99.55699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.0960000000036,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.617999999999999,
"layouts": 8,
"layoutDurationMs": 2.2650000000000006,
"taskDurationMs": 748.215,
"heapDeltaBytes": -9117300,
"heapUsedBytes": 54435656,
"domNodes": -168,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 95.244,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1334.3489999999747,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.837000000000007,
"layouts": 5,
"layoutDurationMs": 10.329999999999998,
"taskDurationMs": 869.9020000000002,
"heapDeltaBytes": 38225324,
"heapUsedBytes": 114749416,
"domNodes": 16030,
"jsHeapTotalBytes": 4329472,
"scriptDurationMs": 24.648000000000003,
"eventListeners": 3246,
"totalBlockingTimeMs": 113,
"frameDurationMs": 19.012676056338023,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9945.952000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.799,
"layouts": 8,
"layoutDurationMs": 1.8070000000000002,
"taskDurationMs": 5111.677000000001,
"heapDeltaBytes": 1869832,
"heapUsedBytes": 76102936,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2327.4820000000004,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665829145728644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9514.184999999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.148999999999997,
"layouts": 9,
"layoutDurationMs": 1.946,
"taskDurationMs": 4988.465,
"heapDeltaBytes": -14581400,
"heapUsedBytes": 61943412,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 2247.352,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666140350877193,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 21313.06000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20503.075,
"heapDeltaBytes": -29349852,
"heapUsedBytes": 267148860,
"domNodes": -3343,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 311.245,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.84369602763386,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20594.309000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19848.049,
"heapDeltaBytes": -2362928,
"heapUsedBytes": 281113988,
"domNodes": -3343,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 278.263,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.784285714285716,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24560.464000000025,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.30599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24207.325,
"heapDeltaBytes": -51887052,
"heapUsedBytes": 249801752,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 745.5970000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.79180952380952,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24056.359000000044,
"styleRecalcs": 179,
"styleRecalcDurationMs": 19.313999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23810.49,
"heapDeltaBytes": -22281036,
"heapUsedBytes": 255791108,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 737.092,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 45.98279158699809,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 7370.715000000018,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.90199999999998,
"layouts": 20,
"layoutDurationMs": 23.702,
"taskDurationMs": 7232.673000000001,
"heapDeltaBytes": -13363776,
"heapUsedBytes": 285510916,
"domNodes": -307,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 111.91199999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.58034682080925,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7344.153000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.95399999999999,
"layouts": 20,
"layoutDurationMs": 20.83099999999999,
"taskDurationMs": 7143.912,
"heapDeltaBytes": -17224404,
"heapUsedBytes": 275328160,
"domNodes": -3343,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 105.243,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.239080459770115,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10046.312999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9620.6,
"heapDeltaBytes": -1436676,
"heapUsedBytes": 259256872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.76299999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.83148788927336,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10085.848000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9710.533,
"heapDeltaBytes": -1151148,
"heapUsedBytes": 260124524,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.86999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.592753623188415,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 119.5849999999723,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.624999999999998,
"layouts": 10,
"layoutDurationMs": 3.411,
"taskDurationMs": 86.06000000000002,
"heapDeltaBytes": 4914896,
"heapUsedBytes": 64776336,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.909,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 144.71500000001924,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.809000000000001,
"layouts": 9,
"layoutDurationMs": 3.497,
"taskDurationMs": 117.954,
"heapDeltaBytes": -13226252,
"heapUsedBytes": 61112940,
"domNodes": 124,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 5.986999999999999,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 324.0579999999227,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.596,
"layouts": 76,
"layoutDurationMs": 12.25,
"taskDurationMs": 289.95,
"heapDeltaBytes": -5208460,
"heapUsedBytes": 37095964,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 132.479,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263162,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 384.1859999999997,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5820000000000001,
"layouts": 76,
"layoutDurationMs": 13.289,
"taskDurationMs": 337.76800000000003,
"heapDeltaBytes": -4458636,
"heapUsedBytes": 39015732,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 159.611,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66086956521742,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 358.4250000000111,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.511,
"layouts": 76,
"layoutDurationMs": 11.726,
"taskDurationMs": 325.389,
"heapDeltaBytes": -1214676,
"heapUsedBytes": 90002660,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.465,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661904761904786,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 345.7270000000108,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.488,
"layouts": 76,
"layoutDurationMs": 12.218,
"taskDurationMs": 314.718,
"heapDeltaBytes": -921072,
"heapUsedBytes": 100765788,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.523,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661904761904744,
"p95FrameDurationMs": 16.700000000000728
}
]
}🎭 Playwright: ✅ 3147 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a0aaf4a2993295df3ba796e5fecd247c4e1789e2
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (315)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport of #23075, per the requested backport review policy. No code-change review or tests were performed.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.59 #23154 +/- ##
=============================================
Coverage ? 86.76%
=============================================
Files ? 2726
Lines ? 141127
Branches ? 40768
=============================================
Hits ? 122446
Misses ? 17863
Partials ? 818
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…ndoff (#23501) ## Summary Use the Comfy Cloud video and updated copy in the deployment dialogs. Keep the agent choice explicit and prefill an unsent handoff without replacing an existing draft. Backport of #23463 — show the Comfy Cloud video in the deployment dialogs Backport of #23475 — frame Deploy your setup around running workflows on Comfy Cloud Backport of #23470 — preserve agent choice and update Cloud handoff Keeps the release branch’s UI and telemetry imports and retains its consent tests. With Open on Cloud enabled, Desktop and Desktop 2 now show the toolbar button. The target branch already includes the system-browser relay (backport #23154). Local and Desktop handoffs reference a saved workflow on the server; Cloud handoffs still export JSON. The separate Deploy to Comfy API dialog now asks localhost users to export the workflow themselves. ## Verification - Commit hooks passed, including changed-file lint and app type checking. - Both video formats and the poster returned HTTP 200 with the expected media type. - 734 tests passed across eight focused suites (toolbar, dialog, agent consent and composer, and handoff). - 36 tests passed across the Desktop relay, Cloud receiver, and handoff protocol suites. --------- Co-authored-by: Willie <falloon.willie@gmail.com> Co-authored-by: huang47 <157390+huang47@users.noreply.github.com>
Backport of #23075 to
cloud/1.59. Opened by hand: the PR Backport workflow is hittingstartup_failure(everypull_request_targetworkflow since 16:03 UTC), and a cherry-pick conflicts here anyway.Adapted for cloud/1.59:
AddCreditsDialogContent.vueis dropped. It was added on main by FRONT-3643 feat(billing): open the shared Add credits dialog on Cloud and local #22760, which is not on cloud/1.59, so this PR's import move has nothing to apply to.@comfyorg/telemetry,@comfyorg/graph-model).Everything is behind
open_on_cloud_enabled(off). App and browser-test typecheck clean;openOnCloud,billing,distributionandTopMenuSectionunit suites pass.