Repository navigation
[backport cloud/1.60] feat: model uploads resume after a dropped connection, with reconnection and time left - #23131
Conversation
Model imports can continue after a dropped connection. The editor requests a resumable upload and sends one file slice at a time, using storage's confirmed range after a drop. Older servers still receive one PUT. When the server refuses resumable mode with `403 FEATURE_DISABLED`, the editor retries once with `resumable: false`. That request still passes the server's workspace, plan and storage checks. A file over 2 GiB also makes this retry, although the server's contract only offers it up to 2 GiB. The server answers `400 FILE_TOO_LARGE`, so the person sees "Files can be up to 2 GB." instead of "Upload failed. Try again.", which can never work. No bytes are sent for that file. **Why** A dropped connection currently ends the transfer and makes the next attempt send the whole file again. The new transfer supports the server's 25 GB upload mode while keeping the existing save task. Transport tests cover retained bytes after a partial piece, exact assembled content, missing ranges, completed status queries, capped backoff, expired sessions and cancellation. The existing single-PUT test covers older servers. CI on test-only commit `165dd94c1c` reproduced the HTTP 408 recovery failure and both stalled-request failures ([unit shard 5](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42264102527/job/128053434401)). Commit `28d0644cd5` adds a 30-second inactivity deadline for resumable requests, resets it as uploaded bytes advance, and retries HTTP 408. CI on that fix passed all 39 upload API tests ([unit shard 5](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42266161675/job/128060400938)); all eight unit shards passed. CI on test-only commit `de4235e136` failed five fallback cases because the start request stopped before retrying ([unit shard 5](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42307560437/job/128201803266)). The 12-byte and exactly 2 GiB cases never sent a PUT. Refused-retry and cancellation cases never reached the second start request. The over-2-GiB refusal passed. Fix `85660363a4` adds the bounded retry with those tests unchanged. CI on `98eccf9e0d` (the fix plus automated formatting) passes all 45 upload API tests ([unit shard 5](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42311684931/job/128215508938)); all eight unit shards pass. The over-2-GiB case changed in `e7ddeb8798`. Its updated test failed before the fix, with `reason: 'failed'` where `tooLarge` was expected, and all 45 upload API tests pass after it, both run locally on that one test file. CI on this head is running. Not run locally: the rest of the unit tests, browser uploads or a real 10 GB transfer. Browser CORS and full-size transfer remain to be exercised. Ref BE-25019 (cherry picked from commit 6212fca)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-08T14:27:42.784Z",
"gitSha": "8acb2ce6d7663354d7a890d03dc6cdf4f111287f",
"branch": "backport-23081-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.3059999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0820000000000007,
"layouts": 9,
"layoutDurationMs": 2.541,
"taskDurationMs": 521.353,
"heapDeltaBytes": -14088908,
"heapUsedBytes": 63386248,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 10.54,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2008.6779999999749,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.88,
"layouts": 9,
"layoutDurationMs": 2.881,
"taskDurationMs": 558.076,
"heapDeltaBytes": 8568432,
"heapUsedBytes": 70496460,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.226,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1703.801999999996,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.12,
"layouts": 9,
"layoutDurationMs": 2.4349999999999996,
"taskDurationMs": 766.021,
"heapDeltaBytes": 23585592,
"heapUsedBytes": 83677236,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 129.50599999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.191999999975,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.037000000000003,
"layouts": 9,
"layoutDurationMs": 2.3970000000000007,
"taskDurationMs": 860.8659999999999,
"heapDeltaBytes": -10589204,
"heapUsedBytes": 58004116,
"domNodes": -178,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 137.172,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.5570000000284,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.836999999999999,
"layouts": 11,
"layoutDurationMs": 2.765,
"taskDurationMs": 396.02700000000004,
"heapDeltaBytes": 25391584,
"heapUsedBytes": 86081968,
"domNodes": 57,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 13.148,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.436000000097,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.667,
"layouts": 11,
"layoutDurationMs": 2.6429999999999993,
"taskDurationMs": 411.66999999999996,
"heapDeltaBytes": 25406172,
"heapUsedBytes": 85595936,
"domNodes": 57,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 14.591,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 598.6120000000028,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.029,
"layouts": 10,
"layoutDurationMs": 2.471,
"taskDurationMs": 462.758,
"heapDeltaBytes": -14847872,
"heapUsedBytes": 61902992,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 147.30100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 607.496000000026,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0440000000000005,
"layouts": 9,
"layoutDurationMs": 2.6420000000000003,
"taskDurationMs": 449.632,
"heapDeltaBytes": -15377976,
"heapUsedBytes": 61385492,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 142.746,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1004.5819999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.788,
"heapDeltaBytes": 20878588,
"heapUsedBytes": 86623904,
"domNodes": 0,
"jsHeapTotalBytes": 11698176,
"scriptDurationMs": 50.82399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 370,
"frameDurationMs": 29.414705882352937,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1127.1919999999795,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.4889999999999,
"heapDeltaBytes": -14195364,
"heapUsedBytes": 74443240,
"domNodes": -208,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 54.539000000000016,
"eventListeners": -129,
"totalBlockingTimeMs": 451,
"frameDurationMs": 30.629729729729736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 810.2900000000091,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.5049999999999,
"heapDeltaBytes": -27441256,
"heapUsedBytes": 66562588,
"domNodes": -208,
"jsHeapTotalBytes": 4849664,
"scriptDurationMs": 126.65200000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 173,
"frameDurationMs": 23.331428571428557,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 828.3429999999612,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.29399999999987,
"heapDeltaBytes": -29666908,
"heapUsedBytes": 64420804,
"domNodes": -208,
"jsHeapTotalBytes": 5636096,
"scriptDurationMs": 121.65500000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 164,
"frameDurationMs": 23.14999999999999,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8068.985999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8179999999999993,
"layouts": 3,
"layoutDurationMs": 0.8209999999999997,
"taskDurationMs": 7240.591,
"heapDeltaBytes": 69328856,
"heapUsedBytes": 146705368,
"domNodes": -274,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 5582.108,
"eventListeners": -69,
"totalBlockingTimeMs": 71,
"frameDurationMs": 24.100898203592813,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8257.438999999977,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04500000000000077,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7279.101000000001,
"heapDeltaBytes": 63349856,
"heapUsedBytes": 138847220,
"domNodes": -274,
"jsHeapTotalBytes": 55439360,
"scriptDurationMs": 5527.651,
"eventListeners": -69,
"totalBlockingTimeMs": 68,
"frameDurationMs": 24.078488372093023,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7412.101999999976,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7480000000000004,
"layouts": 3,
"layoutDurationMs": 0.6899999999999996,
"taskDurationMs": 6616.015,
"heapDeltaBytes": 41960204,
"heapUsedBytes": 126638128,
"domNodes": -274,
"jsHeapTotalBytes": 59109376,
"scriptDurationMs": 5033.178000000001,
"eventListeners": -91,
"totalBlockingTimeMs": 107,
"frameDurationMs": 24.395723684210523,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8029.994999999985,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6750000000000003,
"layouts": 2,
"layoutDurationMs": 0.6050000000000001,
"taskDurationMs": 7139.744,
"heapDeltaBytes": 36343228,
"heapUsedBytes": 130340892,
"domNodes": -274,
"jsHeapTotalBytes": 66187264,
"scriptDurationMs": 5507.739,
"eventListeners": -69,
"totalBlockingTimeMs": 58,
"frameDurationMs": 23.787240356083085,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 211.4310000000046,
"styleRecalcs": 24,
"styleRecalcDurationMs": 11.705999999999998,
"layouts": 11,
"layoutDurationMs": 2.6649999999999996,
"taskDurationMs": 174.56099999999998,
"heapDeltaBytes": 14828628,
"heapUsedBytes": 90658324,
"domNodes": 936,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 7.438999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.690909090909084,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 213.7840000000324,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.993,
"layouts": 13,
"layoutDurationMs": 3.7390000000000003,
"taskDurationMs": 157.38500000000002,
"heapDeltaBytes": -6734180,
"heapUsedBytes": 75371940,
"domNodes": 936,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.463,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2024.0269999999896,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.776,
"layouts": 9,
"layoutDurationMs": 2.5390000000000006,
"taskDurationMs": 652.0330000000001,
"heapDeltaBytes": -28993736,
"heapUsedBytes": 61456548,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 33.48400000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2057.183000000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7090000000000005,
"layouts": 9,
"layoutDurationMs": 2.5640000000000005,
"taskDurationMs": 667.673,
"heapDeltaBytes": -23246708,
"heapUsedBytes": 60608136,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 34.528999999999996,
"eventListeners": -91,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3068.421999999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.416,
"layouts": 8,
"layoutDurationMs": 1.9729999999999999,
"taskDurationMs": 1536.308,
"heapDeltaBytes": 4894856,
"heapUsedBytes": 89201748,
"domNodes": -274,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 714.921,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3015.692999999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.562,
"layouts": 8,
"layoutDurationMs": 2.059,
"taskDurationMs": 1533.4940000000001,
"heapDeltaBytes": -28237204,
"heapUsedBytes": 62388648,
"domNodes": -274,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 707.431,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353592,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4001.687000000004,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.433000000000002,
"layouts": 65,
"layoutDurationMs": 10.600999999999999,
"taskDurationMs": 1586.277,
"heapDeltaBytes": 12331008,
"heapUsedBytes": 97790668,
"domNodes": 24,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 688.341,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665833333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3978.98100000009,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.443999999999999,
"layouts": 66,
"layoutDurationMs": 10.885,
"taskDurationMs": 1684.306,
"heapDeltaBytes": -23148132,
"heapUsedBytes": 61294088,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 724.316,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666108786610877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2906.7039999999906,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.1419999999999995,
"layouts": 5,
"layoutDurationMs": 1.036,
"taskDurationMs": 1692.5649999999998,
"heapDeltaBytes": -5119092,
"heapUsedBytes": 82548212,
"domNodes": 0,
"jsHeapTotalBytes": 6254592,
"scriptDurationMs": 834.8820000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.762427745664745,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3081.8700000000376,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.553000000000001,
"layouts": 7,
"layoutDurationMs": 1.6280000000000001,
"taskDurationMs": 1827.7969999999998,
"heapDeltaBytes": -7801800,
"heapUsedBytes": 78247296,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 901.087,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.938043478260873,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2924.3490000000065,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.692,
"layouts": 8,
"layoutDurationMs": 1.504,
"taskDurationMs": 646.9269999999999,
"heapDeltaBytes": 7779572,
"heapUsedBytes": 80499156,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 290.627,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66647727272727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3021.007999999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.174,
"layouts": 8,
"layoutDurationMs": 1.8320000000000003,
"taskDurationMs": 674.8230000000001,
"heapDeltaBytes": -19106832,
"heapUsedBytes": 73177992,
"domNodes": 0,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 316.49100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574585635359,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.1680000000088,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.379,
"layouts": 8,
"layoutDurationMs": 2.1330000000000005,
"taskDurationMs": 614.828,
"heapDeltaBytes": -20075008,
"heapUsedBytes": 65300788,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.708999999999993,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2065.1059999999006,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.504,
"layouts": 7,
"layoutDurationMs": 3.0060000000000002,
"taskDurationMs": 693.7820000000002,
"heapDeltaBytes": -15585624,
"heapUsedBytes": 68160496,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 37.88099999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2707.841000000002,
"styleRecalcs": 26,
"styleRecalcDurationMs": 10.488000000000001,
"layouts": 7,
"layoutDurationMs": 1.3719999999999999,
"taskDurationMs": 490.4719999999999,
"heapDeltaBytes": -17121796,
"heapUsedBytes": 65405080,
"domNodes": -260,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 153.337,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665432098765432,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2741.646000000003,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.869000000000002,
"layouts": 8,
"layoutDurationMs": 1.9079999999999997,
"taskDurationMs": 555.062,
"heapDeltaBytes": -17859460,
"heapUsedBytes": 67387464,
"domNodes": -259,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 168.334,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666463414634148,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3084.054000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9010000000000007,
"layouts": 8,
"layoutDurationMs": 1.547,
"taskDurationMs": 784.255,
"heapDeltaBytes": 8644856,
"heapUsedBytes": 81393420,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 303.084,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-topology-cadence",
"durationMs": 3155.234000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3420000000000005,
"layouts": 8,
"layoutDurationMs": 2.189,
"taskDurationMs": 843.212,
"heapDeltaBytes": -22497388,
"heapUsedBytes": 62467912,
"domNodes": -274,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 305.609,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.093000000018,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.755000000000001,
"layouts": 10,
"layoutDurationMs": 2.378,
"taskDurationMs": 369.648,
"heapDeltaBytes": 917328,
"heapUsedBytes": 62888468,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 122.629,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.6660000000165,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.405000000000001,
"layouts": 10,
"layoutDurationMs": 2.569,
"taskDurationMs": 399.036,
"heapDeltaBytes": 3331288,
"heapUsedBytes": 68152284,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 125.51,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.335000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7349999999999994,
"layouts": 9,
"layoutDurationMs": 2.365,
"taskDurationMs": 548.531,
"heapDeltaBytes": -2175448,
"heapUsedBytes": 68133264,
"domNodes": -200,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 11.132,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2025.480000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9610000000000003,
"layouts": 10,
"layoutDurationMs": 2.725,
"taskDurationMs": 604.322,
"heapDeltaBytes": -3778680,
"heapUsedBytes": 60798244,
"domNodes": -200,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 11.744000000000002,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.0429999999988,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.915000000000001,
"layouts": 11,
"layoutDurationMs": 2.704,
"taskDurationMs": 748.396,
"heapDeltaBytes": 19570892,
"heapUsedBytes": 80544796,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 97.50200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.333000000011,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.312999999999999,
"layouts": 9,
"layoutDurationMs": 2.1989999999999994,
"taskDurationMs": 802.8530000000001,
"heapDeltaBytes": 11329592,
"heapUsedBytes": 73134016,
"domNodes": -200,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 99.887,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1471.1040000000253,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.648,
"layouts": 5,
"layoutDurationMs": 14.435000000000004,
"taskDurationMs": 1178.9039999999998,
"heapDeltaBytes": 6553832,
"heapUsedBytes": 86384028,
"domNodes": -1320,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 29.355000000000008,
"eventListeners": -262,
"totalBlockingTimeMs": 146,
"frameDurationMs": 19.515789473684208,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11210.465,
"styleRecalcs": 252,
"styleRecalcDurationMs": 31.515999999999995,
"layouts": 9,
"layoutDurationMs": 2.242,
"taskDurationMs": 5226.596,
"heapDeltaBytes": -14972864,
"heapUsedBytes": 78827328,
"domNodes": -274,
"jsHeapTotalBytes": 5861376,
"scriptDurationMs": 2339.2980000000002,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666121842496285,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11861.516999999934,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.827,
"layouts": 8,
"layoutDurationMs": 1.7609999999999997,
"taskDurationMs": 5617.058,
"heapDeltaBytes": -5646320,
"heapUsedBytes": 76973892,
"domNodes": -274,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2515.332,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665870786516855,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 21032.10999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20342.445,
"heapDeltaBytes": -21327340,
"heapUsedBytes": 285225396,
"domNodes": -3482,
"jsHeapTotalBytes": 13090816,
"scriptDurationMs": 288.426,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.20051635111876,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 20493.92799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20063.992,
"heapDeltaBytes": -1180292,
"heapUsedBytes": 289222436,
"domNodes": -3482,
"jsHeapTotalBytes": -6037504,
"scriptDurationMs": 274.05899999999997,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.483333333333334,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 25271.060000000034,
"styleRecalcs": 180,
"styleRecalcDurationMs": 24.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24980.375,
"heapDeltaBytes": -30286896,
"heapUsedBytes": 273028236,
"domNodes": -3482,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 801.559,
"eventListeners": -659,
"totalBlockingTimeMs": 11,
"frameDurationMs": 47.76105860113422,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25148.036000000047,
"styleRecalcs": 179,
"styleRecalcDurationMs": 23.917999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24968.052,
"heapDeltaBytes": -43650944,
"heapUsedBytes": 259554452,
"domNodes": -3482,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 826.064,
"eventListeners": -663,
"totalBlockingTimeMs": 15,
"frameDurationMs": 49.119140625,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7603.8060000000205,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.707,
"layouts": 20,
"layoutDurationMs": 24.38,
"taskDurationMs": 7511.85,
"heapDeltaBytes": -33088888,
"heapUsedBytes": 264581760,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 138.43999999999997,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.92890173410404,
"p95FrameDurationMs": 83.40000000000055
},
{
"name": "vue-node-resize-workload",
"durationMs": 7504.942999999912,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.881,
"layouts": 20,
"layoutDurationMs": 30.870999999999995,
"taskDurationMs": 7460.644,
"heapDeltaBytes": -17358216,
"heapUsedBytes": 285906128,
"domNodes": -3481,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 112.176,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.351515151515144,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10415.674000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10169.859,
"heapDeltaBytes": -11267412,
"heapUsedBytes": 261588172,
"domNodes": 0,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 157.60100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.72193308550186,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10557.271000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10278.691,
"heapDeltaBytes": -20258980,
"heapUsedBytes": 267288064,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 141.03199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.88671328671328,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 106.94100000000617,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.228,
"layouts": 9,
"layoutDurationMs": 3.443,
"taskDurationMs": 82.93699999999998,
"heapDeltaBytes": 5176876,
"heapUsedBytes": 79734348,
"domNodes": 132,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.109,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.642857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 94.1609999999855,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.093,
"layouts": 7,
"layoutDurationMs": 2.4419999999999997,
"taskDurationMs": 70.487,
"heapDeltaBytes": 4876892,
"heapUsedBytes": 66441644,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.024000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 349.61299999997664,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.579,
"layouts": 76,
"layoutDurationMs": 12.142999999999999,
"taskDurationMs": 310.911,
"heapDeltaBytes": -4548828,
"heapUsedBytes": 39558940,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 143.78000000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 361.8589999999813,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.603,
"layouts": 76,
"layoutDurationMs": 12.815,
"taskDurationMs": 332.87600000000003,
"heapDeltaBytes": -4203096,
"heapUsedBytes": 40497732,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 152.908,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 360.740000000078,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.915,
"layouts": 76,
"layoutDurationMs": 11.745000000000001,
"taskDurationMs": 331.96500000000003,
"heapDeltaBytes": -960832,
"heapUsedBytes": 101330436,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.857,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 346.2050000000545,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.778,
"layouts": 76,
"layoutDurationMs": 11.757,
"taskDurationMs": 323.34399999999994,
"heapDeltaBytes": -445604,
"heapUsedBytes": 100526500,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.898,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage: 🟡 59.2% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3229 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0cf10f2e67d82ddd463f9dce625ea98a0a24dbf1
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (361)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
## Summary Model imports show "Reconnecting" after a dropped connection, with Cancel still available. During transfer, the dialog shows the upload rate and estimated time left. An expired upload offers Try again to start a new attempt. **Why** A large upload needs to distinguish a connection retry from a failed import. The rate is measured again after reconnection so the retry wait does not skew the estimate. ## Verification Added tests exercise rate measurement after recovery, stale callbacks, cancellation while reconnecting and retrying an expired session. A dialog test uses the real transfer API with a fake storage connection through recovery and library completion. CI on test-only head `f8bbb1b16f` reproduced both UI regressions: the missing status region before progress and an untranslated Korean time-left unit ([unit shard 6](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42265825939/job/128059358128)). The fix keeps a status region present before reconnection and renders changing rate estimates outside it. Time left keeps the same calculation and hours/minutes/seconds split, with units formatted for the active locale. The assertions are unchanged. This branch also includes the transfer recovery fix from its base PR. [CI on `b509f86395`](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42269079050) passes all eight unit shards, including both unchanged UI regression tests. Not run locally: unit tests, full-editor visual QA, or the 10 GB offline/online upload. CI runs the tests. Viewed the component at desktop and phone widths with fixed transfer, reconnecting and expired-session states. These screenshots use the real component and design-system CSS with fixture data; they do not demonstrate a real upload. The dialog tokens use a fixed dark palette.       Try it: On staging with resumable model uploads available, open the model library, choose Import, select a .safetensors file, and start uploading. Interrupt and restore the connection to see Reconnecting, then the transfer rate and time left. An expired session offers Try again. Ref BE-25019 --------- Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 5676d4f)
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #23131 +/- ##
=============================================
Coverage ? 87.62%
=============================================
Files ? 3003
Lines ? 163415
Branches ? 41661
=============================================
Hits ? 143187
Misses ? 19297
Partials ? 931
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport, per the requested backport review policy. No tests run.
|
Thanks @dante01yoon. |
TL;DR: Backports #23081 (merge commit 6212fca) and #23082 (merge commit 5676d4f) to
cloud/1.60, one commit each. A model import on Cloud continues after a dropped connection instead of starting over, and the Import dialog shows reconnecting and time left.Why
cloud/1.60does not have #23081, so a model import built from it still sends the whole file in one request. The server side of resumable uploads is merged (Comfy-Org/cloud#18428). The bot's cherry-pick conflicted, so this one is by hand. #23082, the reconnection and time-left display, builds on #23081, so it is in this PR too; the bot's separate backport, #23130, is closed because its checks failed without #23081 on the branch.Before / After
Conflicts
packages/ingest-types/src/types.gen.tsandpackages/ingest-types/src/zod.gen.tsconflicted. Both are generated from Cloud's API spec.cloud/1.60's copies came from an older spec thanmain's, so the types sit in a different order andmainhas many newer types around them. I keptcloud/1.60's files and applied only #23081's hunks to them:ModelUploadStartedandzModelUploadStartedgainupload_modeandchunk_size_bytes. Their fields are reordered and their comments updated, as feat: model uploads resume after a dropped connection #23081 did onmain.StartModelUploadDatagains theresumablebody flag and the optionalOriginheader.zStartModelUploadBodygainsresumable, andzStartModelUploadHeadersis new.The change to these two files is line for line #23081's (38 and 25 lines). No other API type changes. I did not run the generator: it rebuilds both files from the current spec and would bring every newer type with them, as the open bot PR #22719 does on
cloud/1.59.Everything else applied cleanly, #23082's commit included.
modelFileUploadApi.tsand its test are identical oncloud/1.60and onmainbefore #23081, and every schema they import exists oncloud/1.60. Nothing beyond #23081 and #23082 is brought in.Screenshots (the same screen change as #23082; taken there)
Viewed the component at desktop and phone widths with fixed transfer, reconnecting and expired-session states. These screenshots use the real component and design-system CSS with fixture data; they do not demonstrate a real upload. The dialog tokens use a fixed dark palette.
Try it: on testcloud (cloud/1.60), once resumable model uploads are turned on there (BE-25022), open the model library, choose Import, select a .safetensors file and start uploading. Interrupt and restore the connection to see Reconnecting, then the transfer rate and time left. An expired session offers Try again.
Not run: unit tests, typecheck, lint and a real upload, locally; CI runs the first three. The repo gate passes against
cloud/1.60with no new findings.Rule bent: none.
Ref BE-25019