Repository navigation
[backport cloud/1.60] feat: model imports show reconnection and time left - #23130
comfy-pr-bot wants to merge 1 commit into
Conversation
## Summary Model imports show "Reconnecting" after a dropped connection, with Cancel still available. During transfer, the dialog shows the upload rate and estimated time left. An expired upload offers Try again to start a new attempt. **Why** A large upload needs to distinguish a connection retry from a failed import. The rate is measured again after reconnection so the retry wait does not skew the estimate. ## Verification Added tests exercise rate measurement after recovery, stale callbacks, cancellation while reconnecting and retrying an expired session. A dialog test uses the real transfer API with a fake storage connection through recovery and library completion. CI on test-only head `f8bbb1b16f` reproduced both UI regressions: the missing status region before progress and an untranslated Korean time-left unit ([unit shard 6](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42265825939/job/128059358128)). The fix keeps a status region present before reconnection and renders changing rate estimates outside it. Time left keeps the same calculation and hours/minutes/seconds split, with units formatted for the active locale. The assertions are unchanged. This branch also includes the transfer recovery fix from its base PR. [CI on `b509f86395`](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42269079050) passes all eight unit shards, including both unchanged UI regression tests. Not run locally: unit tests, full-editor visual QA, or the 10 GB offline/online upload. CI runs the tests. Viewed the component at desktop and phone widths with fixed transfer, reconnecting and expired-session states. These screenshots use the real component and design-system CSS with fixture data; they do not demonstrate a real upload. The dialog tokens use a fixed dark palette.       Try it: On staging with resumable model uploads available, open the model library, choose Import, select a .safetensors file, and start uploading. Interrupt and restore the connection to see Reconnecting, then the transfer rate and time left. An expired session offers Try again. Ref BE-25019 --------- Co-authored-by: GitHub Action <action@github.com>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-08T14:04:56.280Z",
"gitSha": "26989a0688ca55b433d89b9946d54780de8008b3",
"branch": "backport-23082-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.8250000000212,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9239999999999995,
"layouts": 11,
"layoutDurationMs": 2.0629999999999997,
"taskDurationMs": 464.70399999999995,
"heapDeltaBytes": -4439644,
"heapUsedBytes": 65227088,
"domNodes": -178,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 6.796,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2026.3390000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6849999999999998,
"layouts": 9,
"layoutDurationMs": 1.658,
"taskDurationMs": 490.14199999999994,
"heapDeltaBytes": -3894600,
"heapUsedBytes": 69250080,
"domNodes": -178,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 8.001999999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.1380000000386,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.312,
"layouts": 9,
"layoutDurationMs": 1.561,
"taskDurationMs": 688.899,
"heapDeltaBytes": -7595956,
"heapUsedBytes": 55042424,
"domNodes": -178,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 106.692,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.2170000000042,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.530000000000001,
"layouts": 9,
"layoutDurationMs": 1.597,
"taskDurationMs": 647.0740000000001,
"heapDeltaBytes": 637852,
"heapUsedBytes": 63029648,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 106.815,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.5149999999817,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.868,
"layouts": 11,
"layoutDurationMs": 2.1460000000000004,
"taskDurationMs": 326.363,
"heapDeltaBytes": 25424500,
"heapUsedBytes": 85334128,
"domNodes": 57,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.635,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.0269999999973,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.688,
"layouts": 12,
"layoutDurationMs": 2.111,
"taskDurationMs": 322.19699999999995,
"heapDeltaBytes": 7591900,
"heapUsedBytes": 84618764,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 9.07,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 534.1889999999694,
"styleRecalcs": 13,
"styleRecalcDurationMs": 1.5759999999999996,
"layouts": 9,
"layoutDurationMs": 1.565,
"taskDurationMs": 365.259,
"heapDeltaBytes": 2325940,
"heapUsedBytes": 62550356,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 117.816,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 532.1070000000532,
"styleRecalcs": 15,
"styleRecalcDurationMs": 1.855,
"layouts": 10,
"layoutDurationMs": 1.7020000000000002,
"taskDurationMs": 371.194,
"heapDeltaBytes": 6480724,
"heapUsedBytes": 68471452,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 120.128,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1011.5759999999909,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 661.7259999999999,
"heapDeltaBytes": 19443944,
"heapUsedBytes": 83936512,
"domNodes": 0,
"jsHeapTotalBytes": 12484608,
"scriptDurationMs": 47.654,
"eventListeners": 0,
"totalBlockingTimeMs": 389,
"frameDurationMs": 29.899999999999984,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1014.6530000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.3340000000001,
"heapDeltaBytes": 15961508,
"heapUsedBytes": 86467260,
"domNodes": 0,
"jsHeapTotalBytes": 14319616,
"scriptDurationMs": 44.184,
"eventListeners": 0,
"totalBlockingTimeMs": 384,
"frameDurationMs": 29.902941176470595,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 744.2080000000146,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.84399999999994,
"heapDeltaBytes": -2483432,
"heapUsedBytes": 73796896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.405,
"eventListeners": 0,
"totalBlockingTimeMs": 128,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 745.8479999999668,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.61300000000006,
"heapDeltaBytes": -3035448,
"heapUsedBytes": 73256688,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 100.52999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 119,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7022.528999999991,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.33499999999999935,
"layouts": 2,
"layoutDurationMs": 0.4459999999999998,
"taskDurationMs": 6191.555,
"heapDeltaBytes": 52441608,
"heapUsedBytes": 146538580,
"domNodes": -274,
"jsHeapTotalBytes": 54915072,
"scriptDurationMs": 4614.155000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 58,
"frameDurationMs": 24.56341463414634,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7554.509999999993,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.23100000000000032,
"layouts": 2,
"layoutDurationMs": 0.49,
"taskDurationMs": 6784.365,
"heapDeltaBytes": 66287472,
"heapUsedBytes": 142789696,
"domNodes": -274,
"jsHeapTotalBytes": 72478720,
"scriptDurationMs": 5268.847999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 63,
"frameDurationMs": 24.432686084142397,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7124.602999999979,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.026999999999999247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6395.329,
"heapDeltaBytes": 56881768,
"heapUsedBytes": 132934456,
"domNodes": -274,
"jsHeapTotalBytes": 63827968,
"scriptDurationMs": 4858.729,
"eventListeners": -69,
"totalBlockingTimeMs": 66,
"frameDurationMs": 24.6242214532872,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6725.706000000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4350000000000005,
"layouts": 2,
"layoutDurationMs": 0.4190000000000001,
"taskDurationMs": 5977.251,
"heapDeltaBytes": 69578632,
"heapUsedBytes": 144441712,
"domNodes": -274,
"jsHeapTotalBytes": 63827968,
"scriptDurationMs": 4445.296,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.512408759124085,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 174.55400000000054,
"styleRecalcs": 18,
"styleRecalcDurationMs": 9.690000000000001,
"layouts": 5,
"layoutDurationMs": 1.4420000000000006,
"taskDurationMs": 134.423,
"heapDeltaBytes": -677680,
"heapUsedBytes": 75009180,
"domNodes": 699,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 8.072,
"eventListeners": 72,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837499999999977,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 204.59799999997585,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.834,
"layouts": 10,
"layoutDurationMs": 2.9079999999999995,
"taskDurationMs": 168.532,
"heapDeltaBytes": 14783444,
"heapUsedBytes": 90956724,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 9.100999999999997,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2040.7730000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.706,
"layouts": 9,
"layoutDurationMs": 1.7540000000000002,
"taskDurationMs": 525.119,
"heapDeltaBytes": -3656520,
"heapUsedBytes": 79439500,
"domNodes": -274,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 23.586000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.7760000000035,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.733,
"layouts": 9,
"layoutDurationMs": 1.687,
"taskDurationMs": 543.669,
"heapDeltaBytes": -16490040,
"heapUsedBytes": 77152240,
"domNodes": -274,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 30.839000000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2269.75299999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.470999999999999,
"layouts": 8,
"layoutDurationMs": 1.3179999999999998,
"taskDurationMs": 1329.9910000000002,
"heapDeltaBytes": -31664588,
"heapUsedBytes": 63286792,
"domNodes": -274,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 614.61,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588233,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2171.533000000011,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.171000000000001,
"layouts": 8,
"layoutDurationMs": 1.4800000000000002,
"taskDurationMs": 1324.77,
"heapDeltaBytes": 2844640,
"heapUsedBytes": 78063112,
"domNodes": -274,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 607.2950000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538461,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.2540000000117,
"styleRecalcs": 72,
"styleRecalcDurationMs": 6.9510000000000005,
"layouts": 65,
"layoutDurationMs": 8.423,
"taskDurationMs": 1364.564,
"heapDeltaBytes": -2990568,
"heapUsedBytes": 70641368,
"domNodes": -250,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 561.194,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3190.341999999987,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.248999999999999,
"layouts": 65,
"layoutDurationMs": 9.392,
"taskDurationMs": 1354.7820000000002,
"heapDeltaBytes": 9449144,
"heapUsedBytes": 83557388,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 574.0639999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66544502617801,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2317.4889999999664,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.306,
"layouts": 7,
"layoutDurationMs": 1.0650000000000002,
"taskDurationMs": 1438.0830000000003,
"heapDeltaBytes": -8273352,
"heapUsedBytes": 76528000,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 659.8409999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786956521739125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2254.970000000071,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.072000000000001,
"layouts": 7,
"layoutDurationMs": 1.277,
"taskDurationMs": 1494.1599999999999,
"heapDeltaBytes": -10381348,
"heapUsedBytes": 76303884,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 708.0880000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.790298507462687,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2974.6999999999844,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.261,
"layouts": 8,
"layoutDurationMs": 1.3020000000000003,
"taskDurationMs": 612.0409999999999,
"heapDeltaBytes": -19078968,
"heapUsedBytes": 72986644,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 296.66,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666480446927377,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2973.0200000000195,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.1440000000000001,
"layouts": 7,
"layoutDurationMs": 1.158,
"taskDurationMs": 646.657,
"heapDeltaBytes": -7314128,
"heapUsedBytes": 76535772,
"domNodes": -274,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 304.488,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2035.3080000000432,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.4330000000000003,
"layouts": 8,
"layoutDurationMs": 1.3850000000000002,
"taskDurationMs": 516.477,
"heapDeltaBytes": 7366760,
"heapUsedBytes": 82672008,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 23.852999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2017.4520000000484,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.4549999999999996,
"layouts": 8,
"layoutDurationMs": 1.487,
"taskDurationMs": 538.8620000000001,
"heapDeltaBytes": -28934324,
"heapUsedBytes": 64032412,
"domNodes": -274,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 32.17900000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2855.120999999997,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.123999999999999,
"layouts": 8,
"layoutDurationMs": 1.4130000000000003,
"taskDurationMs": 524.8389999999999,
"heapDeltaBytes": -6830416,
"heapUsedBytes": 65836548,
"domNodes": -259,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 156.204,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666081871345032,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2707.9180000000065,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.200999999999999,
"layouts": 8,
"layoutDurationMs": 1.496,
"taskDurationMs": 512.3839999999998,
"heapDeltaBytes": -10375488,
"heapUsedBytes": 73613264,
"domNodes": -271,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 144.56,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3077.0069999999805,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.2689999999999992,
"layouts": 8,
"layoutDurationMs": 1.2369999999999999,
"taskDurationMs": 779.638,
"heapDeltaBytes": -2121180,
"heapUsedBytes": 81770836,
"domNodes": -274,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 301.62500000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3066.8919999999957,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.3210000000000002,
"layouts": 7,
"layoutDurationMs": 1.374,
"taskDurationMs": 773.3779999999999,
"heapDeltaBytes": -22683208,
"heapUsedBytes": 61984636,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 285.304,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.2650000000426,
"styleRecalcs": 46,
"styleRecalcDurationMs": 3.276,
"layouts": 9,
"layoutDurationMs": 1.534,
"taskDurationMs": 330.70700000000005,
"heapDeltaBytes": 24377988,
"heapUsedBytes": 86112948,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 99.79100000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.7389999999596,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.3569999999999998,
"layouts": 10,
"layoutDurationMs": 1.7249999999999999,
"taskDurationMs": 342.409,
"heapDeltaBytes": -849804,
"heapUsedBytes": 78085196,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 105.379,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2036.7689999999925,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.696,
"layouts": 10,
"layoutDurationMs": 1.655,
"taskDurationMs": 465.13199999999995,
"heapDeltaBytes": -5591344,
"heapUsedBytes": 69802860,
"domNodes": -200,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 6.760999999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.7439999999742,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.7820000000000003,
"layouts": 10,
"layoutDurationMs": 1.5379999999999998,
"taskDurationMs": 415.303,
"heapDeltaBytes": 4554196,
"heapUsedBytes": 66174516,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 7.261,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.1740000000364,
"styleRecalcs": 76,
"styleRecalcDurationMs": 9.725,
"layouts": 9,
"layoutDurationMs": 1.535,
"taskDurationMs": 614.9449999999999,
"heapDeltaBytes": 23163148,
"heapUsedBytes": 86077204,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 71.457,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.9419999999973,
"styleRecalcs": 77,
"styleRecalcDurationMs": 10.659000000000002,
"layouts": 10,
"layoutDurationMs": 1.858,
"taskDurationMs": 641.366,
"heapDeltaBytes": 19586760,
"heapUsedBytes": 80619512,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 74.069,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1489.8210000000063,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.835,
"layouts": 5,
"layoutDurationMs": 12.325,
"taskDurationMs": 1056.478,
"heapDeltaBytes": 1492324,
"heapUsedBytes": 81133260,
"domNodes": 10439,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 24.144000000000005,
"eventListeners": 3566,
"totalBlockingTimeMs": 181,
"frameDurationMs": 19.99866666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8261.563999999964,
"styleRecalcs": 251,
"styleRecalcDurationMs": 16.724000000000004,
"layouts": 10,
"layoutDurationMs": 1.778,
"taskDurationMs": 4540.42,
"heapDeltaBytes": -17484996,
"heapUsedBytes": 64808696,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 1998.237,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8209.146000000033,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.831,
"layouts": 8,
"layoutDurationMs": 1.429,
"taskDurationMs": 4584.099,
"heapDeltaBytes": -19909292,
"heapUsedBytes": 62731728,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 1969.0880000000002,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612576064909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16639.170000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15674.623,
"heapDeltaBytes": -9750056,
"heapUsedBytes": 279413544,
"domNodes": -3482,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 232.323,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.048397976391232,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 16994.444000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16033.633000000002,
"heapDeltaBytes": -6950332,
"heapUsedBytes": 276919912,
"domNodes": -3482,
"jsHeapTotalBytes": 9682944,
"scriptDurationMs": 214.85299999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.66661045531197,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19213.20800000001,
"styleRecalcs": 169,
"styleRecalcDurationMs": 15.829999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18808.051,
"heapDeltaBytes": -35531228,
"heapUsedBytes": 255202856,
"domNodes": -3482,
"jsHeapTotalBytes": 8634368,
"scriptDurationMs": 755.003,
"eventListeners": -659,
"totalBlockingTimeMs": 8,
"frameDurationMs": 34.81123188405797,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 20548.35300000002,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.156999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20096.436,
"heapDeltaBytes": -13474132,
"heapUsedBytes": 276868376,
"domNodes": -3482,
"jsHeapTotalBytes": 13090816,
"scriptDurationMs": 730.251,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.17799295774648,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 5751.4529999999695,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.00599999999999,
"layouts": 20,
"layoutDurationMs": 18.717000000000013,
"taskDurationMs": 5609.562999999999,
"heapDeltaBytes": -33096968,
"heapUsedBytes": 256835676,
"domNodes": -3482,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 86.46600000000001,
"eventListeners": -661,
"totalBlockingTimeMs": 1,
"frameDurationMs": 33.42906976744186,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-node-resize-workload",
"durationMs": 6123.964000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.55000000000001,
"layouts": 20,
"layoutDurationMs": 21.189,
"taskDurationMs": 5996.001,
"heapDeltaBytes": 422504,
"heapUsedBytes": 283694028,
"domNodes": -3482,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 120.195,
"eventListeners": -661,
"totalBlockingTimeMs": 7,
"frameDurationMs": 34.6497175141243,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8087.157000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7663.9990000000025,
"heapDeltaBytes": 2457368,
"heapUsedBytes": 260582464,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.19800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.215824915824925,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8089.293999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7567.345999999999,
"heapDeltaBytes": -26408524,
"heapUsedBytes": 258457012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.64599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.215488215488215,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 469.0870000000018,
"styleRecalcs": 18,
"styleRecalcDurationMs": 8.803999999999998,
"layouts": 12,
"layoutDurationMs": 3.638,
"taskDurationMs": 125.337,
"heapDeltaBytes": -9479368,
"heapUsedBytes": 65708812,
"domNodes": 136,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 9.598,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 106.45199999999022,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.617999999999999,
"layouts": 9,
"layoutDurationMs": 2.4789999999999996,
"taskDurationMs": 74.14699999999999,
"heapDeltaBytes": -13094212,
"heapUsedBytes": 62481500,
"domNodes": 125,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 5.467,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 294.5190000000366,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.512,
"layouts": 76,
"layoutDurationMs": 12.014999999999999,
"taskDurationMs": 254.114,
"heapDeltaBytes": -5146824,
"heapUsedBytes": 38843928,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 110.75200000000001,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 297.7180000000317,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.526,
"layouts": 76,
"layoutDurationMs": 12.176,
"taskDurationMs": 257.825,
"heapDeltaBytes": -3078976,
"heapUsedBytes": 37139660,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.468,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666643,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 343.60399999991387,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.516,
"layouts": 76,
"layoutDurationMs": 12.357999999999999,
"taskDurationMs": 303.094,
"heapDeltaBytes": -350156,
"heapUsedBytes": 100611320,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.263,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 349.4630000000143,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.55,
"layouts": 76,
"layoutDurationMs": 12.388,
"taskDurationMs": 320.198,
"heapDeltaBytes": 126660,
"heapUsedBytes": 96119324,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.62500000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage:
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 5 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: c92d0c6 | Docs | View more details | Give us feedback! |
Pull request was closed
…ection, with reconnection and time left (#23131) **TL;DR:** Backports [#23081](#23081) (merge commit 6212fca) and [#23082](#23082) (merge commit 5676d4f) to `cloud/1.60`, one commit each. A model import on Cloud continues after a dropped connection instead of starting over, and the Import dialog shows reconnecting and time left. **Why** `cloud/1.60` does not have #23081, so a model import built from it still sends the whole file in one request. The server side of resumable uploads is merged (Comfy-Org/cloud#18428). The bot's cherry-pick conflicted, so this one is by hand. #23082, the reconnection and time-left display, builds on #23081, so it is in this PR too; the bot's separate backport, #23130, is closed because its checks failed without #23081 on the branch. **Before / After** - Before: a dropped connection ends the import, and the next try sends the whole file again. Files are capped at 2 GB. - After: the editor asks for a resumable upload, sends the file in pieces, and after a drop continues from the last byte storage confirmed. Files up to 25 GB. Servers that refuse resumable mode still get one request, as before. **Conflicts** `packages/ingest-types/src/types.gen.ts` and `packages/ingest-types/src/zod.gen.ts` conflicted. Both are generated from Cloud's API spec. `cloud/1.60`'s copies came from an older spec than `main`'s, so the types sit in a different order and `main` has many newer types around them. I kept `cloud/1.60`'s files and applied only #23081's hunks to them: - `ModelUploadStarted` and `zModelUploadStarted` gain `upload_mode` and `chunk_size_bytes`. Their fields are reordered and their comments updated, as #23081 did on `main`. - `StartModelUploadData` gains the `resumable` body flag and the optional `Origin` header. - `zStartModelUploadBody` gains `resumable`, and `zStartModelUploadHeaders` is new. The change to these two files is line for line #23081's (38 and 25 lines). No other API type changes. I did not run the generator: it rebuilds both files from the current spec and would bring every newer type with them, as the open bot PR #22719 does on `cloud/1.59`. Everything else applied cleanly, #23082's commit included. `modelFileUploadApi.ts` and its test are identical on `cloud/1.60` and on `main` before #23081, and every schema they import exists on `cloud/1.60`. Nothing beyond #23081 and #23082 is brought in. **Screenshots** (the same screen change as #23082; taken there) Viewed the component at desktop and phone widths with fixed transfer, reconnecting and expired-session states. These screenshots use the real component and design-system CSS with fixture data; they do not demonstrate a real upload. The dialog tokens use a fixed dark palette.       Try it: on testcloud (cloud/1.60), once resumable model uploads are turned on there (BE-25022), open the model library, choose Import, select a .safetensors file and start uploading. Interrupt and restore the connection to see Reconnecting, then the transfer rate and time left. An expired session offers Try again. Not run: unit tests, typecheck, lint and a real upload, locally; CI runs the first three. The repo gate passes against `cloud/1.60` with no new findings. **Rule bent:** none. Ref BE-25019 --------- Co-authored-by: GitHub Action <action@github.com>
Backport of #23082 to
cloud/1.60Automatically created by backport workflow.