Repository navigation
[backport cloud/1.60] fix(agent): keep a group the agent draws around existing nodes on them - #22966
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T05:19:14.327Z",
"gitSha": "9b53b7cbb58285512674ac43f40e59520f6bee34",
"branch": "backport-22945-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.650000000003,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8730000000000007,
"layouts": 11,
"layoutDurationMs": 2.562,
"taskDurationMs": 339.077,
"heapDeltaBytes": 5034524,
"heapUsedBytes": 72555768,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 8.181000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2026.2140000000386,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.236,
"layouts": 11,
"layoutDurationMs": 3.052,
"taskDurationMs": 522.313,
"heapDeltaBytes": -894828,
"heapUsedBytes": 76580956,
"domNodes": -178,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 12.57,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1673.7329999999986,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.84,
"layouts": 8,
"layoutDurationMs": 1.84,
"taskDurationMs": 613.553,
"heapDeltaBytes": 780108,
"heapUsedBytes": 62504260,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 112.568,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653466,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.3589999999908,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.853000000000002,
"layouts": 9,
"layoutDurationMs": 2.353,
"taskDurationMs": 734.6510000000001,
"heapDeltaBytes": 1149016,
"heapUsedBytes": 62729392,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 125.37700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.993000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.037,
"layouts": 12,
"layoutDurationMs": 2.881,
"taskDurationMs": 310.48199999999997,
"heapDeltaBytes": 5072536,
"heapUsedBytes": 82483928,
"domNodes": 57,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.680000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0060000000076,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.697,
"layouts": 12,
"layoutDurationMs": 3.4449999999999994,
"taskDurationMs": 361.439,
"heapDeltaBytes": 1661020,
"heapUsedBytes": 63422664,
"domNodes": 57,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 14.956,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 480.05800000001386,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8040000000000003,
"layouts": 9,
"layoutDurationMs": 2.2250000000000005,
"taskDurationMs": 327.023,
"heapDeltaBytes": 5660220,
"heapUsedBytes": 67314568,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 110.901,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 558.8610000000358,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2329999999999988,
"layouts": 10,
"layoutDurationMs": 2.774,
"taskDurationMs": 392.59,
"heapDeltaBytes": 10687436,
"heapUsedBytes": 88492256,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 123.26900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66176470588235,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 990.2989999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.1730000000001,
"heapDeltaBytes": -10217172,
"heapUsedBytes": 78374424,
"domNodes": -208,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 40.07699999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 345,
"frameDurationMs": 27.775000000000002,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1018.0729999999585,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.2830000000001,
"heapDeltaBytes": -10630132,
"heapUsedBytes": 77666204,
"domNodes": -208,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 45.034,
"eventListeners": -107,
"totalBlockingTimeMs": 320,
"frameDurationMs": 26.752631578947366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 712.8510000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.7169999999997,
"heapDeltaBytes": -2990756,
"heapUsedBytes": 73150512,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.579,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 21.076470588235278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 742.7370000000337,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.8800000000003,
"heapDeltaBytes": -6187380,
"heapUsedBytes": 86936936,
"domNodes": 0,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 105.75299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 100,
"frameDurationMs": 20.948571428571423,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6798.022000000003,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9199999999999998,
"layouts": 3,
"layoutDurationMs": 0.7520000000000001,
"taskDurationMs": 5913.157,
"heapDeltaBytes": 42138992,
"heapUsedBytes": 124384856,
"domNodes": -274,
"jsHeapTotalBytes": 56750080,
"scriptDurationMs": 4438.063999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 57,
"frameDurationMs": 22.44158415841584,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6605.551999999989,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.273,
"layouts": 4,
"layoutDurationMs": 1.03,
"taskDurationMs": 5725.456,
"heapDeltaBytes": 48808288,
"heapUsedBytes": 142669064,
"domNodes": -274,
"jsHeapTotalBytes": 64876544,
"scriptDurationMs": 4261.652,
"eventListeners": -69,
"totalBlockingTimeMs": 17,
"frameDurationMs": 21.07133757961783,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6411.5459999999875,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.895,
"layouts": 3,
"layoutDurationMs": 0.6360000000000002,
"taskDurationMs": 5497.722000000001,
"heapDeltaBytes": 32586992,
"heapUsedBytes": 126319724,
"domNodes": -274,
"jsHeapTotalBytes": 62255104,
"scriptDurationMs": 4130.842,
"eventListeners": -69,
"totalBlockingTimeMs": 35,
"frameDurationMs": 19.803703703703704,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6690.805000000011,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8339999999999996,
"layouts": 3,
"layoutDurationMs": 0.7199999999999998,
"taskDurationMs": 5686.788,
"heapDeltaBytes": 46383040,
"heapUsedBytes": 128737856,
"domNodes": -274,
"jsHeapTotalBytes": 49934336,
"scriptDurationMs": 4237.47,
"eventListeners": -69,
"totalBlockingTimeMs": 2,
"frameDurationMs": 20.62685185185185,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 170.72099999998613,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.553000000000003,
"layouts": 11,
"layoutDurationMs": 3.3910000000000005,
"taskDurationMs": 133.04299999999998,
"heapDeltaBytes": 14793776,
"heapUsedBytes": 90324424,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.107999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912499999999966,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 169.0749999999639,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.501,
"layouts": 12,
"layoutDurationMs": 3.2929999999999997,
"taskDurationMs": 124.97200000000001,
"heapDeltaBytes": 14800384,
"heapUsedBytes": 91197808,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.683,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837500000000034,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2022.6470000000063,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.960000000000001,
"layouts": 10,
"layoutDurationMs": 2.501,
"taskDurationMs": 440.66400000000004,
"heapDeltaBytes": -17065024,
"heapUsedBytes": 77085656,
"domNodes": -274,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 26.972,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.3230000000144,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.077999999999999,
"layouts": 9,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 552.881,
"heapDeltaBytes": -6297236,
"heapUsedBytes": 83197080,
"domNodes": -274,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 32.00899999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2459.096000000017,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.069999999999999,
"layouts": 7,
"layoutDurationMs": 1.753,
"taskDurationMs": 1211.706,
"heapDeltaBytes": -20561964,
"heapUsedBytes": 62655040,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 576.759,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780136986301372,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3014.904999999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.363999999999999,
"layouts": 8,
"layoutDurationMs": 2.07,
"taskDurationMs": 1433.251,
"heapDeltaBytes": -30218108,
"heapUsedBytes": 63912412,
"domNodes": -274,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 666.4610000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353592,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3923.2810000000027,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.575,
"layouts": 67,
"layoutDurationMs": 13.234,
"taskDurationMs": 1480.0910000000001,
"heapDeltaBytes": -31335244,
"heapUsedBytes": 62204424,
"domNodes": -250,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 636.1329999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.808119658119658,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4050.733999999977,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.643999999999998,
"layouts": 64,
"layoutDurationMs": 12.925999999999998,
"taskDurationMs": 1588.4230000000002,
"heapDeltaBytes": -14108496,
"heapUsedBytes": 71012932,
"domNodes": -220,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 685.6170000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399176,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2843.322999999998,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.176,
"layouts": 7,
"layoutDurationMs": 1.7009999999999998,
"taskDurationMs": 1504.9350000000002,
"heapDeltaBytes": -8202008,
"heapUsedBytes": 78911292,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 739.624,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.862721893491127,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3087.596000000019,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.115000000000001,
"layouts": 7,
"layoutDurationMs": 1.8799999999999997,
"taskDurationMs": 1635.7009999999998,
"heapDeltaBytes": 23996296,
"heapUsedBytes": 110424884,
"domNodes": 0,
"jsHeapTotalBytes": 8544256,
"scriptDurationMs": 805.585,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130434,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2859.1839999999993,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0510000000000006,
"layouts": 8,
"layoutDurationMs": 1.691,
"taskDurationMs": 524.167,
"heapDeltaBytes": 825376,
"heapUsedBytes": 92167200,
"domNodes": 0,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 250.185,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608187134503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2928.3720000000244,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.516,
"layouts": 8,
"layoutDurationMs": 2.0200000000000005,
"taskDurationMs": 604.6830000000001,
"heapDeltaBytes": -21684864,
"heapUsedBytes": 61890524,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 279.235,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.2790000000123,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5519999999999996,
"layouts": 8,
"layoutDurationMs": 2.0860000000000003,
"taskDurationMs": 491.1530000000001,
"heapDeltaBytes": 6618008,
"heapUsedBytes": 82248888,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.278,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2032.1599999999762,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.386000000000001,
"layouts": 7,
"layoutDurationMs": 1.955,
"taskDurationMs": 549.2429999999999,
"heapDeltaBytes": -12439916,
"heapUsedBytes": 82790476,
"domNodes": -274,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 31.221000000000007,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2704.291000000012,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.123,
"layouts": 8,
"layoutDurationMs": 1.975,
"taskDurationMs": 429.599,
"heapDeltaBytes": 8083032,
"heapUsedBytes": 89929956,
"domNodes": 19,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 151.60600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66604938271605,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2707.400000000007,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.783999999999999,
"layouts": 8,
"layoutDurationMs": 2.0900000000000003,
"taskDurationMs": 416.46200000000005,
"heapDeltaBytes": -18785272,
"heapUsedBytes": 73708064,
"domNodes": 19,
"jsHeapTotalBytes": 4231168,
"scriptDurationMs": 137.219,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3013.0740000000173,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.255,
"layouts": 8,
"layoutDurationMs": 1.8899999999999997,
"taskDurationMs": 662.047,
"heapDeltaBytes": -12736960,
"heapUsedBytes": 78757736,
"domNodes": 0,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 266.978,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665745856353595,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-topology-cadence",
"durationMs": 3009.5120000000293,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4300000000000006,
"layouts": 8,
"layoutDurationMs": 2.0060000000000002,
"taskDurationMs": 685.105,
"heapDeltaBytes": 10373180,
"heapUsedBytes": 93227220,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 270.763,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574585635359,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.4780000000017,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.619,
"layouts": 9,
"layoutDurationMs": 2.3460000000000005,
"taskDurationMs": 322.24299999999994,
"heapDeltaBytes": -2219288,
"heapUsedBytes": 60659676,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 103.2,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.843000000019,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.412,
"layouts": 8,
"layoutDurationMs": 2.022,
"taskDurationMs": 337.167,
"heapDeltaBytes": 24896028,
"heapUsedBytes": 87370764,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 106.86399999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.5289999999864,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.322,
"layouts": 8,
"layoutDurationMs": 1.9710000000000005,
"taskDurationMs": 323.337,
"heapDeltaBytes": 10963920,
"heapUsedBytes": 73429776,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 6.881,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2025.825999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8850000000000002,
"layouts": 9,
"layoutDurationMs": 2.5090000000000003,
"taskDurationMs": 491.091,
"heapDeltaBytes": -15010864,
"heapUsedBytes": 62914016,
"domNodes": -200,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.309,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.206999999991,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.443,
"layouts": 9,
"layoutDurationMs": 1.9880000000000002,
"taskDurationMs": 622.703,
"heapDeltaBytes": 19565192,
"heapUsedBytes": 84168660,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 90.77799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664356435643565,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.9269999999542,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.878,
"layouts": 11,
"layoutDurationMs": 2.82,
"taskDurationMs": 689.7110000000001,
"heapDeltaBytes": 23165308,
"heapUsedBytes": 85139828,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 100.453,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 984.3780000000493,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.31,
"layouts": 5,
"layoutDurationMs": 10.856000000000002,
"taskDurationMs": 794.788,
"heapDeltaBytes": -8238420,
"heapUsedBytes": 100007152,
"domNodes": 19229,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 21.013000000000005,
"eventListeners": 3566,
"totalBlockingTimeMs": 115,
"frameDurationMs": 20.067346938775515,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9323.105999999996,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.278000000000006,
"layouts": 9,
"layoutDurationMs": 2.372,
"taskDurationMs": 4370.318,
"heapDeltaBytes": -4795536,
"heapUsedBytes": 85170332,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 2041.977,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11309.790999999961,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.831,
"layouts": 9,
"layoutDurationMs": 2.44,
"taskDurationMs": 4915.263000000001,
"heapDeltaBytes": -25184632,
"heapUsedBytes": 64373592,
"domNodes": -274,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 2170.723,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16569.571999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15639.770999999999,
"heapDeltaBytes": 932040,
"heapUsedBytes": 288087344,
"domNodes": -3482,
"jsHeapTotalBytes": 17285120,
"scriptDurationMs": 204.99399999999997,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.512908777969024,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16972.765999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16260.866,
"heapDeltaBytes": -36282904,
"heapUsedBytes": 262149988,
"domNodes": -3482,
"jsHeapTotalBytes": 15974400,
"scriptDurationMs": 220.56499999999997,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.52839721254356,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 19446.542000000023,
"styleRecalcs": 167,
"styleRecalcDurationMs": 19.92000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18945.650999999998,
"heapDeltaBytes": -217172,
"heapUsedBytes": 289302536,
"domNodes": -3482,
"jsHeapTotalBytes": 19841024,
"scriptDurationMs": 693.149,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.07671480144405,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19725.076999999997,
"styleRecalcs": 147,
"styleRecalcDurationMs": 20.323000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19374.831000000002,
"heapDeltaBytes": -44689892,
"heapUsedBytes": 258445140,
"domNodes": -3482,
"jsHeapTotalBytes": 13615104,
"scriptDurationMs": 682.011,
"eventListeners": -659,
"totalBlockingTimeMs": 9,
"frameDurationMs": 36.85214953271028,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6154.2329999999765,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.921,
"layouts": 20,
"layoutDurationMs": 22.56000000000001,
"taskDurationMs": 6046.728,
"heapDeltaBytes": -10450628,
"heapUsedBytes": 287444896,
"domNodes": -3482,
"jsHeapTotalBytes": 29081600,
"scriptDurationMs": 90.56599999999999,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.04685714285714,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6177.687999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.788999999999994,
"layouts": 20,
"layoutDurationMs": 21.092999999999986,
"taskDurationMs": 6041.722,
"heapDeltaBytes": -9091864,
"heapUsedBytes": 288733120,
"domNodes": -3482,
"jsHeapTotalBytes": 23052288,
"scriptDurationMs": 94.883,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.43908045977011,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8333.377999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8160.422999999998,
"heapDeltaBytes": 5264884,
"heapUsedBytes": 295805140,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.58200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.034843205574912,
"p95FrameDurationMs": 66.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8229.343999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7887.712,
"heapDeltaBytes": 6200176,
"heapUsedBytes": 279297712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 102.715,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.786713286713287,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 88.7019999999552,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.039000000000001,
"layouts": 6,
"layoutDurationMs": 2.2630000000000003,
"taskDurationMs": 62.50599999999999,
"heapDeltaBytes": 4999268,
"heapUsedBytes": 67081724,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.163,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 88.19099999993796,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.351999999999999,
"layouts": 7,
"layoutDurationMs": 2.233,
"taskDurationMs": 62.675,
"heapDeltaBytes": 4897792,
"heapUsedBytes": 66165096,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.989,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 260.8589999999822,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5900000000000001,
"layouts": 76,
"layoutDurationMs": 12.992,
"taskDurationMs": 221.154,
"heapDeltaBytes": -5588172,
"heapUsedBytes": 37716136,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 90.974,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 253.0739999999696,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.593,
"layouts": 76,
"layoutDurationMs": 12.562999999999999,
"taskDurationMs": 221.287,
"heapDeltaBytes": -5125804,
"heapUsedBytes": 36786644,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 93.327,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 299.0190000000439,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8760000000000001,
"layouts": 76,
"layoutDurationMs": 12.211,
"taskDurationMs": 265.62600000000003,
"heapDeltaBytes": -1738544,
"heapUsedBytes": 90975880,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.45100000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 302.9579999999896,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.442,
"layouts": 76,
"layoutDurationMs": 12.324,
"taskDurationMs": 266.70099999999996,
"heapDeltaBytes": -788456,
"heapUsedBytes": 97036900,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 89.377,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 3223 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5f9b65190f22b8385a1d89bad988f67107949336
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #22966 +/- ##
=============================================
Coverage ? 87.51%
=============================================
Files ? 2890
Lines ? 159611
Branches ? 40737
=============================================
Hits ? 139687
Misses ? 19161
Partials ? 763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport, per the requested backport review policy. No additional code review or test execution performed.
#22945) Asking the agent to "put both KSamplers in one group" now draws the group around those KSamplers. Before this, the group either never appeared (fixed by #21749) or, since #21749, appeared empty to the right of the graph, while the agent's own copy of the workflow said it framed the KSamplers. Frontend 1.60 QA row REG04 ([results](https://github.com/Comfy-Org/ideation-sharing/blob/synap5e/docs/fe160-qa-checklist/fe160-qa-checklist/results/part-b/README.md)). Fixes [FRONT-3833](https://linear.app/comfyorg/issue/FRONT-3833). The only way the agent can make a group is an `insert_workflow` whose workflow carries just that group (comfy-cli has no group op). #21749 started projecting `meta.groups`, and `placeBatch` then treats the group like any inserted batch. A group drawn around existing nodes always collides with them, so in a live agent turn `placementOffset` moves it beside the graph. Group geometry has no op, so the moved position never reaches the document: canvas and document disagree. In `LiveGraphApplier.placeBatch`, a created group that frames existing nodes and none of the nodes created with it keeps the document's coordinates, also when the same insertion adds nodes elsewhere. In a group-only insertion where any group frames existing nodes, all of its groups stay together. Membership is LiteGraph's own test, `containsCentre` on an existing node's rendered `boundingRect`, as `recomputeInsideNodes` does (nodes created in the same frame are not drawn yet and use the bounds `measure()` would give, title included, without its side effect on collapsed width). Everything else is placed as before: groups that frame nothing (the #21749 case "clear of the groups already on the canvas" is unchanged) and groups around newly inserted nodes (stage frames, PM-947). This matches comfy-cli's `rebase_template`, which already leaves a group-only template where it was authored. - `agentCrdtProjection.integration.test.ts`, red on main and green here: "keeps a group-only insertion on the existing nodes it frames" (`expected [680, 20] to deeply equal [0, 10]`; replaces the #21749 case that pinned the old placement for this exact shape), "keeps a group around existing nodes in place when the same insertion adds a node", "keeps every group of a group-only insertion together when one frames existing nodes", "keeps a group on a collapsed node it frames as rendered", "places a group with the new node it frames by its rendered title". Control, green on both: "places a group-only insertion that frames no node clear of the canvas content". - `agentStageFramesFromInsertedWorkflow.spec.ts`: new browser case "keeps a group drawn around existing nodes on those nodes" (bounding unchanged, the existing node is its member). Not run locally (host disk/IO); CI runs it. - `vitest run src/workbench/extensions/agent/crdt/`: 78 files, 1410 passed, 2 expected fail. `src/workbench/extensions/agent/crdt/**` is under the informal freeze, so this waits for @DrJKL's review and is not self-merged. (cherry picked from commit 0d1a02c)
42e366e to
81f413b
Compare
#22974) Backport of #22958 to `core/1.60`. A group the agent inserts without an `id` was dropped by the live applier, so it never reached the canvas or the saved workflow. This is the second half of the "groups the agent adds don't show up" fix, after #21749 (#22844/#22845) and #22945 (#22965/#22966), which are already on this branch. Manual: the auto-backport stopped on two browser-test files (`agentStageFrames.ts`, `agentStageFramesFromInsertedWorkflow.spec.ts`) that do not exist on `core/1.60`, so their hunks are left out. The one content conflict was the import line in `liveGraphApplier.test.ts`: `readDocGroups` is imported next to `LiveGraphApplier`; `readDocWidgetValue` (imported on main) is not used by this branch's test file, so it stays out. `liveGraphApplier.ts` and the integration tests apply unchanged.
…id (#22975) Backport of #22958 to `cloud/1.60`. A group the agent inserts without an `id` was dropped by the live applier, so it never reached the canvas or the saved workflow. This is the second half of the "groups the agent adds don't show up" fix, after #21749 (#22844/#22845) and #22945 (#22965/#22966), which are already on this branch. Manual: the auto-backport stopped on two browser-test files (`agentStageFrames.ts`, `agentStageFramesFromInsertedWorkflow.spec.ts`) that do not exist on `cloud/1.60`, so their hunks are left out. The one content conflict was the import line in `liveGraphApplier.test.ts`: `readDocGroups` is imported next to `LiveGraphApplier`; `readDocWidgetValue` (imported on main) is not used by this branch's test file, so it stays out. `liveGraphApplier.ts` and the integration tests apply unchanged.
Backport of #22945 to
cloud/1.60.Manual: the auto-backport stopped on two browser-test files (
agentStageFrames.ts,agentStageFramesFromInsertedWorkflow.spec.ts) that do not exist oncloud/1.60, so their hunks are left out. TheliveGraphApplier.tschange and its integration tests apply unchanged; the integration and applier suites pass on this branch (110 tests).