Repository navigation
[backport cloud/1.60] fix(agent): show inserted groups that carry no id - #22975
Conversation
An agent turn that asks for a group can report "Done, both KSamplers are
in one group" while no group ever appears on the canvas, also after a
save and reload (FE 1.60 QA REG04, on 1.59, 1.60 and 1.61.0.dev1). Part
of FRONT-3833.
Cause: `insert_workflow` keeps a group's `id` only when the inserted
workflow gave it one (`remap` only rewrites a present `id`), so the host
accepts a group written as just `{ title, bounding }` and stores it in
`meta.groups` with no id. `readDocGroups` required `id: z.number()` and
dropped that record silently, in both the change collector and the
applier, so the group never reached the canvas or the saved workflow.
Fix: a `meta.groups` record without a numeric id gets a stable id
derived from its content (FNV-1a over key-sorted JSON). The collector
and the applier name the same canvas group on every read, and a later
`clear` removes it. Records with a numeric id are unchanged.
- Integration (`agentCrdtProjection.integration.test.ts`): "creates and
clears an inserted group that carries no id" — red on main (`expected []
to deeply equal [ 'KSamplers' ]`), green here. crdt suite: 1415 pass.
- Browser (`agentStageFramesFromInsertedWorkflow.spec.ts`): "shows stage
frames the agent inserted without group ids, and saves them" — the same
PM-947 stage-frames insertion with the group ids stripped must show both
frames and save them.
Related: #22945 (a group drawn around existing nodes was moved off them)
is the other REG04 cause.
(cherry picked from commit 723f628)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T06:36:06.193Z",
"gitSha": "37e632b28b84fa03d7f95ac8478652ff256273d5",
"branch": "backport-22958-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.496999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.967,
"layouts": 9,
"layoutDurationMs": 2.891,
"taskDurationMs": 649.485,
"heapDeltaBytes": -4121604,
"heapUsedBytes": 64895616,
"domNodes": -178,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 12.329999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2035.765000000083,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3750000000000004,
"layouts": 7,
"layoutDurationMs": 2.2360000000000007,
"taskDurationMs": 616.635,
"heapDeltaBytes": 13243312,
"heapUsedBytes": 73058584,
"domNodes": -178,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 10.239,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1960.8989999999835,
"styleRecalcs": 53,
"styleRecalcDurationMs": 16.051,
"layouts": 8,
"layoutDurationMs": 3.8819999999999997,
"taskDurationMs": 1013.6,
"heapDeltaBytes": 212776,
"heapUsedBytes": 61838328,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 177.642,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.4270000000652,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.283,
"layouts": 9,
"layoutDurationMs": 2.9319999999999995,
"taskDurationMs": 965.2890000000001,
"heapDeltaBytes": -6774460,
"heapUsedBytes": 66457120,
"domNodes": -178,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 166.746,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.5499999999847,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.799,
"layouts": 12,
"layoutDurationMs": 3.22,
"taskDurationMs": 457.159,
"heapDeltaBytes": 11573224,
"heapUsedBytes": 84542544,
"domNodes": 57,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 13.841000000000003,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9610000000685,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.29,
"layouts": 11,
"layoutDurationMs": 3.233,
"taskDurationMs": 462.098,
"heapDeltaBytes": 7755308,
"heapUsedBytes": 84378172,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 13.921999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 731.1559999999986,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1060000000000003,
"layouts": 10,
"layoutDurationMs": 3.027,
"taskDurationMs": 536.413,
"heapDeltaBytes": 2713396,
"heapUsedBytes": 62502988,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 174.701,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 721.6019999999617,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.615,
"layouts": 9,
"layoutDurationMs": 2.382,
"taskDurationMs": 524.138,
"heapDeltaBytes": -13386580,
"heapUsedBytes": 60122224,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 172.844,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069764,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1238.0619999999567,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 950.4070000000002,
"heapDeltaBytes": 18021928,
"heapUsedBytes": 107374580,
"domNodes": -148,
"jsHeapTotalBytes": 19165184,
"scriptDurationMs": 73.753,
"eventListeners": -107,
"totalBlockingTimeMs": 593,
"frameDurationMs": 35.237142857142864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1182.0549999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 883.514,
"heapDeltaBytes": 23701192,
"heapUsedBytes": 87436944,
"domNodes": 0,
"jsHeapTotalBytes": 11436032,
"scriptDurationMs": 73.843,
"eventListeners": 0,
"totalBlockingTimeMs": 546,
"frameDurationMs": 34.80294117647058,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.73900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.1369999999997,
"heapDeltaBytes": -4168412,
"heapUsedBytes": 72545484,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.72199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.759999999999984,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.4739999999247,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.572,
"heapDeltaBytes": -2790276,
"heapUsedBytes": 72181024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.787,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11553.676999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10617.369999999999,
"heapDeltaBytes": 69650588,
"heapUsedBytes": 163762896,
"domNodes": -274,
"jsHeapTotalBytes": 76410880,
"scriptDurationMs": 8443.911999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 1402,
"frameDurationMs": 32.26145251396648,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11219.834999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10369.582,
"heapDeltaBytes": 49856068,
"heapUsedBytes": 143862768,
"domNodes": -274,
"jsHeapTotalBytes": 80605184,
"scriptDurationMs": 8263.679,
"eventListeners": -69,
"totalBlockingTimeMs": 1220,
"frameDurationMs": 31.242896935933146,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10820.797999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9985.452000000001,
"heapDeltaBytes": 56025684,
"heapUsedBytes": 131773500,
"domNodes": -274,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 7987.252999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1051,
"frameDurationMs": 31.308959537572253,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11322.129999999903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10495.36,
"heapDeltaBytes": 77495472,
"heapUsedBytes": 172277652,
"domNodes": -274,
"jsHeapTotalBytes": 82964480,
"scriptDurationMs": 8427.796,
"eventListeners": -69,
"totalBlockingTimeMs": 1250,
"frameDurationMs": 31.43388888888889,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 236.98899999999412,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.961999999999998,
"layouts": 8,
"layoutDurationMs": 2.536,
"taskDurationMs": 175.06100000000004,
"heapDeltaBytes": 14938856,
"heapUsedBytes": 75618564,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.812999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 7,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 227.37499999993815,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.599,
"layouts": 8,
"layoutDurationMs": 2.8289999999999997,
"taskDurationMs": 176.008,
"heapDeltaBytes": 14911120,
"heapUsedBytes": 75643348,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.939,
"eventListeners": 205,
"totalBlockingTimeMs": 7,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2053.9529999999786,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.947,
"layouts": 8,
"layoutDurationMs": 2.6369999999999996,
"taskDurationMs": 751.769,
"heapDeltaBytes": -18525892,
"heapUsedBytes": 63210344,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 35.906000000000006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.0300000000307,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5200000000000005,
"layouts": 8,
"layoutDurationMs": 2,
"taskDurationMs": 700.847,
"heapDeltaBytes": -18382708,
"heapUsedBytes": 64391236,
"domNodes": -274,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 37.11200000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2988.429999999994,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.139000000000001,
"layouts": 6,
"layoutDurationMs": 1.6090000000000002,
"taskDurationMs": 1894.116,
"heapDeltaBytes": -5726808,
"heapUsedBytes": 78471716,
"domNodes": -274,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 901.9619999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665363128491617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2916.4329999999836,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.003,
"layouts": 7,
"layoutDurationMs": 1.9030000000000002,
"taskDurationMs": 1851.0209999999997,
"heapDeltaBytes": 1490208,
"heapUsedBytes": 73945756,
"domNodes": -274,
"jsHeapTotalBytes": 3497984,
"scriptDurationMs": 917.1429999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3980.1889999999958,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.717000000000002,
"layouts": 64,
"layoutDurationMs": 10.801000000000002,
"taskDurationMs": 1934.662,
"heapDeltaBytes": -30461188,
"heapUsedBytes": 62553984,
"domNodes": -250,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 825.924,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666108786610877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4063.6819999999716,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.777000000000001,
"layouts": 64,
"layoutDurationMs": 10.094000000000001,
"taskDurationMs": 1915.602,
"heapDeltaBytes": -8830508,
"heapUsedBytes": 67206080,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 829.006,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3204.913999999974,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.214,
"layouts": 4,
"layoutDurationMs": 1.0699999999999998,
"taskDurationMs": 2123.2990000000004,
"heapDeltaBytes": -1799908,
"heapUsedBytes": 72340780,
"domNodes": 0,
"jsHeapTotalBytes": 5857280,
"scriptDurationMs": 1036.1480000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 24,
"frameDurationMs": 16.927748691099474,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3211.153000000081,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.038999999999999,
"layouts": 5,
"layoutDurationMs": 1.2439999999999998,
"taskDurationMs": 2090.5550000000003,
"heapDeltaBytes": -16193592,
"heapUsedBytes": 78580640,
"domNodes": -274,
"jsHeapTotalBytes": 5824512,
"scriptDurationMs": 1005.001,
"eventListeners": -66,
"totalBlockingTimeMs": 4,
"frameDurationMs": 16.84083769633508,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3072.6290000000063,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5839999999999996,
"layouts": 8,
"layoutDurationMs": 2.3579999999999997,
"taskDurationMs": 740.353,
"heapDeltaBytes": -9071396,
"heapUsedBytes": 63446660,
"domNodes": -274,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 387.76800000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3074.738000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6640000000000006,
"layouts": 9,
"layoutDurationMs": 2.458,
"taskDurationMs": 825.782,
"heapDeltaBytes": -8350936,
"heapUsedBytes": 75463208,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 367.998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.384999999954,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.338999999999999,
"layouts": 7,
"layoutDurationMs": 2.3539999999999996,
"taskDurationMs": 812.6700000000001,
"heapDeltaBytes": -20416148,
"heapUsedBytes": 65794300,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 43.363,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.9700000000112,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7100000000000004,
"layouts": 9,
"layoutDurationMs": 2.7149999999999994,
"taskDurationMs": 703.2869999999999,
"heapDeltaBytes": -20281988,
"heapUsedBytes": 63445156,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 36.291,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2885.655999999983,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.870000000000003,
"layouts": 6,
"layoutDurationMs": 1.7009999999999998,
"taskDurationMs": 649.2629999999999,
"heapDeltaBytes": -5128384,
"heapUsedBytes": 78643972,
"domNodes": -256,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 198.303,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76279069767442,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2915.973000000008,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.811,
"layouts": 7,
"layoutDurationMs": 1.7049999999999998,
"taskDurationMs": 637.367,
"heapDeltaBytes": -5864452,
"heapUsedBytes": 66430192,
"domNodes": -260,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 196.057,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3325.285000000008,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7249999999999999,
"layouts": 6,
"layoutDurationMs": 1.51,
"taskDurationMs": 1027.494,
"heapDeltaBytes": -21394264,
"heapUsedBytes": 63623300,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 386.826,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66582914572864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3312.6359999999977,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8349999999999997,
"layouts": 7,
"layoutDurationMs": 1.9660000000000002,
"taskDurationMs": 1009.5490000000002,
"heapDeltaBytes": -18356140,
"heapUsedBytes": 61977196,
"domNodes": -274,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 391.368,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66633165829146,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 642.2770000000355,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.191000000000001,
"layouts": 9,
"layoutDurationMs": 2.584,
"taskDurationMs": 451.44700000000006,
"heapDeltaBytes": 23883684,
"heapUsedBytes": 85871532,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 150.174,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.9689999999646,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.6930000000000005,
"layouts": 10,
"layoutDurationMs": 2.5300000000000007,
"taskDurationMs": 456.177,
"heapDeltaBytes": 5167224,
"heapUsedBytes": 76893304,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 145.919,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2037.7399999999852,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7919999999999994,
"layouts": 9,
"layoutDurationMs": 2.8529999999999998,
"taskDurationMs": 620.2090000000001,
"heapDeltaBytes": -25528,
"heapUsedBytes": 63659244,
"domNodes": -200,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 10.579999999999998,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.0700000000143,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.959999999999999,
"layouts": 8,
"layoutDurationMs": 2.64,
"taskDurationMs": 641.255,
"heapDeltaBytes": -5909620,
"heapUsedBytes": 64685536,
"domNodes": -200,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 10.959,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.0469999999568,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.670000000000003,
"layouts": 10,
"layoutDurationMs": 3.178,
"taskDurationMs": 943.1260000000001,
"heapDeltaBytes": -8517928,
"heapUsedBytes": 63062372,
"domNodes": -200,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 118.045,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.615000000077,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.715,
"layouts": 8,
"layoutDurationMs": 2.514,
"taskDurationMs": 902.3100000000001,
"heapDeltaBytes": 5070932,
"heapUsedBytes": 76422460,
"domNodes": -200,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 112.184,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1592.538999999988,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.433,
"layouts": 5,
"layoutDurationMs": 19.267999999999997,
"taskDurationMs": 1368.5130000000001,
"heapDeltaBytes": 20420576,
"heapUsedBytes": 121174488,
"domNodes": 19229,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 31.215,
"eventListeners": 3566,
"totalBlockingTimeMs": 228,
"frameDurationMs": 20.511538461538457,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10946.333999999979,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.964999999999993,
"layouts": 8,
"layoutDurationMs": 2.4490000000000003,
"taskDurationMs": 6573.355,
"heapDeltaBytes": -19382640,
"heapUsedBytes": 62854164,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2952.418,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691450381679388,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10585.490000000049,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.703999999999997,
"layouts": 8,
"layoutDurationMs": 2.5180000000000002,
"taskDurationMs": 6314.178,
"heapDeltaBytes": -19357312,
"heapUsedBytes": 63049108,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 2810.8329999999996,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665984251968506,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24681.018999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23826.175,
"heapDeltaBytes": -22326780,
"heapUsedBytes": 267093976,
"domNodes": -3482,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 365.933,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.73368794326241,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 24486.894000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23606.301000000003,
"heapDeltaBytes": -47729280,
"heapUsedBytes": 262248444,
"domNodes": -3482,
"jsHeapTotalBytes": 11517952,
"scriptDurationMs": 357.78,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.726876090750444,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29719.632999999987,
"styleRecalcs": 181,
"styleRecalcDurationMs": 26.06,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29350.801000000003,
"heapDeltaBytes": -11360820,
"heapUsedBytes": 272348036,
"domNodes": -3482,
"jsHeapTotalBytes": 13877248,
"scriptDurationMs": 943.7769999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 42,
"frameDurationMs": 55.43917910447761,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 29126.236999999946,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.467999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28763.856000000003,
"heapDeltaBytes": -51729932,
"heapUsedBytes": 275826980,
"domNodes": -3482,
"jsHeapTotalBytes": -5259264,
"scriptDurationMs": 880.133,
"eventListeners": -659,
"totalBlockingTimeMs": 26,
"frameDurationMs": 54.460861423220976,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8998.010000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.098,
"layouts": 20,
"layoutDurationMs": 30.653,
"taskDurationMs": 8893.432,
"heapDeltaBytes": -2138236,
"heapUsedBytes": 281837724,
"domNodes": -3482,
"jsHeapTotalBytes": 13352960,
"scriptDurationMs": 139.42399999999998,
"eventListeners": -661,
"totalBlockingTimeMs": 5,
"frameDurationMs": 49.448901098901096,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8768.198999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.49699999999999,
"layouts": 20,
"layoutDurationMs": 23.463999999999984,
"taskDurationMs": 8637.194000000001,
"heapDeltaBytes": -6159576,
"heapUsedBytes": 272244368,
"domNodes": -3482,
"jsHeapTotalBytes": 18071552,
"scriptDurationMs": 150.856,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.4764367816092,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12568.056000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12058.226999999999,
"heapDeltaBytes": 12583436,
"heapUsedBytes": 276756388,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 190.43699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.937412587412595,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12350.40099999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11906.027999999998,
"heapDeltaBytes": 4396184,
"heapUsedBytes": 278223640,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 194.894,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.58482758620689,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 161.08600000006845,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.271,
"layouts": 10,
"layoutDurationMs": 4.199,
"taskDurationMs": 114.43499999999999,
"heapDeltaBytes": 5154124,
"heapUsedBytes": 72138620,
"domNodes": 107,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.266000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 131.29300000002786,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.180000000000001,
"layouts": 8,
"layoutDurationMs": 3.531,
"taskDurationMs": 94.094,
"heapDeltaBytes": -11693308,
"heapUsedBytes": 63132068,
"domNodes": 125,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 6.558000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 465.7519999999522,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.661,
"layouts": 76,
"layoutDurationMs": 15.467,
"taskDurationMs": 428.811,
"heapDeltaBytes": -1005496,
"heapUsedBytes": 47134164,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 202.52100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 601.6839999999775,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.728,
"layouts": 76,
"layoutDurationMs": 16.840999999999998,
"taskDurationMs": 562.7890000000001,
"heapDeltaBytes": 802960,
"heapUsedBytes": 49500280,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 276.614,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 552.6139999999486,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.631,
"layouts": 76,
"layoutDurationMs": 15.061,
"taskDurationMs": 519.385,
"heapDeltaBytes": 788572,
"heapUsedBytes": 105778908,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 209.74200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.17272727272727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 711.4819999999327,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.063,
"layouts": 76,
"layoutDurationMs": 16.35,
"taskDurationMs": 683.458,
"heapDeltaBytes": -24809696,
"heapUsedBytes": 80980624,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 286.748,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3224 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since aa1e27aee598635c26eda8aa3c62d35b3ea15654
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #22975 +/- ##
=============================================
Coverage ? 87.52%
=============================================
Files ? 2890
Lines ? 159644
Branches ? 40745
=============================================
Hits ? 139725
Misses ? 19156
Partials ? 763
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 39b7be0 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Backport of #22958 to
cloud/1.60.A group the agent inserts without an
idwas dropped by the live applier, so it never reached the canvas or the saved workflow. This is the second half of the "groups the agent adds don't show up" fix, after #21749 (#22844/#22845) and #22945 (#22965/#22966), which are already on this branch.Manual: the auto-backport stopped on two browser-test files (
agentStageFrames.ts,agentStageFramesFromInsertedWorkflow.spec.ts) that do not exist oncloud/1.60, so their hunks are left out. The one content conflict was the import line inliveGraphApplier.test.ts:readDocGroupsis imported next toLiveGraphApplier;readDocWidgetValue(imported on main) is not used by this branch's test file, so it stays out.liveGraphApplier.tsand the integration tests apply unchanged.