Skip to content

M4 fix(billing): show the member auto top-up block from the served member notice fact - #22914

Merged
dante01yoon merged 3 commits into
mainfrom
e1-member-notice-served-fact
Nov 4, 2026
Merged

dante01yoon merged 3 commits into
mainfrom
e1-member-notice-served-fact

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The Billing tab shows the member auto top-up block ("Contact a workspace owner to manage this.") only when the server serves can_view_auto_top_up_member_notice: true, so a member on a paused Team workspace no longer sees it. The owner card now renders the served can_view_auto_top_up instead of the BE-25243 interim combination.

Stacked on #22913 (ingest-types sync).

Why

QA case E1 on 1.60: a Member on a paused Team workspace still sees the member block; the design hides it while paused. https://comfy-organization.slack.com/archives/C0932CGKT5K/p1793803745327049

Root cause

deriveAutoTopUpSection showed the member block for any denied_reasons.can_manage_auto_top_up === 'not_workspace_owner'. That denial only says the actor is not an owner; it says nothing about the workspace being paused or past due, so a paused member qualified. The backend now serves that answer directly (cloud#18078).

How

  • useBillingCapabilities exposes canViewAutoTopUpMemberNotice as receiveServerFact('can_view_auto_top_up_member_notice', ...).
  • canViewAutoTopUpCard reads receiveServerFact('can_view_auto_top_up', ...) (cloud#17972). The pendingServerFact('BE-25243', canManageAutoTopUp && canTopUp) wrapper is deleted, as pendingServerFact requires once the field ships.
  • deriveAutoTopUpSection takes canViewAutoTopUpMemberNotice in place of manageAutoTopUpDenial and shows memberBlock when it is true, still inside auto_top_up_enabled and after the card check.
  • manageAutoTopUpDenial had no other reader and is removed from the composable and its mock.

Commits: the test commit (test(billing): ...) goes red on the member block, the core table and the served card fact; it carries the type surface the tests compile against (the new fact on the composable, its mock, and AutoTopUpSectionFacts), because the pre-commit typecheck rejects a test against an API that does not exist yet. The fix commit changes no tests.

Verification

  • pnpm exec vitest run src/platform/billing src/platform/account: 4061/4061.
  • account-core src/core/billing/billingTab: 137/137.
  • Red commit alone: BillingTab member block, the core "member on a healthy workspace" row and the three served can_view_auto_top_up composable cases fail; the fix commit turns them green.
  • pnpm typecheck, typecheck:account-core, knip: clean.
AS IS TO BE
Member, paused Team workspace AS IS: Member, paused Team workspace TO BE: Member, paused Team workspace
Member, healthy Team workspace AS IS: Member, healthy Team workspace TO BE: Member, healthy Team workspace
Owner, healthy Team workspace AS IS: Owner, healthy Team workspace TO BE: Owner, healthy Team workspace

Risk

Both capability booleans are required in the generated zod. Without them from prod ingest, the SDK capabilities read fails to decode; the legacy read falls back to false and hides the card and the member block. Ingest must ship cloud#17972 and cloud#18078 before this.

@dante01yoon
dante01yoon requested a review from a team as a code owner November 4, 2026 18:07
@dante01yoon dante01yoon added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.60 Backport PRs for core 1.60 cloud/1.60 Backport PRs for cloud 1.60 labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 8 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.4 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
dom-widget-order-dense-n200-w200-i120: 30.6 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 511ms TBT · 74.0 MB heap
dom-widget-order-sparse-n1000-w20-i120: 40.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 223ms TBT · 63.4 MB heap
extension-clean-combined-draw: 33.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 360ms TBT · 148.3 MB heap
extension-rgthree-prototype-draw: 33.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 237ms TBT · 147.6 MB heap
large-combo-open: 43.2 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 5ms TBT · 68.7 MB heap
large-graph-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
large-graph-pan: 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
large-graph-zoom: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
minimap-geometry-cadence: 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
minimap-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
minimap-progress-execution-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
minimap-topology-cadence: 59.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
subgraph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
subgraph-transition-enter: 49.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 219ms TBT · 85.7 MB heap
viewport-pan-sweep: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.2 MB heap
vue-large-graph-idle: 21.9 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 260.0 MB heap
vue-large-graph-pan: 16.8 avg FPS · 8.6 P5 FPS ❌ (target: ≥52) · 89ms TBT · 257.1 MB heap
vue-node-resize-workload: 18.4 avg FPS · 9.2 P5 FPS ❌ (target: ≥52) · 70ms TBT · 251.3 MB heap
vue-zoom-out-idle: 20.3 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 261.5 MB heap
workflow-execution: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.3 MB heap
agent-composer-long-conversation-typing: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.3 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 9
canvas-idle: style recalc count 9
canvas-idle: task duration 688ms
canvas-idle: script duration 14ms
canvas-idle: TBT 0ms
canvas-idle: heap used 54.4 MB
canvas-idle: DOM nodes -178
canvas-idle: event listeners -69
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1011ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 61.6 MB
canvas-mouse-sweep: DOM nodes -178
canvas-mouse-sweep: event listeners -69
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 511ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 57
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 518ms
dom-widget-clipping: script duration 176ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.2 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 25ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 940ms
dom-widget-order-dense-n200-w200-i120: script duration 60ms
dom-widget-order-dense-n200-w200-i120: TBT 511ms
dom-widget-order-dense-n200-w200-i120: heap used 74.0 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -208
dom-widget-order-dense-n200-w200-i120: event listeners -107
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 599ms
dom-widget-order-sparse-n1000-w20-i120: script duration 151ms
dom-widget-order-sparse-n1000-w20-i120: TBT 223ms
dom-widget-order-sparse-n1000-w20-i120: heap used 63.4 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -208
dom-widget-order-sparse-n1000-w20-i120: event listeners -107
extension-clean-combined-draw: avg frame time 30ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9374ms
extension-clean-combined-draw: script duration 7270ms
extension-clean-combined-draw: TBT 360ms
extension-clean-combined-draw: heap used 148.3 MB
extension-clean-combined-draw: DOM nodes -274
extension-clean-combined-draw: event listeners -69
extension-rgthree-prototype-draw: avg frame time 30ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 1
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 8374ms
extension-rgthree-prototype-draw: script duration 6818ms
extension-rgthree-prototype-draw: TBT 237ms
extension-rgthree-prototype-draw: heap used 147.6 MB
extension-rgthree-prototype-draw: DOM nodes -274
extension-rgthree-prototype-draw: event listeners -69
large-combo-open: avg frame time 23ms
large-combo-open: p95 frame time 83ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 16ms
large-combo-open: layout count 9
large-combo-open: style recalc count 23
large-combo-open: task duration 206ms
large-combo-open: script duration 11ms
large-combo-open: TBT 5ms
large-combo-open: heap used 68.7 MB
large-combo-open: DOM nodes -746
large-combo-open: event listeners -189
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 7
large-graph-idle: style recalc count 8
large-graph-idle: task duration 769ms
large-graph-idle: script duration 45ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.1 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -69
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1733ms
large-graph-pan: script duration 851ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.3 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -67
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 65
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1950ms
large-graph-zoom: script duration 832ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.1 MB
large-graph-zoom: DOM nodes -250
large-graph-zoom: event listeners -69
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 4
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 2209ms
legacy-node-drag: script duration 1060ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.4 MB
legacy-node-drag: DOM nodes -274
legacy-node-drag: event listeners -63
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 5
minimap-geometry-cadence: style recalc count 6
minimap-geometry-cadence: task duration 867ms
minimap-geometry-cadence: script duration 383ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 63.9 MB
minimap-geometry-cadence: DOM nodes -137
minimap-geometry-cadence: event listeners -35
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 7
minimap-idle: style recalc count 7
minimap-idle: task duration 760ms
minimap-idle: script duration 41ms
minimap-idle: TBT 0ms
minimap-idle: heap used 62.4 MB
minimap-idle: DOM nodes -274
minimap-idle: event listeners -69
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 2ms
minimap-progress-execution-cadence: style recalc duration 13ms
minimap-progress-execution-cadence: layout count 6
minimap-progress-execution-cadence: style recalc count 26
minimap-progress-execution-cadence: task duration 599ms
minimap-progress-execution-cadence: script duration 192ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 75.9 MB
minimap-progress-execution-cadence: DOM nodes 19
minimap-progress-execution-cadence: event listeners 0
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 2ms
minimap-topology-cadence: layout count 6
minimap-topology-cadence: style recalc count 6
minimap-topology-cadence: task duration 1026ms
minimap-topology-cadence: script duration 400ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 69.3 MB
minimap-topology-cadence: DOM nodes -137
minimap-topology-cadence: event listeners -35
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 498ms
subgraph-dom-widget-clipping: script duration 152ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 76.6 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 10
subgraph-idle: task duration 590ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 79.6 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 17ms
subgraph-mouse-sweep: layout count 9
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 984ms
subgraph-mouse-sweep: script duration 118ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.7 MB
subgraph-mouse-sweep: DOM nodes -200
subgraph-mouse-sweep: event listeners -116
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 19ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1526ms
subgraph-transition-enter: script duration 41ms
subgraph-transition-enter: TBT 219ms
subgraph-transition-enter: heap used 85.7 MB
subgraph-transition-enter: DOM nodes -1320
subgraph-transition-enter: event listeners -262
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 6311ms
viewport-pan-sweep: script duration 2820ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.2 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -67
vue-large-graph-idle: avg frame time 46ms
vue-large-graph-idle: p95 frame time 100ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 24992ms
vue-large-graph-idle: script duration 362ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 260.0 MB
vue-large-graph-idle: DOM nodes -3482
vue-large-graph-idle: event listeners -661
vue-large-graph-pan: avg frame time 60ms
vue-large-graph-pan: p95 frame time 117ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 25ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 30521ms
vue-large-graph-pan: script duration 958ms
vue-large-graph-pan: TBT 89ms
vue-large-graph-pan: heap used 257.1 MB
vue-large-graph-pan: DOM nodes -3482
vue-large-graph-pan: event listeners -659
vue-node-resize-workload: avg frame time 54ms
vue-node-resize-workload: p95 frame time 108ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 73ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 9313ms
vue-node-resize-workload: script duration 168ms
vue-node-resize-workload: TBT 70ms
vue-node-resize-workload: heap used 251.3 MB
vue-node-resize-workload: DOM nodes -3482
vue-node-resize-workload: event listeners -661
vue-zoom-out-idle: avg frame time 49ms
vue-zoom-out-idle: p95 frame time 100ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 12815ms
vue-zoom-out-idle: script duration 187ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 261.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 8
workflow-execution: style recalc count 9
workflow-execution: task duration 111ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.6 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 7
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 16ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 473ms
agent-composer-empty-conversation-typing: script duration 222ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 44.3 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 16ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 583ms
agent-composer-long-conversation-typing: script duration 228ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 98.3 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-11-04T18:20:52.952Z",
  "gitSha": "11c5fd3f37626b3c003cba49afb98e789a0c636e",
  "branch": "e1-member-notice-served-fact",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2056.669999999997,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.9779999999999998,
      "layouts": 8,
      "layoutDurationMs": 2.7880000000000003,
      "taskDurationMs": 671.346,
      "heapDeltaBytes": -180120,
      "heapUsedBytes": 62020988,
      "domNodes": -178,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 14.626,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.6910000000007,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.2720000000000007,
      "layouts": 9,
      "layoutDurationMs": 3.102,
      "taskDurationMs": 703.977,
      "heapDeltaBytes": -20688996,
      "heapUsedBytes": 52037676,
      "domNodes": -178,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 13.601000000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1858.6930000000166,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 13.983,
      "layouts": 8,
      "layoutDurationMs": 2.3229999999999995,
      "taskDurationMs": 989.6310000000001,
      "heapDeltaBytes": -4506648,
      "heapUsedBytes": 57943240,
      "domNodes": -178,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 162.908,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1908.6609999999382,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 15.639999999999997,
      "layouts": 9,
      "layoutDurationMs": 2.788,
      "taskDurationMs": 1032.761,
      "heapDeltaBytes": -96228,
      "heapUsedBytes": 71337028,
      "domNodes": -178,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 165.33599999999998,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684207,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.1130000000162,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.901999999999999,
      "layouts": 11,
      "layoutDurationMs": 3.2660000000000005,
      "taskDurationMs": 474.555,
      "heapDeltaBytes": 5262688,
      "heapUsedBytes": 74070040,
      "domNodes": 57,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 14.380999999999998,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665686274509806,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1757.2669999999562,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 6.308,
      "layouts": 12,
      "layoutDurationMs": 3.706,
      "taskDurationMs": 547.92,
      "heapDeltaBytes": 4947560,
      "heapUsedBytes": 76449008,
      "domNodes": 57,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 16.878000000000004,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714287,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 690.4900000000112,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.072,
      "layouts": 8,
      "layoutDurationMs": 2.2830000000000004,
      "taskDurationMs": 483.443,
      "heapDeltaBytes": 241072,
      "heapUsedBytes": 61399188,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 174.871,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668292682926833,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 759.6640000000434,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.451,
      "layouts": 10,
      "layoutDurationMs": 3.224,
      "taskDurationMs": 552.212,
      "heapDeltaBytes": -15305896,
      "heapUsedBytes": 60721452,
      "domNodes": 0,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 176.48799999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664444444444445,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1202.7810000000159,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 904.8689999999999,
      "heapDeltaBytes": -4780928,
      "heapUsedBytes": 77686844,
      "domNodes": -208,
      "jsHeapTotalBytes": 15212544,
      "scriptDurationMs": 60.51799999999999,
      "eventListeners": -107,
      "totalBlockingTimeMs": 502,
      "frameDurationMs": 32.42972972972973,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1218.270000000075,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 975.275,
      "heapDeltaBytes": -11898696,
      "heapUsedBytes": 77541928,
      "domNodes": -208,
      "jsHeapTotalBytes": 20455424,
      "scriptDurationMs": 60.203,
      "eventListeners": -107,
      "totalBlockingTimeMs": 519,
      "frameDurationMs": 32.88108108108108,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 909.9989999999707,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.5530000000005,
      "heapDeltaBytes": -27875048,
      "heapUsedBytes": 65457984,
      "domNodes": -208,
      "jsHeapTotalBytes": 5636096,
      "scriptDurationMs": 154.26399999999995,
      "eventListeners": -107,
      "totalBlockingTimeMs": 225,
      "frameDurationMs": 24.12105263157896,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 906.8849999999884,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.5480000000003,
      "heapDeltaBytes": -25428156,
      "heapUsedBytes": 67480996,
      "domNodes": -208,
      "jsHeapTotalBytes": 5373952,
      "scriptDurationMs": 148.115,
      "eventListeners": -107,
      "totalBlockingTimeMs": 221,
      "frameDurationMs": 24.997222222222238,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10556.016999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9668.728000000001,
      "heapDeltaBytes": 81771292,
      "heapUsedBytes": 158072128,
      "domNodes": -274,
      "jsHeapTotalBytes": 80867328,
      "scriptDurationMs": 7508.1449999999995,
      "eventListeners": -69,
      "totalBlockingTimeMs": 419,
      "frameDurationMs": 28.93653846153846,
      "p95FrameDurationMs": 50.099999999999454
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9952.177000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9080.195,
      "heapDeltaBytes": 59068920,
      "heapUsedBytes": 152930320,
      "domNodes": -274,
      "jsHeapTotalBytes": 77459456,
      "scriptDurationMs": 7032.263999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 300,
      "frameDurationMs": 30.426911314984704,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9041.464999999987,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.42299999999999977,
      "layouts": 1,
      "layoutDurationMs": 0.33,
      "taskDurationMs": 8216.359,
      "heapDeltaBytes": 58456468,
      "heapUsedBytes": 150814584,
      "domNodes": -274,
      "jsHeapTotalBytes": 70119424,
      "scriptDurationMs": 6737.710000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 192,
      "frameDurationMs": 29.045016077170423,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9407.853000000046,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.3229999999999995,
      "layouts": 1,
      "layoutDurationMs": 0.3259999999999999,
      "taskDurationMs": 8532.629,
      "heapDeltaBytes": 65734620,
      "heapUsedBytes": 158661736,
      "domNodes": -274,
      "jsHeapTotalBytes": 72478720,
      "scriptDurationMs": 6898.097,
      "eventListeners": -69,
      "totalBlockingTimeMs": 281,
      "frameDurationMs": 30.321290322580648,
      "p95FrameDurationMs": 50.099999999999454
    },
    {
      "name": "large-combo-open",
      "durationMs": 219.23300000000268,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 14.325999999999999,
      "layouts": 7,
      "layoutDurationMs": 2.5499999999999994,
      "taskDurationMs": 167.00299999999996,
      "heapDeltaBytes": 14555132,
      "heapUsedBytes": 74948708,
      "domNodes": 936,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.659,
      "eventListeners": 205,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 24.077777777777758,
      "p95FrameDurationMs": 83.40000000000009
    },
    {
      "name": "large-combo-open",
      "durationMs": 287.16399999996156,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 16.849999999999998,
      "layouts": 11,
      "layoutDurationMs": 4.0299999999999985,
      "taskDurationMs": 245.16800000000003,
      "heapDeltaBytes": -6472772,
      "heapUsedBytes": 69214664,
      "domNodes": -2427,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.71,
      "eventListeners": -582,
      "totalBlockingTimeMs": 7,
      "frameDurationMs": 22.224999999999984,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.841999999984,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.856,
      "layouts": 8,
      "layoutDurationMs": 2.479,
      "taskDurationMs": 790.6120000000001,
      "heapDeltaBytes": 9339032,
      "heapUsedBytes": 83322616,
      "domNodes": -274,
      "jsHeapTotalBytes": 126976,
      "scriptDurationMs": 46.66199999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.118999999924,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.927999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.8619999999999994,
      "taskDurationMs": 747.934,
      "heapDeltaBytes": 6597516,
      "heapUsedBytes": 80410868,
      "domNodes": -274,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 43.295,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2955.001999999979,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 10.317,
      "layouts": 7,
      "layoutDurationMs": 1.991,
      "taskDurationMs": 1789.462,
      "heapDeltaBytes": -10113232,
      "heapUsedBytes": 71201104,
      "domNodes": -274,
      "jsHeapTotalBytes": 5332992,
      "scriptDurationMs": 815.8870000000001,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666292134831462,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2332.467000000065,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 10.409000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.6229999999999998,
      "taskDurationMs": 1676.076,
      "heapDeltaBytes": -10630972,
      "heapUsedBytes": 63652904,
      "domNodes": -274,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 886.144,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.785611510791366,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3838.661000000002,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.895999999999999,
      "layouts": 65,
      "layoutDurationMs": 11.675999999999998,
      "taskDurationMs": 1841.583,
      "heapDeltaBytes": 4357004,
      "heapUsedBytes": 80038708,
      "domNodes": -250,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 791.819,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666086956521738,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4225.897999999916,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 13.152,
      "layouts": 64,
      "layoutDurationMs": 12.969,
      "taskDurationMs": 2058.299,
      "heapDeltaBytes": -7012672,
      "heapUsedBytes": 71120104,
      "domNodes": -250,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 872.352,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66600790513834,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3255.6920000000105,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.199999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.6600000000000004,
      "taskDurationMs": 2134.272,
      "heapDeltaBytes": 4905812,
      "heapUsedBytes": 77288668,
      "domNodes": -274,
      "jsHeapTotalBytes": 4739072,
      "scriptDurationMs": 1015.145,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.752331606217616,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3332.593999999972,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.183999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.6940000000000002,
      "taskDurationMs": 2284.7110000000002,
      "heapDeltaBytes": 11915300,
      "heapUsedBytes": 85009508,
      "domNodes": -274,
      "jsHeapTotalBytes": 5525504,
      "scriptDurationMs": 1103.909,
      "eventListeners": -60,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.83383838383838,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3107.7300000000037,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.7270000000000012,
      "layouts": 5,
      "layoutDurationMs": 1.4050000000000005,
      "taskDurationMs": 877.054,
      "heapDeltaBytes": -15701156,
      "heapUsedBytes": 60627752,
      "domNodes": -274,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 372.247,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666129032258063,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3213.324000000057,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.3999999999999995,
      "layouts": 5,
      "layoutDurationMs": 1.919,
      "taskDurationMs": 857.443,
      "heapDeltaBytes": -3042604,
      "heapUsedBytes": 73443668,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 394.041,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.752604166666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.8819999999823,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.5370000000000004,
      "layouts": 7,
      "layoutDurationMs": 2.1809999999999996,
      "taskDurationMs": 802.7979999999999,
      "heapDeltaBytes": -5676368,
      "heapUsedBytes": 67554704,
      "domNodes": -274,
      "jsHeapTotalBytes": 2748416,
      "scriptDurationMs": 41.036,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.2979999999598,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.9559999999999995,
      "layouts": 6,
      "layoutDurationMs": 1.683,
      "taskDurationMs": 717.349,
      "heapDeltaBytes": -11357436,
      "heapUsedBytes": 63369604,
      "domNodes": -274,
      "jsHeapTotalBytes": 126976,
      "scriptDurationMs": 41.39300000000001,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665040650406507,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2764.2219999999897,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 12.824,
      "layouts": 6,
      "layoutDurationMs": 1.597,
      "taskDurationMs": 586.056,
      "heapDeltaBytes": 6787304,
      "heapUsedBytes": 79571352,
      "domNodes": 19,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 190.853,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666265060240967,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2832.341000000042,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 13.175000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.719,
      "taskDurationMs": 611.228,
      "heapDeltaBytes": 7102032,
      "heapUsedBytes": 79514008,
      "domNodes": 19,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 193.88099999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666470588235295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3361.1950000000093,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.0950000000000006,
      "layouts": 7,
      "layoutDurationMs": 1.8699999999999997,
      "taskDurationMs": 1001.9520000000002,
      "heapDeltaBytes": 10323496,
      "heapUsedBytes": 83037584,
      "domNodes": 0,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 402.832,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665841584158414,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3390.0619999999435,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.3170000000000004,
      "layouts": 4,
      "layoutDurationMs": 1.2489999999999997,
      "taskDurationMs": 1049.06,
      "heapDeltaBytes": -14947044,
      "heapUsedBytes": 62383520,
      "domNodes": -274,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 397.76800000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.748514851485147,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 706.4610000000471,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.652000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.4799999999999995,
      "taskDurationMs": 477.108,
      "heapDeltaBytes": 23155332,
      "heapUsedBytes": 84578632,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 148.63500000000002,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 741.5429999999787,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.808,
      "layouts": 9,
      "layoutDurationMs": 2.8879999999999995,
      "taskDurationMs": 519.882,
      "heapDeltaBytes": 2612424,
      "heapUsedBytes": 76004204,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 156.15699999999998,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66363636363636,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2033.4809999999948,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.053,
      "layouts": 9,
      "layoutDurationMs": 2.7230000000000003,
      "taskDurationMs": 554.114,
      "heapDeltaBytes": 12274252,
      "heapUsedBytes": 83182840,
      "domNodes": 0,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 9.379999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.2309999999861,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.294,
      "layouts": 9,
      "layoutDurationMs": 2.79,
      "taskDurationMs": 625.141,
      "heapDeltaBytes": 12446760,
      "heapUsedBytes": 83780684,
      "domNodes": 0,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 11.452,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1791.7590000000132,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 17.27,
      "layouts": 9,
      "layoutDurationMs": 2.8880000000000003,
      "taskDurationMs": 999.574,
      "heapDeltaBytes": -9280208,
      "heapUsedBytes": 64207216,
      "domNodes": -200,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 120.09999999999998,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66635514018692,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1765.2199999999993,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 16.875,
      "layouts": 8,
      "layoutDurationMs": 2.376,
      "taskDurationMs": 967.7980000000001,
      "heapDeltaBytes": 13649248,
      "heapUsedBytes": 75735280,
      "domNodes": -200,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 116.60799999999999,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66603773584906,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1737.4299999999607,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 27.377,
      "layouts": 5,
      "layoutDurationMs": 18.997,
      "taskDurationMs": 1526.3709999999996,
      "heapDeltaBytes": 10708744,
      "heapUsedBytes": 89873756,
      "domNodes": -1320,
      "jsHeapTotalBytes": 17301504,
      "scriptDurationMs": 40.689,
      "eventListeners": -262,
      "totalBlockingTimeMs": 219,
      "frameDurationMs": 20.390588235294125,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10466.702999999996,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 34.588,
      "layouts": 8,
      "layoutDurationMs": 2.179,
      "taskDurationMs": 6274.4220000000005,
      "heapDeltaBytes": 461936,
      "heapUsedBytes": 84858352,
      "domNodes": -274,
      "jsHeapTotalBytes": 3764224,
      "scriptDurationMs": 2790.7819999999997,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66592356687898,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9962.117999999919,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 35.957,
      "layouts": 8,
      "layoutDurationMs": 2.4000000000000004,
      "taskDurationMs": 6347.4839999999995,
      "heapDeltaBytes": -1551844,
      "heapUsedBytes": 81214436,
      "domNodes": -274,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 2849.542,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.693959731543625,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 25608.401000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 25225.707,
      "heapDeltaBytes": -7181656,
      "heapUsedBytes": 283185708,
      "domNodes": -3482,
      "jsHeapTotalBytes": 12046336,
      "scriptDurationMs": 363.554,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 45.609252669039144,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 25324.06800000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24758.048000000003,
      "heapDeltaBytes": -35886924,
      "heapUsedBytes": 262130048,
      "domNodes": -3482,
      "jsHeapTotalBytes": 13877248,
      "scriptDurationMs": 361.238,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 45.77884267631104,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 31052.28900000003,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 27.195999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 30832.460000000006,
      "heapDeltaBytes": -29010408,
      "heapUsedBytes": 269505360,
      "domNodes": -3482,
      "jsHeapTotalBytes": 10469376,
      "scriptDurationMs": 983.302,
      "eventListeners": -659,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 58.80996168582376,
      "p95FrameDurationMs": 116.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 30453.480000000014,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 22.349000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 30209.855999999996,
      "heapDeltaBytes": -34250948,
      "heapUsedBytes": 269595228,
      "domNodes": -3482,
      "jsHeapTotalBytes": 13615104,
      "scriptDurationMs": 933.374,
      "eventListeners": -659,
      "totalBlockingTimeMs": 19,
      "frameDurationMs": 60.53439363817098,
      "p95FrameDurationMs": 116.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 9677.551999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.84999999999998,
      "layouts": 20,
      "layoutDurationMs": 30.301999999999996,
      "taskDurationMs": 9613.106,
      "heapDeltaBytes": -48672940,
      "heapUsedBytes": 249403768,
      "domNodes": -3482,
      "jsHeapTotalBytes": 770048,
      "scriptDurationMs": 172.48000000000002,
      "eventListeners": -661,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 57.29526627218936,
      "p95FrameDurationMs": 116.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 9121.52299999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 57.19299999999999,
      "layouts": 20,
      "layoutDurationMs": 24.155999999999995,
      "taskDurationMs": 9011.931,
      "heapDeltaBytes": -31969772,
      "heapUsedBytes": 277644076,
      "domNodes": -3482,
      "jsHeapTotalBytes": 18604032,
      "scriptDurationMs": 163.529,
      "eventListeners": -661,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 51.121348314606735,
      "p95FrameDurationMs": 100.10000000000036
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 13274.413999999979,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13119.250999999998,
      "heapDeltaBytes": 4956752,
      "heapUsedBytes": 280701164,
      "domNodes": 0,
      "jsHeapTotalBytes": 16252928,
      "scriptDurationMs": 188.91599999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 51.68404669260701,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 12749.96400000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12510.124999999998,
      "heapDeltaBytes": 17304,
      "heapUsedBytes": 267683976,
      "domNodes": 0,
      "jsHeapTotalBytes": 19136512,
      "scriptDurationMs": 186.083,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 46.640293040293024,
      "p95FrameDurationMs": 100
    },
    {
      "name": "workflow-execution",
      "durationMs": 171.93599999995968,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 13.696000000000002,
      "layouts": 7,
      "layoutDurationMs": 5.051,
      "taskDurationMs": 136.652,
      "heapDeltaBytes": 5089348,
      "heapUsedBytes": 73217804,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 14.794000000000002,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000027,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "workflow-execution",
      "durationMs": 128.3619999999246,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.168,
      "layouts": 9,
      "layoutDurationMs": 3.8149999999999995,
      "taskDurationMs": 85.821,
      "heapDeltaBytes": 4875500,
      "heapUsedBytes": 72731556,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.9510000000000005,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.657142857142844,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 497.8110000000697,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.713,
      "layouts": 76,
      "layoutDurationMs": 15.568,
      "taskDurationMs": 450.734,
      "heapDeltaBytes": -1524244,
      "heapUsedBytes": 46275272,
      "domNodes": 4,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 207.06,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 527.1449999999049,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.8270000000000001,
      "layouts": 76,
      "layoutDurationMs": 16.095000000000002,
      "taskDurationMs": 496.13400000000007,
      "heapDeltaBytes": -1031480,
      "heapUsedBytes": 46707896,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 236.508,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636353,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 634.1189999999415,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.967,
      "layouts": 76,
      "layoutDurationMs": 16.389999999999997,
      "taskDurationMs": 604.154,
      "heapDeltaBytes": 1953192,
      "heapUsedBytes": 100260492,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 236.743,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663157894736838,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 588.5900000000674,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.049,
      "layouts": 76,
      "layoutDurationMs": 16.17,
      "taskDurationMs": 560.972,
      "heapDeltaBytes": 629496,
      "heapUsedBytes": 105846712,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 218.871,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663888888888906,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage: 🟡 59.3% of lines

Coverage totals
Metric Covered Total Pct
Lines 61892 104394 59.3% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1180
src/workbench/extensions/agent/composables/agent/useAgentSession.ts 12.0% 983
src/workbench/extensions/agent/crdt/liveGraphApplier.ts 2.2% 762
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts 11.8% 667
src/workbench/extensions/agent/AgentPanelRoot.vue 27.1% 632
src/workbench/extensions/agent/crdt/docOpMinter.ts 4.2% 438
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts 25.4% 402
src/LGraphNode.ts 71.4% 377
src/platform/billing/stores/billingOperationStore.ts 9.3% 333
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332

🎭 Playwright: ✅ 3252 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2376 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 839 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 9 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/04/2026, 06:09:35 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Full docs: scripts/registry-census/README.md

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

🌾 Fallow: ✅ Passed

Findings and check details

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Full docs: ADR-DEVEX-LINT-0015

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 1e65d5fb21153ee33c65e46dfdb5b45ccff2fdb9

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (358)

  • billing path matches no source files: src/platform/billing/composables/activateBillingScope.testUtils.ts. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • error-handling path matches no source files: src/utils/errorUtil.ts. Remove or update it in docs/architecture/domains/records/error-handling.domain.json.
  • graph-model path matches no source files: src/types/linkTopology.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • graph-model path matches no source files: src/types/nodeState.ts. Remove or update it in docs/architecture/domains/records/graph-model.domain.json.
  • job-queue path matches no source files: src/platform/remote/comfyui/jobs/**. Remove or update it in docs/architecture/domains/records/job-queue.domain.json.
  • linear-mode path matches no source files: src/utils/appMode.ts. Remove or update it in docs/architecture/domains/records/linear-mode.domain.json.
  • link-connection path matches no source files: src/lib/litegraph/src/infrastructure/LinkConnectorEventMap.ts. Remove or update it in docs/architecture/domains/records/link-connection.domain.json.
  • node-widgets path matches no source files: src/types/widgetState.ts. Remove or update it in docs/architecture/domains/records/node-widgets.domain.json.
  • subgraphs path matches no source files: src/lib/litegraph/src/infrastructure/SubgraphEventMap.ts. Remove or update it in docs/architecture/domains/records/subgraphs.domain.json.
  • vue-node-widgets path matches no source files: src/types/positionConfig.ts. Remove or update it in docs/architecture/domains/records/vue-node-widgets.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • packages/api-client/src/abortSignal.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/abortSignal.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchRouteTemplate.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/fetchWithRetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/retryPolicy.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/api-client/src/statusRetryTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/generated/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/generated/types.gen.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/comfyui-api-types/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/formatUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/geometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/loadExternalScript.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/networkUtil.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/telemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/shared-frontend-utils/src/urlSafety.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • packages/tailwind-utils/src/index.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/TopbarActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipStrip.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatClipTile.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPanel.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/VideoConcatPlaybackBar.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/WidgetVideoConcat.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/videoConcat/__fixtures__/clipTiles.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionActions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useAgentExtensionNotices.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 308 more

Full docs: Frontend domain catalog

Reproduce locally
pnpm architecture:check

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Nov 4, 2026
@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ng/composables/__mocks__/useBillingCapabilities.ts 0.00% 2 Missing ⚠️
@@                      Coverage Diff                       @@
##           ingest-types-sync-6ac8f584   #22914      +/-   ##
==============================================================
- Coverage                       87.55%   87.55%   -0.01%     
==============================================================
  Files                            3037     3037              
  Lines                          162720   162720              
  Branches                        41421    41422       +1     
==============================================================
- Hits                           142466   142464       -2     
- Misses                          19364    19366       +2     
  Partials                          890      890              
Flag Coverage Δ
billing-web-unit 92.19% <ø> (ø)
e2e 59.28% <50.00%> (ø)
unit 86.68% <71.42%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-core/src/core/billing/billingTab/autoTopUpCard.ts 72.72% <100.00%> (ø)
...account/components/dialogs/settings/BillingTab.vue 97.67% <ø> (ø)
...form/billing/composables/useBillingCapabilities.ts 95.83% <100.00%> (-0.68%) ⬇️
...ng/composables/__mocks__/useBillingCapabilities.ts 84.90% <0.00%> (-0.55%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from ingest-types-sync-6ac8f584 to main November 4, 2026 18:39
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The billing capability contracts add separate flags for auto-top-up card and member-notice visibility. The billing composable and tab use these flags to determine visibility. Related types, denial reasons, fixtures, and tests are updated.

Changes: Billing visibility capabilities

Layer / File(s) Summary
Capability contracts and denial reasons
packages/ingest-types/src/types.gen.ts, packages/ingest-types/src/zod.gen.ts, packages/account-core/src/core/billing/capabilityDenials.ts, packages/account-core/src/core/billing/contracts/billingCapabilities.contract.test.ts, apps/billing-web/src/checkout/endingScreen.ts
Billing types and schemas add can_view_auto_top_up, can_view_auto_top_up_member_notice, billing_notice_audience, and ending_notice_starts_at. The denial decoder recognizes workspace_owner, and the ending screen maps it to unknown.
Capability-driven auto-top-up UI
src/platform/billing/composables/useBillingCapabilities.ts, src/platform/account/components/dialogs/settings/BillingTab.vue, packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts, src/platform/account/components/dialogs/settings/BillingTab.test.ts, packages/account-core/src/core/billing/billingTab/autoTopUpCard.test.ts, src/platform/billing/composables/useBillingCapabilities.test.ts, src/platform/billing/composables/useBillingCapabilities.crossUser.test.ts
The composable reads the two visibility capabilities. The billing tab passes the member-notice capability to section derivation, which uses it to select the member block. Tests cover card and notice visibility from the corresponding flags.
Capability fixtures and role scenarios
apps/billing-web/e2e/fixtures/scenario.ts, apps/billing-web/src/test/fakeBillingClient.ts, browser_tests/fixtures/data/billingCapabilities.ts, packages/account-core/src/core/billing/*test.ts, packages/account-ui/src/billing/__fixtures__/billingHarness.ts, src/platform/auth/*test.ts, src/platform/billing/api/__mocks__/billingApi.ts, src/platform/billing/components/billingTab/BillingLocalCreditBanner.capabilities.test.ts, src/platform/billing/composables/__mocks__/useBillingCapabilities.ts, src/platform/billing/sdk/*test.ts, src/platform/billing/telemetry/workspaceTelemetryContext.test.ts
Capability fixtures add false defaults. Workspace browser fixtures set member-notice visibility based on owner status, with caller overrides applied afterward.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant BillingAPI
  participant useBillingCapabilities
  participant BillingTab
  participant deriveAutoTopUpSection
  BillingAPI->>useBillingCapabilities: capability values
  useBillingCapabilities->>BillingTab: canViewAutoTopUpMemberNotice
  BillingTab->>deriveAutoTopUpSection: section facts
  deriveAutoTopUpSection-->>BillingTab: section selection
Loading

Suggested reviewers: drjkl

Merge Risk: Minimal · up to 889dc

Auto top-up visibility now follows server capabilities. Deploy ingest first; older responses make billing capabilities unavailable.

Pre-merge checks: Passed 5 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
End-To-End Test Suggestion For User-Facing Changes Warning The PR changes user-visible Billing-tab behavior in src/ and packages/: members see the auto top-up notice only when can_view_auto_top_up_member_notice is served, and owners use `can_view_auto_t… Extend an existing Billing-tab spec under browser_tests/: - Configure a healthy member workspace with can_view_auto_top_up_member_notice: true. - Open the Billing tab as a workspace member. - Expect the member auto top-up notice to be v…
Passed Passed checks: 5 passed
Check name Status Explanation
Title check Passed The title names the main change: the member auto top-up block is now driven by the served member-notice capability fact. The changeset does that: deriveAutoTopUpSection takes canViewAutoTopUpMemberNot…
Description check Passed The description follows the repository template. It has a Summary that states the problem and behavior change, and it names a known risk (ingest must ship cloud#17972 and cloud#18078 first, or decodin…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes Passed The changed-file list contains no files under src/lib/litegraph/ or src/ecs/, and no files related to graph entities such as nodes, links, widgets, slots, reroutes, groups, or subgraphs. The ADR c…
Full details: Title check

Explanation

The title names the main change: the member auto top-up block is now driven by the served member-notice capability fact. The changeset does that: deriveAutoTopUpSection takes canViewAutoTopUpMemberNotice in place of manageAutoTopUpDenial, and the owner card reads can_view_auto_top_up directly. The title says 'M4 fix(billing)', which uses a milestone tag and a conventional-commit prefix. These are not vague terms, but a teammate scanning history may not know what 'M4' means.

Full details: Description check

Explanation

The description follows the repository template. It has a Summary that states the problem and behavior change, and it names a known risk (ingest must ship cloud#17972 and cloud#18078 first, or decoding fails). It has a Verification section with test commands and results, before/after screenshots, and a red/green commit note. It does not include a 'Fixes #ISSUE_NUMBER' line, which the template marks as optional. It has no 'After release' telemetry entry, which the template also treats as optional. The description references the Slack QA thread and a stacked PR (#22913).

Full details: Adr Compliance For Entity/Litegraph Changes

Explanation

The changed-file list contains no files under src/lib/litegraph/ or src/ecs/, and no files related to graph entities such as nodes, links, widgets, slots, reroutes, groups, or subgraphs. The ADR compliance check is therefore not applicable.

Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

The PR changes user-visible Billing-tab behavior in src/ and packages/: members see the auto top-up notice only when can_view_auto_top_up_member_notice is served, and owners use can_view_auto_top_up. The changed browser_tests/ file is only a fixture; no browser spec exercises this behavior. This is a suggestion, not a merge requirement.

Resolution

Extend an existing Billing-tab spec under browser_tests/: - Configure a healthy member workspace with can_view_auto_top_up_member_notice: true. - Open the Billing tab as a workspace member. - Expect the member auto top-up notice to be visible. - Configure the member notice capability as false. - Expect the member auto top-up notice to be hidden. - Configure can_view_auto_top_up: true for a workspace owner. - Expect the owner auto top-up card to be visible.

Finishing Touches
Generate docstrings
  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 22cf9f9 and 889dc24.

Files selected for processing: 29
  • apps/billing-web/e2e/fixtures/scenario.ts
  • apps/billing-web/src/checkout/endingScreen.ts
  • apps/billing-web/src/test/fakeBillingClient.ts
  • browser_tests/fixtures/data/billingCapabilities.ts
  • packages/account-core/src/core/billing/billingTab/autoTopUpCard.test.ts
  • packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts
  • packages/account-core/src/core/billing/capabilities.test.ts
  • packages/account-core/src/core/billing/capabilitiesCrossUser.test.ts
  • packages/account-core/src/core/billing/capabilityDenials.ts
  • packages/account-core/src/core/billing/contracts/billingCapabilities.contract.test.ts
  • packages/account-core/src/core/billing/scopedReader.test.ts
  • packages/account-core/src/core/billing/topup.test.ts
  • packages/account-ui/src/billing/__fixtures__/billingHarness.ts
  • packages/ingest-types/src/types.gen.ts
  • packages/ingest-types/src/zod.gen.ts
  • src/platform/account/components/dialogs/settings/BillingTab.test.ts
  • src/platform/account/components/dialogs/settings/BillingTab.vue
  • src/platform/auth/webSessionFlagOff.test.ts
  • src/platform/auth/webSessionFlagOn.test.ts
  • src/platform/billing/api/__mocks__/billingApi.ts
  • src/platform/billing/components/billingTab/BillingLocalCreditBanner.capabilities.test.ts
  • src/platform/billing/composables/__mocks__/useBillingCapabilities.ts
  • src/platform/billing/composables/useBillingCapabilities.crossUser.test.ts
  • src/platform/billing/composables/useBillingCapabilities.test.ts
  • src/platform/billing/composables/useBillingCapabilities.ts
  • src/platform/billing/sdk/billingCapabilitiesView.test.ts
  • src/platform/billing/sdk/billingSdkTelemetryOwnership.test.ts
  • src/platform/billing/sdk/createBillingSdk.test.ts
  • src/platform/billing/telemetry/workspaceTelemetryContext.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at full head 889dc24a1f9aaa15da73ec4b8677004e96f78cb5. Diff matches the PR body exactly: deriveAutoTopUpSection now takes the served can_view_auto_top_up_member_notice fact directly in place of deriving the member block from denied_reasons.can_manage_auto_top_up === 'not_workspace_owner', which could not distinguish a paused workspace from a healthy one. useBillingCapabilities and BillingTab.vue wiring, and every fixture/mock/test file touching the capabilities shape, are updated consistently with the two new required booleans (can_view_auto_top_up, can_view_auto_top_up_member_notice) and the new workspace_owner denial reason. Matches the already-approved FRONT-3796/ADR-0042 sibling pattern (#22886-22889, #22903/#22904/#22907/#22913). Thread-free, 95 pass / 30 skip / 0 fail.

The disclosed risk (both booleans required in generated zod; a prod ingest without cloud#17972/#18078 fails SDK decode and falls back to hiding the card/block) is a backend-sequencing note, not a defect in this diff.

@dante01yoon
dante01yoon added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 476fd00 Nov 4, 2026
152 of 154 checks passed
@dante01yoon
dante01yoon deleted the e1-member-notice-served-fact branch November 4, 2026 19:42
@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to core/1.60 failed

Reason: Merge conflicts detected during cherry-pick of 476fd00

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-22914-to-core-1.60 (from origin/core/1.60) and
open a PR to core/1.60.

📄 Conflicting files
packages/account-core/src/core/billing/billingTab/autoTopUpCard.test.ts
packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts
src/platform/account/components/dialogs/settings/BillingTab.test.ts
src/platform/account/components/dialogs/settings/BillingTab.vue
src/platform/billing/composables/__mocks__/useBillingCapabilities.ts
src/platform/billing/composables/useBillingCapabilities.test.ts
src/platform/billing/composables/useBillingCapabilities.ts
🤖 Prompt for AI Agents
Backport PR #22914 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/22914) to core/1.60.
Cherry-pick merge commit 476fd00466f927e2e96352bd3d344d2098124296 onto new branch
backport-22914-to-core-1.60 from origin/core/1.60.
Resolve conflicts in: packages/account-core/src/core/billing/billingTab/autoTopUpCard.test.ts packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts src/platform/account/components/dialogs/settings/BillingTab.test.ts src/platform/account/components/dialogs/settings/BillingTab.vue src/platform/billing/composables/__mocks__/useBillingCapabilities.ts src/platform/billing/composables/useBillingCapabilities.test.ts src/platform/billing/composables/useBillingCapabilities.ts .



For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.60] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @dante01yoon

@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to cloud/1.60 failed

Reason: Merge conflicts detected during cherry-pick of 476fd00

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-22914-to-cloud-1.60 (from origin/cloud/1.60) and
open a PR to cloud/1.60.

📄 Conflicting files
packages/account-core/src/core/billing/billingTab/autoTopUpCard.test.ts
packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts
src/platform/account/components/dialogs/settings/BillingTab.test.ts
src/platform/account/components/dialogs/settings/BillingTab.vue
src/platform/billing/composables/__mocks__/useBillingCapabilities.ts
src/platform/billing/composables/useBillingCapabilities.test.ts
src/platform/billing/composables/useBillingCapabilities.ts
🤖 Prompt for AI Agents
Backport PR #22914 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/22914) to cloud/1.60.
Cherry-pick merge commit 476fd00466f927e2e96352bd3d344d2098124296 onto new branch
backport-22914-to-cloud-1.60 from origin/cloud/1.60.
Resolve conflicts in: packages/account-core/src/core/billing/billingTab/autoTopUpCard.test.ts packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts src/platform/account/components/dialogs/settings/BillingTab.test.ts src/platform/account/components/dialogs/settings/BillingTab.vue src/platform/billing/composables/__mocks__/useBillingCapabilities.ts src/platform/billing/composables/useBillingCapabilities.test.ts src/platform/billing/composables/useBillingCapabilities.ts .



For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.60] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @dante01yoon

dante01yoon added a commit that referenced this pull request Nov 4, 2026
…e owner card and member block (#22913, #22914) (#22922)

## Summary

Manual backport of
#22913 (ingest-types
sync to cloud@6ac8f584 plus fixture fixes) and
#22914 (E1) to
`core/1.60`. Both auto-backports failed with conflicts.

The Billing tab now shows the member auto top-up block only when the
server sends `can_view_auto_top_up_member_notice: true`, so a Member on
a paused Team no longer sees it. The owner auto top-up card now uses the
served `can_view_auto_top_up`. The old `can_manage_auto_top_up &&
can_top_up` gate and the `not_workspace_owner` denial check are both
gone.

Commits:
1. #22913, cherry-picked with #22871's fixture changes added in the same
commit (both `-x` lines are kept).
2. #22914, cherry-picked with `-x`.

## Conflicts and resolution

- **`packages/ingest-types/src/*.gen.ts`**: these were not hand-merged.
I regenerated them on this branch from cloud@6ac8f584 with the bot's
projection (`openapi-project -fe`), then ran `pnpm generate` and oxfmt.
The exported names in `index.ts` match main's #22913 output exactly. The
regen also brings in spec drift that has built up since the last 1.60
sync, all of it additive: `credit_validity`, cloud compatibility, agent
usage-status, OAuth `verified_client` and 429 error types. There is one
narrowing: `billing_rail` becomes `'stripe'` only. That narrowing broke
three e2e fixtures and a contract test on 1.60. Main fixed exactly this
in #22871 with test
and fixture changes only, so I carried those changes into commit 1. The
pre-commit typecheck rejects any split where the types and the fixtures
land in separate commits.
- **#22914 core module**:
`packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts` and
its test don't exist on 1.60, so I dropped them. On 1.60 the gate lives
in `BillingTab.vue` instead:
  - owner card: `autoTopUpEnabled && canViewAutoTopUpCard`
  - member block: `v-else-if canViewAutoTopUpMemberNotice`
  
`BillingAutoTopUpMemberCard.vue` drops its own `not_workspace_owner`
check and now matches main's version.
- **`useBillingCapabilities`, its mock and its test, and
`BillingTab.test.ts`**: I took main's side. That means
`canViewAutoTopUpCard` and `canViewAutoTopUpMemberNotice` come from
`receiveServerFact`, `manageAutoTopUpDenial` is removed, and the
scenarios are rewritten with scenario-correct values for the two
booleans. No casts, nothing loosened.

Risk, same as main: both booleans are required in the generated zod, and
`billing_rail` is now `z.enum(['stripe'])`. Ingest has to serve
cloud#17972, cloud#18078 and the stripe-only rail.

## Verification

- `pnpm typecheck`, `typecheck:browser`, `typecheck:workspaces`, `pnpm
knip`: clean.
- `vitest run src/platform/billing src/platform/account
src/platform/auth/webSessionFlag{Off,On}.test.ts`: 4422/4422.
- `packages/account-core`: 1828/1828. `packages/account-ui src/billing`:
192/192. `apps/billing-web src`: 1578/1578.

For QA, E1: a Member on a paused Team sees no auto top-up block; on an
active Team it shows.
dante01yoon added a commit that referenced this pull request Nov 4, 2026
…he owner card and member block (#22913, #22914) (#22923)

## Summary

Manual backport of
#22913 (ingest-types
sync to cloud@6ac8f584 plus fixture fixes) and
#22914 (E1) to
`cloud/1.60`. Both auto-backports failed with conflicts.

The Billing tab now shows the member auto top-up block only when the
server sends `can_view_auto_top_up_member_notice: true`, so a Member on
a paused Team no longer sees it. The owner auto top-up card now uses the
served `can_view_auto_top_up`. The old `can_manage_auto_top_up &&
can_top_up` gate and the `not_workspace_owner` denial check are both
gone.

Commits:
1. #22913, cherry-picked with #22871's fixture changes added in the same
commit (both `-x` lines are kept).
2. #22914, cherry-picked with `-x`.

## Conflicts and resolution

- **`packages/ingest-types/src/*.gen.ts`**: these were not hand-merged.
I regenerated them on this branch from cloud@6ac8f584 with the bot's
projection (`openapi-project -fe`), then ran `pnpm generate` and oxfmt.
The exported names in `index.ts` match main's #22913 output exactly. The
regen also brings in spec drift that has built up since the last 1.60
sync, all of it additive: `credit_validity`, cloud compatibility, agent
usage-status, OAuth `verified_client` and 429 error types. There is one
narrowing: `billing_rail` becomes `'stripe'` only. That narrowing broke
three e2e fixtures and a contract test on 1.60. Main fixed exactly this
in #22871 with test
and fixture changes only, so I carried those changes into commit 1. The
pre-commit typecheck rejects any split where the types and the fixtures
land in separate commits.
- **#22914 core module**:
`packages/account-core/src/core/billing/billingTab/autoTopUpCard.ts` and
its test don't exist on 1.60, so I dropped them. On 1.60 the gate lives
in `BillingTab.vue` instead:
  - owner card: `autoTopUpEnabled && canViewAutoTopUpCard`
  - member block: `v-else-if canViewAutoTopUpMemberNotice`
  
`BillingAutoTopUpMemberCard.vue` drops its own `not_workspace_owner`
check and now matches main's version.
- **`useBillingCapabilities`, its mock and its test, and
`BillingTab.test.ts`**: I took main's side. That means
`canViewAutoTopUpCard` and `canViewAutoTopUpMemberNotice` come from
`receiveServerFact`, `manageAutoTopUpDenial` is removed, and the
scenarios are rewritten with scenario-correct values for the two
booleans. No casts, nothing loosened.

Risk, same as main: both booleans are required in the generated zod, and
`billing_rail` is now `z.enum(['stripe'])`. Ingest has to serve
cloud#17972, cloud#18078 and the stripe-only rail.

## Verification

- `pnpm typecheck`, `typecheck:browser`, `typecheck:workspaces`, `pnpm
knip`: clean.
- `vitest run src/platform/billing src/platform/account
src/platform/auth/webSessionFlag{Off,On}.test.ts`: 4422/4422.
- `packages/account-core`: 1828/1828. `packages/account-ui src/billing`:
192/192. `apps/billing-web src`: 1578/1578.

For QA, E1: a Member on a paused Team sees no auto top-up block; on an
active Team it shows.
@christian-byrne christian-byrne removed the needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch label Nov 5, 2026
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Nov 5, 2026
…d Enterprise ending notice start (Comfy-Org#22931)

## Why

ADR-0042 says billing banners render server facts and do not derive
them. The billing banner and the subscription panel still worked out two
things on the client, behind `pendingServerFact('BE-25244', …)`:

- the notice audience, from the plan tier (`ENTERPRISE`, the personal
tiers) and `isTeamPlan`;
- the Enterprise 14-day ending window, from `cancel_at`.

BE-25244 now serves both facts: `billing_notice_audience` and
`ending_notice_starts_at` (cloud#17977, cloud#18073). They are live on
staging and production in v0.535.1 (cloud#18140).

## Root cause

When Comfy-Org#22889 and Comfy-Org#22903 landed, the served fields did not exist yet, so
the client computed them and marked that computation as pending.

## How

- `useBillingCapabilities` exposes `billing_notice_audience` and
`ending_notice_starts_at` as received.
- `useBillingBanner` takes the audience from the server. `none` and
absent both mean no audience. The server documents absent as unknown
(`subscription_state_authoritative` false), so the banner fails closed.
When `ending_notice_starts_at` is served, the Enterprise path is used:
no banner before that time, `ending` at or after it. `PERSONAL_TIERS`,
`classifyTier` and the `isTeamPlan` input are removed.
- `SubscriptionPanelContentWorkspace` keeps its quiet Enterprise
treatment until the served start time passes.
`isWithinEnterpriseEndingNotice` is replaced by
`hasEndingNoticeStarted(startsAt, now)`.
- Still pending: the panel's `isEnterprisePlan` (`tier ===
'ENTERPRISE'`) stays wrapped in `pendingServerFact('BE-25244', …)`. The
API serves no "is Enterprise" fact, and `billing_notice_audience: none`
also covers Free and unknown tiers.
- There is no client fallback when a field is absent. Every deployed
billing-api serves both fields, and a tier-based fallback would bring
back the derivation this PR removes.
- Tests: unit fixtures play billing-api through one shared helper,
`__mocks__/servedBillingNotices.ts`, which the Storybook mock also uses.
The cloud e2e `enterpriseTierCloud.spec.ts` now serves
`ending_notice_starts_at` for the ending-soon Enterprise case.

BE-25243 (the auto top-up card) was already switched to its served fact
in Comfy-Org#22913 and Comfy-Org#22914.

## AS-IS/TO-BE

| AS IS | TO BE |
| --- | --- |
| _pending: testcloud screenshot_ | _pending: testcloud screenshot_ |

Visible behaviour should be unchanged. Still to be checked on testcloud.

- Part of FRONT-3796
trsommer pushed a commit to trsommer/ComfyUI_frontend that referenced this pull request Nov 6, 2026
…d token is out of quota (Comfy-Org#22953)

## Summary

When the shared bot token runs out of REST quota, the backport workflow
still posts every conflict notice, but its duplicate check stops
working. A later labeled event or re-run then posts the same notice
again. This keeps the duplicate check working in that case.

## Why

`Comment on failures` posts with `gh pr comment`, which goes through
GraphQL and has its own quota, so notices still go out. The duplicate
check (`gh api user`, then reading the PR's comments and the bot's open
issues) uses REST. When REST quota is spent, `POSTING_LOGIN` comes back
empty and `conflict_already_reported` returns false, so every conflict
counts as new.

Seen on 2026-11-01:
Comfy-Org#21857 got four of its
conflict notices twice. The second run (41277223517) hit `API rate limit
exceeded` in this check. The quota ran out again on 2026-11-04 (runs
41889332183 and 41899537945). No notice was lost on either day: I
checked Comfy-Org#21857, Comfy-Org#22452, Comfy-Org#22563, Comfy-Org#22571, Comfy-Org#22913 and Comfy-Org#22914.

## Changes

- `POSTING_LOGIN` falls back to GraphQL `viewer { login }` when `gh api
user` fails.
- The comment and issue reads try the job token (`JOB_TOKEN: ${{
github.token }}`, own quota; the job already grants `issues: write` and
`pull-requests: write`) and then the shared token. Comfy-Org#22645 does the same
for the label cleanup.
- Each attempt assigns on its own, so a failed call's error body never
ends up in the login or the JSON that gets read.
- The step is never worse than before. If both reads fail, it posts, as
it did before.

## Tests

Test-first in `scripts/cicd/backport-conflict-comment.test.ts`:
- The fake `gh` now fails REST calls made with a spent token the way
GitHub does: error body on stdout, message on stderr. GraphQL calls
still succeed.
- New case: the second run happens while the shared token's REST quota
is spent. It expects one report. Before this change it got 2 (red);
after, 1 (green).
- More cases: job token spent (1 report) and both tokens spent (2
reports, as before this PR).
- New check: the step pins `JOB_TOKEN` to `github.token`.
- `backport-conflict-comment`, `backport-token-scopes` and
`backport-missing-trigger`: 54/54 pass. `actionlint` reports no new
findings for `pr-backport.yaml`.

Follow-up to FRONT-3753 (https://linear.app/comfyorg/issue/FRONT-3753).

---------

Co-authored-by: GitHub Action <action@github.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Nov 12, 2026
…led (Comfy-Org#23276)

## Why

`billing_new_ux_enabled` (Comfy-Org#23248) rolls 1.61 billing back to 1.60
behavior when it is off, but the Billing settings tab was not covered.
Comfy-Org#22746 moved the tab's rules (plan row, credits card, auto top-up card,
plan lifecycle, the tab's banners) into the SDK packages and deleted the
app-side 1.60 implementation. So 1.61 renders the Billing tab through
the SDK for everyone, and a regression there has no switch to turn it
off. The 1.61 release review lists the Team-workspace Billing tab (owner
and member) as a post-deploy check for exactly this reason.

## How

- One branch point: the settings panel now renders
`BillingTabLegacy.vue` while `billing_new_ux_enabled` is off and the
current `BillingTab.vue` when it is on. The choice is read at render
time, so a flag that resolves after the dialog opens still swaps the
tab.
- `BillingTabLegacy.vue` is the `core/1.60` tab. Everything it reaches
that main deleted, or that main moved onto SDK rules, is restored
verbatim from `core/1.60` under `src/platform/billing/legacy160/` (34
files), with its 1.60 tests (22 files, 580 cases). Shared infrastructure
that did not change rules (capabilities reader, SDK store, dialogs) is
main's, and the restored tree typechecks against it unchanged.
- Restored with a script (copy from `core/1.60`, rewrite imports between
restored files), so the tree is reproducible rather than hand-edited.
Two hand edits: the two `tier === 'ENTERPRISE'` checks are wrapped in
the existing `pendingServerFact('BE-25244', ...)` bridge (ADR-0042
lint), the same bridge Comfy-Org#23248 uses for the flag-off notices; and the
legacy root carries `data-billing-release="1.60"` so a browser test can
tell the tabs apart (their markup is otherwise identical by design).
- The current `BillingTab.vue` loses its own flag-off branch (member
auto top-up view) and that branch's test, since the tab now only renders
with the flag on.
- `legacy160/` and `BillingTabLegacy.*` are excluded from the fallow
audit: it is 1.60 code kept as-is and deleted with the flag, not new
code to refactor.

The other 1.61 SDK-rule screens get the same flag-off path, so turning
the flag off leaves no 1.61 billing SDK rules on screen:

- The previous profile popover (`CurrentUserPopoverWorkspace.vue`,
rendered only with the flag off) is its `core/1.60` content again.
- `CreditsPanel` and the Plan & Credits panel render the `core/1.60`
credits tile with the flag off.
- The settings status banner, and the Plan & Credits panel's banner
kind, come from the `core/1.60` banner rules with the flag off.
- The previous Add credits dialog
(`TopUpCreditsDialogContentWorkspace.vue`) and its auto top-up card
(`TopUpAutoTopUpCard.vue`), both rendered only with the flag off, are
their `core/1.60` content again: the served top-up bounds go through the
1.60 local helper instead of the SDK's `servedTopUpBound`, and the card
reads auto top-up through the 1.60 composable, so the Billing tab and
the dialog share one auto top-up read again.

This only changes what main (1.61) renders with the flag off;
`core/1.60` is untouched.

Bug fixes stay outside the flag. Every 1.61 `fix(...)` commit touching a
restored file was checked against `core/1.60`: Comfy-Org#22372, Comfy-Org#22392, Comfy-Org#22717,
Comfy-Org#22888, Comfy-Org#22914, Comfy-Org#22921 and Comfy-Org#23060 were backported, so the restored
copies already contain them. Comfy-Org#22887, Comfy-Org#22889 and Comfy-Org#22979 only restructure
code or add server-fact markers, with no user-visible change. Comfy-Org#22931
(served notice audience) was already put behind this flag by Comfy-Org#23248. The
plan-change confirmation fix Comfy-Org#23048 lives in the SDK
`CheckoutTransitionConfirm`, which this PR does not gate.

Delete `BillingTabLegacy.*`, `legacy160/` and the fallow entry together
when the flag is removed.

## AS IS / TO BE

AS IS: flag off, the Billing tab renders through the SDK rules.
TO BE: flag off, the 1.60 Billing tab; flag on, the current tab.

AS IS for flag off is the same picture as flag on: before this PR the
flag did not affect the Billing tab.

| Flag off (TO BE): 1.60 Billing tab | Flag on: current Billing tab |
| --- | --- |
| <img
src="https://gist.githubusercontent.com/dante01yoon/4dab1584fdedaaaa6722859310c69446/raw/469248fb30804f421c863e6cd3ac97d9e855db62/pr23276-billing-flag-off.png"
width="480"> | <img
src="https://gist.githubusercontent.com/dante01yoon/4dab1584fdedaaaa6722859310c69446/raw/469248fb30804f421c863e6cd3ac97d9e855db62/pr23276-billing-flag-on.png"
width="480"> |

## Verification

- `useSettingUI.test.ts`: renders the 1.60 tab with the flag off, then
the current tab after the flag turns on in the same render. Goes red
when the switch is forced to the current tab.
- Browser (`@cloud`, `Billing rollout`): opens the Billing tab with
`/api/features` serving the flag off and on and asserts which tab
rendered. Ran locally, 4/4 pass; the 1.60 case goes red when the switch
is forced to the current tab.
- 580 restored 1.60 tests; billing, settings and account settings suites
(4,398 tests); app and browser typecheck; knip; dependency-cruiser;
server-facts lint.

## Dependencies

```
Comfy-Org#23248 (merged, billing_new_ux_enabled rollout)
  └── this PR (Billing tab under the same flag)
cloud#18886 (serves billing_new_ux_enabled on /api/features)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.60 Backport PRs for cloud 1.60 core/1.60 Backport PRs for core 1.60 risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants