Repository navigation
[backport cloud/1.60] M4 fix(billing): served auto top-up facts for the owner card and member block (#22913, #22914) - #22923
Conversation
…tice fact) (#22913) Regenerated packages/ingest-types on this branch from the cloud spec at cloud@6ac8f584 with the bot's FE projection, then pnpm generate and oxfmt. The regen also narrows billing_rail to 'stripe', so this carries the test and e2e fixture updates from #22871 that main made for that narrowing. (cherry picked from commit 37d48a4) (cherry picked from commit 22cf9f9)
…mber notice fact (#22914) The Billing tab shows the member auto top-up block ("Contact a workspace owner to manage this.") only when the server serves `can_view_auto_top_up_member_notice: true`, so a member on a paused Team workspace no longer sees it. The owner card now renders the served `can_view_auto_top_up` instead of the BE-25243 interim combination. Stacked on #22913 (ingest-types sync). QA case E1 on 1.60: a Member on a paused Team workspace still sees the member block; the design hides it while paused. https://comfy-organization.slack.com/archives/C0932CGKT5K/p1793803745327049 `deriveAutoTopUpSection` showed the member block for any `denied_reasons.can_manage_auto_top_up === 'not_workspace_owner'`. That denial only says the actor is not an owner; it says nothing about the workspace being paused or past due, so a paused member qualified. The backend now serves that answer directly (cloud#18078). - `useBillingCapabilities` exposes `canViewAutoTopUpMemberNotice` as `receiveServerFact('can_view_auto_top_up_member_notice', ...)`. - `canViewAutoTopUpCard` reads `receiveServerFact('can_view_auto_top_up', ...)` (cloud#17972). The `pendingServerFact('BE-25243', canManageAutoTopUp && canTopUp)` wrapper is deleted, as `pendingServerFact` requires once the field ships. - `deriveAutoTopUpSection` takes `canViewAutoTopUpMemberNotice` in place of `manageAutoTopUpDenial` and shows `memberBlock` when it is true, still inside `auto_top_up_enabled` and after the card check. - `manageAutoTopUpDenial` had no other reader and is removed from the composable and its mock. Commits: the test commit (`test(billing): ...`) goes red on the member block, the core table and the served card fact; it carries the type surface the tests compile against (the new fact on the composable, its mock, and `AutoTopUpSectionFacts`), because the pre-commit typecheck rejects a test against an API that does not exist yet. The fix commit changes no tests. - `pnpm exec vitest run src/platform/billing src/platform/account`: 4061/4061. - account-core `src/core/billing/billingTab`: 137/137. - Red commit alone: BillingTab member block, the core "member on a healthy workspace" row and the three served `can_view_auto_top_up` composable cases fail; the fix commit turns them green. - `pnpm typecheck`, `typecheck:account-core`, knip: clean. | | AS IS | TO BE | | --- | --- | --- | | Member, paused Team workspace | <img alt="AS IS: Member, paused Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-as-is-paused-member.png" width="480"> | <img alt="TO BE: Member, paused Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-to-be-paused-member.png" width="480"> | | Member, healthy Team workspace | <img alt="AS IS: Member, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-as-is-healthy-member.png" width="480"> | <img alt="TO BE: Member, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-to-be-healthy-member.png" width="480"> | | Owner, healthy Team workspace | <img alt="AS IS: Owner, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-as-is-healthy-owner.png" width="480"> | <img alt="TO BE: Owner, healthy Team workspace" src="https://gist.githubusercontent.com/dante01yoon/c914fc8fd60fb6db3dc2a5b24ca0a441/raw/18f42041227d6bfaeb283d1746bb36dc23e0ed5a/pr22914-to-be-healthy-owner.png" width="480"> | Both capability booleans are required in the generated zod. Without them from prod ingest, the SDK capabilities read fails to decode; the legacy read falls back to `false` and hides the card and the member block. Ingest must ship cloud#17972 and cloud#18078 before this. (cherry picked from commit 476fd00)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-04T20:17:27.925Z",
"gitSha": "ce994333b4fb9983ea1fa79083cd4cc3dc02105d",
"branch": "backport-22913-22914-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.9259999999604,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.162,
"layouts": 9,
"layoutDurationMs": 2.333,
"taskDurationMs": 570.685,
"heapDeltaBytes": -7846792,
"heapUsedBytes": 65585492,
"domNodes": -178,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 8.043999999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2012.817000000041,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.456,
"layouts": 8,
"layoutDurationMs": 2.338,
"taskDurationMs": 593.891,
"heapDeltaBytes": 4621016,
"heapUsedBytes": 64962272,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 10.822000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1785.7050000000072,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.993,
"layouts": 8,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 919.3549999999999,
"heapDeltaBytes": 10132232,
"heapUsedBytes": 70428144,
"domNodes": -178,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 157.522,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.3720000000903,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.613000000000001,
"layouts": 9,
"layoutDurationMs": 2.2920000000000007,
"taskDurationMs": 902.4409999999999,
"heapDeltaBytes": 7839720,
"heapUsedBytes": 80951640,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 165.828,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.7149999999597,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.83,
"layouts": 10,
"layoutDurationMs": 2.505,
"taskDurationMs": 405.14900000000006,
"heapDeltaBytes": 25381320,
"heapUsedBytes": 85963188,
"domNodes": 57,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 10.116,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2000000000198,
"styleRecalcs": 20,
"styleRecalcDurationMs": 4.923,
"layouts": 12,
"layoutDurationMs": 3.0330000000000004,
"taskDurationMs": 441.639,
"heapDeltaBytes": 11132580,
"heapUsedBytes": 85513864,
"domNodes": 57,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 12.125,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.3859999999795,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.581,
"layouts": 9,
"layoutDurationMs": 2.263,
"taskDurationMs": 486.991,
"heapDeltaBytes": 2811224,
"heapUsedBytes": 62306836,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 169.05200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 811.3019999999551,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.816,
"layouts": 9,
"layoutDurationMs": 2.665000000000001,
"taskDurationMs": 575.0509999999999,
"heapDeltaBytes": 9757564,
"heapUsedBytes": 77861188,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 191.332,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.7159999999742,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 853.2450000000001,
"heapDeltaBytes": 19738016,
"heapUsedBytes": 83741248,
"domNodes": 0,
"jsHeapTotalBytes": 10911744,
"scriptDurationMs": 71.743,
"eventListeners": 0,
"totalBlockingTimeMs": 520,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.7200000000375,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 917.7829999999999,
"heapDeltaBytes": -6350616,
"heapUsedBytes": 77709728,
"domNodes": -208,
"jsHeapTotalBytes": 18358272,
"scriptDurationMs": 68.91000000000001,
"eventListeners": -107,
"totalBlockingTimeMs": 527,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.8720000000235,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.8349999999998,
"heapDeltaBytes": -5451920,
"heapUsedBytes": 70636876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.71,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.8409999999367,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.0099999999996,
"heapDeltaBytes": -3214888,
"heapUsedBytes": 72858584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.673,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11186.400999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10230.119999999999,
"heapDeltaBytes": 83233292,
"heapUsedBytes": 159559772,
"domNodes": -274,
"jsHeapTotalBytes": 68808704,
"scriptDurationMs": 8196.308,
"eventListeners": -69,
"totalBlockingTimeMs": 1079,
"frameDurationMs": 31.950857142857146,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11119.748000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10305.216999999999,
"heapDeltaBytes": 83378000,
"heapUsedBytes": 163883240,
"domNodes": -274,
"jsHeapTotalBytes": 82178048,
"scriptDurationMs": 8226.709,
"eventListeners": -69,
"totalBlockingTimeMs": 1104,
"frameDurationMs": 31.17865168539326,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9998.772000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9210.402,
"heapDeltaBytes": 60480992,
"heapUsedBytes": 135146084,
"domNodes": -274,
"jsHeapTotalBytes": 66449408,
"scriptDurationMs": 7313.407000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 727,
"frameDurationMs": 31.151401869158878,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10866.390000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10081.741,
"heapDeltaBytes": 48523864,
"heapUsedBytes": 130477120,
"domNodes": -274,
"jsHeapTotalBytes": 64614400,
"scriptDurationMs": 8093.827000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 1165,
"frameDurationMs": 31.6798833819242,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 213.51300000000606,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.092999999999998,
"layouts": 7,
"layoutDurationMs": 2.3930000000000002,
"taskDurationMs": 156.77599999999998,
"heapDeltaBytes": 14969072,
"heapUsedBytes": 74789628,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.356,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 280.3369999999745,
"styleRecalcs": 22,
"styleRecalcDurationMs": 18.415,
"layouts": 7,
"layoutDurationMs": 2.6449999999999996,
"taskDurationMs": 215.57699999999997,
"heapDeltaBytes": 14904956,
"heapUsedBytes": 76120292,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.491999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 14,
"frameDurationMs": 23.60833333333331,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2040.9859999999753,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1990000000000003,
"layouts": 9,
"layoutDurationMs": 2.6339999999999995,
"taskDurationMs": 660.283,
"heapDeltaBytes": 6613444,
"heapUsedBytes": 81484416,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 32.767,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.197999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.651,
"layouts": 9,
"layoutDurationMs": 2.572,
"taskDurationMs": 666.2410000000001,
"heapDeltaBytes": -19415468,
"heapUsedBytes": 62318060,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.191999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2548.2410000000186,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.437000000000001,
"layouts": 6,
"layoutDurationMs": 1.4559999999999997,
"taskDurationMs": 1709.8970000000002,
"heapDeltaBytes": 7839140,
"heapUsedBytes": 82845276,
"domNodes": -274,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 815.998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775000000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2578.3099999999877,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.453999999999999,
"layouts": 8,
"layoutDurationMs": 1.944,
"taskDurationMs": 1743.3819999999998,
"heapDeltaBytes": 27564,
"heapUsedBytes": 82058988,
"domNodes": -274,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 821.4140000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774025974025975,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3963.423999999975,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.384,
"layouts": 64,
"layoutDurationMs": 10.398000000000001,
"taskDurationMs": 1896.1139999999998,
"heapDeltaBytes": -14965936,
"heapUsedBytes": 62227732,
"domNodes": -250,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 827.1370000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665966386554622,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3997.066000000018,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.655999999999999,
"layouts": 65,
"layoutDurationMs": 10.725,
"taskDurationMs": 1871.6420000000003,
"heapDeltaBytes": -22479188,
"heapUsedBytes": 61925260,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 802.718,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3102.0169999999894,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.021999999999999,
"layouts": 7,
"layoutDurationMs": 1.8059999999999994,
"taskDurationMs": 2009.6440000000002,
"heapDeltaBytes": -4741432,
"heapUsedBytes": 82853112,
"domNodes": 0,
"jsHeapTotalBytes": 7827456,
"scriptDurationMs": 1009.2319999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.02648648648649,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3092.35799999999,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.920000000000001,
"layouts": 5,
"layoutDurationMs": 1.415,
"taskDurationMs": 1987.962,
"heapDeltaBytes": -7188640,
"heapUsedBytes": 75804352,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 970.764,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846739130434784,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3042.016000000018,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.967,
"layouts": 8,
"layoutDurationMs": 1.7750000000000001,
"taskDurationMs": 685.276,
"heapDeltaBytes": -8803212,
"heapUsedBytes": 75577116,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 352.76599999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3074.183000000005,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.5970000000000004,
"layouts": 6,
"layoutDurationMs": 1.4480000000000002,
"taskDurationMs": 823.4339999999999,
"heapDeltaBytes": -16575104,
"heapUsedBytes": 60426552,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 377.697,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.6889999999817,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9249999999999996,
"layouts": 7,
"layoutDurationMs": 1.836,
"taskDurationMs": 649.8609999999999,
"heapDeltaBytes": -16615656,
"heapUsedBytes": 68608984,
"domNodes": -274,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 28.614999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.4160000000693,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4499999999999997,
"layouts": 7,
"layoutDurationMs": 2.163,
"taskDurationMs": 786.721,
"heapDeltaBytes": 7553064,
"heapUsedBytes": 82697812,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.807,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2762.52199999999,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.268,
"layouts": 6,
"layoutDurationMs": 1.6110000000000004,
"taskDurationMs": 595.9219999999999,
"heapDeltaBytes": -4610500,
"heapUsedBytes": 80018708,
"domNodes": -256,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 189.77499999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240967,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2788.6760000000095,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.502,
"layouts": 7,
"layoutDurationMs": 1.6700000000000002,
"taskDurationMs": 624.834,
"heapDeltaBytes": -15756604,
"heapUsedBytes": 64982372,
"domNodes": -273,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 189.075,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76626506024096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3268.5170000000026,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.503,
"layouts": 6,
"layoutDurationMs": 1.2889999999999997,
"taskDurationMs": 992.0640000000001,
"heapDeltaBytes": -13350112,
"heapUsedBytes": 70515148,
"domNodes": -274,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 402.69100000000003,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3372.963999999911,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9389999999999998,
"layouts": 7,
"layoutDurationMs": 1.6609999999999998,
"taskDurationMs": 1009.4380000000001,
"heapDeltaBytes": 3698128,
"heapUsedBytes": 87556312,
"domNodes": -274,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 407.735,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665841584158414,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.6720000000082,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.125,
"layouts": 9,
"layoutDurationMs": 2.5770000000000004,
"taskDurationMs": 447.821,
"heapDeltaBytes": 10676744,
"heapUsedBytes": 85838048,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 146.575,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.6410000000542,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.789999999999999,
"layouts": 8,
"layoutDurationMs": 2.0140000000000002,
"taskDurationMs": 460.214,
"heapDeltaBytes": 10313712,
"heapUsedBytes": 85301188,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 147.46599999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2038.4540000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3549999999999995,
"layouts": 10,
"layoutDurationMs": 2.6569999999999996,
"taskDurationMs": 576.173,
"heapDeltaBytes": -5045132,
"heapUsedBytes": 65377776,
"domNodes": -200,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 7.401000000000002,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.6199999999844,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9490000000000003,
"layouts": 9,
"layoutDurationMs": 2.5799999999999996,
"taskDurationMs": 548.222,
"heapDeltaBytes": 4569292,
"heapUsedBytes": 67385428,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.108,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.9910000000218,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.199000000000002,
"layouts": 9,
"layoutDurationMs": 2.1630000000000003,
"taskDurationMs": 890.085,
"heapDeltaBytes": 1062672,
"heapUsedBytes": 63398668,
"domNodes": -200,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 109.655,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5090000000491,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.934999999999999,
"layouts": 9,
"layoutDurationMs": 2.2590000000000003,
"taskDurationMs": 866.643,
"heapDeltaBytes": 19553996,
"heapUsedBytes": 81367224,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 109.17999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1609.1539999999895,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.240999999999996,
"layouts": 5,
"layoutDurationMs": 19.345,
"taskDurationMs": 1389.2189999999998,
"heapDeltaBytes": 7510724,
"heapUsedBytes": 89840844,
"domNodes": -1320,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 35.058,
"eventListeners": -262,
"totalBlockingTimeMs": 211,
"frameDurationMs": 20.41625,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10544.275999999969,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.254,
"layouts": 9,
"layoutDurationMs": 2.321,
"taskDurationMs": 6253.333,
"heapDeltaBytes": -10172852,
"heapUsedBytes": 83285060,
"domNodes": -274,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2790.6079999999997,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.692405063291137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11317.269000000011,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.862000000000002,
"layouts": 9,
"layoutDurationMs": 2.4029999999999996,
"taskDurationMs": 6542.965999999999,
"heapDeltaBytes": -14049964,
"heapUsedBytes": 69277532,
"domNodes": -274,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 3011.5769999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23472.702000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22982.934,
"heapDeltaBytes": -26688156,
"heapUsedBytes": 276548676,
"domNodes": -3482,
"jsHeapTotalBytes": 9945088,
"scriptDurationMs": 303.447,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.7390625,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24455.644000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23857.967,
"heapDeltaBytes": 2091008,
"heapUsedBytes": 286290672,
"domNodes": -3482,
"jsHeapTotalBytes": 8634368,
"scriptDurationMs": 344.794,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.42628774422735,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 19698.534999999993,
"styleRecalcs": 159,
"styleRecalcDurationMs": 13.712000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19280.729,
"heapDeltaBytes": -44241536,
"heapUsedBytes": 259948360,
"domNodes": -3482,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 805.2379999999999,
"eventListeners": -659,
"totalBlockingTimeMs": 25,
"frameDurationMs": 36.34538745387454,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 29795.908999999938,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.07899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29466.911,
"heapDeltaBytes": -29045876,
"heapUsedBytes": 268406448,
"domNodes": -3482,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 935.507,
"eventListeners": -659,
"totalBlockingTimeMs": 11,
"frameDurationMs": 56.4373106060606,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8456.63300000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.741,
"layouts": 20,
"layoutDurationMs": 22.921999999999983,
"taskDurationMs": 8334.417,
"heapDeltaBytes": -31380372,
"heapUsedBytes": 252038296,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 142.934,
"eventListeners": -661,
"totalBlockingTimeMs": 96,
"frameDurationMs": 47.644632768361575,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8738.707999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.47299999999996,
"layouts": 20,
"layoutDurationMs": 27.38900000000001,
"taskDurationMs": 8683.162,
"heapDeltaBytes": 863912,
"heapUsedBytes": 284305180,
"domNodes": -3482,
"jsHeapTotalBytes": 16498688,
"scriptDurationMs": 156.108,
"eventListeners": -661,
"totalBlockingTimeMs": 36,
"frameDurationMs": 51.46823529411764,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11863.358000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11639.082000000002,
"heapDeltaBytes": -12740240,
"heapUsedBytes": 265041536,
"domNodes": 0,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 150.42800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.089090909090906,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12476.675,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12073.238,
"heapDeltaBytes": -8057516,
"heapUsedBytes": 268028328,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 177.35299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.10918727915194,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "workflow-execution",
"durationMs": 112.53700000003164,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.229999999999999,
"layouts": 7,
"layoutDurationMs": 3.439,
"taskDurationMs": 94.735,
"heapDeltaBytes": 5058664,
"heapUsedBytes": 75319032,
"domNodes": 135,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.338,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 143.50600000000213,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.674,
"layouts": 10,
"layoutDurationMs": 4.617,
"taskDurationMs": 107.43100000000001,
"heapDeltaBytes": -11691844,
"heapUsedBytes": 62201428,
"domNodes": 125,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7.110999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 516.62500000009,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6859999999999999,
"layouts": 76,
"layoutDurationMs": 16.441999999999997,
"taskDurationMs": 470.455,
"heapDeltaBytes": -3608424,
"heapUsedBytes": 42427072,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 221.82500000000002,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 576.453000000015,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.76,
"layouts": 76,
"layoutDurationMs": 16.627,
"taskDurationMs": 528.149,
"heapDeltaBytes": -429444,
"heapUsedBytes": 47104484,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 258.13800000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 638.7770000000046,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.342,
"layouts": 76,
"layoutDurationMs": 16.457,
"taskDurationMs": 602.7660000000001,
"heapDeltaBytes": 1547232,
"heapUsedBytes": 102537844,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 247.615,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 711.5559999999732,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.823,
"layouts": 76,
"layoutDurationMs": 17.517999999999997,
"taskDurationMs": 678.7840000000001,
"heapDeltaBytes": 477448,
"heapUsedBytes": 77707016,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 285.238,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.3% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3220 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f29a24d868286ab23fe78976489258474bd2ec70
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.60 #22923 +/- ##
=============================================
Coverage ? 87.59%
=============================================
Files ? 2997
Lines ? 162774
Branches ? 41846
=============================================
Hits ? 142588
Misses ? 19254
Partials ? 932
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…he latest cloud spec (#22930) ## Why The bot's cloud/1.60 types sync (#22776) conflicts now that #22923 landed the same types on cloud/1.60. Its only remaining change is newer doc comments from cloud#18073. ## How Take the bot's generated `packages/ingest-types` output from `update-ingest-types-cloud-1.60`. The change is doc comments only (+9/-6), on `billing_notice_audience` and `ending_notice_starts_at`. No type or schema change. Supersedes #22776. ## AS IS / TO BE No UI change: generated doc comments only.
Summary
Manual backport of #22913 (ingest-types sync to cloud@6ac8f584 plus fixture fixes) and #22914 (E1) to
cloud/1.60. Both auto-backports failed with conflicts.The Billing tab now shows the member auto top-up block only when the server sends
can_view_auto_top_up_member_notice: true, so a Member on a paused Team no longer sees it. The owner auto top-up card now uses the servedcan_view_auto_top_up. The oldcan_manage_auto_top_up && can_top_upgate and thenot_workspace_ownerdenial check are both gone.Commits:
-xlines are kept).-x.Conflicts and resolution
packages/ingest-types/src/*.gen.ts: these were not hand-merged. I regenerated them on this branch from cloud@6ac8f584 with the bot's projection (openapi-project -fe), then ranpnpm generateand oxfmt. The exported names inindex.tsmatch main's M4 chore(ingest-types): sync to cloud@6ac8f584 (member auto top-up notice fact) #22913 output exactly. The regen also brings in spec drift that has built up since the last 1.60 sync, all of it additive:credit_validity, cloud compatibility, agent usage-status, OAuthverified_clientand 429 error types. There is one narrowing:billing_railbecomes'stripe'only. That narrowing broke three e2e fixtures and a contract test on 1.60. Main fixed exactly this in chore(ingest-types): narrow billing_rail to stripe only #22871 with test and fixture changes only, so I carried those changes into commit 1. The pre-commit typecheck rejects any split where the types and the fixtures land in separate commits.M4 fix(billing): show the member auto top-up block from the served member notice fact #22914 core module:
packages/account-core/src/core/billing/billingTab/autoTopUpCard.tsand its test don't exist on 1.60, so I dropped them. On 1.60 the gate lives inBillingTab.vueinstead:autoTopUpEnabled && canViewAutoTopUpCardv-else-if canViewAutoTopUpMemberNoticeBillingAutoTopUpMemberCard.vuedrops its ownnot_workspace_ownercheck and now matches main's version.useBillingCapabilities, its mock and its test, andBillingTab.test.ts: I took main's side. That meanscanViewAutoTopUpCardandcanViewAutoTopUpMemberNoticecome fromreceiveServerFact,manageAutoTopUpDenialis removed, and the scenarios are rewritten with scenario-correct values for the two booleans. No casts, nothing loosened.Risk, same as main: both booleans are required in the generated zod, and
billing_railis nowz.enum(['stripe']). Ingest has to serve cloud#17972, cloud#18078 and the stripe-only rail.Verification
pnpm typecheck,typecheck:browser,typecheck:workspaces,pnpm knip: clean.vitest run src/platform/billing src/platform/account src/platform/auth/webSessionFlag{Off,On}.test.ts: 4422/4422.packages/account-core: 1828/1828.packages/account-ui src/billing: 192/192.apps/billing-web src: 1578/1578.For QA, E1: a Member on a paused Team sees no auto top-up block; on an active Team it shows.