Repository navigation
[backport cloud/1.60] fix(agent): observe meta.groups in DocChangeCollector and project groups - #22845
Conversation
…ups (#21749) ## Summary Part of FE-3387, implements FE-3583; supersedes #21572. `DocChangeCollector` observed `nodes`, `links` and `definitions` but never `meta`, so a remote `clear` left groups on the canvas (BE-22005) and groups carried by `insert_workflow` never appeared. The collector now observes all four roots and emits one change set per frame. - `DocChangeCollector` observes `meta` and adds a `groups` entry to the change set: each root group id whose presence in `meta.groups` changed. Other `meta` keys (including `extra`) are ignored; the package never rewrites `extra` after mint, and replaying it would move the local viewport. - `LiveGraphApplier` reads `meta.groups` at apply time and, per changed id, adds or removes the canvas group with `graph.add`/`graph.remove`, which emit the layout store's `createGroup`/`deleteGroup` operations (ADR CRDT-LAYOUT-0003). No reconcile pass. Groups the document never named, such as one drawn after mint, are left alone. Inserted groups are offset together with the nodes of the same batch. - Because the applier reads the document rather than the frame's delta, a failed frame retries to the document's current groups without the `changesAgainstDoc` patch #21572 needed. - `definitions` was already observed; registration through one `createSubgraphs` batch stays with FE-3401. Gap, needs a package/backend decision: the op vocabulary has no op for groups or for colour/shape/properties. Human group and appearance edits cannot reach the document, so the follower only mirrors host-authored group changes (`clear`, `insert_workflow`). Group geometry/appearance changes inside an existing `meta.groups` entry are not re-applied. No frontend-side ops are added here. ## Verification - `vitest run src/workbench/extensions/agent/crdt/`: 72 files, 1204 passed, 1 expected fail. - New tests fail on main and pass here: collector-level `meta.groups` add/remove diff; real host `clear` op removes both doc groups and keeps a post-mint group (#21572's scenario); #21572's retry case; real `insert_workflow` creates a group placed with its node. - oxfmt, oxlint, eslint on changed files and `pnpm typecheck:app` clean. --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org>
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-03T19:54:50.799Z",
"gitSha": "2befa9639e8ddf31b2d768bd7ebdde84e2d53ff3",
"branch": "backport-21749-to-cloud-1.60",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.0470000000144,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.746,
"layouts": 11,
"layoutDurationMs": 2.6189999999999998,
"taskDurationMs": 303.268,
"heapDeltaBytes": 7927376,
"heapUsedBytes": 69688204,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 5.824999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2028.0500000000075,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.165,
"layouts": 11,
"layoutDurationMs": 1.938,
"taskDurationMs": 332.535,
"heapDeltaBytes": -12019960,
"heapUsedBytes": 65796796,
"domNodes": -178,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 5.4350000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.3919999999787,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.996,
"layouts": 10,
"layoutDurationMs": 2.287,
"taskDurationMs": 581.723,
"heapDeltaBytes": 24282648,
"heapUsedBytes": 85335048,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 107.70400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5199999999918,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.286,
"layouts": 9,
"layoutDurationMs": 1.7959999999999998,
"taskDurationMs": 510.8839999999999,
"heapDeltaBytes": 229292,
"heapUsedBytes": 61561864,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 91.229,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.6150000000184,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.307,
"layouts": 11,
"layoutDurationMs": 1.9310000000000003,
"taskDurationMs": 221.636,
"heapDeltaBytes": 25350868,
"heapUsedBytes": 86397012,
"domNodes": 57,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.247000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.5339999999956,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.494,
"layouts": 13,
"layoutDurationMs": 2.2050000000000005,
"taskDurationMs": 229.07100000000003,
"heapDeltaBytes": 3653608,
"heapUsedBytes": 66585168,
"domNodes": 57,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 6.868000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 510.25999999998817,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.883,
"layouts": 10,
"layoutDurationMs": 5.6690000000000005,
"taskDurationMs": 313.262,
"heapDeltaBytes": 649792,
"heapUsedBytes": 62086300,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 107.59,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 450.51599999999326,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.98,
"layouts": 11,
"layoutDurationMs": 2.677,
"taskDurationMs": 312.112,
"heapDeltaBytes": -15858672,
"heapUsedBytes": 62325972,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 104.461,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 921.9760000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.883,
"heapDeltaBytes": -12673120,
"heapUsedBytes": 77214792,
"domNodes": -208,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 40.119,
"eventListeners": -107,
"totalBlockingTimeMs": 272,
"frameDurationMs": 26.188571428571425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 877.9279999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.6950000000001,
"heapDeltaBytes": -10786648,
"heapUsedBytes": 77476772,
"domNodes": -212,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 35.579,
"eventListeners": -110,
"totalBlockingTimeMs": 247,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.4350000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.1579999999999,
"heapDeltaBytes": -1396872,
"heapUsedBytes": 85170572,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 92.695,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 735.6730000000198,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 304.32999999999976,
"heapDeltaBytes": -2619136,
"heapUsedBytes": 67940192,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 118.84399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 118,
"frameDurationMs": 21.564705882352936,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6738.954000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8059999999999994,
"layouts": 3,
"layoutDurationMs": 0.6930000000000001,
"taskDurationMs": 5618.828,
"heapDeltaBytes": 62880000,
"heapUsedBytes": 140803032,
"domNodes": -274,
"jsHeapTotalBytes": 70643712,
"scriptDurationMs": 4359.860000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 5,
"frameDurationMs": 20.590519877675842,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6240.782999999965,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.7959999999999998,
"layouts": 3,
"layoutDurationMs": 0.6579999999999997,
"taskDurationMs": 5213.428000000001,
"heapDeltaBytes": 40751568,
"heapUsedBytes": 123312980,
"domNodes": -274,
"jsHeapTotalBytes": 56225792,
"scriptDurationMs": 4021.6479999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 19,
"frameDurationMs": 19.5214953271028,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6056.1239999999825,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8070000000000004,
"layouts": 3,
"layoutDurationMs": 0.843,
"taskDurationMs": 5085.191,
"heapDeltaBytes": 46878028,
"heapUsedBytes": 140576108,
"domNodes": -274,
"jsHeapTotalBytes": 65400832,
"scriptDurationMs": 3913.528,
"eventListeners": -69,
"totalBlockingTimeMs": 28,
"frameDurationMs": 18.79470404984424,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5817.7839999999605,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9450000000000005,
"layouts": 4,
"layoutDurationMs": 0.8600000000000001,
"taskDurationMs": 4957.56,
"heapDeltaBytes": 48577276,
"heapUsedBytes": 142370600,
"domNodes": -274,
"jsHeapTotalBytes": 66973696,
"scriptDurationMs": 3830.8379999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 14,
"frameDurationMs": 18.238050314465408,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 134.3999999999994,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.940000000000001,
"layouts": 12,
"layoutDurationMs": 2.6169999999999995,
"taskDurationMs": 98.215,
"heapDeltaBytes": 14771148,
"heapUsedBytes": 92295868,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.5840000000000005,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 131.56199999997398,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.503999999999998,
"layouts": 12,
"layoutDurationMs": 2.5330000000000004,
"taskDurationMs": 93.02199999999999,
"heapDeltaBytes": 14794212,
"heapUsedBytes": 93220140,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.265999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857105,
"p95FrameDurationMs": 33.5
},
{
"name": "large-graph-idle",
"durationMs": 2008.1690000000094,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7270000000000003,
"layouts": 10,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 387.06699999999995,
"heapDeltaBytes": -14419036,
"heapUsedBytes": 67472728,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 18.833000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2010.199,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.6909999999999998,
"layouts": 9,
"layoutDurationMs": 1.588,
"taskDurationMs": 388.80499999999995,
"heapDeltaBytes": -11194652,
"heapUsedBytes": 74230760,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 22.997999999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2157.1810000000087,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.586,
"layouts": 9,
"layoutDurationMs": 1.9189999999999998,
"taskDurationMs": 1066.4319999999998,
"heapDeltaBytes": -10987256,
"heapUsedBytes": 72187628,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 527.6070000000001,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2131.4540000000193,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.883,
"layouts": 10,
"layoutDurationMs": 2.143,
"taskDurationMs": 1040.034,
"heapDeltaBytes": -3693988,
"heapUsedBytes": 87222692,
"domNodes": -294,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 522.576,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3242.705000000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.937000000000001,
"layouts": 64,
"layoutDurationMs": 10.318999999999999,
"taskDurationMs": 1176.371,
"heapDeltaBytes": -11609668,
"heapUsedBytes": 74735944,
"domNodes": -250,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 517.0680000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665641025641026,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3105.176999999969,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.203999999999999,
"layouts": 67,
"layoutDurationMs": 10.456,
"taskDurationMs": 1091.9150000000002,
"heapDeltaBytes": 12269572,
"heapUsedBytes": 98594852,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 503.93699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666844919786094,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2254.8020000000124,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.113,
"layouts": 8,
"layoutDurationMs": 1.827,
"taskDurationMs": 1224.168,
"heapDeltaBytes": -2912184,
"heapUsedBytes": 91121948,
"domNodes": 0,
"jsHeapTotalBytes": 5697536,
"scriptDurationMs": 620.814,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2188.3619999999837,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.799,
"layouts": 7,
"layoutDurationMs": 1.5270000000000001,
"taskDurationMs": 1227.193,
"heapDeltaBytes": -8026424,
"heapUsedBytes": 76549832,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 622.39,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2797.831000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2199999999999998,
"layouts": 10,
"layoutDurationMs": 1.9909999999999997,
"taskDurationMs": 487.889,
"heapDeltaBytes": 3401128,
"heapUsedBytes": 87334884,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 246.32,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2740.58500000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.4799999999999995,
"layouts": 8,
"layoutDurationMs": 1.293,
"taskDurationMs": 435.943,
"heapDeltaBytes": 1292576,
"heapUsedBytes": 92439168,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 219.125,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2020.8700000000022,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5250000000000004,
"layouts": 9,
"layoutDurationMs": 1.525,
"taskDurationMs": 410.39300000000003,
"heapDeltaBytes": -2280420,
"heapUsedBytes": 82902908,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 23.142,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2005.7499999999777,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6840000000000006,
"layouts": 9,
"layoutDurationMs": 1.6179999999999999,
"taskDurationMs": 377.524,
"heapDeltaBytes": -7952672,
"heapUsedBytes": 84543080,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 18.830999999999996,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2711.635000000001,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.058000000000002,
"layouts": 7,
"layoutDurationMs": 1.155,
"taskDurationMs": 381.00500000000005,
"heapDeltaBytes": 412964,
"heapUsedBytes": 82875384,
"domNodes": -268,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 121.25300000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665644171779142,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2712.2439999999983,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.138,
"layouts": 8,
"layoutDurationMs": 1.6800000000000002,
"taskDurationMs": 344.28000000000003,
"heapDeltaBytes": -19838804,
"heapUsedBytes": 71911204,
"domNodes": 19,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 115.83000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564417177914,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2899.6860000000024,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0380000000000007,
"layouts": 8,
"layoutDurationMs": 1.744,
"taskDurationMs": 602.0029999999999,
"heapDeltaBytes": -22509368,
"heapUsedBytes": 62002788,
"domNodes": -274,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 236.269,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2916.843999999969,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.477,
"layouts": 7,
"layoutDurationMs": 1.2699999999999998,
"taskDurationMs": 592.096,
"heapDeltaBytes": -10604884,
"heapUsedBytes": 81819552,
"domNodes": 0,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 237.838,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666285714285713,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 381.3470000000052,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.231000000000001,
"layouts": 9,
"layoutDurationMs": 1.9559999999999997,
"taskDurationMs": 270.582,
"heapDeltaBytes": 891588,
"heapUsedBytes": 63147084,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 91.457,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 441.2280000000237,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.949999999999999,
"layouts": 10,
"layoutDurationMs": 2.188,
"taskDurationMs": 277.6650000000001,
"heapDeltaBytes": 24849248,
"heapUsedBytes": 87450944,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 91.765,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.3140000000176,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9940000000000002,
"layouts": 10,
"layoutDurationMs": 1.7240000000000002,
"taskDurationMs": 304.219,
"heapDeltaBytes": 8627936,
"heapUsedBytes": 71158456,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 5.8210000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.8359999999834,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9959999999999996,
"layouts": 10,
"layoutDurationMs": 1.7440000000000002,
"taskDurationMs": 215.624,
"heapDeltaBytes": -13373440,
"heapUsedBytes": 66592620,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 4.835000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.510000000004,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.763000000000002,
"layouts": 10,
"layoutDurationMs": 2.1930000000000005,
"taskDurationMs": 543.9419999999999,
"heapDeltaBytes": -6617600,
"heapUsedBytes": 63102740,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 79.06200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.6900000000173,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.209,
"layouts": 9,
"layoutDurationMs": 1.7820000000000003,
"taskDurationMs": 491.834,
"heapDeltaBytes": 23636180,
"heapUsedBytes": 85657140,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 70.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 885.0390000000061,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.532,
"layouts": 5,
"layoutDurationMs": 10.296,
"taskDurationMs": 704.4510000000001,
"heapDeltaBytes": 18271068,
"heapUsedBytes": 100024736,
"domNodes": 19229,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 18.323000000000008,
"eventListeners": 3566,
"totalBlockingTimeMs": 88,
"frameDurationMs": 19.20217391304348,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8203.68400000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.260000000000005,
"layouts": 11,
"layoutDurationMs": 2.212,
"taskDurationMs": 3568.044,
"heapDeltaBytes": -16018296,
"heapUsedBytes": 73413276,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 1760.4479999999999,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666260162601624,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8153.8719999999785,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.143,
"layouts": 9,
"layoutDurationMs": 1.813,
"taskDurationMs": 3555.454,
"heapDeltaBytes": -16913408,
"heapUsedBytes": 77948996,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 1737.494,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666053169734152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16029.102000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15122.137,
"heapDeltaBytes": -6333156,
"heapUsedBytes": 280643344,
"domNodes": -3482,
"jsHeapTotalBytes": 15974400,
"scriptDurationMs": 188.95600000000002,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.036593591905564,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 14936.216999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14186.537,
"heapDeltaBytes": -31113124,
"heapUsedBytes": 266594844,
"domNodes": -3482,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 170.179,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.266835871404396,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 19339.837999999985,
"styleRecalcs": 158,
"styleRecalcDurationMs": 17.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18950.451999999997,
"heapDeltaBytes": -24573500,
"heapUsedBytes": 272973552,
"domNodes": -3482,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 663.736,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.47266055045872,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 18249.20000000003,
"styleRecalcs": 147,
"styleRecalcDurationMs": 15.328999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17947.576,
"heapDeltaBytes": -22814424,
"heapUsedBytes": 274324024,
"domNodes": -3482,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 605.409,
"eventListeners": -659,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.17471910112359,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5798.735000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.188,
"layouts": 20,
"layoutDurationMs": 25.361999999999995,
"taskDurationMs": 5682.346,
"heapDeltaBytes": -1122960,
"heapUsedBytes": 284062296,
"domNodes": -3482,
"jsHeapTotalBytes": 17809408,
"scriptDurationMs": 101.134,
"eventListeners": -661,
"totalBlockingTimeMs": 29,
"frameDurationMs": 33.622674418604646,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5551.417000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 38.52599999999999,
"layouts": 20,
"layoutDurationMs": 18.915000000000003,
"taskDurationMs": 5474.7029999999995,
"heapDeltaBytes": -18840044,
"heapUsedBytes": 279059440,
"domNodes": -3482,
"jsHeapTotalBytes": 26730496,
"scriptDurationMs": 72.33999999999999,
"eventListeners": -661,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.33192771084337,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7309.091999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6933.986000000001,
"heapDeltaBytes": 5577096,
"heapUsedBytes": 282352724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 77.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.171724137931033,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7974.544000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7506.161000000001,
"heapDeltaBytes": -25067296,
"heapUsedBytes": 265890880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.51600000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.00474576271187,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 439.5979999999895,
"styleRecalcs": 16,
"styleRecalcDurationMs": 8.366,
"layouts": 10,
"layoutDurationMs": 2.954,
"taskDurationMs": 87.11500000000001,
"heapDeltaBytes": 7601440,
"heapUsedBytes": 69029988,
"domNodes": 138,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.776000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 92.30999999999767,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.638999999999999,
"layouts": 8,
"layoutDurationMs": 2.9430000000000005,
"taskDurationMs": 70.253,
"heapDeltaBytes": -12864124,
"heapUsedBytes": 61472760,
"domNodes": 106,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 5.839,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 234.18000000003758,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.606,
"layouts": 76,
"layoutDurationMs": 11.126000000000001,
"taskDurationMs": 185.78,
"heapDeltaBytes": 10055200,
"heapUsedBytes": 49627264,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 78.09400000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 224.12899999994806,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.631,
"layouts": 76,
"layoutDurationMs": 11.497,
"taskDurationMs": 184.56300000000002,
"heapDeltaBytes": 10096768,
"heapUsedBytes": 50340900,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 78.223,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 244.59400000000642,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.108,
"layouts": 76,
"layoutDurationMs": 10.439,
"taskDurationMs": 213.318,
"heapDeltaBytes": -2352024,
"heapUsedBytes": 90059028,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 72.99,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 245.95299999998588,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.374,
"layouts": 76,
"layoutDurationMs": 10.156,
"taskDurationMs": 214.903,
"heapDeltaBytes": -1649492,
"heapUsedBytes": 95886704,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 69.266,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🎭 Playwright: ✅ 3220 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure
Findings and check detailsExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Full docs: scripts/registry-census/README.md Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
🌾 Fallow: ✅ PassedFindings and check detailsFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Full docs: ADR-DEVEX-LINT-0015 Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 27ed9db79f1f6caac167ff7d7874b5f7b43cb748
🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (356)
Full docs: Frontend domain catalog Reproduce locallypnpm architecture:check |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.60 #22845 +/- ##
=============================================
Coverage ? 87.59%
=============================================
Files ? 2996
Lines ? 162768
Branches ? 43874
=============================================
Hits ? 142571
Misses ? 19264
Partials ? 933
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21749 to cloud/1.60, with passing checks.
I compared all seven files against merged source commit f68a6f9, verified on current main. Every added and removed line matches, including all source tests. No target-specific adaptations were needed.
With the target's locked dependencies installed in this worktree, I ran the CRDT suite: 78 files passed, with 1,393 tests passed and two expected failures. ESLint on the changed production files and git diff --check passed. The required lint-and-format, test, and e2e-status checks are green at this head.
christian-byrne
left a comment
There was a problem hiding this comment.
Backport review at 0967557: clean cherry-pick of #21749 (f68a6f9), no conflict resolution. Diff against the cloud/1.60 tip 27ed9db equals the main change line for line (7 files, +290/-56). Focused vitest on the touched files passes 110/110 at this head. Branch refreshed onto the current train tip with update-branch; exact-head checks all terminal green (87 pass, 19 skipped), target-branch merge guard passed, no unresolved threads. Merging under the program's release-backport grant.
#22974) Backport of #22958 to `core/1.60`. A group the agent inserts without an `id` was dropped by the live applier, so it never reached the canvas or the saved workflow. This is the second half of the "groups the agent adds don't show up" fix, after #21749 (#22844/#22845) and #22945 (#22965/#22966), which are already on this branch. Manual: the auto-backport stopped on two browser-test files (`agentStageFrames.ts`, `agentStageFramesFromInsertedWorkflow.spec.ts`) that do not exist on `core/1.60`, so their hunks are left out. The one content conflict was the import line in `liveGraphApplier.test.ts`: `readDocGroups` is imported next to `LiveGraphApplier`; `readDocWidgetValue` (imported on main) is not used by this branch's test file, so it stays out. `liveGraphApplier.ts` and the integration tests apply unchanged.
…id (#22975) Backport of #22958 to `cloud/1.60`. A group the agent inserts without an `id` was dropped by the live applier, so it never reached the canvas or the saved workflow. This is the second half of the "groups the agent adds don't show up" fix, after #21749 (#22844/#22845) and #22945 (#22965/#22966), which are already on this branch. Manual: the auto-backport stopped on two browser-test files (`agentStageFrames.ts`, `agentStageFramesFromInsertedWorkflow.spec.ts`) that do not exist on `cloud/1.60`, so their hunks are left out. The one content conflict was the import line in `liveGraphApplier.test.ts`: `readDocGroups` is imported next to `LiveGraphApplier`; `readDocWidgetValue` (imported on main) is not used by this branch's test file, so it stays out. `liveGraphApplier.ts` and the integration tests apply unchanged.
Backport of #21749 to
cloud/1.60Automatically created by backport workflow.
Fixes FE 1.60 QA row REG04 (agent-created groups never land on the canvas), ticket FRONT-3583.
Justification: Agent release backport of merged #21749 on a current train, merged by the program under its standing release-backport grant (program/release-backport-authority.md). Carrier diff against the cloud/1.60 tip equals the main change f68a6f9 line for line; focused vitest (agentCrdtProjection.integration, docChangeCollector, liveGraphApplier) passes 110/110 at this head; target-branch merge guard passed with all exact-head checks terminal green; no unresolved threads. GitHub does not accept an approval from this account as the merging author, so no approval record exists.