Repository navigation
[cloud/1.58] fix(billing): read subscription_state for the locked-credits line - #22689
Conversation
…cloud/1.58 The first port keyed the resubscribe wording on subscriptionStatus, which is not the same fact as main's subscriptionState: a lapsed legacy subscriber shows 'canceled' and got the subscribe line. The API already sends subscription_state on this branch, so expose it on the billing context (legacy and workspace adapters, mocks) as main does, and use CreditsLockedNotice exactly as on main. Server facts are rendered as received, per ADR 0042.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 8 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-02T03:05:37.234Z",
"gitSha": "460520cdd5ad250ce39230530f2f5f66cd595713",
"branch": "fix-1.58-credits-locked-subscription-state",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.7890000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5300000000000002,
"layouts": 10,
"layoutDurationMs": 3.431,
"taskDurationMs": 583.2729999999999,
"heapDeltaBytes": -806276,
"heapUsedBytes": 90967796,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.551000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2050.6339999999454,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.132,
"layouts": 9,
"layoutDurationMs": 2.4450000000000007,
"taskDurationMs": 653.023,
"heapDeltaBytes": -497420,
"heapUsedBytes": 87482636,
"domNodes": -200,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 12.528999999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.1210000000005,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.719000000000001,
"layouts": 9,
"layoutDurationMs": 2.7319999999999998,
"taskDurationMs": 940.3539999999999,
"heapDeltaBytes": 18887356,
"heapUsedBytes": 110176164,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 174.148,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1923.9460000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.157,
"layouts": 9,
"layoutDurationMs": 2.842,
"taskDurationMs": 1002.4150000000001,
"heapDeltaBytes": 21868496,
"heapUsedBytes": 113011432,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 177.94000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608695652174,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.5769999999816,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.1579999999999995,
"layouts": 11,
"layoutDurationMs": 3.952,
"taskDurationMs": 364.815,
"heapDeltaBytes": 21571456,
"heapUsedBytes": 112364684,
"domNodes": 47,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 14.451000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1779.2619999999033,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.837999999999999,
"layouts": 10,
"layoutDurationMs": 2.873,
"taskDurationMs": 513.702,
"heapDeltaBytes": 21483764,
"heapUsedBytes": 112656736,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 15.598000000000004,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 718.5140000000274,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.7020000000000004,
"layouts": 10,
"layoutDurationMs": 3.3539999999999996,
"taskDurationMs": 498.35400000000004,
"heapDeltaBytes": -614584,
"heapUsedBytes": 90307704,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 184.147,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190476,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 683.5340000000087,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.510000000000001,
"layouts": 9,
"layoutDurationMs": 3.2199999999999998,
"taskDurationMs": 479.94899999999996,
"heapDeltaBytes": 3365676,
"heapUsedBytes": 92302364,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 182.825,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1299.0050000000224,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 961.8820000000001,
"heapDeltaBytes": -9328904,
"heapUsedBytes": 102780768,
"domNodes": -230,
"jsHeapTotalBytes": 12394496,
"scriptDurationMs": 76.039,
"eventListeners": -168,
"totalBlockingTimeMs": 604,
"frameDurationMs": 34.21052631578947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1294.6190000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 994.331,
"heapDeltaBytes": -14249552,
"heapUsedBytes": 102441508,
"domNodes": -230,
"jsHeapTotalBytes": 16588800,
"scriptDurationMs": 75.10000000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 614,
"frameDurationMs": 35.132432432432445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.3929999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.9800000000001,
"heapDeltaBytes": -3306816,
"heapUsedBytes": 98391024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.603,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.3620000000283,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.31000000000034,
"heapDeltaBytes": -3012980,
"heapUsedBytes": 98215432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.29999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11378.158000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10491.859999999999,
"heapDeltaBytes": 15826804,
"heapUsedBytes": 136912472,
"domNodes": -276,
"jsHeapTotalBytes": 39124992,
"scriptDurationMs": 8708.221000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1805,
"frameDurationMs": 33.97910447761195,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11889.653999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11078.993,
"heapDeltaBytes": 51640236,
"heapUsedBytes": 176820032,
"domNodes": -276,
"jsHeapTotalBytes": 62795776,
"scriptDurationMs": 8870.616,
"eventListeners": -130,
"totalBlockingTimeMs": 1490,
"frameDurationMs": 32.2029810298103,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12228.036000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11472.009000000002,
"heapDeltaBytes": 50602240,
"heapUsedBytes": 154075148,
"domNodes": -276,
"jsHeapTotalBytes": 39989248,
"scriptDurationMs": 9340.516,
"eventListeners": -130,
"totalBlockingTimeMs": 1934,
"frameDurationMs": 33.42295081967213,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11711.572999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10890.509999999998,
"heapDeltaBytes": 52832192,
"heapUsedBytes": 156527760,
"domNodes": -276,
"jsHeapTotalBytes": 38154240,
"scriptDurationMs": 8723.297,
"eventListeners": -130,
"totalBlockingTimeMs": 1428,
"frameDurationMs": 32.23030303030303,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 257.4070000000006,
"styleRecalcs": 24,
"styleRecalcDurationMs": 17.027,
"layouts": 11,
"layoutDurationMs": 3.83,
"taskDurationMs": 188.90200000000002,
"heapDeltaBytes": 13243804,
"heapUsedBytes": 117434888,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 9.518,
"eventListeners": 196,
"totalBlockingTimeMs": 6,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 247.52200000000357,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.548000000000002,
"layouts": 12,
"layoutDurationMs": 4.222,
"taskDurationMs": 188.66599999999997,
"heapDeltaBytes": 15461976,
"heapUsedBytes": 118192004,
"domNodes": 917,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 9.713000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2041.312000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.112000000000001,
"layouts": 8,
"layoutDurationMs": 3.073,
"taskDurationMs": 561.901,
"heapDeltaBytes": 430260,
"heapUsedBytes": 102033052,
"domNodes": -296,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 36.011,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.3709999999937,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1850000000000005,
"layouts": 6,
"layoutDurationMs": 2.05,
"taskDurationMs": 732.529,
"heapDeltaBytes": -155996,
"heapUsedBytes": 101724428,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 37.257000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2663.2620000000315,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.232,
"layouts": 6,
"layoutDurationMs": 1.9700000000000004,
"taskDurationMs": 1829.1599999999999,
"heapDeltaBytes": 642876,
"heapUsedBytes": 104125764,
"domNodes": -296,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 963.067,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.878343949044584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2337.427000000048,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.443999999999999,
"layouts": 6,
"layoutDurationMs": 1.6600000000000004,
"taskDurationMs": 1622.2660000000003,
"heapDeltaBytes": -2963196,
"heapUsedBytes": 103817296,
"domNodes": -296,
"jsHeapTotalBytes": -942080,
"scriptDurationMs": 855.559,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.90875912408759,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3975.89899999997,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.822,
"layouts": 64,
"layoutDurationMs": 11.216000000000001,
"taskDurationMs": 1905.1689999999999,
"heapDeltaBytes": 10160904,
"heapUsedBytes": 109989376,
"domNodes": -272,
"jsHeapTotalBytes": -3706880,
"scriptDurationMs": 824.4440000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665966386554622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3614.588000000026,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.947999999999999,
"layouts": 64,
"layoutDurationMs": 11.665,
"taskDurationMs": 1697.1819999999998,
"heapDeltaBytes": 6781716,
"heapUsedBytes": 115235872,
"domNodes": 24,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 833.9080000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666359447004606,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3198.3189999999695,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.779999999999999,
"layouts": 4,
"layoutDurationMs": 1.2379999999999995,
"taskDurationMs": 2110.676,
"heapDeltaBytes": -12369296,
"heapUsedBytes": 96939724,
"domNodes": 0,
"jsHeapTotalBytes": 1024000,
"scriptDurationMs": 1031.6159999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.20160427807487,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3290.7180000000835,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.347000000000001,
"layouts": 4,
"layoutDurationMs": 1.2119999999999995,
"taskDurationMs": 2198.094,
"heapDeltaBytes": -596348,
"heapUsedBytes": 108299100,
"domNodes": -296,
"jsHeapTotalBytes": 196608,
"scriptDurationMs": 1056.1269999999997,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.011398963730574,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2072.443000000021,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7099999999999995,
"layouts": 7,
"layoutDurationMs": 2.487,
"taskDurationMs": 800.703,
"heapDeltaBytes": -28810280,
"heapUsedBytes": 94177652,
"domNodes": -296,
"jsHeapTotalBytes": -1626112,
"scriptDurationMs": 39.347,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.162999999955,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.528999999999999,
"layouts": 6,
"layoutDurationMs": 2.2689999999999997,
"taskDurationMs": 578.9190000000001,
"heapDeltaBytes": 1453692,
"heapUsedBytes": 109698840,
"domNodes": -296,
"jsHeapTotalBytes": -458752,
"scriptDurationMs": 37.64699999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 713.6919999999805,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.045999999999999,
"layouts": 10,
"layoutDurationMs": 3.013,
"taskDurationMs": 497.778,
"heapDeltaBytes": 22542304,
"heapUsedBytes": 114064384,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 154.327,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.3040000000337,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.585999999999999,
"layouts": 8,
"layoutDurationMs": 2.5860000000000003,
"taskDurationMs": 434.836,
"heapDeltaBytes": 22405280,
"heapUsedBytes": 112957452,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 155.347,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.1679999999794,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6219999999999994,
"layouts": 10,
"layoutDurationMs": 3.7910000000000004,
"taskDurationMs": 479.19500000000005,
"heapDeltaBytes": 986092,
"heapUsedBytes": 90980188,
"domNodes": -218,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 9.732,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.8059999999596,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4680000000000004,
"layouts": 10,
"layoutDurationMs": 4.006,
"taskDurationMs": 592.05,
"heapDeltaBytes": -893140,
"heapUsedBytes": 91218416,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.35,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1855.2320000000009,
"styleRecalcs": 58,
"styleRecalcDurationMs": 14.548,
"layouts": 9,
"layoutDurationMs": 2.973,
"taskDurationMs": 1067.545,
"heapDeltaBytes": -3894612,
"heapUsedBytes": 86002924,
"domNodes": -210,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 125.472,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2006.9780000000037,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.482999999999997,
"layouts": 10,
"layoutDurationMs": 3.128,
"taskDurationMs": 1041.11,
"heapDeltaBytes": -1448412,
"heapUsedBytes": 88553176,
"domNodes": -210,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 126.25899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.7809999999786,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.580999999999996,
"layouts": 5,
"layoutDurationMs": 17.087999999999997,
"taskDurationMs": 1189.7389999999998,
"heapDeltaBytes": 11687456,
"heapUsedBytes": 132857596,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 34.02400000000001,
"eventListeners": 3244,
"totalBlockingTimeMs": 169,
"frameDurationMs": 19.777333333333324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8446.871999999985,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.89,
"layouts": 7,
"layoutDurationMs": 2.124,
"taskDurationMs": 5694.095,
"heapDeltaBytes": 1709596,
"heapUsedBytes": 103377800,
"domNodes": -296,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 2869.5220000000004,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765277777777776,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8588.705000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.205999999999996,
"layouts": 8,
"layoutDurationMs": 2.2880000000000003,
"taskDurationMs": 5813.722000000001,
"heapDeltaBytes": 2524108,
"heapUsedBytes": 103772888,
"domNodes": -276,
"jsHeapTotalBytes": -266240,
"scriptDurationMs": 2892.528,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.730994152046787,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22880.03299999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22284.896,
"heapDeltaBytes": -54213864,
"heapUsedBytes": 265018680,
"domNodes": -3344,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 310.967,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.18594024604569,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16502.986000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15757.450000000003,
"heapDeltaBytes": -17217348,
"heapUsedBytes": 293159512,
"domNodes": -3344,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 264.438,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.594974003466202,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19952.770999999986,
"styleRecalcs": 152,
"styleRecalcDurationMs": 17.674999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19552.815,
"heapDeltaBytes": -26178636,
"heapUsedBytes": 298794680,
"domNodes": -3344,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 860.7410000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 36.53717948717949,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28348.50200000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28028.425000000003,
"heapDeltaBytes": -23488108,
"heapUsedBytes": 296946860,
"domNodes": -3344,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 882.9820000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 54.17227533460804,
"p95FrameDurationMs": 116.5
},
{
"name": "vue-node-resize-workload",
"durationMs": 6093.974000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.70999999999998,
"layouts": 20,
"layoutDurationMs": 30.37699999999999,
"taskDurationMs": 5923.347000000001,
"heapDeltaBytes": -49494652,
"heapUsedBytes": 270074000,
"domNodes": -3344,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 101.345,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.56306818181818,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8332.027000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 105.76000000000002,
"layouts": 20,
"layoutDurationMs": 31.795000000000005,
"taskDurationMs": 8218.968,
"heapDeltaBytes": -39754300,
"heapUsedBytes": 260871776,
"domNodes": -3344,
"jsHeapTotalBytes": 5492736,
"scriptDurationMs": 126.112,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.617142857142845,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8220.090999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7809.070999999998,
"heapDeltaBytes": 23393140,
"heapUsedBytes": 285522432,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.99199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.908474576271185,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8206.319000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7726.656999999997,
"heapDeltaBytes": -18944328,
"heapUsedBytes": 274475768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.88199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.2748275862069,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 526.2119999999868,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.492999999999999,
"layouts": 11,
"layoutDurationMs": 5.139,
"taskDurationMs": 173.346,
"heapDeltaBytes": 7487368,
"heapUsedBytes": 107834160,
"domNodes": 126,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 19.872999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.21999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 150.5490000000691,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.314000000000002,
"layouts": 9,
"layoutDurationMs": 4.2540000000000004,
"taskDurationMs": 117.32499999999999,
"heapDeltaBytes": -21094072,
"heapUsedBytes": 88727108,
"domNodes": 117,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.678,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 484.28499999999985,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.732,
"layouts": 76,
"layoutDurationMs": 15.935,
"taskDurationMs": 445.31699999999995,
"heapDeltaBytes": 11818700,
"heapUsedBytes": 81791372,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 212.179,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 505.47099999994316,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6880000000000001,
"layouts": 76,
"layoutDurationMs": 16.32,
"taskDurationMs": 464.68499999999995,
"heapDeltaBytes": 12487980,
"heapUsedBytes": 81973588,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 223.715,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 675.1489999999194,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.33,
"layouts": 76,
"layoutDurationMs": 15.554,
"taskDurationMs": 639.355,
"heapDeltaBytes": 1834968,
"heapUsedBytes": 119510860,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 260.418,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.073170731707318,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 713.119000000006,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.706,
"layouts": 76,
"layoutDurationMs": 16.519,
"taskDurationMs": 668.483,
"heapDeltaBytes": 1994560,
"heapUsedBytes": 119738332,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 278.649,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 63.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2994 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f7a13fba9f6aabf39497fb0907b0ba92585902e9
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (145)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.58 #22689 +/- ##
=============================================
Coverage ? 84.26%
=============================================
Files ? 3173
Lines ? 165699
Branches ? 39133
=============================================
Hits ? 139621
Misses ? 25687
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Verified against cloud/1.58:
- Bug is real.
useLegacyBillingreturnssubscriptionStatus = 'canceled'wheneverisCancelledis true (useLegacyBilling.ts:158), so a lapsed legacy subscriber never reached the oldsubscriptionStatus === 'ended'branch and was shown "Subscribe" instead of "Resubscribe". - Server fact rendered as received (ADR 0042). Both adapters now pass
BillingStatusResponse.subscription_statestraight through. Its type is the generatedSubscriptionStatefrom@comfyorg/ingest-types(documented as "Server-owned subscription presentation state"). Nothing is derived on the client. - Matches
main.CreditsLockedNoticenow readssubscriptionState === 'ended', the same asmain(src/platform/billing/components/CreditsLockedNotice.vue). The mocks and the storybook mock are updated to match. - Tests. The passthrough test cannot pass without the new field. The notice tests cover
never_subscribed,ended, and unknown (null). CI is green.
No blockers. Approving.
Follow-up to #22685 (cloud/1.58 backport of #22514), which auto-merged at its approved head before this commit reached it.
Problem. On cloud/1.58 the locked-credits line picks subscribe or resubscribe wording from
subscriptionStatus === 'ended'. That is not the factmainuses (subscriptionState). A lapsed legacy subscriber readscanceledthere (legacy billing sets it on the client fromisCancelled), so they are told "Subscribe" instead of "Resubscribe". Found by an independent review of #22685; the server-facts gate (ADR 0042) also rejects deriving the state fromsubscriptionStatus.Fix. The API already sends
subscription_stateon this branch. Expose it on the billing context asmaindoes (types, legacy and workspace adapters,__mocks__, storybook mock), and makeCreditsLockedNoticeidentical tomain. No other behaviour changes; nothing reads the new field except the notice.Tests. New
useBillingContextpassthrough test, seen failing before the change.CreditsLockedNoticetest is themainversion (never_subscribed,ended, unknown). Local:pnpm typecheckclean; vitest onsrc/composables/billing,src/platform/workspace,src/platform/cloud,src/scripts/app.test.ts,src/platform/errorCatalog: 205 files, 5025 passed.Cloud 1.58 only:
mainand cloud/1.59 already readsubscriptionState. Related: https://linear.app/comfyorg/issue/FRONT-3662, https://linear.app/comfyorg/issue/PM-2273