Repository navigation
[backport cloud/1.58] fix(billing): say why bought credits did not unlock a refused Cloud run - #22685
Conversation
…lock a refused Cloud run (#22514) ## Summary A free Cloud account that holds credits gets `402 CLOUD_SUBSCRIPTION_REQUIRED` with `credits_locked: true` when it presses Run. Since #21592 that opens the subscribe dialog, but the dialog dropped the fact, so someone who just bought credits was never told why they did not help. This shows the already approved plan-required line in the dialog. - Fixes https://linear.app/comfyorg/issue/FRONT-3662 - Related: https://linear.app/comfyorg/issue/PM-2273, https://linear.app/comfyorg/issue/BE-20863 ## Changes - `promptErrorHasLockedCredits` reads the raw refusal. `normalizePromptError` keeps its shape. - `creditsLocked` travels through `useAccountPreconditionDialog`, `showSubscriptionRequiredDialog` and `useSubscriptionDialog` into all three dialog contents (unified, legacy team, legacy personal). - New `CreditsLockedNotice` reuses `credits.topUp.planRequiredSubscribe`, or `planRequiredResubscribe` when `subscription_state` is `ended`. No new copy, so no new translations. Unified and legacy team show it on the pricing step only. - `modal_opened` gains `refusal_type` (the server `error.type`). `reason` stays `subscription_required` so existing funnels keep working. - Small refactor in `showPricingTable`: one shared props object, because the audit gate flagged the extra optional reads. ## Screenshot Mocked 402 on the Cloud build, real Run button, new line under the title:  ## Tests - Unit, red first: refusal parsing, routing, `app.queuePrompt`, each dialog variant, resubscribe versus subscribe line. - Cloud e2e `browser_tests/tests/billing/cloudCreditsLockedRefusal.spec.ts` with a snapshot: `credits_locked: true` shows the line, `false` does not. Passed locally against a served Cloud build and in CI. Baseline regenerated through the CI expectations workflow. ## Known limit An account whose billing reads inactive never reaches the server: `blockRunWithoutSubscription` opens the dialog with reason `subscribe_to_run` and no refusal, so no line shows there. Only a refusal says the credits are locked. The resumed dialog drops the line for the same reason. `onChooseTeam` sends the user to the team-workspace flow and `resumePendingPricingFlow` reopens pricing from a session marker, with no refusal in hand to re-read. Backport: cloud trains only, this has no effect off Cloud. cloud/1.58 adaptation: CreditsLockedNotice lives in src/platform/workspace/components and reads subscriptionStatus === 'ended', because this branch's BillingContext has no subscriptionState. The e2e asserts the line inside the dialog by text instead of a region screenshot: this branch has no expectRegionScreenshot helper, and the main baseline would not match this branch's dialog. (cherry picked from commit 834cce9)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-02T02:08:07.790Z",
"gitSha": "29057894c3d9d61ae6f209335537b4db5d2f2db4",
"branch": "backport-22514-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.639999999982,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.797,
"layouts": 10,
"layoutDurationMs": 2.7140000000000004,
"taskDurationMs": 409.30899999999997,
"heapDeltaBytes": 1262392,
"heapUsedBytes": 89186720,
"domNodes": -200,
"jsHeapTotalBytes": -3342336,
"scriptDurationMs": 8.497000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.3599999999683,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5850000000000004,
"layouts": 9,
"layoutDurationMs": 2.626,
"taskDurationMs": 403.02000000000004,
"heapDeltaBytes": 7981300,
"heapUsedBytes": 95931068,
"domNodes": -180,
"jsHeapTotalBytes": -3604480,
"scriptDurationMs": 7.785,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.8579999999881,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.095,
"layouts": 10,
"layoutDurationMs": 2.6189999999999998,
"taskDurationMs": 871.169,
"heapDeltaBytes": -589432,
"heapUsedBytes": 104059524,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 160.59599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.0229999999492,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.392,
"layouts": 10,
"layoutDurationMs": 2.713,
"taskDurationMs": 706.132,
"heapDeltaBytes": 18723864,
"heapUsedBytes": 108931932,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 156.89700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.569000000049,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.102,
"layouts": 11,
"layoutDurationMs": 2.886,
"taskDurationMs": 280.408,
"heapDeltaBytes": 21465056,
"heapUsedBytes": 109476912,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.516,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1807.3120000000245,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.49,
"layouts": 11,
"layoutDurationMs": 2.6320000000000006,
"taskDurationMs": 457.811,
"heapDeltaBytes": 21521392,
"heapUsedBytes": 112223148,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.827000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 680.6119999999964,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9439999999999995,
"layouts": 9,
"layoutDurationMs": 2.7680000000000007,
"taskDurationMs": 497.72499999999997,
"heapDeltaBytes": 735980,
"heapUsedBytes": 88121256,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 167.30499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 632.4710000000096,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8859999999999997,
"layouts": 9,
"layoutDurationMs": 2.6300000000000003,
"taskDurationMs": 448.29200000000003,
"heapDeltaBytes": 219220,
"heapUsedBytes": 87799772,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 170.018,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66216216216215,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.7489999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 925.333,
"heapDeltaBytes": -8958648,
"heapUsedBytes": 102826132,
"domNodes": -230,
"jsHeapTotalBytes": 12394496,
"scriptDurationMs": 68.946,
"eventListeners": -168,
"totalBlockingTimeMs": 535,
"frameDurationMs": 32.45526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.820000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 931.47,
"heapDeltaBytes": -13087896,
"heapUsedBytes": 103225452,
"domNodes": -230,
"jsHeapTotalBytes": 16326656,
"scriptDurationMs": 71.10299999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 545,
"frameDurationMs": 33.33243243243241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 827.6290000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.9580000000001,
"heapDeltaBytes": -3727988,
"heapUsedBytes": 98010144,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.26899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 210,
"frameDurationMs": 24.508823529411742,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.2209999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.3099999999998,
"heapDeltaBytes": -3371184,
"heapUsedBytes": 94421208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.60599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11042.075000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10162.948,
"heapDeltaBytes": 30399292,
"heapUsedBytes": 151956844,
"domNodes": -276,
"jsHeapTotalBytes": 42795008,
"scriptDurationMs": 8168.366000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1099,
"frameDurationMs": 31.704022988505752,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9650.019999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8800.339,
"heapDeltaBytes": 15039972,
"heapUsedBytes": 136349100,
"domNodes": -276,
"jsHeapTotalBytes": 27852800,
"scriptDurationMs": 7330.84,
"eventListeners": -130,
"totalBlockingTimeMs": 973,
"frameDurationMs": 31.84686468646865,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9732.394999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8949.807,
"heapDeltaBytes": 21203440,
"heapUsedBytes": 144281564,
"domNodes": -276,
"jsHeapTotalBytes": 30814208,
"scriptDurationMs": 7188.706,
"eventListeners": -130,
"totalBlockingTimeMs": 707,
"frameDurationMs": 31.29549839228296,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10093.96799999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04900000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9368.228000000001,
"heapDeltaBytes": -1819200,
"heapUsedBytes": 119156932,
"domNodes": -276,
"jsHeapTotalBytes": 6094848,
"scriptDurationMs": 7585.303,
"eventListeners": -130,
"totalBlockingTimeMs": 888,
"frameDurationMs": 31.075692307692307,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 215.139999999991,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.559000000000001,
"layouts": 11,
"layoutDurationMs": 3.012,
"taskDurationMs": 159.385,
"heapDeltaBytes": 13230152,
"heapUsedBytes": 115726760,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.962999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.659999999999947,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 294.14800000000696,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.464999999999998,
"layouts": 11,
"layoutDurationMs": 3.267,
"taskDurationMs": 240.539,
"heapDeltaBytes": 15635972,
"heapUsedBytes": 117910388,
"domNodes": 917,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.296999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 4,
"frameDurationMs": 21.10666666666663,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2040.7810000000097,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2659999999999996,
"layouts": 8,
"layoutDurationMs": 2.156,
"taskDurationMs": 475.116,
"heapDeltaBytes": 1515492,
"heapUsedBytes": 107158868,
"domNodes": -297,
"jsHeapTotalBytes": -720896,
"scriptDurationMs": 32.99700000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.954000000066,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6290000000000004,
"layouts": 9,
"layoutDurationMs": 2.675,
"taskDurationMs": 647.2000000000002,
"heapDeltaBytes": 787084,
"heapUsedBytes": 106722076,
"domNodes": -296,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 31.565999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2550.0729999999976,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.316,
"layouts": 5,
"layoutDurationMs": 1.394,
"taskDurationMs": 1713.8,
"heapDeltaBytes": 3322636,
"heapUsedBytes": 108646664,
"domNodes": -296,
"jsHeapTotalBytes": -1036288,
"scriptDurationMs": 804.2760000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775657894736838,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2212.0870000001105,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.125,
"layouts": 7,
"layoutDurationMs": 1.7519999999999998,
"taskDurationMs": 1474.2620000000002,
"heapDeltaBytes": 4992696,
"heapUsedBytes": 111957408,
"domNodes": -296,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 793.825,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665151515151518,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3518.0630000000406,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.987000000000002,
"layouts": 65,
"layoutDurationMs": 10.472,
"taskDurationMs": 1547.918,
"heapDeltaBytes": 9412004,
"heapUsedBytes": 117579164,
"domNodes": 24,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 764.308,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3473.176999999964,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.502,
"layouts": 64,
"layoutDurationMs": 10.304,
"taskDurationMs": 1576.59,
"heapDeltaBytes": 77800,
"heapUsedBytes": 110989952,
"domNodes": -272,
"jsHeapTotalBytes": -774144,
"scriptDurationMs": 772.46,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665865384615383,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2928.3829999999966,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.321,
"layouts": 6,
"layoutDurationMs": 1.5040000000000002,
"taskDurationMs": 1903.734,
"heapDeltaBytes": -8625504,
"heapUsedBytes": 103677628,
"domNodes": 0,
"jsHeapTotalBytes": 5771264,
"scriptDurationMs": 928.989,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.761714285714287,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2678.867000000082,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.869999999999999,
"layouts": 5,
"layoutDurationMs": 1.3309999999999997,
"taskDurationMs": 1700.0249999999999,
"heapDeltaBytes": -5540412,
"heapUsedBytes": 104162036,
"domNodes": 0,
"jsHeapTotalBytes": 5509120,
"scriptDurationMs": 927.05,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.984076433121018,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.3889999999947,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3379999999999996,
"layouts": 7,
"layoutDurationMs": 2.2030000000000003,
"taskDurationMs": 460.4180000000001,
"heapDeltaBytes": 261552,
"heapUsedBytes": 102793944,
"domNodes": -296,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 30.393000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.099000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.02,
"layouts": 7,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 472.831,
"heapDeltaBytes": 176520,
"heapUsedBytes": 103041992,
"domNodes": -306,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 30.59,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.8320000000049,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.805000000000001,
"layouts": 10,
"layoutDurationMs": 2.693,
"taskDurationMs": 374.81,
"heapDeltaBytes": 22415360,
"heapUsedBytes": 112499580,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 146.817,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 549.252000000024,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.152,
"layouts": 10,
"layoutDurationMs": 2.5789999999999997,
"taskDurationMs": 383.161,
"heapDeltaBytes": 1985960,
"heapUsedBytes": 102927116,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 145.434,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.6100000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.351,
"layouts": 9,
"layoutDurationMs": 2.2510000000000003,
"taskDurationMs": 563.702,
"heapDeltaBytes": 3353124,
"heapUsedBytes": 92900484,
"domNodes": -198,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 7.517000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2043.2900000000132,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4479999999999995,
"layouts": 9,
"layoutDurationMs": 2.4879999999999995,
"taskDurationMs": 403.503,
"heapDeltaBytes": 1068900,
"heapUsedBytes": 91226904,
"domNodes": -218,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 7.495000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1736.3829999999894,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.603,
"layouts": 8,
"layoutDurationMs": 2.083,
"taskDurationMs": 877.7649999999999,
"heapDeltaBytes": -4302956,
"heapUsedBytes": 84764260,
"domNodes": -210,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 108.96799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.8649999999893,
"styleRecalcs": 85,
"styleRecalcDurationMs": 14.143999999999998,
"layouts": 10,
"layoutDurationMs": 2.2380000000000004,
"taskDurationMs": 928.955,
"heapDeltaBytes": -1643840,
"heapUsedBytes": 88732904,
"domNodes": -210,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 108.992,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666386554621848,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.629999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.851000000000006,
"layouts": 5,
"layoutDurationMs": 16.747,
"taskDurationMs": 1058.338,
"heapDeltaBytes": 41009272,
"heapUsedBytes": 195041624,
"domNodes": 16030,
"jsHeapTotalBytes": 42082304,
"scriptDurationMs": 29.866000000000003,
"eventListeners": 3244,
"totalBlockingTimeMs": 153,
"frameDurationMs": 19.263636363636355,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9506.362000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.494000000000003,
"layouts": 8,
"layoutDurationMs": 2.1159999999999997,
"taskDurationMs": 5937.888,
"heapDeltaBytes": 2552676,
"heapUsedBytes": 104029644,
"domNodes": -296,
"jsHeapTotalBytes": -528384,
"scriptDurationMs": 2650.48,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75414462081129,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9349.015000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.728999999999996,
"layouts": 8,
"layoutDurationMs": 1.9100000000000001,
"taskDurationMs": 5892.69,
"heapDeltaBytes": 5526756,
"heapUsedBytes": 113643880,
"domNodes": -297,
"jsHeapTotalBytes": -1470464,
"scriptDurationMs": 2665.08,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22695.34500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21784.618000000002,
"heapDeltaBytes": 4548012,
"heapUsedBytes": 309773396,
"domNodes": -3344,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 309.899,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.83972602739726,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22631.14399999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21709.900999999998,
"heapDeltaBytes": -49909760,
"heapUsedBytes": 279647308,
"domNodes": -3344,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 291.19800000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.02137931034483,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27610.21199999999,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.628000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27178.767,
"heapDeltaBytes": -5664284,
"heapUsedBytes": 304721240,
"domNodes": -3344,
"jsHeapTotalBytes": 10665984,
"scriptDurationMs": 859.8,
"eventListeners": -651,
"totalBlockingTimeMs": 35,
"frameDurationMs": 51.90902255639097,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27853.136999999948,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.41499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27485.901,
"heapDeltaBytes": -17124796,
"heapUsedBytes": 303100476,
"domNodes": -3344,
"jsHeapTotalBytes": 7782400,
"scriptDurationMs": 857.827,
"eventListeners": -651,
"totalBlockingTimeMs": 36,
"frameDurationMs": 52.08504672897197,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 5754.742000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.787000000000006,
"layouts": 20,
"layoutDurationMs": 21.500000000000004,
"taskDurationMs": 5599.446999999999,
"heapDeltaBytes": -7158440,
"heapUsedBytes": 297810516,
"domNodes": -3344,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 92.549,
"eventListeners": -653,
"totalBlockingTimeMs": 17,
"frameDurationMs": 32.76363636363636,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 8046.448000000055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.22799999999998,
"layouts": 20,
"layoutDurationMs": 22.003999999999984,
"taskDurationMs": 7920.7970000000005,
"heapDeltaBytes": -51044076,
"heapUsedBytes": 278185800,
"domNodes": -3344,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 119.22500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.729585798816565,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7575.02599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7242.945000000001,
"heapDeltaBytes": -7910796,
"heapUsedBytes": 276070908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.11000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.823549488054606,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7508.605999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7206.129999999998,
"heapDeltaBytes": -8723704,
"heapUsedBytes": 262378620,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.92299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.772164948453597,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 116.94499999998698,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.513,
"layouts": 8,
"layoutDurationMs": 3.3879999999999995,
"taskDurationMs": 82.395,
"heapDeltaBytes": 4836196,
"heapUsedBytes": 95687292,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.353000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 122.27699999994002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.417,
"layouts": 9,
"layoutDurationMs": 3.734,
"taskDurationMs": 96.613,
"heapDeltaBytes": -21259100,
"heapUsedBytes": 88820544,
"domNodes": 117,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.075000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 370.1939999999695,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6769999999999999,
"layouts": 76,
"layoutDurationMs": 13.215,
"taskDurationMs": 316.963,
"heapDeltaBytes": -15755440,
"heapUsedBytes": 79496912,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 145.55,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 430.7569999999714,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.669,
"layouts": 76,
"layoutDurationMs": 13.994,
"taskDurationMs": 396.02400000000006,
"heapDeltaBytes": -14920352,
"heapUsedBytes": 80533852,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 191.08700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 541.2410000000136,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.443,
"layouts": 76,
"layoutDurationMs": 12.902000000000001,
"taskDurationMs": 494.47999999999996,
"heapDeltaBytes": 28924336,
"heapUsedBytes": 132338912,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 206.735,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 447.50699999997323,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.588,
"layouts": 76,
"layoutDurationMs": 12.656,
"taskDurationMs": 409.011,
"heapDeltaBytes": -338096,
"heapUsedBytes": 115086896,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 159.559,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 63.6% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2994 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bf29c9a83bdc776ac7543a5bd78d24dfda8132f0
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (145)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
Ran the adapted e2e locally against a Cloud build of this branch ( |
dante01yoon
left a comment
There was a problem hiding this comment.
Approving backport of #22514.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #22685 +/- ##
=============================================
Coverage ? 84.25%
=============================================
Files ? 3173
Lines ? 165690
Branches ? 39131
=============================================
Hits ? 139610
Misses ? 25689
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…dits line (#22689) Follow-up to #22685 (cloud/1.58 backport of #22514), which auto-merged at its approved head before this commit reached it. **Problem.** On cloud/1.58 the locked-credits line picks subscribe or resubscribe wording from `subscriptionStatus === 'ended'`. That is not the fact `main` uses (`subscriptionState`). A lapsed legacy subscriber reads `canceled` there (legacy billing sets it on the client from `isCancelled`), so they are told "Subscribe" instead of "Resubscribe". Found by an independent review of #22685; the server-facts gate (ADR 0042) also rejects deriving the state from `subscriptionStatus`. **Fix.** The API already sends `subscription_state` on this branch. Expose it on the billing context as `main` does (types, legacy and workspace adapters, `__mocks__`, storybook mock), and make `CreditsLockedNotice` identical to `main`. No other behaviour changes; nothing reads the new field except the notice. **Tests.** New `useBillingContext` passthrough test, seen failing before the change. `CreditsLockedNotice` test is the `main` version (`never_subscribed`, `ended`, unknown). Local: `pnpm typecheck` clean; vitest on `src/composables/billing`, `src/platform/workspace`, `src/platform/cloud`, `src/scripts/app.test.ts`, `src/platform/errorCatalog`: 205 files, 5025 passed. Cloud 1.58 only: `main` and cloud/1.59 already read `subscriptionState`. Related: https://linear.app/comfyorg/issue/FRONT-3662, https://linear.app/comfyorg/issue/PM-2273
Backport of #22514 to
cloud/1.58, the branch production Cloud serves.Manual: the automatic backport conflicted, and this branch differs from
mainin ways a plain cherry-pick cannot carry.Adaptations:
src/platform/cloud/subscription,src/platform/workspaceandsrc/composables/billinghere.CreditsLockedNoticegoes insrc/platform/workspace/components.subscriptionState: this branch'sBillingContextdid not expose it, although the API already sendssubscription_state. The third commit exposes it on the legacy and workspace adapters and the mocks, asmaindoes, soCreditsLockedNoticeis identical tomain. (An earlier version keyed onsubscriptionStatus; an independent review found that a lapsed legacy subscriber readscanceledthere and would get the subscribe line, and the server-facts gate rejects deriving it.)credits.topUp.planRequiredSubscribeandplanRequiredResubscribeare not on this branch (they came with FE-3557 feat(billing): say a Cloud plan is required to run workflows #21766 and FE-3593 fix(billing): show the plan-required Add credits line only when it applies #21835). The second commit copies both keys, in every locale, verbatim fromcloud/1.59, so the notice shows text and not a raw key. No other copy from those PRs comes along.expectRegionScreenshothelper and themainbaseline would not match, so the spec asserts the line inside the dialog by exact text and drops the region screenshot.mainand thecloud/1.59backport ([backport cloud/1.59] fix(billing): say why bought credits did not unlock a refused Cloud run #22684) keep the snapshot.Checked locally on this branch:
pnpm typecheckand the pre-commit browser-test typecheck clean; vitest onsrc/composables/billing,src/platform/workspace,src/platform/cloud,src/scripts/app.test.tsandsrc/platform/errorCatalog: 205 files, 5025 passed. New passthrough test seen failing before the plumbing. The adapted e2e passed against a local Cloud build (see comment).Fixes https://linear.app/comfyorg/issue/FRONT-3662 on Cloud 1.58. Related: https://linear.app/comfyorg/issue/PM-2273