Skip to content

[backport cloud/1.58] fix(billing): say why bought credits did not unlock a refused Cloud run - #22685

Merged
comfy-pr-bot merged 2 commits into
cloud/1.58from
backport-22514-to-cloud-1.58
Nov 2, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.58from
backport-22514-to-cloud-1.58

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #22514 to cloud/1.58, the branch production Cloud serves.

Manual: the automatic backport conflicted, and this branch differs from main in ways a plain cherry-pick cannot carry.

Adaptations:

  • Paths: billing code lives under src/platform/cloud/subscription, src/platform/workspace and src/composables/billing here. CreditsLockedNotice goes in src/platform/workspace/components.
  • subscriptionState: this branch's BillingContext did not expose it, although the API already sends subscription_state. The third commit exposes it on the legacy and workspace adapters and the mocks, as main does, so CreditsLockedNotice is identical to main. (An earlier version keyed on subscriptionStatus; an independent review found that a lapsed legacy subscriber reads canceled there and would get the subscribe line, and the server-facts gate rejects deriving it.)
  • Copy: credits.topUp.planRequiredSubscribe and planRequiredResubscribe are not on this branch (they came with FE-3557 feat(billing): say a Cloud plan is required to run workflows #21766 and FE-3593 fix(billing): show the plan-required Add credits line only when it applies #21835). The second commit copies both keys, in every locale, verbatim from cloud/1.59, so the notice shows text and not a raw key. No other copy from those PRs comes along.
  • E2E: this branch has no expectRegionScreenshot helper and the main baseline would not match, so the spec asserts the line inside the dialog by exact text and drops the region screenshot. main and the cloud/1.59 backport ([backport cloud/1.59] fix(billing): say why bought credits did not unlock a refused Cloud run #22684) keep the snapshot.

Checked locally on this branch: pnpm typecheck and the pre-commit browser-test typecheck clean; vitest on src/composables/billing, src/platform/workspace, src/platform/cloud, src/scripts/app.test.ts and src/platform/errorCatalog: 205 files, 5025 passed. New passthrough test seen failing before the plumbing. The adapted e2e passed against a local Cloud build (see comment).

Fixes https://linear.app/comfyorg/issue/FRONT-3662 on Cloud 1.58. Related: https://linear.app/comfyorg/issue/PM-2273

…lock a refused Cloud run (#22514)

## Summary

A free Cloud account that holds credits gets `402
CLOUD_SUBSCRIPTION_REQUIRED` with `credits_locked: true` when it presses
Run. Since #21592 that opens the subscribe dialog, but the dialog
dropped the fact, so someone who just bought credits was never told why
they did not help. This shows the already approved plan-required line in
the dialog.

- Fixes https://linear.app/comfyorg/issue/FRONT-3662
- Related: https://linear.app/comfyorg/issue/PM-2273,
https://linear.app/comfyorg/issue/BE-20863

## Changes

- `promptErrorHasLockedCredits` reads the raw refusal.
`normalizePromptError` keeps its shape.
- `creditsLocked` travels through `useAccountPreconditionDialog`,
`showSubscriptionRequiredDialog` and `useSubscriptionDialog` into all
three dialog contents (unified, legacy team, legacy personal).
- New `CreditsLockedNotice` reuses
`credits.topUp.planRequiredSubscribe`, or `planRequiredResubscribe` when
`subscription_state` is `ended`. No new copy, so no new translations.
Unified and legacy team show it on the pricing step only.
- `modal_opened` gains `refusal_type` (the server `error.type`).
`reason` stays `subscription_required` so existing funnels keep working.
- Small refactor in `showPricingTable`: one shared props object, because
the audit gate flagged the extra optional reads.

## Screenshot

Mocked 402 on the Cloud build, real Run button, new line under the
title:

![locked credits
line](https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/faeb2fd5f0efdb2ad636ffbf827fe1da911b8ea7/browser_tests/tests/cloudCreditsLockedRefusal.spec.ts-snapshots/credits-locked-subscribe-dialog-cloud-linux.png)

## Tests

- Unit, red first: refusal parsing, routing, `app.queuePrompt`, each
dialog variant, resubscribe versus subscribe line.
- Cloud e2e
`browser_tests/tests/billing/cloudCreditsLockedRefusal.spec.ts` with a
snapshot: `credits_locked: true` shows the line, `false` does not.
Passed locally against a served Cloud build and in CI. Baseline
regenerated through the CI expectations workflow.

## Known limit

An account whose billing reads inactive never reaches the server:
`blockRunWithoutSubscription` opens the dialog with reason
`subscribe_to_run` and no refusal, so no line shows there. Only a
refusal says the credits are locked.

The resumed dialog drops the line for the same reason. `onChooseTeam`
sends the user to the team-workspace flow and `resumePendingPricingFlow`
reopens pricing from a session marker, with no refusal in hand to
re-read.

Backport: cloud trains only, this has no effect off Cloud.

cloud/1.58 adaptation: CreditsLockedNotice lives in
src/platform/workspace/components and reads subscriptionStatus === 'ended',
because this branch's BillingContext has no subscriptionState. The e2e
asserts the line inside the dialog by text instead of a region
screenshot: this branch has no expectRegionScreenshot helper, and the
main baseline would not match this branch's dialog.

(cherry picked from commit 834cce9)
CreditsLockedNotice reads credits.topUp.planRequiredSubscribe and
planRequiredResubscribe. Those keys reached main and cloud/1.59 with
#21766 and #21835, which are not on cloud/1.58. Copy both keys, in every
locale, verbatim from cloud/1.59 so the notice shows text, not a raw key.
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Nov 2, 2026
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.3 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.6 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.7 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
dom-widget-order-dense-n200-w200-i120: 30.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 540ms TBT · 98.3 MB heap
dom-widget-order-sparse-n1000-w20-i120: 40.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 214ms TBT · 91.8 MB heap
extension-clean-combined-draw: 31.5 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1036ms TBT · 137.5 MB heap
extension-rgthree-prototype-draw: 32.1 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 798ms TBT · 125.6 MB heap
large-combo-open: 46.8 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 2ms TBT · 111.4 MB heap
large-graph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.0 MB heap
large-graph-pan: 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.2 MB heap
large-graph-zoom: 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 109.0 MB heap
legacy-node-drag: 59.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.1 MB heap
minimap-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.2 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.7 MB heap
subgraph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.8 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
subgraph-transition-enter: 51.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 153ms TBT · 186.0 MB heap
viewport-pan-sweep: 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.8 MB heap
vue-large-graph-idle: 25.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 281.1 MB heap
vue-large-graph-pan: 19.2 avg FPS · 8.6 P5 FPS ❌ (target: ≥52) · 36ms TBT · 289.8 MB heap
vue-node-resize-workload: 24.8 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 9ms TBT · 274.7 MB heap
vue-zoom-out-idle: 38.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 256.8 MB heap
workflow-execution: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.0 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
agent-composer-long-conversation-typing: 59.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 118.0 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 406ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 88.3 MB
canvas-idle: DOM nodes -190
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 789ms
canvas-mouse-sweep: script duration 159ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 101.6 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 369ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 105.7 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 473ms
dom-widget-clipping: script duration 169ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.9 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 928ms
dom-widget-order-dense-n200-w200-i120: script duration 70ms
dom-widget-order-dense-n200-w200-i120: TBT 540ms
dom-widget-order-dense-n200-w200-i120: heap used 98.3 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -230
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 441ms
dom-widget-order-sparse-n1000-w20-i120: script duration 155ms
dom-widget-order-sparse-n1000-w20-i120: TBT 214ms
dom-widget-order-sparse-n1000-w20-i120: heap used 91.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9482ms
extension-clean-combined-draw: script duration 7750ms
extension-clean-combined-draw: TBT 1036ms
extension-clean-combined-draw: heap used 137.5 MB
extension-clean-combined-draw: DOM nodes -276
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 31ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 9159ms
extension-rgthree-prototype-draw: script duration 7387ms
extension-rgthree-prototype-draw: TBT 798ms
extension-rgthree-prototype-draw: heap used 125.6 MB
extension-rgthree-prototype-draw: DOM nodes -276
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 67ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 11
large-combo-open: style recalc count 26
large-combo-open: task duration 200ms
large-combo-open: script duration 9ms
large-combo-open: TBT 2ms
large-combo-open: heap used 111.4 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 9
large-graph-idle: task duration 561ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 102.0 MB
large-graph-idle: DOM nodes -297
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 6
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1594ms
large-graph-pan: script duration 799ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 105.2 MB
large-graph-pan: DOM nodes -296
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 65
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1562ms
large-graph-zoom: script duration 768ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 109.0 MB
large-graph-zoom: DOM nodes -124
large-graph-zoom: event listeners -65
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 6
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1802ms
legacy-node-drag: script duration 928ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 99.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 7
minimap-idle: style recalc count 8
minimap-idle: task duration 467ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 98.2 MB
minimap-idle: DOM nodes -301
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 379ms
subgraph-dom-widget-clipping: script duration 146ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 102.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 9
subgraph-idle: task duration 484ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 87.8 MB
subgraph-idle: DOM nodes -208
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 9
subgraph-mouse-sweep: style recalc count 81
subgraph-mouse-sweep: task duration 903ms
subgraph-mouse-sweep: script duration 109ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 82.7 MB
subgraph-mouse-sweep: DOM nodes -210
subgraph-mouse-sweep: event listeners -174
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 1058ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 153ms
subgraph-transition-enter: heap used 186.0 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 28ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5915ms
viewport-pan-sweep: script duration 2658ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 103.8 MB
viewport-pan-sweep: DOM nodes -297
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 39ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 21747ms
vue-large-graph-idle: script duration 301ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 281.1 MB
vue-large-graph-idle: DOM nodes -3344
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 52ms
vue-large-graph-pan: p95 frame time 117ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 27332ms
vue-large-graph-pan: script duration 859ms
vue-large-graph-pan: TBT 36ms
vue-large-graph-pan: heap used 289.8 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 40ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 65ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6760ms
vue-node-resize-workload: script duration 106ms
vue-node-resize-workload: TBT 9ms
vue-node-resize-workload: heap used 274.7 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 26ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7225ms
vue-zoom-out-idle: script duration 104ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 256.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 9ms
workflow-execution: layout count 9
workflow-execution: style recalc count 9
workflow-execution: task duration 90ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 88.0 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 14ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 356ms
agent-composer-empty-conversation-typing: script duration 168ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 76.3 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 13ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 452ms
agent-composer-long-conversation-typing: script duration 183ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 118.0 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-11-02T02:08:07.790Z",
  "gitSha": "29057894c3d9d61ae6f209335537b4db5d2f2db4",
  "branch": "backport-22514-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2037.639999999982,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.797,
      "layouts": 10,
      "layoutDurationMs": 2.7140000000000004,
      "taskDurationMs": 409.30899999999997,
      "heapDeltaBytes": 1262392,
      "heapUsedBytes": 89186720,
      "domNodes": -200,
      "jsHeapTotalBytes": -3342336,
      "scriptDurationMs": 8.497000000000002,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.3599999999683,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.5850000000000004,
      "layouts": 9,
      "layoutDurationMs": 2.626,
      "taskDurationMs": 403.02000000000004,
      "heapDeltaBytes": 7981300,
      "heapUsedBytes": 95931068,
      "domNodes": -180,
      "jsHeapTotalBytes": -3604480,
      "scriptDurationMs": 7.785,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1725.8579999999881,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 12.095,
      "layouts": 10,
      "layoutDurationMs": 2.6189999999999998,
      "taskDurationMs": 871.169,
      "heapDeltaBytes": -589432,
      "heapUsedBytes": 104059524,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 160.59599999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1692.0229999999492,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 12.392,
      "layouts": 10,
      "layoutDurationMs": 2.713,
      "taskDurationMs": 706.132,
      "heapDeltaBytes": 18723864,
      "heapUsedBytes": 108931932,
      "domNodes": 0,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 156.89700000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1704.569000000049,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.102,
      "layouts": 11,
      "layoutDurationMs": 2.886,
      "taskDurationMs": 280.408,
      "heapDeltaBytes": 21465056,
      "heapUsedBytes": 109476912,
      "domNodes": 47,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 9.516,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1807.3120000000245,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.49,
      "layouts": 11,
      "layoutDurationMs": 2.6320000000000006,
      "taskDurationMs": 457.811,
      "heapDeltaBytes": 21521392,
      "heapUsedBytes": 112223148,
      "domNodes": 47,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 9.827000000000002,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666055045871563,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 680.6119999999964,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.9439999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.7680000000000007,
      "taskDurationMs": 497.72499999999997,
      "heapDeltaBytes": 735980,
      "heapUsedBytes": 88121256,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 167.30499999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667499999999997,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 632.4710000000096,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.8859999999999997,
      "layouts": 9,
      "layoutDurationMs": 2.6300000000000003,
      "taskDurationMs": 448.29200000000003,
      "heapDeltaBytes": 219220,
      "heapUsedBytes": 87799772,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 170.018,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66216216216215,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1229.7489999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 925.333,
      "heapDeltaBytes": -8958648,
      "heapUsedBytes": 102826132,
      "domNodes": -230,
      "jsHeapTotalBytes": 12394496,
      "scriptDurationMs": 68.946,
      "eventListeners": -168,
      "totalBlockingTimeMs": 535,
      "frameDurationMs": 32.45526315789474,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1229.820000000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 931.47,
      "heapDeltaBytes": -13087896,
      "heapUsedBytes": 103225452,
      "domNodes": -230,
      "jsHeapTotalBytes": 16326656,
      "scriptDurationMs": 71.10299999999998,
      "eventListeners": -168,
      "totalBlockingTimeMs": 545,
      "frameDurationMs": 33.33243243243241,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 827.6290000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.9580000000001,
      "heapDeltaBytes": -3727988,
      "heapUsedBytes": 98010144,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 153.26899999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 210,
      "frameDurationMs": 24.508823529411742,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 847.2209999999905,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.3099999999998,
      "heapDeltaBytes": -3371184,
      "heapUsedBytes": 94421208,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 156.60599999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 218,
      "frameDurationMs": 24.99705882352943,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11042.075000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10162.948,
      "heapDeltaBytes": 30399292,
      "heapUsedBytes": 151956844,
      "domNodes": -276,
      "jsHeapTotalBytes": 42795008,
      "scriptDurationMs": 8168.366000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 1099,
      "frameDurationMs": 31.704022988505752,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9650.019999999984,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8800.339,
      "heapDeltaBytes": 15039972,
      "heapUsedBytes": 136349100,
      "domNodes": -276,
      "jsHeapTotalBytes": 27852800,
      "scriptDurationMs": 7330.84,
      "eventListeners": -130,
      "totalBlockingTimeMs": 973,
      "frameDurationMs": 31.84686468646865,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9732.394999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8949.807,
      "heapDeltaBytes": 21203440,
      "heapUsedBytes": 144281564,
      "domNodes": -276,
      "jsHeapTotalBytes": 30814208,
      "scriptDurationMs": 7188.706,
      "eventListeners": -130,
      "totalBlockingTimeMs": 707,
      "frameDurationMs": 31.29549839228296,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10093.96799999996,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.04900000000000043,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9368.228000000001,
      "heapDeltaBytes": -1819200,
      "heapUsedBytes": 119156932,
      "domNodes": -276,
      "jsHeapTotalBytes": 6094848,
      "scriptDurationMs": 7585.303,
      "eventListeners": -130,
      "totalBlockingTimeMs": 888,
      "frameDurationMs": 31.075692307692307,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 215.139999999991,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 13.559000000000001,
      "layouts": 11,
      "layoutDurationMs": 3.012,
      "taskDurationMs": 159.385,
      "heapDeltaBytes": 13230152,
      "heapUsedBytes": 115726760,
      "domNodes": 917,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.962999999999999,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.659999999999947,
      "p95FrameDurationMs": 66.59999999999945
    },
    {
      "name": "large-combo-open",
      "durationMs": 294.14800000000696,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 14.464999999999998,
      "layouts": 11,
      "layoutDurationMs": 3.267,
      "taskDurationMs": 240.539,
      "heapDeltaBytes": 15635972,
      "heapUsedBytes": 117910388,
      "domNodes": 917,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 9.296999999999999,
      "eventListeners": 196,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 21.10666666666663,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.7810000000097,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.2659999999999996,
      "layouts": 8,
      "layoutDurationMs": 2.156,
      "taskDurationMs": 475.116,
      "heapDeltaBytes": 1515492,
      "heapUsedBytes": 107158868,
      "domNodes": -297,
      "jsHeapTotalBytes": -720896,
      "scriptDurationMs": 32.99700000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.954000000066,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.6290000000000004,
      "layouts": 9,
      "layoutDurationMs": 2.675,
      "taskDurationMs": 647.2000000000002,
      "heapDeltaBytes": 787084,
      "heapUsedBytes": 106722076,
      "domNodes": -296,
      "jsHeapTotalBytes": -1245184,
      "scriptDurationMs": 31.565999999999995,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2550.0729999999976,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 8.316,
      "layouts": 5,
      "layoutDurationMs": 1.394,
      "taskDurationMs": 1713.8,
      "heapDeltaBytes": 3322636,
      "heapUsedBytes": 108646664,
      "domNodes": -296,
      "jsHeapTotalBytes": -1036288,
      "scriptDurationMs": 804.2760000000001,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.775657894736838,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2212.0870000001105,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 8.125,
      "layouts": 7,
      "layoutDurationMs": 1.7519999999999998,
      "taskDurationMs": 1474.2620000000002,
      "heapDeltaBytes": 4992696,
      "heapUsedBytes": 111957408,
      "domNodes": -296,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 793.825,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665151515151518,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3518.0630000000406,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 9.987000000000002,
      "layouts": 65,
      "layoutDurationMs": 10.472,
      "taskDurationMs": 1547.918,
      "heapDeltaBytes": 9412004,
      "heapUsedBytes": 117579164,
      "domNodes": 24,
      "jsHeapTotalBytes": 5771264,
      "scriptDurationMs": 764.308,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.74571428571429,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3473.176999999964,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.502,
      "layouts": 64,
      "layoutDurationMs": 10.304,
      "taskDurationMs": 1576.59,
      "heapDeltaBytes": 77800,
      "heapUsedBytes": 110989952,
      "domNodes": -272,
      "jsHeapTotalBytes": -774144,
      "scriptDurationMs": 772.46,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665865384615383,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2928.3829999999966,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 5.321,
      "layouts": 6,
      "layoutDurationMs": 1.5040000000000002,
      "taskDurationMs": 1903.734,
      "heapDeltaBytes": -8625504,
      "heapUsedBytes": 103677628,
      "domNodes": 0,
      "jsHeapTotalBytes": 5771264,
      "scriptDurationMs": 928.989,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.761714285714287,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2678.867000000082,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.869999999999999,
      "layouts": 5,
      "layoutDurationMs": 1.3309999999999997,
      "taskDurationMs": 1700.0249999999999,
      "heapDeltaBytes": -5540412,
      "heapUsedBytes": 104162036,
      "domNodes": 0,
      "jsHeapTotalBytes": 5509120,
      "scriptDurationMs": 927.05,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.984076433121018,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2026.3889999999947,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.3379999999999996,
      "layouts": 7,
      "layoutDurationMs": 2.2030000000000003,
      "taskDurationMs": 460.4180000000001,
      "heapDeltaBytes": 261552,
      "heapUsedBytes": 102793944,
      "domNodes": -296,
      "jsHeapTotalBytes": -1507328,
      "scriptDurationMs": 30.393000000000004,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.099000000003,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.02,
      "layouts": 7,
      "layoutDurationMs": 1.8370000000000002,
      "taskDurationMs": 472.831,
      "heapDeltaBytes": 176520,
      "heapUsedBytes": 103041992,
      "domNodes": -306,
      "jsHeapTotalBytes": -1769472,
      "scriptDurationMs": 30.59,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 560.8320000000049,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.805000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.693,
      "taskDurationMs": 374.81,
      "heapDeltaBytes": 22415360,
      "heapUsedBytes": 112499580,
      "domNodes": 0,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 146.817,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823537,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 549.252000000024,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.152,
      "layouts": 10,
      "layoutDurationMs": 2.5789999999999997,
      "taskDurationMs": 383.161,
      "heapDeltaBytes": 1985960,
      "heapUsedBytes": 102927116,
      "domNodes": 0,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 145.434,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636353,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2055.6100000000015,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.351,
      "layouts": 9,
      "layoutDurationMs": 2.2510000000000003,
      "taskDurationMs": 563.702,
      "heapDeltaBytes": 3353124,
      "heapUsedBytes": 92900484,
      "domNodes": -198,
      "jsHeapTotalBytes": -2818048,
      "scriptDurationMs": 7.517000000000001,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2043.2900000000132,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.4479999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.4879999999999995,
      "taskDurationMs": 403.503,
      "heapDeltaBytes": 1068900,
      "heapUsedBytes": 91226904,
      "domNodes": -218,
      "jsHeapTotalBytes": -2818048,
      "scriptDurationMs": 7.495000000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1736.3829999999894,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 13.603,
      "layouts": 8,
      "layoutDurationMs": 2.083,
      "taskDurationMs": 877.7649999999999,
      "heapDeltaBytes": -4302956,
      "heapUsedBytes": 84764260,
      "domNodes": -210,
      "jsHeapTotalBytes": -1507328,
      "scriptDurationMs": 108.96799999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1973.8649999999893,
      "styleRecalcs": 85,
      "styleRecalcDurationMs": 14.143999999999998,
      "layouts": 10,
      "layoutDurationMs": 2.2380000000000004,
      "taskDurationMs": 928.955,
      "heapDeltaBytes": -1643840,
      "heapUsedBytes": 88732904,
      "domNodes": -210,
      "jsHeapTotalBytes": -3080192,
      "scriptDurationMs": 108.992,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666386554621848,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1468.629999999962,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.851000000000006,
      "layouts": 5,
      "layoutDurationMs": 16.747,
      "taskDurationMs": 1058.338,
      "heapDeltaBytes": 41009272,
      "heapUsedBytes": 195041624,
      "domNodes": 16030,
      "jsHeapTotalBytes": 42082304,
      "scriptDurationMs": 29.866000000000003,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 153,
      "frameDurationMs": 19.263636363636355,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9506.362000000025,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 28.494000000000003,
      "layouts": 8,
      "layoutDurationMs": 2.1159999999999997,
      "taskDurationMs": 5937.888,
      "heapDeltaBytes": 2552676,
      "heapUsedBytes": 104029644,
      "domNodes": -296,
      "jsHeapTotalBytes": -528384,
      "scriptDurationMs": 2650.48,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75414462081129,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9349.015000000009,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 27.728999999999996,
      "layouts": 8,
      "layoutDurationMs": 1.9100000000000001,
      "taskDurationMs": 5892.69,
      "heapDeltaBytes": 5526756,
      "heapUsedBytes": 113643880,
      "domNodes": -297,
      "jsHeapTotalBytes": -1470464,
      "scriptDurationMs": 2665.08,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665775401069517,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 22695.34500000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21784.618000000002,
      "heapDeltaBytes": 4548012,
      "heapUsedBytes": 309773396,
      "domNodes": -3344,
      "jsHeapTotalBytes": 11259904,
      "scriptDurationMs": 309.899,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.83972602739726,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 22631.14399999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21709.900999999998,
      "heapDeltaBytes": -49909760,
      "heapUsedBytes": 279647308,
      "domNodes": -3344,
      "jsHeapTotalBytes": 15192064,
      "scriptDurationMs": 291.19800000000004,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.02137931034483,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27610.21199999999,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.628000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27178.767,
      "heapDeltaBytes": -5664284,
      "heapUsedBytes": 304721240,
      "domNodes": -3344,
      "jsHeapTotalBytes": 10665984,
      "scriptDurationMs": 859.8,
      "eventListeners": -651,
      "totalBlockingTimeMs": 35,
      "frameDurationMs": 51.90902255639097,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27853.136999999948,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 18.41499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27485.901,
      "heapDeltaBytes": -17124796,
      "heapUsedBytes": 303100476,
      "domNodes": -3344,
      "jsHeapTotalBytes": 7782400,
      "scriptDurationMs": 857.827,
      "eventListeners": -651,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 52.08504672897197,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5754.742000000022,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.787000000000006,
      "layouts": 20,
      "layoutDurationMs": 21.500000000000004,
      "taskDurationMs": 5599.446999999999,
      "heapDeltaBytes": -7158440,
      "heapUsedBytes": 297810516,
      "domNodes": -3344,
      "jsHeapTotalBytes": 11259904,
      "scriptDurationMs": 92.549,
      "eventListeners": -653,
      "totalBlockingTimeMs": 17,
      "frameDurationMs": 32.76363636363636,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8046.448000000055,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 66.22799999999998,
      "layouts": 20,
      "layoutDurationMs": 22.003999999999984,
      "taskDurationMs": 7920.7970000000005,
      "heapDeltaBytes": -51044076,
      "heapUsedBytes": 278185800,
      "domNodes": -3344,
      "jsHeapTotalBytes": 15978496,
      "scriptDurationMs": 119.22500000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 47.729585798816565,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7575.02599999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7242.945000000001,
      "heapDeltaBytes": -7910796,
      "heapUsedBytes": 276070908,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 105.11000000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.823549488054606,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7508.605999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7206.129999999998,
      "heapDeltaBytes": -8723704,
      "heapUsedBytes": 262378620,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 101.92299999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.772164948453597,
      "p95FrameDurationMs": 50
    },
    {
      "name": "workflow-execution",
      "durationMs": 116.94499999998698,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.513,
      "layouts": 8,
      "layoutDurationMs": 3.3879999999999995,
      "taskDurationMs": 82.395,
      "heapDeltaBytes": 4836196,
      "heapUsedBytes": 95687292,
      "domNodes": 120,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.353000000000002,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.657142857142844,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 122.27699999994002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.417,
      "layouts": 9,
      "layoutDurationMs": 3.734,
      "taskDurationMs": 96.613,
      "heapDeltaBytes": -21259100,
      "heapUsedBytes": 88820544,
      "domNodes": 117,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 7.075000000000001,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428546,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 370.1939999999695,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6769999999999999,
      "layouts": 76,
      "layoutDurationMs": 13.215,
      "taskDurationMs": 316.963,
      "heapDeltaBytes": -15755440,
      "heapUsedBytes": 79496912,
      "domNodes": 4,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 145.55,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636382,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 430.7569999999714,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.669,
      "layouts": 76,
      "layoutDurationMs": 13.994,
      "taskDurationMs": 396.02400000000006,
      "heapDeltaBytes": -14920352,
      "heapUsedBytes": 80533852,
      "domNodes": 4,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 191.08700000000002,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 541.2410000000136,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.443,
      "layouts": 76,
      "layoutDurationMs": 12.902000000000001,
      "taskDurationMs": 494.47999999999996,
      "heapDeltaBytes": 28924336,
      "heapUsedBytes": 132338912,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 206.735,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.1875,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 447.50699999997323,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.588,
      "layouts": 76,
      "layoutDurationMs": 12.656,
      "taskDurationMs": 409.011,
      "heapDeltaBytes": -338096,
      "heapUsedBytes": 115086896,
      "domNodes": 4,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 159.559,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662962962962983,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage: 🟡 63.6% of lines

Coverage totals
Metric Covered Total Pct
Lines 57581 90494 63.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.7% 1172
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 314
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 312
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.9% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2994 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2288 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 677 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/02/2026, 01:57:33 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since bf29c9a83bdc776ac7543a5bd78d24dfda8132f0

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (145)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/workspaceApi.webSessionRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 95 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Ran the adapted e2e locally against a Cloud build of this branch (pnpm build:cloud at bdc6ad7, served by vite preview, mocked 402 with credits_locked): both cases pass. The Choose a Plan dialog shows "Buying credits doesn't start a Cloud plan. Subscribe to run workflows on Cloud." directly under the title, the same place as the screenshot in #22514; with credits_locked: false the line is absent.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving backport of #22514.

@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/scripts/app.ts 66.66% 1 Missing and 1 partial ⚠️
@@              Coverage Diff              @@
##             cloud/1.58   #22685   +/-   ##
=============================================
  Coverage              ?   84.25%           
=============================================
  Files                 ?     3173           
  Lines                 ?   165690           
  Branches              ?    39131           
=============================================
  Hits                  ?   139610           
  Misses                ?    25689           
  Partials              ?      391           
Flag Coverage Δ
e2e 63.84% <ø> (?)
unit 86.06% <94.11%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/components/SubscriptionRequiredDialogContent.vue 75.80% <100.00%> (ø)
...iption/composables/useAccountPreconditionDialog.ts 100.00% <100.00%> (ø)
.../subscription/composables/useSubscriptionDialog.ts 97.47% <100.00%> (ø)
...latform/errorCatalog/accountPreconditionRouting.ts 100.00% <100.00%> (ø)
.../telemetry/providers/cloud/GtmTelemetryProvider.ts 71.75% <ø> (ø)
src/platform/telemetry/types.ts 100.00% <ø> (ø)
...tform/workspace/components/CreditsLockedNotice.vue 100.00% <100.00%> (ø)
...nents/SubscriptionRequiredDialogContentUnified.vue 92.30% <100.00%> (ø)
...nts/SubscriptionRequiredDialogContentWorkspace.vue 100.00% <100.00%> (ø)
src/scripts/app.ts 87.80% <66.66%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit f7a13fb into cloud/1.58 Nov 2, 2026
147 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-22514-to-cloud-1.58 branch November 2, 2026 02:22
@christian-byrne

Copy link
Copy Markdown
Contributor Author

This auto-merged at bdc6ad7, before the follow-up commit that reads subscription_state (1fe4276) reached it. That commit is now #22689. What merged here works; the gap is wording only: a lapsed legacy subscriber whose status reads canceled sees the subscribe line instead of the resubscribe line.

christian-byrne added a commit that referenced this pull request Nov 2, 2026
…dits line (#22689)

Follow-up to #22685 (cloud/1.58 backport of #22514), which auto-merged
at its approved head before this commit reached it.

**Problem.** On cloud/1.58 the locked-credits line picks subscribe or
resubscribe wording from `subscriptionStatus === 'ended'`. That is not
the fact `main` uses (`subscriptionState`). A lapsed legacy subscriber
reads `canceled` there (legacy billing sets it on the client from
`isCancelled`), so they are told "Subscribe" instead of "Resubscribe".
Found by an independent review of #22685; the server-facts gate (ADR
0042) also rejects deriving the state from `subscriptionStatus`.

**Fix.** The API already sends `subscription_state` on this branch.
Expose it on the billing context as `main` does (types, legacy and
workspace adapters, `__mocks__`, storybook mock), and make
`CreditsLockedNotice` identical to `main`. No other behaviour changes;
nothing reads the new field except the notice.

**Tests.** New `useBillingContext` passthrough test, seen failing before
the change. `CreditsLockedNotice` test is the `main` version
(`never_subscribed`, `ended`, unknown). Local: `pnpm typecheck` clean;
vitest on `src/composables/billing`, `src/platform/workspace`,
`src/platform/cloud`, `src/scripts/app.test.ts`,
`src/platform/errorCatalog`: 205 files, 5025 passed.

Cloud 1.58 only: `main` and cloud/1.59 already read `subscriptionState`.
Related: https://linear.app/comfyorg/issue/FRONT-3662,
https://linear.app/comfyorg/issue/PM-2273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants