Repository navigation
[backport cloud/1.59] fix(billing): say why bought credits did not unlock a refused Cloud run - #22684
Conversation
…lock a refused Cloud run (#22514) A free Cloud account that holds credits gets `402 CLOUD_SUBSCRIPTION_REQUIRED` with `credits_locked: true` when it presses Run. Since #21592 that opens the subscribe dialog, but the dialog dropped the fact, so someone who just bought credits was never told why they did not help. This shows the already approved plan-required line in the dialog. - Fixes https://linear.app/comfyorg/issue/FRONT-3662 - Related: https://linear.app/comfyorg/issue/PM-2273, https://linear.app/comfyorg/issue/BE-20863 - `promptErrorHasLockedCredits` reads the raw refusal. `normalizePromptError` keeps its shape. - `creditsLocked` travels through `useAccountPreconditionDialog`, `showSubscriptionRequiredDialog` and `useSubscriptionDialog` into all three dialog contents (unified, legacy team, legacy personal). - New `CreditsLockedNotice` reuses `credits.topUp.planRequiredSubscribe`, or `planRequiredResubscribe` when `subscription_state` is `ended`. No new copy, so no new translations. Unified and legacy team show it on the pricing step only. - `modal_opened` gains `refusal_type` (the server `error.type`). `reason` stays `subscription_required` so existing funnels keep working. - Small refactor in `showPricingTable`: one shared props object, because the audit gate flagged the extra optional reads. Mocked 402 on the Cloud build, real Run button, new line under the title:  - Unit, red first: refusal parsing, routing, `app.queuePrompt`, each dialog variant, resubscribe versus subscribe line. - Cloud e2e `browser_tests/tests/billing/cloudCreditsLockedRefusal.spec.ts` with a snapshot: `credits_locked: true` shows the line, `false` does not. Passed locally against a served Cloud build and in CI. Baseline regenerated through the CI expectations workflow. An account whose billing reads inactive never reaches the server: `blockRunWithoutSubscription` opens the dialog with reason `subscribe_to_run` and no refusal, so no line shows there. Only a refusal says the credits are locked. The resumed dialog drops the line for the same reason. `onChooseTeam` sends the user to the team-workspace flow and `resumePendingPricingFlow` reopens pricing from a session marker, with no refusal in hand to re-read. Backport: cloud trains only, this has no effect off Cloud. (cherry picked from commit 834cce9)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-02T02:15:31.366Z",
"gitSha": "395a4b4b05fbebe1a37997f6266be07a91fb61c6",
"branch": "backport-22514-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.324000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.011,
"layouts": 9,
"layoutDurationMs": 2.2169999999999996,
"taskDurationMs": 459.18899999999996,
"heapDeltaBytes": 1739936,
"heapUsedBytes": 63821592,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.762,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2022.5719999999683,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2169999999999996,
"layouts": 10,
"layoutDurationMs": 2.416,
"taskDurationMs": 470.129,
"heapDeltaBytes": 1566720,
"heapUsedBytes": 63382592,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8.769000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.2160000000213,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.652999999999999,
"layouts": 8,
"layoutDurationMs": 1.8500000000000005,
"taskDurationMs": 734.879,
"heapDeltaBytes": 21770356,
"heapUsedBytes": 82640448,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 121.75800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.5769999999438,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.329,
"layouts": 10,
"layoutDurationMs": 2.302,
"taskDurationMs": 744.953,
"heapDeltaBytes": 17347536,
"heapUsedBytes": 78389576,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 126.187,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.5519999999933,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.34,
"layouts": 11,
"layoutDurationMs": 2.691,
"taskDurationMs": 361.09599999999995,
"heapDeltaBytes": 24137108,
"heapUsedBytes": 85608712,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 10.683000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.00000000007,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.9589999999999996,
"layouts": 10,
"layoutDurationMs": 2.5269999999999997,
"taskDurationMs": 347.714,
"heapDeltaBytes": -1214896,
"heapUsedBytes": 59961232,
"domNodes": 56,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 10.058000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 591.3449999999898,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.3630000000000004,
"layouts": 10,
"layoutDurationMs": 2.207,
"taskDurationMs": 433.13,
"heapDeltaBytes": 6062720,
"heapUsedBytes": 67438608,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 149.177,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 625.9370000000217,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.142,
"layouts": 9,
"layoutDurationMs": 2.05,
"taskDurationMs": 447.738,
"heapDeltaBytes": 3847964,
"heapUsedBytes": 65485228,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 151.605,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1132.5649999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 809.663,
"heapDeltaBytes": -12461100,
"heapUsedBytes": 75647676,
"domNodes": -191,
"jsHeapTotalBytes": 22028288,
"scriptDurationMs": 50.61,
"eventListeners": -107,
"totalBlockingTimeMs": 462,
"frameDurationMs": 31.48055555555556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1133.367999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.917,
"heapDeltaBytes": -2001808,
"heapUsedBytes": 75697372,
"domNodes": -191,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 48.793000000000006,
"eventListeners": -107,
"totalBlockingTimeMs": 462,
"frameDurationMs": 31.477777777777774,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 796.2190000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.9700000000002,
"heapDeltaBytes": -12246592,
"heapUsedBytes": 66526072,
"domNodes": -191,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 119.44700000000003,
"eventListeners": -107,
"totalBlockingTimeMs": 146,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 812.4839999999267,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.7950000000001,
"heapDeltaBytes": -24980164,
"heapUsedBytes": 66682512,
"domNodes": -191,
"jsHeapTotalBytes": 3014656,
"scriptDurationMs": 121.88399999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 147,
"frameDurationMs": 22.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8818.822000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7875.719999999999,
"heapDeltaBytes": 58859512,
"heapUsedBytes": 132669080,
"domNodes": -257,
"jsHeapTotalBytes": 53342208,
"scriptDurationMs": 5994.8820000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 138,
"frameDurationMs": 26.475675675675674,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8223.957000000042,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.22700000000000065,
"layouts": 1,
"layoutDurationMs": 0.22600000000000006,
"taskDurationMs": 7377.975,
"heapDeltaBytes": 65800892,
"heapUsedBytes": 140452000,
"domNodes": -257,
"jsHeapTotalBytes": 61992960,
"scriptDurationMs": 5655.818,
"eventListeners": -69,
"totalBlockingTimeMs": 73,
"frameDurationMs": 24.673573573573577,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8413.025000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7538.054000000001,
"heapDeltaBytes": -12356608,
"heapUsedBytes": 66778488,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 5795.996999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 138,
"frameDurationMs": 25.14850299401197,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8663.976999999932,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.19499999999999987,
"layouts": 1,
"layoutDurationMs": 0.255,
"taskDurationMs": 7773.616000000001,
"heapDeltaBytes": 73755332,
"heapUsedBytes": 147444060,
"domNodes": -257,
"jsHeapTotalBytes": 70381568,
"scriptDurationMs": 5991.703,
"eventListeners": -69,
"totalBlockingTimeMs": 129,
"frameDurationMs": 25.590532544378693,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 207.50100000003613,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.046,
"layouts": 10,
"layoutDurationMs": 3.028,
"taskDurationMs": 172.92600000000002,
"heapDeltaBytes": 14411252,
"heapUsedBytes": 90076376,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 7.927,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 209.37099999991915,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.213,
"layouts": 9,
"layoutDurationMs": 2.4920000000000004,
"taskDurationMs": 144.541,
"heapDeltaBytes": 14617100,
"heapUsedBytes": 70790620,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.925000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.79999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2024.2590000000291,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.824,
"layouts": 9,
"layoutDurationMs": 2.114,
"taskDurationMs": 564.196,
"heapDeltaBytes": -9488640,
"heapUsedBytes": 70587012,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 29.630999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.2680000000064,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.85,
"layouts": 9,
"layoutDurationMs": 1.9140000000000001,
"taskDurationMs": 574.242,
"heapDeltaBytes": -30611612,
"heapUsedBytes": 60833292,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 31.16,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2203.3440000000155,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.322,
"layouts": 8,
"layoutDurationMs": 1.653,
"taskDurationMs": 1493.96,
"heapDeltaBytes": -13678544,
"heapUsedBytes": 61595432,
"domNodes": -257,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 685.087,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2199.1819999999507,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.425,
"layouts": 5,
"layoutDurationMs": 1.0370000000000001,
"taskDurationMs": 1460.0779999999997,
"heapDeltaBytes": 8472780,
"heapUsedBytes": 85227552,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 671.742,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3372.8310000000192,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.422,
"layouts": 64,
"layoutDurationMs": 10.971,
"taskDurationMs": 1577.6080000000002,
"heapDeltaBytes": 589896,
"heapUsedBytes": 79322744,
"domNodes": -233,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 664.928,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665841584158414,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3388.5500000000093,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.784,
"layouts": 65,
"layoutDurationMs": 10.991000000000001,
"taskDurationMs": 1616.1339999999998,
"heapDeltaBytes": -1347728,
"heapUsedBytes": 79920796,
"domNodes": -233,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 671.01,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2649.5479999999816,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.983,
"layouts": 5,
"layoutDurationMs": 1.1340000000000001,
"taskDurationMs": 1711.0250000000003,
"heapDeltaBytes": 15023128,
"heapUsedBytes": 92241564,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 820.5910000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771974522292993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2540.28500000004,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.651,
"layouts": 6,
"layoutDurationMs": 1.268,
"taskDurationMs": 1639.0249999999996,
"heapDeltaBytes": 14559972,
"heapUsedBytes": 92812116,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 780.845,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776666666666664,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3005.6359999999813,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6710000000000007,
"layouts": 7,
"layoutDurationMs": 1.582,
"taskDurationMs": 735.373,
"heapDeltaBytes": 7807208,
"heapUsedBytes": 85769548,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 317.64,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666298342541438,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3071.0050000000138,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8050000000000002,
"layouts": 9,
"layoutDurationMs": 1.898,
"taskDurationMs": 711.634,
"heapDeltaBytes": -7839928,
"heapUsedBytes": 72315080,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 338.246,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.5210000000034,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7680000000000005,
"layouts": 8,
"layoutDurationMs": 1.8920000000000001,
"taskDurationMs": 558.5960000000001,
"heapDeltaBytes": 5800836,
"heapUsedBytes": 85796684,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.425999999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2048.0830000000196,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7339999999999995,
"layouts": 8,
"layoutDurationMs": 1.851,
"taskDurationMs": 561.2819999999999,
"heapDeltaBytes": -16946712,
"heapUsedBytes": 63750804,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.345000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2831.4399999999864,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.602000000000002,
"layouts": 9,
"layoutDurationMs": 2.125,
"taskDurationMs": 591.097,
"heapDeltaBytes": -6493844,
"heapUsedBytes": 72466460,
"domNodes": -253,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 169.405,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588235294118,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2996.469999999931,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.259000000000002,
"layouts": 7,
"layoutDurationMs": 1.496,
"taskDurationMs": 588.615,
"heapDeltaBytes": -6612040,
"heapUsedBytes": 71453204,
"domNodes": -254,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 165.209,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611111111111,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3210.3079999999977,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.4449999999999992,
"layouts": 7,
"layoutDurationMs": 1.469,
"taskDurationMs": 862.1889999999999,
"heapDeltaBytes": 2975924,
"heapUsedBytes": 78752964,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 339.02700000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3220.954000000006,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.4939999999999998,
"layouts": 7,
"layoutDurationMs": 1.6650000000000003,
"taskDurationMs": 874.2659999999998,
"heapDeltaBytes": -4847748,
"heapUsedBytes": 72124264,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 336.079,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666321243523313,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.4379999999628,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.34,
"layouts": 10,
"layoutDurationMs": 2.2659999999999996,
"taskDurationMs": 380.197,
"heapDeltaBytes": -1008024,
"heapUsedBytes": 61262172,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 122.42100000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.0150000000112,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.329000000000001,
"layouts": 10,
"layoutDurationMs": 2.4079999999999995,
"taskDurationMs": 381.69300000000004,
"heapDeltaBytes": 2534360,
"heapUsedBytes": 75939132,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 122.79899999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.7370000000064,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.234000000000001,
"layouts": 10,
"layoutDurationMs": 2.3680000000000003,
"taskDurationMs": 465.45899999999995,
"heapDeltaBytes": 3976080,
"heapUsedBytes": 65423496,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 8.191,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.7320000000327,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1810000000000005,
"layouts": 9,
"layoutDurationMs": 2.0480000000000005,
"taskDurationMs": 461.931,
"heapDeltaBytes": 1844740,
"heapUsedBytes": 64329320,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.386,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.1099999999765,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.245,
"layouts": 9,
"layoutDurationMs": 2.0709999999999997,
"taskDurationMs": 722.4050000000001,
"heapDeltaBytes": 17896748,
"heapUsedBytes": 80313668,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 91.887,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9849999999979,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.896,
"layouts": 9,
"layoutDurationMs": 2.0329999999999995,
"taskDurationMs": 743.637,
"heapDeltaBytes": 17461360,
"heapUsedBytes": 80335220,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 89.912,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2760000000526,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.698,
"layouts": 5,
"layoutDurationMs": 13.629999999999999,
"taskDurationMs": 898.4019999999999,
"heapDeltaBytes": 11991004,
"heapUsedBytes": 100149484,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 27.237000000000005,
"eventListeners": 3246,
"totalBlockingTimeMs": 149,
"frameDurationMs": 19.95352112676056,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8229.557,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.207,
"layouts": 7,
"layoutDurationMs": 1.5599999999999998,
"taskDurationMs": 5162.8150000000005,
"heapDeltaBytes": 3130956,
"heapUsedBytes": 80175040,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2289.634,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665922920892495,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8200.169999999958,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.098999999999997,
"layouts": 9,
"layoutDurationMs": 1.8800000000000001,
"taskDurationMs": 5077.331000000001,
"heapDeltaBytes": -5338800,
"heapUsedBytes": 71481544,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2240.087,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569104,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "vue-large-graph-idle",
"durationMs": 18880.499999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18020.93,
"heapDeltaBytes": -53435092,
"heapUsedBytes": 252396356,
"domNodes": -3343,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 308.30600000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.084863945578235,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 18768.921999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17926.547000000002,
"heapDeltaBytes": -15625264,
"heapUsedBytes": 276646144,
"domNodes": -3343,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 268.54499999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.13339041095891,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22578.971999999965,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.99000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22158.156,
"heapDeltaBytes": 6824932,
"heapUsedBytes": 284349672,
"domNodes": -3343,
"jsHeapTotalBytes": 10928128,
"scriptDurationMs": 841.5559999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.94386617100372,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22762.169000000085,
"styleRecalcs": 177,
"styleRecalcDurationMs": 20.784999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22424.543,
"heapDeltaBytes": 7077184,
"heapUsedBytes": 283602568,
"domNodes": -3343,
"jsHeapTotalBytes": 13029376,
"scriptDurationMs": 851.163,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 42.12796296296296,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6769.180000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.37300000000002,
"layouts": 20,
"layoutDurationMs": 23.419000000000008,
"taskDurationMs": 6668.489,
"heapDeltaBytes": -24149588,
"heapUsedBytes": 271956152,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 128.899,
"eventListeners": -653,
"totalBlockingTimeMs": 7,
"frameDurationMs": 40.51736526946108,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6719.694000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.71400000000001,
"layouts": 20,
"layoutDurationMs": 22.40600000000001,
"taskDurationMs": 6597.213000000001,
"heapDeltaBytes": -18376696,
"heapUsedBytes": 258269252,
"domNodes": -3343,
"jsHeapTotalBytes": 26206208,
"scriptDurationMs": 113.67199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.277192982456135,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9259.224000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8899.371999999998,
"heapDeltaBytes": -5331040,
"heapUsedBytes": 252136332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.33900000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.3993006993007,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9250.07599999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8812.319999999998,
"heapDeltaBytes": -23092768,
"heapUsedBytes": 245358744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.47100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.785567010309272,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 498.6429999999018,
"styleRecalcs": 23,
"styleRecalcDurationMs": 10.258999999999999,
"layouts": 12,
"layoutDurationMs": 4.111999999999999,
"taskDurationMs": 142.922,
"heapDeltaBytes": 7375480,
"heapUsedBytes": 67531248,
"domNodes": 138,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 16.157999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 117.04500000007556,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.114000000000001,
"layouts": 8,
"layoutDurationMs": 2.6,
"taskDurationMs": 69.56899999999999,
"heapDeltaBytes": 4637904,
"heapUsedBytes": 65706908,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.707,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 406.6569999999956,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6629999999999999,
"layouts": 76,
"layoutDurationMs": 13.811,
"taskDurationMs": 352.628,
"heapDeltaBytes": -4907900,
"heapUsedBytes": 38209588,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 162.462,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 386.21899999998277,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.68,
"layouts": 76,
"layoutDurationMs": 13.620000000000001,
"taskDurationMs": 341.51899999999995,
"heapDeltaBytes": -4970876,
"heapUsedBytes": 37680796,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 161.11700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660869565217382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 478.85699999994813,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.619,
"layouts": 76,
"layoutDurationMs": 13.43,
"taskDurationMs": 437.81499999999994,
"heapDeltaBytes": -3685292,
"heapUsedBytes": 79005624,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 175.71099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 444.00500000006105,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.657,
"layouts": 76,
"layoutDurationMs": 14.66,
"taskDurationMs": 407.345,
"heapDeltaBytes": -4069624,
"heapUsedBytes": 78697076,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 158.86399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370385,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage: 🟡 60.0% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3135 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 48325d9c39dd124b9e514284d03374ac25eefb79
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (242)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.59 #22684 +/- ##
=============================================
Coverage ? 87.23%
=============================================
Files ? 3035
Lines ? 159486
Branches ? 42236
=============================================
Hits ? 139123
Misses ? 19684
Partials ? 679
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Approving backport of #22514.
…alog The baseline from main differs by 8 pixels on this branch's dialog. This is the actual image from the cloud e2e on this PR; all four attempts produced the same pixels.
…lock a refused Cloud run (#22685) Backport of #22514 to `cloud/1.58`, the branch production Cloud serves. Manual: the automatic backport conflicted, and this branch differs from `main` in ways a plain cherry-pick cannot carry. Adaptations, all in the first commit unless noted: - Paths: billing code lives under `src/platform/cloud/subscription`, `src/platform/workspace` and `src/composables/billing` here. `CreditsLockedNotice` goes in `src/platform/workspace/components`. - `CreditsLockedNotice` reads `subscriptionStatus === 'ended'` for the resubscribe line, because this branch's `BillingContext` has no `subscriptionState`. Its unit test covers no status, `ended` and `canceled`. - Copy: `credits.topUp.planRequiredSubscribe` and `planRequiredResubscribe` are not on this branch (they came with #21766 and #21835). The second commit copies both keys, in every locale, verbatim from `cloud/1.59`, so the notice shows text and not a raw key. No other copy from those PRs comes along. - E2E: this branch has no `expectRegionScreenshot` helper and the `main` baseline would not match, so the spec asserts the line inside the dialog by exact text and drops the region screenshot. `main` and the `cloud/1.59` backport (#22684) keep the snapshot. Checked locally on this branch: pre-commit typecheck (app and browser tests) clean; vitest on `src/platform/cloud`, `src/platform/workspace`, `src/composables/billing`, `src/scripts/app.test.ts`, `src/platform/errorCatalog` and the GTM provider: 214 files, 5311 passed. Fixes https://linear.app/comfyorg/issue/FRONT-3662 on Cloud 1.58. Related: https://linear.app/comfyorg/issue/PM-2273
|
Justification: merging at 8757c9d under the stale-approval exception. Dante approved the backport code at 02d9740. The only later commit, 8757c9d, replaces one screenshot baseline (credits-locked-subscribe-dialog-cloud-linux.png) with the image this PR's cloud e2e produced on cloud/1.59: the main baseline differed by 8 pixels, all four CI attempts gave identical pixels, and the image shows the expected line under "Choose a Plan". No code changed. All required checks are green at 8757c9d (107 completed, none failing), there are no open review threads, and the base is cloud/1.59 head 48325d9. Post-merge review of that one file: @dante01yoon. |
Backport of #22514 to
cloud/1.59.Manual: the automatic backport hit one conflict in
SubscriptionRequiredDialogContent.vue.cloud/1.59still importsButtonandDialogTitlefrom@/components/ui/..., whilemainuses@comfyorg/design-system. Resolution keeps thecloud/1.59imports and adds theCreditsLockedNoticeimport. No other change;packages/telemetry/src/types.tsmapped tosrc/platform/telemetry/types.tsautomatically.The copy keys (
credits.topUp.planRequiredSubscribe,planRequiredResubscribe) already exist oncloud/1.59from #21766.Screenshot baseline: the
mainbaseline differed by 8 pixels on this branch, so the second commit takes the actual image from this PR's cloud e2e (all four attempts produced identical pixels; it shows the line under "Choose a Plan").Checked locally on this branch:
pnpm typecheckclean; vitest onsrc/platform/billing,src/scripts/app.test.ts,accountPreconditionRoutingandGtmTelemetryProvider: 140 files, 3703 passed.Fixes https://linear.app/comfyorg/issue/FRONT-3662 on Cloud 1.59. Related: https://linear.app/comfyorg/issue/PM-2273