Repository navigation
[backport cloud/1.59] fix(billing): show <1 for an activity charge under one credit - #22632
Conversation
A real charge under one credit showed as `0 Credits` in Settings > Plan & Credits > Activity, which reads as a free turn. platform.comfy.org shows `<1`. The app now shows `<1` too. Rule, for charge displays only: | Charge | Tooltip | |---|---| | 0 | `Charge: 0 Credits` | | 0.21 credits (1,000 micro USD) | `Charge: <1 Credits` | | 0.70 credits (3,318 micro USD) | `Charge: <1 Credits` | | 1.4 credits (6,636 micro USD) | `Charge: 1 Credits` | - `<1` is the new i18n string `credits.lessThanOne`. - `isSubCreditCharge` joins the shared credit helpers. `usdToCredits` and every balance display keep whole-credit rounding; `UsageLogsTable` is the only charge caller. - Decided on https://linear.app/comfyorg/issue/PM-2389: any non-zero amount under one credit shows `<1`. Platform currently switches at 0.5; Comfy-Org/platform#1548 moves it to 1 so both surfaces agree. - Unit, written first and seen failing: `UsageLogsTable.test.ts` (0.21, 0.70, 1 micro USD; 1.0001 and 1.4 stay `1`; 0 stays `0`) and `creditsUtil.test.ts` (classifier and balance rounding). - Browser test `usageLogsChargeTooltip.spec.ts` adds a sub-credit tooltip case with a snapshot. Baseline from CI for 1,000 micro USD: `browser_tests/tests/dialogs/usageLogsChargeTooltip.spec.ts-snapshots/activity-charge-tooltip-sub-credit-chromium-linux.png` (renders `Charge: <1 Credits`).  Fixes PM-2389 --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit f08a6c3)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T17:20:39.259Z",
"gitSha": "c36975dcb63485fc714a20b8f39204694d03afc8",
"branch": "backport-22470-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2037.6660000000015,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.718,
"layouts": 9,
"layoutDurationMs": 2.5689999999999995,
"taskDurationMs": 564.724,
"heapDeltaBytes": -5630564,
"heapUsedBytes": 55637452,
"domNodes": -161,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.237000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.100999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7610000000000006,
"layouts": 10,
"layoutDurationMs": 2.6429999999999993,
"taskDurationMs": 467.65999999999997,
"heapDeltaBytes": 3599092,
"heapUsedBytes": 65856528,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.826,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.8560000000157,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.526,
"layouts": 10,
"layoutDurationMs": 2.6350000000000002,
"taskDurationMs": 786.3960000000001,
"heapDeltaBytes": -2104548,
"heapUsedBytes": 67618072,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 132.411,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.4619999999832,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.409,
"layouts": 9,
"layoutDurationMs": 2.26,
"taskDurationMs": 757.7689999999999,
"heapDeltaBytes": 23490692,
"heapUsedBytes": 84059940,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 130.12300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2050000000072,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.8629999999999995,
"layouts": 10,
"layoutDurationMs": 2.9759999999999995,
"taskDurationMs": 361.68,
"heapDeltaBytes": 24792592,
"heapUsedBytes": 86200124,
"domNodes": 56,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.944999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.328000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.797999999999999,
"layouts": 12,
"layoutDurationMs": 3.4690000000000003,
"taskDurationMs": 374.879,
"heapDeltaBytes": 24438456,
"heapUsedBytes": 85400308,
"domNodes": 56,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 12.289,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307695,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 575.3500000000145,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.1009999999999995,
"layouts": 10,
"layoutDurationMs": 2.64,
"taskDurationMs": 432.79499999999996,
"heapDeltaBytes": 5145072,
"heapUsedBytes": 66592760,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 142.656,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571433,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 582.06899999999,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.836,
"layouts": 9,
"layoutDurationMs": 2.434,
"taskDurationMs": 431.25600000000003,
"heapDeltaBytes": 3853384,
"heapUsedBytes": 64402968,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 141.748,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1081.2549999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.798,
"heapDeltaBytes": -11470248,
"heapUsedBytes": 75761528,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 49.94899999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 408,
"frameDurationMs": 29.27567567567567,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1049.6990000000324,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 723.841,
"heapDeltaBytes": -13792836,
"heapUsedBytes": 75445324,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 50.38200000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 363,
"frameDurationMs": 28.378378378378365,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.1289999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.04400000000004,
"heapDeltaBytes": -30054840,
"heapUsedBytes": 66421272,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 124.32099999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 166,
"frameDurationMs": 23.14999999999999,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 814.549999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.7210000000003,
"heapDeltaBytes": -25393876,
"heapUsedBytes": 66350244,
"domNodes": -201,
"jsHeapTotalBytes": 4849664,
"scriptDurationMs": 133.48000000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 163,
"frameDurationMs": 22.686111111111106,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8102.978000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.28200000000000014,
"layouts": 1,
"layoutDurationMs": 0.3219999999999998,
"taskDurationMs": 7266.7480000000005,
"heapDeltaBytes": 65503532,
"heapUsedBytes": 138288920,
"domNodes": -257,
"jsHeapTotalBytes": 57536512,
"scriptDurationMs": 5542.84,
"eventListeners": -68,
"totalBlockingTimeMs": 74,
"frameDurationMs": 23.80175953079179,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7540.785999999969,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5639999999999994,
"layouts": 2,
"layoutDurationMs": 0.477,
"taskDurationMs": 6679.897999999999,
"heapDeltaBytes": 67026548,
"heapUsedBytes": 140372804,
"domNodes": -257,
"jsHeapTotalBytes": 61468672,
"scriptDurationMs": 5091.321,
"eventListeners": -68,
"totalBlockingTimeMs": 29,
"frameDurationMs": 23.89145569620253,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7946.146999999996,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6410000000000001,
"layouts": 2,
"layoutDurationMs": 0.5410000000000003,
"taskDurationMs": 7073.424,
"heapDeltaBytes": 55717244,
"heapUsedBytes": 135500856,
"domNodes": -257,
"jsHeapTotalBytes": 57274368,
"scriptDurationMs": 5447.5160000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 91,
"frameDurationMs": 24.185975609756095,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7808.611999999983,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2529999999999998,
"layouts": 1,
"layoutDurationMs": 0.21699999999999975,
"taskDurationMs": 6913.691,
"heapDeltaBytes": 71950524,
"heapUsedBytes": 145646564,
"domNodes": -257,
"jsHeapTotalBytes": 55701504,
"scriptDurationMs": 5377.84,
"eventListeners": -68,
"totalBlockingTimeMs": 83,
"frameDurationMs": 24.60441640378549,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 226.85500000000047,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.360000000000001,
"layouts": 11,
"layoutDurationMs": 3.253,
"taskDurationMs": 181.415,
"heapDeltaBytes": 14495052,
"heapUsedBytes": 89985560,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 8.953,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181826,
"p95FrameDurationMs": 66.70000000000027
},
{
"name": "large-combo-open",
"durationMs": 186.5640000000326,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.355000000000002,
"layouts": 10,
"layoutDurationMs": 2.7130000000000005,
"taskDurationMs": 150.05,
"heapDeltaBytes": 14453628,
"heapUsedBytes": 90198704,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 7.074999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2026.0719999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8040000000000003,
"layouts": 8,
"layoutDurationMs": 2.5220000000000002,
"taskDurationMs": 645.821,
"heapDeltaBytes": -9714088,
"heapUsedBytes": 64318552,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.025,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.6789999999587,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.593,
"layouts": 9,
"layoutDurationMs": 2.28,
"taskDurationMs": 578.883,
"heapDeltaBytes": -11290040,
"heapUsedBytes": 62915200,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 32.98499999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2615.8860000000177,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.563000000000002,
"layouts": 8,
"layoutDurationMs": 1.9680000000000002,
"taskDurationMs": 1440.2719999999997,
"heapDeltaBytes": -3633364,
"heapUsedBytes": 71698892,
"domNodes": -257,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 682.3629999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656050955414,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2237.2739999999567,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.743,
"layouts": 8,
"layoutDurationMs": 1.747,
"taskDurationMs": 1368.684,
"heapDeltaBytes": -31354444,
"heapUsedBytes": 60794172,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 654.5889999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3527.875999999992,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.11,
"layouts": 66,
"layoutDurationMs": 10.468,
"taskDurationMs": 1511.723,
"heapDeltaBytes": -7571496,
"heapUsedBytes": 64165496,
"domNodes": -233,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 653.633,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3651.7820000000256,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.916,
"layouts": 64,
"layoutDurationMs": 10.350999999999999,
"taskDurationMs": 1543.5210000000002,
"heapDeltaBytes": -23132476,
"heapUsedBytes": 70481276,
"domNodes": -233,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 648.8280000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662100456621,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2647.763999999995,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.212,
"layouts": 6,
"layoutDurationMs": 1.3860000000000001,
"taskDurationMs": 1677.5659999999996,
"heapDeltaBytes": 18789892,
"heapUsedBytes": 97702332,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 840.113,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77151898734177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2427.8470000000425,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.370999999999999,
"layouts": 7,
"layoutDurationMs": 1.5630000000000002,
"taskDurationMs": 1634.3280000000002,
"heapDeltaBytes": 16807852,
"heapUsedBytes": 97462004,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 797.0240000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.781249999999996,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2976.5940000000055,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8889999999999991,
"layouts": 7,
"layoutDurationMs": 1.563,
"taskDurationMs": 697.672,
"heapDeltaBytes": -8117908,
"heapUsedBytes": 85527984,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 311.787,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665363128491624,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3007.0610000000215,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.176,
"layouts": 7,
"layoutDurationMs": 1.9149999999999996,
"taskDurationMs": 698.6510000000002,
"heapDeltaBytes": -9192860,
"heapUsedBytes": 70459092,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 313.46999999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.1489999999667,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.354,
"layouts": 8,
"layoutDurationMs": 2.156,
"taskDurationMs": 595.6239999999999,
"heapDeltaBytes": -9387824,
"heapUsedBytes": 67469016,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.344,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2034.7150000000056,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.975,
"layouts": 7,
"layoutDurationMs": 1.8329999999999997,
"taskDurationMs": 581.711,
"heapDeltaBytes": -13106220,
"heapUsedBytes": 64439924,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 30.224999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2825.0869999999964,
"styleRecalcs": 28,
"styleRecalcDurationMs": 12.162999999999998,
"layouts": 8,
"layoutDurationMs": 2.26,
"taskDurationMs": 552.538,
"heapDeltaBytes": -4462128,
"heapUsedBytes": 71530316,
"domNodes": -254,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 159.86299999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665882352941175,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2688.9639999999986,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.376999999999999,
"layouts": 7,
"layoutDurationMs": 1.5929999999999997,
"taskDurationMs": 506.8809999999999,
"heapDeltaBytes": -9488688,
"heapUsedBytes": 67887712,
"domNodes": -255,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 159.30700000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666459627329193,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3075.209999999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0549999999999997,
"layouts": 7,
"layoutDurationMs": 1.8110000000000002,
"taskDurationMs": 823.991,
"heapDeltaBytes": 5746432,
"heapUsedBytes": 82252568,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 305.349,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-topology-cadence",
"durationMs": 3059.5260000000053,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0759999999999996,
"layouts": 7,
"layoutDurationMs": 1.996,
"taskDurationMs": 797.763,
"heapDeltaBytes": -7421508,
"heapUsedBytes": 67605392,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 300.86999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.1129999999594,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.178999999999999,
"layouts": 10,
"layoutDurationMs": 2.535,
"taskDurationMs": 389.46400000000006,
"heapDeltaBytes": 24626180,
"heapUsedBytes": 86408900,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 126.854,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.606000000078,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.792,
"layouts": 9,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 369.269,
"heapDeltaBytes": 24668940,
"heapUsedBytes": 86498024,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 123.302,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.4559999999954,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.760000000000001,
"layouts": 9,
"layoutDurationMs": 2.356,
"taskDurationMs": 505.56,
"heapDeltaBytes": 2124464,
"heapUsedBytes": 64480044,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.036,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.9559999999788,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6109999999999998,
"layouts": 9,
"layoutDurationMs": 2.3810000000000002,
"taskDurationMs": 483.695,
"heapDeltaBytes": 3819080,
"heapUsedBytes": 65778452,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 9.162999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.2199999999966,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.074,
"layouts": 9,
"layoutDurationMs": 2.447,
"taskDurationMs": 740.6600000000001,
"heapDeltaBytes": -5453916,
"heapUsedBytes": 66755472,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 97.04400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.294000000004,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.486999999999998,
"layouts": 9,
"layoutDurationMs": 2.251,
"taskDurationMs": 718.085,
"heapDeltaBytes": 17311464,
"heapUsedBytes": 79855032,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 96.21300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1352.6880000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.252,
"layouts": 5,
"layoutDurationMs": 10.639,
"taskDurationMs": 964.1980000000001,
"heapDeltaBytes": 11891048,
"heapUsedBytes": 113584936,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 28.509,
"eventListeners": 3246,
"totalBlockingTimeMs": 105,
"frameDurationMs": 18.72054794520547,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10149.810000000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.557,
"layouts": 9,
"layoutDurationMs": 2.1310000000000002,
"taskDurationMs": 5096.692,
"heapDeltaBytes": -3133564,
"heapUsedBytes": 70680648,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2265.3800000000006,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10045.344999999941,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.398999999999997,
"layouts": 8,
"layoutDurationMs": 1.9499999999999997,
"taskDurationMs": 5055.263,
"heapDeltaBytes": 7031668,
"heapUsedBytes": 81008864,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2267.225,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666003316749585,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20390.462000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19864.221999999998,
"heapDeltaBytes": -38169748,
"heapUsedBytes": 258153024,
"domNodes": -3343,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 306.589,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.955253623188405,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20386.82899999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19873.525999999998,
"heapDeltaBytes": -21125520,
"heapUsedBytes": 257719584,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 311.488,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.05820895522388,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 24807.05999999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.204000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24555.989,
"heapDeltaBytes": -38059436,
"heapUsedBytes": 254055812,
"domNodes": -3343,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 793.0319999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 10,
"frameDurationMs": 47.41682600382409,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 24145.794000000024,
"styleRecalcs": 178,
"styleRecalcDurationMs": 21.513000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23792.202,
"heapDeltaBytes": -13678268,
"heapUsedBytes": 287846520,
"domNodes": -3064,
"jsHeapTotalBytes": 17485824,
"scriptDurationMs": 777.9789999999999,
"eventListeners": -588,
"totalBlockingTimeMs": 6,
"frameDurationMs": 46.14225621414914,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7309.054000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.40800000000001,
"layouts": 20,
"layoutDurationMs": 23.305000000000007,
"taskDurationMs": 7218.2519999999995,
"heapDeltaBytes": -19235628,
"heapUsedBytes": 282187440,
"domNodes": -2276,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 128.911,
"eventListeners": -423,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.45059523809524,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7309.937999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.37600000000002,
"layouts": 20,
"layoutDurationMs": 29.876,
"taskDurationMs": 7207.4400000000005,
"heapDeltaBytes": -1380756,
"heapUsedBytes": 272023256,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 109.586,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.664772727272734,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10114.598999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9795.457,
"heapDeltaBytes": 313612,
"heapUsedBytes": 278903576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.33,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.38920863309352,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10020.929000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9625.701,
"heapDeltaBytes": -3989268,
"heapUsedBytes": 258619144,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.27900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.29057971014493,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 442.68200000004754,
"styleRecalcs": 15,
"styleRecalcDurationMs": 9.028999999999998,
"layouts": 13,
"layoutDurationMs": 3.791,
"taskDurationMs": 96.562,
"heapDeltaBytes": 6909504,
"heapUsedBytes": 68763420,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.6,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 100.55099999999584,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.702000000000001,
"layouts": 8,
"layoutDurationMs": 2.371,
"taskDurationMs": 68.996,
"heapDeltaBytes": 4599616,
"heapUsedBytes": 63336628,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.005000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 357.1759999999813,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.636,
"layouts": 76,
"layoutDurationMs": 12.798,
"taskDurationMs": 312.838,
"heapDeltaBytes": -5291004,
"heapUsedBytes": 36337204,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 147.859,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 370.50700000008874,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.627,
"layouts": 76,
"layoutDurationMs": 13.724,
"taskDurationMs": 326.322,
"heapDeltaBytes": -5102488,
"heapUsedBytes": 38244424,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 153.222,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 423.72599999998783,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.3770000000000002,
"layouts": 76,
"layoutDurationMs": 14.314,
"taskDurationMs": 394.62,
"heapDeltaBytes": -4434264,
"heapUsedBytes": 80591496,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 146.85,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538459,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 426.482999999962,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.246,
"layouts": 76,
"layoutDurationMs": 13.459,
"taskDurationMs": 399.358,
"heapDeltaBytes": -4465640,
"heapUsedBytes": 78592564,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 147.317,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 60.1% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3127 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b77005661e99c582f9fc66c349f3665447ca1f0e
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (240)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22632 +/- ##
=============================================
Coverage ? 87.33%
=============================================
Files ? 3142
Lines ? 162782
Branches ? 43713
=============================================
Hits ? 142171
Misses ? 19767
Partials ? 844
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approving the backport of #22470.
…tivity charge (#22472) (#22999) Backport of #22472 to `core/1.59`. The automated backport stopped on a conflict. Conflicts resolved by hand: - On this branch the Activity charge tooltip still lives in `UsageLogsTable.vue` (#17858 moved it to `customerEventsService.ts` on `main` only). The change from #22472 is applied to `formatChargeCredits` there, and the test expectations go to `UsageLogsTable.test.ts`: the one-credit rows now expect `Charge: 1 Credit`, plus a new two-credit row. - `browser_tests/fixtures/data/customerEvents.ts`: kept the branch's `/customers/events` doc comment and `CustomerEventsResponse` type. Everything else is the #22472 change as merged: the `credits.creditUnit` plural key (`Credit | Credits` in English, each locale's existing credits word elsewhere), and the browser test one-credit case with its snapshot baseline. Tests: `UsageLogsTable.test.ts` failed on the 2 one-credit rows before the fix (`expected 'Charge: 1 Credits' to be 'Charge: 1 Credit'`) and passes after (47/47; 83/83 with the customer events service and credits util tests). Follows #22631 / #22632 (the `<1` change on 1.59). Ticket: FRONT-3751. --------- Co-authored-by: github-actions <github-actions@github.com>
…ctivity charge (#22472) (#23000) Backport of #22472 to `cloud/1.59`. The automated backport stopped on a conflict. Conflicts resolved by hand: - On this branch the Activity charge tooltip still lives in `UsageLogsTable.vue` (#17858 moved it to `customerEventsService.ts` on `main` only). The change from #22472 is applied to `formatChargeCredits` there, and the test expectations go to `UsageLogsTable.test.ts`: the one-credit rows now expect `Charge: 1 Credit`, plus a new two-credit row. - `browser_tests/fixtures/data/customerEvents.ts`: kept the branch's `/customers/events` doc comment and `CustomerEventsResponse` type. Everything else is the #22472 change as merged: the `credits.creditUnit` plural key (`Credit | Credits` in English, each locale's existing credits word elsewhere), and the browser test one-credit case with its snapshot baseline. Tests: `UsageLogsTable.test.ts` failed on the 2 one-credit rows before the fix (`expected 'Charge: 1 Credits' to be 'Charge: 1 Credit'`) and passes after (47/47; 83/83 with the customer events service and credits util tests). Follows #22631 / #22632 (the `<1` change on 1.59). Ticket: FRONT-3751. --------- Co-authored-by: github-actions <github-actions@github.com>
Backport of #22470 to
cloud/1.59. The automated backport stopped on a conflict.Conflicts resolved by hand:
creditsUtil.ts/creditsUtil.test.ts:microUsdToCreditsis not oncloud/1.59, so the backport adds it next toisSubCreditCharge(same one-line helper as onmain).UsageLogsTable.vue: kept the branch's local@/components/ui/tableimports; only the credits import changed.No other changes from #22470. A charge under one credit now shows
Charge: <1 Creditsin Settings > Plan & Credits > Activity; 0 stays 0, 1.4 shows 1, balances keep whole-credit rounding.Tests:
UsageLogsTable.test.ts46/46 andcreditsUtil.test.ts19/19 pass on this branch; the three<1rows fail without theUsageLogsTable.vuechange. Typecheck clean. The browser test and its sub-credit snapshot come over unchanged.Ticket: https://linear.app/comfyorg/issue/PM-2389