Repository navigation
[backport cloud/1.59] fix(billing): say "1 Credit" for a one-credit activity charge (#22472) - #23000
Conversation
…ctivity charge (#22472) Backport of #22472 to `cloud/1.59`. The automated backport stopped on a conflict. Conflicts resolved by hand: - `customerEventsService.ts` / `customerEventsService.test.ts`: on `cloud/1.59` the charge tooltip still lives in `UsageLogsTable.vue` (#17858 moved it on `main` only), so the change is applied to `formatChargeCredits` there, and the expectations move to `UsageLogsTable.test.ts` (one-credit rows now `Charge: 1 Credit`, plus a two-credit row). - `browser_tests/fixtures/data/customerEvents.ts`: kept the branch's `/customers/events` doc comment and `CustomerEventsResponse` type. No other changes from #22472. Unit tests seen failing before the fix (2 failures), green after (83/83 across UsageLogsTable, customerEvents service and creditsUtil). (cherry picked from commit f2f115a)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle: ⏳ Size data collection in progress…⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable
DetailsScenario timings
Absolute values
Raw data{
"timestamp": "2026-11-05T12:05:53.031Z",
"gitSha": "7fa15353f9ccd7eb34554d876b98631b975a297f",
"branch": "backport-22472-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.6639999999961,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.287,
"layouts": 10,
"layoutDurationMs": 2.114,
"taskDurationMs": 304.641,
"heapDeltaBytes": 1793120,
"heapUsedBytes": 62875612,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 6.2429999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66694214876033,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2004.4129999999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.124,
"layouts": 10,
"layoutDurationMs": 1.925,
"taskDurationMs": 320.93,
"heapDeltaBytes": -8836408,
"heapUsedBytes": 51814272,
"domNodes": -161,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 5.117999999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6989999999946,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.017,
"layouts": 10,
"layoutDurationMs": 2.2640000000000002,
"taskDurationMs": 544.411,
"heapDeltaBytes": 24470088,
"heapUsedBytes": 86980812,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 100.591,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653466,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.9879999999944,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.424,
"layouts": 11,
"layoutDurationMs": 2.3640000000000003,
"taskDurationMs": 506.994,
"heapDeltaBytes": 21965488,
"heapUsedBytes": 83741416,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 90.96300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.1450000000025,
"styleRecalcs": 19,
"styleRecalcDurationMs": 3.6599999999999997,
"layouts": 11,
"layoutDurationMs": 2.152,
"taskDurationMs": 229.673,
"heapDeltaBytes": 192168,
"heapUsedBytes": 69733364,
"domNodes": 56,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 7.367,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.3109999999997,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.122,
"layouts": 9,
"layoutDurationMs": 2.5109999999999997,
"taskDurationMs": 254.20900000000003,
"heapDeltaBytes": -223640,
"heapUsedBytes": 72521376,
"domNodes": 56,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 7.572000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 460.47699999999736,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6609999999999996,
"layouts": 10,
"layoutDurationMs": 2.235,
"taskDurationMs": 301.68699999999995,
"heapDeltaBytes": 5227620,
"heapUsedBytes": 67155820,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 100.90599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 445.0199999999995,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.3710000000000004,
"layouts": 12,
"layoutDurationMs": 2.948,
"taskDurationMs": 316.74500000000006,
"heapDeltaBytes": 6013824,
"heapUsedBytes": 78848344,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 105.391,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962958,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 894.4120000000169,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.73199999999997,
"heapDeltaBytes": -15156540,
"heapUsedBytes": 76014604,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 37.934999999999995,
"eventListeners": -107,
"totalBlockingTimeMs": 246,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 876.9790000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.58300000000014,
"heapDeltaBytes": -14912212,
"heapUsedBytes": 75503740,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 34.17,
"eventListeners": -107,
"totalBlockingTimeMs": 249,
"frameDurationMs": 25.240000000000002,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 703.1089999999836,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.4300000000002,
"heapDeltaBytes": -4205920,
"heapUsedBytes": 69807732,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 86.96399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 697.3940000000312,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 274.9480000000002,
"heapDeltaBytes": -4483004,
"heapUsedBytes": 70536932,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.503,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5960.157999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.804,
"layouts": 3,
"layoutDurationMs": 0.6940000000000002,
"taskDurationMs": 4926.573,
"heapDeltaBytes": 43941036,
"heapUsedBytes": 118719344,
"domNodes": -257,
"jsHeapTotalBytes": 52293632,
"scriptDurationMs": 3711.741,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.358461538461537,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6065.476000000046,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.895,
"layouts": 3,
"layoutDurationMs": 0.7990000000000003,
"taskDurationMs": 5067.925,
"heapDeltaBytes": -6667484,
"heapUsedBytes": 81903960,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 3892.861,
"eventListeners": -69,
"totalBlockingTimeMs": 37,
"frameDurationMs": 18.957500000000003,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6017.871000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6820000000000003,
"layouts": 3,
"layoutDurationMs": 0.5539999999999998,
"taskDurationMs": 5013.880999999999,
"heapDeltaBytes": -15091332,
"heapUsedBytes": 79425036,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 3829.2409999999995,
"eventListeners": -69,
"totalBlockingTimeMs": 22,
"frameDurationMs": 18.742679127725857,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5981.179999999995,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.758,
"layouts": 3,
"layoutDurationMs": 0.6819999999999998,
"taskDurationMs": 5016.878000000001,
"heapDeltaBytes": 48204056,
"heapUsedBytes": 123450728,
"domNodes": -257,
"jsHeapTotalBytes": 57536512,
"scriptDurationMs": 3846.038,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.933544303797465,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 211.52399999999716,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.568999999999999,
"layouts": 12,
"layoutDurationMs": 3.104,
"taskDurationMs": 149.70200000000003,
"heapDeltaBytes": -7404024,
"heapUsedBytes": 75811540,
"domNodes": 936,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.292000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.690909090909084,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 127.6849999999854,
"styleRecalcs": 21,
"styleRecalcDurationMs": 9.841,
"layouts": 12,
"layoutDurationMs": 2.6719999999999997,
"taskDurationMs": 92.46000000000001,
"heapDeltaBytes": 14526496,
"heapUsedBytes": 85493528,
"domNodes": 936,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.303,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2007.8460000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4649999999999994,
"layouts": 9,
"layoutDurationMs": 2.1330000000000005,
"taskDurationMs": 371.34299999999996,
"heapDeltaBytes": 7355224,
"heapUsedBytes": 83037888,
"domNodes": -277,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 23.049999999999994,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.0860000000207,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.7289999999999996,
"layouts": 9,
"layoutDurationMs": 1.546,
"taskDurationMs": 371.797,
"heapDeltaBytes": 3351032,
"heapUsedBytes": 78109656,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 21.485999999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2198.837999999995,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.770000000000001,
"layouts": 9,
"layoutDurationMs": 2.0149999999999997,
"taskDurationMs": 1080.19,
"heapDeltaBytes": -20920980,
"heapUsedBytes": 73277320,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 548.29,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2154.537000000005,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.706999999999999,
"layouts": 10,
"layoutDurationMs": 2.3810000000000002,
"taskDurationMs": 1118.4640000000002,
"heapDeltaBytes": -25878564,
"heapUsedBytes": 61534860,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 551.262,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3238.9689999999973,
"styleRecalcs": 74,
"styleRecalcDurationMs": 11.184,
"layouts": 67,
"layoutDurationMs": 11.181999999999999,
"taskDurationMs": 1100.915,
"heapDeltaBytes": -345200,
"heapUsedBytes": 91978632,
"domNodes": 24,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 490.19500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665641025641023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3138.7230000000272,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.801,
"layouts": 68,
"layoutDurationMs": 11.524000000000001,
"taskDurationMs": 1194.125,
"heapDeltaBytes": -27426316,
"heapUsedBytes": 64459480,
"domNodes": -233,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 532.2679999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2271.2350000000188,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.066999999999999,
"layouts": 7,
"layoutDurationMs": 1.7530000000000001,
"taskDurationMs": 1228.2269999999999,
"heapDeltaBytes": 14912164,
"heapUsedBytes": 94132908,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 621.217,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588233,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2341.655000000003,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.824,
"layouts": 7,
"layoutDurationMs": 1.4789999999999999,
"taskDurationMs": 1272.5,
"heapDeltaBytes": 14367528,
"heapUsedBytes": 93440784,
"domNodes": 0,
"jsHeapTotalBytes": 7233536,
"scriptDurationMs": 653.312,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666428571428572,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2787.803999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7169999999999999,
"layouts": 8,
"layoutDurationMs": 1.5850000000000002,
"taskDurationMs": 504.236,
"heapDeltaBytes": -631356,
"heapUsedBytes": 75811608,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 244.12499999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66526946107785,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2830.8439999999564,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6499999999999995,
"layouts": 8,
"layoutDurationMs": 1.4169999999999998,
"taskDurationMs": 514.2330000000001,
"heapDeltaBytes": 10462144,
"heapUsedBytes": 85522588,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 247.39500000000004,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666470588235292,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2037.7169999999865,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5130000000000003,
"layouts": 9,
"layoutDurationMs": 5.099,
"taskDurationMs": 378.06,
"heapDeltaBytes": -17363012,
"heapUsedBytes": 66172896,
"domNodes": -257,
"jsHeapTotalBytes": 126976,
"scriptDurationMs": 22.007000000000005,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2004.350000000045,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7689999999999997,
"layouts": 9,
"layoutDurationMs": 1.592,
"taskDurationMs": 353.80299999999994,
"heapDeltaBytes": -26250664,
"heapUsedBytes": 68849820,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 18.342000000000002,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2707.8479999999845,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.712,
"layouts": 9,
"layoutDurationMs": 1.54,
"taskDurationMs": 409.28700000000003,
"heapDeltaBytes": -2784408,
"heapUsedBytes": 78146440,
"domNodes": -245,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 130.682,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66503067484663,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2678.094999999985,
"styleRecalcs": 27,
"styleRecalcDurationMs": 9.222999999999999,
"layouts": 7,
"layoutDurationMs": 1.1730000000000003,
"taskDurationMs": 364.445,
"heapDeltaBytes": -4099744,
"heapUsedBytes": 73411284,
"domNodes": -240,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 113.20400000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583850931677,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-topology-cadence",
"durationMs": 2890.3449999999966,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6299999999999994,
"layouts": 8,
"layoutDurationMs": 1.3669999999999998,
"taskDurationMs": 609.785,
"heapDeltaBytes": 363068,
"heapUsedBytes": 76942244,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 234.49499999999998,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665317919075143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 2918.7029999999936,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.7180000000000009,
"layouts": 8,
"layoutDurationMs": 1.516,
"taskDurationMs": 646.9,
"heapDeltaBytes": -6188848,
"heapUsedBytes": 66812444,
"domNodes": -257,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 247.20899999999997,
"eventListeners": -69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.8409999999915,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.4319999999999995,
"layouts": 10,
"layoutDurationMs": 2.353,
"taskDurationMs": 299.297,
"heapDeltaBytes": 495928,
"heapUsedBytes": 64241080,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 100.007,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661538461538473,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 397.6430000000164,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.5009999999999994,
"layouts": 9,
"layoutDurationMs": 2.097,
"taskDurationMs": 263.915,
"heapDeltaBytes": -1270608,
"heapUsedBytes": 61033312,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 91.005,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.1860000000233,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.264,
"layouts": 10,
"layoutDurationMs": 2.091,
"taskDurationMs": 334.38900000000007,
"heapDeltaBytes": -5977520,
"heapUsedBytes": 68596940,
"domNodes": -183,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 5.582,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.0510000000231,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9819999999999993,
"layouts": 12,
"layoutDurationMs": 2.8649999999999998,
"taskDurationMs": 354.043,
"heapDeltaBytes": -17203564,
"heapUsedBytes": 65299756,
"domNodes": -183,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.944999999999999,
"eventListeners": -116,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8209999999856,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.047999999999998,
"layouts": 11,
"layoutDurationMs": 2.2279999999999998,
"taskDurationMs": 544.5569999999999,
"heapDeltaBytes": -20730988,
"heapUsedBytes": 53080376,
"domNodes": -175,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 74.43299999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.7360000000012,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.469,
"layouts": 10,
"layoutDurationMs": 2.326,
"taskDurationMs": 574.623,
"heapDeltaBytes": -17830960,
"heapUsedBytes": 56653624,
"domNodes": -175,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 82.55999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.6209999999742,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.403000000000002,
"layouts": 5,
"layoutDurationMs": 9.052999999999999,
"taskDurationMs": 588.368,
"heapDeltaBytes": 9214552,
"heapUsedBytes": 101750836,
"domNodes": 16030,
"jsHeapTotalBytes": 16650240,
"scriptDurationMs": 17.719,
"eventListeners": 3246,
"totalBlockingTimeMs": 66,
"frameDurationMs": 18.990697674418612,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8539.327000000014,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.196999999999996,
"layouts": 8,
"layoutDurationMs": 1.5839999999999999,
"taskDurationMs": 3935.172,
"heapDeltaBytes": 7858908,
"heapUsedBytes": 82175412,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 1904.757,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666015625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8151.3920000000435,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.099000000000004,
"layouts": 9,
"layoutDurationMs": 1.854,
"taskDurationMs": 3591.0280000000002,
"heapDeltaBytes": -22093480,
"heapUsedBytes": 61584168,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 1736.617,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15712.47199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14797.711,
"heapDeltaBytes": -28956868,
"heapUsedBytes": 273589108,
"domNodes": -3343,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 196.71800000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.974742268041236,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14822.249,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13913.765,
"heapDeltaBytes": -10420776,
"heapUsedBytes": 286556052,
"domNodes": -3343,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 168.67,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.26865417376491,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14490.049999999996,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.190000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13816.269999999999,
"heapDeltaBytes": -31507796,
"heapUsedBytes": 265442356,
"domNodes": -3343,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 542.481,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.572134038800705,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17334.19299999997,
"styleRecalcs": 153,
"styleRecalcDurationMs": 15.074000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17063.793,
"heapDeltaBytes": -24776552,
"heapUsedBytes": 272350536,
"domNodes": -3343,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 577.9929999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.79621928166351,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5259.673000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.41799999999999,
"layouts": 20,
"layoutDurationMs": 17.791,
"taskDurationMs": 5140.691,
"heapDeltaBytes": -11975924,
"heapUsedBytes": 262075060,
"domNodes": -3343,
"jsHeapTotalBytes": 22794240,
"scriptDurationMs": 95.56700000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 30,
"frameDurationMs": 32.11280487804878,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5238.871000000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 40.35900000000001,
"layouts": 20,
"layoutDurationMs": 17.812999999999995,
"taskDurationMs": 5119.168000000001,
"heapDeltaBytes": -22571644,
"heapUsedBytes": 275126448,
"domNodes": -3343,
"jsHeapTotalBytes": 34332672,
"scriptDurationMs": 69.84999999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.10490797546012,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7245.046000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6683.333,
"heapDeltaBytes": 19050228,
"heapUsedBytes": 286608868,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 79.12400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.328187919463083,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7398.892999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7038.975999999998,
"heapDeltaBytes": -14575152,
"heapUsedBytes": 275394100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.81499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.255290102389075,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 460.7809999999972,
"styleRecalcs": 18,
"styleRecalcDurationMs": 9.564,
"layouts": 12,
"layoutDurationMs": 4.195000000000001,
"taskDurationMs": 114.38600000000001,
"heapDeltaBytes": -9723180,
"heapUsedBytes": 64960128,
"domNodes": 138,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 15.166000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 72.10900000001175,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.818,
"layouts": 5,
"layoutDurationMs": 1.1549999999999998,
"taskDurationMs": 43.60099999999999,
"heapDeltaBytes": 4612820,
"heapUsedBytes": 75507816,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.9779999999999998,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.649999999999977,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 188.52399999991576,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5139999999999999,
"layouts": 76,
"layoutDurationMs": 8.839999999999998,
"taskDurationMs": 148.35099999999997,
"heapDeltaBytes": 9576196,
"heapUsedBytes": 48816012,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 60.781,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 185.97999999997228,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.575,
"layouts": 76,
"layoutDurationMs": 9.128,
"taskDurationMs": 153.71699999999998,
"heapDeltaBytes": 9723336,
"heapUsedBytes": 48400456,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 62.501,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 239.87499999998363,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1540000000000001,
"layouts": 76,
"layoutDurationMs": 8.95,
"taskDurationMs": 200.731,
"heapDeltaBytes": -1361108,
"heapUsedBytes": 87726160,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 65.805,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 232.31699999996636,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.186,
"layouts": 76,
"layoutDurationMs": 9.147,
"taskDurationMs": 198.977,
"heapDeltaBytes": -1551088,
"heapUsedBytes": 91949248,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 65.485,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage: 🟡 59.7% of linesCoverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3141 passed, 0 failed · 4 flaky📊 Browser Reports
🎭 Playwright Expectations UpdateTip Updated 1 screenshot taken from the E2E run without rerunning Playwright and pushed to the branch. 🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0d3fc943049a8350a00e7acd9078ce49e1e24c2b
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (284)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #23000 +/- ##
=============================================
Coverage ? 87.30%
=============================================
Files ? 3073
Lines ? 160975
Branches ? 43043
=============================================
Hits ? 140545
Misses ? 19750
Partials ? 680
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/42017740170 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/dialogs/usageLogsChargeTooltip.spec.ts-snapshots/activity-charge-tooltip-one-credit-chromium-linux.png` | modified | 2915B -> 2895B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
dante01yoon
left a comment
There was a problem hiding this comment.
Approved as a backport, as requested. No additional code-change review or tests run. Live head, checks, and discussion rechecked before submission.
Backport of #22472 to
cloud/1.59. The automated backport stopped on a conflict.Conflicts resolved by hand:
UsageLogsTable.vue(fix(billing): render usage-log tooltips from an explicit param allowlist #17858 moved it tocustomerEventsService.tsonmainonly). The change from fix(billing): say "1 Credit" for a one-credit activity charge #22472 is applied toformatChargeCreditsthere, and the test expectations go toUsageLogsTable.test.ts: the one-credit rows now expectCharge: 1 Credit, plus a new two-credit row.browser_tests/fixtures/data/customerEvents.ts: kept the branch's/customers/eventsdoc comment andCustomerEventsResponsetype.Everything else is the #22472 change as merged: the
credits.creditUnitplural key (Credit | Creditsin English, each locale's existing credits word elsewhere), and the browser test one-credit case with its snapshot baseline.Tests:
UsageLogsTable.test.tsfailed on the 2 one-credit rows before the fix (expected 'Charge: 1 Credits' to be 'Charge: 1 Credit') and passes after (47/47; 83/83 with the customer events service and credits util tests).Follows #22631 / #22632 (the
<1change on 1.59). Ticket: FRONT-3751.