Repository navigation
[backport cloud/1.57] fix(paste): keep name-keyed widget values on pasted custom nodes - #22554
Conversation
) ## Summary - Pasting VHS nodes showed "Failed to restore node" - Cause: clipboard schema dropped record-shaped `widgets_values` (from #19239) - Fix: keep the record, like workflow load does; e2e red on main, green here <details><summary>Full context for agent readers</summary> ### Bug From the 1.57 release QA thread: https://comfy-organization.slack.com/archives/C0932CGKT5K/p1791952563933479 Local, Nodes 2.0 on, ComfyUI-VideoHelperSuite installed. Connect a Load Video (Upload) node (`meta_batch` in, `frame_count` out), select the connected nodes, Ctrl+C, Ctrl+V. The dialog "Failed to restore node: Load Video (Upload) ... Please remove and re-add it." appears, and the pasted node turns red and loses its widget values. Meta Batch Manager fails the same way. Root cause identified by Austin Mroz. ### Root cause VHS's `onSerialize` writes `widgets_values` as a name-keyed record. #19239 added `normalizeClipboardNodeWidgets` to `zClipboardNode`. For a record without a numeric `length`, it set `widgets_values: undefined` and kept only `widgets_values_named`. `ComfyNode.configure` then ran `migrateWidgetsValues(..., data.widgets_values ?? [])`, so VHS's `onConfigure` received `[]`. VHS treats that as a list whose length does not match the widget count, so it shows the dialog and sets `bgcolor = #C00`. Workflow load never strips the record, so only paste was broken. ### Fix `normalizeClipboardNodeWidgets` now passes the record through as `widgets_values` and still sets the `widgets_values_named` copy. That restores how paste behaved before #19239, and it matches workflow load. The `as unknown as TWidgetValue[]` cast follows `ISerialisedNode.widgets_values`, whose JSDoc already says custom nodes (it links to VHS) store an object there. Widening that shared type would touch every consumer, so this PR does not do it. The Alt-drag clone height flicker from the same report comes from VHS itself and is out of scope. ### Red -> green - e2e `browser_tests/tests/customNodes/vhsCopyPaste.spec.ts` (`@custom-nodes`, Nodes 2.0 on) builds Meta Batch Manager -> Load Video -> KSampler.seed, sets `force_rate` to 12, then copies and pastes all three. It asserts that no restore dialog appears, the widgets match, `bgcolor` is unset, and both links are restored. - main (dist build): `expect(locator).toBeHidden() failed ... Received: visible` on the "Failed to restore node" dialog. Instrumentation showed that VHS `onConfigure` received `widgets_values=[]`. - this branch: passes (`--repeat-each=2`, 2/2). `ecsMigrationScenarios.spec.ts` VHS cases still pass. - unit `workflowSchema.test.ts` "keeps named-record widget values for custom nodes that read them back": fails on main (`expected undefined to deeply equal { seed: 42, steps: 20 }`) and passes here. `workflowSchema`, `usePaste`, and `LGraphCanvas.clipboard` tests: 142/142. - Pre-commit (eslint, oxfmt, typecheck:app, typecheck:browser) and pre-push (depcruise, knip, fallow) passed. Run locally against ComfyUI 0.28.0 + VHS @115de7a + devtools, with the frontend `dist/` served by the backend. The Vite dev server stubs `/api/extensions` to `[]`, so VHS JS never loads there and the bug cannot reproduce in that setup. Not verified locally: `browser_tests/tests/copyPaste.spec.ts` (chromium project). Against this custom-node backend, 6 of its tests fail on canvas click interception and screenshot diffs, because it is not the default e2e backend. Those tests were not run on main in the same environment, so CI is the check for them. </details>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-11-01T03:32:14.656Z",
"gitSha": "c8cc0d0e1047bff9135373e2949941cf2816bd3e",
"branch": "backport-21332-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.0490000000045,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.882,
"layouts": 10,
"layoutDurationMs": 2.8200000000000003,
"taskDurationMs": 429.431,
"heapDeltaBytes": 22101476,
"heapUsedBytes": 87895844,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.596000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2009.1869999999972,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0620000000000003,
"layouts": 10,
"layoutDurationMs": 2.7149999999999994,
"taskDurationMs": 396.98699999999997,
"heapDeltaBytes": 3608784,
"heapUsedBytes": 77758276,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 11.133000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.4499999999891,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.534000000000002,
"layouts": 10,
"layoutDurationMs": 2.4850000000000003,
"taskDurationMs": 626.669,
"heapDeltaBytes": -8253328,
"heapUsedBytes": 66775492,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 116.24900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.1820000000494,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.440000000000001,
"layouts": 9,
"layoutDurationMs": 2.196,
"taskDurationMs": 610.729,
"heapDeltaBytes": 15615092,
"heapUsedBytes": 81903412,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 115.79,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.3559999999902,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.713,
"layouts": 12,
"layoutDurationMs": 3.1460000000000004,
"taskDurationMs": 293.53499999999997,
"heapDeltaBytes": 18632188,
"heapUsedBytes": 84950000,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 13.847999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.5279999999734,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.779,
"layouts": 12,
"layoutDurationMs": 3.556,
"taskDurationMs": 322.33299999999997,
"heapDeltaBytes": 18713184,
"heapUsedBytes": 84663428,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 15.163,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 493.7800000000152,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.648,
"layouts": 9,
"layoutDurationMs": 2.2159999999999997,
"taskDurationMs": 315.407,
"heapDeltaBytes": 25068216,
"heapUsedBytes": 91428516,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 107.086,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 532.8850000000216,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.2299999999999995,
"layouts": 10,
"layoutDurationMs": 2.807,
"taskDurationMs": 335.904,
"heapDeltaBytes": 1631444,
"heapUsedBytes": 76610108,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 109.242,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 902.9250000000104,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.209,
"heapDeltaBytes": -3171392,
"heapUsedBytes": 81340084,
"domNodes": -192,
"jsHeapTotalBytes": 12066816,
"scriptDurationMs": 37.63099999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 257,
"frameDurationMs": 25.7142857142857,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 917.2189999999887,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.3289999999998,
"heapDeltaBytes": -12462336,
"heapUsedBytes": 81737816,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 43.588,
"eventListeners": -106,
"totalBlockingTimeMs": 261,
"frameDurationMs": 25.458333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.4439999999809,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.6780000000001,
"heapDeltaBytes": -4453436,
"heapUsedBytes": 76328164,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 90.10199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 85,
"frameDurationMs": 20.585294117647074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 718.0339999999887,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.28900000000004,
"heapDeltaBytes": -5231420,
"heapUsedBytes": 75820796,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 98.18299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6218.252000000007,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2050000000000003,
"layouts": 4,
"layoutDurationMs": 1.062,
"taskDurationMs": 5063.042,
"heapDeltaBytes": 11462308,
"heapUsedBytes": 88297472,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 4019.62,
"eventListeners": -68,
"totalBlockingTimeMs": 55,
"frameDurationMs": 19.80766773162939,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6374.82,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9380000000000005,
"layouts": 3,
"layoutDurationMs": 0.7630000000000002,
"taskDurationMs": 5140.895,
"heapDeltaBytes": -10350428,
"heapUsedBytes": 83707344,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 3955.1710000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 19,
"frameDurationMs": 19.22620481927711,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6205.218000000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8909999999999995,
"layouts": 3,
"layoutDurationMs": 0.7820000000000001,
"taskDurationMs": 4968.525000000001,
"heapDeltaBytes": -13026264,
"heapUsedBytes": 86802680,
"domNodes": -258,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 3781.1470000000004,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.54874213836478,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6473.493000000019,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8049999999999993,
"layouts": 3,
"layoutDurationMs": 0.719,
"taskDurationMs": 5262.41,
"heapDeltaBytes": 22900152,
"heapUsedBytes": 111051668,
"domNodes": -278,
"jsHeapTotalBytes": 14807040,
"scriptDurationMs": 4083.564999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.271159874608152,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 274.33600000000524,
"styleRecalcs": 25,
"styleRecalcDurationMs": 17.52,
"layouts": 13,
"layoutDurationMs": 3.9840000000000004,
"taskDurationMs": 187.29299999999998,
"heapDeltaBytes": -8329764,
"heapUsedBytes": 79517132,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 11.691999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 13,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 161.89900000000534,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.033000000000001,
"layouts": 13,
"layoutDurationMs": 3.24,
"taskDurationMs": 113.551,
"heapDeltaBytes": -8135640,
"heapUsedBytes": 79125740,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.603999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2027.0330000000172,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.685999999999999,
"layouts": 9,
"layoutDurationMs": 2.46,
"taskDurationMs": 491.145,
"heapDeltaBytes": -2059240,
"heapUsedBytes": 77024400,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 29.094,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.6080000000102,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.568,
"layouts": 8,
"layoutDurationMs": 2.26,
"taskDurationMs": 445.51199999999994,
"heapDeltaBytes": -2179460,
"heapUsedBytes": 76619908,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 28.762999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2493.8439999999955,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.628,
"layouts": 8,
"layoutDurationMs": 2.1559999999999997,
"taskDurationMs": 1197.446,
"heapDeltaBytes": -16909316,
"heapUsedBytes": 80693064,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 576.89,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2302.644999999984,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.748,
"layouts": 9,
"layoutDurationMs": 2.244,
"taskDurationMs": 1135.469,
"heapDeltaBytes": -12254088,
"heapUsedBytes": 67907544,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 539.024,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666423357664236,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3750.3360000000043,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.06,
"layouts": 66,
"layoutDurationMs": 12.37,
"taskDurationMs": 1333.022,
"heapDeltaBytes": -17662288,
"heapUsedBytes": 81712036,
"domNodes": -234,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 585.4399999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666222222222224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3564.580000000035,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.764999999999999,
"layouts": 66,
"layoutDurationMs": 12.603,
"taskDurationMs": 1311.758,
"heapDeltaBytes": -27701864,
"heapUsedBytes": 71469636,
"domNodes": -234,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 546.7169999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467293,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2738.4570000000112,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.103000000000001,
"layouts": 8,
"layoutDurationMs": 2.186,
"taskDurationMs": 1396.615,
"heapDeltaBytes": 2611108,
"heapUsedBytes": 86017272,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 679.477,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3018.82599999999,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.716999999999999,
"layouts": 6,
"layoutDurationMs": 1.6550000000000002,
"taskDurationMs": 1483.7760000000003,
"heapDeltaBytes": 4470544,
"heapUsedBytes": 87520728,
"domNodes": 0,
"jsHeapTotalBytes": 6254592,
"scriptDurationMs": 726.3889999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757458563535913,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.7349999999979,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.438,
"layouts": 9,
"layoutDurationMs": 2.084,
"taskDurationMs": 466.41600000000005,
"heapDeltaBytes": -2538332,
"heapUsedBytes": 79705596,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 29.157000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.3299999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.852000000000001,
"layouts": 9,
"layoutDurationMs": 2.766,
"taskDurationMs": 489.52299999999997,
"heapDeltaBytes": -1404840,
"heapUsedBytes": 79622156,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 29.82,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 464.2059999999901,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.99,
"layouts": 11,
"layoutDurationMs": 2.9070000000000005,
"taskDurationMs": 311.60900000000004,
"heapDeltaBytes": -1071824,
"heapUsedBytes": 75909228,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 101.913,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 479.05900000000656,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.619,
"layouts": 10,
"layoutDurationMs": 2.6719999999999997,
"taskDurationMs": 308.954,
"heapDeltaBytes": -1064516,
"heapUsedBytes": 75923344,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 102.323,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2026.2570000000153,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.974000000000001,
"layouts": 10,
"layoutDurationMs": 2.7059999999999995,
"taskDurationMs": 414.829,
"heapDeltaBytes": -9578652,
"heapUsedBytes": 57783060,
"domNodes": -180,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.169,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2009.9270000000047,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.907000000000001,
"layouts": 10,
"layoutDurationMs": 2.528,
"taskDurationMs": 344.119,
"heapDeltaBytes": -576416,
"heapUsedBytes": 75961064,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.071,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.2890000000023,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.973999999999998,
"layouts": 8,
"layoutDurationMs": 2.157,
"taskDurationMs": 581.0000000000001,
"heapDeltaBytes": 10782704,
"heapUsedBytes": 77726196,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 90.289,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.416000000027,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.471000000000002,
"layouts": 9,
"layoutDurationMs": 2.2600000000000002,
"taskDurationMs": 584.007,
"heapDeltaBytes": 11250136,
"heapUsedBytes": 78695876,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 92.65599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 1084.8859999999831,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.529000000000003,
"layouts": 5,
"layoutDurationMs": 10.113999999999997,
"taskDurationMs": 733.5909999999999,
"heapDeltaBytes": 7185520,
"heapUsedBytes": 103083952,
"domNodes": 15953,
"jsHeapTotalBytes": 16650240,
"scriptDurationMs": 23.181000000000008,
"eventListeners": 3244,
"totalBlockingTimeMs": 80,
"frameDurationMs": 19.00526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8521.489999999972,
"styleRecalcs": 249,
"styleRecalcDurationMs": 23.573,
"layouts": 8,
"layoutDurationMs": 2.017,
"taskDurationMs": 4110.17,
"heapDeltaBytes": 4769968,
"heapUsedBytes": 83828752,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 1889.2859999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666015625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8824.89700000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 24.051,
"layouts": 9,
"layoutDurationMs": 2.4250000000000003,
"taskDurationMs": 4258.813,
"heapDeltaBytes": 6093996,
"heapUsedBytes": 85119212,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 1909.415,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16476.63,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15463.511999999999,
"heapDeltaBytes": 33184592,
"heapUsedBytes": 306258840,
"domNodes": -3330,
"jsHeapTotalBytes": 45076480,
"scriptDurationMs": 222.95199999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.66089965397924,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 12762.355999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12328.496,
"heapDeltaBytes": -8206944,
"heapUsedBytes": 268070556,
"domNodes": -3330,
"jsHeapTotalBytes": 35381248,
"scriptDurationMs": 180.805,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.523450586264655,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "vue-large-graph-pan",
"durationMs": 18196.595999999998,
"styleRecalcs": 142,
"styleRecalcDurationMs": 14.408000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17738.471999999998,
"heapDeltaBytes": -153964,
"heapUsedBytes": 282012472,
"domNodes": -3330,
"jsHeapTotalBytes": 11264000,
"scriptDurationMs": 618.823,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.73333333333334,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 18767.05400000003,
"styleRecalcs": 152,
"styleRecalcDurationMs": 16.404000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18451.087,
"heapDeltaBytes": -7132768,
"heapUsedBytes": 274893328,
"domNodes": -3330,
"jsHeapTotalBytes": 11001856,
"scriptDurationMs": 668.48,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.94599627560521,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5762.761000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.31400000000002,
"layouts": 20,
"layoutDurationMs": 22.416000000000004,
"taskDurationMs": 5630.8640000000005,
"heapDeltaBytes": -23707364,
"heapUsedBytes": 258997916,
"domNodes": -3330,
"jsHeapTotalBytes": 28303360,
"scriptDurationMs": 105.38499999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.94848484848485,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5956.452000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.431000000000004,
"layouts": 20,
"layoutDurationMs": 26.649000000000004,
"taskDurationMs": 5810.231,
"heapDeltaBytes": -21005516,
"heapUsedBytes": 260889016,
"domNodes": -307,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 94.04,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.19310344827586,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8183.141999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7609.654999999998,
"heapDeltaBytes": 19025964,
"heapUsedBytes": 278444964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.458,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.73898305084746,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7912.979999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7507.952999999999,
"heapDeltaBytes": 4573840,
"heapUsedBytes": 269309964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.50000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.973144876325094,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 107.2810000000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.629000000000001,
"layouts": 8,
"layoutDurationMs": 2.965,
"taskDurationMs": 88.42999999999999,
"heapDeltaBytes": -14949576,
"heapUsedBytes": 68503360,
"domNodes": 126,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 13.065999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 91.33100000008199,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.334000000000001,
"layouts": 6,
"layoutDurationMs": 2.6750000000000003,
"taskDurationMs": 68.964,
"heapDeltaBytes": -15586964,
"heapUsedBytes": 68107684,
"domNodes": 117,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 4.650000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 225.75000000006185,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.157,
"layouts": 76,
"layoutDurationMs": 13.073,
"taskDurationMs": 192.124,
"heapDeltaBytes": 8923544,
"heapUsedBytes": 101735552,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 80.641,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 224.474999999984,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.949,
"layouts": 76,
"layoutDurationMs": 11.568,
"taskDurationMs": 186.15300000000002,
"heapDeltaBytes": 9157496,
"heapUsedBytes": 101346620,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 80.978,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 249.25200000006953,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.702,
"layouts": 76,
"layoutDurationMs": 10.422,
"taskDurationMs": 215.40699999999998,
"heapDeltaBytes": -3874396,
"heapUsedBytes": 116218048,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 68.323,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 378.153999999995,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.889,
"layouts": 76,
"layoutDurationMs": 13.818999999999999,
"taskDurationMs": 353.16700000000003,
"heapDeltaBytes": -852204,
"heapUsedBytes": 123792560,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.572,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669565217391288,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2286 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8572a9ce6534f6f16802fbd18903a06c820f860f
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #22554 +/- ##
=============================================
Coverage ? 83.69%
=============================================
Files ? 3079
Lines ? 162297
Branches ? 38420
=============================================
Hits ? 135828
Misses ? 26079
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21332 to
cloud/1.57Automatically created by backport workflow.