Repository navigation
fix(paste): keep name-keyed widget values on pasted custom nodes - #21332
Conversation
Clipboard parsing dropped a node's record-shaped widgets_values and kept only widgets_values_named. ComfyNode.configure then migrated the missing value to [], so VideoHelperSuite's onConfigure saw an empty array and showed "Failed to restore node" for every pasted VHS node. Keep the record as widgets_values, matching workflow load, alongside the named copy.
📦 Bundle: 11.9 MB gzip 🔴 +180 BDetailsSummary
Category Glance App Entry Points — 6.66 kB (baseline 6.66 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 872 kB (baseline 872 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 154 kB (baseline 154 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 8 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 343 kB (baseline 343 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 22 unchanged Data & Services — 1.83 MB (baseline 1.83 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 33 added / 33 removed / 8 unchanged Utilities & Hooks — 2.44 MB (baseline 2.44 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 44 added / 44 removed / 41 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 102 added / 102 removed / 642 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T02:20:23.448Z",
"gitSha": "b9fb1055e9bf0f4541b6debd81f092d2c690ff05",
"branch": "fix/qa157-vhs-paste-connected-node",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.1500000000106,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.921,
"layouts": 10,
"layoutDurationMs": 3.2710000000000004,
"taskDurationMs": 596.2180000000001,
"heapDeltaBytes": 1120608,
"heapUsedBytes": 61133768,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 11.795999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.3310000000083,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.524,
"layouts": 8,
"layoutDurationMs": 2.3519999999999994,
"taskDurationMs": 606.613,
"heapDeltaBytes": 1475020,
"heapUsedBytes": 62720868,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.978,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.1039999999957,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.812,
"layouts": 8,
"layoutDurationMs": 2.301,
"taskDurationMs": 944.965,
"heapDeltaBytes": 21412528,
"heapUsedBytes": 81084036,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 155.635,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678898,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.2800000000361,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.584000000000001,
"layouts": 9,
"layoutDurationMs": 2.6820000000000004,
"taskDurationMs": 955.4659999999999,
"heapDeltaBytes": 23278172,
"heapUsedBytes": 84533452,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 163.09799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.2180000000021,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.949999999999999,
"layouts": 11,
"layoutDurationMs": 3.254,
"taskDurationMs": 488.371,
"heapDeltaBytes": -1311000,
"heapUsedBytes": 59838076,
"domNodes": 57,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 14.412,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.04000000003,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.8389999999999995,
"layouts": 11,
"layoutDurationMs": 3.073,
"taskDurationMs": 446.595,
"heapDeltaBytes": 24008872,
"heapUsedBytes": 85291700,
"domNodes": 57,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.426000000000004,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 825.5680000000041,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.272,
"layouts": 9,
"layoutDurationMs": 3.318,
"taskDurationMs": 569.4899999999999,
"heapDeltaBytes": 2871848,
"heapUsedBytes": 64454160,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 182.234,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663265306122447,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 760.0410000000011,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0409999999999995,
"layouts": 9,
"layoutDurationMs": 2.7179999999999995,
"taskDurationMs": 545.548,
"heapDeltaBytes": 7012084,
"heapUsedBytes": 77501012,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 169.96900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.2360000000137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 920.361,
"heapDeltaBytes": -13744600,
"heapUsedBytes": 75218360,
"domNodes": -203,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 62.94599999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 527,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1275.1199999999585,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 983.9330000000001,
"heapDeltaBytes": -13349556,
"heapUsedBytes": 74911132,
"domNodes": -203,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 64.91599999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 565,
"frameDurationMs": 34.23243243243244,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 834.9039999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.48699999999957,
"heapDeltaBytes": 22360388,
"heapUsedBytes": 87231296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.299,
"eventListeners": 0,
"totalBlockingTimeMs": 190,
"frameDurationMs": 23.805714285714306,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 907.8289999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.0580000000004,
"heapDeltaBytes": -31394736,
"heapUsedBytes": 65930912,
"domNodes": -203,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 146.65699999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 201,
"frameDurationMs": 23.684210526315766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9906.080000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9024.773,
"heapDeltaBytes": 37783816,
"heapUsedBytes": 131992052,
"domNodes": -269,
"jsHeapTotalBytes": 61730816,
"scriptDurationMs": 6910.727,
"eventListeners": -68,
"totalBlockingTimeMs": 490,
"frameDurationMs": 29.90815709969788,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10255.396000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9443.866999999998,
"heapDeltaBytes": 58884048,
"heapUsedBytes": 153374664,
"domNodes": -269,
"jsHeapTotalBytes": 75362304,
"scriptDurationMs": 7380.993,
"eventListeners": -68,
"totalBlockingTimeMs": 648,
"frameDurationMs": 31.24878048780488,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9611.401000000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.29999999999999993,
"layouts": 1,
"layoutDurationMs": 0.38400000000000023,
"taskDurationMs": 8824.300000000001,
"heapDeltaBytes": 39569068,
"heapUsedBytes": 133098744,
"domNodes": -269,
"jsHeapTotalBytes": 56750080,
"scriptDurationMs": 6814.42,
"eventListeners": -68,
"totalBlockingTimeMs": 419,
"frameDurationMs": 30.335015772870666,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9897.155999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9105.16,
"heapDeltaBytes": 47809040,
"heapUsedBytes": 127555184,
"domNodes": -269,
"jsHeapTotalBytes": 61468672,
"scriptDurationMs": 7034.005,
"eventListeners": -68,
"totalBlockingTimeMs": 552,
"frameDurationMs": 31.033228840125386,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 308.4869999999853,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.854,
"layouts": 11,
"layoutDurationMs": 3.492,
"taskDurationMs": 261.98900000000003,
"heapDeltaBytes": -16634692,
"heapUsedBytes": 59052732,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 10.494,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 24.361538461538483,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 314.95499999999765,
"styleRecalcs": 26,
"styleRecalcDurationMs": 16.035,
"layouts": 11,
"layoutDurationMs": 3.4539999999999997,
"taskDurationMs": 278.32800000000003,
"heapDeltaBytes": -10754604,
"heapUsedBytes": 59655068,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 10.670999999999998,
"eventListeners": -640,
"totalBlockingTimeMs": 5,
"frameDurationMs": 24.35384615384618,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2054.257000000007,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.352,
"layouts": 7,
"layoutDurationMs": 2.3499999999999996,
"taskDurationMs": 736.019,
"heapDeltaBytes": 10738136,
"heapUsedBytes": 84851848,
"domNodes": -269,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 43.856,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2056.6749999999843,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3880000000000003,
"layouts": 8,
"layoutDurationMs": 2.3109999999999995,
"taskDurationMs": 698.009,
"heapDeltaBytes": -23005076,
"heapUsedBytes": 63889132,
"domNodes": -269,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 38.846000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2715.765000000005,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.231,
"layouts": 8,
"layoutDurationMs": 2.1400000000000006,
"taskDurationMs": 1876.1129999999996,
"heapDeltaBytes": -15108268,
"heapUsedBytes": 72170616,
"domNodes": -269,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 883.5780000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666257668711655,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2575.2559999999676,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.536,
"layouts": 6,
"layoutDurationMs": 1.9400000000000004,
"taskDurationMs": 1833.2009999999998,
"heapDeltaBytes": -11230620,
"heapUsedBytes": 76877328,
"domNodes": -269,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 830.4250000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665806451612905,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3891.7470000000094,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.685999999999998,
"layouts": 65,
"layoutDurationMs": 11.663,
"taskDurationMs": 1936.896,
"heapDeltaBytes": 7010128,
"heapUsedBytes": 83731252,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 846.3299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609442060086,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3659.17300000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.929999999999998,
"layouts": 64,
"layoutDurationMs": 10.875,
"taskDurationMs": 1845.856,
"heapDeltaBytes": -17476384,
"heapUsedBytes": 72590780,
"domNodes": 24,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 782.0020000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3270.9289999999955,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.3740000000000006,
"layouts": 5,
"layoutDurationMs": 1.612,
"taskDurationMs": 2213.801,
"heapDeltaBytes": -10062324,
"heapUsedBytes": 81554644,
"domNodes": -269,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 1014.8170000000001,
"eventListeners": -63,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.837628865979383,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3285.287999999923,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.590000000000001,
"layouts": 5,
"layoutDurationMs": 1.5799999999999998,
"taskDurationMs": 2184.255,
"heapDeltaBytes": -9092508,
"heapUsedBytes": 82301496,
"domNodes": -269,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 1034.4560000000001,
"eventListeners": -62,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.836923076923075,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3113.997999999981,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8730000000000004,
"layouts": 7,
"layoutDurationMs": 1.9370000000000003,
"taskDurationMs": 843.7340000000002,
"heapDeltaBytes": -26297288,
"heapUsedBytes": 65003368,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 370.996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3190.3749999999604,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.934,
"layouts": 6,
"layoutDurationMs": 1.8360000000000003,
"taskDurationMs": 882.361,
"heapDeltaBytes": -7544720,
"heapUsedBytes": 81963716,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 400.559,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.0679999999916,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5789999999999997,
"layouts": 8,
"layoutDurationMs": 2.61,
"taskDurationMs": 752.942,
"heapDeltaBytes": -23938988,
"heapUsedBytes": 65724164,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 37.324,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.2369999999291,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.698000000000001,
"layouts": 9,
"layoutDurationMs": 2.6539999999999995,
"taskDurationMs": 666.931,
"heapDeltaBytes": -8323004,
"heapUsedBytes": 83418816,
"domNodes": -269,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 31.168000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2894.6109999999976,
"styleRecalcs": 25,
"styleRecalcDurationMs": 10.867999999999999,
"layouts": 6,
"layoutDurationMs": 1.7209999999999999,
"taskDurationMs": 630.1880000000001,
"heapDeltaBytes": -20523504,
"heapUsedBytes": 69147536,
"domNodes": -266,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 189.545,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665317919075143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2892.477999999983,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.74,
"layouts": 6,
"layoutDurationMs": 1.9449999999999996,
"taskDurationMs": 684.131,
"heapDeltaBytes": -26583712,
"heapUsedBytes": 65429148,
"domNodes": -260,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 201.75199999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76220930232558,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3328.4099999999908,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0669999999999993,
"layouts": 7,
"layoutDurationMs": 1.9950000000000003,
"taskDurationMs": 997.6469999999999,
"heapDeltaBytes": -13999104,
"heapUsedBytes": 77329104,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 382.67300000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3487.6970000000256,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7169999999999999,
"layouts": 6,
"layoutDurationMs": 1.626,
"taskDurationMs": 1098.596,
"heapDeltaBytes": -26955612,
"heapUsedBytes": 62258548,
"domNodes": -269,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 432.76099999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74615384615385,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.9040000000259,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.148,
"layouts": 8,
"layoutDurationMs": 2.125,
"taskDurationMs": 460.134,
"heapDeltaBytes": -11728,
"heapUsedBytes": 62552144,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 144.75,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 635.9150000000682,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.208,
"layouts": 8,
"layoutDurationMs": 2.2539999999999996,
"taskDurationMs": 454.59700000000004,
"heapDeltaBytes": 3053760,
"heapUsedBytes": 75575628,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 139.814,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.3389999999888,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.012,
"layouts": 9,
"layoutDurationMs": 2.803,
"taskDurationMs": 579.677,
"heapDeltaBytes": 1373180,
"heapUsedBytes": 63308468,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.151000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.6009999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6629999999999994,
"layouts": 9,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 574.9329999999999,
"heapDeltaBytes": 1573760,
"heapUsedBytes": 63370728,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.684,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1790.6619999999975,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.535,
"layouts": 9,
"layoutDurationMs": 2.5380000000000003,
"taskDurationMs": 946.636,
"heapDeltaBytes": 18938792,
"heapUsedBytes": 80491880,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 114.81099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.844000000015,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.012,
"layouts": 7,
"layoutDurationMs": 2.2149999999999994,
"taskDurationMs": 918.826,
"heapDeltaBytes": 17518812,
"heapUsedBytes": 79468952,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 111.986,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1485.0629999999683,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.837999999999994,
"layouts": 5,
"layoutDurationMs": 13.450000000000003,
"taskDurationMs": 1133.9979999999998,
"heapDeltaBytes": 14112608,
"heapUsedBytes": 116414840,
"domNodes": 16029,
"jsHeapTotalBytes": 10096640,
"scriptDurationMs": 35.71799999999999,
"eventListeners": 3246,
"totalBlockingTimeMs": 159,
"frameDurationMs": 20.04594594594594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9658.815999999944,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.917,
"layouts": 7,
"layoutDurationMs": 2.3679999999999994,
"taskDurationMs": 6720.928,
"heapDeltaBytes": -20658016,
"heapUsedBytes": 65548656,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 3018.006,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69498269896194,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8855.06399999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 28.991,
"layouts": 6,
"layoutDurationMs": 1.586,
"taskDurationMs": 6341.155,
"heapDeltaBytes": -29673692,
"heapUsedBytes": 62577856,
"domNodes": -269,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 2794.01,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697547169811322,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20966.879000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20444.965,
"heapDeltaBytes": -303740,
"heapUsedBytes": 283364144,
"domNodes": -3343,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 279.54,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.29835466179159,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 21035.34000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20707.932,
"heapDeltaBytes": -18901492,
"heapUsedBytes": 283305132,
"domNodes": -3343,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 298.33700000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.454092526690395,
"p95FrameDurationMs": 66.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 26054.783000000043,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.871000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25720.289,
"heapDeltaBytes": -16680448,
"heapUsedBytes": 260980924,
"domNodes": -3343,
"jsHeapTotalBytes": 11264000,
"scriptDurationMs": 902.836,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 49.99808061420346,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25324.67799999995,
"styleRecalcs": 180,
"styleRecalcDurationMs": 21.932000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25066.73,
"heapDeltaBytes": -22884236,
"heapUsedBytes": 259751620,
"domNodes": -3343,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 923.16,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 47.79679245283019,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7722.597000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.14399999999999,
"layouts": 20,
"layoutDurationMs": 30.694000000000013,
"taskDurationMs": 7615.1489999999985,
"heapDeltaBytes": -11890224,
"heapUsedBytes": 266023396,
"domNodes": -3343,
"jsHeapTotalBytes": 10477568,
"scriptDurationMs": 118.849,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.108379888268146,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7522.768999999926,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.62700000000001,
"layouts": 20,
"layoutDurationMs": 29.903,
"taskDurationMs": 7431.558,
"heapDeltaBytes": -25464072,
"heapUsedBytes": 256714432,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 117.74099999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.641666666666666,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10249.075000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10005.543999999998,
"heapDeltaBytes": -722168,
"heapUsedBytes": 262410416,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.28999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.19673913043478,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10308.170000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10077.863000000001,
"heapDeltaBytes": -8908524,
"heapUsedBytes": 273327440,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 135.83200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.843571428571416,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 145.66200000001572,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.157,
"layouts": 9,
"layoutDurationMs": 3.621,
"taskDurationMs": 112.25600000000001,
"heapDeltaBytes": 4733200,
"heapUsedBytes": 64627012,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.482,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 141.65000000002692,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.368,
"layouts": 9,
"layoutDurationMs": 5.445,
"taskDurationMs": 99.114,
"heapDeltaBytes": 4623172,
"heapUsedBytes": 65727292,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.055000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 445.9229999999934,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.66,
"layouts": 76,
"layoutDurationMs": 16.2,
"taskDurationMs": 401.45699999999994,
"heapDeltaBytes": -5589752,
"heapUsedBytes": 37695476,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 175.78500000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 492.5539999999273,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6669999999999999,
"layouts": 76,
"layoutDurationMs": 16.582,
"taskDurationMs": 447.978,
"heapDeltaBytes": -4502520,
"heapUsedBytes": 40081216,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 204.33499999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 694.5869999999559,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9400000000000002,
"layouts": 76,
"layoutDurationMs": 18.468,
"taskDurationMs": 667.3439999999999,
"heapDeltaBytes": 1918152,
"heapUsedBytes": 95785320,
"domNodes": 4,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 275.087,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 602.0340000000033,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.807,
"layouts": 76,
"layoutDurationMs": 16.074,
"taskDurationMs": 555.712,
"heapDeltaBytes": 2253868,
"heapUsedBytes": 99510264,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 220.797,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888906,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3155 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 23359f8f670059dcb8e13a66ea2f1c2ad5c42584
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (272)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Preserve and verify widget values packages/graph-model/src/workflowSchema.ts, src/platform/workflow/validation/schemas/workflowSchema.test.ts, browser_tests/tests/customNodes/vhsCopyPaste.spec.ts |
The normalizer retains record-shaped values in widgets_values and copies them to widgets_values_named. The schema test checks the record values. The VHS browser test copies and pastes connected nodes, then checks the pasted loader’s widgets, connections, and background color. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21584: Preserves record-shaped widget values when opening saved custom-node workflows.
Merge Risk: 
Minimal · up to ae240
-
Pasted custom nodes such as VHS nodes now keep their name-keyed widget values instead of showing a restore failure. No concrete regression was found in the paste path, so this is ready to merge after normal CI checks, including the copy/paste browser tests the author could not run locally.
Pre-merge checks: 
6
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes application code under
packages/graph-model/to preserve named widget values during paste. The trigger is user-facing: copy and paste connected VHS custom nodes. The PR addsbrowser_tests/tests/customNodes/vhsCopyPaste.spec.ts, which exercises this flow. This check encourages but does not require an end-to-end test, and the suggested test is present.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The PR changes clipboard widget-value normalization and adds tests. The changed files do not add entity methods or properties, mutate node/group spatial state, introduce component methods or back-references, or change extension-facing callbacks, node.widgets access, serialization overrides, or graph version handling. No ADR-LAYOUT or ADR-ECS pattern is present in the supplied diff.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21332 +/- ##
==========================================
- Coverage 87.46% 87.46% -0.01%
==========================================
Files 2923 2923
Lines 158503 158503
Branches 41452 44681 +3229
==========================================
- Hits 138631 138627 -4
- Misses 18951 18955 +4
Partials 921 921
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…s when the Agent opens it (PM-2018) (Comfy-Org#21584) ## Summary Fixes [PM-2018](https://linear.app/comfyorg/issue/PM-2018): a saved VideoHelperSuite workflow opened by the Agent lost its output node and its saved values on the canvas. - Video Combine kept: the applier's slot schema now accepts list-typed slot types, as workflow load does. - Load Video keeps its values: a name-keyed opaque widget record now reaches `configure` verbatim, as a hand-opened workflow does, on creation and on a later edit or reopen of the same node. - The PM-2018 harness case opens the workflow, then applies an Agent edit to the record; red on the parent at each step. <details><summary>Full context for agent readers</summary> ### Defect Reproduced live 2 of 2 times: published `comfy-agent[go-nonfree]==0.1.0rc2` on Linux x86_64, ComfyUI master `faa7e494`, ComfyUI-VideoHelperSuite `4d907bee`, frontend 1.59.0. A VHS Load Video -> Invert Image -> Video Combine workflow runs without the Agent. After the Agent's `open_workflow` loads it, VHS shows "Failed to restore node: Load Video (Upload)", the node turns red, Video Combine is absent, and Run returns `prompt_no_outputs`. The stored document is faithful (decoded from the local agent DB); the loss is in `liveGraphApplier.ts`: 1. `zDocSlot.type` was `string | number`. VHS appends per-format widgets as input slots whose `type` is the option list, so `readDocNode` reported `agent_graph_node_malformed` and the node was never created. 2. `readDocNode` read `OPAQUE_WIDGETS_KEY` only when it is an array. The doc host's mint (`quarantineDictWidgets`, in both the local rc2 sidecar and `cloud` `services/agent/dochost/src/server.ts`) stores an undeclared name-keyed `widgets_values` there as a plain object, so the node was configured with no values and VHS's `useKVState` rejected the empty list. ### Fix - `zDocSlot.type` accepts `string | string[] | number`, the same union as the workflow schema's `zDataType` and litegraph's `ISlotType`. - `readDocNode` keeps a plain-object opaque value as `widgetRecord`. `createNode` passes it as `widgets_values` to `node.configure`, exactly what `loadGraphData` hands a custom node that serializes a record. Positional and named document widgets take the existing path unchanged. On an edit or a same-node reopen, a registered node is re-configured from its own serialization with the record as `widgets_values` (the same contract as creation, so the extension's `onConfigure` owns it), and a missing-node placeholder gets its `last_serialization.widgets_values` refreshed. A named widget map wins over a record beside it. - External constraint behind the one type assertion: `ISerialisedNode.widgets_values` is typed `TWidgetValue[]`, while its JSDoc already records that custom nodes (it links VHS) store an object there. Widening that shared type touches every consumer; Comfy-Org#21332 makes the same call for paste. - Graph API only: no reconcile pass, no store-direct write. - Slot types accept non-empty string lists; empty lists stay malformed (`too_small`). ### Review follow-ups (CodeRabbit) - Spec comments removed; the fixture data moved to `browser_tests/fixtures/data/agent/agentVhsSavedWorkflow.ts` and the boot, VHS restore stand-in, canvas reader and document send to `browser_tests/fixtures/agentVhsSavedWorkflowFixture.ts`. - The saved workflow is parsed with `zComfyWorkflow`, leaving one assertion at the `HostDoc` boundary. - `HostDoc.quarantineRecordWidgets` JSDoc shortened. It mirrors the doc host's quarantine step, because the frontend's pinned comfy-multi-player `mint()` alone keeps a record name-keyed. - VHS's script is not loaded in the harness, so a minimal `onConfigure` stands in for VHS `useKVState` (restore a name-keyed `widgets_values` by widget name, and keep its `videopreview` entry). The hand-load control was removed in review: the Agent case already fails without the fix and without the stand-in. </details> ## Verification - `agentOpenWorkflowCustomNodeState.spec.ts --project=cloud`: applier at the merge base fails at the open step (`VHS_VideoCombine` missing, `frame_load_cap` 0, `filename_prefix` undefined); applier before the update-path fix fails at the edit step (preview stays `clip.mp4`). With the fix: 2/2 passed (`--repeat-each=2`). - `vitest src/workbench/extensions/agent/crdt/`: 1174 passed, 1 expected fail. - `vitest src/workbench/extensions/agent/`: 4036 passed; one `useAttachment` case failed once under load and passes alone (unrelated). - `pnpm typecheck`, `typecheck:browser`, `oxlint --type-aware`, pre-commit and pre-push hooks: clean.
dante01yoon
left a comment
There was a problem hiding this comment.
Looks good. Root cause and fix match: normalizeClipboardNodeWidgets stopped dropping the record, so paste now hands VHS's onConfigure the same record that workflow load does. createWidgetRestorationState still reads widgets_values_named for the named path, and Array.from(record) keeps the positional path an empty list as before. Gate 1 is met: the unit test fails on main, and the @custom-nodes e2e reproduces the restore dialog. The as unknown as TWidgetValue[] sits at the boundary where ISerialisedNode.widgets_values is documented as possibly an object for custom nodes, and the reason is stated in the description, so I'm fine with it here.
|
@christian-byrne Successfully backported to #22553 |
|
@christian-byrne Successfully backported to #22554 |
|
Thank you for the fix!! Made a PowerShell 7 patch to fix this issue on existing ComfyUI install, until the fix is implemented officially: Check first, without modifying anything. .\Fix-VHS-Clipboard-1576.ps1 -Action Check Apply the patch: Rollback, if necessary: Copy below code into "Fix-VHS-Clipboard-1576.ps1" |
Summary
widgets_values(from fix(litegraph): recover graph ID allocation safely #19239)Full context for agent readers
Bug
From the 1.57 release QA thread: https://comfy-organization.slack.com/archives/C0932CGKT5K/p1791952563933479
Local, Nodes 2.0 on, ComfyUI-VideoHelperSuite installed. Connect a Load Video (Upload) node (
meta_batchin,frame_countout), select the connected nodes, Ctrl+C, Ctrl+V. The dialog "Failed to restore node: Load Video (Upload) ... Please remove and re-add it." appears, and the pasted node turns red and loses its widget values. Meta Batch Manager fails the same way. Root cause identified by Austin Mroz.Root cause
VHS's
onSerializewriteswidgets_valuesas a name-keyed record. #19239 addednormalizeClipboardNodeWidgetstozClipboardNode. For a record without a numericlength, it setwidgets_values: undefinedand kept onlywidgets_values_named.ComfyNode.configurethen ranmigrateWidgetsValues(..., data.widgets_values ?? []), so VHS'sonConfigurereceived[]. VHS treats that as a list whose length does not match the widget count, so it shows the dialog and setsbgcolor = #C00. Workflow load never strips the record, so only paste was broken.Fix
normalizeClipboardNodeWidgetsnow passes the record through aswidgets_valuesand still sets thewidgets_values_namedcopy. That restores how paste behaved before #19239, and it matches workflow load. Theas unknown as TWidgetValue[]cast followsISerialisedNode.widgets_values, whose JSDoc already says custom nodes (it links to VHS) store an object there. Widening that shared type would touch every consumer, so this PR does not do it.The Alt-drag clone height flicker from the same report comes from VHS itself and is out of scope.
Red -> green
browser_tests/tests/customNodes/vhsCopyPaste.spec.ts(@custom-nodes, Nodes 2.0 on) builds Meta Batch Manager -> Load Video -> KSampler.seed, setsforce_rateto 12, then copies and pastes all three. It asserts that no restore dialog appears, the widgets match,bgcoloris unset, and both links are restored.expect(locator).toBeHidden() failed ... Received: visibleon the "Failed to restore node" dialog. Instrumentation showed that VHSonConfigurereceivedwidgets_values=[].--repeat-each=2, 2/2).ecsMigrationScenarios.spec.tsVHS cases still pass.workflowSchema.test.ts"keeps named-record widget values for custom nodes that read them back": fails on main (expected undefined to deeply equal { seed: 42, steps: 20 }) and passes here.workflowSchema,usePaste, andLGraphCanvas.clipboardtests: 142/142.Run locally against ComfyUI 0.28.0 + VHS @115de7a + devtools, with the frontend
dist/served by the backend. The Vite dev server stubs/api/extensionsto[], so VHS JS never loads there and the bug cannot reproduce in that setup.Not verified locally:
browser_tests/tests/copyPaste.spec.ts(chromium project). Against this custom-node backend, 6 of its tests fail on canvas click interception and screenshot diffs, because it is not the default e2e backend. Those tests were not run on main in the same environment, so CI is the check for them.