Skip to content

[backport cloud/1.59] offer a compatible deployment when opening a workflow (#21587) - #22539

Merged
benceruleanlu merged 1 commit into
bl/cloud-1.59-missing-node-deployment-offerfrom
bl/cloud-1.59-compatible-deployment-switch
Nov 3, 2026
Merged

benceruleanlu merged 1 commit into
bl/cloud-1.59-missing-node-deployment-offerfrom
bl/cloud-1.59-compatible-deployment-switch

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

Backport of #21587 to cloud/1.59. The workflow's deployment dialog offers Switch to a ready deployment that can run it, or creation when none can. Unsaved-work confirmation and stale-workflow guards are preserved.

Part 7 of 9 in the Cloud workflow deployment backport stack. Uses 1.59's local Select components, including the source PR's two SelectItem props, and release-branch telemetry imports. No unrelated module moves are included.

Verification

  • Rebuilt on cloud/1.59 at 7482c071; application typecheck passes on every layer. The expanded stack, including deployment Start/Retry, passes 23,186 of 23,187 affected tests across 1,269 files; the one failure, in SignUpForm.test.ts, is intermittent and also fails on cloud/1.59 without this stack. Formatting, affected-file lint, dependency audit and pre-push checks pass.
  • The original feature was exercised against test cloud at cc9bd948, including a successful job after switching deployments. Browser QA has not been repeated on this release-branch build.
  • Known behavior from that QA remains: an open offer can switch to a deployment stopped after the offer opened; ordinary reload restores only the active workflow tab. These are not fixed in this backport.

@benceruleanlu
benceruleanlu requested review from a team and dante01yoon as code owners October 31, 2026 22:25
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T22:27:15.029119Z 2553c29 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⏳ Size data collection in progress…

⚡ Performance: ❌ 7 below 52 FPS target · ℹ️ No baseline — significance unavailable

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Details
Scenario timings

canvas-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap
canvas-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.5 MB heap
canvas-zoom-sweep: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
dom-widget-clipping: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
dom-widget-order-dense-n200-w200-i120: 30.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 553ms TBT · 72.3 MB heap
dom-widget-order-sparse-n1000-w20-i120: 40.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 227ms TBT · 64.8 MB heap
extension-clean-combined-draw: 31.6 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 1125ms TBT · 151.1 MB heap
extension-rgthree-prototype-draw: 32.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 984ms TBT · 132.8 MB heap
large-combo-open: 41.9 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 6ms TBT · 63.4 MB heap
large-graph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
large-graph-pan: 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
large-graph-zoom: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
legacy-node-drag: 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
minimap-geometry-cadence: 59.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
minimap-idle: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
minimap-progress-execution-cadence: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap
minimap-topology-cadence: 59.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.4 MB heap
subgraph-dom-widget-clipping: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
subgraph-idle: 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
subgraph-mouse-sweep: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.5 MB heap
subgraph-transition-enter: 50.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 168ms TBT · 108.3 MB heap
viewport-pan-sweep: 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap
vue-large-graph-idle: 24.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 247.0 MB heap
vue-large-graph-pan: 19.1 avg FPS · 9.2 P5 FPS ❌ (target: ≥52) · 86ms TBT · 265.5 MB heap
vue-node-resize-workload: 20.7 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 245.3 MB heap
vue-zoom-out-idle: 24.8 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 267.7 MB heap
workflow-execution: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
agent-composer-empty-conversation-typing: 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 37.9 MB heap
agent-composer-long-conversation-typing: 59.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.4 MB heap

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 9
canvas-idle: style recalc count 10
canvas-idle: task duration 543ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.4 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 917ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 80.5 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 10
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 403ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.5 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 9
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 529ms
dom-widget-clipping: script duration 180ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 69.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 33ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 964ms
dom-widget-order-dense-n200-w200-i120: script duration 74ms
dom-widget-order-dense-n200-w200-i120: TBT 553ms
dom-widget-order-dense-n200-w200-i120: heap used 72.3 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -191
dom-widget-order-dense-n200-w200-i120: event listeners -107
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 531ms
dom-widget-order-sparse-n1000-w20-i120: script duration 171ms
dom-widget-order-sparse-n1000-w20-i120: TBT 227ms
dom-widget-order-sparse-n1000-w20-i120: heap used 64.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -96
dom-widget-order-sparse-n1000-w20-i120: event listeners -54
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 10202ms
extension-clean-combined-draw: script duration 8220ms
extension-clean-combined-draw: TBT 1125ms
extension-clean-combined-draw: heap used 151.1 MB
extension-clean-combined-draw: DOM nodes -257
extension-clean-combined-draw: event listeners -69
extension-rgthree-prototype-draw: avg frame time 31ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 1
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 9752ms
extension-rgthree-prototype-draw: script duration 7786ms
extension-rgthree-prototype-draw: TBT 984ms
extension-rgthree-prototype-draw: heap used 132.8 MB
extension-rgthree-prototype-draw: DOM nodes -257
extension-rgthree-prototype-draw: event listeners -69
large-combo-open: avg frame time 24ms
large-combo-open: p95 frame time 100ms
large-combo-open: layout duration 4ms
large-combo-open: style recalc duration 15ms
large-combo-open: layout count 12
large-combo-open: style recalc count 26
large-combo-open: task duration 255ms
large-combo-open: script duration 11ms
large-combo-open: TBT 6ms
large-combo-open: heap used 63.4 MB
large-combo-open: DOM nodes -690
large-combo-open: event listeners -185
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 7
large-graph-idle: style recalc count 8
large-graph-idle: task duration 614ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 62.4 MB
large-graph-idle: DOM nodes -257
large-graph-idle: event listeners -69
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 1ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 6
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1694ms
large-graph-pan: script duration 837ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.4 MB
large-graph-pan: DOM nodes -129
large-graph-pan: event listeners -33
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 63
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1857ms
large-graph-zoom: script duration 825ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 78.1 MB
large-graph-zoom: DOM nodes -233
large-graph-zoom: event listeners -69
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 4
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2001ms
legacy-node-drag: script duration 974ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.7 MB
legacy-node-drag: DOM nodes -129
legacy-node-drag: event listeners 148
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 5
minimap-geometry-cadence: style recalc count 6
minimap-geometry-cadence: task duration 843ms
minimap-geometry-cadence: script duration 391ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 75.9 MB
minimap-geometry-cadence: DOM nodes -257
minimap-geometry-cadence: event listeners -69
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 8
minimap-idle: style recalc count 9
minimap-idle: task duration 660ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.5 MB
minimap-idle: DOM nodes -257
minimap-idle: event listeners -69
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 1ms
minimap-progress-execution-cadence: style recalc duration 12ms
minimap-progress-execution-cadence: layout count 5
minimap-progress-execution-cadence: style recalc count 24
minimap-progress-execution-cadence: task duration 625ms
minimap-progress-execution-cadence: script duration 203ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 62.9 MB
minimap-progress-execution-cadence: DOM nodes -118
minimap-progress-execution-cadence: event listeners -35
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 1ms
minimap-topology-cadence: layout count 6
minimap-topology-cadence: style recalc count 6
minimap-topology-cadence: task duration 1025ms
minimap-topology-cadence: script duration 406ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 60.4 MB
minimap-topology-cadence: DOM nodes -257
minimap-topology-cadence: event listeners -69
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 450ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 59.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 537ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.6 MB
subgraph-idle: DOM nodes -92
subgraph-idle: event listeners -58
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 856ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 59.5 MB
subgraph-mouse-sweep: DOM nodes -92
subgraph-mouse-sweep: event listeners -55
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1211ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 168ms
subgraph-transition-enter: heap used 108.3 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3246
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 3ms
viewport-pan-sweep: style recalc duration 28ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6046ms
viewport-pan-sweep: script duration 2764ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.1 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -67
vue-large-graph-idle: avg frame time 40ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 22900ms
vue-large-graph-idle: script duration 328ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 247.0 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 52ms
vue-large-graph-pan: p95 frame time 108ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 27984ms
vue-large-graph-pan: script duration 902ms
vue-large-graph-pan: TBT 86ms
vue-large-graph-pan: heap used 265.5 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 48ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8373ms
vue-node-resize-workload: script duration 127ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 245.3 MB
vue-node-resize-workload: DOM nodes -3343
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 40ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 11490ms
vue-zoom-out-idle: script duration 162ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 267.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 5ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 10
workflow-execution: style recalc count 14
workflow-execution: task duration 120ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.2 MB
workflow-execution: DOM nodes 132
workflow-execution: event listeners 6
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 15ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 419ms
agent-composer-empty-conversation-typing: script duration 197ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 37.9 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 15ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 550ms
agent-composer-long-conversation-typing: script duration 227ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 93.4 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-11-03T00:08:07.772Z",
  "gitSha": "4b79ecd39610106632594bc4e37fe4a25453a866",
  "branch": "bl/cloud-1.59-compatible-deployment-switch",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2031.0159999999655,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.444,
      "layouts": 9,
      "layoutDurationMs": 2.6290000000000004,
      "taskDurationMs": 535.208,
      "heapDeltaBytes": 4840624,
      "heapUsedBytes": 75126336,
      "domNodes": 0,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 8.254999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.429999999962,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.783,
      "layouts": 9,
      "layoutDurationMs": 2.678,
      "taskDurationMs": 549.964,
      "heapDeltaBytes": 2307752,
      "heapUsedBytes": 64215600,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 10.314,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1758.1579999999803,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 12.511999999999999,
      "layouts": 9,
      "layoutDurationMs": 3.0469999999999997,
      "taskDurationMs": 885.149,
      "heapDeltaBytes": 21966336,
      "heapUsedBytes": 83606432,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 161.103,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1810.6599999999844,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 13.897000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.6319999999999997,
      "taskDurationMs": 948.387,
      "heapDeltaBytes": 24199844,
      "heapUsedBytes": 85279788,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 172.80300000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66605504587156,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.5609999999651,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 4.4990000000000006,
      "layouts": 10,
      "layoutDurationMs": 2.7250000000000005,
      "taskDurationMs": 388.30899999999997,
      "heapDeltaBytes": 42468,
      "heapUsedBytes": 61274244,
      "domNodes": 56,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 10.159999999999998,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66764705882353,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1705.428999999981,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.311999999999999,
      "layouts": 10,
      "layoutDurationMs": 4.194,
      "taskDurationMs": 417.22800000000007,
      "heapDeltaBytes": 24683464,
      "heapUsedBytes": 86653120,
      "domNodes": 56,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 11.595999999999998,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 651.3300000000299,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.3000000000000003,
      "layouts": 9,
      "layoutDurationMs": 2.4219999999999997,
      "taskDurationMs": 493.35100000000006,
      "heapDeltaBytes": 7340144,
      "heapUsedBytes": 68746112,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 173.414,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669230769230754,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 829.9590000000308,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.894999999999999,
      "layouts": 8,
      "layoutDurationMs": 2.6350000000000002,
      "taskDurationMs": 565.1050000000001,
      "heapDeltaBytes": 6638740,
      "heapUsedBytes": 77446836,
      "domNodes": 0,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 186.62300000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665306122448985,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1214.585999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 897.906,
      "heapDeltaBytes": -13850980,
      "heapUsedBytes": 75722244,
      "domNodes": -191,
      "jsHeapTotalBytes": 22028288,
      "scriptDurationMs": 70.118,
      "eventListeners": -107,
      "totalBlockingTimeMs": 522,
      "frameDurationMs": 32.88108108108109,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1287.8010000000586,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1029.5990000000002,
      "heapDeltaBytes": -11933964,
      "heapUsedBytes": 75970444,
      "domNodes": -191,
      "jsHeapTotalBytes": 22028288,
      "scriptDurationMs": 77.183,
      "eventListeners": -107,
      "totalBlockingTimeMs": 583,
      "frameDurationMs": 33.771052631578954,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 861.6159999999695,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.5680000000001,
      "heapDeltaBytes": -4790128,
      "heapUsedBytes": 69943532,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 170.64200000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 223,
      "frameDurationMs": 24.76000000000001,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 893.6380000000099,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 562.5959999999997,
      "heapDeltaBytes": -14298156,
      "heapUsedBytes": 65881864,
      "domNodes": -191,
      "jsHeapTotalBytes": 917504,
      "scriptDurationMs": 172.211,
      "eventListeners": -107,
      "totalBlockingTimeMs": 231,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10848.951,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9958.9,
      "heapDeltaBytes": 85440952,
      "heapUsedBytes": 160750356,
      "domNodes": -257,
      "jsHeapTotalBytes": 71430144,
      "scriptDurationMs": 8010.849,
      "eventListeners": -69,
      "totalBlockingTimeMs": 1110,
      "frameDurationMs": 31.723684210526315,
      "p95FrameDurationMs": 66.5
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11208.153999999979,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10445.644,
      "heapDeltaBytes": 82022428,
      "heapUsedBytes": 156174864,
      "domNodes": -257,
      "jsHeapTotalBytes": 70905856,
      "scriptDurationMs": 8428.806,
      "eventListeners": -69,
      "totalBlockingTimeMs": 1140,
      "frameDurationMs": 31.548169014084507,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10187.663000000015,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.046000000000000034,
      "layouts": 1,
      "layoutDurationMs": 0.27899999999999975,
      "taskDurationMs": 9442.167000000001,
      "heapDeltaBytes": 48691988,
      "heapUsedBytes": 131626484,
      "domNodes": -257,
      "jsHeapTotalBytes": 67235840,
      "scriptDurationMs": 7536.2210000000005,
      "eventListeners": -69,
      "totalBlockingTimeMs": 855,
      "frameDurationMs": 31.19113149847095,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10862.089999999967,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.22900000000000004,
      "layouts": 1,
      "layoutDurationMs": 0.21300000000000008,
      "taskDurationMs": 10062.131000000001,
      "heapDeltaBytes": 73665652,
      "heapUsedBytes": 146843880,
      "domNodes": -257,
      "jsHeapTotalBytes": 66449408,
      "scriptDurationMs": 8036.203,
      "eventListeners": -69,
      "totalBlockingTimeMs": 1113,
      "frameDurationMs": 31.314409221902018,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 262.39100000000803,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 12.594999999999999,
      "layouts": 11,
      "layoutDurationMs": 3.083,
      "taskDurationMs": 213.63899999999998,
      "heapDeltaBytes": -741792,
      "heapUsedBytes": 69147052,
      "domNodes": -2315,
      "jsHeapTotalBytes": -1048576,
      "scriptDurationMs": 8.747,
      "eventListeners": -574,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 22.727272727272727,
      "p95FrameDurationMs": 83.40000000000009
    },
    {
      "name": "large-combo-open",
      "durationMs": 345.28499999998985,
      "styleRecalcs": 27,
      "styleRecalcDurationMs": 17.742,
      "layouts": 12,
      "layoutDurationMs": 4.880999999999999,
      "taskDurationMs": 295.794,
      "heapDeltaBytes": -19054200,
      "heapUsedBytes": 63713932,
      "domNodes": 936,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 12.481,
      "eventListeners": 205,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 116.60000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.888000000015,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.9620000000000002,
      "layouts": 8,
      "layoutDurationMs": 2.02,
      "taskDurationMs": 626.123,
      "heapDeltaBytes": -14448512,
      "heapUsedBytes": 60126724,
      "domNodes": -257,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 34.00399999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.5400000000018,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.9710000000000005,
      "layouts": 6,
      "layoutDurationMs": 1.5139999999999998,
      "taskDurationMs": 601.0459999999999,
      "heapDeltaBytes": 10703632,
      "heapUsedBytes": 70648620,
      "domNodes": -257,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.431000000000008,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2452.6149999999802,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 7.366999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.6790000000000004,
      "taskDurationMs": 1633.5859999999998,
      "heapDeltaBytes": 15210568,
      "heapUsedBytes": 76364796,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 816.158,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666438356164385,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2565.539000000058,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 9.087,
      "layouts": 8,
      "layoutDurationMs": 2.1799999999999997,
      "taskDurationMs": 1753.594,
      "heapDeltaBytes": -4801628,
      "heapUsedBytes": 86054684,
      "domNodes": -257,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 857.848,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.77516339869281,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3842.1450000000164,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 8.695,
      "layouts": 61,
      "layoutDurationMs": 9.772,
      "taskDurationMs": 1848.9340000000002,
      "heapDeltaBytes": 6990468,
      "heapUsedBytes": 79669956,
      "domNodes": -233,
      "jsHeapTotalBytes": 2486272,
      "scriptDurationMs": 827.261,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665652173913045,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3981.469000000061,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.4,
      "layouts": 65,
      "layoutDurationMs": 11.350999999999999,
      "taskDurationMs": 1864.4510000000002,
      "heapDeltaBytes": 4657208,
      "heapUsedBytes": 84092868,
      "domNodes": -233,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 823.202,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666108786610877,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3105.1799999999616,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.6739999999999995,
      "layouts": 4,
      "layoutDurationMs": 0.9369999999999999,
      "taskDurationMs": 1975.9569999999999,
      "heapDeltaBytes": 21979980,
      "heapUsedBytes": 103114164,
      "domNodes": 0,
      "jsHeapTotalBytes": 5922816,
      "scriptDurationMs": 970.3389999999998,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.847282608695654,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3175.3549999999677,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.1579999999999995,
      "layouts": 4,
      "layoutDurationMs": 1.4309999999999996,
      "taskDurationMs": 2026.1480000000001,
      "heapDeltaBytes": -1486388,
      "heapUsedBytes": 70405328,
      "domNodes": -257,
      "jsHeapTotalBytes": 2187264,
      "scriptDurationMs": 978.586,
      "eventListeners": 113,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.753968253968253,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3085.836000000029,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.8000000000000005,
      "layouts": 5,
      "layoutDurationMs": 1.5480000000000003,
      "taskDurationMs": 783.1239999999999,
      "heapDeltaBytes": -13484420,
      "heapUsedBytes": 79224744,
      "domNodes": -257,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 364.9,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.755978260869565,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 3203.482000000008,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.9059999999999997,
      "layouts": 5,
      "layoutDurationMs": 2.0610000000000004,
      "taskDurationMs": 903.2860000000001,
      "heapDeltaBytes": -12546600,
      "heapUsedBytes": 79894760,
      "domNodes": -257,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 416.198,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75287958115183,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.728000000011,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.192,
      "layouts": 8,
      "layoutDurationMs": 2.279000000000001,
      "taskDurationMs": 636.8929999999999,
      "heapDeltaBytes": -18122616,
      "heapUsedBytes": 62358352,
      "domNodes": -257,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 32.647,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2048.129999999901,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.4879999999999995,
      "layouts": 8,
      "layoutDurationMs": 2.247,
      "taskDurationMs": 683.419,
      "heapDeltaBytes": -15722212,
      "heapUsedBytes": 77039272,
      "domNodes": -257,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 34.214999999999996,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2745.089000000007,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 11.074,
      "layouts": 4,
      "layoutDurationMs": 0.8650000000000003,
      "taskDurationMs": 535.6110000000001,
      "heapDeltaBytes": 378676,
      "heapUsedBytes": 62557588,
      "domNodes": 19,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 184.743,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666060606060604,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 3047.8109999999106,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 12.749,
      "layouts": 5,
      "layoutDurationMs": 1.761,
      "taskDurationMs": 713.508,
      "heapDeltaBytes": -7216120,
      "heapUsedBytes": 69380952,
      "domNodes": -254,
      "jsHeapTotalBytes": 5632000,
      "scriptDurationMs": 221.77400000000003,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666120218579234,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3257.8510000000165,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.576,
      "layouts": 6,
      "layoutDurationMs": 1.3959999999999997,
      "taskDurationMs": 949.385,
      "heapDeltaBytes": -16462708,
      "heapUsedBytes": 62502540,
      "domNodes": -257,
      "jsHeapTotalBytes": 5632000,
      "scriptDurationMs": 370.779,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.752307692307692,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3449.491999999964,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.3470000000000002,
      "layouts": 5,
      "layoutDurationMs": 1.703,
      "taskDurationMs": 1100.4619999999998,
      "heapDeltaBytes": -16127576,
      "heapUsedBytes": 64109848,
      "domNodes": -257,
      "jsHeapTotalBytes": 5369856,
      "scriptDurationMs": 441.48400000000004,
      "eventListeners": -69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.747087378640778,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 628.1870000000254,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.596,
      "layouts": 10,
      "layoutDurationMs": 3.0429999999999997,
      "taskDurationMs": 451.57699999999994,
      "heapDeltaBytes": 1238144,
      "heapUsedBytes": 62965148,
      "domNodes": 0,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 146.664,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 640.5799999999999,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.183000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.662,
      "taskDurationMs": 448.888,
      "heapDeltaBytes": -376600,
      "heapUsedBytes": 62458420,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 149.087,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2229999999968,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.6719999999999997,
      "layouts": 10,
      "layoutDurationMs": 2.5599999999999996,
      "taskDurationMs": 514.605,
      "heapDeltaBytes": 3576140,
      "heapUsedBytes": 65277120,
      "domNodes": 0,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 8.186,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2034.2010000000528,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.5850000000000004,
      "layouts": 9,
      "layoutDurationMs": 2.6100000000000003,
      "taskDurationMs": 560.161,
      "heapDeltaBytes": 4975800,
      "heapUsedBytes": 66078012,
      "domNodes": -183,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 8.943999999999999,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.6609999999732,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 13.118,
      "layouts": 10,
      "layoutDurationMs": 2.7119999999999997,
      "taskDurationMs": 827.176,
      "heapDeltaBytes": -5520416,
      "heapUsedBytes": 66392540,
      "domNodes": 0,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 109.95100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.0730000000049,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 14.200999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.684,
      "taskDurationMs": 885.4580000000001,
      "heapDeltaBytes": -12155828,
      "heapUsedBytes": 58486980,
      "domNodes": -183,
      "jsHeapTotalBytes": 9437184,
      "scriptDurationMs": 111.17000000000002,
      "eventListeners": -116,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1502.36799999999,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 24.36,
      "layouts": 5,
      "layoutDurationMs": 16.061999999999998,
      "taskDurationMs": 1210.7250000000001,
      "heapDeltaBytes": 11451816,
      "heapUsedBytes": 113534500,
      "domNodes": 16030,
      "jsHeapTotalBytes": 15863808,
      "scriptDurationMs": 35.746,
      "eventListeners": 3246,
      "totalBlockingTimeMs": 168,
      "frameDurationMs": 19.998666666666676,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9303.134,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 27.619,
      "layouts": 8,
      "layoutDurationMs": 1.9900000000000004,
      "taskDurationMs": 5986.765,
      "heapDeltaBytes": -3055644,
      "heapUsedBytes": 71527228,
      "domNodes": -257,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 2751.967,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66594982078853,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9973.598999999922,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 28.192,
      "layouts": 5,
      "layoutDurationMs": 4.218,
      "taskDurationMs": 6105.302,
      "heapDeltaBytes": 13379784,
      "heapUsedBytes": 73466324,
      "domNodes": -257,
      "jsHeapTotalBytes": 192512,
      "scriptDurationMs": 2776.59,
      "eventListeners": -67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666220735785952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23250.872000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22747.951,
      "heapDeltaBytes": -29675060,
      "heapUsedBytes": 262236272,
      "domNodes": -3343,
      "jsHeapTotalBytes": 10473472,
      "scriptDurationMs": 329.69399999999996,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.293067590987874,
      "p95FrameDurationMs": 83.39999999999782
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23557.980000000043,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23051.357000000004,
      "heapDeltaBytes": -26971852,
      "heapUsedBytes": 255775404,
      "domNodes": -3343,
      "jsHeapTotalBytes": 3137536,
      "scriptDurationMs": 326.09,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.601724137931036,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28040.352000000043,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.61400000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27672.027000000002,
      "heapDeltaBytes": -10115976,
      "heapUsedBytes": 286502764,
      "domNodes": -3343,
      "jsHeapTotalBytes": 13287424,
      "scriptDurationMs": 883.728,
      "eventListeners": -651,
      "totalBlockingTimeMs": 136,
      "frameDurationMs": 51.5297794117647,
      "p95FrameDurationMs": 100.10000000000036
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28639.28999999996,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 20.105999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 28296.357,
      "heapDeltaBytes": -32269440,
      "heapUsedBytes": 270247876,
      "domNodes": -3343,
      "jsHeapTotalBytes": 14934016,
      "scriptDurationMs": 920.599,
      "eventListeners": -651,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 53.21970260223049,
      "p95FrameDurationMs": 116.60000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8486.426999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 84.038,
      "layouts": 20,
      "layoutDurationMs": 23.746000000000002,
      "taskDurationMs": 8382.331,
      "heapDeltaBytes": -23106176,
      "heapUsedBytes": 249832632,
      "domNodes": -3343,
      "jsHeapTotalBytes": 14409728,
      "scriptDurationMs": 123.09700000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 49.31976744186046,
      "p95FrameDurationMs": 100.10000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8491.903999999977,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.761,
      "layouts": 20,
      "layoutDurationMs": 28.878000000000014,
      "taskDurationMs": 8364.518,
      "heapDeltaBytes": -27473272,
      "heapUsedBytes": 264551688,
      "domNodes": -3343,
      "jsHeapTotalBytes": 13881344,
      "scriptDurationMs": 130.87300000000002,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 47.39106145251397,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11700.604999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11435.466000000002,
      "heapDeltaBytes": 4546396,
      "heapUsedBytes": 279088532,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 161.64600000000007,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.204810996563566,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11775.854999999978,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11544.633000000002,
      "heapDeltaBytes": 20403500,
      "heapUsedBytes": 282373624,
      "domNodes": 0,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 161.50200000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.573103448275866,
      "p95FrameDurationMs": 83.39999999999782
    },
    {
      "name": "workflow-execution",
      "durationMs": 498.6940000000004,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 12.308000000000002,
      "layouts": 11,
      "layoutDurationMs": 6.183000000000001,
      "taskDurationMs": 159.37,
      "heapDeltaBytes": -10297864,
      "heapUsedBytes": 66544972,
      "domNodes": 138,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 14.175,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 131.3949999999977,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.835,
      "layouts": 9,
      "layoutDurationMs": 3.429,
      "taskDurationMs": 81.081,
      "heapDeltaBytes": 4635396,
      "heapUsedBytes": 66069012,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.378000000000001,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428546,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 468.6020000000326,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.642,
      "layouts": 76,
      "layoutDurationMs": 14.934,
      "taskDurationMs": 422.931,
      "heapDeltaBytes": -4621952,
      "heapUsedBytes": 38704216,
      "domNodes": 4,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 198.856,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428573,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 462.54799999996976,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.646,
      "layouts": 76,
      "layoutDurationMs": 14.461,
      "taskDurationMs": 415.003,
      "heapDeltaBytes": -4534712,
      "heapUsedBytes": 40790112,
      "domNodes": 4,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 195.983,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664285714285693,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 594.504000000029,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.032,
      "layouts": 76,
      "layoutDurationMs": 15.415999999999999,
      "taskDurationMs": 550.622,
      "heapDeltaBytes": 1183032,
      "heapUsedBytes": 104056084,
      "domNodes": 4,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 226.358,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.142857142857142,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 583.5039999999481,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.606,
      "layouts": 76,
      "layoutDurationMs": 14.996,
      "taskDurationMs": 549.2579999999999,
      "heapDeltaBytes": 1519744,
      "heapUsedBytes": 91814092,
      "domNodes": 4,
      "jsHeapTotalBytes": 790528,
      "scriptDurationMs": 228.494,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage: 🟡 59.8% of lines

Coverage totals
Metric Covered Total Pct
Lines 60759 101537 59.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1179
src/workbench/extensions/agent/composables/agent/useAgentSession.ts 13.9% 714
src/workbench/extensions/agent/crdt/liveGraphApplier.ts 2.1% 657
src/workbench/extensions/agent/AgentPanelRoot.vue 27.6% 566
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts 13.5% 557
src/workbench/extensions/agent/crdt/docOpMinter.ts 4.3% 425
src/LGraphNode.ts 71.3% 379
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts 26.1% 379
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332
src/platform/billing/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 321

🎭 Playwright: ✅ 3130 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2323 / ❌ 0 / ⚠️ 3 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 776 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 11/02/2026, 11:57:12 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 432df64ceca6253406c1cd7bcbe13db983e9ec7b

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (275)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/syncPromotedComboHostOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 225 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@datadog-official

datadog-official Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ef3d547 | Docs | Give us feedback!

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 31, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport approval: LGTM.

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.21912% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...form/workspace/components/SwitchDeploymentCard.vue 94.73% 3 Missing and 1 partial ⚠️
...c/platform/workspace/openCustomDeploymentDialog.ts 75.00% 3 Missing ⚠️
src/platform/workspace/workflowDeploymentOffer.ts 93.54% 2 Missing ⚠️
...form/workspace/components/CustomDeploymentCard.vue 96.66% 1 Missing ⚠️
...orkspace/composables/useCustomDeploymentOffered.ts 87.50% 1 Missing ⚠️
src/platform/workspace/openWorkflowForCheck.ts 90.90% 1 Missing ⚠️
@@                               Coverage Diff                               @@
##           bl/cloud-1.59-missing-node-deployment-offer   #22539      +/-   ##
===============================================================================
+ Coverage                                        86.65%   87.28%   +0.62%     
===============================================================================
  Files                                             2689     3062     +373     
  Lines                                           139492   160424   +20932     
  Branches                                         42798    40345    -2453     
===============================================================================
+ Hits                                            120879   140026   +19147     
- Misses                                           17793    19718    +1925     
+ Partials                                           820      680     -140     
Flag Coverage Δ
e2e 59.79% <10.52%> (?)
unit 86.66% <96.74%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/ui/select/SelectItem.vue 100.00% <100.00%> (ø)
...platform/workflow/core/services/workflowService.ts 95.80% <100.00%> (+5.74%) ⬆️
...rkflowErrors/nodeReplacement/missingNodesNotice.ts 100.00% <100.00%> (ø)
...orm/workspace/components/DeploymentDialogFrame.vue 100.00% <100.00%> (ø)
...atform/workspace/components/DeploymentDocsLink.vue 100.00% <100.00%> (ø)
...pace/components/ErrorOverlayDeploymentOfferRow.vue 96.00% <100.00%> (-4.00%) ⬇️
...latform/workspace/components/MissingItemsTable.vue 100.00% <100.00%> (ø)
...rkspace/components/WorkflowNeedsDeploymentCard.vue 100.00% <100.00%> (ø)
src/platform/workspace/customDeploymentPitch.ts 100.00% <100.00%> (ø)
src/platform/workspace/deploymentBuildBrief.ts 93.02% <100.00%> (-6.98%) ⬇️
... and 9 more

... and 1808 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving backport.

christian-byrne added a commit to hphproton/ComfyUI_frontend that referenced this pull request Nov 1, 2026
…sh entry (Comfy-Org#22576)

## Summary

Locale collection rewrites `src/locales/en/commands.json` from the
commands the running app has
registered, so a command whose extension had not loaded is pruned.
Nothing fails at that moment,
because ESLint caches on file content and config rather than on catalog
content — so the prune
reaches a release branch and only surfaces later as an
`@intlify/vue-i18n/no-missing-keys` error in
an unrelated pull request.

`Comfy.3DViewer.Open3DViewer` has been through that cycle three times:
pruned by the 1.59.2 bump,
restored by Comfy-Org#22130, pruned again by the 1.59.3 bump (`342a87f0d9`), and
fixed at the source for the
lazy 3D extension by Comfy-Org#22168. **The third prune is still live on
`cloud/1.59` and is currently
failing `lint-pr / lint` on six open carriers (Comfy-Org#22534–Comfy-Org#22539)** — which
is how it was found. Comfy-Org#22168
fixed collection for that one extension; nothing fails when it happens
to the next one.

This adds the missing mechanical check.
`scripts/check-command-locales.ts` reads command ids out of
the source tree with the TypeScript AST — `commands: [...]` on a
`ComfyExtension` and
`const commands = [...]` as `useCoreCommands` declares them — and
requires each one to keep a
`commands.<normalized id>.label` string. It needs neither a browser nor
a regeneration run, so it
works on any branch.

Two wiring points, for two different failure moments:

- **`i18n-update-core.yaml`, right after `pnpm collect-i18n`** — fails
the regeneration before the
pruned catalog is translated and committed. This is the step that
prunes, so failing here also
avoids spending OpenAI tokens on a catalog that is about to be rejected.
- **`repo-checks`** — catches an already-pruned branch on any pull
request. `locale:check` compares
the non-English catalogs against the English ones, so it cannot see a
key missing from the English
  catalog itself.

Non-obvious decisions:

- A computed id (`id: \`Comfy.${suffix}\``) cannot be resolved
statically. Those are counted and
  reported in the pass line rather than ignored silently or failed on.
- The reverse direction is deliberately not checked. The catalog carries
122 entries against 113
statically declared ids, because some commands are registered only at
runtime, so flagging
  catalog entries with no declaration would be false-positive-prone.
- Comfy-Org#22168's one-key output assertion in `collect-i18n-general.ts` is left
in place. This guard
subsumes it, but removing it is a separate call for that file's author.

## Verification

Red on the real broken states, green on the real repaired ones — not
only on fixtures.

| state | result |
| --- | --- |
| `main` at `ac70ad8a8c` | **pass** — 113 declared commands across 1661
files |
| `origin/cloud/1.59` at `122b615f36` (live) | **fail**, exit 1 —
`src/extensions/core/load3d/load3d.ts:60 command
'Comfy.3DViewer.Open3DViewer' has no
commands.Comfy_3DViewer_Open3DViewer entry` |
| same tree, with the 3-line entry restored | **pass** — 113 declared
commands |
| `342a87f0d9` (the 1.59.3 bump that pruned it) | **fail**, exit 1, same
single finding |
| `e05ecb7577` (Comfy-Org#22130's restore) | **pass** |

So the guard would have failed the version-bump PR that reintroduced the
defect, and fails the
release branch that still carries it, naming the declaration site rather
than a downstream call
site.

- Tests: `scripts/check-command-locales.test.ts`, 13 cases, hermetic
(temp-directory trees, no
network, no browser). Covers the AST cases — extension array, `const
commands`, `as const` /
`satisfies` unwrapping, a `menuCommands` reference array that must *not*
count as a declaration,
a computed id — and the catalog cases: missing entry, restored entry,
absent/blank/`tooltip`-only
label, duplicate declaration reported once, and test/`__tests__` files
skipped so a fixture
command needs no locale entry. `vitest run
scripts/check-command-locales.test.ts` → 13 passed.
- `pnpm typecheck:scripts` → exit 0. `pnpm knip` → exit 0. `pnpm
format:check` → all 6469 files
correct. `pnpm deps:audit`, `pnpm knip` and `pnpm fallow:audit` all pass
via the `pre-push` hook,
not bypassed. Both edited YAML files re-parsed and their step order
asserted.
- No manual repair is pushed to `cloud/1.59` or to Comfy-Org#22534–Comfy-Org#22539 here;
that is the release owner's
  call and is tracked separately.

## Related

- Comfy-Org#22168 (FE-3637) fixed collection for the lazy 3D extension; this adds
the check that fails when
  the same thing happens to another extension.
- Comfy-Org#22130 restored the entry the second time. Comfy-Org#22160 is complementary and
independent: it makes the
ESLint cache honest on `cloud/1.59` so the prune is *visible* sooner,
while this makes the
  regeneration refuse to produce it.
…21587)

When an opened or dropped workflow needs nodes absent from Comfy Cloud,
the deployment dialog that opens over the issues card offers to switch
to a workspace deployment that can run it. It uses the compatibility
check already on main.

Stack: 4 of 4, after #21188. Board B of the DES-1254 drop-dialog canvas.

- Compatible, ready deployments appear first in Run on. Other
deployments remain visible and disabled, with missing-node or unchecked
status. Switch asks about unsaved workflows using the current shared
confirmation and leave-prompt guard, then selects the deployment; server
refusals appear as toasts.
- If every deployment was checked and lacks nodes, the dialog offers
creation and explains that none can run the workflow.
- The issues card shows at once, as in #21188. The dialog waits at most
5 s for the deployments listing, then at most 3 s for the compatibility
check. It opens by itself for an empty listing, for Switch, or once
every deployment lacks the nodes. With no answer in time, an unchecked
deployment, only a deployment that is not ready running it, the feature
flag off, or its code failing to load, it stays closed and the issues
card offers what the check finds: Switch, or Set up once Comfy Cloud and
every deployment are found lacking the nodes. As in #21188, it opens by
itself only the first time the page meets a set of missing node types,
and not once another workflow is active, the issues card is closed or
the editor is in App mode. It also stays closed once the open workflow
no longer needs a deployment, which the card's custom deployment row
reads too.
- The dialog's missing models and agent brief follow Comfy Cloud's model
check when it finishes after the dialog opens. The brief drops invisible
characters from names taken from the workflow.
- The dialog frame, missing-items table and docs link are shared between
creation and switching. Run on uses two new props on the design system's
`SelectItem` (`textClass`, `reserveIndicator`). The workflow warning
callback avoids an import cycle through the workflow service.

- The stack's changed suites and GraphView's pass (13 files, 113 tests),
including a listing that never answers while another workflow opens.
Each fix in cc9bd94 fails a test when reverted.
- Pre-commit format, lint, server-fact checks and typecheck, and
pre-push dependency audit, knip and Fallow pass. Fallow warns on 7
domain-boundary imports around the missing-nodes notice hook.
- Browser verification is still pending; there is no Playwright case
yet.

---------

Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
(cherry picked from commit 67016f4)
@benceruleanlu
benceruleanlu removed this pull request from stack #22540 November 2, 2026 23:54
@benceruleanlu
benceruleanlu force-pushed the bl/cloud-1.59-compatible-deployment-switch branch from a358582 to ef3d547 Compare November 2, 2026 23:55
@benceruleanlu
benceruleanlu merged commit e27374d into cloud/1.59 Nov 3, 2026
107 checks passed
@benceruleanlu
benceruleanlu deleted the bl/cloud-1.59-compatible-deployment-switch branch November 3, 2026 00:27
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Nov 3, 2026
… nodes (Comfy-Org#22772)

## Summary

When a workflow is missing nodes, the issues card and the Issues panel
offer the deployments that can run it. They also listed stopped, failed
and starting deployments, so **Switch** could reload the editor onto a
deployment where jobs won't run. The Run on menu already refuses this
(Comfy-Org#21858). They now list only ready deployments; when only a deployment
that isn't ready can run the workflow, the card stays as it was and the
menu's **Start** remains the way forward.

Reachable only with `deployment_compatibility_marks_enabled` on. Not
changed here: switching from an already-open dialog after its deployment
stops (known, listed on Comfy-Org#22539), and picking a deployment from a link
(`pickFromLink`).

## Verification

- The 5 new tests fail without the fix. With it,
`ErrorOverlayDeploymentOffer`, `MissingNodeDeploymentOffer` and
`MissingNodeCard` pass (55 tests).
- Cherry-picked locally onto `cloud/1.59` (`3e870e6f8`) and `cloud/1.60`
(`e87613972`): the two changed suites pass (34 tests), application
typecheck clean on both. Backports: Comfy-Org#22774 (`cloud/1.59`), Comfy-Org#22775
(`cloud/1.60`).
- Not run in a browser. The bug was found in QA on staging at
`3e870e6f8`, and confirmed by reading the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants