Repository navigation
fix: model dropdowns read the library again after the flag turns back on - #22487
Conversation
📦 Bundle: 12 MB gzip 🟢 -5 BDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.6 MB (baseline 2.6 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 2 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed / 17 unchanged Panels & Settings — 879 kB (baseline 879 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 3 added / 3 removed / 32 unchanged User & Accounts — 160 kB (baseline 160 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 18 unchanged Editors & Dialogs — 503 kB (baseline 503 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 10 unchanged UI Components — 368 kB (baseline 368 kB) • ⚪ 0 BReusable component library chunks
Status: 2 added / 2 removed / 32 unchanged Data & Services — 1.94 MB (baseline 1.94 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 3 added / 3 removed / 39 unchanged Utilities & Hooks — 2.46 MB (baseline 2.46 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 9 added / 9 removed / 74 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.9 MB (baseline 34.9 MB) • 🔴 +116 BBundles that do not match a named category
Status: 41 added / 41 removed / 713 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T12:07:16.195Z",
"gitSha": "18c5c11f09a0ed67f0f8dcc53d9c7be220be99e3",
"branch": "vinh/be-24489-library-flag-reread",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.5670000000046,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9519999999999997,
"layouts": 9,
"layoutDurationMs": 1.941,
"taskDurationMs": 475.474,
"heapDeltaBytes": 8024072,
"heapUsedBytes": 69097216,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 9.153000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.9689999999891,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.07,
"layouts": 11,
"layoutDurationMs": 2.2929999999999997,
"taskDurationMs": 477.26300000000003,
"heapDeltaBytes": -15997596,
"heapUsedBytes": 61124448,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.258000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.191999999979,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.897,
"layouts": 9,
"layoutDurationMs": 2.201,
"taskDurationMs": 819.1700000000001,
"heapDeltaBytes": -19899876,
"heapUsedBytes": 56275376,
"domNodes": -178,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 130.153,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.4260000000704,
"styleRecalcs": 74,
"styleRecalcDurationMs": 10.669999999999998,
"layouts": 10,
"layoutDurationMs": 2.232,
"taskDurationMs": 818.5910000000001,
"heapDeltaBytes": -24524812,
"heapUsedBytes": 53022256,
"domNodes": -163,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 128.272,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.9070000000065,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.249,
"layouts": 12,
"layoutDurationMs": 2.6109999999999998,
"taskDurationMs": 373.281,
"heapDeltaBytes": 1760304,
"heapUsedBytes": 78383756,
"domNodes": 57,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.207,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.6770000000188,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.023,
"layouts": 12,
"layoutDurationMs": 2.9830000000000005,
"taskDurationMs": 377.78000000000003,
"heapDeltaBytes": 8157008,
"heapUsedBytes": 83889812,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 11.100999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 597.8230000000622,
"styleRecalcs": 12,
"styleRecalcDurationMs": 1.9069999999999998,
"layouts": 8,
"layoutDurationMs": 1.6900000000000002,
"taskDurationMs": 435.4870000000001,
"heapDeltaBytes": 1291836,
"heapUsedBytes": 62130504,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 146.869,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 609.0069999999059,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.053,
"layouts": 9,
"layoutDurationMs": 1.9780000000000002,
"taskDurationMs": 433.355,
"heapDeltaBytes": 9379704,
"heapUsedBytes": 77793696,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 145.107,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1128.1420000000253,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.5830000000001,
"heapDeltaBytes": -10771424,
"heapUsedBytes": 77826496,
"domNodes": -208,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 51.39800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 452,
"frameDurationMs": 30.62972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1083.0740000000105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 748.1569999999999,
"heapDeltaBytes": 19205288,
"heapUsedBytes": 82678896,
"domNodes": 0,
"jsHeapTotalBytes": 17989632,
"scriptDurationMs": 48.54,
"eventListeners": 0,
"totalBlockingTimeMs": 464,
"frameDurationMs": 32.827272727272735,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.3390000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.36100000000005,
"heapDeltaBytes": -22782304,
"heapUsedBytes": 66641812,
"domNodes": -208,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 121.84400000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 147,
"frameDurationMs": 22.521621621621627,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 761.887999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.73099999999994,
"heapDeltaBytes": -2524752,
"heapUsedBytes": 73700996,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 111.59000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 139,
"frameDurationMs": 22.549999999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8483.499999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7499.739999999999,
"heapDeltaBytes": 4678128,
"heapUsedBytes": 66466028,
"domNodes": -274,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5720.937,
"eventListeners": -68,
"totalBlockingTimeMs": 117,
"frameDurationMs": 25.655757575757576,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8281.44199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7406.880999999999,
"heapDeltaBytes": 79052580,
"heapUsedBytes": 154172904,
"domNodes": -274,
"jsHeapTotalBytes": 70905856,
"scriptDurationMs": 5668.197,
"eventListeners": -68,
"totalBlockingTimeMs": 38,
"frameDurationMs": 24.652083333333334,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9260.605999999938,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.4689999999999998,
"layouts": 2,
"layoutDurationMs": 0.5059999999999999,
"taskDurationMs": 8366.060000000001,
"heapDeltaBytes": 65832192,
"heapUsedBytes": 144662696,
"domNodes": -274,
"jsHeapTotalBytes": 77197312,
"scriptDurationMs": 6525.204,
"eventListeners": -68,
"totalBlockingTimeMs": 180,
"frameDurationMs": 26.81072463768116,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8458.620999999994,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.029999999999999645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7638.630999999999,
"heapDeltaBytes": 70001476,
"heapUsedBytes": 145014740,
"domNodes": -274,
"jsHeapTotalBytes": 76935168,
"scriptDurationMs": 5905.715,
"eventListeners": -68,
"totalBlockingTimeMs": 69,
"frameDurationMs": 25.072997032640952,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 216.87599999995655,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.371,
"layouts": 11,
"layoutDurationMs": 2.916,
"taskDurationMs": 170.597,
"heapDeltaBytes": 14779684,
"heapUsedBytes": 90782124,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 8.249,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 232.84700000010616,
"styleRecalcs": 23,
"styleRecalcDurationMs": 11.501000000000001,
"layouts": 10,
"layoutDurationMs": 3.306,
"taskDurationMs": 186.114,
"heapDeltaBytes": -4999600,
"heapUsedBytes": 70592912,
"domNodes": -2325,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 8.858999999999998,
"eventListeners": -573,
"totalBlockingTimeMs": 1,
"frameDurationMs": 23.329999999999973,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2041.5949999999157,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6479999999999992,
"layouts": 8,
"layoutDurationMs": 1.8179999999999998,
"taskDurationMs": 586.762,
"heapDeltaBytes": -1252656,
"heapUsedBytes": 80956560,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 28.397,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.7260000000497,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.169,
"layouts": 10,
"layoutDurationMs": 2.338,
"taskDurationMs": 593.395,
"heapDeltaBytes": -19610124,
"heapUsedBytes": 62313144,
"domNodes": -274,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 30.686000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2256.779999999935,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.8450000000000015,
"layouts": 7,
"layoutDurationMs": 1.5089999999999997,
"taskDurationMs": 1553.119,
"heapDeltaBytes": 2065700,
"heapUsedBytes": 78630336,
"domNodes": -274,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 713.3670000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78962962962963,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.462000000086,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.5889999999999995,
"layouts": 8,
"layoutDurationMs": 1.483,
"taskDurationMs": 1446.2919999999997,
"heapDeltaBytes": -17304692,
"heapUsedBytes": 73842332,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 657.3710000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66564885496183,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3359.5790000000534,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.1,
"layouts": 64,
"layoutDurationMs": 10.193000000000001,
"taskDurationMs": 1611.144,
"heapDeltaBytes": -4672916,
"heapUsedBytes": 80736140,
"domNodes": -250,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 678.028,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3324.702000000002,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.289,
"layouts": 64,
"layoutDurationMs": 9.513,
"taskDurationMs": 1556.372,
"heapDeltaBytes": -6508772,
"heapUsedBytes": 74650544,
"domNodes": -250,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 632.0029999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665829145728644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2500.9769999999207,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.229,
"layouts": 5,
"layoutDurationMs": 1.1320000000000001,
"taskDurationMs": 1669.856,
"heapDeltaBytes": 21635240,
"heapUsedBytes": 100790780,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 787.7890000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779054054054054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2466.6330000000016,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.513999999999999,
"layouts": 7,
"layoutDurationMs": 1.48,
"taskDurationMs": 1657.222,
"heapDeltaBytes": 19187404,
"heapUsedBytes": 90921344,
"domNodes": 0,
"jsHeapTotalBytes": 3039232,
"scriptDurationMs": 772.4830000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780136986301372,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3038.5370000000194,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.575,
"layouts": 7,
"layoutDurationMs": 1.4390000000000003,
"taskDurationMs": 694.845,
"heapDeltaBytes": 4911212,
"heapUsedBytes": 87603708,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 325.20799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934067,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2992.480999999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5250000000000004,
"layouts": 7,
"layoutDurationMs": 1.5389999999999997,
"taskDurationMs": 632.477,
"heapDeltaBytes": -11150872,
"heapUsedBytes": 62253284,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 331.015,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2046.6299999999364,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.784,
"layouts": 8,
"layoutDurationMs": 1.8519999999999996,
"taskDurationMs": 611.822,
"heapDeltaBytes": 5267172,
"heapUsedBytes": 80441016,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 36.032,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2050.4770000000008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6119999999999997,
"layouts": 7,
"layoutDurationMs": 1.793,
"taskDurationMs": 595.963,
"heapDeltaBytes": 7122760,
"heapUsedBytes": 82220164,
"domNodes": -274,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.091,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2701.4480000000276,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.842000000000002,
"layouts": 6,
"layoutDurationMs": 1.1419999999999997,
"taskDurationMs": 562.859,
"heapDeltaBytes": -7483224,
"heapUsedBytes": 65700780,
"domNodes": -259,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 170.027,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665432098765432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2769.3429999999353,
"styleRecalcs": 26,
"styleRecalcDurationMs": 10.993,
"layouts": 7,
"layoutDurationMs": 1.4270000000000003,
"taskDurationMs": 539.573,
"heapDeltaBytes": -7225532,
"heapUsedBytes": 65338320,
"domNodes": -259,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 163.587,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666265060240967,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3270.860999999968,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6779999999999997,
"layouts": 8,
"layoutDurationMs": 1.743,
"taskDurationMs": 867.7170000000001,
"heapDeltaBytes": -24360212,
"heapUsedBytes": 63411888,
"domNodes": -274,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 339.36699999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3229.872999999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7219999999999995,
"layouts": 8,
"layoutDurationMs": 1.951,
"taskDurationMs": 902.3209999999999,
"heapDeltaBytes": -455728,
"heapUsedBytes": 86269752,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 333.791,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580310880829,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.6069999999381,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.680000000000001,
"layouts": 10,
"layoutDurationMs": 2.409,
"taskDurationMs": 396.168,
"heapDeltaBytes": -2251900,
"heapUsedBytes": 67305868,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 130.274,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.3120000000008,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.13,
"layouts": 10,
"layoutDurationMs": 2.1350000000000002,
"taskDurationMs": 395.501,
"heapDeltaBytes": 1016404,
"heapUsedBytes": 63043600,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 128.12199999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2025.3400000000283,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1510000000000002,
"layouts": 10,
"layoutDurationMs": 2.164,
"taskDurationMs": 526.751,
"heapDeltaBytes": 3773944,
"heapUsedBytes": 65889120,
"domNodes": -200,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7.981,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.2569999999341,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0619999999999994,
"layouts": 10,
"layoutDurationMs": 2.0460000000000003,
"taskDurationMs": 474.26499999999993,
"heapDeltaBytes": -15007552,
"heapUsedBytes": 63546184,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7.348000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5019999999531,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.982000000000001,
"layouts": 9,
"layoutDurationMs": 1.8830000000000002,
"taskDurationMs": 784.069,
"heapDeltaBytes": -3914120,
"heapUsedBytes": 60588072,
"domNodes": -200,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 86.843,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.1089999999986,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.008000000000001,
"layouts": 9,
"layoutDurationMs": 2.046,
"taskDurationMs": 775.046,
"heapDeltaBytes": -2865288,
"heapUsedBytes": 58335032,
"domNodes": -200,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 87.299,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.1820000000016,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.090000000000003,
"layouts": 5,
"layoutDurationMs": 12.008000000000001,
"taskDurationMs": 965.6579999999999,
"heapDeltaBytes": 11413904,
"heapUsedBytes": 87709288,
"domNodes": 15949,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 31.374,
"eventListeners": 3246,
"totalBlockingTimeMs": 155,
"frameDurationMs": 19.63424657534247,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8217.273999999976,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.599999999999998,
"layouts": 9,
"layoutDurationMs": 1.827,
"taskDurationMs": 5206.612,
"heapDeltaBytes": 1627364,
"heapUsedBytes": 82475728,
"domNodes": -274,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2281.781,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659229208925,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8303.838999999925,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.194,
"layouts": 9,
"layoutDurationMs": 1.749,
"taskDurationMs": 5300.414,
"heapDeltaBytes": -23814812,
"heapUsedBytes": 63458960,
"domNodes": -274,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 2330.865,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666064257028115,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18341.62300000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17435.176000000003,
"heapDeltaBytes": -17707728,
"heapUsedBytes": 266285032,
"domNodes": -3388,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 250.521,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.125127334465198,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18425.511000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17591.529,
"heapDeltaBytes": -26576768,
"heapUsedBytes": 258300980,
"domNodes": -3388,
"jsHeapTotalBytes": 11255808,
"scriptDurationMs": 265.259,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.69690189328744,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 23510.943999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.373,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23063.752999999997,
"heapDeltaBytes": -7837568,
"heapUsedBytes": 285853400,
"domNodes": -3388,
"jsHeapTotalBytes": 14340096,
"scriptDurationMs": 838.674,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 43.27642725598526,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23405.788999999913,
"styleRecalcs": 179,
"styleRecalcDurationMs": 21.461999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23050.574,
"heapDeltaBytes": -32162888,
"heapUsedBytes": 262635384,
"domNodes": -3388,
"jsHeapTotalBytes": 12566528,
"scriptDurationMs": 821.9609999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.983270676691724,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6678.804000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.849000000000004,
"layouts": 20,
"layoutDurationMs": 22.153000000000006,
"taskDurationMs": 6520.613,
"heapDeltaBytes": -37044372,
"heapUsedBytes": 267589920,
"domNodes": -3388,
"jsHeapTotalBytes": 15712256,
"scriptDurationMs": 100.72099999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.972159090909095,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6725.26199999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.408999999999985,
"layouts": 20,
"layoutDurationMs": 23.58700000000001,
"taskDurationMs": 6588.052000000001,
"heapDeltaBytes": -1473456,
"heapUsedBytes": 282526944,
"domNodes": -3388,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 126.34900000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.60057471264367,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9556.512999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9183.159000000001,
"heapDeltaBytes": -21382212,
"heapUsedBytes": 257327084,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 131.62700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.873539518900344,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9504.51299999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9062.647000000003,
"heapDeltaBytes": 27685716,
"heapUsedBytes": 277911156,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 136.84999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.6446735395189,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 118.67099999994934,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.179,
"layouts": 9,
"layoutDurationMs": 3.9309999999999996,
"taskDurationMs": 95.68799999999999,
"heapDeltaBytes": -13356428,
"heapUsedBytes": 61355712,
"domNodes": 128,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.334,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 124.35800000002928,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.791,
"layouts": 9,
"layoutDurationMs": 2.782,
"taskDurationMs": 82.18,
"heapDeltaBytes": 4916796,
"heapUsedBytes": 79242144,
"domNodes": 103,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.780000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 371.599999999944,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6849999999999999,
"layouts": 76,
"layoutDurationMs": 14.525,
"taskDurationMs": 318.96100000000007,
"heapDeltaBytes": -5143460,
"heapUsedBytes": 39285388,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 147.16700000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 381.8989999999758,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6880000000000001,
"layouts": 76,
"layoutDurationMs": 13.273,
"taskDurationMs": 329.124,
"heapDeltaBytes": -5061488,
"heapUsedBytes": 39282708,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 149.67600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 400.7489999999052,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.565,
"layouts": 76,
"layoutDurationMs": 13.332,
"taskDurationMs": 360.722,
"heapDeltaBytes": -246860,
"heapUsedBytes": 98614436,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 132.482,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999984,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 383.46599999999853,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.596,
"layouts": 76,
"layoutDurationMs": 13.421000000000001,
"taskDurationMs": 355.822,
"heapDeltaBytes": -367368,
"heapUsedBytes": 98511308,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 135.216,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999984,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 59.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3192 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since aa4e48c08d364dcd36071131455a7aec40b852ac
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (324)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Flag transitions and read validation src/platform/workspace/stores/deploymentLibraryModelsStore.ts, src/platform/workspace/stores/deploymentLibraryModelsStore.test.ts |
The watcher reloads watched folders when enabled. When disabled, it invalidates in-flight reads and clears cached state. Tests check that re-enabling refreshes library names and that a stale read does not replace a newer result. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#22157: Adds the store and flag watcher that this change updates.
Suggested reviewers: austinmroz
Merge Risk: 
Minimal · up to e0ac0
-
Re-enabling the flag reloads watched folders. No merge-blocking issue was identified.
Pre-merge checks: 
5 · 
1
-
Failed checks: 1 warning Passed checks: 5 passed-
Full details: Title check
-
Explanation
The title names the main change: model dropdowns re-read the library after the runtime-library-models flag turns back on. The raw summary shows the watcher now clears cached folders when the flag turns off and reloads watched folders when it turns on, and the objectives match. The title is specific and uses the fix: prefix, so it reads as a clear summary of the primary change.
Full details: Adr Compliance For Entity/Litegraph Changes
-
Explanation
The changed files are
src/platform/workspace/stores/deploymentLibraryModelsStore.tsand its test. None are undersrc/lib/litegraph/,src/ecs/, or graph-entity-related paths. The ADR compliance check is not applicable.
Full details: Description check
-
Explanation
The description includes the required Summary and Verification sections. It explains the problem, resulting behavior, design rationale, test coverage, validation commands, and the browser-testing gap. The linked issue reference is provided as BE-24489.
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes frontend behavior under
src/and fixes a user-visible case: while the editor remains open, turning the runtime-library-models flag off and on must refresh open model dropdowns and ignore stale reads. The PR adds unit tests but does not add or update a spec underbrowser_tests/.Resolution
This is a test suggestion, not a merge requirement. Extend an existing spec under
browser_tests/if one covers library model dropdowns: - Open the editor with a deployment and a LoRA loader. - Turn off the runtime-library-models flag. - Turn on the runtime-library-models flag. - Expect the open folder to be read again and the dropdown to show current model names. - Expect a read started before the flag was turned off not to replace the newer result.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22487 +/- ##
==========================================
- Coverage 87.53% 87.43% -0.10%
==========================================
Files 2983 2875 -108
Lines 162069 158701 -3368
Branches 43399 40201 -3198
==========================================
- Hits 141862 138764 -3098
+ Misses 19283 19177 -106
+ Partials 924 760 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 118 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed e0ac03e against main.
The bug is real on main. While the flag is off, loaded() hides the folders but the cached entries stay in folders. When the flag turns back on, loadWatchedFolders() skips every folder that folders.has(), so no folder is read again and the old names come back. Clearing on flag-off, as the workspace switch already does, fixes that. The generation bump makes isCurrent() drop a read that started before the flag went off.
Validation: deploymentLibraryModelsStore.test.ts PASS (2 tests). Mutation checks, each caught by the new tests:
- dropping
generation++: 1 test fails - dropping
folders.clear(): 2 tests fail
No added comments. Not run in a browser with the PostHog flag flipped.
One non-blocking nit inline.
| loadWatchedFolders() | ||
| return | ||
| } | ||
| generation++ |
There was a problem hiding this comment.
nit (non-blocking): these three lines now repeat the workspace watcher's reset. A small forgetLoadedFolders() used by both watchers would keep the two resets from drifting apart if the store gains more per-folder state.
There was a problem hiding this comment.
You're right that the two resets now repeat, and a shared helper would keep them from drifting. I'm leaving it as is in this PR: the store has nothing else to reset today, so the copies give the same result, and a push here would drop your approval for a refactor with no change in behaviour. Whoever adds more per-folder state is the natural point to pull them together.
On the browser check you noted: I haven't run the flag flip in a browser either; the PR body lists it under Not run.
… on (#22487) ## Summary You have the editor open with a deployment picked, and a LoRA loader's dropdown lists your library's models. The library-models flag turns off, then back on, while the page stays open. - **Before:** the dropdown comes back with the list it had before the flag went off, and no folder is read again. A model deleted in that window is still offered, and picking it fails the job. - **Now:** turning the flag off drops the cached lists, as switching workspace already does, and turning it back on reads every open folder again. A read that started before the flag went off is ignored when it answers late. The change is the suggestion from the review of #22157 (#22157 (comment)), as written. ## Why James Kwon asked for this in his review of #22157 (#22157 (comment)): turning the flag off left the cached lists in place, so turning it back on showed them again without reading any folder. #22157 merged without it, and frontend main still has the old watcher. ## Verification - Tests: new `deploymentLibraryModelsStore.test.ts`, two cases: - flag off then on: the folder is read a second time and the dropdown shows the second read's names; - a read that started before the flag went off and answers after it came back on is ignored; the newer read's names stay. - Both fail on main's watcher (one read only; the stale names win) and pass with the fix. With the fix minus the `generation++` bump, the second case fails. - `pnpm typecheck`, oxlint and oxfmt pass on both files. - Not run: the editor in a browser with the flag flipped in PostHog; the unit test mocks the flag and the library API. Ref BE-24489 (cherry picked from commit 62ef02a)
…nloading bar, Choose a file (#22159, #22157, #22210, #22208, #22487) (#22493) **Why** Staging and production serve the Cloud frontend from `cloud/1.59`, which was cut before these PRs merged. Staging already runs the backend half of this feature (an artist's own LoRA, uploaded into the workspace library, runs on their deployment), and these screens passed against staging from a local build of main on 2026-10-30. This puts the same screens on staging's own site without waiting for the next line cut from main. ## Summary Backport of #22159, #22157, #22210, #22208 and #22487 to `cloud/1.59`, cherry-picked in that order with `-x`. An artist picks their own deployment and adds a LoRA Loader. With `runtime_library_models_enabled` on: - [#22157](#22157): the loader's dropdown also lists the LoRAs in the workspace library, such as `my_style_v2.safetensors`. - [#22159](#22159): they press Run. While the deployment's worker downloads that file, the job's queue row says "Downloading my_style_v2.safetensors" with "50 MB of 145 MB" and a bar, instead of "Running" with no progress. - [#22210](#22210): the client and composable that upload one `.safetensors` file from the computer into the workspace library (no screen of its own). - [#22208](#22208): the Import dialog gets "Choose a file". The artist picks or drops the file, picks a model type, and it uploads. - [#22487](#22487): when the flag turns off and back on while the editor is open, the dropdowns read the library again instead of showing the list from before. The flag gates each screen as on main: the dropdowns read `runtime_library_models_enabled`; the server sends `model_upload_folders` (which shows "Choose a file") and the `model_download` events (which show the Downloading row) only while it is on. ## Conflicts Each one is an import whose module main moved after `cloud/1.59` was cut. Every import keeps this branch's path. - #22159, `src/stores/queueStore.ts`: main imports `tryNormalizeNodeExecutionId` from `@comfyorg/graph-model/nodeIdentification`. Kept `@/types/nodeIdentification` and added the `useJobModelDownloadStore` import. - #22159, `src/scripts/app.test.ts`: main imports `useExtensionStore` from `@/platform/extensions/stores/extensionStore`. Kept `@/stores/extensionStore` and added the `useJobModelDownloadStore` import. - #22157, `useComboWidget.ts` and `useComboWidget.deployment.test.ts`: main imports `IBaseWidget` and `IComboWidget` from `@comfyorg/graph-model/widgets`. Both come from `@/lib/litegraph/src/types/widgets` here. - #22210 and #22208 applied with no conflict. Their conflicts on `useFeatureFlags`, `serverFeatureFlag.ts`, `main.json`, `useUploadModelFile` and `assetDownloadStore` came from picking each one alone, without the PR before it. Imports that applied cleanly but name a package this branch does not have: - `@comfyorg/telemetry/reportError` is `@/platform/telemetry/reportError` here (main moved it into a package in #22135; same function and signature). Changed in `jobModelDownloadStore` and its test, `deploymentLibraryModelsStore`, `useComboWidget.deployment.test.ts`, and `useUploadModelFile` and its test. - `@comfyorg/design-system/button/Button` is `@/components/ui/button/Button.vue` here, as in the sibling `UploadModelFooter.vue`. Both read the same `button.variants`. Changed in `UploadModelFileUpload.vue`. - #22487 applied with no conflict. Its store test's deployment fixture set `can_start`, a field `WorkspaceDeployment` does not have on this branch; dropped from the fixture. Nothing else is brought from main. ## Verification - `pnpm typecheck`, `pnpm format:check`, stylelint, oxlint, `architecture:check`, `lint:packages` pass. ESLint passes on every file here; its one error, a missing `commands.Comfy_3DViewer_Open3DViewer` key in `Load3DViewerButton.vue`, is already on `cloud/1.59`. - Vitest, the 14 test files these PRs touch plus `queueStore.loadWorkflow.test.ts`: 715 passed. - Pre-push `deps:audit`, knip and fallow audit pass. Ref BE-17387 ## Screenshots Taken while testing the original PRs on main (dark, light and phone width); the screens here are the same code with only import paths changed. #22210 has no screen, and #22487 changes no screen's look. #22157, feat(models): offer the workspace library's models on a picked deployment: <img width="720" alt="after-dark-lora" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-after-dark-lora.png" /> <img width="720" alt="after-light-lora" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-after-light-lora.png" /> <img width="195" alt="after-phone-lora" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-after-phone-lora.png" /> #22159, feat(queue): show the model a Cloud job downloads before it runs: <img width="720" alt="after-dark-downloading" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-dark-downloading.png" /> <img width="720" alt="after-dark-downloading-60" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-dark-downloading-60.png" /> <img width="720" alt="after-dark-run-started" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-dark-run-started.png" /> <img width="720" alt="after-light-downloading" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-light-downloading.png" /> <img width="720" alt="after-light-downloading-60" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-light-downloading-60.png" /> <img width="720" alt="after-light-run-started" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-light-run-started.png" /> <img width="195" alt="after-phone-downloading" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-phone-downloading.png" /> <img width="195" alt="after-phone-downloading-60" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-phone-downloading-60.png" /> <img width="195" alt="after-phone-run-started" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-phone-run-started.png" /> #22208, feat(models): choose or drop a model file in the Import dialog: <img width="720" alt="after-dark-1-choose" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-1-choose.png" /> <img width="720" alt="after-dark-2-type" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-2-type.png" /> <img width="720" alt="after-dark-3-uploading" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-3-uploading.png" /> <img width="720" alt="after-dark-4-done" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-4-done.png" /> <img width="720" alt="after-dark-5-failed" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-5-failed.png" /> <img width="720" alt="after-dark-6-type-refused" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-6-type-refused.png" /> <img width="720" alt="after-light-1-choose" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-1-choose.png" /> <img width="720" alt="after-light-2-type" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-2-type.png" /> <img width="720" alt="after-light-3-uploading" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-3-uploading.png" /> <img width="720" alt="after-light-4-done" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-4-done.png" /> <img width="720" alt="after-light-5-failed" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-5-failed.png" /> <img width="720" alt="after-light-6-type-refused" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-6-type-refused.png" /> <img width="195" alt="after-phone-1-choose" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-1-choose.png" /> <img width="195" alt="after-phone-2-type" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-2-type.png" /> <img width="195" alt="after-phone-3-uploading" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-3-uploading.png" /> <img width="195" alt="after-phone-4-done" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-4-done.png" /> <img width="195" alt="after-phone-5-failed" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-5-failed.png" /> <img width="195" alt="after-phone-6-type-refused" src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-6-type-refused.png" /> Try it: once this merges and staging runs the new frontend tag, sign in to stagingcloud with `runtime_library_models_enabled` on for your account, pick a deployment, open the model library's Import dialog and press "Choose a file"; then add a LoRA Loader, pick the uploaded LoRA from its dropdown and press Run to see the Downloading row. Not run: the browser flow on staging's own site (it needs this merged and deployed first), and the full unit suite (only the touched files' tests ran).
Summary
You have the editor open with a deployment picked, and a LoRA loader's dropdown lists your library's models. The library-models flag turns off, then back on, while the page stays open.
The change is the suggestion from the review of #22157 (#22157 (comment)), as written.
Why
James Kwon asked for this in his review of #22157 (#22157 (comment)): turning the flag off left the cached lists in place, so turning it back on showed them again without reading any folder. #22157 merged without it, and frontend main still has the old watcher.
Verification
deploymentLibraryModelsStore.test.ts, two cases:generation++bump, the second case fails.pnpm typecheck, oxlint and oxfmt pass on both files.Ref BE-24489