Skip to content

[backport cloud/1.59] LoRA from the workspace library: dropdowns, Downloading bar, Choose a file (#22159, #22157, #22210, #22208, #22487) - #22493

Merged
comfy-pr-bot merged 6 commits into
cloud/1.59from
vinh/backport-be17387-cloud-1.59
Oct 31, 2026
Merged

comfy-pr-bot merged 6 commits into
cloud/1.59from
vinh/backport-be17387-cloud-1.59

Conversation

@vqt123

@vqt123 vqt123 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Why

Staging and production serve the Cloud frontend from cloud/1.59, which was cut before these PRs merged. Staging already runs the backend half of this feature (an artist's own LoRA, uploaded into the workspace library, runs on their deployment), and these screens passed against staging from a local build of main on 2026-10-30. This puts the same screens on staging's own site without waiting for the next line cut from main.

Summary

Backport of #22159, #22157, #22210, #22208 and #22487 to cloud/1.59, cherry-picked in that order with -x.

An artist picks their own deployment and adds a LoRA Loader. With runtime_library_models_enabled on:

  • #22157: the loader's dropdown also lists the LoRAs in the workspace library, such as my_style_v2.safetensors.
  • #22159: they press Run. While the deployment's worker downloads that file, the job's queue row says "Downloading my_style_v2.safetensors" with "50 MB of 145 MB" and a bar, instead of "Running" with no progress.
  • #22210: the client and composable that upload one .safetensors file from the computer into the workspace library (no screen of its own).
  • #22208: the Import dialog gets "Choose a file". The artist picks or drops the file, picks a model type, and it uploads.
  • #22487: when the flag turns off and back on while the editor is open, the dropdowns read the library again instead of showing the list from before.

The flag gates each screen as on main: the dropdowns read runtime_library_models_enabled; the server sends model_upload_folders (which shows "Choose a file") and the model_download events (which show the Downloading row) only while it is on.

Conflicts

Each one is an import whose module main moved after cloud/1.59 was cut. Every import keeps this branch's path.

Imports that applied cleanly but name a package this branch does not have:

  • @comfyorg/telemetry/reportError is @/platform/telemetry/reportError here (main moved it into a package in refactor: extract telemetry into a package #22135; same function and signature). Changed in jobModelDownloadStore and its test, deploymentLibraryModelsStore, useComboWidget.deployment.test.ts, and useUploadModelFile and its test.

  • @comfyorg/design-system/button/Button is @/components/ui/button/Button.vue here, as in the sibling UploadModelFooter.vue. Both read the same button.variants. Changed in UploadModelFileUpload.vue.

  • fix: model dropdowns read the library again after the flag turns back on #22487 applied with no conflict. Its store test's deployment fixture set can_start, a field WorkspaceDeployment does not have on this branch; dropped from the fixture.

Nothing else is brought from main.

Verification

  • pnpm typecheck, pnpm format:check, stylelint, oxlint, architecture:check, lint:packages pass. ESLint passes on every file here; its one error, a missing commands.Comfy_3DViewer_Open3DViewer key in Load3DViewerButton.vue, is already on cloud/1.59.
  • Vitest, the 14 test files these PRs touch plus queueStore.loadWorkflow.test.ts: 715 passed.
  • Pre-push deps:audit, knip and fallow audit pass.

Ref BE-17387

Screenshots

Taken while testing the original PRs on main (dark, light and phone width); the screens here are the same code with only import paths changed. #22210 has no screen, and #22487 changes no screen's look.

#22157, feat(models): offer the workspace library's models on a picked deployment:

after-dark-lora

after-light-lora

after-phone-lora

#22159, feat(queue): show the model a Cloud job downloads before it runs:

after-dark-downloading

after-dark-downloading-60

after-dark-run-started

after-light-downloading

after-light-downloading-60

after-light-run-started

after-phone-downloading

after-phone-downloading-60

after-phone-run-started

#22208, feat(models): choose or drop a model file in the Import dialog:

after-dark-1-choose

after-dark-2-type

after-dark-3-uploading

after-dark-4-done

after-dark-5-failed

after-dark-6-type-refused

after-light-1-choose

after-light-2-type

after-light-3-uploading

after-light-4-done

after-light-5-failed

after-light-6-type-refused

after-phone-1-choose

after-phone-2-type

after-phone-3-uploading

after-phone-4-done

after-phone-5-failed

after-phone-6-type-refused

Try it: once this merges and staging runs the new frontend tag, sign in to stagingcloud with runtime_library_models_enabled on for your account, pick a deployment, open the model library's Import dialog and press "Choose a file"; then add a LoRA Loader, pick the uploaded LoRA from its dropdown and press Run to see the Downloading row.

Not run: the browser flow on staging's own site (it needs this merged and deployed first), and the full unit suite (only the touched files' tests ran).

)

An artist on their own deployment presses Run on a workflow that uses
`my_style_v2.safetensors`, a LoRA from their workspace library. Before
ComfyUI starts, the GPU worker downloads that file. Before this change,
the job's row in the queue said "Running" with no progress while that
happened. After it, the row says "Downloading my_style_v2.safetensors",
shows the size so far of the whole ("50 MB of 145 MB") and fills a bar.
When the run starts, the row goes back to the normal step progress.

- The worker reports each file as a `model_download` websocket event
with the Cloud job id (`prompt_id`), the file name, its place among the
job's files, bytes so far, total bytes and progress.
- A new store (`src/stores/jobModelDownloadStore.ts`) keeps the latest
download per job id. The app creates it just before the socket opens, so
a download event that arrives before the queue first loads is kept.
- The frame is declared in the Cloud ingest spec (`ModelDownloadFrame`,
`ModelDownloadData`), and `@comfyorg/ingest-types` carries the generated
types. The store checks each event with `zModelDownloadData`, picking
only the fields it reads. The contract makes `status` an open string, so
any value other than `downloading` ends that file's download. A
malformed event is ignored and the first is reported
(`error_parsing_model_download_message`, warning).
- A job's entry ends on `execution_start`, `progress`, `progress_state`,
`execution_success`, `execution_error` or `execution_interrupted` for
that job (so a reconnect that missed `execution_start` still ends it
once execution progress arrives), when the file's status is anything but
`downloading` (`done`, `cached`, `failed`, or a value added later), and
when the queue snapshot no longer lists the job (the same reconcile the
"Initializing" state uses).
- The job row (floating queue panel and docked job history) shows the
download only while the job is pending or running. With several files it
says "Downloading <file> (2 of 3)". With no total size it shows the
bytes so far and no bar.
- The download bar is the light fill the row already uses for the
running node's progress, not the solid one, so the file name and size
stay readable over it at every fill level in dark and light.
- A `failed` download always ends the job right after: the worker tries
no other source and the job is not retried, so Cloud sends
`execution_error` for it (or `execution_interrupted` when a cancel was
in flight) and the row turns Failed.
- A job with no download events looks exactly as before.
- No feature flag here: the row only changes when a `model_download`
event arrives, and the worker sends none while
`runtime_library_models_enabled` is off.

On a deployment, a job that names a library LoRA now waits while the
worker downloads it (cloud BE-20050, BE-24278). Without this, the job
looks stuck.

- `jobModelDownloadStore.test.ts`: the event reader (latest state per
job, `done`/`cached`/`failed` end it, each execution event ends only its
own job, `progress` and `progress_state` end a download whose
`execution_start` was missed, reconcile, malformed events, a computed
reader created before the events sees each update, a status it does not
know ends the download without a report, a frame without `dir` and
`workflow_id` or with a new field still shows). The last two fail on
907c404, where the schema was hand-written.
- `queueDisplay.test.ts`: the row text with a total, with several files
and with an unknown total.
- `app.test.ts`: a download event sent as the socket starts is kept.
- `useJobList.test.ts`, through the real row builder: a pending,
initializing or running job's row reads "Downloading
my_style_v2.safetensors" and "50 MB of 145 MB" with its light bar; the
active job shows the download fill, not node progress; a finished job
never does.
- `queueStore.test.ts`: a queue refresh drops the download of a job it
no longer lists.
- `packages/ingest-types`: the `ModelDownloadFrame` and
`ModelDownloadData` blocks are the package's openapi-ts output for the
Cloud ingest spec with the frame added (`openapi-project -fe`, `pnpm
generate`, `oxfmt`), additions only.
- Each production change was reverted one at a time and at least one
test failed each time (16 mutations, including putting the download back
on the solid bar, a plain container in place of the reactive map, and
limiting downloads to running jobs). 881 tests across the queue
composables, queue components, queue and execution stores, the workspace
stores and `queueDisplay` pass.
- Typecheck, type-aware oxlint, eslint, oxfmt, knip, locale check and
the Fallow push audit pass. At this head: the five touched test files
(269 tests) pass, `pnpm architecture:check` passes and `fallow audit`
reports 0 introduced findings.
- Playwright, local Cloud dev server with the deployment listing, the
jobs list and the websocket mocked: the job row before and after at
about a third and at 60%, then after `execution_start`, dark, light and
390 px wide.

Not run: a real GPU job downloading a real LoRA; `pnpm build:cloud`.

Try it: on a deployment, run a workflow whose LoRA loader names a file
from your workspace library that the deployment does not have yet, then
open the queue ("1 active"). The job shows "Downloading <file>" with a
bar until the run starts.

Ref BE-24279

Local Cloud dev server with the jobs list and websocket mocked; one
running job receives `model_download` events at 0%, 34% and 60%, then
`execution_start`. At 390 px the floating queue panel is wider than the
screen, as it is on main.

<details>
<summary>Dark</summary>

Before (the row says Running, no progress):

<img width="1440" height="1000" alt="before-dark-downloading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-before-dark-downloading.png"
/>

After, while the LoRA downloads (about a third):

<img width="1440" height="1000" alt="after-dark-downloading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-dark-downloading.png"
/>

After, at 60%:

<img width="1440" height="1000" alt="after-dark-downloading-60"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-dark-downloading-60.png"
/>

After, once the run starts:

<img width="1440" height="1000" alt="after-dark-run-started"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-dark-run-started.png"
/>

</details>
<details>
<summary>Light</summary>

Before (the row says Running, no progress):

<img width="1440" height="1000" alt="before-light-downloading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-before-light-downloading.png"
/>

After, while the LoRA downloads (about a third):

<img width="1440" height="1000" alt="after-light-downloading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-light-downloading.png"
/>

After, at 60%:

<img width="1440" height="1000" alt="after-light-downloading-60"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-light-downloading-60.png"
/>

After, once the run starts:

<img width="1440" height="1000" alt="after-light-run-started"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-light-run-started.png"
/>

</details>
<details>
<summary>Phone (390 px)</summary>

Before (the row says Running, no progress):

<img width="390" height="844" alt="before-phone-downloading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-before-phone-downloading.png"
/>

After, while the LoRA downloads (about a third):

<img width="390" height="844" alt="after-phone-downloading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-phone-downloading.png"
/>

After, at 60%:

<img width="390" height="844" alt="after-phone-downloading-60"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-phone-downloading-60.png"
/>

After, once the run starts:

<img width="390" height="844" alt="after-phone-run-started"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24279-after-phone-run-started.png"
/>

</details>

(cherry picked from commit b6bc2f2)
…ment (#22157)

An artist picks their own deployment in the Cloud editor and uploads
`my_style_v2.safetensors` to their workspace's model library. Before
this change, the LoRA loader dropdown lists only the Release's LoRAs, so
the uploaded file cannot be picked. After it, with the
`runtime_library_models_enabled` flag on for their workspace, the
dropdown lists the Release's LoRAs first, then every LoRA in the
workspace's library, including ones a teammate uploaded, each name once.

- The feature sits behind one PostHog flag,
`runtime_library_models_enabled`, read from the server's `/api/features`
response through `useFeatureFlags` like the other remote flags
(`flags.runtimeLibraryModelsEnabled`, default off). With the flag off
the dropdown is exactly today's: the Release's models only, and no
`/api/assets` library read is made.
- If the flag flips while the page is open, the dropdown follows it: on,
the folders of the loaders on the page are read and joined in; off, the
dropdown goes back to the Release list.
- On a page booted on a deployment with the flag on, every model loader
input (the inputs Cloud's asset picker covers) joins two lists: the
Release's options from `object_info`, then the private models of that
folder in the workspace's library, whichever member added them. The
library is read per folder from
`/api/assets?include_tags=models,<folder>&include_public=false&workspace_library=true`,
which lists every member's private models in the workspace and is not
narrowed to the Release's names; public Cloud models and other
workspaces' models are not offered.
- A name in both lists shows once, in the Release's position.
- A browser on Comfy Cloud (no deployment) is unchanged: it keeps the
asset picker and never reads this list.
- Only the 25 model folders a deployment's worker places models in get
library models (`WorkerDirs` in Comfy-Org/cloud: `checkpoints`, `loras`,
`vae`, ...). A custom-node folder such as `ipadapter` or `sam2` keeps
the Release list only, since the job would be refused.

- New `assetService.getWorkspaceLibraryModels(folder)` walks that
listing page by page (the keyset walk `getAllAssetsByTag` uses, now
shared) and returns each safe loader name once, even when two members
added a model under the same name.
- `workspace_library` is declared in the vendored
`@comfyorg/ingest-types` (`ListAssetsData['query']` and
`zListAssetsQuery`), copied from the ingest spec in
Comfy-Org/cloud#16886 as openapi-ts generates it. The request names the
param through a constant typed against `ListAssetsData['query']`, so a
rename fails typecheck.
- Which library models the picked deployment can download is decided in
one place until ingest answers it (BE-24448):
`pendingServerFact('BE-24448', ...)` in the store. It holds three
client-side copies: the page booted on a deployment, the loader's folder
is one of the worker's 25, and the name is a bare `.safetensors` file
name (no subfolder, no `..`, no leading dot). Anything else, such as a
`.ckpt` from a link import, is not offered.
- New `deploymentLibraryModelsStore`, beside `deploymentPickStore`. It
keeps the library names per folder for the current workspace, and reads
nothing while the flag is off.
- A loader watches its folder from when its widget is set up until its
widget is removed or its node is deleted; a node added back to a graph
(undo, or moved into a subgraph) watches again. Each node keeps one set
of its loaders' watches, with one `node.onAdded` and one
`node.onRemoved` handler installed the first time, so dynamic LoRA rows
that come and go add no handlers; `widget.onRemove` drops only that
widget's watch. The store counts the loaders watching each folder.
Reading the dropdown's options or the missing-model status only reads
what is cached; the network read starts when a loader begins watching,
and again on the triggers below.
- It drops everything when the workspace id changes, including signing
out or into another account without a reload, then reads again only the
folders a loader still watches. It ignores any answer that started under
the previous workspace or was overtaken by a newer read.
- It reads a folder again when the Release options are refreshed
(Refresh Node Definitions, `R`), when a model upload into that folder
completes (`lastCompletedDownload`, the same signal the Model Library
sidebar uses), and through `assetService.onAssetsChanged` after any
asset is deleted or an import finishes at once (HTTP 200 because the
file is already in storage, or a 202 whose task is already complete;
neither goes through `lastCompletedDownload`).
- The combo registers a widget inventory, as remote combos do, so the
missing-model check waits for the library before judging a workflow's
saved LoRA. A wait follows the folder, not the request it started with:
it settles once the folder is no longer loading, whether a newer read
answered, the workspace changed, the member signed out or the flag
turned off. With the flag off the inventory is ready at once.
- A failed read keeps the Release list, reports
`error_loading_library_models` (warning) through `reportError`, and
leaves that loader's missing-model check undecided, as a failed remote
list does. It is not retried until the next refresh or upload.
- A loader promoted out of a subgraph shows its source's list: the
editor's host-options sync (moved from `app.ts` to
`syncPromotedComboHostOptions`) runs when node definitions refresh, as
before, and whenever a library loader's names change (an answer, a
workspace change, the flag). One change runs it once per graph, however
many loaders read the folder. The listener stops when the loader's
widget is removed or its node is deleted (and starts again if the node
is added back), or at the next change once the node is in no graph (a
temporary clone).

The worker on a deployment can now download a job's library models
(cloud BE-20050, BE-20052). Without this, the editor never offers those
files, so an artist cannot pick their own LoRA there.

- `assetService.test.ts`: 5 new cases against the real list response
shape (a name two members added listed once, the exact query with
`workspace_library=true`, rows from two members across two pages, an
unsafe name left out, a row named by its `loader_path`, a failed
listing).
- `useComboWidget.deployment.test.ts`: 18 new cases (flag off: no
library read and the Release list unchanged; the flag flipping on and
off while the page is open; join order and de-duplication; no library
without a deployment; missing-model wait; workspace change with a late
answer from the old workspace; sign-out; refresh on `R`; refresh after
an upload; a newer read winning over an older one that answers last; a
deleted model dropped; a wait whose first read never answers, settled by
a workspace change, sign-out, the flag turning off and a newer read; a
promoted loader following the library and the flag; three promoted
loaders updated by one pass over the graph; failed read).
- `useComboWidget.deployment.test.ts`, this round: 7 more cases, each
failing on the previous head a2d83a3: an `ipadapter` loader gets no
library models; `.ckpt`, `.pt`, a subfolder, `..` and a dot file left
out of the dropdown; reading names or status starts no network read;
deleting a loader's node, or removing its widget, stops its folder being
read on a workspace change while another loader of the same folder keeps
it; an import answered with 200, or with a 202 already complete, puts
the model in the dropdown.
- `useComboWidget.deployment.test.ts`, latest round: 3 more cases, each
failing on the previous head 176f96d: a loader deleted and added back
still copies a library change to its promoted dropdowns after an upload,
and after a workspace change; three LoRA rows added and removed on one
node leave its `onRemoved` handler as it was.
- `useFeatureFlags.test.ts`: the flag is read from `/api/features`,
falls back to the server feature, and defaults to off.
- Each production change was reverted one at a time and at least one
test failed each time (26 mutations, including removing the flag gate,
the `workspace_library` parameter, the request-order guard and
`loader_path` precedence; the previous round 12 more: the folder
allowlist, the name rule, the deployment check, each removal hook, the
watcher count, the workspace and flag re-reads, the read started by
watching, each import notification and the workspace guard; this round 2
more: the restart when a node is added back, and the stop when it is
deleted).
- `useComboWidget.deployment.test.ts`, `useComboWidget.test.ts`,
`assetService.test.ts` and `useFeatureFlags.test.ts` pass (294 tests).
- Typecheck, type-aware oxlint, eslint, oxfmt, knip, the Fallow push
audit and `check:pending-server-facts --offline` pass.
- Playwright, local Cloud dev server with the deployment listing,
`object_info`, `/api/features` and `/api/assets` mocked: the LoRA
dropdown with the flag off and on, dark, light and 390 px wide. With the
flag off the run counted no library read; with it on, one
`workspace_library=true` read per layout.

Not run: a real deployment with a real uploaded LoRA (needs the cloud
changes running; planned on the local stack);
`check:pending-server-facts` online (the Linear credentials are not set
locally; BE-24448 is open); the Playwright screenshots were not retaken
this round (the dropdown looks the same).

Try it: with `runtime_library_models_enabled` on for your workspace in
PostHog, pick a deployment in the editor, have a teammate in the same
workspace import a LoRA to the model library, add a Load LoRA node and
open `lora_name`. The Release's LoRAs come first, then the library's,
theirs included. With the flag off, only the Release's LoRAs.

Ref BE-20054

Local Cloud dev server with the deployment listing, `object_info`,
`/api/features` and `/api/assets` mocked. Release LoRA:
`homestead_private_v1.safetensors`; workspace library:
`my_style_v2.safetensors` and a teammate's
`teammate_portrait.safetensors`. "Flag off" is today's dropdown.

<details>
<summary>Dark</summary>

Flag off (only the Release's LoRA, as today):

<img width="1440" height="1000" alt="before-dark-lora"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-before-dark-lora.png"
/>

Flag on (Release first, then the workspace library):

<img width="1440" height="1000" alt="after-dark-lora"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-after-dark-lora.png"
/>

</details>

<details>
<summary>Light</summary>

Flag off (only the Release's LoRA, as today):

<img width="1440" height="1000" alt="before-light-lora"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-before-light-lora.png"
/>

Flag on (Release first, then the workspace library):

<img width="1440" height="1000" alt="after-light-lora"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-after-light-lora.png"
/>

</details>

<details>
<summary>Phone (390 px)</summary>

Flag off (only the Release's LoRA, as today):

<img width="390" height="844" alt="before-phone-lora"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-before-phone-lora.png"
/>

Flag on (Release first, then the workspace library):

<img width="390" height="844" alt="after-phone-lora"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be20054-after-phone-lora.png"
/>

</details>

(cherry picked from commit 317fa99)
…brary (#22210)

## Summary

An artist trains `my_style_v2.safetensors` on their own computer and
needs it in the workspace's model library. This adds the client and the
composable that upload one model file; the Import dialog's file option
(#22208) uses them. Nothing on screen changes here.

- `modelFileUploadApi.uploadModelFile(file, { tags, signal, onProgress
})`:
1. `POST /api/assets/uploads` with the file name, size and tags; the
answer is a signed URL and the headers to send.
2. `PUT` of the raw file straight to that URL with exactly those
headers, through `XMLHttpRequest` for upload progress; the `AbortSignal`
aborts it. Files up to 2 GB never pass through ingest.
3. `POST /api/assets/uploads/{upload_id}/complete`; its `202` answer
gives the task id.
Both answers are checked with the generated schemas
(`zStartModelUploadResponse`, `zCompleteModelUploadResponse`) and the
request bodies are typed with `StartModelUploadData` /
`CompleteModelUploadData`.
It returns a result value and never throws: `unsupportedFile`
(`UNSUPPORTED_FILE_TYPE`, at start or finish), `unsupportedType`
(`UNSUPPORTED_MODEL_TYPE`, a folder the server cannot store), `tooLarge`
(with the server's message, "Files can be up to 2 GB."),
`privateModelsDisabled` (`PRIVATE_MODELS_DISABLED`, the workspace's plan
has no private models), `planUnavailable` (`PRIVATE_MODELS_UNAVAILABLE`,
the plan could not be read), `failed` (start, storage or finish refused,
or the connection dropped) or `cancelled`. A file too large is refused
by the start call, before any byte is sent.
Storage answers `412` when this upload's staged object already exists
(the start answer's `x-goog-if-generation-match: 0` header, sent as
given). Each start makes a fresh `upload_id`, the object's key is built
from the workspace, the user, that `upload_id` and the file name, and
GCS shows an object only after a whole `PUT` succeeds. So a `412` means
this upload's bytes are already stored, for example when a `PUT` was
replayed after its answer was lost. The upload then goes on to step 3
with the same `upload_id`: `/complete` checks the object exists and is
at most 2 GB, and the library task checks that the bytes open as
safetensors. Starting over would send up to 2 GB again and leave the
first staged object behind.
- `useUploadModelFile()` runs one upload as a single state (`idle`,
`chosen`, `uploading`, `saving`, `done`, `failed`):
  - refuses a file that is not `.safetensors` before any call;
- offers only the folders the server lists in `model_upload_folders` on
`/api/features` (read through
`useFeatureFlags().flags.modelUploadFolders`), starting each chosen file
on `loras` when listed, else the first;
- says "Cloud can't store this model type yet. Choose another type."
when the server refuses the folder, "Your plan doesn't include private
models." when the plan has none, "Couldn't check your plan. Try again."
when the plan could not be read, and "Only .safetensors files can be
uploaded." when the server refuses the file; a failed library task shows
the task's own text ("This file is not a valid .safetensors file.");
  - tags the file `models` plus the chosen folder;
- after complete, tracks the task with `trackDownload` and follows its
status and error, as a link import is followed, so the existing
completion refresh updates the Model Library, the loader caches and the
loader dropdowns on a deployment. A task with any cancellation status
(pending, confirmed or never confirmed) says "Upload canceled.", and the
upload is still done if the task completes later, even after its row is
dismissed from the progress list; a task the server no longer has ends
in the store's "The download task is no longer available." instead of
staying on saving;
- `trackDownload` on a task the store already holds (its completion
arrived before the finish call's answer) fills in the model type and, if
the task already completed, raises the completion, so the refresh still
happens;
- ignores an answer that arrives after `reset`, aborts the transfer when
its owner unmounts, and reports a failed upload
(`error_uploading_model_file`);
- exposes `isAvailable` (the server lists at least one upload folder; it
sends `model_upload_folders` only while `runtime_library_models_enabled`
is on for the caller) for its caller.

- `@comfyorg/ingest-types` gains the two upload operations
(`startModelUpload`, `completeModelUpload`), `ModelUploadStarted` and
the features field `model_upload_folders`, generated with this package's
`openapi-ts` config from cloud's `services/ingest/openapi.yaml` at
Comfy-Org/cloud@3d15d828875 and kept to those additions: both routes'
`403` lists `FEATURE_DISABLED` and `PRIVATE_MODELS_DISABLED`, both have
the `503` `PRIVATE_MODELS_UNAVAILABLE`, `/complete`'s `400` lists
`UNSUPPORTED_FILE_TYPE`, and `ModelUploadStarted.headers` documents
`x-goog-if-generation-match: 0`.

## **Why**

Artists train LoRAs locally and need them in the shared workspace
library so a teammate's workflow can use them on the deployment. A link
import only works for files already on Civitai or Hugging Face.

## Testing

- `modelFileUploadApi.test.ts` (17): the three calls in order, each
start and finish call a `POST`, with the exact bodies, the signed
headers sent as given, one table of the start refusals with no bytes
sent (file type, size, model type, `403 PRIVATE_MODELS_DISABLED`, `503
PRIVATE_MODELS_UNAVAILABLE`), the model-type and plan refusals at
finish, the file-type refusal at finish, a `412` from storage finishing
the same upload with no second start or `PUT`, storage refusing the
bytes, a dropped connection, cancel aborting the transfer without
completing, cancel while waiting for the upload URL and while waiting
for the finish answer (the fake server rejects on abort as fetch does),
a finish answer that is not a task.
- `useUploadModelFile.test.ts` (24): wrong file type refused before
upload; choosing another file stops the earlier transfer and stops
following the earlier library task; the plan and file-type refusals
shown in plain words and not reported as errors; only the server's
folders offered, LoRA first when listed, else the first, and again for
each new file; offered exactly while the server lists folders, whatever
the runtime library flag says; a refused type asks for another;
progress, then saving, then done when the task completes (and the
completion that refreshes the library is raised); the chosen folder in
the tags; cancel; a failure reported and retried; the server's size
message; a failed task showing the task's text; a completion that
arrives before the finish answer still raising the refresh; a task the
server no longer has ending the save; a cancelled task; a cancel never
confirmed after six reads, then the row dismissed, then the task
completing; another import's completion ignored; an answer after reset
ignored; unmount aborting the transfer.
- `useFeatureFlags.test.ts`: `modelUploadFolders` read from
`/api/features`, empty when absent.
- Each production change was reverted one at a time and at least one
test failed each time (32 mutations, including the plan answers, the
`412` handling, `GET` for `POST`, a dropped abort signal, accepting any
task, only `cancelled` counting as a cancel, and ignoring a completion
after dismissal). 3,318 tests in `src/platform/workspace`,
`src/platform/assets`, the widget composables, `src/core/graph` and
`assetDownloadStore` pass.
- The folder-list gate and finishing on a `412` each fail their test
against the previous head.
- Typecheck (app and `@comfyorg/ingest-types`), type-aware oxlint,
eslint, oxfmt, knip and the Fallow push audit pass.

Not run: a real upload to a signed storage URL (needs the start and
finish routes running; planned on the local stack).

Try it: nothing to click in this PR; the next PR in the stack adds
"Choose a file" to the Import dialog.

Ref BE-24338

(cherry picked from commit 2a9c930)
## Summary

An artist trains `my_style_v2.safetensors` on their own computer. Before
this change, Cloud's Import dialog only takes a Civitai or Hugging Face
link, so a LoRA that lives only on their disk cannot get into the
workspace library from the editor. After it, with the
`runtime_library_models_enabled` flag on, the same dialog also says "Or
drop a .safetensors file here" with a "Choose a file" button. They pick
the file, keep the type at LoRA (or pick another the server can store),
press Upload, and watch "Uploading my_style_v2.safetensors, 140 MB of
228 MB" fill. When it is done the LoRA is in the Model Library and in
the LoRA loader's dropdown without a reload.

- The file goes from the browser straight to storage: `POST
/api/assets/uploads` answers a signed URL and the headers to send, the
browser `PUT`s the raw file there with those headers (progress from the
browser's upload events), then `POST
/api/assets/uploads/{upload_id}/complete` starts the task that stores
it. Files up to 2 GB never pass through ingest.
- The dialog follows that task exactly as it follows a link import
(`trackDownload`, the `asset_download` messages), so the existing
completion refresh updates the Model Library, the loader caches and the
loader dropdowns on a deployment.
- The type picker offers only the folders the server lists in
`model_upload_folders`, so a person cannot pick one the upload route
refuses. If the server still refuses it, the dialog says "Cloud can't
store this model type yet. Choose another type." and keeps the picker on
screen for Try again.
- Cancel stops the transfer. A file that is not `.safetensors` is
refused before any upload. A file over 2 GB is refused by the start call
before any byte is sent, with the server's "Files can be up to 2 GB.";
the editor keeps no copy of the limit. A storage failure, a dropped
connection and a cancel each say what happened, with Try again; a failed
upload is reported (`error_uploading_model_file`). When the library task
fails after the bytes arrived, Try again first asks the server to cancel
that task and keeps following it until it settles; it sends the file
again only once the task is cancelled or failed. If the task completed
after all, the dialog shows the model imported, naming the folder it
went to, and sends nothing. While Try again waits for the earlier task
to stop, the dialog says "Stopping the earlier upload..." with Cancel,
and shows "Uploading my_style_v2.safetensors" only once the file is
being sent. If the task is still running, its cancel cannot be
confirmed, or the cancel request fails, nothing is sent and the dialog
says "Couldn't confirm the earlier upload stopped, so the file wasn't
sent again." A failed cancel request is also reported
(`asset_download_cancellation_failure`). In both cases a later
completion still finishes the upload. Closing the import toast does not
change this: a task the server confirmed canceled lets Try again send at
once, and any other is shown in the toast again while Try again asks to
cancel it. Cancel pressed while Try again waits on the earlier task
stops the retry, says "Upload canceled." and keeps following that task.
Canceling the task from the import toast says "Upload canceled.", also
when the cancel is never confirmed, and a late completion still finishes
it. Back and closing the dialog stop following the task without asking
the server to cancel it: a failed library task is not retried or
revived, and a second copy of the same file is stored as the same
library model (same caller, same content hash).
- A workspace whose plan has no private models sees "Your plan doesn't
include private models."; a plan that could not be read, "Couldn't check
your plan. Try again."; a file the server refuses at finish, "Only
.safetensors files can be uploaded."; a file the library task cannot
open, the task's own "This file is not a valid .safetensors file." (the
answers are read in #22210).
- The import toast at the bottom said "All downloads completed" after an
upload. The download tracker now marks a row that came from a file
upload, and when every row is one the toast says
"my_style_v2.safetensors is in your library" (or "2 models are in your
library"). A link import, alone or mixed in, keeps "All downloads
completed".
- Flag off: the dialog is exactly today's. The dialog opened to fix a
missing model also stays link-only.

## How it is wired

- `UploadModelFilePicker` (drop zone and file input) and
`UploadModelFileUpload` (file row, type picker, progress, result) sit
beside the deployment pieces in `src/platform/workspace/components`;
`UploadModelDialog` shows them while `useUploadModelFile().isAvailable`
is on and the dialog is not resolving a missing model.
- The upload itself (start, the storage `PUT`, complete, following the
task) is `useUploadModelFile` and `modelFileUploadApi`, from #22210.

## **Why**

Artists train LoRAs locally and need them in the shared workspace
library so a teammate's workflow can use them on the deployment. A link
import only works for files already on Civitai or Hugging Face.

## Testing

- `UploadModelDialogFileUpload.test.ts` (19): flag off shows only the
link import, no file option without upload folders, flag on shows the
file option, a missing-model import stays link-only, choosing a file
shows its type and Upload and Back returns, dropping a file (`dragenter`
and `drop` with a `DataTransfer`) does the same, a wrong file type
explained, the picker offers only the server's folders with LoRA first,
a refused type keeps the picker so Try again sends the newly chosen
folder, the progress bar's percentage, Cancel stopping the transfer,
`upload-success` reaching the caller and Finish closing the dialog, a
canceled task saying so and still finishing on a late completion, Try
again canceling the failed task and sending again only once the cancel
is confirmed, "Stopping the earlier upload..." with Cancel while that
cancel is pending, then the upload once the file is sent, Try again
while a cancel from the toast is pending sending nothing and finishing
when the first task completes, a failed cancel request still finishing
on a late completion, the imported folder named from the task after
another type was picked, and a task that completed after all shown
imported with no second upload. `useUploadModelFile.test.ts` (6 new): a
cancel request that fails sends nothing and says the earlier upload
could not be confirmed stopped; a task still running after its cancel is
refused sends nothing, says so, and finishes when it completes; after
the toast is closed, a canceled task's Try again sends at once, and a
failed task's Try again cancels it and sends only once the cancel is
confirmed; Cancel pressed while the earlier task's cancel request is in
flight, or while its confirmation is awaited, stops the retry, says
"Upload canceled.", and a late completion still finishes it. Each of
these 4 fails against the previous push. This round, the stopping line,
the composable's `stopping` state and the dropped file each fail their
test against the previous head (the drop test fails with the drop
handler removed).
- `ModelImportProgressDialog.test.ts` (3 new): one upload names the
file, several are counted, a link import in the list keeps "All
downloads completed". `assetDownloadStore.test.ts` (1 new): an upload
stays marked through its progress and completion messages.
- Each production change was reverted one at a time and at least one
test failed each time (24 mutations: the flag gate, the missing-model
check, the server's folder list, the picker on failure, the upload mark
where it is set and where it is kept, the toast's every-row check, the
Cancel listener, the `upload-success` event, Finish, the progress
percentage, the cancel before Try again, the completed-after-all check,
the failed cancel request, the cancellation states, not waiting for a
pending cancel, no longer following the task while it settles, the
folder label read from the picker, counting any status as stopped,
keeping a task's status after its row is closed, sending at once after a
confirmed cancel, following a closed task again before canceling it,
checking Cancel after the cancel request, and ending the wait on
Cancel). At this push, 2,822 tests across `src/platform/assets`,
`src/platform/workspace`, the widget composables, `src/core/graph` and
`assetDownloadStore` pass.
- Typecheck, type-aware oxlint, eslint, oxfmt, knip, locale check and
the Fallow push audit pass.
- Playwright, local Cloud dev server with `/api/features`, the start and
finish routes and the task message mocked, and the storage `PUT` held by
a stand-in `XMLHttpRequest` so the progress frames can be captured: flag
off, then flag on (upload folders `checkpoints`, `loras`, `vae`) through
choose, type, uploading at 140 MB of 228 MB, done with the toast, a
storage refusal and a refused type, dark, light and 390 px wide.

Not run: a real upload to a signed storage URL (needs the start and
finish routes running; planned on the local stack).

Try it: with `runtime_library_models_enabled` on for your workspace,
open the Model Library, press Import, drop a `.safetensors` file on "Or
drop a .safetensors file here" (or press Choose a file), keep LoRA and
press Upload. When it says "Model successfully imported.", add a Load
LoRA node: the file is in `lora_name`.

Ref BE-24338

## Screenshots

<details>
<summary>Dark</summary>

Flag off (today's dialog):

<img width="1440" height="1000" alt="before-dark-import"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-before-dark-import.png"
/>

Flag on, the file option under the link:

<img width="1440" height="1000" alt="after-dark-1-choose"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-1-choose.png"
/>

A file chosen, its type (LoRA by default):

<img width="1440" height="1000" alt="after-dark-2-type"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-2-type.png"
/>

Uploading, 140 MB of 228 MB:

<img width="1440" height="1000" alt="after-dark-3-uploading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-3-uploading.png"
/>

Done, with the toast:

<img width="1440" height="1000" alt="after-dark-4-done"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-4-done.png"
/>

Storage refused the bytes:

<img width="1440" height="1000" alt="after-dark-5-failed"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-5-failed.png"
/>

The server refused the type; the picker stays:

<img width="1440" height="1000" alt="after-dark-6-type-refused"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-dark-6-type-refused.png"
/>

</details>
<details>
<summary>Light</summary>

Flag off (today's dialog):

<img width="1440" height="1000" alt="before-light-import"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-before-light-import.png"
/>

Flag on, the file option under the link:

<img width="1440" height="1000" alt="after-light-1-choose"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-1-choose.png"
/>

A file chosen, its type (LoRA by default):

<img width="1440" height="1000" alt="after-light-2-type"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-2-type.png"
/>

Uploading, 140 MB of 228 MB:

<img width="1440" height="1000" alt="after-light-3-uploading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-3-uploading.png"
/>

Done, with the toast:

<img width="1440" height="1000" alt="after-light-4-done"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-4-done.png"
/>

Storage refused the bytes:

<img width="1440" height="1000" alt="after-light-5-failed"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-5-failed.png"
/>

The server refused the type; the picker stays:

<img width="1440" height="1000" alt="after-light-6-type-refused"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-light-6-type-refused.png"
/>

</details>
<details>
<summary>Phone (390 px)</summary>

Flag off (today's dialog):

<img width="390" height="844" alt="before-phone-import"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-before-phone-import.png"
/>

Flag on, the file option under the link:

<img width="390" height="844" alt="after-phone-1-choose"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-1-choose.png"
/>

A file chosen, its type (LoRA by default):

<img width="390" height="844" alt="after-phone-2-type"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-2-type.png"
/>

Uploading, 140 MB of 228 MB:

<img width="390" height="844" alt="after-phone-3-uploading"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-3-uploading.png"
/>

Done, with the toast:

<img width="390" height="844" alt="after-phone-4-done"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-4-done.png"
/>

Storage refused the bytes:

<img width="390" height="844" alt="after-phone-5-failed"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-5-failed.png"
/>

The server refused the type; the picker stays:

<img width="390" height="844" alt="after-phone-6-type-refused"
src="https://gist.githubusercontent.com/vqt123/b9f31f5381267883dfcb5b6a06200c1d/raw/be24338-after-phone-6-type-refused.png"
/>

</details>

(cherry picked from commit b1c6275)
@vqt123 vqt123 added backport Backporting a PR onto a release candidate ai-assisted Written by a person driving an AI coding agent. Informational: no automation reads it. labels Oct 31, 2026
@vqt123 vqt123 self-assigned this Oct 31, 2026
@vqt123
vqt123 requested review from a team and dante01yoon as code owners October 31, 2026 13:06
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
dom-widget-order-dense-n200-w200-i120: · 33.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 409ms TBT · 71.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 43.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 161ms TBT · 64.7 MB heap
extension-clean-combined-draw: · 40.9 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 86ms TBT · 129.1 MB heap
extension-rgthree-prototype-draw: · 41.2 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 74ms TBT · 107.1 MB heap
large-combo-open: · 44.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 85.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
legacy-node-drag: · 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 91.4 MB heap
minimap-geometry-cadence: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
minimap-progress-execution-cadence: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
minimap-topology-cadence: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
subgraph-transition-enter: · 52.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 118ms TBT · 109.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
vue-large-graph-idle: · 26.9 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 0ms TBT · 266.5 MB heap
vue-large-graph-pan: · 21.4 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 11ms TBT · 264.4 MB heap
vue-node-resize-workload: · 23.0 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 241.1 MB heap
vue-zoom-out-idle: · 27.2 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 254.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 36.2 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 11
canvas-idle: style recalc count 11
canvas-idle: task duration 498ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.2 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 761ms
canvas-mouse-sweep: script duration 131ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.0 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 357ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 80.8 MB
canvas-zoom-sweep: DOM nodes 56
canvas-zoom-sweep: event listeners 43
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 429ms
dom-widget-clipping: script duration 139ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 62.8 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 30ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 762ms
dom-widget-order-dense-n200-w200-i120: script duration 51ms
dom-widget-order-dense-n200-w200-i120: TBT 409ms
dom-widget-order-dense-n200-w200-i120: heap used 71.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -191
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 436ms
dom-widget-order-sparse-n1000-w20-i120: script duration 123ms
dom-widget-order-sparse-n1000-w20-i120: TBT 161ms
dom-widget-order-sparse-n1000-w20-i120: heap used 64.7 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -96
dom-widget-order-sparse-n1000-w20-i120: event listeners -53
extension-clean-combined-draw: avg frame time 24ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 3
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 7006ms
extension-clean-combined-draw: script duration 5412ms
extension-clean-combined-draw: TBT 86ms
extension-clean-combined-draw: heap used 129.1 MB
extension-clean-combined-draw: DOM nodes -257
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 24ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 2
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 6992ms
extension-rgthree-prototype-draw: script duration 5457ms
extension-rgthree-prototype-draw: TBT 74ms
extension-rgthree-prototype-draw: heap used 107.1 MB
extension-rgthree-prototype-draw: DOM nodes -257
extension-rgthree-prototype-draw: event listeners -68
large-combo-open: avg frame time 23ms
large-combo-open: p95 frame time 67ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 13ms
large-combo-open: layout count 11
large-combo-open: style recalc count 23
large-combo-open: task duration 148ms
large-combo-open: script duration 8ms
large-combo-open: TBT 0ms
large-combo-open: heap used 85.0 MB
large-combo-open: DOM nodes 936
large-combo-open: event listeners 205
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 583ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 70.6 MB
large-graph-idle: DOM nodes -257
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 7
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1477ms
large-graph-pan: script duration 711ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 68.6 MB
large-graph-pan: DOM nodes -257
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 66
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1545ms
large-graph-zoom: script duration 669ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.2 MB
large-graph-zoom: DOM nodes -233
large-graph-zoom: event listeners -68
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1679ms
legacy-node-drag: script duration 826ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 91.4 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-geometry-cadence: avg frame time 17ms
minimap-geometry-cadence: p95 frame time 17ms
minimap-geometry-cadence: layout duration 2ms
minimap-geometry-cadence: style recalc duration 2ms
minimap-geometry-cadence: layout count 7
minimap-geometry-cadence: style recalc count 8
minimap-geometry-cadence: task duration 640ms
minimap-geometry-cadence: script duration 295ms
minimap-geometry-cadence: TBT 0ms
minimap-geometry-cadence: heap used 77.9 MB
minimap-geometry-cadence: DOM nodes -257
minimap-geometry-cadence: event listeners -68
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 8
minimap-idle: style recalc count 9
minimap-idle: task duration 545ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 63.2 MB
minimap-idle: DOM nodes -257
minimap-idle: event listeners -68
minimap-progress-execution-cadence: avg frame time 17ms
minimap-progress-execution-cadence: p95 frame time 17ms
minimap-progress-execution-cadence: layout duration 2ms
minimap-progress-execution-cadence: style recalc duration 11ms
minimap-progress-execution-cadence: layout count 7
minimap-progress-execution-cadence: style recalc count 27
minimap-progress-execution-cadence: task duration 485ms
minimap-progress-execution-cadence: script duration 153ms
minimap-progress-execution-cadence: TBT 0ms
minimap-progress-execution-cadence: heap used 72.5 MB
minimap-progress-execution-cadence: DOM nodes -253
minimap-progress-execution-cadence: event listeners -68
minimap-topology-cadence: avg frame time 17ms
minimap-topology-cadence: p95 frame time 17ms
minimap-topology-cadence: layout duration 2ms
minimap-topology-cadence: style recalc duration 2ms
minimap-topology-cadence: layout count 7
minimap-topology-cadence: style recalc count 8
minimap-topology-cadence: task duration 784ms
minimap-topology-cadence: script duration 304ms
minimap-topology-cadence: TBT 0ms
minimap-topology-cadence: heap used 76.6 MB
minimap-topology-cadence: DOM nodes -257
minimap-topology-cadence: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 380ms
subgraph-dom-widget-clipping: script duration 128ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 58.2 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 9
subgraph-idle: style recalc count 9
subgraph-idle: task duration 513ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.3 MB
subgraph-idle: DOM nodes -92
subgraph-idle: event listeners -58
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 13ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 680ms
subgraph-mouse-sweep: script duration 91ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 76.0 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 18ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 915ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 118ms
subgraph-transition-enter: heap used 109.4 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3246
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 30ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4902ms
viewport-pan-sweep: script duration 2244ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 63.5 MB
viewport-pan-sweep: DOM nodes -257
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 37ms
vue-large-graph-idle: p95 frame time 75ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 19893ms
vue-large-graph-idle: script duration 291ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 266.5 MB
vue-large-graph-idle: DOM nodes -3343
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 47ms
vue-large-graph-pan: p95 frame time 100ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 24116ms
vue-large-graph-pan: script duration 761ms
vue-large-graph-pan: TBT 11ms
vue-large-graph-pan: heap used 264.4 MB
vue-large-graph-pan: DOM nodes -3343
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 43ms
vue-node-resize-workload: p95 frame time 92ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 50ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 7247ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 241.1 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 37ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9789ms
vue-zoom-out-idle: script duration 132ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 254.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 7ms
workflow-execution: layout count 7
workflow-execution: style recalc count 7
workflow-execution: task duration 72ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.3 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 4
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 14ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 322ms
agent-composer-empty-conversation-typing: script duration 147ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 36.2 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 14ms
agent-composer-long-conversation-typing: style recalc duration 3ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 389ms
agent-composer-long-conversation-typing: script duration 144ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 87.3 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-31T13:36:08.866Z",
  "gitSha": "e0a507dd15d393ead0c6c305d1b163e1c2c28995",
  "branch": "vinh/backport-be17387-cloud-1.59",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2008.2709999999793,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.352,
      "layouts": 11,
      "layoutDurationMs": 3.071,
      "taskDurationMs": 521.6540000000001,
      "heapDeltaBytes": 5197164,
      "heapUsedBytes": 75535540,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 11.716,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.7119999999559,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.1380000000000003,
      "layouts": 10,
      "layoutDurationMs": 3.071,
      "taskDurationMs": 473.596,
      "heapDeltaBytes": 1316592,
      "heapUsedBytes": 63272476,
      "domNodes": 0,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 9.949,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1710.5149999999867,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 13.149000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.5780000000000003,
      "taskDurationMs": 795.2429999999999,
      "heapDeltaBytes": -1434076,
      "heapUsedBytes": 68424436,
      "domNodes": 0,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 135.982,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66504854368932,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1725.6059999999707,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 12.076,
      "layouts": 9,
      "layoutDurationMs": 2.259,
      "taskDurationMs": 727.2,
      "heapDeltaBytes": -1647564,
      "heapUsedBytes": 67838056,
      "domNodes": 0,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 125.23099999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667307692307688,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.6119999999555,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.926,
      "layouts": 11,
      "layoutDurationMs": 2.947,
      "taskDurationMs": 377.401,
      "heapDeltaBytes": 22813736,
      "heapUsedBytes": 84461480,
      "domNodes": 56,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 12.889,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.9649999999974,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.346,
      "layouts": 10,
      "layoutDurationMs": 2.474,
      "taskDurationMs": 336.19200000000006,
      "heapDeltaBytes": 24094728,
      "heapUsedBytes": 85024840,
      "domNodes": 56,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 10.486000000000002,
      "eventListeners": 43,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 576.7629999999997,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.843,
      "layouts": 9,
      "layoutDurationMs": 2.5989999999999998,
      "taskDurationMs": 431.219,
      "heapDeltaBytes": 5319800,
      "heapUsedBytes": 66511124,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 140.58700000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 567.8589999999986,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.9929999999999994,
      "layouts": 10,
      "layoutDurationMs": 2.585,
      "taskDurationMs": 426.566,
      "heapDeltaBytes": 3424568,
      "heapUsedBytes": 65214020,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 136.555,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823523,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1048.4749999999963,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 745.8419999999999,
      "heapDeltaBytes": -12807684,
      "heapUsedBytes": 74795260,
      "domNodes": -191,
      "jsHeapTotalBytes": 21241856,
      "scriptDurationMs": 51.67599999999999,
      "eventListeners": -106,
      "totalBlockingTimeMs": 394,
      "frameDurationMs": 30,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1098.1149999999502,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 777.916,
      "heapDeltaBytes": -12409668,
      "heapUsedBytes": 75183448,
      "domNodes": -191,
      "jsHeapTotalBytes": 20455424,
      "scriptDurationMs": 49.50299999999999,
      "eventListeners": -106,
      "totalBlockingTimeMs": 423,
      "frameDurationMs": 29.72702702702704,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 776.2930000000097,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.67200000000014,
      "heapDeltaBytes": -4771788,
      "heapUsedBytes": 69755080,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 119.07600000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 161,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 817.2830000000317,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.8500000000003,
      "heapDeltaBytes": -23913632,
      "heapUsedBytes": 65900568,
      "domNodes": -191,
      "jsHeapTotalBytes": 3014656,
      "scriptDurationMs": 127.75999999999999,
      "eventListeners": -106,
      "totalBlockingTimeMs": 160,
      "frameDurationMs": 22.686111111111106,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8139.848999999998,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5079999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.696,
      "taskDurationMs": 7281.3820000000005,
      "heapDeltaBytes": 65680120,
      "heapUsedBytes": 139704596,
      "domNodes": -257,
      "jsHeapTotalBytes": 60944384,
      "scriptDurationMs": 5617.9169999999995,
      "eventListeners": -68,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 24.423423423423422,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7526.9309999999905,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5740000000000007,
      "layouts": 2,
      "layoutDurationMs": 0.4210000000000004,
      "taskDurationMs": 6731.084,
      "heapDeltaBytes": 57252844,
      "heapUsedBytes": 131022684,
      "domNodes": -257,
      "jsHeapTotalBytes": 53080064,
      "scriptDurationMs": 5206.033,
      "eventListeners": -68,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 24.512012987012987,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7910.461999999996,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.5760000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.6069999999999999,
      "taskDurationMs": 7056.156,
      "heapDeltaBytes": -17909920,
      "heapUsedBytes": 70865152,
      "domNodes": -257,
      "jsHeapTotalBytes": 5107712,
      "scriptDurationMs": 5506.424,
      "eventListeners": -68,
      "totalBlockingTimeMs": 111,
      "frameDurationMs": 24.283128834355832,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7691.175999999985,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.29800000000000054,
      "layouts": 1,
      "layoutDurationMs": 0.24600000000000014,
      "taskDurationMs": 6928.483,
      "heapDeltaBytes": 79002920,
      "heapUsedBytes": 153830468,
      "domNodes": -257,
      "jsHeapTotalBytes": 66973696,
      "scriptDurationMs": 5407.438,
      "eventListeners": -68,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 24.236593059936904,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 225.88299999998185,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 13.459999999999999,
      "layouts": 12,
      "layoutDurationMs": 3.359,
      "taskDurationMs": 167.8,
      "heapDeltaBytes": 14477612,
      "heapUsedBytes": 85889296,
      "domNodes": 936,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 8.848999999999998,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.209090909090925,
      "p95FrameDurationMs": 66.70000000000027
    },
    {
      "name": "large-combo-open",
      "durationMs": 169.6019999999976,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 11.574000000000002,
      "layouts": 10,
      "layoutDurationMs": 2.405,
      "taskDurationMs": 127.48300000000002,
      "heapDeltaBytes": 14456792,
      "heapUsedBytes": 92325056,
      "domNodes": 936,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.690999999999998,
      "eventListeners": 205,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.81428571428569,
      "p95FrameDurationMs": 66.59999999999991
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.8219999999956,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.4919999999999995,
      "layouts": 8,
      "layoutDurationMs": 2.106,
      "taskDurationMs": 620.0470000000001,
      "heapDeltaBytes": 8817404,
      "heapUsedBytes": 82946140,
      "domNodes": -257,
      "jsHeapTotalBytes": 4059136,
      "scriptDurationMs": 33.311,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66475409836066,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.8789999999653,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.1229999999999998,
      "layouts": 8,
      "layoutDurationMs": 1.9589999999999999,
      "taskDurationMs": 546.9129999999999,
      "heapDeltaBytes": -8818652,
      "heapUsedBytes": 65062188,
      "domNodes": -257,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 30.092999999999996,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2770.9839999999986,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.226999999999999,
      "layouts": 7,
      "layoutDurationMs": 1.6840000000000002,
      "taskDurationMs": 1542.4410000000003,
      "heapDeltaBytes": -29073300,
      "heapUsedBytes": 62595976,
      "domNodes": -257,
      "jsHeapTotalBytes": 6193152,
      "scriptDurationMs": 758.719,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666467065868265,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2554.593000000011,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.033,
      "layouts": 7,
      "layoutDurationMs": 1.6380000000000001,
      "taskDurationMs": 1410.8110000000001,
      "heapDeltaBytes": 5495856,
      "heapUsedBytes": 81309868,
      "domNodes": -257,
      "jsHeapTotalBytes": 5332992,
      "scriptDurationMs": 664.095,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666013071895428,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3702.060999999958,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.321999999999997,
      "layouts": 65,
      "layoutDurationMs": 10.989,
      "taskDurationMs": 1604.1950000000002,
      "heapDeltaBytes": -1099080,
      "heapUsedBytes": 74936904,
      "domNodes": -233,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 690.01,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665765765765766,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3468.9129999999864,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 9.931,
      "layouts": 66,
      "layoutDurationMs": 10.226,
      "taskDurationMs": 1485.385,
      "heapDeltaBytes": -20825860,
      "heapUsedBytes": 59779868,
      "domNodes": -233,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 647.135,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665865384615387,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2765.3019999999915,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 5.417000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.712,
      "taskDurationMs": 1726.12,
      "heapDeltaBytes": 17149764,
      "heapUsedBytes": 94660620,
      "domNodes": 0,
      "jsHeapTotalBytes": 6184960,
      "scriptDurationMs": 852.211,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.767272727272726,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2515.5020000000263,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.606,
      "layouts": 7,
      "layoutDurationMs": 1.6929999999999996,
      "taskDurationMs": 1632.002,
      "heapDeltaBytes": 15143672,
      "heapUsedBytes": 96948440,
      "domNodes": 0,
      "jsHeapTotalBytes": 5398528,
      "scriptDurationMs": 798.953,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.77666666666667,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 2988.4950000000003,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.824,
      "layouts": 7,
      "layoutDurationMs": 1.6649999999999998,
      "taskDurationMs": 649.694,
      "heapDeltaBytes": 1095860,
      "heapUsedBytes": 75815816,
      "domNodes": -257,
      "jsHeapTotalBytes": 5107712,
      "scriptDurationMs": 297.255,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-geometry-cadence",
      "durationMs": 2922.060999999985,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.6960000000000004,
      "layouts": 7,
      "layoutDurationMs": 1.5830000000000002,
      "taskDurationMs": 631.04,
      "heapDeltaBytes": 10802508,
      "heapUsedBytes": 87636108,
      "domNodes": -257,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 292.85999999999996,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666285714285717,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.0680000000239,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.4000000000000004,
      "layouts": 9,
      "layoutDurationMs": 2.392,
      "taskDurationMs": 569.238,
      "heapDeltaBytes": -13642304,
      "heapUsedBytes": 63395364,
      "domNodes": -257,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 30.837999999999997,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.0660000000098,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.6960000000000004,
      "layouts": 7,
      "layoutDurationMs": 1.4240000000000002,
      "taskDurationMs": 521.7570000000001,
      "heapDeltaBytes": -8954812,
      "heapUsedBytes": 69068508,
      "domNodes": -257,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 31.479,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2725.490000000008,
      "styleRecalcs": 27,
      "styleRecalcDurationMs": 11.591000000000001,
      "layouts": 7,
      "layoutDurationMs": 1.7460000000000002,
      "taskDurationMs": 496.2540000000001,
      "heapDeltaBytes": -16584164,
      "heapUsedBytes": 76389584,
      "domNodes": -252,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 157.915,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536587,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-progress-execution-cadence",
      "durationMs": 2690.8000000000243,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 10.772,
      "layouts": 7,
      "layoutDurationMs": 1.411,
      "taskDurationMs": 474.4490000000001,
      "heapDeltaBytes": -1267052,
      "heapUsedBytes": 75662796,
      "domNodes": -253,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 147.57799999999997,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665838509316767,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3070.970999999986,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.087,
      "layouts": 7,
      "layoutDurationMs": 1.9070000000000003,
      "taskDurationMs": 785.2389999999999,
      "heapDeltaBytes": 2630588,
      "heapUsedBytes": 78327976,
      "domNodes": -257,
      "jsHeapTotalBytes": 5369856,
      "scriptDurationMs": 308.605,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665945945945946,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-topology-cadence",
      "durationMs": 3065.025999999989,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.8999999999999997,
      "layouts": 7,
      "layoutDurationMs": 1.91,
      "taskDurationMs": 782.4050000000001,
      "heapDeltaBytes": 5420128,
      "heapUsedBytes": 82379252,
      "domNodes": -257,
      "jsHeapTotalBytes": 5369856,
      "scriptDurationMs": 298.707,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665760869565215,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 547.3440000000096,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.5569999999999995,
      "layouts": 9,
      "layoutDurationMs": 2.271,
      "taskDurationMs": 386.68899999999996,
      "heapDeltaBytes": -1267124,
      "heapUsedBytes": 61009164,
      "domNodes": 0,
      "jsHeapTotalBytes": 8912896,
      "scriptDurationMs": 128.42700000000002,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 542.8379999999606,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.367,
      "layouts": 10,
      "layoutDurationMs": 2.6109999999999998,
      "taskDurationMs": 372.6,
      "heapDeltaBytes": -1218192,
      "heapUsedBytes": 60971432,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 126.62,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.9799999999896,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.6369999999999996,
      "layouts": 8,
      "layoutDurationMs": 2.3340000000000005,
      "taskDurationMs": 509.918,
      "heapDeltaBytes": 1741700,
      "heapUsedBytes": 63649544,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 10.602,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.2540000000085,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.7609999999999997,
      "layouts": 9,
      "layoutDurationMs": 2.6940000000000004,
      "taskDurationMs": 516.9019999999999,
      "heapDeltaBytes": -5027368,
      "heapUsedBytes": 56517328,
      "domNodes": -183,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 9.417,
      "eventListeners": -115,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6672131147541,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1675.1590000000078,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.255,
      "layouts": 10,
      "layoutDurationMs": 2.282,
      "taskDurationMs": 706.4929999999999,
      "heapDeltaBytes": 17166500,
      "heapUsedBytes": 79734876,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 96.135,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663363,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1675.6180000000427,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 12.148000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.055,
      "taskDurationMs": 653.922,
      "heapDeltaBytes": 17321456,
      "heapUsedBytes": 79739196,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 86.49900000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663363,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1368.2440000000042,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 18.174999999999997,
      "layouts": 5,
      "layoutDurationMs": 10.571999999999997,
      "taskDurationMs": 914.9949999999998,
      "heapDeltaBytes": 38084668,
      "heapUsedBytes": 114694956,
      "domNodes": 16030,
      "jsHeapTotalBytes": 15601664,
      "scriptDurationMs": 27.779999999999998,
      "eventListeners": 3246,
      "totalBlockingTimeMs": 118,
      "frameDurationMs": 18.949315068493153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9883.020999999986,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 31.087999999999997,
      "layouts": 8,
      "layoutDurationMs": 2.111,
      "taskDurationMs": 5098.438,
      "heapDeltaBytes": -11593056,
      "heapUsedBytes": 61563936,
      "domNodes": -257,
      "jsHeapTotalBytes": 4321280,
      "scriptDurationMs": 2319.45,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66593591905565,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8477.02700000002,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 28.852999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.053,
      "taskDurationMs": 4706.484,
      "heapDeltaBytes": -2162428,
      "heapUsedBytes": 71623164,
      "domNodes": -257,
      "jsHeapTotalBytes": 5070848,
      "scriptDurationMs": 2168.4910000000004,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666011787819254,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 20039.908000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19652.320000000003,
      "heapDeltaBytes": -8915144,
      "heapUsedBytes": 274069548,
      "domNodes": -3343,
      "jsHeapTotalBytes": 8380416,
      "scriptDurationMs": 291.86500000000007,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.58461538461539,
      "p95FrameDurationMs": 66.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 20813.07400000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20134.574999999997,
      "heapDeltaBytes": -11615048,
      "heapUsedBytes": 284755020,
      "domNodes": -3343,
      "jsHeapTotalBytes": 16506880,
      "scriptDurationMs": 289.343,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.77720848056537,
      "p95FrameDurationMs": 83.20000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24312.408000000003,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 20.515000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23996.354,
      "heapDeltaBytes": 3471044,
      "heapUsedBytes": 276873612,
      "domNodes": -3343,
      "jsHeapTotalBytes": 13619200,
      "scriptDurationMs": 753.4119999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 22,
      "frameDurationMs": 46.31561904761905,
      "p95FrameDurationMs": 99.89999999999964
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24455.963999999993,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 23.005000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24235.590000000004,
      "heapDeltaBytes": -26124216,
      "heapUsedBytes": 277576020,
      "domNodes": -3343,
      "jsHeapTotalBytes": 13881344,
      "scriptDurationMs": 768.886,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 47.10809248554913,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7223.453000000007,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.61599999999999,
      "layouts": 20,
      "layoutDurationMs": 23.002999999999997,
      "taskDurationMs": 7157.635,
      "heapDeltaBytes": -27322780,
      "heapUsedBytes": 256713160,
      "domNodes": -3343,
      "jsHeapTotalBytes": 18079744,
      "scriptDurationMs": 126.33500000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 42.44941176470588,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7400.8420000000115,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.15800000000001,
      "layouts": 20,
      "layoutDurationMs": 22.31100000000001,
      "taskDurationMs": 7336.946999999999,
      "heapDeltaBytes": -47349000,
      "heapUsedBytes": 248914076,
      "domNodes": -3344,
      "jsHeapTotalBytes": 17813504,
      "scriptDurationMs": 110.284,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 44.475903614457835,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9952.089999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9728.482,
      "heapDeltaBytes": 8889152,
      "heapUsedBytes": 266991044,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 129.09999999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.20224719101124,
      "p95FrameDurationMs": 66.79999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 10130.104999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9849.289999999999,
      "heapDeltaBytes": -4359604,
      "heapUsedBytes": 267591864,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 135.46099999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.44928057553956,
      "p95FrameDurationMs": 66.79999999999927
    },
    {
      "name": "workflow-execution",
      "durationMs": 113.01800000001094,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.989,
      "layouts": 7,
      "layoutDurationMs": 2.933,
      "taskDurationMs": 72.213,
      "heapDeltaBytes": 4770580,
      "heapUsedBytes": 65217340,
      "domNodes": 127,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.039999999999999,
      "eventListeners": 3,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428546,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 104.18000000004213,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.9110000000000005,
      "layouts": 7,
      "layoutDurationMs": 2.811,
      "taskDurationMs": 72.465,
      "heapDeltaBytes": 4623208,
      "heapUsedBytes": 65398104,
      "domNodes": 121,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.540000000000003,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 354.1649999999663,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.716,
      "layouts": 76,
      "layoutDurationMs": 13.857,
      "taskDurationMs": 314.71500000000003,
      "heapDeltaBytes": -5422884,
      "heapUsedBytes": 38337484,
      "domNodes": 4,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 143.47099999999998,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 365.97999999992226,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.6759999999999999,
      "layouts": 76,
      "layoutDurationMs": 15.069,
      "taskDurationMs": 328.528,
      "heapDeltaBytes": -5497248,
      "heapUsedBytes": 37634304,
      "domNodes": 4,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 150.48600000000002,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660869565217382,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 414.1699999998991,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.428,
      "layouts": 76,
      "layoutDurationMs": 14.066,
      "taskDurationMs": 382.687,
      "heapDeltaBytes": -912320,
      "heapUsedBytes": 89640008,
      "domNodes": 4,
      "jsHeapTotalBytes": 790528,
      "scriptDurationMs": 138.68800000000002,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667999999999992,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 436.5980000000036,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.1069999999999998,
      "layouts": 76,
      "layoutDurationMs": 14.808,
      "taskDurationMs": 396.17999999999995,
      "heapDeltaBytes": -433832,
      "heapUsedBytes": 93390200,
      "domNodes": 4,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 148.59499999999997,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66296296296295,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Line coverage: 60.1%

Coverage totals
Metric Covered Total Pct
Lines 60558 100759 60.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.9% 1177
src/workbench/extensions/agent/crdt/liveGraphApplier.ts 2.1% 657
src/workbench/extensions/agent/composables/agent/useAgentSession.ts 14.9% 647
src/workbench/extensions/agent/AgentPanelRoot.vue 27.8% 558
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts 14.6% 498
src/workbench/extensions/agent/crdt/docOpMinter.ts 4.3% 425
src/LGraphNode.ts 71.3% 379
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts 26.1% 379
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 39.6% 332
src/platform/billing/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 321

🎭 Playwright: ✅ 3128 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2325 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 772 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • desktop: View Report (✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/31/2026, 01:25:10 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (45 changed files).

Kind Finding Where Usual remedy
Complexity buildJobDisplay() — cyclomatic 19, CRAP undefined src/utils/queueDisplay.ts:67 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity addComboWidget() — cyclomatic 17, CRAP 79.4 src/renderer/extensions/vueNodes/widgets/composables/useComboWidget.ts:342 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 044f4e1002d093ff6994132f9dd57aae1781972f

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (238)

  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupEnforcementBoundary.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/syncPromotedComboHostOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/legacyUI/attachLegacyUI.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cloudBadges.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/electronAdapter.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.cloud.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/index.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/findNumericWidget.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dLazy.retry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dSettings.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dWidgets.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchPointerGuards.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/ContextMenu.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 188 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@codecov

codecov Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.48031% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/workspace/api/modelFileUploadApi.ts 86.66% 8 Missing ⚠️
...atform/workspace/composables/useUploadModelFile.ts 96.66% 5 Missing ⚠️
...orm/workspace/components/UploadModelFileUpload.vue 98.63% 1 Missing ⚠️
src/stores/assetDownloadStore.ts 92.85% 1 Missing ⚠️
src/utils/queueDisplay.ts 90.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.59   #22493   +/-   ##
=============================================
  Coverage              ?   87.29%           
=============================================
  Files                 ?     3141           
  Lines                 ?   162499           
  Branches              ?    41467           
=============================================
  Hits                  ?   141859           
  Misses                ?    19796           
  Partials              ?      844           
Flag Coverage Δ
billing-web-unit 92.14% <ø> (?)
e2e 60.00% <18.69%> (?)
unit 86.51% <99.01%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/ingest-types/src/zod.gen.ts 100.00% <100.00%> (ø)
src/composables/__mocks__/useFeatureFlags.ts 87.50% <ø> (ø)
src/composables/queue/useJobList.ts 99.03% <100.00%> (ø)
src/composables/useFeatureFlags.ts 97.22% <100.00%> (ø)
...core/graph/widgets/syncPromotedComboHostOptions.ts 100.00% <100.00%> (ø)
...rm/assets/components/ModelImportProgressDialog.vue 87.71% <100.00%> (ø)
...c/platform/assets/components/UploadModelDialog.vue 74.00% <100.00%> (ø)
...platform/assets/components/UploadModelUrlInput.vue 78.78% <ø> (ø)
src/platform/assets/services/assetService.ts 81.81% <100.00%> (ø)
src/platform/remoteConfig/serverFeatureFlag.ts 100.00% <100.00%> (ø)
... and 12 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 31, 2026
… on (#22487)

## Summary

You have the editor open with a deployment picked, and a LoRA loader's
dropdown lists your library's models. The library-models flag turns off,
then back on, while the page stays open.

- **Before:** the dropdown comes back with the list it had before the
flag went off, and no folder is read again. A model deleted in that
window is still offered, and picking it fails the job.
- **Now:** turning the flag off drops the cached lists, as switching
workspace already does, and turning it back on reads every open folder
again. A read that started before the flag went off is ignored when it
answers late.

The change is the suggestion from the review of #22157
(#22157 (comment)),
as written.

## Why

James Kwon asked for this in his review of #22157
(#22157 (comment)):
turning the flag off left the cached lists in place, so turning it back
on showed them again without reading any folder. #22157 merged without
it, and frontend main still has the old watcher.

## Verification

- Tests: new `deploymentLibraryModelsStore.test.ts`, two cases:
- flag off then on: the folder is read a second time and the dropdown
shows the second read's names;
- a read that started before the flag went off and answers after it came
back on is ignored; the newer read's names stay.
- Both fail on main's watcher (one read only; the stale names win) and
pass with the fix. With the fix minus the `generation++` bump, the
second case fails.
- `pnpm typecheck`, oxlint and oxfmt pass on both files.
- Not run: the editor in a browser with the flag flipped in PostHog; the
unit test mocks the flag and the library API.

Ref BE-24489

(cherry picked from commit 62ef02a)
@vqt123 vqt123 changed the title [backport cloud/1.59] LoRA from the workspace library: dropdowns, Downloading bar, Choose a file (#22159, #22157, #22210, #22208) [backport cloud/1.59] LoRA from the workspace library: dropdowns, Downloading bar, Choose a file (#22159, #22157, #22210, #22208, #22487) Oct 31, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the cloud/1.59 backport.

@comfy-pr-bot
comfy-pr-bot merged commit ea157a8 into cloud/1.59 Oct 31, 2026
117 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the vinh/backport-be17387-cloud-1.59 branch October 31, 2026 15:03
koshimazaki pushed a commit to koshimazaki/ComfyUI_frontend that referenced this pull request Nov 1, 2026
…omfy-Org#22506)

## Summary

With a deployment picked, you change a library model's type in the model
library, say from LoRA to checkpoint.

- **Before:** the LoRA loader's dropdown still lists the model, and the
checkpoint loader's does not, until the page reloads. Picking it from
the LoRA loader fails the run.
- **After:** both dropdowns update right away. The model leaves the LoRA
list and shows up in the checkpoint list.

The library model lists reread a folder when the asset service says an
asset changed. Deleting an asset and a finished import already say so.
Adding or removing an asset's tags, which is how a type change is saved,
did not. Now `addAssetTags` and `removeAssetTags` say so too, once the
server has accepted the change, the same way `deleteAsset` does. The
undo path in `assetsStore.updateAssetTags` goes through `addAssetTags`,
so it is covered as well. A failed call still says nothing.

A type change is a remove and then an add, so each watched folder is
reread twice. The store already keeps only the latest read per folder.

**Why** An artist who corrects a model's type should see it in the right
loader without reloading the page. Today the old loader keeps offering
it and the new one does not. This came up in review of the cloud/1.59
backport of Comfy-Org#22157 (Comfy-Org#22493), and the new store test below reproduces it:
on main, `loras` still holds the model after the change. It has not been
reported from production; these lists only show with the library models
flag on.

## Verification

- `assetService.test.ts`: a successful `addAssetTags` or
`removeAssetTags` calls an `onAssetsChanged` listener once; a call the
server refuses (500) does not. The two success cases fail on main.
- `deploymentLibraryModelsStore.test.ts`: a type change from LoRA to
checkpoint through `assetsStore.updateAssetTags` takes the model out of
the `loras` list and puts it in the `checkpoints` list. Fails on main
(`loras` still holds the model).
- `pnpm vitest run` on both files: 93 pass. `assetsStore.test.ts`,
`useComboWidget.deployment.test.ts` and the model info panel tests also
pass. Typecheck, oxlint, eslint and oxfmt are clean.

Not run: no browser check against a live backend. The tests mock the
API, so they do not cover a real model library page changing a model's
type.

Ref BE-24660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Written by a person driving an AI coding agent. Informational: no automation reads it. backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants