Repository navigation
[backport core/1.58] fix: handle rejected play() in useWaveAudioPlayer - #22455
Conversation
## Summary Fixes the unhandled `NotSupportedError` from `WaveAudioPlayer` and the agent audio reply card ([FRONT-3746](https://linear.app/comfyorg/issue/FRONT-3746), Sentry [CLOUD-FRONTEND-PROD-31S](https://comfy-org.sentry.io/issues/7811786061/)). `useWaveAudioPlayer` started playback by setting vueuse's `playing` ref. `useMediaControls` fires its error event and then rethrows the `play()` rejection, so no consumer could handle it, and the user got no feedback. ## Changes - `togglePlayPause` and `handleWaveformClick` call `play()` directly in `try/catch`. Pause and the media events still go through `useMediaControls`, so `isPlaying` is unchanged for working audio. - Both entry points branch on `audio.paused`, so a click during buffering can pause. - On failure the element is paused and the same localized toast as [#22390](#22390) is shown. `AbortError` and superseded attempts stay silent. - A failed source is reloaded before a retry. - The toast clears on a successful retry, pause, a change of the logical source, or scope disposal. `WaveAudioPlayer` passes `logicalSrc` because its retry logic clears and restores the same URL. - Failures go through `reportError` at warning level (`error_playing_audio`). `g.audioPlaybackFailed` is added here on the same line as #22390, so either can land first. `WaveAudioPlayer.test.ts`: the media stub now models `paused` and its events, as a real element does. ## Verification - New tests run against the real `useMediaControls`. Before the fix they failed with the unhandled rejection; removing the attempt guard fails one again. - Against the old composable: 7 tests fail with 19 unhandled rejections. With the fix, the composable, `WaveAudioPlayer` and `ReplyAudioCard` suites pass. - Not run in real Safari.
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T04:06:12.392Z",
"gitSha": "ae5f112cd924d7aaa34e16c94b1ea23156978d68",
"branch": "backport-22451-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.456000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.91,
"layouts": 9,
"layoutDurationMs": 2.808,
"taskDurationMs": 621.4090000000001,
"heapDeltaBytes": -12593936,
"heapUsedBytes": 88000036,
"domNodes": -200,
"jsHeapTotalBytes": 7483392,
"scriptDurationMs": 10.748999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2040.5349999999771,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.176,
"layouts": 9,
"layoutDurationMs": 3.1020000000000003,
"taskDurationMs": 545.5110000000001,
"heapDeltaBytes": 1810636,
"heapUsedBytes": 92646992,
"domNodes": -200,
"jsHeapTotalBytes": 2424832,
"scriptDurationMs": 14.780999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.514000000005,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.552,
"layouts": 10,
"layoutDurationMs": 2.7680000000000007,
"taskDurationMs": 946.7120000000001,
"heapDeltaBytes": 599712,
"heapUsedBytes": 91217104,
"domNodes": -200,
"jsHeapTotalBytes": 2949120,
"scriptDurationMs": 165.518,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665178571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.4129999999845,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.544,
"layouts": 9,
"layoutDurationMs": 2.4789999999999996,
"taskDurationMs": 1029.4830000000002,
"heapDeltaBytes": -1992804,
"heapUsedBytes": 88348288,
"domNodes": -200,
"jsHeapTotalBytes": 2162688,
"scriptDurationMs": 172.25400000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.1779999999949,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.026999999999999,
"layouts": 11,
"layoutDurationMs": 3.3480000000000003,
"taskDurationMs": 362.539,
"heapDeltaBytes": -1381588,
"heapUsedBytes": 88989904,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 15.925999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2960000000576,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.101999999999999,
"layouts": 12,
"layoutDurationMs": 3.501000000000001,
"taskDurationMs": 502.50900000000007,
"heapDeltaBytes": -598912,
"heapUsedBytes": 99580548,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 17.118999999999996,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 650.1050000000248,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8019999999999996,
"layouts": 10,
"layoutDurationMs": 2.6620000000000004,
"taskDurationMs": 478.065,
"heapDeltaBytes": 4840600,
"heapUsedBytes": 103842000,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 165.87400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 727.0460000000867,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.397,
"layouts": 9,
"layoutDurationMs": 3.3479999999999994,
"taskDurationMs": 488.6700000000001,
"heapDeltaBytes": 4242624,
"heapUsedBytes": 94659452,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 183.90200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.2779999999789,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 913.5780000000001,
"heapDeltaBytes": -14218288,
"heapUsedBytes": 103235940,
"domNodes": -230,
"jsHeapTotalBytes": 16064512,
"scriptDurationMs": 72.925,
"eventListeners": -168,
"totalBlockingTimeMs": 518,
"frameDurationMs": 32.015789473684194,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1245.4060000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 934.2800000000001,
"heapDeltaBytes": -14871376,
"heapUsedBytes": 102732832,
"domNodes": -230,
"jsHeapTotalBytes": 15015936,
"scriptDurationMs": 72.099,
"eventListeners": -168,
"totalBlockingTimeMs": 559,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.7029999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.43800000000005,
"heapDeltaBytes": -4036596,
"heapUsedBytes": 97378364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.045,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.2999999999756,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.83100000000013,
"heapDeltaBytes": -3550260,
"heapUsedBytes": 97894860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.53500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11333.321000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10407.31,
"heapDeltaBytes": 54219008,
"heapUsedBytes": 169260592,
"domNodes": -296,
"jsHeapTotalBytes": 53096448,
"scriptDurationMs": 8361.74,
"eventListeners": -130,
"totalBlockingTimeMs": 1362,
"frameDurationMs": 31.30635359116022,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11144.514000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10369.786,
"heapDeltaBytes": 37863668,
"heapUsedBytes": 146945836,
"domNodes": -296,
"jsHeapTotalBytes": 34406400,
"scriptDurationMs": 8314.237,
"eventListeners": -130,
"totalBlockingTimeMs": 1222,
"frameDurationMs": 31.675,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10373.992999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9647.064999999999,
"heapDeltaBytes": 47527904,
"heapUsedBytes": 161869240,
"domNodes": -296,
"jsHeapTotalBytes": 46018560,
"scriptDurationMs": 7720.355,
"eventListeners": -130,
"totalBlockingTimeMs": 943,
"frameDurationMs": 32.34548286604361,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11086.62099999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10224.838,
"heapDeltaBytes": 33414396,
"heapUsedBytes": 143227044,
"domNodes": -277,
"jsHeapTotalBytes": 38076416,
"scriptDurationMs": 8183.496,
"eventListeners": -130,
"totalBlockingTimeMs": 1198,
"frameDurationMs": 31.044537815126045,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 223.33399999999415,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.371,
"layouts": 11,
"layoutDurationMs": 3.125,
"taskDurationMs": 188.87699999999998,
"heapDeltaBytes": 15463352,
"heapUsedBytes": 120908036,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 7.989,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090843,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 235.65300000001344,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.549,
"layouts": 10,
"layoutDurationMs": 3.733,
"taskDurationMs": 182.619,
"heapDeltaBytes": 13172808,
"heapUsedBytes": 121367908,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 10.571,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2054.642000000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.796,
"layouts": 8,
"layoutDurationMs": 2.615,
"taskDurationMs": 662.3919999999998,
"heapDeltaBytes": -428056,
"heapUsedBytes": 109838092,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 31.356,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.5780000000586,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0089999999999995,
"layouts": 8,
"layoutDurationMs": 2.726,
"taskDurationMs": 612.165,
"heapDeltaBytes": -293464,
"heapUsedBytes": 109748744,
"domNodes": -296,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 40.13399999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2620.4179999999724,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.296000000000001,
"layouts": 7,
"layoutDurationMs": 1.562,
"taskDurationMs": 1755.46,
"heapDeltaBytes": -34824872,
"heapUsedBytes": 88801508,
"domNodes": -302,
"jsHeapTotalBytes": -81920,
"scriptDurationMs": 869.3580000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666455696202533,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2907.444000000055,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.233,
"layouts": 6,
"layoutDurationMs": 1.95,
"taskDurationMs": 1880.3180000000002,
"heapDeltaBytes": -12885320,
"heapUsedBytes": 107430508,
"domNodes": -297,
"jsHeapTotalBytes": -1523712,
"scriptDurationMs": 855.568,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76184971098266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3822.6119999999923,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.978,
"layouts": 64,
"layoutDurationMs": 10.854000000000001,
"taskDurationMs": 1760.3779999999997,
"heapDeltaBytes": 6836648,
"heapUsedBytes": 111994848,
"domNodes": 24,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 787.69,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.739035087719294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3586.0549999999876,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.574999999999998,
"layouts": 65,
"layoutDurationMs": 12.057,
"taskDurationMs": 1719.4270000000001,
"heapDeltaBytes": 6200248,
"heapUsedBytes": 109798868,
"domNodes": 24,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 828.453,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6660465116279,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2922.239999999988,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.893,
"layouts": 5,
"layoutDurationMs": 1.5129999999999997,
"taskDurationMs": 1889.563,
"heapDeltaBytes": 17446728,
"heapUsedBytes": 126033244,
"domNodes": 0,
"jsHeapTotalBytes": 8024064,
"scriptDurationMs": 917.4639999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858381502890172,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3260.3259999999636,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.952,
"layouts": 4,
"layoutDurationMs": 1.2850000000000001,
"taskDurationMs": 2246.636,
"heapDeltaBytes": -10337612,
"heapUsedBytes": 104293680,
"domNodes": -296,
"jsHeapTotalBytes": 1925120,
"scriptDurationMs": 1057.036,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.926562500000003,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2079.1130000000067,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.81,
"layouts": 5,
"layoutDurationMs": 1.568,
"taskDurationMs": 798.569,
"heapDeltaBytes": -21964928,
"heapUsedBytes": 101471860,
"domNodes": -296,
"jsHeapTotalBytes": -2965504,
"scriptDurationMs": 43.694,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.0909999999567,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.95,
"layouts": 7,
"layoutDurationMs": 2.7490000000000006,
"taskDurationMs": 802.899,
"heapDeltaBytes": -27977916,
"heapUsedBytes": 96144768,
"domNodes": -296,
"jsHeapTotalBytes": -962560,
"scriptDurationMs": 38.760000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 691.3749999999936,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.518000000000001,
"layouts": 9,
"layoutDurationMs": 2.6220000000000003,
"taskDurationMs": 493.113,
"heapDeltaBytes": -263556,
"heapUsedBytes": 90698612,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 146.201,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.0829999999269,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.202,
"layouts": 9,
"layoutDurationMs": 3.084,
"taskDurationMs": 429.87399999999997,
"heapDeltaBytes": -1150112,
"heapUsedBytes": 89969124,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 153.599,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.8820000000242,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.766,
"layouts": 8,
"layoutDurationMs": 2.6499999999999995,
"taskDurationMs": 424.69800000000004,
"heapDeltaBytes": 5727864,
"heapUsedBytes": 96978592,
"domNodes": -218,
"jsHeapTotalBytes": 3473408,
"scriptDurationMs": 8.635,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2055.904000000055,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.49,
"layouts": 9,
"layoutDurationMs": 3.044,
"taskDurationMs": 546.7059999999999,
"heapDeltaBytes": 10453812,
"heapUsedBytes": 102386160,
"domNodes": -199,
"jsHeapTotalBytes": 65536,
"scriptDurationMs": 13.876000000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.1979999999887,
"styleRecalcs": 79,
"styleRecalcDurationMs": 12.874,
"layouts": 8,
"layoutDurationMs": 2.1460000000000004,
"taskDurationMs": 875.539,
"heapDeltaBytes": 2797228,
"heapUsedBytes": 93248100,
"domNodes": -190,
"jsHeapTotalBytes": 1638400,
"scriptDurationMs": 104.574,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1853.9489999999432,
"styleRecalcs": 56,
"styleRecalcDurationMs": 13.55,
"layouts": 7,
"layoutDurationMs": 2.191,
"taskDurationMs": 1036.073,
"heapDeltaBytes": -3633504,
"heapUsedBytes": 87846784,
"domNodes": -210,
"jsHeapTotalBytes": 1900544,
"scriptDurationMs": 119.803,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1548.2150000000274,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.934,
"layouts": 5,
"layoutDurationMs": 24.183000000000003,
"taskDurationMs": 1034.5489999999998,
"heapDeltaBytes": 35398340,
"heapUsedBytes": 137153384,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 39.14499999999999,
"eventListeners": 3244,
"totalBlockingTimeMs": 229,
"frameDurationMs": 20.9445945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8255.675999999994,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.076999999999998,
"layouts": 8,
"layoutDurationMs": 2.012,
"taskDurationMs": 5283.9929999999995,
"heapDeltaBytes": -19831344,
"heapUsedBytes": 90039612,
"domNodes": -296,
"jsHeapTotalBytes": -458752,
"scriptDurationMs": 2703.449,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10629.386000000068,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.046999999999997,
"layouts": 7,
"layoutDurationMs": 2.1809999999999996,
"taskDurationMs": 6524.888,
"heapDeltaBytes": -11289060,
"heapUsedBytes": 113096200,
"domNodes": -296,
"jsHeapTotalBytes": -675840,
"scriptDurationMs": 2894.4260000000004,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69229559748428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16633.88500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15778.314,
"heapDeltaBytes": -29517112,
"heapUsedBytes": 299518812,
"domNodes": -3344,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 258.575,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.201745200698078,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 22967.120000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22452.935999999998,
"heapDeltaBytes": -23604160,
"heapUsedBytes": 300427820,
"domNodes": -3344,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 323.609,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.12062937062937,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 28476.53200000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.883000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28105.902000000002,
"heapDeltaBytes": -29685040,
"heapUsedBytes": 289860860,
"domNodes": -3344,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 934.7909999999999,
"eventListeners": -654,
"totalBlockingTimeMs": 32,
"frameDurationMs": 53.537969924812025,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28327.92299999994,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.219000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27979.407,
"heapDeltaBytes": -28680396,
"heapUsedBytes": 276533724,
"domNodes": -3344,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 934.526,
"eventListeners": -651,
"totalBlockingTimeMs": 31,
"frameDurationMs": 52.242619926199254,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8356.475999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.03099999999999,
"layouts": 20,
"layoutDurationMs": 27.737999999999985,
"taskDurationMs": 8243.306,
"heapDeltaBytes": -39300772,
"heapUsedBytes": 266932060,
"domNodes": -3344,
"jsHeapTotalBytes": 8114176,
"scriptDurationMs": 151.262,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.47944444444444,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8313.628999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.22599999999997,
"layouts": 20,
"layoutDurationMs": 30.92700000000001,
"taskDurationMs": 8185.587999999999,
"heapDeltaBytes": -10533524,
"heapUsedBytes": 299095340,
"domNodes": -3348,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 121.06,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.07109826589595,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8215.47800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7766.817,
"heapDeltaBytes": 23312368,
"heapUsedBytes": 285693036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.08799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.94693877551021,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8238.560000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7778.848999999999,
"heapDeltaBytes": -4097556,
"heapUsedBytes": 299146612,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.77700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.195205479452056,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 128.1780000000481,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.999,
"layouts": 8,
"layoutDurationMs": 4.978,
"taskDurationMs": 102.82799999999999,
"heapDeltaBytes": 4986488,
"heapUsedBytes": 95786648,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.041,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 487.23599999993894,
"styleRecalcs": 19,
"styleRecalcDurationMs": 10.798000000000002,
"layouts": 10,
"layoutDurationMs": 4.298,
"taskDurationMs": 133.17200000000003,
"heapDeltaBytes": 7024504,
"heapUsedBytes": 97352448,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.963000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 490.80900000001293,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.637,
"layouts": 76,
"layoutDurationMs": 16.521,
"taskDurationMs": 442.563,
"heapDeltaBytes": -14371724,
"heapUsedBytes": 79858348,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 208.204,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 440.3629999999339,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.618,
"layouts": 76,
"layoutDurationMs": 14.8,
"taskDurationMs": 399.635,
"heapDeltaBytes": 11717868,
"heapUsedBytes": 81268492,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 189.78400000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 562.4869999999191,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.821,
"layouts": 76,
"layoutDurationMs": 14.897,
"taskDurationMs": 524.915,
"heapDeltaBytes": 803676,
"heapUsedBytes": 118043184,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 211.196,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 499.492000000032,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.186,
"layouts": 76,
"layoutDurationMs": 13.299,
"taskDurationMs": 463.588,
"heapDeltaBytes": -17380,
"heapUsedBytes": 117265924,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 182.12,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E CoverageLine coverage: 59.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2984 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c6d2dea681075bbbcb18714c01dc47344f6cf868
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (136)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22455 +/- ##
==========================================
Coverage 84.04% 84.04%
==========================================
Files 3175 3174 -1
Lines 166036 166035 -1
Branches 39605 39612 +7
==========================================
+ Hits 139540 139545 +5
+ Misses 26104 26098 -6
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #22451 to
core/1.58Automatically created by backport workflow.