Repository navigation
fix: tag agent audio failures with the agent surface - #22460
Conversation
Let the caller name the report surface and pass agent from ReplyAudioCard. Pin the waveform resume and failed-source reload with tests that depend on them.
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 10 seconds for your next included review. View limit details
|
📦 Bundle: 12 MB gzip 🔴 +16 BDetailsSummary
Category Glance App Entry Points — 6.71 kB (baseline 6.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.61 MB (baseline 2.61 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 878 kB (baseline 878 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 33 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 18 unchanged Editors & Dialogs — 503 kB (baseline 503 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 17 unchanged UI Components — 352 kB (baseline 352 kB) • ⚪ 0 BReusable component library chunks Status: 31 unchanged Data & Services — 1.93 MB (baseline 1.93 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 1 added / 1 removed / 41 unchanged Utilities & Hooks — 2.46 MB (baseline 2.46 MB) • 🔴 +10 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed / 82 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.9 MB (baseline 34.9 MB) • 🔴 +21 BBundles that do not match a named category
Status: 6 added / 6 removed / 746 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-31T03:59:45.187Z",
"gitSha": "f8365380786250febb901331425b3cf3a201aca9",
"branch": "fix/wave-audio-play-followups",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.061999999991,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.666,
"layouts": 10,
"layoutDurationMs": 2.4250000000000003,
"taskDurationMs": 438.994,
"heapDeltaBytes": 4655700,
"heapUsedBytes": 63990044,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 8.59,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2035.4690000000346,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9830000000000005,
"layouts": 10,
"layoutDurationMs": 2.646,
"taskDurationMs": 505.193,
"heapDeltaBytes": 12661476,
"heapUsedBytes": 73648924,
"domNodes": -178,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.736999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.8760000000173,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.322999999999999,
"layouts": 9,
"layoutDurationMs": 2.085,
"taskDurationMs": 700.491,
"heapDeltaBytes": 6565072,
"heapUsedBytes": 83154372,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 117.177,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.5670000000082,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.579999999999998,
"layouts": 10,
"layoutDurationMs": 2.3430000000000004,
"taskDurationMs": 803.288,
"heapDeltaBytes": -5049196,
"heapUsedBytes": 57365504,
"domNodes": -178,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 133.95200000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.2060000000183,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.372,
"layouts": 11,
"layoutDurationMs": 2.5039999999999996,
"taskDurationMs": 333.747,
"heapDeltaBytes": 8086780,
"heapUsedBytes": 85326684,
"domNodes": 57,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 10.239999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.7000000000216,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.014,
"layouts": 12,
"layoutDurationMs": 2.551,
"taskDurationMs": 331.71099999999996,
"heapDeltaBytes": 1858412,
"heapUsedBytes": 63442288,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.714999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 544.7169999999915,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.7390000000000003,
"layouts": 10,
"layoutDurationMs": 2.3739999999999997,
"taskDurationMs": 364.884,
"heapDeltaBytes": -12890332,
"heapUsedBytes": 59847776,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 137.436,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669696969696968,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 548.4519999999975,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.545,
"layouts": 9,
"layoutDurationMs": 2.023,
"taskDurationMs": 417.74499999999995,
"heapDeltaBytes": -13990764,
"heapUsedBytes": 62841232,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 134.679,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1034.9560000000224,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.3949999999999,
"heapDeltaBytes": -3892464,
"heapUsedBytes": 78012504,
"domNodes": -208,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 49.357,
"eventListeners": -106,
"totalBlockingTimeMs": 370,
"frameDurationMs": 28.70555555555556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1067.1370000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.612,
"heapDeltaBytes": -5743916,
"heapUsedBytes": 77808324,
"domNodes": -208,
"jsHeapTotalBytes": 16261120,
"scriptDurationMs": 47.94800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 397,
"frameDurationMs": 29.627777777777776,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 798.5480000000109,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.38799999999986,
"heapDeltaBytes": -2439784,
"heapUsedBytes": 73406072,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.433,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 23.529411764705884,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 816.7700000000195,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.11099999999993,
"heapDeltaBytes": -21523608,
"heapUsedBytes": 72115256,
"domNodes": -208,
"jsHeapTotalBytes": 4849664,
"scriptDurationMs": 131.035,
"eventListeners": -106,
"totalBlockingTimeMs": 166,
"frameDurationMs": 23.33142857142858,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7313.164000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7850000000000001,
"layouts": 3,
"layoutDurationMs": 0.6359999999999999,
"taskDurationMs": 6517.747,
"heapDeltaBytes": 50933668,
"heapUsedBytes": 127457148,
"domNodes": -274,
"jsHeapTotalBytes": 57012224,
"scriptDurationMs": 4973.795,
"eventListeners": -68,
"totalBlockingTimeMs": 62,
"frameDurationMs": 24.22649006622516,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7129.467999999974,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6809999999999993,
"layouts": 3,
"layoutDurationMs": 0.6350000000000001,
"taskDurationMs": 6408.018,
"heapDeltaBytes": 72304988,
"heapUsedBytes": 148854020,
"domNodes": -274,
"jsHeapTotalBytes": 59371520,
"scriptDurationMs": 4922.956,
"eventListeners": -68,
"totalBlockingTimeMs": 30,
"frameDurationMs": 24.51237113402062,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7173.642000000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.209,
"layouts": 1,
"layoutDurationMs": 0.18499999999999983,
"taskDurationMs": 6475.982,
"heapDeltaBytes": 56525772,
"heapUsedBytes": 138511572,
"domNodes": -274,
"jsHeapTotalBytes": 60682240,
"scriptDurationMs": 5016.059,
"eventListeners": -68,
"totalBlockingTimeMs": 100,
"frameDurationMs": 24.88298611111111,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6927.775999999994,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.601,
"layouts": 2,
"layoutDurationMs": 0.5990000000000001,
"taskDurationMs": 6247.028,
"heapDeltaBytes": 66742384,
"heapUsedBytes": 140909596,
"domNodes": -274,
"jsHeapTotalBytes": 56225792,
"scriptDurationMs": 4746.803,
"eventListeners": -68,
"totalBlockingTimeMs": 29,
"frameDurationMs": 24.01527777777778,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 178.93000000000825,
"styleRecalcs": 22,
"styleRecalcDurationMs": 10.560999999999998,
"layouts": 11,
"layoutDurationMs": 2.5950000000000006,
"taskDurationMs": 136.92200000000003,
"heapDeltaBytes": -5683696,
"heapUsedBytes": 72500428,
"domNodes": 936,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6.666,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.36666666666669,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 198.7060000000156,
"styleRecalcs": 24,
"styleRecalcDurationMs": 10.627,
"layouts": 12,
"layoutDurationMs": 2.9240000000000004,
"taskDurationMs": 179.927,
"heapDeltaBytes": -6845892,
"heapUsedBytes": 68137672,
"domNodes": -2325,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.357,
"eventListeners": -573,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2025.4879999999957,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.302,
"layouts": 10,
"layoutDurationMs": 2.229,
"taskDurationMs": 550.5720000000001,
"heapDeltaBytes": -26412456,
"heapUsedBytes": 63342348,
"domNodes": -274,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 29.879999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2024.4299999999953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2319999999999998,
"layouts": 8,
"layoutDurationMs": 1.946,
"taskDurationMs": 559.4699999999999,
"heapDeltaBytes": -28799260,
"heapUsedBytes": 61278064,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 33.251,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836065,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2388.7059999999847,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.658,
"layouts": 8,
"layoutDurationMs": 1.9130000000000003,
"taskDurationMs": 1378.037,
"heapDeltaBytes": -12017488,
"heapUsedBytes": 78220992,
"domNodes": -274,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 657.96,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666433566433565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2252.5190000000066,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.229999999999999,
"layouts": 8,
"layoutDurationMs": 1.644,
"taskDurationMs": 1357.162,
"heapDeltaBytes": -4457356,
"heapUsedBytes": 86560524,
"domNodes": -274,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 637.617,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665185185185184,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3573.042999999984,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.943999999999997,
"layouts": 68,
"layoutDurationMs": 10.626999999999999,
"taskDurationMs": 1524.8319999999999,
"heapDeltaBytes": -21962896,
"heapUsedBytes": 69968752,
"domNodes": -250,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 653.943,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3821.343000000013,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.961,
"layouts": 64,
"layoutDurationMs": 10.138,
"taskDurationMs": 1602.2670000000003,
"heapDeltaBytes": -354768,
"heapUsedBytes": 80945156,
"domNodes": -250,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 690.761,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637554585153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2392.278000000005,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.0299999999999985,
"layouts": 6,
"layoutDurationMs": 1.343,
"taskDurationMs": 1607.942,
"heapDeltaBytes": -2721784,
"heapUsedBytes": 90944704,
"domNodes": 0,
"jsHeapTotalBytes": 5697536,
"scriptDurationMs": 804.591,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2399.3619999999964,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.313,
"layouts": 7,
"layoutDurationMs": 1.4220000000000002,
"taskDurationMs": 1612.8940000000002,
"heapDeltaBytes": -8707828,
"heapUsedBytes": 81015500,
"domNodes": 0,
"jsHeapTotalBytes": 5734400,
"scriptDurationMs": 794.081,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78251748251748,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2903.796,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7239999999999998,
"layouts": 8,
"layoutDurationMs": 1.536,
"taskDurationMs": 591.5889999999999,
"heapDeltaBytes": 2098212,
"heapUsedBytes": 86619960,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 284.169,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022985,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2921.701999999982,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6449999999999998,
"layouts": 8,
"layoutDurationMs": 1.4369999999999998,
"taskDurationMs": 638.0870000000001,
"heapDeltaBytes": -17194732,
"heapUsedBytes": 66792944,
"domNodes": -274,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 283.923,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2034.667000000013,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9680000000000002,
"layouts": 8,
"layoutDurationMs": 1.6909999999999998,
"taskDurationMs": 545.788,
"heapDeltaBytes": -4602500,
"heapUsedBytes": 87326464,
"domNodes": -274,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 29.475,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.132000000047,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7220000000000004,
"layouts": 8,
"layoutDurationMs": 1.618,
"taskDurationMs": 538.6720000000001,
"heapDeltaBytes": -25017876,
"heapUsedBytes": 67262140,
"domNodes": -274,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 29.468999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2725.1119999999955,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.612,
"layouts": 8,
"layoutDurationMs": 1.6400000000000001,
"taskDurationMs": 447.8810000000001,
"heapDeltaBytes": 6556764,
"heapUsedBytes": 90114260,
"domNodes": 19,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 146.84799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2725.98899999997,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.100999999999999,
"layouts": 7,
"layoutDurationMs": 1.305,
"taskDurationMs": 474.39,
"heapDeltaBytes": -6559292,
"heapUsedBytes": 70525472,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 143.191,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665243902439023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3032.2109999999893,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8830000000000002,
"layouts": 8,
"layoutDurationMs": 1.6260000000000003,
"taskDurationMs": 716.0139999999999,
"heapDeltaBytes": 8691080,
"heapUsedBytes": 100308176,
"domNodes": 0,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 287.406,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3074.9119999999834,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9249999999999996,
"layouts": 7,
"layoutDurationMs": 1.5739999999999998,
"taskDurationMs": 720.4140000000001,
"heapDeltaBytes": -9031876,
"heapUsedBytes": 84937424,
"domNodes": 0,
"jsHeapTotalBytes": 7114752,
"scriptDurationMs": 281.458,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.679000000001,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.6339999999999995,
"layouts": 9,
"layoutDurationMs": 2.1950000000000003,
"taskDurationMs": 358.66900000000004,
"heapDeltaBytes": 24327792,
"heapUsedBytes": 86366732,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 124.023,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.4930000000077,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.151,
"layouts": 9,
"layoutDurationMs": 1.9950000000000003,
"taskDurationMs": 347.11500000000007,
"heapDeltaBytes": 1352100,
"heapUsedBytes": 63495736,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 116.76799999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.766999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0170000000000003,
"layouts": 10,
"layoutDurationMs": 2.165,
"taskDurationMs": 452.37999999999994,
"heapDeltaBytes": -7488816,
"heapUsedBytes": 53805584,
"domNodes": -200,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.196999999999998,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.1759999999827,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.079,
"layouts": 10,
"layoutDurationMs": 2.7089999999999996,
"taskDurationMs": 484.81000000000006,
"heapDeltaBytes": 4490344,
"heapUsedBytes": 65764708,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.870000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1686.329999999998,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.508999999999999,
"layouts": 7,
"layoutDurationMs": 1.5959999999999999,
"taskDurationMs": 691.603,
"heapDeltaBytes": 23145172,
"heapUsedBytes": 85244528,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 91.93499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.9120000000075,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.128,
"layouts": 9,
"layoutDurationMs": 2.4400000000000004,
"taskDurationMs": 749.899,
"heapDeltaBytes": -7733524,
"heapUsedBytes": 56526880,
"domNodes": -185,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 92.57300000000001,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.4390000000121,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.73,
"layouts": 5,
"layoutDurationMs": 10.3,
"taskDurationMs": 812.9619999999998,
"heapDeltaBytes": 39283596,
"heapUsedBytes": 117367944,
"domNodes": 15949,
"jsHeapTotalBytes": 6950912,
"scriptDurationMs": 24.314999999999998,
"eventListeners": 3246,
"totalBlockingTimeMs": 107,
"frameDurationMs": 18.780281690140853,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9441.738000000043,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.467999999999996,
"layouts": 9,
"layoutDurationMs": 2.072,
"taskDurationMs": 4851.5960000000005,
"heapDeltaBytes": -6226400,
"heapUsedBytes": 82287792,
"domNodes": -274,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 2202.344,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66596119929453,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10523.954000000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.138,
"layouts": 9,
"layoutDurationMs": 2.201,
"taskDurationMs": 5110.099,
"heapDeltaBytes": -8722032,
"heapUsedBytes": 74575132,
"domNodes": -274,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2275.6240000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592709984152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 20209.389999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19430.064000000002,
"heapDeltaBytes": -42133460,
"heapUsedBytes": 260953556,
"domNodes": -3388,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 264.10499999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.2191637630662,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 20331.59999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19385.365,
"heapDeltaBytes": -39364564,
"heapUsedBytes": 259675236,
"domNodes": -3388,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 274.52000000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.922968197879854,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 23838.46399999999,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.60199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23494.861999999997,
"heapDeltaBytes": -12894056,
"heapUsedBytes": 266216920,
"domNodes": -3388,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 741.6819999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 45.137121212121215,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23343.20600000001,
"styleRecalcs": 180,
"styleRecalcDurationMs": 17.386,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23032.146,
"heapDeltaBytes": 1442796,
"heapUsedBytes": 289532872,
"domNodes": -3388,
"jsHeapTotalBytes": 15380480,
"scriptDurationMs": 707.456,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.054905660377365,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7146.055999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.881000000000014,
"layouts": 20,
"layoutDurationMs": 25.135999999999992,
"taskDurationMs": 6990.068,
"heapDeltaBytes": -4419764,
"heapUsedBytes": 274998124,
"domNodes": -3388,
"jsHeapTotalBytes": 19382272,
"scriptDurationMs": 103.165,
"eventListeners": -653,
"totalBlockingTimeMs": 7,
"frameDurationMs": 41.616374269005846,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7053.508999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.842000000000006,
"layouts": 20,
"layoutDurationMs": 21.28100000000001,
"taskDurationMs": 6969.436,
"heapDeltaBytes": -22148048,
"heapUsedBytes": 263255592,
"domNodes": -3388,
"jsHeapTotalBytes": 24363008,
"scriptDurationMs": 100.45800000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 28,
"frameDurationMs": 43.351533742331284,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9647.790999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9503.777999999998,
"heapDeltaBytes": 40869904,
"heapUsedBytes": 289212380,
"domNodes": 0,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 127.86199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.505208333333336,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10166.137999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9679.650000000001,
"heapDeltaBytes": -7643748,
"heapUsedBytes": 256078884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.29700000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.7968309859155,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "workflow-execution",
"durationMs": 472.11700000002566,
"styleRecalcs": 20,
"styleRecalcDurationMs": 9.866,
"layouts": 13,
"layoutDurationMs": 3.9370000000000003,
"taskDurationMs": 118.31899999999999,
"heapDeltaBytes": -9643392,
"heapUsedBytes": 60097864,
"domNodes": 138,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.165000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 94.35499999995045,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.812,
"layouts": 7,
"layoutDurationMs": 1.844,
"taskDurationMs": 63.56199999999999,
"heapDeltaBytes": 4775456,
"heapUsedBytes": 66589700,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.485000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 275.5380000000969,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.601,
"layouts": 76,
"layoutDurationMs": 10.999,
"taskDurationMs": 237.204,
"heapDeltaBytes": -6017348,
"heapUsedBytes": 37721356,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 107.67399999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670588235294098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 277.76300000004994,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.558,
"layouts": 76,
"layoutDurationMs": 10.749,
"taskDurationMs": 231.214,
"heapDeltaBytes": -6182040,
"heapUsedBytes": 36723264,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 106.56599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 327.09799999997813,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.514,
"layouts": 76,
"layoutDurationMs": 12.381,
"taskDurationMs": 290.86500000000007,
"heapDeltaBytes": -2093948,
"heapUsedBytes": 89029444,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 103.651,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 329.5630000000074,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.439,
"layouts": 76,
"layoutDurationMs": 11.029,
"taskDurationMs": 291.85,
"heapDeltaBytes": -2076084,
"heapUsedBytes": 89371628,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.02499999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 59.6% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3188 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fd947b072284fd7edb665d509fba73c5c7fe405d
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (303)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22460 +/- ##
==========================================
- Coverage 87.49% 87.39% -0.11%
==========================================
Files 2967 2859 -108
Lines 161263 157893 -3370
Branches 43154 39972 -3182
==========================================
- Hits 141096 137985 -3111
+ Misses 19244 19150 -94
+ Partials 923 758 -165
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 120 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed 728a901. Surface already includes agent, and ReplyAudioCard is the only agent caller of useWaveAudioPlayer. WaveAudioPlayer.vue keeps the assets default, which is correct for its queue/assets consumers.
Checked locally: vitest run src/composables/useWaveAudioPlayer.test.ts, 27 passed. Mutation checks: hard-coding surface: 'assets' fails "reports failures on the caller surface", and switching handleWaveformClick back to !playing.value fails "resumes from a waveform click right after a pause". Both new tests guard real behavior. LGTM.
|
|
|
|
A conflict resolved during the rebase collapsed the useWaveAudioPlayer call back to its pre-Comfy-Org#22460 form, dropping surface: 'agent'. useWaveAudioPlayer defaults the surface to 'assets', so agent reply audio failures were reported with the wrong surface tag. Only the import path is meant to change in this file. The playback failure test asserts the reported surface, so dropping the tag again fails it with surface: "assets" instead of "agent".
…rface (#22460) (#22600) Manual backport of #22460. The automatic backport hit a conflict because #22451's backport had not merged yet. One adaptation: this branch imports `reportError` and its `Surface` type from `@/platform/telemetry/reportError`, the path the release trains use (same as #22451's backport). Behaviour is unchanged. Local: useWaveAudioPlayer, WaveAudioPlayer and agent message tests pass; pre-commit typecheck clean.
…face (#22460) (#22599) Manual backport of #22460. The automatic backport hit a conflict because #22451's backport had not merged yet. One adaptation: this branch imports `reportError` and its `Surface` type from `@/platform/telemetry/reportError`, the path the release trains use (same as #22451's backport). Behaviour is unchanged. Local: useWaveAudioPlayer, WaveAudioPlayer and agent message tests pass; pre-commit typecheck clean.
…rface (#22460) (#22598) Manual backport of #22460. The automatic backport hit a conflict because #22451's backport had not merged yet. One adaptation: this branch imports `reportError` and its `Surface` type from `@/platform/telemetry/reportError`, the path the release trains use (same as #22451's backport). Behaviour is unchanged. Local: useWaveAudioPlayer, WaveAudioPlayer and agent message tests pass; pre-commit typecheck clean.
…face (#22460) (#22597) Manual backport of #22460. The automatic backport hit a conflict because #22451's backport had not merged yet. One adaptation: this branch imports `reportError` and its `Surface` type from `@/platform/telemetry/reportError`, the path the release trains use (same as #22451's backport). Behaviour is unchanged. Local: useWaveAudioPlayer, WaveAudioPlayer and agent message tests pass; pre-commit typecheck clean.
Summary
Follow-up to #22451, from its review.
useWaveAudioPlayertakes asurfaceoption (defaultassets), andReplyAudioCardpassesagent, so agent reply failures are tagged correctly in telemetry.playing.play()rejects untilload()clears the error.