Skip to content

[backport cloud/1.58] fix(agent): hold human edits made while the doc socket is down (PM-2392) - #22424

Merged
comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-22237-to-cloud-1.58
Nov 1, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-22237-to-cloud-1.58

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #22237 (a hand edit made while the Agent is disconnected is held and delivered on reconnect, https://linear.app/comfyorg/issue/PM-2392). The auto-backport hit a conflict in opSender, where this branch's settleUnbound has no cause argument. Resolved by keeping the hold, and left out the report-row test this branch does not have. opSender and follower unit tests pass.

…92) (#22237)

A widget edit a user makes while the Agent process is down is now
delivered when it comes back, instead of being thrown away 2.5 seconds
into the outage and then overwritten by the Agent's older document.

Fixes
[PM-2392](https://linear.app/comfyorg/issue/PM-2392/agent-reconnect-overwrites-load-image-edits-saved-during-the-outage).
QA reproduced it 2/2 on Windows Desktop 1.1.8 with local Agent rc5 and
frontend 1.59.0.dev2: kill the Agent process, change two Load Image
widgets by hand, save, and on reconnect `doc_subscribe` plus a full
`doc_update` puts the old filenames back — in the live widget, in the
next save, and in the Agent's next answer.
[#21268](#21268)
guards the outbound draft and does not cover this direction;
`canvasMayBeStale` stayed `false` throughout.

`opSender.transmit` gave a batch five 500 ms retries and then settled it
`undeliverable`. That did two separate kinds of damage:

1. **The edit was lost.** It never reached the document, so nothing
downstream of the document ever saw it.
2. **Its `LocalWidgetWrites` hold was lifted.** `settleHumanOps` calls
`projection.settleLocalWrites` for every outcome, including
`undeliverable`, and the hold is the only thing stopping a remote frame
from writing a register the user has an edit in flight on. With it gone,
the reconnect's catch-up frame was free to project the pre-outage value
back over the register.

The second is why the symptom is a visible revert rather than a silently
unsynced edit.

Transport retry exhaustion is a **hold**, not a terminal discard — the
2026-09-28 ruling that an offline edit is owed delivery. The batch stays
at the head of the sender's FIFO with its original `op_id`, `actor` and
stamp, and `OpSender.retryTransport()` sends it when the socket returns.
Because it never settles, the register's hold survives with it, so the
catch-up frame cannot overwrite the edit in the window before the resend
lands.

The resend is driven from `doc_subscribed{ok:true}`, not from the
socket-live edge: the host answers a subscribe before it reads the ops
frame, so the catch-up `doc_update` is already on the wire ahead of the
resend and ordering stays deterministic.

Nothing else changes shape. A batch whose doc is unbound still settles
`undeliverable` through `abortIfUnbound`, `doc_reset` still aborts
everything, `detach` still drains, and `pendingOps()` still reports the
held batch as unsynced. **No reconciliation pass and no second graph
mutation path**: the retained ops are the human's own intent, minted at
the command site and replayed through the one wire path.

- **Black-box harness, red on parent and green here**:
`browser_tests/tests/agent/agentOfflineEditSurvivesReconnect.spec.ts`
runs the reported sequence — the Agent builds two nodes, its process
goes down, the user retypes both widgets by hand, the Agent comes back
and answers the resubscribe with its whole document, then the workflow
is saved, the page reloaded, the workflow reopened from the server, and
one more Agent turn sent. On the parent it fails with the document still
holding `agent prompt one`; here all four readers hold the user's value.
- **Harness addition**: `AgentFollowerHostSocket.beginAgentOutage()` /
`endAgentOutage()` model a down Agent process by refusing reconnects, so
an outage can outlast the sender's retry budget. `disconnect()` only
models a blip the page recovers from inside its first backoff step. The
outage length is counted in observed refused reconnects rather than a
sleep.
- **Unit**: a new `useAgentCrdtFollower` case pins the whole chain — the
edit is held, `settleLocalWrites` is *not* called, and the resend
carries the same `op_id` and `base_version`. It fails on the parent
exactly on the `settleLocalWrites` assertion. Two new `opSender` cases
cover the hold and the unbound-while-held path; the
`transport_exhausted` report row is now the `detached` one, since a down
transport no longer settles on its own.
- 4,542 Agent/CRDT unit tests pass; app and browser typechecks pass;
`agentHumanEditResentAcrossReconnect`, `agentStaleCanvasDraft` and
`agentHumanRenameRetriesAfterTransportThrow` all still pass.

- The spec drives a `CLIPTextEncode.text` register rather than the
reported `LoadImage.image` one. The defect is a property of a
last-writer-wins widget register, not of a node class, and the Load
Image picker only offers a filename the backend can actually serve —
faking one would exercise the media picker rather than the reconnect.
- The harness host resumes its document across the outage rather than
re-minting it, so the spec's red is the lost edit and its effect on the
save, the reload and the next turn. The register-level overwrite that
the lifted hold allows is pinned by the unit test instead.
- A held batch is retained until the socket returns, the doc unbinds, or
the page unmounts. A long outage with continuous editing therefore
accumulates batches rather than dropping one every 2.5 s; they are
reported as unsynced throughout and drained on unmount.

(cherry picked from commit 7b38703)
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) labels Oct 30, 2026
@christian-byrne
christian-byrne requested review from a team as code owners October 30, 2026 22:58
@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 104.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 36.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 319ms TBT · 97.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 47.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 97ms TBT · 101.1 MB heap
extension-clean-combined-draw: · 41.9 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 53ms TBT · 127.7 MB heap
extension-rgthree-prototype-draw: · 45.6 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 71ms TBT · 111.2 MB heap
large-combo-open: · 47.3 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 112.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 102.5 MB heap
large-graph-zoom: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 122.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.2 MB heap
subgraph-transition-enter: · 53.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 110ms TBT · 112.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.3 MB heap
vue-large-graph-idle: · 34.1 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 262.8 MB heap
vue-large-graph-pan: · 35.9 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 18ms TBT · 275.4 MB heap
vue-node-resize-workload: · 28.7 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 0ms TBT · 275.4 MB heap
vue-zoom-out-idle: · 40.2 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 280.8 MB heap
workflow-execution: · 59.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.1 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.1 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 113.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 11
canvas-idle: task duration 440ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 79.9 MB
canvas-idle: DOM nodes -191
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 816ms
canvas-mouse-sweep: script duration 121ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 76.9 MB
canvas-mouse-sweep: DOM nodes -190
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 19
canvas-zoom-sweep: task duration 328ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 104.6 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 374ms
dom-widget-clipping: script duration 122ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 88.1 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 27ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 639ms
dom-widget-order-dense-n200-w200-i120: script duration 42ms
dom-widget-order-dense-n200-w200-i120: TBT 319ms
dom-widget-order-dense-n200-w200-i120: heap used 97.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -231
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 330ms
dom-widget-order-sparse-n1000-w20-i120: script duration 106ms
dom-widget-order-sparse-n1000-w20-i120: TBT 97ms
dom-widget-order-sparse-n1000-w20-i120: heap used 101.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes -106
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 24ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 2
extension-clean-combined-draw: style recalc count 2
extension-clean-combined-draw: task duration 5890ms
extension-clean-combined-draw: script duration 4357ms
extension-clean-combined-draw: TBT 53ms
extension-clean-combined-draw: heap used 127.7 MB
extension-clean-combined-draw: DOM nodes -286
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 22ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 1ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 4
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 5609ms
extension-rgthree-prototype-draw: script duration 4306ms
extension-rgthree-prototype-draw: TBT 71ms
extension-rgthree-prototype-draw: heap used 111.2 MB
extension-rgthree-prototype-draw: DOM nodes -286
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 50ms
large-combo-open: layout duration 3ms
large-combo-open: style recalc duration 14ms
large-combo-open: layout count 12
large-combo-open: style recalc count 22
large-combo-open: task duration 119ms
large-combo-open: script duration 7ms
large-combo-open: TBT 0ms
large-combo-open: heap used 112.5 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 9
large-graph-idle: style recalc count 10
large-graph-idle: task duration 501ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 99.0 MB
large-graph-idle: DOM nodes -286
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 9
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1269ms
large-graph-pan: script duration 606ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 102.5 MB
large-graph-pan: DOM nodes -286
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 67
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1304ms
large-graph-zoom: script duration 578ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 96.4 MB
large-graph-zoom: DOM nodes -262
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 2ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 48
legacy-node-drag: task duration 1510ms
legacy-node-drag: script duration 714ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 122.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 8
minimap-idle: style recalc count 9
minimap-idle: task duration 526ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 88.6 MB
minimap-idle: DOM nodes -297
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 11
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 305ms
subgraph-dom-widget-clipping: script duration 103ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 99.1 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 444ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 82.4 MB
subgraph-idle: DOM nodes -220
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 11
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 668ms
subgraph-mouse-sweep: script duration 98ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 86.2 MB
subgraph-mouse-sweep: DOM nodes -106
subgraph-mouse-sweep: event listeners -84
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 20ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 869ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 110ms
subgraph-transition-enter: heap used 112.9 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4361ms
viewport-pan-sweep: script duration 2058ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 94.3 MB
viewport-pan-sweep: DOM nodes -291
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 29ms
vue-large-graph-idle: p95 frame time 58ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16176ms
vue-large-graph-idle: script duration 234ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 262.8 MB
vue-large-graph-idle: DOM nodes -3346
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 28ms
vue-large-graph-pan: p95 frame time 58ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 84
vue-large-graph-pan: task duration 15043ms
vue-large-graph-pan: script duration 666ms
vue-large-graph-pan: TBT 18ms
vue-large-graph-pan: heap used 275.4 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 35ms
vue-node-resize-workload: p95 frame time 75ms
vue-node-resize-workload: layout duration 29ms
vue-node-resize-workload: style recalc duration 52ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5852ms
vue-node-resize-workload: script duration 100ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 275.4 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 25ms
vue-zoom-out-idle: p95 frame time 42ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6890ms
vue-zoom-out-idle: script duration 96ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 280.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 6ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 13
workflow-execution: style recalc count 18
workflow-execution: task duration 124ms
workflow-execution: script duration 17ms
workflow-execution: TBT 0ms
workflow-execution: heap used 89.1 MB
workflow-execution: DOM nodes 111
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 13ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 239ms
agent-composer-empty-conversation-typing: script duration 107ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 95.1 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 12ms
agent-composer-long-conversation-typing: style recalc duration 1ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 252ms
agent-composer-long-conversation-typing: script duration 88ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 113.9 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-30T23:08:38.477Z",
  "gitSha": "6342eb52058111eaf4a8c021d809dda87306b773",
  "branch": "backport-22237-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.9840000000224,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.793,
      "layouts": 9,
      "layoutDurationMs": 2.4240000000000004,
      "taskDurationMs": 452.23500000000007,
      "heapDeltaBytes": -4697528,
      "heapUsedBytes": 84163844,
      "domNodes": -201,
      "jsHeapTotalBytes": -1339392,
      "scriptDurationMs": 11.583000000000002,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-idle",
      "durationMs": 2025.5780000000527,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.593,
      "layouts": 11,
      "layoutDurationMs": 3.226,
      "taskDurationMs": 427.62600000000003,
      "heapDeltaBytes": -12401136,
      "heapUsedBytes": 83340528,
      "domNodes": -180,
      "jsHeapTotalBytes": 4026368,
      "scriptDurationMs": 10.6,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1743.8149999999837,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 14.817,
      "layouts": 10,
      "layoutDurationMs": 2.8980000000000006,
      "taskDurationMs": 761.986,
      "heapDeltaBytes": -21824744,
      "heapUsedBytes": 80623808,
      "domNodes": -180,
      "jsHeapTotalBytes": -1740800,
      "scriptDurationMs": 129.81300000000002,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714287,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1978.7840000000188,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 13.493,
      "layouts": 10,
      "layoutDurationMs": 2.195,
      "taskDurationMs": 870.994,
      "heapDeltaBytes": -22200432,
      "heapUsedBytes": 80666792,
      "domNodes": -200,
      "jsHeapTotalBytes": -1740800,
      "scriptDurationMs": 111.386,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.655000000008,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 5.941000000000001,
      "layouts": 12,
      "layoutDurationMs": 3.645,
      "taskDurationMs": 365.19800000000004,
      "heapDeltaBytes": 21595360,
      "heapUsedBytes": 109396608,
      "domNodes": 47,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 16.169,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664423076923075,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.2640000000329,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.9719999999999995,
      "layouts": 11,
      "layoutDurationMs": 2.8319999999999994,
      "taskDurationMs": 290.409,
      "heapDeltaBytes": 21478380,
      "heapUsedBytes": 109863632,
      "domNodes": 47,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 12.435,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66504854368932,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 567.6529999999786,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.8729999999999998,
      "layouts": 9,
      "layoutDurationMs": 2.3229999999999995,
      "taskDurationMs": 383.43,
      "heapDeltaBytes": 1727048,
      "heapUsedBytes": 90588828,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 125.638,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 549.2189999999937,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.33,
      "layouts": 10,
      "layoutDurationMs": 3.0260000000000002,
      "taskDurationMs": 364.676,
      "heapDeltaBytes": 5209256,
      "heapUsedBytes": 94246256,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 118.435,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 964.1550000000052,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.3020000000001,
      "heapDeltaBytes": -5403076,
      "heapUsedBytes": 102204200,
      "domNodes": -230,
      "jsHeapTotalBytes": 6393856,
      "scriptDurationMs": 40.332,
      "eventListeners": -168,
      "totalBlockingTimeMs": 301,
      "frameDurationMs": 26.849999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1019.1059999999652,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 662.3129999999999,
      "heapDeltaBytes": -15205348,
      "heapUsedBytes": 102530832,
      "domNodes": -231,
      "jsHeapTotalBytes": 16064512,
      "scriptDurationMs": 43.70800000000001,
      "eventListeners": -168,
      "totalBlockingTimeMs": 336,
      "frameDurationMs": 27.478378378378373,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 717.5780000000032,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.8960000000001,
      "heapDeltaBytes": 24949280,
      "heapUsedBytes": 114656172,
      "domNodes": -211,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 107.91199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 98,
      "frameDurationMs": 21.076470588235306,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 713.7380000000348,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.36200000000025,
      "heapDeltaBytes": -3768088,
      "heapUsedBytes": 97336392,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 104.551,
      "eventListeners": 0,
      "totalBlockingTimeMs": 96,
      "frameDurationMs": 21.079411764705878,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6825.710999999984,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.2069999999999999,
      "layouts": 4,
      "layoutDurationMs": 1.0040000000000002,
      "taskDurationMs": 5993.518,
      "heapDeltaBytes": 23778856,
      "heapUsedBytes": 144970304,
      "domNodes": -276,
      "jsHeapTotalBytes": 24707072,
      "scriptDurationMs": 4471.571,
      "eventListeners": -130,
      "totalBlockingTimeMs": 45,
      "frameDurationMs": 23.1064406779661,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6477.435999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5786.346,
      "heapDeltaBytes": 1147388,
      "heapUsedBytes": 122859204,
      "domNodes": -296,
      "jsHeapTotalBytes": 15532032,
      "scriptDurationMs": 4242.091,
      "eventListeners": -130,
      "totalBlockingTimeMs": 61,
      "frameDurationMs": 24.65057034220532,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6789.596999999986,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.9980000000000007,
      "layouts": 3,
      "layoutDurationMs": 0.82,
      "taskDurationMs": 5811.717,
      "heapDeltaBytes": -7392488,
      "heapUsedBytes": 113053816,
      "domNodes": -276,
      "jsHeapTotalBytes": 2625536,
      "scriptDurationMs": 4450.579000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 70,
      "frameDurationMs": 22.07694805194805,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6405.2840000000515,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.3280000000000003,
      "layouts": 4,
      "layoutDurationMs": 1.0579999999999998,
      "taskDurationMs": 5407.260000000001,
      "heapDeltaBytes": -1664592,
      "heapUsedBytes": 120248072,
      "domNodes": -296,
      "jsHeapTotalBytes": 24707072,
      "scriptDurationMs": 4160.427000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 71,
      "frameDurationMs": 21.767687074829933,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-combo-open",
      "durationMs": 143.37299999999686,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 12.79,
      "layouts": 12,
      "layoutDurationMs": 3.057,
      "taskDurationMs": 107.06199999999998,
      "heapDeltaBytes": 15524872,
      "heapUsedBytes": 118099092,
      "domNodes": 917,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 6.321,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.41428571428566,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-combo-open",
      "durationMs": 167.64100000000326,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 14.506000000000002,
      "layouts": 11,
      "layoutDurationMs": 3.493,
      "taskDurationMs": 130.412,
      "heapDeltaBytes": 15471188,
      "heapUsedBytes": 117794200,
      "domNodes": 917,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.678000000000001,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.82499999999999,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.5089999999955,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.8080000000000007,
      "layouts": 8,
      "layoutDurationMs": 2.299000000000001,
      "taskDurationMs": 527.212,
      "heapDeltaBytes": 1877988,
      "heapUsedBytes": 109049320,
      "domNodes": -276,
      "jsHeapTotalBytes": -983040,
      "scriptDurationMs": 30.88,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.014000000032,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.882,
      "layouts": 9,
      "layoutDurationMs": 2.4080000000000004,
      "taskDurationMs": 474.59900000000005,
      "heapDeltaBytes": -21763336,
      "heapUsedBytes": 98532836,
      "domNodes": -296,
      "jsHeapTotalBytes": -3014656,
      "scriptDurationMs": 30.053,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2981.2949999999887,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.673000000000002,
      "layouts": 8,
      "layoutDurationMs": 2.2769999999999997,
      "taskDurationMs": 1389.6470000000002,
      "heapDeltaBytes": -4815724,
      "heapUsedBytes": 102960220,
      "domNodes": -296,
      "jsHeapTotalBytes": -679936,
      "scriptDurationMs": 636.2629999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665921787709497,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2152.990999999986,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.249000000000002,
      "layouts": 9,
      "layoutDurationMs": 2.2770000000000006,
      "taskDurationMs": 1147.583,
      "heapDeltaBytes": 4331844,
      "heapUsedBytes": 111930996,
      "domNodes": -276,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 575.503,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66692307692308,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3386.0629999999787,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 13.253999999999998,
      "layouts": 66,
      "layoutDurationMs": 12.977,
      "taskDurationMs": 1353.366,
      "heapDeltaBytes": -2253592,
      "heapUsedBytes": 105642424,
      "domNodes": -252,
      "jsHeapTotalBytes": -327680,
      "scriptDurationMs": 600.812,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.748514851485147,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3239.10699999999,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 12.333999999999998,
      "layouts": 67,
      "layoutDurationMs": 12.818,
      "taskDurationMs": 1254.0059999999999,
      "heapDeltaBytes": -7790848,
      "heapUsedBytes": 96446036,
      "domNodes": -272,
      "jsHeapTotalBytes": -65536,
      "scriptDurationMs": 555.787,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666494845360823,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3019.6470000000204,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.685,
      "layouts": 6,
      "layoutDurationMs": 1.6219999999999997,
      "taskDurationMs": 1584.455,
      "heapDeltaBytes": 17225232,
      "heapUsedBytes": 127694900,
      "domNodes": 0,
      "jsHeapTotalBytes": 6189056,
      "scriptDurationMs": 742.95,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384617,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2786.7030000000454,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 6.515999999999999,
      "layouts": 8,
      "layoutDurationMs": 1.813,
      "taskDurationMs": 1435.599,
      "heapDeltaBytes": 16323656,
      "heapUsedBytes": 128693172,
      "domNodes": 0,
      "jsHeapTotalBytes": 6451200,
      "scriptDurationMs": 685.631,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666467065868265,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.1569999999933,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.394,
      "layouts": 7,
      "layoutDurationMs": 1.9710000000000005,
      "taskDurationMs": 543.128,
      "heapDeltaBytes": -17387020,
      "heapUsedBytes": 91978956,
      "domNodes": -296,
      "jsHeapTotalBytes": -2740224,
      "scriptDurationMs": 31.682999999999996,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.3739999999998,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.1030000000000006,
      "layouts": 9,
      "layoutDurationMs": 2.7090000000000005,
      "taskDurationMs": 508.702,
      "heapDeltaBytes": -16510464,
      "heapUsedBytes": 93823004,
      "domNodes": -297,
      "jsHeapTotalBytes": -3526656,
      "scriptDurationMs": 32.04,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665573770491804,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 513.7520000000109,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.521999999999999,
      "layouts": 11,
      "layoutDurationMs": 3.098,
      "taskDurationMs": 326.73400000000004,
      "heapDeltaBytes": -4000056,
      "heapUsedBytes": 95309636,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 104.09400000000001,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 415.33000000003995,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.952000000000001,
      "layouts": 10,
      "layoutDurationMs": 2.775,
      "taskDurationMs": 284.00399999999996,
      "heapDeltaBytes": 22478844,
      "heapUsedBytes": 112436484,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 102.665,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667999999999992,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.779,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.5640000000000005,
      "layouts": 10,
      "layoutDurationMs": 2.8020000000000005,
      "taskDurationMs": 450.14200000000005,
      "heapDeltaBytes": -21534880,
      "heapUsedBytes": 83415156,
      "domNodes": -218,
      "jsHeapTotalBytes": -3051520,
      "scriptDurationMs": 11.089,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2043.4459999999603,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.596,
      "layouts": 9,
      "layoutDurationMs": 2.162000000000001,
      "taskDurationMs": 436.93899999999996,
      "heapDeltaBytes": -482620,
      "heapUsedBytes": 89464400,
      "domNodes": -222,
      "jsHeapTotalBytes": -2912256,
      "scriptDurationMs": 9.602999999999998,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1726.6520000000014,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 14.699,
      "layouts": 10,
      "layoutDurationMs": 2.6229999999999993,
      "taskDurationMs": 769.196,
      "heapDeltaBytes": -4783908,
      "heapUsedBytes": 84737692,
      "domNodes": -211,
      "jsHeapTotalBytes": -983040,
      "scriptDurationMs": 109.28299999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1695.918000000006,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 12.863000000000001,
      "layouts": 11,
      "layoutDurationMs": 2.4090000000000003,
      "taskDurationMs": 566.9550000000002,
      "heapDeltaBytes": -8893340,
      "heapUsedBytes": 96072588,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 86.892,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352944,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1334.6820000000434,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 19.844,
      "layouts": 5,
      "layoutDurationMs": 11.181,
      "taskDurationMs": 868.8789999999997,
      "heapDeltaBytes": 4762024,
      "heapUsedBytes": 118418692,
      "domNodes": 16030,
      "jsHeapTotalBytes": 17965056,
      "scriptDurationMs": 28.877999999999993,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 110,
      "frameDurationMs": 18.748611111111117,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8627.72799999999,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.623,
      "layouts": 8,
      "layoutDurationMs": 2.2210000000000005,
      "taskDurationMs": 4281.885,
      "heapDeltaBytes": 6070592,
      "heapUsedBytes": 108238812,
      "domNodes": -286,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 2119.655,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66602316602317,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9285.905000000013,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.491,
      "layouts": 9,
      "layoutDurationMs": 2.583,
      "taskDurationMs": 4440.808,
      "heapDeltaBytes": -31718000,
      "heapUsedBytes": 89586072,
      "domNodes": -296,
      "jsHeapTotalBytes": 655360,
      "scriptDurationMs": 1996.2359999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665888689407538,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17375.293999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16763.632999999998,
      "heapDeltaBytes": -31254140,
      "heapUsedBytes": 270315084,
      "domNodes": -3344,
      "jsHeapTotalBytes": 17289216,
      "scriptDurationMs": 248.048,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.044982698961945,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16285.591000000068,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15587.990999999998,
      "heapDeltaBytes": -25340632,
      "heapUsedBytes": 280802612,
      "domNodes": -3348,
      "jsHeapTotalBytes": 25939968,
      "scriptDurationMs": 220.526,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 28.61616871704745,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16432.266000000025,
      "styleRecalcs": 95,
      "styleRecalcDurationMs": 17.376,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15969.193,
      "heapDeltaBytes": -28084480,
      "heapUsedBytes": 291981204,
      "domNodes": -3344,
      "jsHeapTotalBytes": 20434944,
      "scriptDurationMs": 708.865,
      "eventListeners": -651,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 29.60846846846847,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14823.787000000038,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 11.825000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14117.562999999998,
      "heapDeltaBytes": -19878108,
      "heapUsedBytes": 285556516,
      "domNodes": -3344,
      "jsHeapTotalBytes": 22007808,
      "scriptDurationMs": 624.0759999999999,
      "eventListeners": -651,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 26.13068783068783,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6320.717000000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 44.30599999999998,
      "layouts": 20,
      "layoutDurationMs": 25.44600000000001,
      "taskDurationMs": 6232.179,
      "heapDeltaBytes": -49154588,
      "heapUsedBytes": 280222544,
      "domNodes": -3344,
      "jsHeapTotalBytes": 18599936,
      "scriptDurationMs": 118.857,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 36.626744186046515,
      "p95FrameDurationMs": 83.30000000000018
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5570.848000000069,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.78600000000001,
      "layouts": 20,
      "layoutDurationMs": 31.702999999999996,
      "taskDurationMs": 5471.69,
      "heapDeltaBytes": -32086048,
      "heapUsedBytes": 297362136,
      "domNodes": -3344,
      "jsHeapTotalBytes": 21745664,
      "scriptDurationMs": 80.204,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.03609467455621,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8502.218000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8272.711,
      "heapDeltaBytes": 10471668,
      "heapUsedBytes": 294520432,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 116.05599999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.82350877192982,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5939.604999999915,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5506.775,
      "heapDeltaBytes": -8605848,
      "heapUsedBytes": 294448392,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 76.86100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.976430976430983,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "workflow-execution",
      "durationMs": 981.695000000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 15.306000000000001,
      "layouts": 11,
      "layoutDurationMs": 7.247000000000001,
      "taskDurationMs": 167.92000000000002,
      "heapDeltaBytes": -16048156,
      "heapUsedBytes": 94292960,
      "domNodes": 126,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 24.308999999999997,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.955172413793097,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 439.23100000006343,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 8.633999999999999,
      "layouts": 14,
      "layoutDurationMs": 3.779,
      "taskDurationMs": 80.25099999999999,
      "heapDeltaBytes": -17535068,
      "heapUsedBytes": 92596260,
      "domNodes": 95,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.753,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669230769230772,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 298.02600000004986,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.623,
      "layouts": 76,
      "layoutDurationMs": 13.174,
      "taskDurationMs": 257.05899999999997,
      "heapDeltaBytes": 10199020,
      "heapUsedBytes": 100875272,
      "domNodes": 4,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 116.299,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 266.4150000000518,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.644,
      "layouts": 76,
      "layoutDurationMs": 12.759,
      "taskDurationMs": 220.55700000000002,
      "heapDeltaBytes": 9975668,
      "heapUsedBytes": 98468660,
      "domNodes": 4,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 98.32000000000001,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66874999999999,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 244.0320000000611,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.1789999999999998,
      "layouts": 76,
      "layoutDurationMs": 9.438,
      "taskDurationMs": 207.07600000000002,
      "heapDeltaBytes": -1853396,
      "heapUsedBytes": 118313468,
      "domNodes": 4,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 70.829,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999975,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 336.42199999997047,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.807,
      "layouts": 76,
      "layoutDurationMs": 14.758000000000001,
      "taskDurationMs": 297.034,
      "heapDeltaBytes": -512468,
      "heapUsedBytes": 120549752,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 104.67699999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Line coverage: 63.7%

Coverage totals
Metric Covered Total Pct
Lines 57488 90309 63.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1170
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 0.9% 314
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.6% 312
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/stores/teamWorkspaceStore.ts 46.9% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2992 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2290 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 673 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/30/2026, 11:00:44 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since fc443f3101add1c6608b56b9a3e2362f9bb38481

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (140)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useLiveGraphNode.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/slotDefaults.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/touchCanvasAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/workspaceApi.webSessionRetry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 90 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.58   #22424   +/-   ##
=============================================
  Coverage              ?   84.24%           
=============================================
  Files                 ?     3171           
  Lines                 ?   165423           
  Branches              ?    39065           
=============================================
  Hits                  ?   139356           
  Misses                ?    25676           
  Partials              ?      391           
Flag Coverage Δ
e2e 63.86% <ø> (?)
unit 86.03% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/crdt/opSender.ts 100.00% <100.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 98.49% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport approved.

@comfy-pr-bot
comfy-pr-bot merged commit 4ac9765 into cloud/1.58 Nov 1, 2026
144 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-22237-to-cloud-1.58 branch November 1, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants