Repository navigation
[backport core/1.58] fix(agent): hold human edits made while the doc socket is down (PM-2392) - #22423
Conversation
…92) (#22237) A widget edit a user makes while the Agent process is down is now delivered when it comes back, instead of being thrown away 2.5 seconds into the outage and then overwritten by the Agent's older document. Fixes [PM-2392](https://linear.app/comfyorg/issue/PM-2392/agent-reconnect-overwrites-load-image-edits-saved-during-the-outage). QA reproduced it 2/2 on Windows Desktop 1.1.8 with local Agent rc5 and frontend 1.59.0.dev2: kill the Agent process, change two Load Image widgets by hand, save, and on reconnect `doc_subscribe` plus a full `doc_update` puts the old filenames back — in the live widget, in the next save, and in the Agent's next answer. [#21268](#21268) guards the outbound draft and does not cover this direction; `canvasMayBeStale` stayed `false` throughout. `opSender.transmit` gave a batch five 500 ms retries and then settled it `undeliverable`. That did two separate kinds of damage: 1. **The edit was lost.** It never reached the document, so nothing downstream of the document ever saw it. 2. **Its `LocalWidgetWrites` hold was lifted.** `settleHumanOps` calls `projection.settleLocalWrites` for every outcome, including `undeliverable`, and the hold is the only thing stopping a remote frame from writing a register the user has an edit in flight on. With it gone, the reconnect's catch-up frame was free to project the pre-outage value back over the register. The second is why the symptom is a visible revert rather than a silently unsynced edit. Transport retry exhaustion is a **hold**, not a terminal discard — the 2026-09-28 ruling that an offline edit is owed delivery. The batch stays at the head of the sender's FIFO with its original `op_id`, `actor` and stamp, and `OpSender.retryTransport()` sends it when the socket returns. Because it never settles, the register's hold survives with it, so the catch-up frame cannot overwrite the edit in the window before the resend lands. The resend is driven from `doc_subscribed{ok:true}`, not from the socket-live edge: the host answers a subscribe before it reads the ops frame, so the catch-up `doc_update` is already on the wire ahead of the resend and ordering stays deterministic. Nothing else changes shape. A batch whose doc is unbound still settles `undeliverable` through `abortIfUnbound`, `doc_reset` still aborts everything, `detach` still drains, and `pendingOps()` still reports the held batch as unsynced. **No reconciliation pass and no second graph mutation path**: the retained ops are the human's own intent, minted at the command site and replayed through the one wire path. - **Black-box harness, red on parent and green here**: `browser_tests/tests/agent/agentOfflineEditSurvivesReconnect.spec.ts` runs the reported sequence — the Agent builds two nodes, its process goes down, the user retypes both widgets by hand, the Agent comes back and answers the resubscribe with its whole document, then the workflow is saved, the page reloaded, the workflow reopened from the server, and one more Agent turn sent. On the parent it fails with the document still holding `agent prompt one`; here all four readers hold the user's value. - **Harness addition**: `AgentFollowerHostSocket.beginAgentOutage()` / `endAgentOutage()` model a down Agent process by refusing reconnects, so an outage can outlast the sender's retry budget. `disconnect()` only models a blip the page recovers from inside its first backoff step. The outage length is counted in observed refused reconnects rather than a sleep. - **Unit**: a new `useAgentCrdtFollower` case pins the whole chain — the edit is held, `settleLocalWrites` is *not* called, and the resend carries the same `op_id` and `base_version`. It fails on the parent exactly on the `settleLocalWrites` assertion. Two new `opSender` cases cover the hold and the unbound-while-held path; the `transport_exhausted` report row is now the `detached` one, since a down transport no longer settles on its own. - 4,542 Agent/CRDT unit tests pass; app and browser typechecks pass; `agentHumanEditResentAcrossReconnect`, `agentStaleCanvasDraft` and `agentHumanRenameRetriesAfterTransportThrow` all still pass. - The spec drives a `CLIPTextEncode.text` register rather than the reported `LoadImage.image` one. The defect is a property of a last-writer-wins widget register, not of a node class, and the Load Image picker only offers a filename the backend can actually serve — faking one would exercise the media picker rather than the reconnect. - The harness host resumes its document across the outage rather than re-minting it, so the spec's red is the lost edit and its effect on the save, the reload and the next turn. The register-level overwrite that the lifted hold allows is pinned by the unit test instead. - A held batch is retained until the socket returns, the doc unbinds, or the page unmounts. A long outage with continuous editing therefore accumulates batches rather than dropping one every 2.5 s; they are reported as unsynced throughout and drained on unmount. (cherry picked from commit 7b38703)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-30T23:11:37.172Z",
"gitSha": "205a5e2a95375a8477f7b807b4ff30f297e41636",
"branch": "backport-22237-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2033.6220000000367,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.757999999999999,
"layouts": 8,
"layoutDurationMs": 2.626,
"taskDurationMs": 513.038,
"heapDeltaBytes": 749192,
"heapUsedBytes": 91032948,
"domNodes": -200,
"jsHeapTotalBytes": 327680,
"scriptDurationMs": 13.070000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2054.9419999999827,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.638000000000001,
"layouts": 8,
"layoutDurationMs": 2.7219999999999995,
"taskDurationMs": 647.6370000000001,
"heapDeltaBytes": 904852,
"heapUsedBytes": 91293736,
"domNodes": -200,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 12.109000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6650406504065,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1838.3330000000342,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.012,
"layouts": 9,
"layoutDurationMs": 2.5429999999999997,
"taskDurationMs": 975.5920000000001,
"heapDeltaBytes": 354980,
"heapUsedBytes": 90586408,
"domNodes": -200,
"jsHeapTotalBytes": 2162688,
"scriptDurationMs": 158.81099999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.819266055045873,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.9090000000697,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.758999999999999,
"layouts": 9,
"layoutDurationMs": 2.739,
"taskDurationMs": 835.5559999999999,
"heapDeltaBytes": 2075208,
"heapUsedBytes": 92492912,
"domNodes": -200,
"jsHeapTotalBytes": 2686976,
"scriptDurationMs": 163.304,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.400999999963,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.102,
"layouts": 11,
"layoutDurationMs": 3.5179999999999993,
"taskDurationMs": 468.19399999999996,
"heapDeltaBytes": 3577428,
"heapUsedBytes": 104224820,
"domNodes": 47,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 15.749000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1807.107999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 6.495000000000001,
"layouts": 12,
"layoutDurationMs": 3.306,
"taskDurationMs": 524.7930000000001,
"heapDeltaBytes": -996436,
"heapUsedBytes": 99905452,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 17.423,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 744.6999999999662,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9059999999999997,
"layouts": 8,
"layoutDurationMs": 2.357,
"taskDurationMs": 532.949,
"heapDeltaBytes": 5368544,
"heapUsedBytes": 98841764,
"domNodes": 0,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 167.355,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.5000000000109,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1510000000000002,
"layouts": 9,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 512.894,
"heapDeltaBytes": 4708196,
"heapUsedBytes": 96231464,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 165.596,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1231.8329999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 895.5709999999999,
"heapDeltaBytes": -14217080,
"heapUsedBytes": 102912916,
"domNodes": -210,
"jsHeapTotalBytes": 16326656,
"scriptDurationMs": 68.01500000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 533,
"frameDurationMs": 32.45526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1214.211999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 954.4119999999999,
"heapDeltaBytes": -3638744,
"heapUsedBytes": 102922924,
"domNodes": -230,
"jsHeapTotalBytes": 9064448,
"scriptDurationMs": 64.699,
"eventListeners": -168,
"totalBlockingTimeMs": 515,
"frameDurationMs": 32.015789473684194,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.7739999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.2569999999997,
"heapDeltaBytes": -2775128,
"heapUsedBytes": 97735404,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.128,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.4280000000172,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.2640000000002,
"heapDeltaBytes": -2984460,
"heapUsedBytes": 94750316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.57700000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9361.188999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8412.116000000002,
"heapDeltaBytes": 42207712,
"heapUsedBytes": 146591172,
"domNodes": -296,
"jsHeapTotalBytes": 33357824,
"scriptDurationMs": 6759.156,
"eventListeners": -130,
"totalBlockingTimeMs": 254,
"frameDurationMs": 28.417933130699087,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9401.35500000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8532.878999999999,
"heapDeltaBytes": 46754012,
"heapUsedBytes": 151111040,
"domNodes": -296,
"jsHeapTotalBytes": 37289984,
"scriptDurationMs": 6890.123,
"eventListeners": -130,
"totalBlockingTimeMs": 223,
"frameDurationMs": 29.924600638977633,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9803.473999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9014.103000000001,
"heapDeltaBytes": 52179144,
"heapUsedBytes": 167166496,
"domNodes": -296,
"jsHeapTotalBytes": 50475008,
"scriptDurationMs": 7009.1,
"eventListeners": -130,
"totalBlockingTimeMs": 224,
"frameDurationMs": 28.07936962750716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9829.330000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9018.281,
"heapDeltaBytes": 54629468,
"heapUsedBytes": 159363668,
"domNodes": -296,
"jsHeapTotalBytes": 35717120,
"scriptDurationMs": 6955.188,
"eventListeners": -130,
"totalBlockingTimeMs": 209,
"frameDurationMs": 29.042011834319524,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 269.9010000000044,
"styleRecalcs": 26,
"styleRecalcDurationMs": 18.75,
"layouts": 11,
"layoutDurationMs": 3.423,
"taskDurationMs": 220.493,
"heapDeltaBytes": 15522084,
"heapUsedBytes": 120703528,
"domNodes": 917,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.285,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.792307692307705,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 235.84600000003775,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.190999999999999,
"layouts": 11,
"layoutDurationMs": 3.605,
"taskDurationMs": 182.928,
"heapDeltaBytes": -3792100,
"heapUsedBytes": 101939552,
"domNodes": 917,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.377999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090843,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2056.18400000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.823000000000001,
"layouts": 8,
"layoutDurationMs": 2.504,
"taskDurationMs": 766.14,
"heapDeltaBytes": 8708,
"heapUsedBytes": 109622944,
"domNodes": -297,
"jsHeapTotalBytes": -1507328,
"scriptDurationMs": 42.388999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2072.3800000000665,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.915000000000001,
"layouts": 8,
"layoutDurationMs": 2.5910000000000006,
"taskDurationMs": 770.6080000000001,
"heapDeltaBytes": -2139296,
"heapUsedBytes": 102494268,
"domNodes": -297,
"jsHeapTotalBytes": -2215936,
"scriptDurationMs": 36.517,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2956.5089999999827,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.112000000000002,
"layouts": 6,
"layoutDurationMs": 1.676,
"taskDurationMs": 1803.5030000000002,
"heapDeltaBytes": -1886084,
"heapUsedBytes": 109629428,
"domNodes": -296,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 859.49,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2798.8249999999653,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.104999999999999,
"layouts": 7,
"layoutDurationMs": 1.8800000000000001,
"taskDurationMs": 1781.9989999999998,
"heapDeltaBytes": -12817668,
"heapUsedBytes": 89094228,
"domNodes": -296,
"jsHeapTotalBytes": -1478656,
"scriptDurationMs": 815.272,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.765868263473052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4122.150999999974,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.439,
"layouts": 64,
"layoutDurationMs": 11.998,
"taskDurationMs": 1979.2439999999997,
"heapDeltaBytes": -20435108,
"heapUsedBytes": 92797144,
"domNodes": -272,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 826.5219999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666260162601628,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3620.139999999992,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.342,
"layouts": 64,
"layoutDurationMs": 12.504,
"taskDurationMs": 1649.7050000000002,
"heapDeltaBytes": 6868792,
"heapUsedBytes": 120332792,
"domNodes": 24,
"jsHeapTotalBytes": 6033408,
"scriptDurationMs": 796.7040000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.743055555555557,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3269.9539999999843,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.299999999999999,
"layouts": 6,
"layoutDurationMs": 1.8709999999999998,
"taskDurationMs": 2146.7580000000003,
"heapDeltaBytes": -7690204,
"heapUsedBytes": 106983984,
"domNodes": -296,
"jsHeapTotalBytes": 1400832,
"scriptDurationMs": 998.6859999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.92538860103627,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3126.5039999999544,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.771,
"layouts": 5,
"layoutDurationMs": 1.5,
"taskDurationMs": 1883.907,
"heapDeltaBytes": 22607732,
"heapUsedBytes": 137519416,
"domNodes": 0,
"jsHeapTotalBytes": 9596928,
"scriptDurationMs": 1009.5160000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.116756756756754,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2047.551999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4339999999999997,
"layouts": 7,
"layoutDurationMs": 2.1429999999999993,
"taskDurationMs": 763.9820000000001,
"heapDeltaBytes": -28660248,
"heapUsedBytes": 95796660,
"domNodes": -296,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 36.932,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.7189999999964,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6639999999999997,
"layouts": 7,
"layoutDurationMs": 2.2629999999999995,
"taskDurationMs": 611.1410000000001,
"heapDeltaBytes": -30030504,
"heapUsedBytes": 89344012,
"domNodes": -296,
"jsHeapTotalBytes": -1732608,
"scriptDurationMs": 36.754,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.6760000000027,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.259999999999999,
"layouts": 9,
"layoutDurationMs": 2.8150000000000004,
"taskDurationMs": 448.22200000000004,
"heapDeltaBytes": -189248,
"heapUsedBytes": 90743840,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 162.727,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.7179999999671,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.439,
"layouts": 10,
"layoutDurationMs": 3.2089999999999996,
"taskDurationMs": 424.303,
"heapDeltaBytes": 833684,
"heapUsedBytes": 102829852,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 153.166,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66944444444443,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2040.9480000000144,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.817,
"layouts": 8,
"layoutDurationMs": 2.714,
"taskDurationMs": 492.799,
"heapDeltaBytes": 6663832,
"heapUsedBytes": 97530672,
"domNodes": -218,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 12.376999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2057.5249999999414,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.142000000000001,
"layouts": 9,
"layoutDurationMs": 2.665,
"taskDurationMs": 651.2959999999999,
"heapDeltaBytes": 1529144,
"heapUsedBytes": 92061960,
"domNodes": -199,
"jsHeapTotalBytes": -2002944,
"scriptDurationMs": 12.116000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.013999999997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.960000000000003,
"layouts": 10,
"layoutDurationMs": 3.3970000000000002,
"taskDurationMs": 787.083,
"heapDeltaBytes": -20336484,
"heapUsedBytes": 81245092,
"domNodes": -210,
"jsHeapTotalBytes": 2764800,
"scriptDurationMs": 114.687,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.2249999999995,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.972,
"layouts": 9,
"layoutDurationMs": 2.7079999999999997,
"taskDurationMs": 798.5329999999999,
"heapDeltaBytes": 5143764,
"heapUsedBytes": 96004824,
"domNodes": -190,
"jsHeapTotalBytes": 3473408,
"scriptDurationMs": 117.316,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9959999999555,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.450000000000003,
"layouts": 5,
"layoutDurationMs": 16.343,
"taskDurationMs": 914.269,
"heapDeltaBytes": 35616808,
"heapUsedBytes": 135234540,
"domNodes": 16030,
"jsHeapTotalBytes": 17178624,
"scriptDurationMs": 31.295,
"eventListeners": 3244,
"totalBlockingTimeMs": 149,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11724.317999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.821,
"layouts": 8,
"layoutDurationMs": 2.502,
"taskDurationMs": 6320.741,
"heapDeltaBytes": -20404812,
"heapUsedBytes": 90067484,
"domNodes": -296,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 2773.825,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.713409415121255,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11202.372999999967,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.961999999999996,
"layouts": 7,
"layoutDurationMs": 2.0869999999999997,
"taskDurationMs": 6306.255,
"heapDeltaBytes": -15209452,
"heapUsedBytes": 89297284,
"domNodes": -296,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 2739.06,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16840.106000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16406.921000000002,
"heapDeltaBytes": -41717612,
"heapUsedBytes": 282890328,
"domNodes": -307,
"jsHeapTotalBytes": 5492736,
"scriptDurationMs": 269.036,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.034402852049915,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16825.642000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16287.213000000002,
"heapDeltaBytes": 104460,
"heapUsedBytes": 300888556,
"domNodes": -3344,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 264.112,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.840316901408457,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 29195.491999999944,
"styleRecalcs": 181,
"styleRecalcDurationMs": 28.162999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28972.155,
"heapDeltaBytes": -26458408,
"heapUsedBytes": 303378172,
"domNodes": -3344,
"jsHeapTotalBytes": 8830976,
"scriptDurationMs": 955.0350000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 57.14050880626223,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21506.81499999996,
"styleRecalcs": 159,
"styleRecalcDurationMs": 23.559000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21299.159000000003,
"heapDeltaBytes": -13730160,
"heapUsedBytes": 297515956,
"domNodes": -3344,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 935.7099999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 41.170936902485664,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6317.072000000053,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.678,
"layouts": 20,
"layoutDurationMs": 26.418999999999997,
"taskDurationMs": 6211.873999999999,
"heapDeltaBytes": -36987280,
"heapUsedBytes": 292572272,
"domNodes": -3373,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 123.414,
"eventListeners": -653,
"totalBlockingTimeMs": 25,
"frameDurationMs": 35.28715083798883,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8747.646000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.64500000000002,
"layouts": 20,
"layoutDurationMs": 33.93300000000001,
"taskDurationMs": 8660.293,
"heapDeltaBytes": -9507068,
"heapUsedBytes": 292430440,
"domNodes": -307,
"jsHeapTotalBytes": 4968448,
"scriptDurationMs": 143.009,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.24406779661016,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8321.574000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8164.735999999998,
"heapDeltaBytes": -8798740,
"heapUsedBytes": 285553308,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.16200000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.807885304659504,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12100.186000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11778.634999999998,
"heapDeltaBytes": -15273492,
"heapUsedBytes": 270010208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.32099999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.64797047970479,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "workflow-execution",
"durationMs": 142.8160000000389,
"styleRecalcs": 11,
"styleRecalcDurationMs": 13.214,
"layouts": 10,
"layoutDurationMs": 4.683,
"taskDurationMs": 114.86399999999999,
"heapDeltaBytes": 5042324,
"heapUsedBytes": 95235800,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.072000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66249999999991,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 131.55000000006112,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.506,
"layouts": 8,
"layoutDurationMs": 4.492999999999999,
"taskDurationMs": 94.97300000000001,
"heapDeltaBytes": 4666636,
"heapUsedBytes": 94946816,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.555999999999997,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.057142857142804,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 566.0990000000083,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.763,
"layouts": 76,
"layoutDurationMs": 18.075999999999997,
"taskDurationMs": 521.318,
"heapDeltaBytes": 12829100,
"heapUsedBytes": 82841352,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 245.19400000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 566.306999999938,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.731,
"layouts": 76,
"layoutDurationMs": 17.828,
"taskDurationMs": 520.978,
"heapDeltaBytes": -13427220,
"heapUsedBytes": 81593600,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 246.762,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 722.7900000000318,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.564,
"layouts": 76,
"layoutDurationMs": 17.61,
"taskDurationMs": 663.355,
"heapDeltaBytes": 1673204,
"heapUsedBytes": 126194316,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 279.03900000000004,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667441860465132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 598.1090000000222,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.509,
"layouts": 76,
"layoutDurationMs": 15.844000000000001,
"taskDurationMs": 566.217,
"heapDeltaBytes": 1141284,
"heapUsedBytes": 118426768,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 228.05100000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777762,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageLine coverage: 59.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2987 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c6d2dea681075bbbcb18714c01dc47344f6cf868
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (136)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #22423 +/- ##
============================================
Coverage 84.04% 84.04%
============================================
Files 3175 3174 -1
Lines 166036 166011 -25
Branches 39605 41807 +2202
============================================
- Hits 139540 139521 -19
+ Misses 26104 26098 -6
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #22237 (a hand edit made while the Agent is disconnected is held and delivered on reconnect, https://linear.app/comfyorg/issue/PM-2392). The auto-backport hit a conflict in
opSender, where this branch'ssettleUnboundhas no cause argument. Resolved by keeping the hold, and left out the report-row test this branch does not have. opSender and follower unit tests pass.