Repository navigation
[backport cloud/1.58] fix(billing): report a failed background balance read instead of leaving it unhandled (#22201) - #22317
Conversation
…ead of leaving it unhandled (#22201) Opening the account menu (legacy or workspace) or the Credits settings section starts a balance read that nothing awaits. When it fails, the rejection is unhandled, so Sentry files it as a new high-priority error. Now: - the failure is reported as a `billing` warning (`error_refreshing_balance`), at most once every five minutes, so reopening the menu during an outage does not repeat it; - a workspace balance read that a newer read has replaced settles quietly instead of rejecting, matching the rail path's `SUPERSEDED` handling, so the warning only covers failures the billing state actually kept; - the same applies across a workspace switch. A balance read for the previous workspace could still land after the switch replaced the billing adapter, writing that workspace's balance into the discarded adapter or reporting a warning for a failure the billing state never kept. `fetchStatus` already captured and rechecked the workspace id, so `fetchBalance` now shares that guard rather than carrying a second copy. What the user sees is unchanged. Note that the two popovers still show 0 credits when the read fails; that display bug is tracked separately in https://linear.app/comfyorg/issue/FRONT-3164. Evidence: both events of Sentry `CLOUD-FRONTEND-PROD-2V0` ("AuthStoreError: Failed to fetch balance: Balance temporarily unavailable") are `onunhandledrejection` from `useLegacyBilling.fetchBalance`, right after a 503 from `/customers/balance`. #21322 now retries that 503; this covers the failure left after the retries run out. Linear: https://linear.app/comfyorg/issue/FRONT-3684 - Red before the fix, green after: one test per call site (`CurrentUserPopoverLegacy`, `CurrentUserPopoverWorkspace`, `SettingDialog` Credits section), the helper's five-minute report budget, `useWorkspaceBilling` settling a superseded failed read, and `useWorkspaceBilling` dropping a balance read on both paths once the workspace changed. - `pnpm typecheck`, oxlint, oxfmt and the pre-push fallow audit pass. - After release: `CLOUD-FRONTEND-PROD-2V0` gets no new unhandled events; a persistent balance outage shows up as `error_refreshing_balance` warnings instead.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-30T00:14:46.208Z",
"gitSha": "a92998035179bea97149543ff8c0e8b8fc0440e7",
"branch": "backport-22201-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.2600000000023,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.814,
"layouts": 10,
"layoutDurationMs": 2.5829999999999997,
"taskDurationMs": 298.357,
"heapDeltaBytes": 25961900,
"heapUsedBytes": 116389204,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.323,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2024.362999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.554,
"layouts": 10,
"layoutDurationMs": 2.454,
"taskDurationMs": 355.117,
"heapDeltaBytes": 2517524,
"heapUsedBytes": 90888448,
"domNodes": -200,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 9.17,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754095,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1717.265999999995,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.357000000000001,
"layouts": 9,
"layoutDurationMs": 2.074,
"taskDurationMs": 757.808,
"heapDeltaBytes": -5104220,
"heapUsedBytes": 82343524,
"domNodes": -200,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 123.31800000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.6349999999597,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.725999999999997,
"layouts": 8,
"layoutDurationMs": 2.1,
"taskDurationMs": 776.2189999999999,
"heapDeltaBytes": -22483852,
"heapUsedBytes": 80522508,
"domNodes": -200,
"jsHeapTotalBytes": -1478656,
"scriptDurationMs": 125.74099999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.6129999999998,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.337,
"layouts": 12,
"layoutDurationMs": 2.5779999999999994,
"taskDurationMs": 242.35700000000003,
"heapDeltaBytes": 24142520,
"heapUsedBytes": 114761528,
"domNodes": 47,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.540000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.170999999989,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.8629999999999995,
"layouts": 12,
"layoutDurationMs": 2.991,
"taskDurationMs": 324.461,
"heapDeltaBytes": -4018640,
"heapUsedBytes": 98879356,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.677000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 550.4720000000134,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.79,
"layouts": 9,
"layoutDurationMs": 2.3939999999999997,
"taskDurationMs": 372.99499999999995,
"heapDeltaBytes": 3224960,
"heapUsedBytes": 92200608,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.44,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 591.0300000000461,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.757,
"layouts": 10,
"layoutDurationMs": 2.405,
"taskDurationMs": 447.25000000000006,
"heapDeltaBytes": -153988,
"heapUsedBytes": 88238064,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 137.542,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1024.991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.15,
"heapDeltaBytes": -16397516,
"heapUsedBytes": 102199972,
"domNodes": -240,
"jsHeapTotalBytes": 14569472,
"scriptDurationMs": 54.403999999999996,
"eventListeners": -168,
"totalBlockingTimeMs": 376,
"frameDurationMs": 28.70277777777777,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1023.7050000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.758,
"heapDeltaBytes": -14484332,
"heapUsedBytes": 102208216,
"domNodes": -230,
"jsHeapTotalBytes": 15802368,
"scriptDurationMs": 54.033,
"eventListeners": -168,
"totalBlockingTimeMs": 373,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 785.9599999999887,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.85699999999997,
"heapDeltaBytes": -2700352,
"heapUsedBytes": 92183188,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.23500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.5729999999803,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.9290000000003,
"heapDeltaBytes": -4454724,
"heapUsedBytes": 97188284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.99700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7407.792999999998,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.49,
"layouts": 2,
"layoutDurationMs": 0.41300000000000014,
"taskDurationMs": 6578.907,
"heapDeltaBytes": 32390164,
"heapUsedBytes": 135994304,
"domNodes": -276,
"jsHeapTotalBytes": 23998464,
"scriptDurationMs": 5279.773999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 105,
"frameDurationMs": 24.665666666666667,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7082.006000000036,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7420000000000004,
"layouts": 3,
"layoutDurationMs": 0.598,
"taskDurationMs": 6303.439,
"heapDeltaBytes": 2421156,
"heapUsedBytes": 123659116,
"domNodes": -276,
"jsHeapTotalBytes": 28114944,
"scriptDurationMs": 5074.378000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 78,
"frameDurationMs": 24.34054982817869,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7461.9680000000135,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5570000000000002,
"layouts": 2,
"layoutDurationMs": 0.477,
"taskDurationMs": 6719.712,
"heapDeltaBytes": 786860,
"heapUsedBytes": 122447804,
"domNodes": -296,
"jsHeapTotalBytes": 27590656,
"scriptDurationMs": 5179.742,
"eventListeners": -130,
"totalBlockingTimeMs": 174,
"frameDurationMs": 24.805315614617943,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6934.697000000028,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8840000000000002,
"layouts": 3,
"layoutDurationMs": 0.8150000000000002,
"taskDurationMs": 6224.934,
"heapDeltaBytes": 25047892,
"heapUsedBytes": 126887396,
"domNodes": -276,
"jsHeapTotalBytes": 27852800,
"scriptDurationMs": 4981.2390000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 68,
"frameDurationMs": 24.849820788530465,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 184.84200000000328,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.133000000000001,
"layouts": 11,
"layoutDurationMs": 2.9559999999999995,
"taskDurationMs": 134.24699999999999,
"heapDeltaBytes": 15492544,
"heapUsedBytes": 116735676,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 6.956000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.00999999999999,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 166.4530000000468,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.027000000000001,
"layouts": 12,
"layoutDurationMs": 2.9710000000000005,
"taskDurationMs": 119.739,
"heapDeltaBytes": 15414464,
"heapUsedBytes": 118180976,
"domNodes": 917,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 6.904999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837500000000034,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2042.4700000000087,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4739999999999998,
"layouts": 9,
"layoutDurationMs": 2.304,
"taskDurationMs": 536.6669999999999,
"heapDeltaBytes": -16501904,
"heapUsedBytes": 89675172,
"domNodes": -296,
"jsHeapTotalBytes": -1167360,
"scriptDurationMs": 27.585000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.8170000000082,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9640000000000004,
"layouts": 8,
"layoutDurationMs": 1.7389999999999999,
"taskDurationMs": 520.077,
"heapDeltaBytes": 69292,
"heapUsedBytes": 101923540,
"domNodes": -296,
"jsHeapTotalBytes": -2031616,
"scriptDurationMs": 28.694999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.8579999999956,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.196,
"layouts": 8,
"layoutDurationMs": 1.9779999999999998,
"taskDurationMs": 1251.633,
"heapDeltaBytes": 1459668,
"heapUsedBytes": 104479028,
"domNodes": -296,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 670.92,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538461,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2271.165000000053,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.701,
"layouts": 7,
"layoutDurationMs": 1.9130000000000003,
"taskDurationMs": 1361.8619999999999,
"heapDeltaBytes": -31632368,
"heapUsedBytes": 88634420,
"domNodes": -276,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 633.122,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78962962962963,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3493.8700000000154,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.634,
"layouts": 65,
"layoutDurationMs": 10.088,
"taskDurationMs": 1496.9969999999998,
"heapDeltaBytes": 9110856,
"heapUsedBytes": 113536460,
"domNodes": -272,
"jsHeapTotalBytes": 196608,
"scriptDurationMs": 637.91,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666190476190476,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3271.6649999999845,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.356,
"layouts": 67,
"layoutDurationMs": 10.947999999999999,
"taskDurationMs": 1357.099,
"heapDeltaBytes": -8314948,
"heapUsedBytes": 96038528,
"domNodes": -280,
"jsHeapTotalBytes": -327680,
"scriptDurationMs": 644.741,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75128205128205,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2295.3540000000316,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.5169999999999995,
"layouts": 6,
"layoutDurationMs": 1.509,
"taskDurationMs": 1558.545,
"heapDeltaBytes": 16653988,
"heapUsedBytes": 122584564,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 751.8770000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91333333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2214.815000000044,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.255,
"layouts": 6,
"layoutDurationMs": 1.52,
"taskDurationMs": 1437.835,
"heapDeltaBytes": 15707452,
"heapUsedBytes": 121791156,
"domNodes": 0,
"jsHeapTotalBytes": 5926912,
"scriptDurationMs": 753.966,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.792424242424243,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.6399999999721,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.503,
"layouts": 8,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 549.2690000000001,
"heapDeltaBytes": -15685812,
"heapUsedBytes": 95428980,
"domNodes": -277,
"jsHeapTotalBytes": -2478080,
"scriptDurationMs": 29.025999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.3710000000447,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.259000000000001,
"layouts": 8,
"layoutDurationMs": 1.9449999999999998,
"taskDurationMs": 404.2939999999999,
"heapDeltaBytes": -107900,
"heapUsedBytes": 102951248,
"domNodes": -296,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 28.081000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.3580000000229,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.8839999999999995,
"layouts": 9,
"layoutDurationMs": 2.159,
"taskDurationMs": 406.55199999999996,
"heapDeltaBytes": 24188120,
"heapUsedBytes": 116270928,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 122.01700000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.8329999999883,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.155999999999999,
"layouts": 10,
"layoutDurationMs": 2.3950000000000005,
"taskDurationMs": 379.563,
"heapDeltaBytes": 22413376,
"heapUsedBytes": 114077288,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 123.85399999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.9420000000148,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.4469999999999996,
"layouts": 10,
"layoutDurationMs": 2.263,
"taskDurationMs": 490.413,
"heapDeltaBytes": -24771268,
"heapUsedBytes": 80272216,
"domNodes": -224,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 8.949,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2025.08899999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.96,
"layouts": 10,
"layoutDurationMs": 3.145,
"taskDurationMs": 480.00100000000003,
"heapDeltaBytes": -22441840,
"heapUsedBytes": 82472236,
"domNodes": -218,
"jsHeapTotalBytes": -2789376,
"scriptDurationMs": 7.9,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1956.0940000000073,
"styleRecalcs": 85,
"styleRecalcDurationMs": 13.867,
"layouts": 9,
"layoutDurationMs": 2.299,
"taskDurationMs": 835.4809999999999,
"heapDeltaBytes": 2555544,
"heapUsedBytes": 92110720,
"domNodes": -191,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 93.301,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.2469999999657,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.679,
"layouts": 9,
"layoutDurationMs": 2.18,
"taskDurationMs": 673.163,
"heapDeltaBytes": 15052672,
"heapUsedBytes": 107009616,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 90.637,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673263,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.5259999999648,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.151000000000003,
"layouts": 5,
"layoutDurationMs": 11.918000000000001,
"taskDurationMs": 630.201,
"heapDeltaBytes": 33172784,
"heapUsedBytes": 133497604,
"domNodes": 16030,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 21.871999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 104,
"frameDurationMs": 20.153488372093033,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8857.918999999982,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.219000000000005,
"layouts": 10,
"layoutDurationMs": 2.104,
"taskDurationMs": 4811.096,
"heapDeltaBytes": 2275404,
"heapUsedBytes": 109014424,
"domNodes": -296,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 2137.7240000000006,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665977443609023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.077000000014,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.996000000000002,
"layouts": 8,
"layoutDurationMs": 2.088,
"taskDurationMs": 4173.928,
"heapDeltaBytes": 6570844,
"heapUsedBytes": 108180056,
"domNodes": -282,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 2136.3839999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666060606060608,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14293.511000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13675.414,
"heapDeltaBytes": -14536088,
"heapUsedBytes": 295882260,
"domNodes": -3344,
"jsHeapTotalBytes": 25677824,
"scriptDurationMs": 196.297,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.264134275618378,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 18907.216000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18632.555,
"heapDeltaBytes": -41519132,
"heapUsedBytes": 288548684,
"domNodes": -3344,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 260.996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.55063985374772,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 23396.834000000013,
"styleRecalcs": 178,
"styleRecalcDurationMs": 20.513000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23064.568,
"heapDeltaBytes": -43170160,
"heapUsedBytes": 287092000,
"domNodes": -3344,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 735.044,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 44.232514177693766,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16922.774000000005,
"styleRecalcs": 110,
"styleRecalcDurationMs": 13.88499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16543.283000000003,
"heapDeltaBytes": 9214776,
"heapUsedBytes": 315105292,
"domNodes": -3344,
"jsHeapTotalBytes": 23511040,
"scriptDurationMs": 705.3810000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 31.649719626168228,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 6910.091000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.99700000000002,
"layouts": 20,
"layoutDurationMs": 26.713,
"taskDurationMs": 6834.167999999999,
"heapDeltaBytes": -17015476,
"heapUsedBytes": 293438492,
"domNodes": -3344,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 116.42,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.563855421686746,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5221.298999999931,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.29799999999999,
"layouts": 20,
"layoutDurationMs": 26.440000000000005,
"taskDurationMs": 5093.736999999999,
"heapDeltaBytes": -27618428,
"heapUsedBytes": 283764644,
"domNodes": -3344,
"jsHeapTotalBytes": 22269952,
"scriptDurationMs": 84.66099999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.42409638554217,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9366.883999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9218.207000000002,
"heapDeltaBytes": 18955652,
"heapUsedBytes": 290468868,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.21800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.630824372759854,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9961.60199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9439.062,
"heapDeltaBytes": -8420156,
"heapUsedBytes": 276199828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 132.57600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.216607773851585,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 447.6359999999886,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.605,
"layouts": 13,
"layoutDurationMs": 3.9159999999999995,
"taskDurationMs": 117.47900000000001,
"heapDeltaBytes": -18126920,
"heapUsedBytes": 91745992,
"domNodes": 98,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.422,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 453.2239999999774,
"styleRecalcs": 18,
"styleRecalcDurationMs": 9.602,
"layouts": 11,
"layoutDurationMs": 4.356999999999999,
"taskDurationMs": 103.124,
"heapDeltaBytes": 7016736,
"heapUsedBytes": 97649200,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.291,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 327.5100000000748,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5860000000000001,
"layouts": 76,
"layoutDurationMs": 12.231,
"taskDurationMs": 288.31399999999996,
"heapDeltaBytes": -17731444,
"heapUsedBytes": 70113268,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 128.195,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 294.88100000003215,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.632,
"layouts": 76,
"layoutDurationMs": 12.136,
"taskDurationMs": 247.748,
"heapDeltaBytes": 10245528,
"heapUsedBytes": 99655000,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 116.708,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 343.7810000000354,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.563,
"layouts": 76,
"layoutDurationMs": 10.721,
"taskDurationMs": 303.10099999999994,
"heapDeltaBytes": -1189984,
"heapUsedBytes": 115633492,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.563,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 329.003000000057,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.577,
"layouts": 76,
"layoutDurationMs": 11.218,
"taskDurationMs": 291.811,
"heapDeltaBytes": -1340880,
"heapUsedBytes": 115648116,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 107.62299999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2990 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 310ae9c1d666f8395972531c0f696fac8146565b
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (137)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed c69aa8c against the merged parent and the 1.59 backports. The 1.58 directory/import adaptations preserve the same background failure handling, workspace/request ownership checks and warning budget while retaining workspaceApi. Own isolated-checkout validation: 184 tests across all five affected suites, application type check and scoped lint/format PASS. Independently reverting each of the three call-site handlers, dropping stale-rejection suppression or dropping the five-minute report budget each fails retained regressions; the restored 184-test run passes. No remaining code blocker.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #22317 +/- ##
=============================================
Coverage ? 84.22%
=============================================
Files ? 3173
Lines ? 165278
Branches ? 41457
=============================================
Hits ? 139204
Misses ? 25683
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Merging at the approved head |
Manual backport of #22201 (
44cf08fb7b) tocloud/1.58. The auto-backport failed on conflicts.What
Opening the account menu or the Credits settings section starts a balance read nobody awaits. When it fails, the rejection is unhandled and Sentry files a new error. With this change it is reported as one
billingwarning at most every 5 minutes, and a balance read replaced by a newer read (or by a workspace switch) settles quietly.Conflict resolution for 1.58
1.58 predates the billing directory move, so the change lands at the 1.58 paths:
src/platform/workspace/refreshBalanceInBackground.ts(main:src/platform/billing/), importing@/platform/telemetry/reportError(1.58 has no@comfyorg/telemetrypackage).useWorkspaceBilling.ts(undersrc/platform/workspace/composables/) took the sharedisStaleBillingReadguard cleanly; reads still go throughworkspaceApi.SettingDialog.vueand their tests: kept the 1.58 imports (@/composables/billing/*) and added only the helper andreportErrorimports.reportErrormock, so the four new tests mock it withvi.mock(import('@/platform/telemetry/reportError')).Verification
pnpm typecheck:app, oxfmt and oxlint pass.Linear: https://linear.app/comfyorg/issue/FRONT-3684