Repository navigation
[backport cloud/1.58] fix(billing): route the free-tier cloud-subscription 402 to the subscribe dialog (#21592) - #22308
Conversation
…ribe dialog (#21592) A FREE-tier Cloud account with no usable free run is refused at submit with a typed 402, `error.type: CLOUD_SUBSCRIPTION_REQUIRED` (the GTM-303 gate). The error catalog only knew the older `PAYMENT_REQUIRED` paywall string, so a canvas Run refused this way showed a raw error in the error panel instead of opening the subscription dialog. This matches the refusal by type, because its message changes with `credits_locked` ("…to queue workflows." / "…to use your credits on cloud."). The same free-tier gate also returns `FREE_TIER_EXHAUSTED`, `PARTNER_NODE_PAYMENT_REQUIRED` and `MODEL_PAYMENT_REQUIRED` 402s, whose remedy is also a plan. They now route to the subscribe dialog too. The retryable `FREE_TIER_UNAVAILABLE` 429 does not. The dialog opener waits for the selected pricing component to load; if loading fails or the dialog is unavailable, the original queue error stays visible. Extension callbacks retain their `Promise<void>` contract. Production case (2026-10-21, cloud `1.57.0`): a new email/password account was refused on every run because the free-run allowance is Google-sign-in only. Its canvas runs got this 402 with no subscribe prompt, and a few minutes later it bought credits on the platform billing page, which still cannot unlock Cloud runs without a plan. Identifiers stay in the internal tracker. <details><summary>Full context for agent readers</summary> - The Cloud ingest subscription gate refuses FREE-tier runs when `FreeTierRequireGoogleSignIn` withholds the allowance or no free run was consumed. - Queue submissions normalize the server refusal and resolve its account precondition. Unmatched refusals still use the error overlay or error dialog. - `FE-3434` assumes "a run rejected for no plan still goes to Subscribe / Resubscribe through `useAccountPreconditionDialog`". This change covers these typed refusals. - The Run button can show **Run** before a reload because workflow eligibility deliberately fails open while authenticated remote config is not loaded. A refused submission now attempts Subscribe and retains the error-panel fallback. Selling platform top-ups to Cloud free-tier accounts remains a separate product question. </details> - Targeted queue, classifier, billing-dialog, pricing, paywall, and URL-loader tests pass. Queue coverage uses the real account-precondition adapter and checks both dialog takeover and the original-error fallback. - The pricing-import regression fails against the original dialog implementation and passes with this fix. Forcing the adapter to return success also fails the queue fallback regression. - The retained local-distribution browser fallback tests pass against a running frontend and backend. The redundant Cloud-subscription browser case was removed because it passed before the fix; it did not prove successful subscription routing. - Cloud-distribution subscription dialog rendering has not been captured. The local browser checks verify the fallback overlay, not the Cloud pricing UI. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T23:29:31.203Z",
"gitSha": "79ec972bc63a6735ca3ba81897ae5361c8ea9235",
"branch": "backport-21592-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.212999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.972,
"layouts": 9,
"layoutDurationMs": 2.784,
"taskDurationMs": 495.547,
"heapDeltaBytes": 5180528,
"heapUsedBytes": 93717216,
"domNodes": -181,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 12.878000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.5180000000146,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4149999999999996,
"layouts": 10,
"layoutDurationMs": 3.3729999999999998,
"taskDurationMs": 651.413,
"heapDeltaBytes": -467144,
"heapUsedBytes": 90980428,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 13.583000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1909.532999999982,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.659,
"layouts": 8,
"layoutDurationMs": 2.455,
"taskDurationMs": 1007.517,
"heapDeltaBytes": -1835432,
"heapUsedBytes": 87034620,
"domNodes": -201,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 166.00400000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.81327433628319,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.5249999999705,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.807000000000002,
"layouts": 8,
"layoutDurationMs": 2.706,
"taskDurationMs": 914.2009999999999,
"heapDeltaBytes": 2705676,
"heapUsedBytes": 91172060,
"domNodes": -180,
"jsHeapTotalBytes": 65536,
"scriptDurationMs": 172.623,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7689999999848,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.587,
"layouts": 11,
"layoutDurationMs": 3.151,
"taskDurationMs": 357.813,
"heapDeltaBytes": 21416144,
"heapUsedBytes": 112817300,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 14.744999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.8079999999336,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.426,
"layouts": 11,
"layoutDurationMs": 3.0739999999999994,
"taskDurationMs": 425.315,
"heapDeltaBytes": 23718004,
"heapUsedBytes": 114711408,
"domNodes": 47,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.613000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 624.9160000000131,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2530000000000006,
"layouts": 9,
"layoutDurationMs": 2.775,
"taskDurationMs": 450.403,
"heapDeltaBytes": 196928,
"heapUsedBytes": 88620124,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 171.556,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 699.1610000000037,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.2949999999999995,
"layouts": 9,
"layoutDurationMs": 2.8080000000000003,
"taskDurationMs": 483.365,
"heapDeltaBytes": 595136,
"heapUsedBytes": 88149180,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 176.19500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1222.0900000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 947.85,
"heapDeltaBytes": -14074844,
"heapUsedBytes": 102284488,
"domNodes": -210,
"jsHeapTotalBytes": 15540224,
"scriptDurationMs": 64.53099999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 516,
"frameDurationMs": 32.01578947368422,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1239.0990000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 988.311,
"heapDeltaBytes": -3980108,
"heapUsedBytes": 102426560,
"domNodes": -230,
"jsHeapTotalBytes": 9015296,
"scriptDurationMs": 67.17099999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 538,
"frameDurationMs": 32.45263157894736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.877000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.3990000000001,
"heapDeltaBytes": -3346584,
"heapUsedBytes": 94538304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.192,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.5659999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.7870000000005,
"heapDeltaBytes": -3460808,
"heapUsedBytes": 97071116,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.94899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25.0029411764706,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10219.321000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9322.343,
"heapDeltaBytes": 11766044,
"heapUsedBytes": 132891292,
"domNodes": -276,
"jsHeapTotalBytes": 37027840,
"scriptDurationMs": 7315.493,
"eventListeners": -130,
"totalBlockingTimeMs": 578,
"frameDurationMs": 29.871929824561406,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9108.339999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8263.327000000001,
"heapDeltaBytes": 40680216,
"heapUsedBytes": 142613872,
"domNodes": -276,
"jsHeapTotalBytes": 29163520,
"scriptDurationMs": 6588.195000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 163,
"frameDurationMs": 28.743354430379746,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9890.164999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9087.401999999998,
"heapDeltaBytes": 24918772,
"heapUsedBytes": 145878344,
"domNodes": -296,
"jsHeapTotalBytes": 36241408,
"scriptDurationMs": 7058.021,
"eventListeners": -130,
"totalBlockingTimeMs": 298,
"frameDurationMs": 29.451641791044775,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9975.481000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9159.945,
"heapDeltaBytes": 37935104,
"heapUsedBytes": 142250656,
"domNodes": -291,
"jsHeapTotalBytes": 30195712,
"scriptDurationMs": 7123.732,
"eventListeners": -130,
"totalBlockingTimeMs": 269,
"frameDurationMs": 28.971802325581397,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 234.93199999998637,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.940999999999997,
"layouts": 12,
"layoutDurationMs": 3.942,
"taskDurationMs": 170.88400000000001,
"heapDeltaBytes": 15483136,
"heapUsedBytes": 116113512,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.892,
"eventListeners": 196,
"totalBlockingTimeMs": 2,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 250.40799999999308,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.893999999999998,
"layouts": 11,
"layoutDurationMs": 3.5779999999999994,
"taskDurationMs": 201.68800000000002,
"heapDeltaBytes": 15456044,
"heapUsedBytes": 117939384,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.885,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2056.6269999999918,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8979999999999997,
"layouts": 9,
"layoutDurationMs": 2.7129999999999996,
"taskDurationMs": 805.84,
"heapDeltaBytes": 119316,
"heapUsedBytes": 104960744,
"domNodes": -276,
"jsHeapTotalBytes": -118784,
"scriptDurationMs": 37.291,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.818000000111,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2080000000000006,
"layouts": 9,
"layoutDurationMs": 2.997,
"taskDurationMs": 735.67,
"heapDeltaBytes": -12294956,
"heapUsedBytes": 91436004,
"domNodes": -296,
"jsHeapTotalBytes": -1953792,
"scriptDurationMs": 38.42300000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2864.6479999999883,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.193000000000001,
"layouts": 6,
"layoutDurationMs": 1.5740000000000003,
"taskDurationMs": 1800.09,
"heapDeltaBytes": 1818444,
"heapUsedBytes": 103954020,
"domNodes": -276,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 826.498,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763742690058482,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2211.981000000037,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.822999999999999,
"layouts": 6,
"layoutDurationMs": 1.7499999999999998,
"taskDurationMs": 1571.7860000000003,
"heapDeltaBytes": 1280804,
"heapUsedBytes": 104461556,
"domNodes": -296,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 817.047,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4053.758999999957,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.188000000000002,
"layouts": 63,
"layoutDurationMs": 12.233,
"taskDurationMs": 1902.3370000000002,
"heapDeltaBytes": 6568040,
"heapUsedBytes": 117810320,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 847.922,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665983606557376,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3983.0500000000484,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.193999999999999,
"layouts": 63,
"layoutDurationMs": 11.581,
"taskDurationMs": 1886.556,
"heapDeltaBytes": 1040444,
"heapUsedBytes": 110292980,
"domNodes": -273,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 797.093,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666386554621848,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3193.3629999999766,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.327,
"layouts": 5,
"layoutDurationMs": 1.565,
"taskDurationMs": 2137.246,
"heapDeltaBytes": -11313776,
"heapUsedBytes": 94713556,
"domNodes": 0,
"jsHeapTotalBytes": 720896,
"scriptDurationMs": 1065.8220000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.200534759358288,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3251.1200000000144,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.129999999999999,
"layouts": 5,
"layoutDurationMs": 1.3080000000000005,
"taskDurationMs": 2154.897,
"heapDeltaBytes": -11829220,
"heapUsedBytes": 97937516,
"domNodes": 0,
"jsHeapTotalBytes": 536576,
"scriptDurationMs": 1060.18,
"eventListeners": 182,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.099999999999994,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.023999999993,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1990000000000003,
"layouts": 6,
"layoutDurationMs": 1.7630000000000003,
"taskDurationMs": 571.5580000000001,
"heapDeltaBytes": 2301972,
"heapUsedBytes": 105468032,
"domNodes": -296,
"jsHeapTotalBytes": -5177344,
"scriptDurationMs": 37.184,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.635999999945,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2529999999999997,
"layouts": 7,
"layoutDurationMs": 2.0069999999999997,
"taskDurationMs": 681.2029999999999,
"heapDeltaBytes": -24453124,
"heapUsedBytes": 97012388,
"domNodes": -296,
"jsHeapTotalBytes": -917504,
"scriptDurationMs": 33.699,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.3139999999971,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.345,
"layouts": 10,
"layoutDurationMs": 3.0749999999999997,
"taskDurationMs": 406.78,
"heapDeltaBytes": 22487544,
"heapUsedBytes": 114163776,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 156.09400000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.3930000000546,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.375,
"layouts": 9,
"layoutDurationMs": 2.49,
"taskDurationMs": 448.92299999999994,
"heapDeltaBytes": 22533024,
"heapUsedBytes": 114488020,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 148.041,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2041.0610000000133,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0749999999999997,
"layouts": 10,
"layoutDurationMs": 3.135,
"taskDurationMs": 657.8269999999999,
"heapDeltaBytes": -2184044,
"heapUsedBytes": 87680084,
"domNodes": -218,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 11.232000000000003,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.8810000000212,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3830000000000005,
"layouts": 9,
"layoutDurationMs": 3.3080000000000003,
"taskDurationMs": 486.701,
"heapDeltaBytes": 894440,
"heapUsedBytes": 92487932,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 13.188000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.8340000000148,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.615,
"layouts": 10,
"layoutDurationMs": 2.9250000000000007,
"taskDurationMs": 857.3720000000001,
"heapDeltaBytes": 14954464,
"heapUsedBytes": 106205456,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 111.25900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.9650000000029,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.425,
"layouts": 9,
"layoutDurationMs": 2.6879999999999997,
"taskDurationMs": 786.1049999999999,
"heapDeltaBytes": -4097008,
"heapUsedBytes": 85853836,
"domNodes": -210,
"jsHeapTotalBytes": 589824,
"scriptDurationMs": 113.312,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1455.6890000000067,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.611,
"layouts": 5,
"layoutDurationMs": 12.934999999999999,
"taskDurationMs": 1171.337,
"heapDeltaBytes": 14163556,
"heapUsedBytes": 143163416,
"domNodes": 16030,
"jsHeapTotalBytes": 13246464,
"scriptDurationMs": 34.068999999999996,
"eventListeners": 3244,
"totalBlockingTimeMs": 142,
"frameDurationMs": 19.82027027027028,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11499.090000000024,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.563,
"layouts": 6,
"layoutDurationMs": 1.8230000000000004,
"taskDurationMs": 6381.487,
"heapDeltaBytes": 3072988,
"heapUsedBytes": 104698248,
"domNodes": -296,
"jsHeapTotalBytes": -1314816,
"scriptDurationMs": 2818.084,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69013062409289,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10599.542000000041,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.215999999999994,
"layouts": 8,
"layoutDurationMs": 2.169,
"taskDurationMs": 6175.442,
"heapDeltaBytes": -19750640,
"heapUsedBytes": 100829752,
"domNodes": -296,
"jsHeapTotalBytes": 585728,
"scriptDurationMs": 2710.8309999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16887.259000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16397.565,
"heapDeltaBytes": -17344144,
"heapUsedBytes": 288530868,
"domNodes": -3344,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 268.07,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.72306338028169,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 22942.219000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22242.665,
"heapDeltaBytes": -37754340,
"heapUsedBytes": 282216984,
"domNodes": -307,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 330.774,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.94479717813051,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 28787.02000000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 25.76300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28417.037,
"heapDeltaBytes": -21032356,
"heapUsedBytes": 302910284,
"domNodes": -3344,
"jsHeapTotalBytes": 6471680,
"scriptDurationMs": 909.022,
"eventListeners": -651,
"totalBlockingTimeMs": 54,
"frameDurationMs": 54.511553030303034,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 20664.424999999937,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.006999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20332.674,
"heapDeltaBytes": -25797752,
"heapUsedBytes": 285327356,
"domNodes": -3344,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 919.106,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 39.21404174573055,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 8568.502000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.43400000000002,
"layouts": 20,
"layoutDurationMs": 27.828000000000007,
"taskDurationMs": 8512.787,
"heapDeltaBytes": -66533204,
"heapUsedBytes": 264224900,
"domNodes": -3344,
"jsHeapTotalBytes": 3919872,
"scriptDurationMs": 152.098,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 51.60421686746987,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6206.483000000048,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.034000000000006,
"layouts": 20,
"layoutDurationMs": 24.67699999999999,
"taskDurationMs": 6104.661000000001,
"heapDeltaBytes": -27702104,
"heapUsedBytes": 291910260,
"domNodes": -3344,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 109.792,
"eventListeners": -653,
"totalBlockingTimeMs": 20,
"frameDurationMs": 34.830337078651695,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8540.42000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8276.645000000002,
"heapDeltaBytes": 19010736,
"heapUsedBytes": 293658348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.39400000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.27979452054795,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8355.024999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8043.245000000001,
"heapDeltaBytes": -8982304,
"heapUsedBytes": 280961148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.76699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.208108108108103,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 123.89500000000453,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.504,
"layouts": 8,
"layoutDurationMs": 3.6399999999999997,
"taskDurationMs": 94.21799999999999,
"heapDeltaBytes": 4723564,
"heapUsedBytes": 94348352,
"domNodes": 116,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.719999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 475.8289999999761,
"styleRecalcs": 14,
"styleRecalcDurationMs": 11.068999999999999,
"layouts": 12,
"layoutDurationMs": 4.494000000000001,
"taskDurationMs": 120.43099999999998,
"heapDeltaBytes": -17370752,
"heapUsedBytes": 92631760,
"domNodes": 95,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 10.586,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 513.1150000000844,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.743,
"layouts": 76,
"layoutDurationMs": 17.579,
"taskDurationMs": 454.16200000000003,
"heapDeltaBytes": 11606364,
"heapUsedBytes": 82258028,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 207.538,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 496.9790000000103,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.733,
"layouts": 76,
"layoutDurationMs": 16.363,
"taskDurationMs": 453.718,
"heapDeltaBytes": -13753400,
"heapUsedBytes": 81829276,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 217.35999999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 592.9059999999708,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.678,
"layouts": 76,
"layoutDurationMs": 16.423000000000002,
"taskDurationMs": 550.817,
"heapDeltaBytes": 695968,
"heapUsedBytes": 118468876,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 215.76199999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13999999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 591.4869999999155,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.384,
"layouts": 76,
"layoutDurationMs": 15.2,
"taskDurationMs": 545.086,
"heapDeltaBytes": 1182292,
"heapUsedBytes": 118228768,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 218.921,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2986 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b57aa3b2726f95b7b4711b02e32b8b00bf8b7902
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (135)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.58 #22308 +/- ##
=============================================
Coverage ? 84.21%
=============================================
Files ? 3172
Lines ? 165261
Branches ? 41452
=============================================
Hits ? 139168
Misses ? 25702
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #21592 to
cloud/1.58(auto-backport hit conflicts).Full context for agent readers
Cherry-pick of cef6e2f. Resolutions:
@comfyorg/telemetryimports mapped back to@/platform/telemetry(+reportErrorfrom@/platform/telemetry/reportError; the loading test mocks that module explicitly).startTeamWorkspaceUpgradeFlowkeeps this branch'suseWorkspaceDialogs().showTeamWorkspacesDialogand only gainsvoid showPricingTable().src/composables/billing/,src/platform/cloud/subscription/,src/platform/errorCatalog/,src/platform/workspace/components/); new and changed imports and test mocks mapped to them. This is the branch Cloud production serves today (frontend 1.58.0).Tracking: https://linear.app/comfyorg/issue/PM-2273