Repository navigation
[backport core/1.59] fix(agent): refresh billing after Agree from the top bar or first load (#22287) - #22300
Conversation
… top bar or first load (#22287) - Agree from the top-bar Agent button (or the automatic first-load prompt with the panel closed) now re-reads billing, so the Local free-use notice shows for the first chat. - Follow-up to #22032: its refresh lived in the panel, which doesn't exist yet when these consent paths finish. - Reloading an already-saved consent does not add a billing read. Linear: https://linear.app/comfyorg/issue/PM-2398/refresh-billing-after-agent-consent-from-the-top-bar-or-first-load <details><summary>Full context for agent readers</summary> **Root cause.** `AgentPanelRoot` mounts only while `DockedAgentPanel` is docked. `TopbarActions.vue` runs `withConsent('button_click', () => agentPanelStore.open())` and `agentPanel.ts` runs `withConsent('first_load', ...)` then opens, so the accepted transition happens before the panel's watcher exists. `useBillingContext` is shared and kept alive by `useAgentDockMount` on `GraphCanvas`, so the pre-consent status read is never replaced until a turn completes. **Change.** - `agentConsentStore` counts confirmed `accept()` writes (`acceptances`). `load()` of a stored acceptance does not count, and a write that lands after the identity changed does not count. - `useAgentDockMount` (persistent graph/linear host) calls billing `fetchStatus` once per new acceptance, sync flush, so it starts before `withConsent`'s `onAccept` runs (same ordering as before). Failures go to `reportError` with the existing `error_refreshing_agent_billing_status` type. - `agentPanelStore.billingRefreshedAcceptances` dedupes the two hosts that coexist in linear mode (`GraphView` mounts `GraphCanvas` and `LinearView` together). - The panel watcher from #22032 is removed; its test is rewritten to assert the panel no longer reads on first send. **Review.** Independent adversarial pass (fresh Claude reviewer; Codex unavailable on this host) on a first draft flagged that watching `accepted` fired on every reload of stored consent and twice in linear mode, and that an identity-change branch was unreachable. All three are addressed by counting confirmed writes and the dedupe marker. **Verification.** - New tests red before the fix, green after: `useAgentDockMount.test.ts` (closed-panel acceptance, stored-consent load is ignored, two hosts read once, failure reported), `agentConsentStore.test.ts` (counts writes not loads; ignores a write that resolves after an account change). - `src/workbench/extensions/agent`, `src/components/graph`, `src/views`, `src/extensions/core`: 6134 passed; 2 load-dependent failures pass in isolation and on the base commit. - `pnpm typecheck:app` and oxlint pass. - Not covered locally: browser run of top-bar Agree on Local. Requested as runtime QA. **Backports.** `core/1.59`, `cloud/1.59`, matching #22032 (carried by </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Alexander Brown <DrJKL0424@gmail.com> (cherry picked from commit 3f85554)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T21:48:56.176Z",
"gitSha": "33c7c9b4fbef7a4dea27da6844017501b104d797",
"branch": "backport-22287-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.8200000000243,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8729999999999998,
"layouts": 8,
"layoutDurationMs": 2.9470000000000005,
"taskDurationMs": 609.099,
"heapDeltaBytes": 3791072,
"heapUsedBytes": 64387156,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 13.155,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2041.0359999999628,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3449999999999998,
"layouts": 9,
"layoutDurationMs": 2.9589999999999996,
"taskDurationMs": 621.507,
"heapDeltaBytes": 5224320,
"heapUsedBytes": 75075540,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 13.194,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.9450000000115,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.201000000000002,
"layouts": 10,
"layoutDurationMs": 3.122,
"taskDurationMs": 962.066,
"heapDeltaBytes": 21764976,
"heapUsedBytes": 83235388,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 173.706,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637168141593,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.9879999999775,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.342999999999998,
"layouts": 8,
"layoutDurationMs": 2.3570000000000007,
"taskDurationMs": 956.073,
"heapDeltaBytes": 23543860,
"heapUsedBytes": 84622584,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 175.60600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.637999999979,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.871999999999999,
"layouts": 9,
"layoutDurationMs": 3.3669999999999995,
"taskDurationMs": 474.122,
"heapDeltaBytes": 23573752,
"heapUsedBytes": 84357364,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 15.011999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1319999999778,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.269,
"layouts": 10,
"layoutDurationMs": 3.4239999999999995,
"taskDurationMs": 471.66799999999995,
"heapDeltaBytes": 472928,
"heapUsedBytes": 70734452,
"domNodes": 56,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 14.213000000000003,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 752.189000000044,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.8189999999999995,
"layouts": 8,
"layoutDurationMs": 2.455,
"taskDurationMs": 544.362,
"heapDeltaBytes": 5694424,
"heapUsedBytes": 66303640,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 179.72299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 758.6279999999306,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.289,
"layouts": 9,
"layoutDurationMs": 3.1339999999999995,
"taskDurationMs": 529.996,
"heapDeltaBytes": 7199092,
"heapUsedBytes": 77413600,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 173.883,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444445,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1305.2869999999643,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1037.312,
"heapDeltaBytes": -12527460,
"heapUsedBytes": 74956152,
"domNodes": -191,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 80.64299999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 601,
"frameDurationMs": 35.13243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1234.324000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 963.4549999999999,
"heapDeltaBytes": -2004620,
"heapUsedBytes": 75037408,
"domNodes": -191,
"jsHeapTotalBytes": 12853248,
"scriptDurationMs": 72.16499999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 554,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 876.1460000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.2739999999999,
"heapDeltaBytes": -3491676,
"heapUsedBytes": 67200084,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 184.51300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.23999999999999,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 891.8210000000499,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.0960000000001,
"heapDeltaBytes": -27221600,
"heapUsedBytes": 66338692,
"domNodes": -191,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 175.861,
"eventListeners": -106,
"totalBlockingTimeMs": 235,
"frameDurationMs": 24.997222222222213,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11883.105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10986.309000000001,
"heapDeltaBytes": -9831492,
"heapUsedBytes": 78780496,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 8903.987000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1810,
"frameDurationMs": 32.73526170798898,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11362.04200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10535.261,
"heapDeltaBytes": 83474960,
"heapUsedBytes": 156700680,
"domNodes": -257,
"jsHeapTotalBytes": 77197312,
"scriptDurationMs": 8512.68,
"eventListeners": -68,
"totalBlockingTimeMs": 1288,
"frameDurationMs": 31.702513966480446,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11823.421999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11026.966,
"heapDeltaBytes": 63720724,
"heapUsedBytes": 137568980,
"domNodes": -257,
"jsHeapTotalBytes": 71430144,
"scriptDurationMs": 8850.82,
"eventListeners": -68,
"totalBlockingTimeMs": 1595,
"frameDurationMs": 32.196457765667574,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11436.003000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10691.376999999999,
"heapDeltaBytes": 66574612,
"heapUsedBytes": 139501180,
"domNodes": -257,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 8582.22,
"eventListeners": -68,
"totalBlockingTimeMs": 1537,
"frameDurationMs": 31.935474860335198,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 255.41100000000938,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.014,
"layouts": 11,
"layoutDurationMs": 4.222,
"taskDurationMs": 202.966,
"heapDeltaBytes": 14434972,
"heapUsedBytes": 90016840,
"domNodes": 936,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 11.59,
"eventListeners": 205,
"totalBlockingTimeMs": 8,
"frameDurationMs": 26.660000000000036,
"p95FrameDurationMs": 116.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 274.92099999994934,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.354000000000001,
"layouts": 8,
"layoutDurationMs": 4.491000000000001,
"taskDurationMs": 230.418,
"heapDeltaBytes": 2565864,
"heapUsedBytes": 72936304,
"domNodes": 721,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 10.43,
"eventListeners": 73,
"totalBlockingTimeMs": 9,
"frameDurationMs": 24.24545454545453,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2056.9810000000075,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4469999999999996,
"layouts": 7,
"layoutDurationMs": 2.2849999999999997,
"taskDurationMs": 742.998,
"heapDeltaBytes": -10016148,
"heapUsedBytes": 64337580,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 38.12799999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.938999999943,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1189999999999993,
"layouts": 9,
"layoutDurationMs": 2.583,
"taskDurationMs": 719.3519999999999,
"heapDeltaBytes": -11555476,
"heapUsedBytes": 63049668,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.645,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2616.847000000007,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.892000000000001,
"layouts": 7,
"layoutDurationMs": 1.6590000000000003,
"taskDurationMs": 1761.7450000000001,
"heapDeltaBytes": -12153916,
"heapUsedBytes": 79894416,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 868.5189999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.773076923076925,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2565.2860000000146,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.962000000000002,
"layouts": 7,
"layoutDurationMs": 2.2600000000000002,
"taskDurationMs": 1793.6190000000001,
"heapDeltaBytes": 7986512,
"heapUsedBytes": 85597276,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 881.034,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774509803921568,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4057.8820000000064,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.743,
"layouts": 64,
"layoutDurationMs": 11.27,
"taskDurationMs": 2003.6070000000002,
"heapDeltaBytes": -18280616,
"heapUsedBytes": 60747752,
"domNodes": -233,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 860.552,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399176,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3837.7160000000003,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.087,
"layouts": 65,
"layoutDurationMs": 12.272,
"taskDurationMs": 1876.732,
"heapDeltaBytes": 5722888,
"heapUsedBytes": 86288088,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 838.373,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666086956521738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3155.574999999999,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.632,
"layouts": 5,
"layoutDurationMs": 1.4259999999999997,
"taskDurationMs": 2124.9089999999997,
"heapDeltaBytes": 21994424,
"heapUsedBytes": 102323868,
"domNodes": 0,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 1039.534,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.842328042328045,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3216.874999999959,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.862,
"layouts": 5,
"layoutDurationMs": 1.435,
"taskDurationMs": 2100.154,
"heapDeltaBytes": -2324704,
"heapUsedBytes": 70452916,
"domNodes": 0,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 1016.5550000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 21,
"frameDurationMs": 16.928272251308897,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3205.657000000002,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6819999999999995,
"layouts": 5,
"layoutDurationMs": 1.4500000000000004,
"taskDurationMs": 875.8280000000001,
"heapDeltaBytes": 3038712,
"heapUsedBytes": 81494312,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 399.134,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614583333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3082.6979999999367,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6920000000000008,
"layouts": 6,
"layoutDurationMs": 1.4289999999999998,
"taskDurationMs": 838.459,
"heapDeltaBytes": 213568,
"heapUsedBytes": 80225496,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 377.836,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.7649999999508,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.0740000000000003,
"layouts": 6,
"layoutDurationMs": 1.9939999999999998,
"taskDurationMs": 732.4879999999999,
"heapDeltaBytes": -13887264,
"heapUsedBytes": 63081612,
"domNodes": -277,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 37.37,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2061.417000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8520000000000003,
"layouts": 9,
"layoutDurationMs": 2.9619999999999993,
"taskDurationMs": 799.619,
"heapDeltaBytes": 5689392,
"heapUsedBytes": 85838240,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 38.94799999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 3032.8850000000216,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.449,
"layouts": 6,
"layoutDurationMs": 1.742,
"taskDurationMs": 725.4000000000001,
"heapDeltaBytes": -16466340,
"heapUsedBytes": 75986468,
"domNodes": -252,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 227.576,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2903.04900000001,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.968,
"layouts": 6,
"layoutDurationMs": 1.6479999999999997,
"taskDurationMs": 668.897,
"heapDeltaBytes": 146088,
"heapUsedBytes": 80668356,
"domNodes": -244,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 212.62599999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3398.202999999995,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7370000000000008,
"layouts": 6,
"layoutDurationMs": 2.0650000000000004,
"taskDurationMs": 1013.5730000000001,
"heapDeltaBytes": 2134112,
"heapUsedBytes": 77973228,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 413.419,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.831188118811884,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3359.47699999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9160000000000001,
"layouts": 6,
"layoutDurationMs": 1.7260000000000002,
"taskDurationMs": 1028.7799999999997,
"heapDeltaBytes": -13873308,
"heapUsedBytes": 62960364,
"domNodes": -277,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 400.84200000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7495,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 664.400999999998,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.691,
"layouts": 9,
"layoutDurationMs": 2.872,
"taskDurationMs": 484.06899999999996,
"heapDeltaBytes": -1812556,
"heapUsedBytes": 60508784,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 154.68400000000003,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 675.3660000000536,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.545,
"layouts": 9,
"layoutDurationMs": 2.8790000000000004,
"taskDurationMs": 470.75,
"heapDeltaBytes": -844804,
"heapUsedBytes": 60827636,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 152.90099999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.469000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.366000000000001,
"layouts": 9,
"layoutDurationMs": 3.032,
"taskDurationMs": 675.367,
"heapDeltaBytes": 1709540,
"heapUsedBytes": 63848052,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.8429999999662,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.109000000000001,
"layouts": 9,
"layoutDurationMs": 3.089,
"taskDurationMs": 609.246,
"heapDeltaBytes": 5638112,
"heapUsedBytes": 77422932,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 12.331000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.107999999997,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.521,
"layouts": 9,
"layoutDurationMs": 2.782,
"taskDurationMs": 917.5909999999999,
"heapDeltaBytes": 18736928,
"heapUsedBytes": 80833704,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 122.64,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.8100000000086,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.695,
"layouts": 8,
"layoutDurationMs": 2.562,
"taskDurationMs": 897.5360000000001,
"heapDeltaBytes": 18617744,
"heapUsedBytes": 80472648,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 121.093,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1486.7350000000101,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.213000000000005,
"layouts": 5,
"layoutDurationMs": 15.526000000000002,
"taskDurationMs": 1198.1299999999999,
"heapDeltaBytes": 11846192,
"heapUsedBytes": 87368448,
"domNodes": 16030,
"jsHeapTotalBytes": 14028800,
"scriptDurationMs": 36.010000000000005,
"eventListeners": 3246,
"totalBlockingTimeMs": 178,
"frameDurationMs": 20.27027027027027,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 10838.858999999957,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.510999999999996,
"layouts": 7,
"layoutDurationMs": 1.9369999999999998,
"taskDurationMs": 6578.42,
"heapDeltaBytes": 2217892,
"heapUsedBytes": 76605304,
"domNodes": -257,
"jsHeapTotalBytes": 4775936,
"scriptDurationMs": 2979.746,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10158.751999999935,
"styleRecalcs": 251,
"styleRecalcDurationMs": 30.556,
"layouts": 9,
"layoutDurationMs": 2.265,
"taskDurationMs": 6301.267,
"heapDeltaBytes": -30172244,
"heapUsedBytes": 61198700,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 2816.9600000000005,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69325657894737,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 24678.07099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23888.759000000002,
"heapDeltaBytes": -2646504,
"heapUsedBytes": 274204056,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 363.667,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.27298245614035,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23650.479000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23200.059,
"heapDeltaBytes": -22189132,
"heapUsedBytes": 260339712,
"domNodes": -3343,
"jsHeapTotalBytes": 11526144,
"scriptDurationMs": 358.179,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.53321616871705,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 29284.32399999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.232000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28994.350000000006,
"heapDeltaBytes": -27866344,
"heapUsedBytes": 263111640,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 936.59,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 55.11393596986818,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 29000.878000000055,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.749999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28656.148,
"heapDeltaBytes": -1748004,
"heapUsedBytes": 271511876,
"domNodes": -3343,
"jsHeapTotalBytes": 11788288,
"scriptDurationMs": 923.723,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 55.76692307692308,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 8788.363000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.16899999999998,
"layouts": 20,
"layoutDurationMs": 23.907999999999983,
"taskDurationMs": 8698.687,
"heapDeltaBytes": -21870340,
"heapUsedBytes": 269839884,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 134.27100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 52.06863905325445,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8607.896999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.60700000000001,
"layouts": 20,
"layoutDurationMs": 35.39200000000001,
"taskDurationMs": 8497.078000000001,
"heapDeltaBytes": -17470388,
"heapUsedBytes": 255915524,
"domNodes": -3343,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 131.04500000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.42044198895028,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12190.04000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11906.962,
"heapDeltaBytes": -4950240,
"heapUsedBytes": 267038432,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 174.25400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.665090909090914,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11633.93899999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11408.590999999999,
"heapDeltaBytes": -22929636,
"heapUsedBytes": 254316648,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.20099999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.53240418118468,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 129.67800000001262,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.776,
"layouts": 9,
"layoutDurationMs": 4.279,
"taskDurationMs": 99.118,
"heapDeltaBytes": 4764404,
"heapUsedBytes": 72631456,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.482,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 181.47399999998015,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.359,
"layouts": 11,
"layoutDurationMs": 4.915,
"taskDurationMs": 109.023,
"heapDeltaBytes": 4722832,
"heapUsedBytes": 65344508,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.015000000000002,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 578.8179999999556,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.699,
"layouts": 76,
"layoutDurationMs": 15.831999999999999,
"taskDurationMs": 528.44,
"heapDeltaBytes": -3245632,
"heapUsedBytes": 41603636,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 259.711,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 546.0520000000315,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.731,
"layouts": 76,
"layoutDurationMs": 16.802999999999997,
"taskDurationMs": 502.85100000000006,
"heapDeltaBytes": -3868252,
"heapUsedBytes": 40021636,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 235.578,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 627.3669999999356,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.326,
"layouts": 76,
"layoutDurationMs": 16.814,
"taskDurationMs": 585.3470000000001,
"heapDeltaBytes": 1880808,
"heapUsedBytes": 103137016,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 233.724,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.116216216216195,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 582.3789999999462,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.196,
"layouts": 76,
"layoutDurationMs": 15.611,
"taskDurationMs": 547.5400000000001,
"heapDeltaBytes": 1455192,
"heapUsedBytes": 99749100,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 216.85199999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3119 passed, 0 failed · 5 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 56bcf7c9f4a9ff27d71eccc670c4cf19c53b7213
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22300 +/- ##
==========================================
Coverage 87.11% 87.12%
==========================================
Files 3027 3027
Lines 158487 158494 +7
Branches 42267 42267
==========================================
+ Hits 138064 138081 +17
+ Misses 19747 19737 -10
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed this exact core/1.59 backport, including the persistent graph/linear hosts, confirmed consent writes, identity guards, shared refresh watermark, and the parent PR's resolved/outdated discussions. The refresh now survives a closed panel, handles acceptance before host mount, and avoids duplicate reads from two mounted hosts. Existing stored consent does not manufacture a new acceptance. The release branch's telemetry import is correct.
Own validation in this checkout with its own frozen install: 588 tests across AgentPanelRoot, useAgentDockMount and agentConsentStore PASS; app typecheck and scoped lint/format checks PASS. Five independent negative controls each fail the relevant retained regression: removing the watcher, confirmation increment, host deduplication, immediate observation, or stale-identity guard. Restored focused tests: 31 PASS. All seven changed files match the sibling backport.
The parent discussion's in-flight billing coalescing concern is pre-existing and tracked separately; I found no new contract, identity, or refresh regression introduced by this backport. No blocking code findings.
…e top bar or first load (#22287) (#22301) Backport of #22287 to `cloud/1.59`. - Same fix: Agree from the top bar or first load re-reads billing, so the Local free-use notice shows for the first chat. - Conflict only in `useAgentDockMount.test.ts` imports: 1.59 uses `@/platform/telemetry`, so `reportError` imports use `@/platform/telemetry/reportError` here. <details><summary>Full context for agent readers</summary> Clean cherry-pick -x of the core/1.59 backport (#22300); all 7 touched files are identical between core/1.59 and cloud/1.59. Verified on this branch: dock, consent store and AgentPanelRoot unit suites pass (cold-import hook timeouts pass on rerun); `pnpm typecheck:app` passes. </details> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Alexander Brown <DrJKL0424@gmail.com>
Backport of #22287 to
core/1.59.useAgentDockMount.test.tsimports: 1.59 uses@/platform/telemetry, soreportErrorimports use@/platform/telemetry/reportErrorhere.Full context for agent readers
Cherry-pick -x of 3f85554. Verified on this branch: dock, consent store and AgentPanelRoot unit suites pass (cold-import hook timeouts pass on rerun);
pnpm typecheck:apppasses.