Repository navigation
[backport cloud/1.59] fix(agent): refresh billing after Agree from the top bar or first load (#22287) - #22301
Conversation
…e top bar or first load (#22287) - Agree from the top-bar Agent button (or the automatic first-load prompt with the panel closed) now re-reads billing, so the Local free-use notice shows for the first chat. - Follow-up to #22032: its refresh lived in the panel, which doesn't exist yet when these consent paths finish. - Reloading an already-saved consent does not add a billing read. Linear: https://linear.app/comfyorg/issue/PM-2398/refresh-billing-after-agent-consent-from-the-top-bar-or-first-load <details><summary>Full context for agent readers</summary> **Root cause.** `AgentPanelRoot` mounts only while `DockedAgentPanel` is docked. `TopbarActions.vue` runs `withConsent('button_click', () => agentPanelStore.open())` and `agentPanel.ts` runs `withConsent('first_load', ...)` then opens, so the accepted transition happens before the panel's watcher exists. `useBillingContext` is shared and kept alive by `useAgentDockMount` on `GraphCanvas`, so the pre-consent status read is never replaced until a turn completes. **Change.** - `agentConsentStore` counts confirmed `accept()` writes (`acceptances`). `load()` of a stored acceptance does not count, and a write that lands after the identity changed does not count. - `useAgentDockMount` (persistent graph/linear host) calls billing `fetchStatus` once per new acceptance, sync flush, so it starts before `withConsent`'s `onAccept` runs (same ordering as before). Failures go to `reportError` with the existing `error_refreshing_agent_billing_status` type. - `agentPanelStore.billingRefreshedAcceptances` dedupes the two hosts that coexist in linear mode (`GraphView` mounts `GraphCanvas` and `LinearView` together). - The panel watcher from #22032 is removed; its test is rewritten to assert the panel no longer reads on first send. **Review.** Independent adversarial pass (fresh Claude reviewer; Codex unavailable on this host) on a first draft flagged that watching `accepted` fired on every reload of stored consent and twice in linear mode, and that an identity-change branch was unreachable. All three are addressed by counting confirmed writes and the dedupe marker. **Verification.** - New tests red before the fix, green after: `useAgentDockMount.test.ts` (closed-panel acceptance, stored-consent load is ignored, two hosts read once, failure reported), `agentConsentStore.test.ts` (counts writes not loads; ignores a write that resolves after an account change). - `src/workbench/extensions/agent`, `src/components/graph`, `src/views`, `src/extensions/core`: 6134 passed; 2 load-dependent failures pass in isolation and on the base commit. - `pnpm typecheck:app` and oxlint pass. - Not covered locally: browser run of top-bar Agree on Local. Requested as runtime QA. **Backports.** `core/1.59`, `cloud/1.59`, matching #22032 (carried by </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Alexander Brown <DrJKL0424@gmail.com> (cherry picked from commit 3f85554) (cherry picked from commit f149ff5)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T21:48:33.223Z",
"gitSha": "234daadae813e0b169aefe99d7b0fa11694e8947",
"branch": "backport-22287-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.8820000000096,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.928,
"layouts": 8,
"layoutDurationMs": 2.1189999999999998,
"taskDurationMs": 501.74999999999994,
"heapDeltaBytes": 1513756,
"heapUsedBytes": 62553052,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.307000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.5960000000214,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.119,
"layouts": 9,
"layoutDurationMs": 2.276,
"taskDurationMs": 494.92,
"heapDeltaBytes": 3114448,
"heapUsedBytes": 64308328,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8.594999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.249999999999,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.751000000000001,
"layouts": 9,
"layoutDurationMs": 2.2600000000000002,
"taskDurationMs": 855.37,
"heapDeltaBytes": -1744688,
"heapUsedBytes": 67934448,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 156.432,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.65599999995,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.884,
"layouts": 8,
"layoutDurationMs": 2.0969999999999995,
"taskDurationMs": 836.736,
"heapDeltaBytes": 21288724,
"heapUsedBytes": 82619224,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 154.29800000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.6649999999772,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.284,
"layouts": 10,
"layoutDurationMs": 2.4999999999999996,
"taskDurationMs": 381.82899999999995,
"heapDeltaBytes": 24100308,
"heapUsedBytes": 85191348,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.989,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9869999999755,
"styleRecalcs": 19,
"styleRecalcDurationMs": 7.535,
"layouts": 10,
"layoutDurationMs": 2.515,
"taskDurationMs": 396.71299999999997,
"heapDeltaBytes": -1037020,
"heapUsedBytes": 60264264,
"domNodes": 56,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 9.665999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 659.0980000000286,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8019999999999996,
"layouts": 9,
"layoutDurationMs": 2.7190000000000003,
"taskDurationMs": 487.511,
"heapDeltaBytes": 3863424,
"heapUsedBytes": 65650188,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 172.82,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.2630000000627,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6980000000000004,
"layouts": 10,
"layoutDurationMs": 2.679,
"taskDurationMs": 506.60800000000006,
"heapDeltaBytes": 6613640,
"heapUsedBytes": 76987172,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 178.13199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.4010000000467,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 883.29,
"heapDeltaBytes": -12150008,
"heapUsedBytes": 75066256,
"domNodes": -191,
"jsHeapTotalBytes": 19406848,
"scriptDurationMs": 66.57199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 518,
"frameDurationMs": 32.43243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.4670000000742,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 890.9540000000002,
"heapDeltaBytes": -13488128,
"heapUsedBytes": 75449244,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 72.177,
"eventListeners": -106,
"totalBlockingTimeMs": 513,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 928.9029999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.9210000000005,
"heapDeltaBytes": -15078032,
"heapUsedBytes": 65924136,
"domNodes": -191,
"jsHeapTotalBytes": 1703936,
"scriptDurationMs": 167.806,
"eventListeners": -106,
"totalBlockingTimeMs": 247,
"frameDurationMs": 25.22432432432433,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 878.6610000000792,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.8210000000001,
"heapDeltaBytes": -14072912,
"heapUsedBytes": 66006260,
"domNodes": -191,
"jsHeapTotalBytes": 1179648,
"scriptDurationMs": 166.22800000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.53611111111109,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10986.703000000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.040000000000000105,
"layouts": 1,
"layoutDurationMs": 0.24600000000000014,
"taskDurationMs": 10192.608999999999,
"heapDeltaBytes": -19649492,
"heapUsedBytes": 69099976,
"domNodes": -257,
"jsHeapTotalBytes": 9039872,
"scriptDurationMs": 8322.163,
"eventListeners": -68,
"totalBlockingTimeMs": 1332,
"frameDurationMs": 32.16588921282799,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10090.485999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9213.273,
"heapDeltaBytes": 102272,
"heapUsedBytes": 88974724,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7476.676,
"eventListeners": -68,
"totalBlockingTimeMs": 722,
"frameDurationMs": 31.411214953271028,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11184.649000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10478.729,
"heapDeltaBytes": 73184820,
"heapUsedBytes": 147162792,
"domNodes": -257,
"jsHeapTotalBytes": 79818752,
"scriptDurationMs": 8573.787,
"eventListeners": -68,
"totalBlockingTimeMs": 1335,
"frameDurationMs": 32.04269340974212,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9808.491000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03199999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9054.012999999999,
"heapDeltaBytes": 62843968,
"heapUsedBytes": 136201356,
"domNodes": -257,
"jsHeapTotalBytes": 58585088,
"scriptDurationMs": 7265.928,
"eventListeners": -68,
"totalBlockingTimeMs": 720,
"frameDurationMs": 31.509967845659165,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 258.8880000000131,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.773,
"layouts": 10,
"layoutDurationMs": 2.8890000000000007,
"taskDurationMs": 215.097,
"heapDeltaBytes": 14444084,
"heapUsedBytes": 89355604,
"domNodes": 936,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 8.62,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.216666666666697,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 252.11899999999332,
"styleRecalcs": 24,
"styleRecalcDurationMs": 12.152,
"layouts": 13,
"layoutDurationMs": 3.411,
"taskDurationMs": 212.66499999999996,
"heapDeltaBytes": -1175188,
"heapUsedBytes": 68245892,
"domNodes": -2315,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.421999999999999,
"eventListeners": -573,
"totalBlockingTimeMs": 4,
"frameDurationMs": 24.99000000000001,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2023.699000000022,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1010000000000004,
"layouts": 9,
"layoutDurationMs": 2.354,
"taskDurationMs": 624.2570000000001,
"heapDeltaBytes": -4466048,
"heapUsedBytes": 72566596,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 31.091,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.246999999932,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.0429999999999997,
"layouts": 8,
"layoutDurationMs": 2.057,
"taskDurationMs": 617.3059999999999,
"heapDeltaBytes": -14287952,
"heapUsedBytes": 63418072,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 30.02699999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2336.874000000023,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.657000000000001,
"layouts": 6,
"layoutDurationMs": 1.437,
"taskDurationMs": 1644.8799999999999,
"heapDeltaBytes": 5559944,
"heapUsedBytes": 81099940,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 811.289,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2313.0910000000995,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.081000000000001,
"layouts": 9,
"layoutDurationMs": 2.018,
"taskDurationMs": 1652.705,
"heapDeltaBytes": 5181460,
"heapUsedBytes": 80719276,
"domNodes": -257,
"jsHeapTotalBytes": 5857280,
"scriptDurationMs": 810.191,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786231884057973,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3770.5949999999575,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.722000000000001,
"layouts": 64,
"layoutDurationMs": 10.196,
"taskDurationMs": 1771.6090000000002,
"heapDeltaBytes": -5109248,
"heapUsedBytes": 74864836,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 780.391,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3543.684999999982,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.979999999999999,
"layouts": 65,
"layoutDurationMs": 10.416,
"taskDurationMs": 1678.97,
"heapDeltaBytes": 1174444,
"heapUsedBytes": 73263564,
"domNodes": 24,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 759.781,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3056.9810000000075,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.133999999999999,
"layouts": 6,
"layoutDurationMs": 1.519,
"taskDurationMs": 1911.172,
"heapDeltaBytes": 7164672,
"heapUsedBytes": 79523524,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 953.5849999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092894,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2933.6000000000695,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.835000000000001,
"layouts": 5,
"layoutDurationMs": 1.2029999999999996,
"taskDurationMs": 1922.247,
"heapDeltaBytes": 17479900,
"heapUsedBytes": 90150664,
"domNodes": 0,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 980.24,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858045977011496,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3052.144999999996,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.582,
"layouts": 7,
"layoutDurationMs": 1.4059999999999997,
"taskDurationMs": 771.4860000000001,
"heapDeltaBytes": -17706520,
"heapUsedBytes": 75420088,
"domNodes": -257,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 368.90900000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3086.8310000000747,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.802999999999999,
"layouts": 7,
"layoutDurationMs": 1.855,
"taskDurationMs": 780.451,
"heapDeltaBytes": 8866172,
"heapUsedBytes": 85462432,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 362.596,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.1769999999765,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.6550000000000002,
"layouts": 8,
"layoutDurationMs": 1.9369999999999998,
"taskDurationMs": 598.779,
"heapDeltaBytes": -11336772,
"heapUsedBytes": 65577652,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 28.915000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.4199999999882,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9779999999999998,
"layouts": 7,
"layoutDurationMs": 2.0120000000000005,
"taskDurationMs": 624.5450000000001,
"heapDeltaBytes": -22569016,
"heapUsedBytes": 70044672,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 32.45000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2926.4060000000145,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.512999999999998,
"layouts": 6,
"layoutDurationMs": 1.2229999999999996,
"taskDurationMs": 628.4790000000002,
"heapDeltaBytes": -4927632,
"heapUsedBytes": 72302076,
"domNodes": -254,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 197.12199999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76149425287356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2878.4409999999525,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.171000000000001,
"layouts": 8,
"layoutDurationMs": 1.8460000000000005,
"taskDurationMs": 583.6850000000001,
"heapDeltaBytes": -5635096,
"heapUsedBytes": 72878464,
"domNodes": -246,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 184.075,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665697674418606,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3202.448000000004,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.4460000000000002,
"layouts": 6,
"layoutDurationMs": 1.4809999999999997,
"taskDurationMs": 894.9110000000002,
"heapDeltaBytes": -2464124,
"heapUsedBytes": 74076904,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 349.56100000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3273.2540000000654,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8330000000000004,
"layouts": 7,
"layoutDurationMs": 1.539,
"taskDurationMs": 925.6339999999999,
"heapDeltaBytes": -2188744,
"heapUsedBytes": 76702412,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 388.429,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.1820000000262,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.509,
"layouts": 10,
"layoutDurationMs": 2.872,
"taskDurationMs": 430.05899999999997,
"heapDeltaBytes": -1449476,
"heapUsedBytes": 60621584,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 141.764,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.9689999999446,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.184,
"layouts": 8,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 433.30999999999995,
"heapDeltaBytes": -1759724,
"heapUsedBytes": 60660292,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 145.341,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.2209999999586,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2330000000000005,
"layouts": 9,
"layoutDurationMs": 2.4699999999999998,
"taskDurationMs": 504.10999999999996,
"heapDeltaBytes": 5486908,
"heapUsedBytes": 78047624,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 8.418999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.483000000093,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.864,
"layouts": 8,
"layoutDurationMs": 2.046,
"taskDurationMs": 500.246,
"heapDeltaBytes": 1812356,
"heapUsedBytes": 63867408,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 7.132999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.1409999999746,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.997,
"layouts": 9,
"layoutDurationMs": 2.1460000000000004,
"taskDurationMs": 793.009,
"heapDeltaBytes": 17049372,
"heapUsedBytes": 79478496,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 101.83300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4410000000698,
"styleRecalcs": 77,
"styleRecalcDurationMs": 11.851,
"layouts": 10,
"layoutDurationMs": 2.6409999999999996,
"taskDurationMs": 777.4140000000001,
"heapDeltaBytes": 18981268,
"heapUsedBytes": 81288360,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 100.896,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.2710000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.650000000000002,
"layouts": 5,
"layoutDurationMs": 13.964,
"taskDurationMs": 1021.5160000000001,
"heapDeltaBytes": 11888340,
"heapUsedBytes": 87693860,
"domNodes": 16030,
"jsHeapTotalBytes": 14028800,
"scriptDurationMs": 31.052999999999997,
"eventListeners": 3246,
"totalBlockingTimeMs": 166,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8559.27600000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.544,
"layouts": 10,
"layoutDurationMs": 2.4730000000000003,
"taskDurationMs": 5749.972,
"heapDeltaBytes": -1372680,
"heapUsedBytes": 76567324,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2666.8390000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698437499999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8370.741000000067,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.091,
"layouts": 8,
"layoutDurationMs": 1.9309999999999998,
"taskDurationMs": 5717.013,
"heapDeltaBytes": 4273124,
"heapUsedBytes": 81573756,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2663.0830000000005,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666067864271458,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22828.42800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21888.52,
"heapDeltaBytes": -24142428,
"heapUsedBytes": 258594400,
"domNodes": -3343,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 286.957,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.366206896551724,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22209.543000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21453.099000000002,
"heapDeltaBytes": -24346128,
"heapUsedBytes": 258086172,
"domNodes": -3343,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 290.447,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.88242320819112,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27688.500000000033,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.33399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27329.319999999996,
"heapDeltaBytes": -26377836,
"heapUsedBytes": 249892032,
"domNodes": -3343,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 881.6630000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 37,
"frameDurationMs": 51.45390334572492,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27523.790000000077,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.85399999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27184.543000000005,
"heapDeltaBytes": -8543104,
"heapUsedBytes": 272780476,
"domNodes": -3343,
"jsHeapTotalBytes": 12836864,
"scriptDurationMs": 869.8249999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 51.84990583804142,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8106.493999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.991,
"layouts": 20,
"layoutDurationMs": 25.99399999999999,
"taskDurationMs": 7970.871999999999,
"heapDeltaBytes": -21218160,
"heapUsedBytes": 255133864,
"domNodes": -3343,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 139.627,
"eventListeners": -653,
"totalBlockingTimeMs": 12,
"frameDurationMs": 46.819075144508666,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8010.2849999999535,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.54600000000002,
"layouts": 20,
"layoutDurationMs": 21.239999999999995,
"taskDurationMs": 7889.271000000001,
"heapDeltaBytes": 238900,
"heapUsedBytes": 277236088,
"domNodes": -3343,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 116.74900000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.07068965517241,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11204.987000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10685.729,
"heapDeltaBytes": -4174228,
"heapUsedBytes": 258740648,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 136.559,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.35508771929825,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11098.659999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10596.441999999997,
"heapDeltaBytes": -20045604,
"heapUsedBytes": 256333468,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 142.562,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.882252559726965,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 484.23800000000483,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.352,
"layouts": 13,
"layoutDurationMs": 5.2490000000000006,
"taskDurationMs": 142.65499999999997,
"heapDeltaBytes": 7371344,
"heapUsedBytes": 67375252,
"domNodes": 140,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 17.765000000000004,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 118.88399999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.583,
"layouts": 9,
"layoutDurationMs": 3.686,
"taskDurationMs": 81.644,
"heapDeltaBytes": 4607500,
"heapUsedBytes": 64299556,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.1069999999999975,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 454.8220000000356,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6130000000000001,
"layouts": 76,
"layoutDurationMs": 14.253,
"taskDurationMs": 409.76199999999994,
"heapDeltaBytes": -4561016,
"heapUsedBytes": 38709416,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 196.937,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 415.15500000002703,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.583,
"layouts": 76,
"layoutDurationMs": 13.873999999999999,
"taskDurationMs": 368.602,
"heapDeltaBytes": -5022664,
"heapUsedBytes": 39064436,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 170.97799999999998,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 485.9310000000505,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.574,
"layouts": 76,
"layoutDurationMs": 13.392,
"taskDurationMs": 447.107,
"heapDeltaBytes": 437120,
"heapUsedBytes": 90302976,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 176.609,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 530.4079999999658,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.498,
"layouts": 76,
"layoutDurationMs": 13.286,
"taskDurationMs": 493.513,
"heapDeltaBytes": 290772,
"heapUsedBytes": 94181828,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 202.03,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3117 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 41ff78af85800f49289b08100c273eec9aa0f082
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22301 +/- ##
=============================================
Coverage ? 87.11%
=============================================
Files ? 3027
Lines ? 158381
Branches ? 42229
=============================================
Hits ? 137972
Misses ? 19733
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed this exact cloud/1.59 backport, including the persistent graph/linear hosts, confirmed consent writes, identity guards, shared refresh watermark, and the parent PR's resolved/outdated discussions. The refresh now survives a closed panel, handles acceptance before host mount, and avoids duplicate reads from two mounted hosts. Existing stored consent does not manufacture a new acceptance. The release branch's telemetry import is correct.
Own validation in this checkout with its own frozen install: 588 tests across AgentPanelRoot, useAgentDockMount and agentConsentStore PASS; app typecheck and scoped lint/format checks PASS. Five independent negative controls each fail the relevant retained regression: removing the watcher, confirmation increment, host deduplication, immediate observation, or stale-identity guard. Restored focused tests: 31 PASS. All seven changed files match the sibling backport.
The parent discussion's in-flight billing coalescing concern is pre-existing and tracked separately; I found no new contract, identity, or refresh regression introduced by this backport. No blocking code findings.
Backport of #22287 to
cloud/1.59.useAgentDockMount.test.tsimports: 1.59 uses@/platform/telemetry, soreportErrorimports use@/platform/telemetry/reportErrorhere.Full context for agent readers
Clean cherry-pick -x of the core/1.59 backport (#22300); all 7 touched files are identical between core/1.59 and cloud/1.59. Verified on this branch: dock, consent store and AgentPanelRoot unit suites pass (cold-import hook timeouts pass on rerun);
pnpm typecheck:apppasses.