Repository navigation
[backport core/1.59] Show truthful free-use notice on Local - #22243
christian-byrne merged 1 commit into
Conversation
Shows the existing free-use notice on Local at the near-composer placement only when billing authoritatively reports an active Agent-scoped grant. Local remains outside the Cloud placement experiment and does not emit Cloud experiment-assignment exposure, while users with no grant see no free-use claim. Linear: https://linear.app/comfyorg/issue/PM-2336/show-truthful-free-credit-notice-on-local-without-contaminating-the - Tests: `NODE_OPTIONS=--no-experimental-webstorage pnpm test:unit src/workbench/extensions/agent/experiments/freeUsePlacement.test.ts` — 14/14 passed. - Types and hooks: `pnpm typecheck:app`, `pnpm typecheck:browser`, lint-staged, dependency-cruiser, knip, and changed-file Fallow audit passed. - Browser: `DISTRIBUTION=localhost` focused Playwright run proves grant=true shows the near-composer notice and grant=false hides it — 2/2 passed. - After release: compare Local notice shown/clicked events separately from Cloud experiment 520535; Local emits no `app:agent_free_use_exposure` assignment. --------- Co-authored-by: Christian Byrne <christian-byrne@users.noreply.github.com> (cherry picked from commit 6650986)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T13:49:56.175Z",
"gitSha": "97aa79a44decce35d720e46b3963f9a457d4b701",
"branch": "backport-22032-to-core-1.59-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.9380000000301,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9619999999999997,
"layouts": 9,
"layoutDurationMs": 2.93,
"taskDurationMs": 612.451,
"heapDeltaBytes": 318596,
"heapUsedBytes": 60618784,
"domNodes": -161,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 11.604,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667213114754098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.3949999999604,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8839999999999995,
"layouts": 9,
"layoutDurationMs": 2.716,
"taskDurationMs": 586.579,
"heapDeltaBytes": 1820512,
"heapUsedBytes": 63495992,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.333000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.316999999951,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.815,
"layouts": 9,
"layoutDurationMs": 2.7960000000000003,
"taskDurationMs": 891.1439999999999,
"heapDeltaBytes": -1416724,
"heapUsedBytes": 68473556,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 161.972,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.5230000000602,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.445000000000002,
"layouts": 9,
"layoutDurationMs": 2.5289999999999995,
"taskDurationMs": 922.8,
"heapDeltaBytes": 21397380,
"heapUsedBytes": 82566452,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 168.989,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.5670000000264,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.347,
"layouts": 10,
"layoutDurationMs": 3.465,
"taskDurationMs": 456.73900000000003,
"heapDeltaBytes": -853536,
"heapUsedBytes": 60104552,
"domNodes": 56,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 14.496000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.0449999999273,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.9,
"layouts": 10,
"layoutDurationMs": 3.0380000000000003,
"taskDurationMs": 445.03900000000004,
"heapDeltaBytes": 24385500,
"heapUsedBytes": 85585732,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 13.864,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.755999999933,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.8970000000000002,
"layouts": 9,
"layoutDurationMs": 2.4099999999999997,
"taskDurationMs": 503.85100000000006,
"heapDeltaBytes": 5684928,
"heapUsedBytes": 66621760,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 173.779,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046512,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 757.7290000000403,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.301,
"layouts": 9,
"layoutDurationMs": 2.692,
"taskDurationMs": 514.004,
"heapDeltaBytes": 3116020,
"heapUsedBytes": 64187076,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 175.509,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666657,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.8590000000531,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 959.3330000000001,
"heapDeltaBytes": -12295476,
"heapUsedBytes": 74964936,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 81.43199999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 567,
"frameDurationMs": 33.78108108108108,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1302.7049999999463,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1048.26,
"heapDeltaBytes": -12290256,
"heapUsedBytes": 75102228,
"domNodes": -191,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 75.077,
"eventListeners": -106,
"totalBlockingTimeMs": 609,
"frameDurationMs": 35.12972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 930.4210000000239,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.1749999999995,
"heapDeltaBytes": -13573500,
"heapUsedBytes": 65790708,
"domNodes": -191,
"jsHeapTotalBytes": 1179648,
"scriptDurationMs": 185.38900000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.461111111111094,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 893.752999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.72,
"heapDeltaBytes": -27024096,
"heapUsedBytes": 66637148,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 167.38199999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12631.821000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11755.014,
"heapDeltaBytes": -7888548,
"heapUsedBytes": 80926576,
"domNodes": -257,
"jsHeapTotalBytes": 9826304,
"scriptDurationMs": 9654.166,
"eventListeners": -68,
"totalBlockingTimeMs": 1959,
"frameDurationMs": 33.420105820105825,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11187.460999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10370.894,
"heapDeltaBytes": 97150040,
"heapUsedBytes": 170840548,
"domNodes": -257,
"jsHeapTotalBytes": 81391616,
"scriptDurationMs": 8410.884,
"eventListeners": -68,
"totalBlockingTimeMs": 1027,
"frameDurationMs": 32.134770114942526,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11096.97799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10283.763,
"heapDeltaBytes": 79181868,
"heapUsedBytes": 153419912,
"domNodes": -257,
"jsHeapTotalBytes": 74838016,
"scriptDurationMs": 8245.688000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 1134,
"frameDurationMs": 31.307344632768366,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11056.286999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10268.578000000001,
"heapDeltaBytes": 64201608,
"heapUsedBytes": 147485860,
"domNodes": -257,
"jsHeapTotalBytes": 70905856,
"scriptDurationMs": 8274.832,
"eventListeners": -68,
"totalBlockingTimeMs": 1412,
"frameDurationMs": 31.57,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 268.3930000000032,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.541,
"layouts": 11,
"layoutDurationMs": 4.342,
"taskDurationMs": 246.694,
"heapDeltaBytes": -9118424,
"heapUsedBytes": 66139460,
"domNodes": -2315,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 11.078,
"eventListeners": -573,
"totalBlockingTimeMs": 10,
"frameDurationMs": 23.60833333333335,
"p95FrameDurationMs": 99.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 250.02099999994698,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.032,
"layouts": 10,
"layoutDurationMs": 3.149,
"taskDurationMs": 187.81000000000003,
"heapDeltaBytes": 14630332,
"heapUsedBytes": 74548292,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.421,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2041.4269999999988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9939999999999993,
"layouts": 9,
"layoutDurationMs": 2.898,
"taskDurationMs": 678.467,
"heapDeltaBytes": -11269184,
"heapUsedBytes": 63377528,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.833999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.2270000000117,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.013,
"layouts": 9,
"layoutDurationMs": 2.862,
"taskDurationMs": 781.333,
"heapDeltaBytes": -29671256,
"heapUsedBytes": 61538704,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 40.719,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2513.2429999999886,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.579,
"layouts": 8,
"layoutDurationMs": 2.1100000000000003,
"taskDurationMs": 1694.428,
"heapDeltaBytes": -15755576,
"heapUsedBytes": 76182476,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 817.403,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2658.4569999999985,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.911999999999999,
"layouts": 7,
"layoutDurationMs": 2.183,
"taskDurationMs": 1750.031,
"heapDeltaBytes": 8623144,
"heapUsedBytes": 85359400,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 837.769,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665408805031447,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3847.7169999999887,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.679,
"layouts": 64,
"layoutDurationMs": 11.089,
"taskDurationMs": 1864.2299999999998,
"heapDeltaBytes": 1883704,
"heapUsedBytes": 79525028,
"domNodes": -233,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 800.315,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580087,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3788.7640000000147,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.986000000000002,
"layouts": 64,
"layoutDurationMs": 10.794999999999998,
"taskDurationMs": 1831.508,
"heapDeltaBytes": 4826084,
"heapUsedBytes": 85460044,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 798.124,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666079295154184,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3062.469999999962,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.917000000000001,
"layouts": 5,
"layoutDurationMs": 1.3509999999999998,
"taskDurationMs": 1995.143,
"heapDeltaBytes": -8625048,
"heapUsedBytes": 72778036,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 979.798,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3197.1320000000105,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.948000000000001,
"layouts": 4,
"layoutDurationMs": 1.3059999999999998,
"taskDurationMs": 2085.0049999999997,
"heapDeltaBytes": 22359448,
"heapUsedBytes": 95814876,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 1056.6599999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.927225130890054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3139.298999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0830000000000006,
"layouts": 7,
"layoutDurationMs": 1.798,
"taskDurationMs": 828.1370000000001,
"heapDeltaBytes": -16377920,
"heapUsedBytes": 62299004,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 382.499,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808513,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3101.321999999982,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7559999999999998,
"layouts": 6,
"layoutDurationMs": 1.8639999999999999,
"taskDurationMs": 866.7980000000001,
"heapDeltaBytes": -2491608,
"heapUsedBytes": 72631520,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 385.777,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.177999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3,
"layouts": 7,
"layoutDurationMs": 2.228,
"taskDurationMs": 762.849,
"heapDeltaBytes": -17589488,
"heapUsedBytes": 63311992,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 40.76299999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.6279999999224,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.374,
"layouts": 7,
"layoutDurationMs": 1.99,
"taskDurationMs": 702.8270000000001,
"heapDeltaBytes": -29739688,
"heapUsedBytes": 63413840,
"domNodes": -257,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 35.684,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2980.4659999999785,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.824,
"layouts": 5,
"layoutDurationMs": 1.5039999999999998,
"taskDurationMs": 675.2540000000001,
"heapDeltaBytes": -5830592,
"heapUsedBytes": 71683664,
"domNodes": -254,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 208.21800000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665921787709497,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2850.5159999999705,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.219,
"layouts": 6,
"layoutDurationMs": 1.8469999999999998,
"taskDurationMs": 683.1239999999999,
"heapDeltaBytes": -21204124,
"heapUsedBytes": 71612036,
"domNodes": -254,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 211.604,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3391.860999999949,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9829999999999994,
"layouts": 7,
"layoutDurationMs": 2.205,
"taskDurationMs": 1027.9129999999998,
"heapDeltaBytes": -14827796,
"heapUsedBytes": 78597172,
"domNodes": -257,
"jsHeapTotalBytes": 6979584,
"scriptDurationMs": 405.694,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74851485148515,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3371.2150000000065,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.209,
"layouts": 4,
"layoutDurationMs": 0.9840000000000001,
"taskDurationMs": 1031.241,
"heapDeltaBytes": -15947764,
"heapUsedBytes": 61821504,
"domNodes": -257,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 397.651,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74875621890547,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.9510000000573,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.059000000000001,
"layouts": 9,
"layoutDurationMs": 2.621,
"taskDurationMs": 453.13399999999996,
"heapDeltaBytes": 164504,
"heapUsedBytes": 62000324,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 144.727,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 674.3549999999914,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.728000000000001,
"layouts": 8,
"layoutDurationMs": 2.302,
"taskDurationMs": 471.58099999999996,
"heapDeltaBytes": 21282340,
"heapUsedBytes": 81660244,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 149.756,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.9880000000549,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.743,
"layouts": 8,
"layoutDurationMs": 2.8280000000000003,
"taskDurationMs": 604.885,
"heapDeltaBytes": 2565348,
"heapUsedBytes": 64984672,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 11.616000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.6880000000874,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5120000000000005,
"layouts": 8,
"layoutDurationMs": 2.359,
"taskDurationMs": 589.7760000000001,
"heapDeltaBytes": 4742024,
"heapUsedBytes": 76437152,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 11.328,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.853999999974,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.757,
"layouts": 10,
"layoutDurationMs": 2.8329999999999997,
"taskDurationMs": 869.0279999999999,
"heapDeltaBytes": -6079244,
"heapUsedBytes": 65550980,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 114.82,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.3029999999872,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.777000000000003,
"layouts": 9,
"layoutDurationMs": 3.062,
"taskDurationMs": 875.7210000000001,
"heapDeltaBytes": 17589344,
"heapUsedBytes": 79759300,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 118.35600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1470.2779999998938,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.361000000000008,
"layouts": 5,
"layoutDurationMs": 14.508000000000003,
"taskDurationMs": 1171.881,
"heapDeltaBytes": 11618956,
"heapUsedBytes": 113220536,
"domNodes": 16030,
"jsHeapTotalBytes": 15601664,
"scriptDurationMs": 30.784000000000006,
"eventListeners": 3246,
"totalBlockingTimeMs": 165,
"frameDurationMs": 19.517105263157898,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10139.108999999962,
"styleRecalcs": 249,
"styleRecalcDurationMs": 29.335,
"layouts": 7,
"layoutDurationMs": 1.849,
"taskDurationMs": 6252.1449999999995,
"heapDeltaBytes": 4748244,
"heapUsedBytes": 81668304,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2820.871,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666118421052634,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10710.414000000015,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.862,
"layouts": 8,
"layoutDurationMs": 2.1730000000000005,
"taskDurationMs": 6702.9220000000005,
"heapDeltaBytes": 18141732,
"heapUsedBytes": 93454972,
"domNodes": -257,
"jsHeapTotalBytes": 6086656,
"scriptDurationMs": 3184.804,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69188767550702,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23194.646000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22687.932999999997,
"heapDeltaBytes": -13220888,
"heapUsedBytes": 267493324,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 311.435,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.20641247833622,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 23511.05999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23071.785,
"heapDeltaBytes": -20741736,
"heapUsedBytes": 258041548,
"domNodes": -3343,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 340.733,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.03774597495527,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28572.896000000015,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.388000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28279.922999999995,
"heapDeltaBytes": -3878548,
"heapUsedBytes": 288042836,
"domNodes": -3343,
"jsHeapTotalBytes": 18010112,
"scriptDurationMs": 904.4929999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 55.35949612403101,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28543.569000000047,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.15900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28138.409,
"heapDeltaBytes": 5642756,
"heapUsedBytes": 281768412,
"domNodes": -3343,
"jsHeapTotalBytes": 9359360,
"scriptDurationMs": 920.8620000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 7,
"frameDurationMs": 53.36242990654206,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8437.549999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.202,
"layouts": 20,
"layoutDurationMs": 29.130000000000017,
"taskDurationMs": 8313.826000000001,
"heapDeltaBytes": -40268636,
"heapUsedBytes": 255184784,
"domNodes": -3343,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 130.739,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.832065217391296,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8388.688000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.88100000000003,
"layouts": 20,
"layoutDurationMs": 28.78499999999999,
"taskDurationMs": 8271.638,
"heapDeltaBytes": -43840544,
"heapUsedBytes": 252266696,
"domNodes": -3343,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 121.51299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.27413793103449,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11725.475999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11412.153,
"heapDeltaBytes": 3075632,
"heapUsedBytes": 259550244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.89299999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.26219931271478,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11724.222999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11524.563,
"heapDeltaBytes": 10779060,
"heapUsedBytes": 283479664,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 159.456,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.851020408163265,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 144.53400000002148,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.546000000000001,
"layouts": 9,
"layoutDurationMs": 4.207,
"taskDurationMs": 107.60799999999999,
"heapDeltaBytes": 4888364,
"heapUsedBytes": 72426612,
"domNodes": 107,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.664,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 128.5889999999199,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.574,
"layouts": 9,
"layoutDurationMs": 3.9369999999999994,
"taskDurationMs": 90.98400000000001,
"heapDeltaBytes": 4614852,
"heapUsedBytes": 72076144,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.3919999999999995,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 483.1580000000031,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.632,
"layouts": 76,
"layoutDurationMs": 15.573,
"taskDurationMs": 442.519,
"heapDeltaBytes": -4426372,
"heapUsedBytes": 40505240,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 215.64600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 513.3579999999256,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.717,
"layouts": 76,
"layoutDurationMs": 15.775,
"taskDurationMs": 473.591,
"heapDeltaBytes": -3854000,
"heapUsedBytes": 40212812,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 226.916,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 598.4950000001845,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.523,
"layouts": 76,
"layoutDurationMs": 15.775999999999998,
"taskDurationMs": 564.7379999999999,
"heapDeltaBytes": 1700792,
"heapUsedBytes": 99805884,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 230.976,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777762,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 648.431999999957,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.925,
"layouts": 76,
"layoutDurationMs": 16.272,
"taskDurationMs": 616.3380000000001,
"heapDeltaBytes": 1950372,
"heapUsedBytes": 104531500,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 258.687,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307678,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3127 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook |
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: 9f5a719 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22243 +/- ##
=============================================
- Coverage 87.46% 87.45% -0.01%
=============================================
Files 2956 2956
Lines 156115 156108 -7
Branches 42194 40072 -2122
=============================================
- Hits 136551 136531 -20
- Misses 18889 18902 +13
Partials 675 675
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Backport approval. Note: unit shard 8 failed on src/components/topbar/WorkflowTab.test.ts > delays hover preview without moving focus and dismisses after leaving, a file this PR does not touch. Please rerun that shard to confirm it is flaky before merging.
0491a66
into
Comfy-Org:core/1.59
…#22259) Backport of #22032 to `cloud/1.59`. The automated backport failed with conflicts. This is a clean cherry-pick of the already-merged `core/1.59` carrier #22243 (0491a66): none of its 11 files differ between `core/1.59` and `cloud/1.59`, so the same conflict resolution applies unchanged. <details><summary>Full context for agent readers</summary> - Source: #22032 (merged to main 2026-10-29, 6650986). - `core/1.59` carrier: #22243 (merged 2026-10-29 16:00Z). - `git cherry-pick -x 0491a66` onto `origin/cloud/1.59` applied with no conflicts; only the title changed. - Older trains (1.56, 1.57) are not targeted: their automated backports also failed, and those trains lack the billing code this change builds on (see https://linear.app/comfyorg/issue/PM-2336). - Tracking: https://linear.app/comfyorg/issue/PM-2336 </details> Co-authored-by: Christian Byrne <christian-byrne@users.noreply.github.com>
Comfy-Org#22287) ## Summary - Agree from the top-bar Agent button (or the automatic first-load prompt with the panel closed) now re-reads billing, so the Local free-use notice shows for the first chat. - Follow-up to Comfy-Org#22032: its refresh lived in the panel, which doesn't exist yet when these consent paths finish. - Reloading an already-saved consent does not add a billing read. Linear: https://linear.app/comfyorg/issue/PM-2398/refresh-billing-after-agent-consent-from-the-top-bar-or-first-load <details><summary>Full context for agent readers</summary> **Root cause.** `AgentPanelRoot` mounts only while `DockedAgentPanel` is docked. `TopbarActions.vue` runs `withConsent('button_click', () => agentPanelStore.open())` and `agentPanel.ts` runs `withConsent('first_load', ...)` then opens, so the accepted transition happens before the panel's watcher exists. `useBillingContext` is shared and kept alive by `useAgentDockMount` on `GraphCanvas`, so the pre-consent status read is never replaced until a turn completes. **Change.** - `agentConsentStore` counts confirmed `accept()` writes (`acceptances`). `load()` of a stored acceptance does not count, and a write that lands after the identity changed does not count. - `useAgentDockMount` (persistent graph/linear host) calls billing `fetchStatus` once per new acceptance, sync flush, so it starts before `withConsent`'s `onAccept` runs (same ordering as before). Failures go to `reportError` with the existing `error_refreshing_agent_billing_status` type. - `agentPanelStore.billingRefreshedAcceptances` dedupes the two hosts that coexist in linear mode (`GraphView` mounts `GraphCanvas` and `LinearView` together). - The panel watcher from Comfy-Org#22032 is removed; its test is rewritten to assert the panel no longer reads on first send. **Review.** Independent adversarial pass (fresh Claude reviewer; Codex unavailable on this host) on a first draft flagged that watching `accepted` fired on every reload of stored consent and twice in linear mode, and that an identity-change branch was unreachable. All three are addressed by counting confirmed writes and the dedupe marker. **Verification.** - New tests red before the fix, green after: `useAgentDockMount.test.ts` (closed-panel acceptance, stored-consent load is ignored, two hosts read once, failure reported), `agentConsentStore.test.ts` (counts writes not loads; ignores a write that resolves after an account change). - `src/workbench/extensions/agent`, `src/components/graph`, `src/views`, `src/extensions/core`: 6134 passed; 2 load-dependent failures pass in isolation and on the base commit. - `pnpm typecheck:app` and oxlint pass. - Not covered locally: browser run of top-bar Agree on Local. Requested as runtime QA. **Backports.** `core/1.59`, `cloud/1.59`, matching Comfy-Org#22032 (carried by Comfy-Org#22243 / Comfy-Org#22259). 1.56/1.57 lack the billing code, as with Comfy-Org#22032. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Alexander Brown <DrJKL0424@gmail.com>
Manual recovery of the failed automated backport from #22032. The conflict resolution preserves core/1.59’s newer signed-out Local browser behavior while carrying the authoritative Agent-grant gate, fixed near-composer Local placement without Cloud assignment, consent-triggered billing refresh, Local telemetry provenance, and regression coverage. Focused unit suites pass 620/620; commit and push hooks pass.\n\nSource: #22032