Repository navigation
[backport cloud/1.59] Show truthful free-use notice on Local (#22032) - #22259
Conversation
Manual recovery of the failed automated backport from #22032. The conflict resolution preserves core/1.59’s newer signed-out Local browser behavior while carrying the authoritative Agent-grant gate, fixed near-composer Local placement without Cloud assignment, consent-triggered billing refresh, Local telemetry provenance, and regression coverage. Focused unit suites pass 620/620; commit and push hooks pass.\n\nSource: #22032 Co-authored-by: Christian Byrne <christian-byrne@users.noreply.github.com> (cherry picked from commit 0491a66)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T16:24:30.097Z",
"gitSha": "c237123bfdcd2a31edd66a6dce179ad554c8dc17",
"branch": "backport-22032-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.9189999999976,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8369999999999993,
"layouts": 10,
"layoutDurationMs": 2.7069999999999994,
"taskDurationMs": 524.8770000000001,
"heapDeltaBytes": 5478920,
"heapUsedBytes": 75135344,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.144,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.2509999999456,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8330000000000006,
"layouts": 9,
"layoutDurationMs": 2.5909999999999997,
"taskDurationMs": 519.707,
"heapDeltaBytes": 4731532,
"heapUsedBytes": 75312236,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8.61,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.1029999999948,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.535,
"layouts": 9,
"layoutDurationMs": 2.544,
"taskDurationMs": 858.491,
"heapDeltaBytes": 21368404,
"heapUsedBytes": 82792656,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 156.43699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.1870000000208,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.305000000000001,
"layouts": 9,
"layoutDurationMs": 2.6040000000000005,
"taskDurationMs": 853.5699999999999,
"heapDeltaBytes": 22621624,
"heapUsedBytes": 84329652,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 154.622,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.771999999973,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.926,
"layouts": 10,
"layoutDurationMs": 2.9630000000000005,
"taskDurationMs": 413.838,
"heapDeltaBytes": 24055788,
"heapUsedBytes": 84834092,
"domNodes": 56,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.369999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.9680000000517,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.848000000000001,
"layouts": 9,
"layoutDurationMs": 2.7259999999999995,
"taskDurationMs": 450.73400000000004,
"heapDeltaBytes": 680816,
"heapUsedBytes": 70821924,
"domNodes": 56,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 14.992999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 759.9819999999795,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.06,
"layouts": 9,
"layoutDurationMs": 2.7810000000000006,
"taskDurationMs": 516.104,
"heapDeltaBytes": 5497360,
"heapUsedBytes": 66474920,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 167.68800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 788.5179999999536,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.528,
"layouts": 8,
"layoutDurationMs": 2.4299999999999997,
"taskDurationMs": 562.267,
"heapDeltaBytes": 7245028,
"heapUsedBytes": 77338580,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 187.815,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808516,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1227.2350000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 926.163,
"heapDeltaBytes": -12182484,
"heapUsedBytes": 75212300,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 71.81099999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 549,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1228.4179999999765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 933.9190000000001,
"heapDeltaBytes": -1418716,
"heapUsedBytes": 75374264,
"domNodes": -191,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 66.996,
"eventListeners": -106,
"totalBlockingTimeMs": 554,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 939.6779999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.2770000000002,
"heapDeltaBytes": -27760612,
"heapUsedBytes": 66542148,
"domNodes": -191,
"jsHeapTotalBytes": 3801088,
"scriptDurationMs": 177.93600000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 239,
"frameDurationMs": 24.560526315789456,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 910.8060000000364,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.6370000000005,
"heapDeltaBytes": -27058824,
"heapUsedBytes": 66358420,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 184.77900000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.775675675675647,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11342.948000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10465.339,
"heapDeltaBytes": 82186028,
"heapUsedBytes": 156409120,
"domNodes": -257,
"jsHeapTotalBytes": 66711552,
"scriptDurationMs": 8441.072,
"eventListeners": -68,
"totalBlockingTimeMs": 1211,
"frameDurationMs": 32.472206303724924,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10464.34000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9661.548,
"heapDeltaBytes": 72233208,
"heapUsedBytes": 146068548,
"domNodes": -257,
"jsHeapTotalBytes": 67235840,
"scriptDurationMs": 7746.351,
"eventListeners": -68,
"totalBlockingTimeMs": 909,
"frameDurationMs": 31.007715133531157,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9626.226000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8816.726,
"heapDeltaBytes": 56184644,
"heapUsedBytes": 129017896,
"domNodes": -257,
"jsHeapTotalBytes": 55439360,
"scriptDurationMs": 7023.197999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 615,
"frameDurationMs": 31.63223684210526,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10338.870999999983,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.03999999999999924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9496.68,
"heapDeltaBytes": 48938812,
"heapUsedBytes": 131897832,
"domNodes": -257,
"jsHeapTotalBytes": 65925120,
"scriptDurationMs": 7647.013999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 899,
"frameDurationMs": 31.69601226993865,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 212.70699999999465,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.378,
"layouts": 8,
"layoutDurationMs": 2.967,
"taskDurationMs": 167.17399999999998,
"heapDeltaBytes": 14510624,
"heapUsedBytes": 71688420,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.971000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 231.46800000000667,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.674,
"layouts": 8,
"layoutDurationMs": 2.7039999999999997,
"taskDurationMs": 172.027,
"heapDeltaBytes": 14602464,
"heapUsedBytes": 71949420,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.933,
"eventListeners": 205,
"totalBlockingTimeMs": 5,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2040.4780000000073,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.757999999999999,
"layouts": 9,
"layoutDurationMs": 2.6220000000000003,
"taskDurationMs": 629.343,
"heapDeltaBytes": -10392872,
"heapUsedBytes": 63688276,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 34.496,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.943999999954,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.562,
"layouts": 8,
"layoutDurationMs": 2.341,
"taskDurationMs": 645.347,
"heapDeltaBytes": -29711184,
"heapUsedBytes": 61584392,
"domNodes": -257,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 32.871,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2515.755000000013,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.86,
"layouts": 7,
"layoutDurationMs": 1.6780000000000002,
"taskDurationMs": 1712.883,
"heapDeltaBytes": -17833808,
"heapUsedBytes": 62224108,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 859.28,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.776666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2610.0260000000617,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.796999999999999,
"layouts": 8,
"layoutDurationMs": 2.024,
"taskDurationMs": 1710.5379999999998,
"heapDeltaBytes": -11095636,
"heapUsedBytes": 81168900,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 834.034,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66624203821656,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3798.3050000000276,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.622,
"layouts": 65,
"layoutDurationMs": 10.562999999999999,
"taskDurationMs": 1806.0040000000001,
"heapDeltaBytes": 6650568,
"heapUsedBytes": 77903148,
"domNodes": -233,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 791.431,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665638766519823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3754.063999999971,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.418,
"layouts": 65,
"layoutDurationMs": 10.836,
"taskDurationMs": 1834.6660000000002,
"heapDeltaBytes": -2924344,
"heapUsedBytes": 74840340,
"domNodes": -233,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 787.446,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666222222222224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3196.4720000000284,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.020000000000001,
"layouts": 5,
"layoutDurationMs": 1.3409999999999997,
"taskDurationMs": 2076.4,
"heapDeltaBytes": -1916760,
"heapUsedBytes": 76530500,
"domNodes": 0,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 984.9960000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 3,
"frameDurationMs": 16.84157894736842,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3185.936999999967,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.262999999999999,
"layouts": 5,
"layoutDurationMs": 1.2859999999999998,
"taskDurationMs": 2029.5330000000004,
"heapDeltaBytes": -1897660,
"heapUsedBytes": 70714892,
"domNodes": 0,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 994.917,
"eventListeners": 182,
"totalBlockingTimeMs": 23,
"frameDurationMs": 16.93015873015873,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3039.8030000000063,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7630000000000008,
"layouts": 6,
"layoutDurationMs": 1.636,
"taskDurationMs": 769.7479999999999,
"heapDeltaBytes": -8030312,
"heapUsedBytes": 85415336,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 352.89400000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666483516483517,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3056.4390000000117,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.085,
"layouts": 7,
"layoutDurationMs": 1.82,
"taskDurationMs": 782.6160000000001,
"heapDeltaBytes": -4776388,
"heapUsedBytes": 73364740,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 374.15,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.8530000000128,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8989999999999996,
"layouts": 6,
"layoutDurationMs": 1.7329999999999997,
"taskDurationMs": 655.5609999999999,
"heapDeltaBytes": -7791572,
"heapUsedBytes": 68855460,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 32.646,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.3419999999815,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.346,
"layouts": 8,
"layoutDurationMs": 2.523,
"taskDurationMs": 641.9119999999999,
"heapDeltaBytes": -28246436,
"heapUsedBytes": 64320300,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 35.276999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2914.262000000008,
"styleRecalcs": 25,
"styleRecalcDurationMs": 10.722,
"layouts": 6,
"layoutDurationMs": 1.591,
"taskDurationMs": 627.4,
"heapDeltaBytes": -903252,
"heapUsedBytes": 76390996,
"domNodes": -252,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 207.13700000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66628571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2823.305000000005,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.711999999999998,
"layouts": 8,
"layoutDurationMs": 1.9850000000000003,
"taskDurationMs": 582.8239999999998,
"heapDeltaBytes": -11305300,
"heapUsedBytes": 67995724,
"domNodes": -248,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 174.355,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568047337278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3238.707000000005,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.476,
"layouts": 6,
"layoutDurationMs": 1.47,
"taskDurationMs": 910.0059999999999,
"heapDeltaBytes": -905392,
"heapUsedBytes": 75320052,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 360.543,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659793814433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3258.3339999999907,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.4519999999999993,
"layouts": 6,
"layoutDurationMs": 1.3509999999999998,
"taskDurationMs": 923.9019999999999,
"heapDeltaBytes": -14665016,
"heapUsedBytes": 64617752,
"domNodes": -257,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 371.88599999999997,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.752061855670107,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.509999999982,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.784,
"layouts": 9,
"layoutDurationMs": 2.5359999999999996,
"taskDurationMs": 444.549,
"heapDeltaBytes": 399956,
"heapUsedBytes": 63024976,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 144.821,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.1570000000766,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.831,
"layouts": 9,
"layoutDurationMs": 2.498,
"taskDurationMs": 435.17499999999995,
"heapDeltaBytes": -864692,
"heapUsedBytes": 61033184,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 144.308,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.4080000000029,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7,
"layouts": 8,
"layoutDurationMs": 2.404,
"taskDurationMs": 626.042,
"heapDeltaBytes": 1169100,
"heapUsedBytes": 63652620,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.393999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.1350000000248,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.053,
"layouts": 10,
"layoutDurationMs": 2.843,
"taskDurationMs": 515.9749999999999,
"heapDeltaBytes": 6080800,
"heapUsedBytes": 77954184,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 7.96,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0110000000038,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.904,
"layouts": 8,
"layoutDurationMs": 2.9309999999999996,
"taskDurationMs": 898.2240000000002,
"heapDeltaBytes": 17136276,
"heapUsedBytes": 79293232,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 116.082,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.3819999999914,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.649000000000001,
"layouts": 9,
"layoutDurationMs": 2.358,
"taskDurationMs": 819.875,
"heapDeltaBytes": 19702632,
"heapUsedBytes": 81127236,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 109.266,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1454.4109999999932,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.855,
"layouts": 5,
"layoutDurationMs": 16.887000000000004,
"taskDurationMs": 1078.517,
"heapDeltaBytes": 7117516,
"heapUsedBytes": 98296072,
"domNodes": 16030,
"jsHeapTotalBytes": 17174528,
"scriptDurationMs": 30.717000000000002,
"eventListeners": 3246,
"totalBlockingTimeMs": 163,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9659.588999999982,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.715,
"layouts": 8,
"layoutDurationMs": 2.053,
"taskDurationMs": 6038.6179999999995,
"heapDeltaBytes": -5495168,
"heapUsedBytes": 85523308,
"domNodes": -257,
"jsHeapTotalBytes": 5337088,
"scriptDurationMs": 2756.507,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.694818652849744,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9608.255999999983,
"styleRecalcs": 251,
"styleRecalcDurationMs": 28.026000000000003,
"layouts": 8,
"layoutDurationMs": 1.9269999999999998,
"taskDurationMs": 5964.399,
"heapDeltaBytes": -16842028,
"heapUsedBytes": 60891896,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 2705.895,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665972222222226,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24059.420999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23405.276,
"heapDeltaBytes": -7253804,
"heapUsedBytes": 273108788,
"domNodes": -3343,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 339.89200000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.33978873239436,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23063.073000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22433.601,
"heapDeltaBytes": -28432724,
"heapUsedBytes": 272361360,
"domNodes": -3343,
"jsHeapTotalBytes": 13623296,
"scriptDurationMs": 333.24199999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.97538994800693,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27925.242000000027,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.25500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27547.798000000003,
"heapDeltaBytes": -7369624,
"heapUsedBytes": 269496392,
"domNodes": -3343,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 851.4200000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 37,
"frameDurationMs": 52.08115671641791,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 27730.785000000084,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.086999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27348.493000000006,
"heapDeltaBytes": -28778692,
"heapUsedBytes": 262322728,
"domNodes": -3343,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 851.6469999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 51.38666666666666,
"p95FrameDurationMs": 100.10000000000582
},
{
"name": "vue-node-resize-workload",
"durationMs": 8241.56899999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.34600000000002,
"layouts": 20,
"layoutDurationMs": 21.097999999999992,
"taskDurationMs": 8105.665999999999,
"heapDeltaBytes": -23349668,
"heapUsedBytes": 253191140,
"domNodes": -3343,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 119.41499999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 8,
"frameDurationMs": 46.34606741573034,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8053.624000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.20899999999999,
"layouts": 20,
"layoutDurationMs": 22.33299999999999,
"taskDurationMs": 7944.854,
"heapDeltaBytes": -29755140,
"heapUsedBytes": 252603956,
"domNodes": -3343,
"jsHeapTotalBytes": 23842816,
"scriptDurationMs": 117.85900000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.09371428571427,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11567.249000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11191.672999999999,
"heapDeltaBytes": 8275828,
"heapUsedBytes": 283913724,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 173.79599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.499650349650345,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11560.029999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11138.593999999997,
"heapDeltaBytes": -17281324,
"heapUsedBytes": 255243872,
"domNodes": 0,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 152.88500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.47508532423208,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 142.9059999999822,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.239,
"layouts": 10,
"layoutDurationMs": 4.271999999999999,
"taskDurationMs": 100.405,
"heapDeltaBytes": 4754268,
"heapUsedBytes": 66066888,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.193999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.677777777777766,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 143.98800000003575,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.543999999999999,
"layouts": 10,
"layoutDurationMs": 3.954,
"taskDurationMs": 92.33000000000001,
"heapDeltaBytes": 4605244,
"heapUsedBytes": 66167660,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.193999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 511.09900000005837,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.638,
"layouts": 76,
"layoutDurationMs": 15.514,
"taskDurationMs": 459.467,
"heapDeltaBytes": -3835960,
"heapUsedBytes": 39201200,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 227.50300000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483896,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 478.52099999988695,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.621,
"layouts": 76,
"layoutDurationMs": 14.416,
"taskDurationMs": 428.82699999999994,
"heapDeltaBytes": -4172584,
"heapUsedBytes": 39022428,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 208.224,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66206896551725,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 513.1390000000238,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.817,
"layouts": 76,
"layoutDurationMs": 14.197,
"taskDurationMs": 480.031,
"heapDeltaBytes": 145388,
"heapUsedBytes": 90549052,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 191.002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 501.1410000000751,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.617,
"layouts": 76,
"layoutDurationMs": 14.417,
"taskDurationMs": 460.89599999999996,
"heapDeltaBytes": -26976,
"heapUsedBytes": 90515008,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 185.40599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.21999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3123 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsFallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since eeb983d4ea8a39a7af01b9fff019556dccc83e77
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (219)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22259 +/- ##
=============================================
Coverage ? 87.46%
=============================================
Files ? 2958
Lines ? 156159
Branches ? 40120
=============================================
Hits ? 136587
Misses ? 18896
Partials ? 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed ce359b87603df55b3896c3c23fb110297149f6ad against cloud/1.59, including the original #22032 discussions, Ryan's complete lifecycle/telemetry thread, and carrier #22243. The five production files match carrier 0491a66f5e; the target also retains its existing cross-tab test. No blocking finding remains.
The free-use claim consumes the served Agent-scoped funds flag with billing-rail provenance, rather than shared-credit availability. Failed current reads invalidate that claim, and successful consent refreshes billing on both rails. The generated API types are retained; the added result type describes the local read outcome, not a copied server envelope.
Executed on this exact head with its own frozen Node 26 install: 777 tests across the five affected unit suites, app and browser typechecks, Local and Cloud production bundles, scoped type-aware Oxlint/ESLint/Oxfmt, and Knip PASS. Independent disposable controls confirm the regressions discriminate:
| Control | Result |
|---|---|
| Remove legacy failed-read invalidation | 2 FAIL, 140 PASS across both adapter suites |
| Remove workspace failed-read invalidation | 1 FAIL, 141 PASS across both adapter suites |
| Remove the notice authority gate | Its billing-disabled regression FAILS |
| Remove post-consent refresh | All 4 workspace/legacy consent regressions FAIL |
| Remove the Local placement default | 1 FAIL, 13 PASS |
| Restore exact source | 156 adapter/placement tests and 5 focused panel tests PASS |
Real Chromium against the exact compiled bundles and an isolated CPU Core backend passes both Local grant/show and spent-grant/hide cases, plus the Cloud no-grant/exposure regression. I inspected the Local screenshots. Identity, billing and Agent transport use the existing typed fixtures; this does not certify a real Cloud grant, payment, or model generation. All temporary probes were restored and the owned backend stopped; checkout clean.
Head, open state and discussions were refreshed before posting. The remaining hosted E2E shards were still running at that check and remain a merge gate; their pending state is not counted as a PASS.
Comfy-Org#22287) ## Summary - Agree from the top-bar Agent button (or the automatic first-load prompt with the panel closed) now re-reads billing, so the Local free-use notice shows for the first chat. - Follow-up to Comfy-Org#22032: its refresh lived in the panel, which doesn't exist yet when these consent paths finish. - Reloading an already-saved consent does not add a billing read. Linear: https://linear.app/comfyorg/issue/PM-2398/refresh-billing-after-agent-consent-from-the-top-bar-or-first-load <details><summary>Full context for agent readers</summary> **Root cause.** `AgentPanelRoot` mounts only while `DockedAgentPanel` is docked. `TopbarActions.vue` runs `withConsent('button_click', () => agentPanelStore.open())` and `agentPanel.ts` runs `withConsent('first_load', ...)` then opens, so the accepted transition happens before the panel's watcher exists. `useBillingContext` is shared and kept alive by `useAgentDockMount` on `GraphCanvas`, so the pre-consent status read is never replaced until a turn completes. **Change.** - `agentConsentStore` counts confirmed `accept()` writes (`acceptances`). `load()` of a stored acceptance does not count, and a write that lands after the identity changed does not count. - `useAgentDockMount` (persistent graph/linear host) calls billing `fetchStatus` once per new acceptance, sync flush, so it starts before `withConsent`'s `onAccept` runs (same ordering as before). Failures go to `reportError` with the existing `error_refreshing_agent_billing_status` type. - `agentPanelStore.billingRefreshedAcceptances` dedupes the two hosts that coexist in linear mode (`GraphView` mounts `GraphCanvas` and `LinearView` together). - The panel watcher from Comfy-Org#22032 is removed; its test is rewritten to assert the panel no longer reads on first send. **Review.** Independent adversarial pass (fresh Claude reviewer; Codex unavailable on this host) on a first draft flagged that watching `accepted` fired on every reload of stored consent and twice in linear mode, and that an identity-change branch was unreachable. All three are addressed by counting confirmed writes and the dedupe marker. **Verification.** - New tests red before the fix, green after: `useAgentDockMount.test.ts` (closed-panel acceptance, stored-consent load is ignored, two hosts read once, failure reported), `agentConsentStore.test.ts` (counts writes not loads; ignores a write that resolves after an account change). - `src/workbench/extensions/agent`, `src/components/graph`, `src/views`, `src/extensions/core`: 6134 passed; 2 load-dependent failures pass in isolation and on the base commit. - `pnpm typecheck:app` and oxlint pass. - Not covered locally: browser run of top-bar Agree on Local. Requested as runtime QA. **Backports.** `core/1.59`, `cloud/1.59`, matching Comfy-Org#22032 (carried by Comfy-Org#22243 / Comfy-Org#22259). 1.56/1.57 lack the billing code, as with Comfy-Org#22032. </details> --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Alexander Brown <DrJKL0424@gmail.com>
Backport of #22032 to
cloud/1.59.The automated backport failed with conflicts. This is a clean cherry-pick of the already-merged
core/1.59carrier #22243 (0491a66): none of its 11 files differ betweencore/1.59andcloud/1.59, so the same conflict resolution applies unchanged.Full context for agent readers
core/1.59carrier: [backport core/1.59] Show truthful free-use notice on Local #22243 (merged 2026-10-29 16:00Z).git cherry-pick -x 0491a66f5eontoorigin/cloud/1.59applied with no conflicts; only the title changed.