Skip to content

[backport cloud/1.57] fix(agent): make the coach-tour hold on the first send visible and always releasable (#21285) - #22227

Merged
comfy-pr-bot merged 2 commits into
cloud/1.57from
backport-21285-to-cloud-1.57
Oct 29, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.57from
backport-21285-to-cloud-1.57

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Manual backport of #21285 to cloud/1.57. The auto-backport hit a conflict in AgentPanelRoot.vue.

Why

A new user's first agent message waits behind the intro tour with no notice, so it looks like the agent never answered (about 5% of first sends; QA reproduced it on a Desktop release candidate). #21285 is on main and in v1.60.0; this line still has the silent hold.

What differs from the original

Same two commits as #22223 (core/1.58), cherry-picked cleanly.

  • AgentPanelRoot.vue: on main, the post-release recheck also compares the consent identity, which came from feat: complete Desktop Agent consent and locked panel startup #21532 (not on this line). The backport keeps the coach-release and still-accepted-consent checks and drops only the identity comparison.
  • AgentPanelRoot.test.ts: one existing test's withConsent mock now marks consent accepted before onAccept, as the real withConsent does and as main's copy of the test does. Without it the recheck rejects the mocked accept.
  • Everything else is byte-identical to the merged commit.

Verification

  • vitest run AgentPanelRoot.test.ts OnboardingCoach.test.ts on this branch: 474/474. pnpm typecheck: clean.
  • Browser case agentActivationConsent.spec.ts (hold notice) runs in CI.

Tracking: https://linear.app/comfyorg/issue/BE-21344

mattmillerai and others added 2 commits October 29, 2026 09:43
…st send visible and always releasable (#21285)

The first message a new user sends waits until they finish or skip the
agent's intro tour. Until now that wait was silent, could last forever
if a tour step failed to appear, and closing the panel threw the message
away. Now the tour card says the message is waiting, a broken tour step
lets the message go, and closing the panel puts the message back in the
box.

The first send after consent still waits for the coach (ordering from
exit either sends once or restores the draft:

- `OnboardingCoach`: new `holdNotice` prop rendered under the card body
and included in the dialog's `aria-describedby`; new `stalled` emit,
fired at most once per instance when a step's target is still missing
after the existing 8s grace period. `stalled` does not call `finish()`,
so the tour is not marked seen.
- `AgentPanelRoot`: `sendHeldByCoach` ref set only around the coach
wait; passes the notice string while held; releases waiters on
`@stalled`. On teardown during a coach hold, the consent-held submission
is no longer invalidated; teardown releases any still-pending coach
wait. If App Mode or another tour defers the coach and the panel stays
visible, the release lets the send through. Switching to App Mode can
unmount the graph-hosted panel before the panel's own deferral watcher
runs, so the send has to be let through here, at teardown. Otherwise the
wait is abandoned: the continuation returns `false`,
`settleSubmission(id, false)` marks it failed and
`recoverFailedSubmission` restores text and attachments on the next
mount. The consent-dialog-phase invalidation (late accept after
teardown) is unchanged.
- New string `agent.coachHoldNotice` in `en/main.json` only. No
timer-based auto-send.

Judgment calls:
- E2E: the coach's full-screen scrim and focus trap block pointer and
keyboard access to the panel toggle, so the new spec closes the panel
with `openButton.dispatchEvent('click')`. On reopen the coach shows
again over the composer, so the spec skips the tour before re-sending
instead of sending first (the ticket's order isn't reachable through the
UI).

- Unit: `pnpm vitest run
src/workbench/extensions/agent/AgentPanelRoot.test.ts
src/workbench/extensions/agent/components/agent/OnboardingCoach.test.ts`:
518/518 pass on the branch merged with current `main` (conflict in
`AgentPanelRoot.vue` resolved by keeping both this PR's coach-release
result and main's post-wait consent/identity recheck). New cases: notice
shown while held, no notice on a "Take the tour" replay, exactly one
POST when a step stalls (fake timers past the grace period, tour not
marked seen), exactly one POST when App Mode unmounts the visible panel,
both before and after the panel's deferral watcher releases the hold,
zero POSTs + `settleSubmission(id, false)` + draft restored after
close/unmount, zero POSTs + draft restored when consent clears before
App Mode releases the hold, `stalled` emitted once across two missing
steps, notice rendered and announced only when set.
- Mutation: reverting the `AgentPanelRoot.vue` change makes the
held-send tests fail; the unmount-before-watcher App Mode case fails
against both earlier teardown versions of this PR, which is what broke
the `@cloud` E2E "resumes the held send when App Mode defers the active
tour", and passes on main and on the current head.
- Existing "does not resume a consent-held send after closing in App
Mode" and the onboarding deferral tests pass unchanged.
- `pnpm typecheck` clean; oxlint/oxfmt/stylelint/eslint clean
(pre-commit hooks).
- Doc-drift sweep: flagged identifiers are generic test/DOM API names
(`toHaveLength`, `dispatchEvent`); the new identifiers
`coachHoldNotice`, `agent-coach-hold-notice`, `holdNotice`, `stalled`
have no doc references. 0 updated.

- The `@cloud` Playwright cases in
`browser_tests/tests/agent/agentActivationConsent.spec.ts` (the new
hold-notice case and the existing finish/skip/App Mode cases) were not
run locally (no cloud-mode backend on this host); they ran in CI, where
the cloud and chromium Playwright shards pass on the current head.
- The hold notice copy names only finish/skip; the stall release is a
failure fallback the user cannot trigger, so it is not mentioned.
- Because the scrim blocks the panel toggle, a user can't actually close
the panel while the coach card is up; the restore-on-close path only
matters when the panel is torn down some other way. Whether the scrim
should leave the panel toggle reachable is a separate design question
and is left alone here.
- Non-English locales get `agent.coachHoldNotice` from the i18n
pipeline; not hand-edited.

- **Authored by:** agent-work loop
- **Verified:**
- Current `main` merged in; the `AgentPanelRoot.vue` conflict resolved
so a held send needs the coach release and a still-matching consent
identity
- Unit tests on the current head: all green (2 files, 518 tests),
including the new hold, stall, close and App Mode cases; App Mode test
now always stops its watcher
- Consent cleared during the hold checked red/green: the held draft
comes back and nothing posts, and the test fails without the post-wait
consent/identity recheck
- App Mode teardown checked red/green: unmounting before the watcher
fails on the previous head and passes on main and the current head
  - Typecheck / lint / format: clean on the current head
- Playwright `@cloud` spec (new + existing cases): not run locally; all
CI checks, including the cloud and chromium Playwright shards, pass on
the current head
- **Deviations:**
- E2E closes the panel with a dispatched click and skips the tour before
re-sending, because the coach overlay blocks the UI path the ticket
described
  - Hold notice copy does not mention the stall fallback

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
The backported recheck requires consent to still be accepted when the
coach releases the send. The real withConsent only calls onAccept after
the store is accepted; this mock now does the same, matching main.
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 29, 2026
@christian-byrne
christian-byrne requested review from a team as code owners October 29, 2026 09:59
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 585ms TBT · 77.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 232ms TBT · 72.6 MB heap
extension-clean-combined-draw: · 31.3 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1232ms TBT · 81.3 MB heap
extension-rgthree-prototype-draw: · 31.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1058ms TBT · 85.3 MB heap
large-combo-open: · 43.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1ms TBT · 81.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
large-graph-pan: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
large-graph-zoom: · 59.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
legacy-node-drag: · 59.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-transition-enter: · 49.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 172ms TBT · 95.1 MB heap
viewport-pan-sweep: · 59.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
vue-large-graph-idle: · 25.1 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 260.9 MB heap
vue-large-graph-pan: · 18.9 avg FPS · 8.6 P5 FPS ❌ (target: ≥52) · 26ms TBT · 247.4 MB heap
vue-node-resize-workload: · 20.8 avg FPS · 10.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 252.7 MB heap
vue-zoom-out-idle: · 25.0 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 250.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
agent-composer-long-conversation-typing: · 59.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 116.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 10
canvas-idle: style recalc count 10
canvas-idle: task duration 559ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.8 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 9
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 822ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.9 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 6
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 3ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 11
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 434ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.0 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 465ms
dom-widget-clipping: script duration 172ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 87.1 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 974ms
dom-widget-order-dense-n200-w200-i120: script duration 74ms
dom-widget-order-dense-n200-w200-i120: TBT 585ms
dom-widget-order-dense-n200-w200-i120: heap used 77.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -192
dom-widget-order-dense-n200-w200-i120: event listeners -106
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 514ms
dom-widget-order-sparse-n1000-w20-i120: script duration 172ms
dom-widget-order-sparse-n1000-w20-i120: TBT 232ms
dom-widget-order-sparse-n1000-w20-i120: heap used 72.6 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9779ms
extension-clean-combined-draw: script duration 8045ms
extension-clean-combined-draw: TBT 1232ms
extension-clean-combined-draw: heap used 81.3 MB
extension-clean-combined-draw: DOM nodes -258
extension-clean-combined-draw: event listeners -68
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9765ms
extension-rgthree-prototype-draw: script duration 7917ms
extension-rgthree-prototype-draw: TBT 1058ms
extension-rgthree-prototype-draw: heap used 85.3 MB
extension-rgthree-prototype-draw: DOM nodes -258
extension-rgthree-prototype-draw: event listeners -68
large-combo-open: avg frame time 23ms
large-combo-open: p95 frame time 67ms
large-combo-open: layout duration 4ms
large-combo-open: style recalc duration 17ms
large-combo-open: layout count 12
large-combo-open: style recalc count 26
large-combo-open: task duration 196ms
large-combo-open: script duration 9ms
large-combo-open: TBT 1ms
large-combo-open: heap used 81.9 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 663ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 71.5 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -68
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 6ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1592ms
large-graph-pan: script duration 812ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.1 MB
large-graph-pan: DOM nodes -268
large-graph-pan: event listeners -66
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 7ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1650ms
large-graph-zoom: script duration 758ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 76.7 MB
large-graph-zoom: DOM nodes -244
large-graph-zoom: event listeners -68
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1962ms
legacy-node-drag: script duration 965ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 8
minimap-idle: style recalc count 8
minimap-idle: task duration 544ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 74.3 MB
minimap-idle: DOM nodes -268
minimap-idle: event listeners -68
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 438ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 72.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 538ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 77.5 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 82
subgraph-mouse-sweep: task duration 941ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.7 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 6
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1168ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 172ms
subgraph-transition-enter: heap used 95.1 MB
subgraph-transition-enter: DOM nodes 15953
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 18ms
viewport-pan-sweep: layout count 7
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5081ms
viewport-pan-sweep: script duration 2669ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.6 MB
viewport-pan-sweep: DOM nodes -258
viewport-pan-sweep: event listeners -66
vue-large-graph-idle: avg frame time 40ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 22352ms
vue-large-graph-idle: script duration 326ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 260.9 MB
vue-large-graph-idle: DOM nodes -3330
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 53ms
vue-large-graph-pan: p95 frame time 117ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 27671ms
vue-large-graph-pan: script duration 924ms
vue-large-graph-pan: TBT 26ms
vue-large-graph-pan: heap used 247.4 MB
vue-large-graph-pan: DOM nodes -3330
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 48ms
vue-node-resize-workload: p95 frame time 100ms
vue-node-resize-workload: layout duration 30ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8260ms
vue-node-resize-workload: script duration 133ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 252.7 MB
vue-node-resize-workload: DOM nodes -3330
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 40ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 11266ms
vue-zoom-out-idle: script duration 160ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 250.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 5ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 12
workflow-execution: style recalc count 13
workflow-execution: task duration 130ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 71.6 MB
workflow-execution: DOM nodes 97
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 16ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 458ms
agent-composer-empty-conversation-typing: script duration 222ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 75.0 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 15ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 535ms
agent-composer-long-conversation-typing: script duration 221ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 116.2 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-29T10:13:40.633Z",
  "gitSha": "2fb901ed17b1650c8f0d594a6dc5ad3289ada0e5",
  "branch": "backport-21285-to-cloud-1.57",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2009.0769999999907,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.732000000000001,
      "layouts": 10,
      "layoutDurationMs": 3.08,
      "taskDurationMs": 569.436,
      "heapDeltaBytes": 3167908,
      "heapUsedBytes": 78585864,
      "domNodes": 0,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 10.937,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2008.1239999999525,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.011999999999999,
      "layouts": 9,
      "layoutDurationMs": 2.9250000000000007,
      "taskDurationMs": 548.9179999999999,
      "heapDeltaBytes": -906652,
      "heapUsedBytes": 74171308,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 11.389,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1725.022000000024,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 14.758000000000001,
      "layouts": 9,
      "layoutDurationMs": 2.713,
      "taskDurationMs": 736.83,
      "heapDeltaBytes": 15561248,
      "heapUsedBytes": 82018016,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 162.465,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1826.139000000012,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 15.34,
      "layouts": 9,
      "layoutDurationMs": 2.463,
      "taskDurationMs": 906.323,
      "heapDeltaBytes": -7243304,
      "heapUsedBytes": 68676308,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 170.644,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666055045871563,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1697.088000000008,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.937,
      "layouts": 11,
      "layoutDurationMs": 2.831,
      "taskDurationMs": 429.284,
      "heapDeltaBytes": 18733692,
      "heapUsedBytes": 84211512,
      "domNodes": 47,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 13.757000000000001,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1817.5469999999905,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.186,
      "layouts": 11,
      "layoutDurationMs": 2.783,
      "taskDurationMs": 438.588,
      "heapDeltaBytes": -4516060,
      "heapUsedBytes": 70916084,
      "domNodes": 47,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 10.672,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666972477064217,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 617.6420000000462,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 2.9240000000000004,
      "layouts": 10,
      "layoutDurationMs": 2.8770000000000002,
      "taskDurationMs": 433.00300000000004,
      "heapDeltaBytes": 25673324,
      "heapUsedBytes": 91035112,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 171.821,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 713.3049999999912,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.863,
      "layouts": 9,
      "layoutDurationMs": 2.572,
      "taskDurationMs": 497.71200000000005,
      "heapDeltaBytes": 25652300,
      "heapUsedBytes": 91540192,
      "domNodes": 0,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 172.24499999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1241.1620000000312,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 944.1449999999999,
      "heapDeltaBytes": 1072980,
      "heapUsedBytes": 81105700,
      "domNodes": -192,
      "jsHeapTotalBytes": 13901824,
      "scriptDurationMs": 70.70400000000001,
      "eventListeners": -106,
      "totalBlockingTimeMs": 542,
      "frameDurationMs": 33.32972972972973,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1310.8349999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1003.392,
      "heapDeltaBytes": -11337720,
      "heapUsedBytes": 81374708,
      "domNodes": -192,
      "jsHeapTotalBytes": 20979712,
      "scriptDurationMs": 77.349,
      "eventListeners": -106,
      "totalBlockingTimeMs": 628,
      "frameDurationMs": 35.583783783783794,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 872.9250000000093,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.81500000000034,
      "heapDeltaBytes": -5614144,
      "heapUsedBytes": 75582620,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 167.60199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 235,
      "frameDurationMs": 25.48823529411763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 876.3050000000021,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.4239999999999,
      "heapDeltaBytes": -3125948,
      "heapUsedBytes": 76723780,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 176.97799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 229,
      "frameDurationMs": 25.48823529411763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11087.796999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10211.741,
      "heapDeltaBytes": -24026012,
      "heapUsedBytes": 75283332,
      "domNodes": -258,
      "jsHeapTotalBytes": 5107712,
      "scriptDurationMs": 8259.023000000001,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1347,
      "frameDurationMs": 32.6929203539823,
      "p95FrameDurationMs": 66.69999999999982
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10249.994000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9346.255,
      "heapDeltaBytes": -4648848,
      "heapUsedBytes": 95155604,
      "domNodes": -258,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 7831.118,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1116,
      "frameDurationMs": 31.24878048780488,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9879.822000000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9062.597,
      "heapDeltaBytes": 6599568,
      "heapUsedBytes": 94525696,
      "domNodes": -258,
      "jsHeapTotalBytes": 3010560,
      "scriptDurationMs": 7290.883,
      "eventListeners": -68,
      "totalBlockingTimeMs": 768,
      "frameDurationMs": 31.374285714285712,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11236.020999999937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10467.760999999999,
      "heapDeltaBytes": -3148920,
      "heapUsedBytes": 84377208,
      "domNodes": -258,
      "jsHeapTotalBytes": 3796992,
      "scriptDurationMs": 8542.394999999999,
      "eventListeners": -68,
      "totalBlockingTimeMs": 1347,
      "frameDurationMs": 31.64197183098592,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 230.60300000003053,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 15.807000000000002,
      "layouts": 12,
      "layoutDurationMs": 3.4160000000000004,
      "taskDurationMs": 171.523,
      "heapDeltaBytes": -8081044,
      "heapUsedBytes": 79658452,
      "domNodes": 917,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 8.846000000000002,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.33000000000002,
      "p95FrameDurationMs": 66.80000000000018
    },
    {
      "name": "large-combo-open",
      "durationMs": 277.95900000000984,
      "styleRecalcs": 27,
      "styleRecalcDurationMs": 18.459,
      "layouts": 12,
      "layoutDurationMs": 3.9639999999999995,
      "taskDurationMs": 219.96500000000003,
      "heapDeltaBytes": 13054668,
      "heapUsedBytes": 91999964,
      "domNodes": 917,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 9.838999999999999,
      "eventListeners": 196,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 22.224999999999984,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.4819999999972,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.294,
      "layouts": 8,
      "layoutDurationMs": 2.214,
      "taskDurationMs": 658.688,
      "heapDeltaBytes": -19665424,
      "heapUsedBytes": 77523824,
      "domNodes": -258,
      "jsHeapTotalBytes": 3571712,
      "scriptDurationMs": 39.58600000000001,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.262999999958,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.386,
      "layouts": 8,
      "layoutDurationMs": 2.1600000000000006,
      "taskDurationMs": 667.2569999999998,
      "heapDeltaBytes": -7008000,
      "heapUsedBytes": 72350956,
      "domNodes": -278,
      "jsHeapTotalBytes": 4845568,
      "scriptDurationMs": 33.754999999999995,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2467.6340000000323,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 5.829999999999999,
      "layouts": 8,
      "layoutDurationMs": 2.004,
      "taskDurationMs": 1682.8630000000003,
      "heapDeltaBytes": -3881296,
      "heapUsedBytes": 76588452,
      "domNodes": -258,
      "jsHeapTotalBytes": 4022272,
      "scriptDurationMs": 815.742,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66554054054054,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2290.273999999954,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 6.058,
      "layouts": 7,
      "layoutDurationMs": 2.024,
      "taskDurationMs": 1501.5960000000002,
      "heapDeltaBytes": 8694616,
      "heapUsedBytes": 89258372,
      "domNodes": -278,
      "jsHeapTotalBytes": 4808704,
      "scriptDurationMs": 808.1819999999999,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.78823529411765,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3618.8750000000027,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 7.2059999999999995,
      "layouts": 64,
      "layoutDurationMs": 10.549,
      "taskDurationMs": 1753.291,
      "heapDeltaBytes": -9390408,
      "heapUsedBytes": 72040716,
      "domNodes": -234,
      "jsHeapTotalBytes": 3534848,
      "scriptDurationMs": 762.597,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.743055555555557,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3452.635999999984,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 7.076,
      "layouts": 63,
      "layoutDurationMs": 10.029,
      "taskDurationMs": 1547.017,
      "heapDeltaBytes": 6876928,
      "heapUsedBytes": 88728964,
      "domNodes": -254,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 753.572,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66570048309179,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2982.106999999985,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.524,
      "layouts": 4,
      "layoutDurationMs": 1.0209999999999997,
      "taskDurationMs": 1930.8709999999999,
      "heapDeltaBytes": 10326444,
      "heapUsedBytes": 89363996,
      "domNodes": 0,
      "jsHeapTotalBytes": 7565312,
      "scriptDurationMs": 954.9490000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.854802259887006,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2995.789000000059,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.973999999999999,
      "layouts": 5,
      "layoutDurationMs": 1.6009999999999995,
      "taskDurationMs": 1992.9199999999998,
      "heapDeltaBytes": 5725904,
      "heapUsedBytes": 83326980,
      "domNodes": 0,
      "jsHeapTotalBytes": 2883584,
      "scriptDurationMs": 974.0630000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.85337078651685,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2053.9600000000178,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.62,
      "layouts": 9,
      "layoutDurationMs": 3.015,
      "taskDurationMs": 472.34899999999993,
      "heapDeltaBytes": -5497484,
      "heapUsedBytes": 76621028,
      "domNodes": -278,
      "jsHeapTotalBytes": 3272704,
      "scriptDurationMs": 31.271,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2056.222000000048,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.8129999999999995,
      "layouts": 7,
      "layoutDurationMs": 1.9680000000000002,
      "taskDurationMs": 614.9149999999998,
      "heapDeltaBytes": -19389680,
      "heapUsedBytes": 79275836,
      "domNodes": -258,
      "jsHeapTotalBytes": 2523136,
      "scriptDurationMs": 31.178000000000004,
      "eventListeners": -68,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 622.3680000000513,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.822,
      "layouts": 10,
      "layoutDurationMs": 2.712,
      "taskDurationMs": 443.36500000000007,
      "heapDeltaBytes": -1084996,
      "heapUsedBytes": 76754964,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 143.92,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 629.4189999999844,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 4.515,
      "layouts": 10,
      "layoutDurationMs": 2.5610000000000004,
      "taskDurationMs": 432.88300000000004,
      "heapDeltaBytes": -1522436,
      "heapUsedBytes": 76009816,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 146.427,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664864864864864,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.2649999999944,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.142000000000001,
      "layouts": 10,
      "layoutDurationMs": 3.141,
      "taskDurationMs": 533.222,
      "heapDeltaBytes": 3907228,
      "heapUsedBytes": 81316380,
      "domNodes": 0,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 10.525,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.738000000004,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.169000000000001,
      "layouts": 10,
      "layoutDurationMs": 3.2390000000000008,
      "taskDurationMs": 542.705,
      "heapDeltaBytes": 3917228,
      "heapUsedBytes": 81307916,
      "domNodes": 0,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 10.167,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66528925619835,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1960.0020000000313,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 16.925000000000004,
      "layouts": 10,
      "layoutDurationMs": 2.6449999999999996,
      "taskDurationMs": 1050.597,
      "heapDeltaBytes": -11390144,
      "heapUsedBytes": 65528628,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 113.30900000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66610169491525,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.299000000011,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 15.675,
      "layouts": 10,
      "layoutDurationMs": 2.4509999999999996,
      "taskDurationMs": 832.187,
      "heapDeltaBytes": -7232040,
      "heapUsedBytes": 70187408,
      "domNodes": 0,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 111.38199999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66568627450981,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1468.8859999999977,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.110000000000003,
      "layouts": 5,
      "layoutDurationMs": 17.082000000000004,
      "taskDurationMs": 1167.9470000000003,
      "heapDeltaBytes": 7515820,
      "heapUsedBytes": 99740720,
      "domNodes": 15953,
      "jsHeapTotalBytes": 17440768,
      "scriptDurationMs": 32.751000000000005,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 172,
      "frameDurationMs": 20.044594594594596,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8382.071999999993,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 18.91,
      "layouts": 7,
      "layoutDurationMs": 2.0399999999999996,
      "taskDurationMs": 5221.003000000001,
      "heapDeltaBytes": -8243692,
      "heapUsedBytes": 71191692,
      "domNodes": -258,
      "jsHeapTotalBytes": 4583424,
      "scriptDurationMs": 2694.726,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7326,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8335.720999999921,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 16.83,
      "layouts": 6,
      "layoutDurationMs": 1.8889999999999998,
      "taskDurationMs": 4940.1669999999995,
      "heapDeltaBytes": -442628,
      "heapUsedBytes": 78982528,
      "domNodes": -258,
      "jsHeapTotalBytes": 4546560,
      "scriptDurationMs": 2644.138,
      "eventListeners": -66,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.766599597585515,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23080.533000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22349.67,
      "heapDeltaBytes": -12648912,
      "heapUsedBytes": 263850000,
      "domNodes": -3330,
      "jsHeapTotalBytes": 13094912,
      "scriptDurationMs": 318.654,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.93494809688582,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23029.674999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22354.515,
      "heapDeltaBytes": -695888,
      "heapUsedBytes": 283218604,
      "domNodes": -3330,
      "jsHeapTotalBytes": 10477568,
      "scriptDurationMs": 333.825,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.84826989619377,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28196.69699999997,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.859000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27795.149,
      "heapDeltaBytes": -8390984,
      "heapUsedBytes": 267996332,
      "domNodes": -3330,
      "jsHeapTotalBytes": 6541312,
      "scriptDurationMs": 941.569,
      "eventListeners": -651,
      "totalBlockingTimeMs": 49,
      "frameDurationMs": 52.64085820895523,
      "p95FrameDurationMs": 116.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 27938.669000000005,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 17.479999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27546.559999999998,
      "heapDeltaBytes": -31909656,
      "heapUsedBytes": 250925464,
      "domNodes": -3330,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 906.511,
      "eventListeners": -651,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 53.407648183556404,
      "p95FrameDurationMs": 116.60000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8453.321000000016,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.71899999999998,
      "layouts": 20,
      "layoutDurationMs": 36.87099999999999,
      "taskDurationMs": 8339.62,
      "heapDeltaBytes": -18590328,
      "heapUsedBytes": 272181632,
      "domNodes": -3330,
      "jsHeapTotalBytes": 15192064,
      "scriptDurationMs": 131.84600000000003,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 47.73785310734463,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8294.633000000089,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.66700000000002,
      "layouts": 20,
      "layoutDurationMs": 23.17100000000001,
      "taskDurationMs": 8181.188999999999,
      "heapDeltaBytes": -42795488,
      "heapUsedBytes": 257858032,
      "domNodes": -3330,
      "jsHeapTotalBytes": 15978496,
      "scriptDurationMs": 134.335,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 48.34093567251462,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11604.255999999965,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11394.167000000003,
      "heapDeltaBytes": 4546368,
      "heapUsedBytes": 262155412,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 165.07199999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.70035087719299,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11411.849000000075,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11138.673999999999,
      "heapDeltaBytes": 10570452,
      "heapUsedBytes": 263322340,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 154.88100000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.44498269896193,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "workflow-execution",
      "durationMs": 482.22599999996874,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 13.675,
      "layouts": 13,
      "layoutDurationMs": 6.082000000000001,
      "taskDurationMs": 139.64399999999998,
      "heapDeltaBytes": 6780596,
      "heapUsedBytes": 79471124,
      "domNodes": 98,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 15.366999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667857142857137,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 480.953999999997,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 10.924999999999999,
      "layouts": 11,
      "layoutDurationMs": 3.4400000000000004,
      "taskDurationMs": 119.39500000000001,
      "heapDeltaBytes": -8621716,
      "heapUsedBytes": 70643884,
      "domNodes": 95,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 10.242999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66428571428571,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 515.4270000000452,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.003,
      "layouts": 76,
      "layoutDurationMs": 16.27,
      "taskDurationMs": 449.5,
      "heapDeltaBytes": -21328428,
      "heapUsedBytes": 72456556,
      "domNodes": 4,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 214.839,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66451612903224,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 520.45099999998,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.345,
      "layouts": 76,
      "layoutDurationMs": 16.650000000000002,
      "taskDurationMs": 467.028,
      "heapDeltaBytes": 11971108,
      "heapUsedBytes": 84895284,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 229.511,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66451612903224,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 585.311000000047,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.96,
      "layouts": 76,
      "layoutDurationMs": 15.065999999999999,
      "taskDurationMs": 539.8130000000001,
      "heapDeltaBytes": 866600,
      "heapUsedBytes": 120551848,
      "domNodes": 4,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 223.90500000000003,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 563.8310000000502,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.057,
      "layouts": 76,
      "layoutDurationMs": 14.657,
      "taskDurationMs": 529.4129999999999,
      "heapDeltaBytes": 588240,
      "heapUsedBytes": 123149508,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 219.089,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.158823529411755,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🎭 Playwright: ✅ 2284 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2262 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/29/2026, 10:02:04 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since b43a3ad58f26da6153dcbd7851cb564663151207

Full docs: ADR-DEVEX-LINT-0015

@github-actions
github-actions Bot requested a review from thedatalife October 29, 2026 10:00

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport of #21285 (merged). Approving the backport; CI was still running at review time with no failures so far — please merge once it's green.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 29, 2026
@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 96.42% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.57   #22227   +/-   ##
=============================================
  Coverage              ?   85.23%           
=============================================
  Files                 ?     2526           
  Lines                 ?   133297           
  Branches              ?    38409           
=============================================
  Hits                  ?   113612           
  Misses                ?    19269           
  Partials              ?      416           
Flag Coverage Δ
unit 85.23% <97.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions/agent/components/agent/OnboardingCoach.vue 100.00% <100.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 95.03% <96.42%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit ff668ba into cloud/1.57 Oct 29, 2026
141 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21285-to-cloud-1.57 branch October 29, 2026 10:20
comfy-pr-bot pushed a commit that referenced this pull request Oct 29, 2026
… is cleared or its identity changes (#22234)

Follow-up to the backport of
#21285 on this line
(#22227). That PR
merged before these two commits were pushed to its branch.

## What

The coach-tour hold on the first send now also ends when consent is
cleared or the consent identity changes, and the release checks that the
identity still matches the one that accepted. Main already has both
(they came with
#21532, which is not
on this line).

## Why

Found in review of the backport:

- After a sign-out and sign-in as another user without a reload, a send
held for the first account could go out under the second account's
consent once the second account's tour finished or stalled.
- Clearing consent with the panel open left the send waiting, with no
tour card, until the panel was closed.

## Tests

Two new `AgentPanelRoot.test.ts` cases, written first and failing before
the fix:

- puts the draft back when consent is cleared while the panel stays open
- puts the draft back when the consent identity changes during the hold

`vitest run AgentPanelRoot.test.ts OnboardingCoach.test.ts` on this
line: 476/476. Typecheck, oxlint, eslint and oxfmt clean (pre-commit).

The same two commits are already on the cloud/1.58 backport:
#22225

Tracking: https://linear.app/comfyorg/issue/BE-21344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants