Repository navigation
[chore] Update Ingest API types from cloud@47889693 - #22216
Conversation
📦 Bundle: 12 MB gzip 🔴 +667 BDetailsSummary
Category Glance App Entry Points — 6.68 kB (baseline 6.68 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 5 unchanged Panels & Settings — 873 kB (baseline 873 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 159 kB (baseline 159 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 10 added / 10 removed / 8 unchanged Editors & Dialogs — 502 kB (baseline 502 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 345 kB (baseline 345 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed / 21 unchanged Data & Services — 1.91 MB (baseline 1.91 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 34 added / 34 removed / 8 unchanged Utilities & Hooks — 2.43 MB (baseline 2.43 MB) • 🔴 +1.15 kBHelpers, composables, and utility bundles
Status: 44 added / 44 removed / 40 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.8 MB (baseline 34.8 MB) • 🔴 +3.65 kBBundles that do not match a named category
Status: 108 added / 108 removed / 639 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-29T21:45:33.454Z",
"gitSha": "79690c47dcf771e9a370a570b1f7b6201868f4a8",
"branch": "update-ingest-types",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.2050000000138,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7399999999999998,
"layouts": 9,
"layoutDurationMs": 2.582,
"taskDurationMs": 529.417,
"heapDeltaBytes": 2692364,
"heapUsedBytes": 64225120,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 8.919,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.6420000000326,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.255,
"layouts": 8,
"layoutDurationMs": 2.2510000000000003,
"taskDurationMs": 506.432,
"heapDeltaBytes": 2781800,
"heapUsedBytes": 64481820,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.378,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.618999999989,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.619000000000002,
"layouts": 10,
"layoutDurationMs": 2.6900000000000004,
"taskDurationMs": 929.6529999999999,
"heapDeltaBytes": -1453832,
"heapUsedBytes": 70725032,
"domNodes": -173,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 160.123,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.3449999999702,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.301,
"layouts": 8,
"layoutDurationMs": 2.4279999999999995,
"taskDurationMs": 893.307,
"heapDeltaBytes": 22743628,
"heapUsedBytes": 84797980,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 165.441,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605504587156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.905000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.008,
"layouts": 12,
"layoutDurationMs": 2.6969999999999996,
"taskDurationMs": 418.58399999999995,
"heapDeltaBytes": 963664,
"heapUsedBytes": 71551112,
"domNodes": 57,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 11.225999999999999,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1859999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.23,
"layouts": 12,
"layoutDurationMs": 3.0129999999999995,
"taskDurationMs": 408.71500000000003,
"heapDeltaBytes": 993032,
"heapUsedBytes": 71709408,
"domNodes": 57,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 10.443000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.8140000000033,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.972,
"layouts": 9,
"layoutDurationMs": 2.5450000000000004,
"taskDurationMs": 490.7049999999999,
"heapDeltaBytes": 6201344,
"heapUsedBytes": 66985124,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 165.941,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 659.8219999999628,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9470000000000005,
"layouts": 10,
"layoutDurationMs": 2.606,
"taskDurationMs": 496.71500000000003,
"heapDeltaBytes": 3446944,
"heapUsedBytes": 65131416,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 173.652,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1207.8599999999824,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 912.4069999999999,
"heapDeltaBytes": -13087392,
"heapUsedBytes": 75278784,
"domNodes": -203,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 70.845,
"eventListeners": -106,
"totalBlockingTimeMs": 515,
"frameDurationMs": 32.43243243243242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.1160000000318,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 884.3330000000001,
"heapDeltaBytes": -12251620,
"heapUsedBytes": 75724972,
"domNodes": -203,
"jsHeapTotalBytes": 22290432,
"scriptDurationMs": 68.403,
"eventListeners": -106,
"totalBlockingTimeMs": 507,
"frameDurationMs": 31.57894736842105,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 890.4709999999909,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.2249999999999,
"heapDeltaBytes": -30096300,
"heapUsedBytes": 65640460,
"domNodes": -203,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 167.176,
"eventListeners": -106,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.7249999999494,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.32800000000043,
"heapDeltaBytes": -4771560,
"heapUsedBytes": 69918452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.72399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 218,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10915.21800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10093.596,
"heapDeltaBytes": 52608352,
"heapUsedBytes": 134117108,
"domNodes": -269,
"jsHeapTotalBytes": 68546560,
"scriptDurationMs": 8089.537,
"eventListeners": -68,
"totalBlockingTimeMs": 1212,
"frameDurationMs": 31.459077809798274,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11207.674999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10425.192,
"heapDeltaBytes": 79592156,
"heapUsedBytes": 159070712,
"domNodes": -269,
"jsHeapTotalBytes": 80867328,
"scriptDurationMs": 8476.828000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1198,
"frameDurationMs": 31.998285714285714,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10166.088000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9373.282000000001,
"heapDeltaBytes": 53025336,
"heapUsedBytes": 135289652,
"domNodes": -269,
"jsHeapTotalBytes": 70119424,
"scriptDurationMs": 7465.753000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 729,
"frameDurationMs": 31.572360248447204,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11004.851000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10316.544,
"heapDeltaBytes": 71955176,
"heapUsedBytes": 153335284,
"domNodes": -269,
"jsHeapTotalBytes": 74051584,
"scriptDurationMs": 8362.767,
"eventListeners": -68,
"totalBlockingTimeMs": 1373,
"frameDurationMs": 31.69942363112392,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 254.54500000000735,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.389999999999999,
"layouts": 11,
"layoutDurationMs": 3.326,
"taskDurationMs": 208.313,
"heapDeltaBytes": 14482304,
"heapUsedBytes": 90063692,
"domNodes": 936,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 9.100999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 240.49999999999727,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.308,
"layouts": 10,
"layoutDurationMs": 3.5250000000000004,
"taskDurationMs": 206.99,
"heapDeltaBytes": -13480688,
"heapUsedBytes": 70080128,
"domNodes": -2323,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.651000000000002,
"eventListeners": -573,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2057.6130000000035,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.03,
"layouts": 8,
"layoutDurationMs": 2.1350000000000002,
"taskDurationMs": 652.4530000000001,
"heapDeltaBytes": -28336136,
"heapUsedBytes": 59651488,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 31.306,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.629999999951,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.378,
"layouts": 9,
"layoutDurationMs": 2.4070000000000005,
"taskDurationMs": 649.3209999999999,
"heapDeltaBytes": -13437932,
"heapUsedBytes": 60535356,
"domNodes": -269,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.871999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2497.1949999999765,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.507000000000001,
"layouts": 9,
"layoutDurationMs": 2.4560000000000004,
"taskDurationMs": 1714.974,
"heapDeltaBytes": -6688020,
"heapUsedBytes": 85341408,
"domNodes": -269,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 843.737,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777852348993285,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2410.4039999999713,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.213000000000001,
"layouts": 7,
"layoutDurationMs": 1.9499999999999995,
"taskDurationMs": 1690.242,
"heapDeltaBytes": -28050128,
"heapUsedBytes": 61918884,
"domNodes": -269,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 812.905,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66551724137931,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3735.572999999988,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.049999999999999,
"layouts": 64,
"layoutDurationMs": 9.876000000000001,
"taskDurationMs": 1795.3669999999997,
"heapDeltaBytes": -14388960,
"heapUsedBytes": 75656240,
"domNodes": -245,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 773.804,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3700.3760000000057,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.891,
"layouts": 65,
"layoutDurationMs": 10.262,
"taskDurationMs": 1767.6570000000002,
"heapDeltaBytes": 1150360,
"heapUsedBytes": 73570764,
"domNodes": -245,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 768.4949999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3124.998000000005,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.8019999999999996,
"layouts": 1,
"layoutDurationMs": 0.31800000000000056,
"taskDurationMs": 1987.5130000000004,
"heapDeltaBytes": 19694176,
"heapUsedBytes": 84693444,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 992.485,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755376344086024,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3051.727000000028,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.992000000000001,
"layouts": 5,
"layoutDurationMs": 1.2400000000000002,
"taskDurationMs": 1934.612,
"heapDeltaBytes": 21909248,
"heapUsedBytes": 100019856,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 965.152,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757142857142853,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3053.8019999999906,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9370000000000003,
"layouts": 7,
"layoutDurationMs": 1.7150000000000003,
"taskDurationMs": 778.207,
"heapDeltaBytes": -15955144,
"heapUsedBytes": 77485792,
"domNodes": -269,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 354.02900000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3053.0090000000314,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7300000000000006,
"layouts": 6,
"layoutDurationMs": 1.4519999999999997,
"taskDurationMs": 797.3659999999999,
"heapDeltaBytes": -11543296,
"heapUsedBytes": 79552600,
"domNodes": -269,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 369.316,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.727,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.6770000000000005,
"layouts": 6,
"layoutDurationMs": 1.6270000000000004,
"taskDurationMs": 677.3,
"heapDeltaBytes": -30624608,
"heapUsedBytes": 62161044,
"domNodes": -269,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 34.011,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.9839999999522,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.035,
"layouts": 8,
"layoutDurationMs": 2.1809999999999996,
"taskDurationMs": 647.1830000000001,
"heapDeltaBytes": -26142056,
"heapUsedBytes": 66712376,
"domNodes": -269,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 32.299,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2906.151999999992,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.447,
"layouts": 6,
"layoutDurationMs": 1.7109999999999999,
"taskDurationMs": 620.324,
"heapDeltaBytes": -6478468,
"heapUsedBytes": 69765208,
"domNodes": -266,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 193.32399999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666091954022985,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2803.13000000001,
"styleRecalcs": 26,
"styleRecalcDurationMs": 12.121,
"layouts": 6,
"layoutDurationMs": 1.395,
"taskDurationMs": 630.577,
"heapDeltaBytes": -21376788,
"heapUsedBytes": 71291876,
"domNodes": -259,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 218.26000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571428,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3273.36600000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8259999999999994,
"layouts": 7,
"layoutDurationMs": 1.7619999999999998,
"taskDurationMs": 931.3,
"heapDeltaBytes": 3494628,
"heapUsedBytes": 78773204,
"domNodes": -269,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 384.85400000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665816326530614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3260.4199999999537,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.0899999999999999,
"layouts": 4,
"layoutDurationMs": 0.8809999999999998,
"taskDurationMs": 906.504,
"heapDeltaBytes": 3407688,
"heapUsedBytes": 65315068,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 372.85699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751546391752576,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.5880000000075,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.819999999999999,
"layouts": 9,
"layoutDurationMs": 2.5309999999999997,
"taskDurationMs": 451.18600000000004,
"heapDeltaBytes": -533348,
"heapUsedBytes": 61892396,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 147.008,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.4110000000092,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.231,
"layouts": 10,
"layoutDurationMs": 2.808,
"taskDurationMs": 454.518,
"heapDeltaBytes": 2320040,
"heapUsedBytes": 72971748,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 149.056,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2034.6879999999885,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.508,
"layouts": 8,
"layoutDurationMs": 2.513,
"taskDurationMs": 556.365,
"heapDeltaBytes": 2196724,
"heapUsedBytes": 63683140,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 8.447999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2022.448000000054,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7720000000000002,
"layouts": 10,
"layoutDurationMs": 2.999,
"taskDurationMs": 512.943,
"heapDeltaBytes": 5679656,
"heapUsedBytes": 78159080,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 7.249999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.8010000000183,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.286,
"layouts": 10,
"layoutDurationMs": 2.5329999999999995,
"taskDurationMs": 826.258,
"heapDeltaBytes": -6022596,
"heapUsedBytes": 67516012,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 112.35000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.0899999999701,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.049000000000001,
"layouts": 9,
"layoutDurationMs": 2.2489999999999997,
"taskDurationMs": 849.4739999999999,
"heapDeltaBytes": -5403832,
"heapUsedBytes": 67058580,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 107.303,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.6180000000295,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.665000000000003,
"layouts": 5,
"layoutDurationMs": 14.133,
"taskDurationMs": 1105.975,
"heapDeltaBytes": 13937416,
"heapUsedBytes": 117151152,
"domNodes": 16029,
"jsHeapTotalBytes": 9834496,
"scriptDurationMs": 34.02499999999999,
"eventListeners": 3246,
"totalBlockingTimeMs": 166,
"frameDurationMs": 20.090410958904116,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9456.613000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.983,
"layouts": 8,
"layoutDurationMs": 1.9709999999999996,
"taskDurationMs": 5982.037,
"heapDeltaBytes": 13829612,
"heapUsedBytes": 86482244,
"domNodes": -269,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 2747.19,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665961199294532,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9703.171999999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 27.523,
"layouts": 8,
"layoutDurationMs": 2.19,
"taskDurationMs": 5987.2570000000005,
"heapDeltaBytes": 3659996,
"heapUsedBytes": 77738264,
"domNodes": -269,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 2732.5840000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66615120274914,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23216.95699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22543.55,
"heapDeltaBytes": -37561716,
"heapUsedBytes": 263721044,
"domNodes": -3343,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 328.718,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.027068965517245,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23261.959000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22505.082,
"heapDeltaBytes": -30423616,
"heapUsedBytes": 252573664,
"domNodes": -3343,
"jsHeapTotalBytes": 9166848,
"scriptDurationMs": 328.7099999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.975601374570445,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 27776.770999999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.40800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27413.159,
"heapDeltaBytes": -19846416,
"heapUsedBytes": 263445784,
"domNodes": -3343,
"jsHeapTotalBytes": 13361152,
"scriptDurationMs": 919.37,
"eventListeners": -651,
"totalBlockingTimeMs": 10,
"frameDurationMs": 50.697445255474456,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27845.640000000003,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.267000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27469.755,
"heapDeltaBytes": -18808128,
"heapUsedBytes": 273333156,
"domNodes": -3343,
"jsHeapTotalBytes": 12050432,
"scriptDurationMs": 874.114,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 51.35092250922509,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8285.099000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.53299999999999,
"layouts": 20,
"layoutDurationMs": 29.09500000000001,
"taskDurationMs": 8123.965999999999,
"heapDeltaBytes": -23702888,
"heapUsedBytes": 268568832,
"domNodes": -3343,
"jsHeapTotalBytes": 19652608,
"scriptDurationMs": 124.631,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.331999999999994,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8217.456999999968,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.38400000000001,
"layouts": 20,
"layoutDurationMs": 23.591,
"taskDurationMs": 8091.554999999999,
"heapDeltaBytes": -29518400,
"heapUsedBytes": 267666128,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 122.871,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.14505494505493,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11495.356000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11227.036,
"heapDeltaBytes": -11101456,
"heapUsedBytes": 261932680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.83100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.59620689655173,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11323.577000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11012.276000000002,
"heapDeltaBytes": -10963200,
"heapUsedBytes": 262722188,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 147.41899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.98621908127209,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 140.32500000001846,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.76,
"layouts": 9,
"layoutDurationMs": 4.817,
"taskDurationMs": 101.55600000000001,
"heapDeltaBytes": 4780592,
"heapUsedBytes": 64366632,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.804,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 118.43200000009801,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.9559999999999995,
"layouts": 7,
"layoutDurationMs": 2.997,
"taskDurationMs": 80.84599999999999,
"heapDeltaBytes": 4643632,
"heapUsedBytes": 65601072,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.414999999999999,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 584.2239999999492,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6489999999999999,
"layouts": 76,
"layoutDurationMs": 15.179,
"taskDurationMs": 535.31,
"heapDeltaBytes": -2943696,
"heapUsedBytes": 41747308,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 265.50800000000004,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 494.4629999999961,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6579999999999999,
"layouts": 76,
"layoutDurationMs": 14.14,
"taskDurationMs": 450.017,
"heapDeltaBytes": -4120060,
"heapUsedBytes": 39126140,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 218.832,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 505.7010000000446,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.625,
"layouts": 76,
"layoutDurationMs": 14.095999999999998,
"taskDurationMs": 478.088,
"heapDeltaBytes": 972564,
"heapUsedBytes": 102650160,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 191.551,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 508.9460000000372,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7,
"layouts": 76,
"layoutDurationMs": 14.177,
"taskDurationMs": 474.6360000000001,
"heapDeltaBytes": -69172,
"heapUsedBytes": 94079020,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 188.391,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 60.1% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3164 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3f85554c8a967e49758463a0a09c96b959d84042
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (281)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22216 +/- ##
==========================================
- Coverage 87.50% 87.49% -0.01%
==========================================
Files 2932 2933 +1
Lines 159209 159245 +36
Branches 43655 43735 +80
==========================================
+ Hits 139314 139339 +25
- Misses 18973 18984 +11
Partials 922 922
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
wei-hai
left a comment
There was a problem hiding this comment.
Review
frontend REQUEST_CHANGES.
Ingest-types regen from cloud@e675d5c0 looks faithful (deployment status enum, served_from invoice, etc.). CI typecheck fails: zBillingStatusResponse now includes period_credit_grant with Zod bigint credits, and projectBillingStatus spreads that into BillingStatusResponse (credits: number) → TS2322 in billingStatusView.ts. Project/coerce period_credit_grant (same asSafeNumber pattern as other int64 fields) before merge.
Verdict: REQUEST_CHANGES
dbf7e6f to
02e72d2
Compare
02e72d2 to
a392706
Compare
|
Typecheck is red on this regen, so the next ingest type update cannot land either.
Full context for agent readersRun: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/40850216365/job/123367524551. Other red jobs (lint, preflight, test, e2e-status) look downstream of the same failure. Older chore PRs from the same cloud commit (#22027 cloud-1.59, #21422 cloud-1.58) are also red. |
wei-hai
left a comment
There was a problem hiding this comment.
Review
Re-review after prior CHANGES_REQUESTED. frontend REQUEST_CHANGES.
Same blocker on head a3927067 (cloud@0778e9d4 regen): period_credit_grant.credits is Zod bigint while BillingStatusResponse expects number, and projectBillingStatus still spreads ...rest → TS2322 at billingStatusView.ts:59. Project/coerce via asSafeNumber (and a focused test) before merge; types-only PR does not fix the consumer.
Verdict: REQUEST_CHANGES
a392706 to
991e577
Compare
wei-hai
left a comment
There was a problem hiding this comment.
Review
Re-review after prior CHANGES_REQUESTED. frontend REQUEST_CHANGES.
Same blocker on head 991e577 (cloud@89e5b586 regen): types-only PR still leaves period_credit_grant.credits as Zod bigint while BillingStatusResponse expects number, and projectBillingStatus still spreads ...rest → TS2322 at billingStatusView.ts:59. Project via asSafeNumber (plus a focused test) before merge.
Verdict: REQUEST_CHANGES
991e577 to
abd77dc
Compare
abd77dc to
6acb959
Compare
The regenerated zod schemas decode period_credit_grant.credits and the balance's max_topup_cents and max_topup_credits as bigint, while the host's billing types read them as number. projectBillingStatus now converts the grant's credits with asSafeNumber and drops only the grant when a number cannot hold them, the way it drops an unreadable renewal invoice. The new projectBillingBalance does the same for the top-up cap, dropping both fields together. WorkspaceDeployment now requires can_start, so every fixture gains it: true for a stopped or failed deployment, false otherwise.
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
…s type The regenerated ingest types (#22216) narrow WorkspaceDeployment.status to the statuses ingest serves, so the Start tests' helpers and tables now take WorkspaceDeployment['status'] instead of a plain string.
…-1279) (Comfy-Org#21839) ## Summary In the Run bar's deployment menu, a deployment the listing says can start (`can_start`) can be started from its row. - While the `deployment_start_enabled` flag is off, such a row shows Start with an arrow. Choosing it opens the deployment's page on the Developer Platform (`/profile/deployments/{id}`) in a new tab, where it can be started. Production shows this until the flag is on. - While the flag is on, choosing Start calls the start route. The row reads Starting until the listing asked for after the server took it lands, then shows the listing's status. The open menu refreshes the listing every 5 s while a row is on its way up. When the deployment is ready, the row shows its version and can be picked. The editor does not switch to it. - If the server refuses the Start, the row says that it did not start, shows the server's own message when there is one, and says how to fix it, keyed on the server's code. Retry starts it again. The reason is also the row's accessible description. - If the deployment fails after the server took the Start, the next listing shows it as Failed, with Start again. - If the server answers 403 (an API-key session, or the rollout flag is off), the row falls back to the Developer Platform link and offers no Retry. - If this browser runs on a stopped or failed deployment, the menu opens with a notice that says which, and the picked row has Start. Run does not change. Closes DES-1279 Builds on Comfy-Org#21858, now on `main`, which makes only a ready deployment pickable. This branch is rebased onto `main`. Uses `can_start` and the listing's `started_deployment_id` from Comfy-Org/cloud#16947, now merged and regenerated into `@comfyorg/ingest-types` by Comfy-Org#22216. This PR has no edits to `packages/ingest-types`. The regeneration narrows `status` to the statuses ingest serves, so the last commit types the Start test fixtures with `WorkspaceDeployment['status']`. Design: the "Deployment menu" canvas, https://claude.ai/artifact/MGGME6U7xjXtberxNaoNUy (boards J1 to J6). ## The start route Ingest's `POST /api/workspaces/{id}/deployments/{deployment_id}/start` landed in Comfy-Org/cloud#15759 (BE-23058). On 27 Oct it answered on testcloud and staging, but not on production: cloud.comfy.org returned 404. It takes no body and answers 202 with `deployment_id` and `status` (`StartWorkspaceDeploymentResult`, parsed with its zod schema). It refuses with 400, 402, 409 or 429 and passes on comfy-deploy's code and message. comfy-deploy's start is idempotent: a deployment that is already up comes back unchanged, so a second Start does no harm. Comfy-Org/cloud#16947 fixes two things the listing did: - It kept each caller's listing for 30 s on each of several ingest servers, with no sticky routing, so the refresh after a Start could still say stopped. A listing now names each deployment this browser started (`started_deployment_id`, repeated), and a server whose cached listing still offers Start on one lists it again. A listing with a deployment on the move is kept for 5 s. - It did not say which rows Start brings back. `can_start` is true while a deployment is stopped or failed, the statuses comfy-deploy's start re-runs. Turn `deployment_start_enabled` on in an environment once its ingest serves the route and `can_start`. On an older ingest no row offers Start or the link. ## Decisions to review - The menu renders the listing's status and `can_start` as received (ADR-API-SERVER-FACTS-0042). Picking a ready row keeps Comfy-Org#21858's `pendingServerFact('BE-24332', …)`, now in `deploymentRowAction`. This page remembers only two things of its own: a Start in flight, and the server's refusal. It no longer works out from listing snapshots whether a Start failed. - A Start in flight lasts until the listing asked for after the server took it lands. A refusal lasts while the listing says the deployment can still start, so it is dropped when the deployment is started or stopped elsewhere. - After the server takes a Start, every listing names that deployment until one asked for after the Start offers Start on it again or no longer lists it. It reads `can_start`, not a status list, and a listing already in flight when the Start was taken never drops it. Names the listing does not offer Start on cost ingest nothing. - A refusal's fix follows the server's code: `PAYMENT_REQUIRED` and `CONCURRENCY_LIMIT` have their own copy, and any other refusal reads as a generic failure. A 403, 404, 405 or 501 falls back to the Developer Platform link. A message is shown only when the server sent a code with it. - A Start the server did not answer (no status, a timeout, a 5xx, or a failure that is not an API error) is reported as `error_starting_deployment`. - With the flag off, a row that can start links to its deployment's page instead of doing nothing. That page has its own Start. The link reuses the Start label with an arrow, so the row reads the same with the flag on or off. - On a stopped deployment that this browser runs on, Run does not change. The engine button's tooltip and the menu's notice say to start the deployment. - Start, Retry and link rows stay reachable by keyboard. Their accessible names are "Start Flux Studio · staging", "Retry starting Flux Studio · staging" and "Start Flux Studio · staging on the Developer Platform". - Copy: 16 new strings. English only: the release workflow translates the other catalogs. ## Follow-ups - comfy-deploy has a sentence for the customer saying why a deployment failed (`error`) on its single read, not on its list rows. Passing it on in the listing needs a comfy-deploy change, so a failed row shows only Failed for now. - `can_pick` from the review of Comfy-Org#21858 is not part of this stack. ## Verification - Unit: `src/platform/workspace`, `TopMenuSection`, and the other files whose fixtures gained `can_start` (now in Comfy-Org#22216), 49 files and 1,242 tests, pass at this head. - `deploymentPickStore.test.ts`: a started deployment stays named after a listing that shows it queued or ready, is dropped after one that offers Start on it again or no longer lists it, and is kept when a listing asked for before its Start says it can start. - `workspaceApi.webSessionRetry.test.ts`: the listing URL carries one `started_deployment_id` per started deployment, through real axios and the web-session adapter. - `deploymentStartState.test.ts`: every Start event, and the action and reason of each row, against the listing's `can_start`. - `DeploymentSwitcher.test.ts`: the listing after a Start names the started deployment; Start only where the listing says it can start; Starting until the listing after the Start lands, whatever an older listing says; a Start that later fails shows Failed with Start; a refused Start and Retry, with the reason as the row's description; 429s told apart by code, including `RATE_LIMITED`; which failures are reported; the link after a 403 and with the flag off; the 5 s refresh skipped while the last is pending; the notice and tooltip on a stopped or failed deployment this browser runs on. - `workspaceApi.test.ts`: `startDeployment` sends POST to the encoded start path with no body and a 30 s timeout, rejects an answer without a status, and turns a refusal into a `WorkspaceApiError` with its code. - Pre-commit (oxfmt, stylelint, oxlint, eslint, the server-facts check) and pre-push (knip, fallow) pass. `typecheck:app` is clean. - Not run: the browser against a backend with Comfy-Org/cloud#16947. The screenshots below are from the earlier build with a mocked listing and were not retaken. ## Screenshots | State | After | | --- | --- | | Flag off: stopped and failed rows link to their page. The reason shows on hover. | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-08-link-hovered.png"> | | Flag on, with the compatibility check: a stopped row that cannot run the workflow offers Start under Incompatible environments | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/ea2c3f3a6cb2b105385e4e50c719108c3d09b1af/DES-1279-g-s5-sections-start.png"> | | Flag on: stopped rows offer Start. The reason shows on hover. | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-01-start.png"> | | Starting, after Start | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-02-starting.png"> | | Ready after the refresh, and can be picked | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-04-ready.png"> | | The server refused the Start (402) | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/a642ac95f63b3b7825d2086ded1d460d28b25cd2/DES-1279-e-j2-03-failed.png"> | | The server answered 403: the row falls back to the link | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-05-not-allowed.png"> | | On a stopped deployment: engine button tooltip | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-06a-active-stopped-tooltip.png"> | | On a stopped deployment: the menu | <img width="400" src="https://gist.githubusercontent.com/shrimbly/4d6895d95a290d70d471f09b5e53bea5/raw/65e63736e8f7fbbc4a7652019c15e5ceff1a27c8/DES-1279-f-j2-06b-active-stopped-open.png"> | --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
…omfy-Org#22101) ## ELI5 If the live connection drops while a run finishes, the app fetches the run's results when it reconnects and puts them back on the canvas. For a node that ComfyUI expanded into other nodes while running, those results went to the hidden expanded id instead of the node you see. They now go to the visible node, the same one the live message would have used. ## Summary - Follow-up from Comfy-Org#21282, gap 2 of [FRONT-3481](https://linear.app/comfyorg/issue/FRONT-3481). - `useReconnectQueueRefresh` replayed each output as `executed` with `display_node: node`. A live frame for an expanded node carries the original node as `display_node`, and `app.ts` routes outputs by `display_node || node`. - It now reads `display_node` from the job detail's `execution_meta` through the generated `zJobExecutionMetaEntry` (cloud#16987, picked up in Comfy-Org#22216). No hand-written API schema remains. - `execution_meta` stays `z.unknown()` in `zJobDetail` and each entry is parsed on its own, so bad metadata cannot fail the detail parse or drop the other entries. A list, a malformed entry or an entry without `display_node` falls back to the output key, so servers without the field behave as before. - An entry whose `node_id` names a different node is ignored. A cached output carries the metadata of the node that first ran it until ComfyUI#17397 lands, and following it would move that output off its own node. - Replay order matches live for a shared display node: ComfyUI sends a node's own output first (`execution.py`, the `executed` send comes before the `has_subgraph` branch), then the outputs of the nodes it expanded into. Known limit: `outputs` carries no timestamps, so two expanded children on one display node replay in key order, which may differ from the order they finished. Live frames have no `merge`, so one of them wins either way. The history-preview fallback (no job detail) still uses the preview's node id; list items carry no metadata. ## Tests `useReconnectQueueRefresh.test.ts`, each red before the fix: expanded output reaches its display node; own output replays before the expanded output; cached metadata naming another node is ignored; a list-shaped `execution_meta` is ignored; no, malformed or display-node-less metadata falls back to the key. ## Backports `core/1.58`, `cloud/1.58`, `core/1.59`, `cloud/1.59`. Those branches don't have the generated entry yet, so the backports need the schema carried with them or the branch's ingest-types update first.
Brings the consumer repairs that main made across the ingest syncs since cloud/1.59 branched (#21701, #22216, #22434, #22354): - account-core decoders accept an omitted ended_at / next_charge / auto_top_up_enabled and drop unreadable plan feature items, as on main - host BillingStatusResponse / BillingCapabilitiesRead keep those fields optional; status, plans, capabilities and balance projections read the new int64 fields (next_charge.amount, period_credit_grant.credits, feature_items params.count, top-up bounds) as safe numbers - fixtures gain the new required fields (can_start, max_owned_workspaces, auto reload settings, ended_at / next_charge, auto_top_up_enabled) - zod.gen.ts formatted with oxfmt, matching main byte for byte
…dc0 (#22354) (#22715) Manual backport of #22354 (squash 1af9270) to `core/1.59`. The auto-backport failed with cherry-pick conflicts. ## Why core/1.59 should ship the same ingest contract as main. The cloud/1.59 counterpart is #22027. ## Root cause The cherry-pick conflicts because 1af9270's fallout edits main-only modules (`@comfyorg/billing-core`). core/1.59 also skipped the earlier ingest syncs (#21701, #22216, #22434), so their consumer repairs are needed too. ## How - `packages/ingest-types/src/{types.gen,zod.gen,index}.ts` taken verbatim from main at 1af9270. This is byte-identical to the bot's cloud/1.59 output in #22027 (cloud@67878a6e) after oxfmt; both regenerate from cloud main, the only difference was formatting. - account-core decoders: `ended_at` / `next_charge` / `auto_top_up_enabled` optional (older servers omit them), and plan `feature_items` that don't parse are dropped. Same as main. - host `BillingStatusResponse` / `BillingCapabilitiesRead` keep those same fields optional, as main does. - `billingStatusView` / `billingPlansView` / `billingCapabilitiesView` / new `billingBalanceView` project the new int64 fields (`next_charge.amount`, `period_credit_grant.credits`, `feature_items[].params.count`, top-up bounds) through `asSafeNumber`. Ported from main along with its tests. - Fixtures and mocks gain the new required fields (`can_start`, `max_owned_workspaces`, the auto-reload settings fields, `ended_at`/`next_charge`, `auto_top_up_enabled`). `agentTurnLockFixture` gets the `doc_seq` wire projection from #21701. Conflict resolution: took the incoming generated files whole, then ported each fallout fix to core/1.59's paths (`@/platform/workspace/api/workspaceApi`). Dropped `deploymentLibraryModelsStore.test.ts` because that cloud-only file doesn't exist on core/1.59. ## AS IS / TO BE N/A: a type sync with no UI change. ## Verification - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm typecheck:workspaces` pass - vitest on the touched src tests + billing sdk view/store tests: 26 files / 1463 tests passed - account-core billing status/plans/capabilities + contracts: 172 tests passed - billing-web `billingWebClient.test.ts`, `CheckoutView.streams.test.ts`: 19 tests passed
Automated Ingest API Type Update
This PR updates the Ingest API TypeScript types and Zod schemas from the latest cloud OpenAPI specification.
These types cover the FE-facing ingest API (workspaces, billing, secrets, assets, tasks, etc.).
Cloud's internal / machine-to-machine surface —
x-internaloperations and the/admin/,/api/internal/,/api/webhooks/rails — is stripped before generation(BE-2669), so it is not code-generated into this public package.