Repository navigation
[backport cloud/1.59] fix: match model picker text size to other widgets - #22120
Conversation
<!-- claude-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1793144276531189?thread_ts=1793144276.531189&cid=C0A4XMHANP3)_ ## Summary The model picker value text rendered larger than other widgets. After #20988 added a global `button { font: inherit }` reset, the inner value button inherits `text-base` from the dropdown input root, so it no longer matches the `text-xs` used by combo and number widgets. - **Before:** model picker value text renders at 16px, larger than neighboring widgets. - **After:** it renders at 12px (`text-xs`), matching other widgets. How: `FormDropdownInput.vue` root classes change `text-base` to `text-xs`. The dropdown menu items were already `text-xs`, so nothing else in the family changes. ## Verification - Tests: `pnpm exec vitest run src/renderer/extensions/vueNodes/widgets/components/form/dropdown` passes (129 tests); `pnpm typecheck`, oxfmt, oxlint, eslint and the pre-commit hooks pass. - Human QA: on a node with a model picker (e.g. Load Checkpoint), compare the value text size against a combo or number widget; they should match. No screenshots attached. --- _Generated by [Claude Code](https://claude.ai/code/session_01MUqgfmFn3gGxD33FeHpnKn)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-28T05:59:33.691Z",
"gitSha": "cf38a890c5a0771afd8f34646995c6db0d616f68",
"branch": "backport-22096-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.9470000000163,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6769999999999996,
"layouts": 9,
"layoutDurationMs": 2.6510000000000007,
"taskDurationMs": 536.591,
"heapDeltaBytes": 1825140,
"heapUsedBytes": 62995068,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.698999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2008.3720000000085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.765,
"layouts": 9,
"layoutDurationMs": 2.431,
"taskDurationMs": 460.15500000000003,
"heapDeltaBytes": 1944456,
"heapUsedBytes": 62456744,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.151000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1691.8699999999944,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.481,
"layouts": 9,
"layoutDurationMs": 2.3960000000000004,
"taskDurationMs": 770.4879999999999,
"heapDeltaBytes": 21709896,
"heapUsedBytes": 83027820,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 131.703,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.9099999999794,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.82,
"layouts": 9,
"layoutDurationMs": 2.129,
"taskDurationMs": 767.3340000000001,
"heapDeltaBytes": 21559112,
"heapUsedBytes": 82657880,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 136.37000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82941176470588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.2569999999992,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.384,
"layouts": 10,
"layoutDurationMs": 3.0319999999999996,
"taskDurationMs": 405.45699999999994,
"heapDeltaBytes": 24777044,
"heapUsedBytes": 86102824,
"domNodes": 56,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.253000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0920000000178,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.968000000000001,
"layouts": 10,
"layoutDurationMs": 2.746,
"taskDurationMs": 357.952,
"heapDeltaBytes": 22880652,
"heapUsedBytes": 84028336,
"domNodes": 56,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 12.197999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 600.9740000000079,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.925,
"layouts": 9,
"layoutDurationMs": 2.59,
"taskDurationMs": 448.26700000000005,
"heapDeltaBytes": 3339652,
"heapUsedBytes": 64537404,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 146.739,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 551.0679999999866,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.621,
"layouts": 9,
"layoutDurationMs": 2.2720000000000002,
"taskDurationMs": 409.681,
"heapDeltaBytes": 3006684,
"heapUsedBytes": 63818352,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 137.504,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1066.1159999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 752.483,
"heapDeltaBytes": -980532,
"heapUsedBytes": 74933916,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 50.8,
"eventListeners": -106,
"totalBlockingTimeMs": 396,
"frameDurationMs": 29.63055555555555,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1083.394999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.234,
"heapDeltaBytes": -1512812,
"heapUsedBytes": 74720932,
"domNodes": -191,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 49.75300000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 414,
"frameDurationMs": 30.091666666666658,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 816.1819999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.4069999999998,
"heapDeltaBytes": -26387956,
"heapUsedBytes": 66383768,
"domNodes": -191,
"jsHeapTotalBytes": 4325376,
"scriptDurationMs": 131.92000000000004,
"eventListeners": -106,
"totalBlockingTimeMs": 158,
"frameDurationMs": 22.68333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 815.985000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.75699999999995,
"heapDeltaBytes": -25617272,
"heapUsedBytes": 66375980,
"domNodes": -191,
"jsHeapTotalBytes": 4063232,
"scriptDurationMs": 120.43499999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 163,
"frameDurationMs": 23.33428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7649.448999999976,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3839999999999998,
"layouts": 1,
"layoutDurationMs": 0.3700000000000001,
"taskDurationMs": 6860.066,
"heapDeltaBytes": 64584484,
"heapUsedBytes": 139056700,
"domNodes": -257,
"jsHeapTotalBytes": 59633664,
"scriptDurationMs": 5321.896,
"eventListeners": -68,
"totalBlockingTimeMs": 68,
"frameDurationMs": 24.676451612903225,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7688.855999999987,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.882,
"layouts": 3,
"layoutDurationMs": 0.6660000000000004,
"taskDurationMs": 6848.771,
"heapDeltaBytes": 64045652,
"heapUsedBytes": 136458216,
"domNodes": -257,
"jsHeapTotalBytes": 51245056,
"scriptDurationMs": 5287.727,
"eventListeners": -68,
"totalBlockingTimeMs": 60,
"frameDurationMs": 23.934267912772587,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8770.981000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9690000000000002,
"layouts": 3,
"layoutDurationMs": 0.932,
"taskDurationMs": 7944.101000000001,
"heapDeltaBytes": 55138888,
"heapUsedBytes": 149546328,
"domNodes": -257,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 6222.910000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 131,
"frameDurationMs": 24.810734463276837,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7615.774000000045,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5210000000000006,
"layouts": 2,
"layoutDurationMs": 0.441,
"taskDurationMs": 6776.128,
"heapDeltaBytes": -8935880,
"heapUsedBytes": 79700676,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 5305.799,
"eventListeners": -68,
"totalBlockingTimeMs": 110,
"frameDurationMs": 24.41121794871795,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 214.4360000000063,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.686,
"layouts": 12,
"layoutDurationMs": 3.2880000000000003,
"taskDurationMs": 155.22699999999998,
"heapDeltaBytes": 14464192,
"heapUsedBytes": 84083760,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 7.5680000000000005,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44166666666668,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 204.65899999999237,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.364,
"layouts": 12,
"layoutDurationMs": 3.7619999999999996,
"taskDurationMs": 185.36300000000003,
"heapDeltaBytes": -4038968,
"heapUsedBytes": 66616728,
"domNodes": -2315,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.722999999999999,
"eventListeners": -573,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.66999999999998,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2057.2879999999714,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3689999999999998,
"layouts": 8,
"layoutDurationMs": 2.202,
"taskDurationMs": 624.0260000000001,
"heapDeltaBytes": -529996,
"heapUsedBytes": 79333124,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 34.50900000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2024.944000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.73,
"layouts": 9,
"layoutDurationMs": 2.314,
"taskDurationMs": 602.6600000000001,
"heapDeltaBytes": 12017444,
"heapUsedBytes": 85549764,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.812000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836065,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2788.4579999999914,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.397,
"layouts": 7,
"layoutDurationMs": 1.8239999999999998,
"taskDurationMs": 1528.6219999999998,
"heapDeltaBytes": -2154264,
"heapUsedBytes": 76796204,
"domNodes": -257,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 740.9839999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66586826347305,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2900.7100000000037,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.241,
"layouts": 7,
"layoutDurationMs": 1.8100000000000003,
"taskDurationMs": 1456.8660000000002,
"heapDeltaBytes": 10400864,
"heapUsedBytes": 85493404,
"domNodes": -257,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 688,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66609195402299,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3652.337999999986,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.235999999999999,
"layouts": 64,
"layoutDurationMs": 10.551000000000002,
"taskDurationMs": 1568.671,
"heapDeltaBytes": -5140592,
"heapUsedBytes": 70031464,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 672.298,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657535,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3702.2289999999884,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.847999999999999,
"layouts": 64,
"layoutDurationMs": 10.575,
"taskDurationMs": 1549.732,
"heapDeltaBytes": 5841740,
"heapUsedBytes": 86148292,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 701.0959999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741176470588236,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3033.126999999979,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.482999999999999,
"layouts": 6,
"layoutDurationMs": 1.4720000000000002,
"taskDurationMs": 1774.359,
"heapDeltaBytes": 16877476,
"heapUsedBytes": 94104056,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 866.548,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75801104972376,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2841.777000000036,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.678999999999999,
"layouts": 7,
"layoutDurationMs": 1.6349999999999998,
"taskDurationMs": 1695.151,
"heapDeltaBytes": 17157912,
"heapUsedBytes": 95324892,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 838.832,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763529411764704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2956.988999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.197,
"layouts": 8,
"layoutDurationMs": 1.9289999999999998,
"taskDurationMs": 670.8190000000001,
"heapDeltaBytes": -6157392,
"heapUsedBytes": 73516592,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 290.945,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66629213483146,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 2924.3230000000153,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.21,
"layouts": 8,
"layoutDurationMs": 1.9949999999999999,
"taskDurationMs": 663.1070000000001,
"heapDeltaBytes": -15406596,
"heapUsedBytes": 77927220,
"domNodes": -257,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 300.585,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66647727272727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2017.515000000003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1949999999999998,
"layouts": 5,
"layoutDurationMs": 1.1480000000000001,
"taskDurationMs": 558.6120000000001,
"heapDeltaBytes": 9165128,
"heapUsedBytes": 70375616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.395,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2032.587000000035,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.165,
"layouts": 7,
"layoutDurationMs": 1.951,
"taskDurationMs": 614.0260000000001,
"heapDeltaBytes": -10667348,
"heapUsedBytes": 67026860,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 32.53399999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2693.238000000008,
"styleRecalcs": 27,
"styleRecalcDurationMs": 10.780000000000001,
"layouts": 8,
"layoutDurationMs": 1.548,
"taskDurationMs": 498.72400000000005,
"heapDeltaBytes": -28503216,
"heapUsedBytes": 64488232,
"domNodes": -249,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 151.995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665432098765432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2706.403000000023,
"styleRecalcs": 27,
"styleRecalcDurationMs": 11.182,
"layouts": 8,
"layoutDurationMs": 1.8869999999999998,
"taskDurationMs": 508.674,
"heapDeltaBytes": -1146044,
"heapUsedBytes": 79427624,
"domNodes": -245,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 153.423,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666049382716047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3062.0030000000042,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9649999999999996,
"layouts": 7,
"layoutDurationMs": 1.655,
"taskDurationMs": 788.877,
"heapDeltaBytes": 5478760,
"heapUsedBytes": 82146048,
"domNodes": -257,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 295.07700000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3065.5909999999835,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1610000000000005,
"layouts": 8,
"layoutDurationMs": 1.879,
"taskDurationMs": 783.649,
"heapDeltaBytes": -1865404,
"heapUsedBytes": 74138356,
"domNodes": -257,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 293.06699999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.8759999999938,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.9959999999999996,
"layouts": 9,
"layoutDurationMs": 2.2410000000000005,
"taskDurationMs": 381.403,
"heapDeltaBytes": -854724,
"heapUsedBytes": 60950624,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 125.753,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.4869999999855,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.4159999999999995,
"layouts": 11,
"layoutDurationMs": 3.0239999999999996,
"taskDurationMs": 375.049,
"heapDeltaBytes": 3307880,
"heapUsedBytes": 75410980,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 123.197,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.2199999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.808999999999999,
"layouts": 9,
"layoutDurationMs": 2.701,
"taskDurationMs": 538.897,
"heapDeltaBytes": 1086792,
"heapUsedBytes": 62867536,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.064,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2008.7630000000445,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4399999999999995,
"layouts": 9,
"layoutDurationMs": 2.321,
"taskDurationMs": 452.17900000000003,
"heapDeltaBytes": 270600,
"heapUsedBytes": 62031928,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 9.477,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.8580000000118,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.144000000000002,
"layouts": 8,
"layoutDurationMs": 1.9370000000000003,
"taskDurationMs": 785.32,
"heapDeltaBytes": 18891864,
"heapUsedBytes": 80467808,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 106.49700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.454000000031,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.063000000000002,
"layouts": 9,
"layoutDurationMs": 2.214000000000001,
"taskDurationMs": 702.2280000000001,
"heapDeltaBytes": 17510356,
"heapUsedBytes": 79323592,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 93.909,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.3439999999832,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.033,
"layouts": 5,
"layoutDurationMs": 12.676,
"taskDurationMs": 910.4039999999998,
"heapDeltaBytes": 16628480,
"heapUsedBytes": 109543572,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 25.614000000000004,
"eventListeners": 3246,
"totalBlockingTimeMs": 114,
"frameDurationMs": 19.246478873239436,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11078.580999999986,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.037999999999997,
"layouts": 8,
"layoutDurationMs": 1.905,
"taskDurationMs": 5262.4220000000005,
"heapDeltaBytes": 8465280,
"heapUsedBytes": 85643292,
"domNodes": -257,
"jsHeapTotalBytes": 5300224,
"scriptDurationMs": 2342.173,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665864661654133,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9046.375000000011,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.709999999999997,
"layouts": 9,
"layoutDurationMs": 2.2250000000000005,
"taskDurationMs": 4926.31,
"heapDeltaBytes": 9895748,
"heapUsedBytes": 84797756,
"domNodes": -257,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2250.642,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611418047882,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 20608.415999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20000.228,
"heapDeltaBytes": -35396176,
"heapUsedBytes": 258109948,
"domNodes": -3343,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 291.47200000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.688848263254116,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20240.599999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19610.775,
"heapDeltaBytes": -38945420,
"heapUsedBytes": 262469012,
"domNodes": -3343,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 275.325,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.81672727272728,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 23418.425999999956,
"styleRecalcs": 179,
"styleRecalcDurationMs": 18.917000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23179.827,
"heapDeltaBytes": -46380428,
"heapUsedBytes": 255576616,
"domNodes": -3343,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 722.1709999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.26427221172023,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23964.590999999928,
"styleRecalcs": 178,
"styleRecalcDurationMs": 22.612999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23762.392,
"heapDeltaBytes": -36238676,
"heapUsedBytes": 265298404,
"domNodes": -3343,
"jsHeapTotalBytes": 17031168,
"scriptDurationMs": 792.455,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 46.9913725490196,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 7061.644000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.761,
"layouts": 20,
"layoutDurationMs": 28.415999999999997,
"taskDurationMs": 6971.348000000001,
"heapDeltaBytes": -48922656,
"heapUsedBytes": 247717532,
"domNodes": -3343,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 120.88199999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.061904761904756,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7314.9689999999055,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.057000000000016,
"layouts": 20,
"layoutDurationMs": 22.130999999999997,
"taskDurationMs": 7247.042,
"heapDeltaBytes": -30479236,
"heapUsedBytes": 271130500,
"domNodes": -3343,
"jsHeapTotalBytes": 17817600,
"scriptDurationMs": 109.411,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.61158536585366,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9981.53400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9705.573999999999,
"heapDeltaBytes": -5056512,
"heapUsedBytes": 253252312,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 128.837,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.495255474452556,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10234.602999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10035.833,
"heapDeltaBytes": 14824032,
"heapUsedBytes": 272989980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 137.00199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.50965250965251,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 119.5769999999925,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.723999999999998,
"layouts": 7,
"layoutDurationMs": 2.842,
"taskDurationMs": 94.99300000000001,
"heapDeltaBytes": -12249132,
"heapUsedBytes": 63560796,
"domNodes": 137,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.996999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 126.17900000009286,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.152,
"layouts": 8,
"layoutDurationMs": 3.173,
"taskDurationMs": 83.43100000000001,
"heapDeltaBytes": 4611748,
"heapUsedBytes": 64340968,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.380999999999998,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 296.1440000000266,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.584,
"layouts": 76,
"layoutDurationMs": 12.455,
"taskDurationMs": 258.193,
"heapDeltaBytes": -6176204,
"heapUsedBytes": 35636408,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 112.79,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 390.77500000007603,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.71,
"layouts": 76,
"layoutDurationMs": 15.189,
"taskDurationMs": 341.392,
"heapDeltaBytes": -4856628,
"heapUsedBytes": 37005788,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 156.274,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 447.18600000010156,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.2590000000000003,
"layouts": 76,
"layoutDurationMs": 14.121,
"taskDurationMs": 414.278,
"heapDeltaBytes": -417336,
"heapUsedBytes": 93115168,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 156.529,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 389.62199999991753,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.553,
"layouts": 76,
"layoutDurationMs": 13.998,
"taskDurationMs": 363.068,
"heapDeltaBytes": -90108,
"heapUsedBytes": 88776096,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 129.279,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🎭 Playwright: ✅ 3125 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e05ecb75779297097781020ec688463459239209
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (217)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
<!-- claude-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0A4XMHANP3/p1793144276531189?thread_ts=1793144276.531189&cid=C0A4XMHANP3)_ **Before:** `lint-pr / lint` fails on `cloud/1.59` with `'commands.Comfy_3DViewer_Open3DViewer' does not exist in localization message resources` in `Load3DViewerButton.vue`, which also blocks #22120. **After:** `src/locales/en/commands.json` has the `Comfy_3DViewer_Open3DViewer` entry again (identical to `main`), so the lint error is gone. **Cause:** the key was missing from the locale files on `cloud/1.59` (dropped by a locale regeneration in the 1.59.2 release bump), and the failure surfaced after the #22087 backport. **How:** restored the 3-line entry in `src/locales/en/commands.json` from `main`. Verified with eslint on `Load3DViewerButton.vue` (2 errors before, clean after), `pnpm format:check`, and `pnpm typecheck`. --- _Generated by [Claude Code](https://claude.ai/code/session_01MUqgfmFn3gGxD33FeHpnKn)_ Co-authored-by: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22120 +/- ##
=============================================
Coverage ? 87.63%
=============================================
Files ? 2787
Lines ? 154957
Branches ? 40037
=============================================
Hits ? 135798
Misses ? 18485
Partials ? 674
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22096 to
cloud/1.59Automatically created by backport workflow.