Repository navigation
[backport cloud/1.59] fix(settings): admit Members when the server says the actor can manage them - #22095
Conversation
…e them (#22073) ## Why An Enterprise workspace owner could not see or manage members ([FE-3618](https://linear.app/comfyorg/issue/FE-3618)). He was signed in to a Cloud workspace from a non-Cloud bundle, and in that state the Members entry does not exist. ## Root cause `useSettingUI.ts` gated the Workspace section and the Members entry inside it on two different axes: ```ts const shouldShowWorkspacePanel = computed(() => isLoggedIn.value) // login only const workspacePanels = isCloud ? [planPanel, membersPanel] : [planPanel] // build-time constant ``` `isCloud` is `__DISTRIBUTION__ === 'cloud'`, statically replaced at build and unable to change at runtime. So a user signed in to a Cloud workspace from a non-Cloud bundle gets the Workspace section, gets Plan & Credits — their real Cloud billing, which is why the reporter's screenshot shows 41,419 Cloud credits — and never gets Members. That is the code's intended output, not a regression: the same gate is on `main`, `cloud/1.58`, `1.57` (prod) and `1.56`. On 1.57/1.56 it is formatted across lines, which is worth knowing if you grep for it. The server already owns this decision and publishes it as `can_manage_members` in the generated ingest contract, and the panel itself consumes it (`useMembersPanel.ts:134`, `MembersPanelContent.vue:150,195`). Only the nav entry ignored it, so a build-time constant stood in for a server-owned permission and refused a user the server considers a full owner. ## How ```diff -const workspacePanels = isCloud ? [planPanel, membersPanel] : [planPanel] +const canViewMembers = pendingServerFact( + 'BE-24066', + isCloud || canManageMembers.value +) +const workspacePanels = canViewMembers ? [planPanel, membersPanel] : [planPanel] ``` **The expression is wrapped because the fact it needs does not exist.** The server-fact gate rejected the first version of this PR, correctly: ADR-API-SERVER-FACTS-0042 rule 1 says a gate renders one server fact as received, and rule 2 says `isCloud` decides which build ships, not what a user may do. `isCloud || canManageMembers.value` is a derivation — the same pattern that shipped the two billing P0s in the ADR's own context, one of which (#15675) also lost member management for Enterprise owners. Viewing the roster is not `can_manage_members`: viewing is gated on `membersLoaded`, the capability gates the actions inside the panel, so Cloud non-owners read a roster today while it is false. Substituting it is exactly what rule 4 warns against. So this is rule 4's case — [BE-24066](https://linear.app/comfyorg/issue/BE-24066) asks the owning team which field should answer it, and `pendingServerFact` makes the gap expire: CI fails once that ticket closes, until the shipped field is rendered and this wrapper is deleted. **Additive, not a replacement, and that distinction is the point.** Viewing the roster is gated on `membersLoaded`, not on `can_manage_members` (`useMembersPanel.ts:143`), so Cloud members who are not owners see a read-only list today. Gating the entry on the capability alone would have silently taken that away from every Cloud non-owner — fixing one bug by introducing another. | | before | after | | --- | --- | --- | | Cloud owner | shown | shown | | Cloud non-owner | shown (read-only) | shown (read-only) | | non-Cloud, server permits | **hidden** | **shown** | | non-Cloud, server refuses | hidden | hidden | `canManageMembers` resolves through `receiveServerFact('can_manage_members', … ?? false)`, so it fails closed: if capabilities do not resolve, the entry stays hidden, which is today's behaviour. ## Tests `useSettingUI.test.ts`: `shows Members off Cloud when the server says the actor can manage them`. Mutation-checked — dropping `|| canManageMembers.value` fails it with `expected [ { id: 'workspace' } ] to deeply equal [ …, { id: 'workspace-members' } ]`. The two existing local cases still assert `workspace-members` is null and now mean "local and the server refuses", since the capability auto-mock defaults to false. 21/21 in that file. Repo typecheck (`scripts/vue-tsc-native.ts`) reports zero `src/` errors; oxlint `--type-aware` and oxfmt clean. ## Not verified here, and it gates the Desktop half Whether `workspaceApi.listMembers` actually serves a **Desktop-origin session**. The capability read works there — Plan & Credits proves the same auth and workspace context resolve — but that is inference, not proof, and I could not run a Desktop build. This is the one case where the change could be worse than today: if the capability is true but `listMembers` does not serve that session, the entry appears and the panel degrades to its minimal layout (`membersLoaded` false → `showMinimalMemberLayout`). No crash, but an entry that leads nowhere. **Please confirm on a real Desktop build signed into a Cloud workspace before merging.** If it does not serve, this becomes a product scope decision and FE-3618 should be retitled to "member management is unavailable on Desktop/local" instead. Cloud is unaffected either way — that path is unchanged. Tracks [FE-3645](https://linear.app/comfyorg/issue/FE-3645).
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T23:43:06.495Z",
"gitSha": "e10eec0d6a4f067173bc4aed1a19f14220a67a8a",
"branch": "backport-22073-to-cloud-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.0579999999914,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.8660000000000005,
"layouts": 6,
"layoutDurationMs": 1.7400000000000002,
"taskDurationMs": 562.1170000000001,
"heapDeltaBytes": 3860936,
"heapUsedBytes": 64821476,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 12.011000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.4260000000095,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.724,
"layouts": 9,
"layoutDurationMs": 2.6049999999999995,
"taskDurationMs": 515.293,
"heapDeltaBytes": 1380080,
"heapUsedBytes": 62964668,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8.453000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.0190000000252,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.465000000000002,
"layouts": 10,
"layoutDurationMs": 3.062,
"taskDurationMs": 907.595,
"heapDeltaBytes": 21443852,
"heapUsedBytes": 82779396,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 168.359,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.0560000000341,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.421999999999999,
"layouts": 9,
"layoutDurationMs": 2.8910000000000005,
"taskDurationMs": 867.008,
"heapDeltaBytes": 21397244,
"heapUsedBytes": 82571540,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 158.915,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.5369999999925,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.9350000000000005,
"layouts": 10,
"layoutDurationMs": 2.78,
"taskDurationMs": 410.287,
"heapDeltaBytes": -1483380,
"heapUsedBytes": 59443700,
"domNodes": 56,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 11.754999999999997,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.9360000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.481999999999999,
"layouts": 10,
"layoutDurationMs": 3.3609999999999998,
"taskDurationMs": 424.58399999999995,
"heapDeltaBytes": -277608,
"heapUsedBytes": 60476212,
"domNodes": 56,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 12.922000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 699.0040000000022,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.107,
"layouts": 9,
"layoutDurationMs": 2.751,
"taskDurationMs": 502.2089999999999,
"heapDeltaBytes": 3325288,
"heapUsedBytes": 64723972,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 170.787,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 695.7629999999426,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9090000000000003,
"layouts": 9,
"layoutDurationMs": 2.2230000000000003,
"taskDurationMs": 494.482,
"heapDeltaBytes": 5677028,
"heapUsedBytes": 66205500,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 171.472,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.839999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 933.331,
"heapDeltaBytes": -12417652,
"heapUsedBytes": 74750500,
"domNodes": -191,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 75.022,
"eventListeners": -106,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.88108108108108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1210.474999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.494,
"heapDeltaBytes": -12839828,
"heapUsedBytes": 74764380,
"domNodes": -191,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 72.72099999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 537,
"frameDurationMs": 32.87837837837838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 908.2970000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.6500000000004,
"heapDeltaBytes": -13793524,
"heapUsedBytes": 66448056,
"domNodes": -191,
"jsHeapTotalBytes": 1441792,
"scriptDurationMs": 180.94500000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 235,
"frameDurationMs": 24.770270270270245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.7830000000122,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.3190000000003,
"heapDeltaBytes": 22126580,
"heapUsedBytes": 87250068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.23099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11194.39,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10323.881,
"heapDeltaBytes": 70538108,
"heapUsedBytes": 144425032,
"domNodes": -257,
"jsHeapTotalBytes": 71954432,
"scriptDurationMs": 8265.181,
"eventListeners": -68,
"totalBlockingTimeMs": 1247,
"frameDurationMs": 31.32436974789916,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12421.71200000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11548.8,
"heapDeltaBytes": 108764840,
"heapUsedBytes": 181801724,
"domNodes": -257,
"jsHeapTotalBytes": 91090944,
"scriptDurationMs": 9551.886999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 2000,
"frameDurationMs": 34.0172602739726,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10463.427999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9679.883,
"heapDeltaBytes": 74361148,
"heapUsedBytes": 148386584,
"domNodes": -257,
"jsHeapTotalBytes": 69595136,
"scriptDurationMs": 7719.142000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 947,
"frameDurationMs": 31.430030030030025,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11174.117000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10382.532,
"heapDeltaBytes": 77944380,
"heapUsedBytes": 160951028,
"domNodes": -257,
"jsHeapTotalBytes": 71954432,
"scriptDurationMs": 8395.98,
"eventListeners": -68,
"totalBlockingTimeMs": 1394,
"frameDurationMs": 31.150139275766016,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 222.44799999998577,
"styleRecalcs": 21,
"styleRecalcDurationMs": 12.831999999999999,
"layouts": 8,
"layoutDurationMs": 2.6629999999999994,
"taskDurationMs": 161.65800000000002,
"heapDeltaBytes": 14623800,
"heapUsedBytes": 74657880,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.771,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777808,
"p95FrameDurationMs": 83.19999999999982
},
{
"name": "large-combo-open",
"durationMs": 239.7439999999733,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.928,
"layouts": 9,
"layoutDurationMs": 3.0059999999999993,
"taskDurationMs": 182.493,
"heapDeltaBytes": 14599252,
"heapUsedBytes": 71613012,
"domNodes": -2315,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.587000000000002,
"eventListeners": -573,
"totalBlockingTimeMs": 6,
"frameDurationMs": 25.91111111111109,
"p95FrameDurationMs": 100.09999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2055.0669999999513,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.721000000000001,
"layouts": 8,
"layoutDurationMs": 2.476,
"taskDurationMs": 687.582,
"heapDeltaBytes": -9279956,
"heapUsedBytes": 65644564,
"domNodes": -257,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 32.8,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.7909999999756,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1229999999999998,
"layouts": 8,
"layoutDurationMs": 2.118,
"taskDurationMs": 634.4190000000001,
"heapDeltaBytes": -6946808,
"heapUsedBytes": 72194228,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 36.191,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2801.0659999999916,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.220000000000002,
"layouts": 5,
"layoutDurationMs": 1.4619999999999997,
"taskDurationMs": 1808.0279999999998,
"heapDeltaBytes": 6772656,
"heapUsedBytes": 81922092,
"domNodes": -257,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 868.3029999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2733.7929999999915,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.416,
"layouts": 7,
"layoutDurationMs": 1.964,
"taskDurationMs": 1789.3349999999998,
"heapDeltaBytes": -14105576,
"heapUsedBytes": 62153932,
"domNodes": -257,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 922.1899999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.870987654320984,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3918.47800000005,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.645000000000001,
"layouts": 64,
"layoutDurationMs": 10.66,
"taskDurationMs": 1849.028,
"heapDeltaBytes": -9974308,
"heapUsedBytes": 83765520,
"domNodes": -233,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 789.6160000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3716.028999999935,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.499,
"layouts": 64,
"layoutDurationMs": 10.591,
"taskDurationMs": 1774.136,
"heapDeltaBytes": 2679544,
"heapUsedBytes": 74047248,
"domNodes": -233,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 797.014,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591928251121,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3056.6239999999993,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.030999999999999,
"layouts": 6,
"layoutDurationMs": 1.6269999999999996,
"taskDurationMs": 1992.4020000000003,
"heapDeltaBytes": 11890072,
"heapUsedBytes": 90657988,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 978.6610000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.849450549450548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3106.777999999963,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.942,
"layouts": 4,
"layoutDurationMs": 1.2650000000000001,
"taskDurationMs": 2019.5020000000002,
"heapDeltaBytes": 18364796,
"heapUsedBytes": 96151000,
"domNodes": 0,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 1001.4289999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.116216216216216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3110.3279999999813,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.21,
"layouts": 5,
"layoutDurationMs": 1.4419999999999997,
"taskDurationMs": 838.965,
"heapDeltaBytes": -3178780,
"heapUsedBytes": 76186856,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 383.07199999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3077.9999999999745,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.8619999999999999,
"layouts": 6,
"layoutDurationMs": 1.6290000000000002,
"taskDurationMs": 804.867,
"heapDeltaBytes": -9475040,
"heapUsedBytes": 70245772,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 362.526,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2042.1819999999684,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2399999999999998,
"layouts": 7,
"layoutDurationMs": 2.2369999999999997,
"taskDurationMs": 683.3860000000001,
"heapDeltaBytes": 7120108,
"heapUsedBytes": 82904368,
"domNodes": -257,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 40.276999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.8399999999556,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.192,
"layouts": 8,
"layoutDurationMs": 2.433,
"taskDurationMs": 633.251,
"heapDeltaBytes": -11658584,
"heapUsedBytes": 65178444,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.163000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2772.079999999988,
"styleRecalcs": 27,
"styleRecalcDurationMs": 12.346,
"layouts": 8,
"layoutDurationMs": 1.9119999999999997,
"taskDurationMs": 628.076,
"heapDeltaBytes": -13068676,
"heapUsedBytes": 64010516,
"domNodes": -249,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 198.544,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2815.2860000000146,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.273,
"layouts": 5,
"layoutDurationMs": 1.5170000000000001,
"taskDurationMs": 620.8499999999999,
"heapDeltaBytes": -9705716,
"heapUsedBytes": 61298216,
"domNodes": -249,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 203.175,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666272189349108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3346.069,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.164,
"layouts": 7,
"layoutDurationMs": 2.1629999999999994,
"taskDurationMs": 986.4720000000001,
"heapDeltaBytes": -17500052,
"heapUsedBytes": 62936020,
"domNodes": -257,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 394.81500000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3419.2920000000413,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6319999999999997,
"layouts": 5,
"layoutDurationMs": 1.454,
"taskDurationMs": 1053.452,
"heapDeltaBytes": -14170328,
"heapUsedBytes": 78943424,
"domNodes": -257,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 405.86300000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.83054187192118,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.2680000000205,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.306000000000001,
"layouts": 9,
"layoutDurationMs": 2.7620000000000005,
"taskDurationMs": 453.1809999999999,
"heapDeltaBytes": 1860420,
"heapUsedBytes": 73768988,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 148.66899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631583,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 633.7709999999106,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.397999999999999,
"layouts": 10,
"layoutDurationMs": 2.8870000000000005,
"taskDurationMs": 448.495,
"heapDeltaBytes": 2986536,
"heapUsedBytes": 75319664,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 150.466,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2039.8119999999835,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0989999999999993,
"layouts": 9,
"layoutDurationMs": 2.9259999999999997,
"taskDurationMs": 551.8,
"heapDeltaBytes": 2301708,
"heapUsedBytes": 64201836,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 10.370000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.506999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4339999999999997,
"layouts": 8,
"layoutDurationMs": 2.088,
"taskDurationMs": 528.2209999999999,
"heapDeltaBytes": 3669652,
"heapUsedBytes": 65726900,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 9.087,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.4719999999834,
"styleRecalcs": 79,
"styleRecalcDurationMs": 15.109000000000002,
"layouts": 10,
"layoutDurationMs": 2.7729999999999997,
"taskDurationMs": 878.7100000000002,
"heapDeltaBytes": -5788300,
"heapUsedBytes": 66721864,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 115.39899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.704999999929,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.673,
"layouts": 10,
"layoutDurationMs": 3.0740000000000003,
"taskDurationMs": 863.67,
"heapDeltaBytes": -6350448,
"heapUsedBytes": 65662968,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 111.353,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689323,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.2459999999983,
"styleRecalcs": 19,
"styleRecalcDurationMs": 22.604,
"layouts": 5,
"layoutDurationMs": 14.345,
"taskDurationMs": 1132.2550000000003,
"heapDeltaBytes": 16457496,
"heapUsedBytes": 118036136,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 34.907999999999994,
"eventListeners": 3246,
"totalBlockingTimeMs": 161,
"frameDurationMs": 20.044594594594596,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10679.956000000004,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.414,
"layouts": 8,
"layoutDurationMs": 2.497,
"taskDurationMs": 6484.923,
"heapDeltaBytes": 20410768,
"heapUsedBytes": 94684264,
"domNodes": -257,
"jsHeapTotalBytes": 6348800,
"scriptDurationMs": 3074.587,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.692175273865413,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9674.871999999938,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.959999999999997,
"layouts": 7,
"layoutDurationMs": 1.9589999999999999,
"taskDurationMs": 6063.023999999999,
"heapDeltaBytes": -1232228,
"heapUsedBytes": 72528028,
"domNodes": -257,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 2797.8810000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69481865284974,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23499.28,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23018.961,
"heapDeltaBytes": -37280484,
"heapUsedBytes": 263351248,
"domNodes": -3343,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 325.007,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.910104529616724,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 23083.311999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22516.106,
"heapDeltaBytes": -20815728,
"heapUsedBytes": 255962440,
"domNodes": -3343,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 304.557,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.0720640569395,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 28242.41900000004,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.619000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27851.109999999997,
"heapDeltaBytes": -23826212,
"heapUsedBytes": 267119432,
"domNodes": -3343,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 858.4770000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 11,
"frameDurationMs": 52.96848030018762,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28124.542999999903,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.93900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27752.390000000007,
"heapDeltaBytes": -25227712,
"heapUsedBytes": 262057596,
"domNodes": -3343,
"jsHeapTotalBytes": 14934016,
"scriptDurationMs": 895.439,
"eventListeners": -651,
"totalBlockingTimeMs": 32,
"frameDurationMs": 52.65093632958801,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8424.783999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.87100000000001,
"layouts": 20,
"layoutDurationMs": 22.324000000000012,
"taskDurationMs": 8344.911,
"heapDeltaBytes": -17204628,
"heapUsedBytes": 255285856,
"domNodes": -3343,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 124.18299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.3157894736842,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8470.194999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.065,
"layouts": 20,
"layoutDurationMs": 33.666000000000004,
"taskDurationMs": 8340.042000000001,
"heapDeltaBytes": -29888848,
"heapUsedBytes": 252315664,
"domNodes": -3343,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 147.42100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.92598870056496,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11392.817999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11215.712,
"heapDeltaBytes": 9784,
"heapUsedBytes": 279635332,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.34300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.60401459854015,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11464.765000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11263.212999999998,
"heapDeltaBytes": 9637196,
"heapUsedBytes": 265302720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.87499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.268150684931506,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 147.1220000000244,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.951,
"layouts": 9,
"layoutDurationMs": 3.3469999999999995,
"taskDurationMs": 109.68199999999999,
"heapDeltaBytes": -12509888,
"heapUsedBytes": 63417008,
"domNodes": 101,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.501000000000001,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.655555555555566,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 131.00200000008044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.402999999999999,
"layouts": 8,
"layoutDurationMs": 3.6700000000000004,
"taskDurationMs": 93.52499999999999,
"heapDeltaBytes": 4773004,
"heapUsedBytes": 65331716,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.779000000000002,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 526.9120000000385,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6449999999999999,
"layouts": 76,
"layoutDurationMs": 15.322000000000001,
"taskDurationMs": 484.94499999999994,
"heapDeltaBytes": -3694572,
"heapUsedBytes": 40810132,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 235.542,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 453.79700000000867,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6679999999999999,
"layouts": 76,
"layoutDurationMs": 14.723,
"taskDurationMs": 415.686,
"heapDeltaBytes": -4546820,
"heapUsedBytes": 39163188,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 199.274,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 613.1630000000996,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.527,
"layouts": 76,
"layoutDurationMs": 15.720999999999998,
"taskDurationMs": 576.073,
"heapDeltaBytes": 1214436,
"heapUsedBytes": 94812628,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 238.497,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 640.3050000000121,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.7889999999999997,
"layouts": 76,
"layoutDurationMs": 16.229,
"taskDurationMs": 604.374,
"heapDeltaBytes": 2165100,
"heapUsedBytes": 100188748,
"domNodes": 4,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 252.228,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.10263157894736,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3123 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f9c06fae1f15ef93b6afc18c5432b328cd194860
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (210)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.59 #22095 +/- ##
=============================================
Coverage ? 87.15%
=============================================
Files ? 3023
Lines ? 158291
Branches ? 42090
=============================================
Hits ? 137957
Misses ? 19659
Partials ? 675
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #22073 to
cloud/1.59Automatically created by backport workflow.