Repository navigation
FE-3647 fix(billing): show the server's message when a top-up is rate limited or purchases are paused - #22072
Conversation
… limited or purchases are paused The backend refuses top-ups with 429 TOPUP_RATE_LIMITED and 403 TOPUP_PURCHASES_PAUSED, each with a sentence written for the customer. The hosts mapped these to their generic REQUEST_FAILED / ACCESS_DENIED copy, and billing-web held the 429 as a retryable rate limit. account-core names the codes; billing-web treats them as a final answer and renders the served message; the Cloud dialog shows it in the purchase toast and in place of the checkout-open failure.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Refusal codes and error messages packages/account-core/src/core/billing/*, src/platform/billing/sdk/topupOperationView.ts, src/platform/billing/sdk/topupOperationView.test.ts |
Billing contracts identify TOPUP_RATE_LIMITED and TOPUP_PURCHASES_PAUSED as purchase refusals. Top-up error conversion uses the server message when available. |
Hosted top-up refusal handling apps/billing-web/src/checkout/*, apps/billing-web/src/composables/useHostedCopy.ts, apps/billing-web/src/views/FullPageTopupView.test.ts |
Recognized refusals settle hosted attempts as answered. Processing errors use the unwrapped server code, and hosted copy uses the server message when available. Tests cover rate limits, paused purchases, and subsequent Pay attempts. |
Workspace refusal messages src/platform/billing/components/TopUpCreditsDialogContentWorkspace.vue, src/platform/billing/components/TopUpCreditsDialogContentWorkspace.test.ts |
The dialog stores recognized checkout refusal messages and displays them in checkout alerts and purchase-error details. Tests cover paused-purchase and rate-limited responses. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Possibly related PRs
- Comfy-Org/ComfyUI_frontend#21800: Introduced
settlesAttemptintopupRequest.ts; this change updates its settlement behavior for recognized purchase-refusal codes.
Merge Risk: 
Minimal · up to c0055
-
No actionable merge-blocking risk was identified.
Pre-merge checks: 
5 · 
1
-
Failed checks: 1 warning Passed checks: 5 passed-
Full details: Description check
-
Explanation
The description explains the problem, root cause, implementation, expected behavior, issue reference, visual changes, and test coverage. It uses headings that differ from the template, but it provides the required summary and verification information.
-
Full details: End-To-End Test Suggestion For User-Facing Changes
-
Explanation
The PR changes user-visible top-up error handling in
src/andpackages/. A user can trigger the feature when a top-up is rate limited or purchases are paused, and the UI should show the server message. The PR does not add or update a spec underbrowser_tests/. This is a test suggestion, not a merge requirement.Resolution
Extend an existing spec under
browser_tests/if one covers top-up purchases, or add one that: - Starts a top-up that receivesTOPUP_RATE_LIMITED. - Expects the server-provided rate-limit message in the purchase failure UI. - Starts a top-up that receivesTOPUP_PURCHASES_PAUSED. - Expects the server-provided paused-purchases message in the purchase failure UI. - Attempts payment again after the refusal. - Expects the retry to start a new purchase request.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
📦 Bundle: 11.9 MB gzip 🟢 -10 BDetailsSummary
Category Glance App Entry Points — 6.61 kB (baseline 6.61 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.57 MB (baseline 2.57 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 149 kB (baseline 149 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 874 kB (baseline 874 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 154 kB (baseline 154 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 10 added / 10 removed / 7 unchanged Editors & Dialogs — 500 kB (baseline 500 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 11 added / 11 removed / 6 unchanged UI Components — 340 kB (baseline 340 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 22 unchanged Data & Services — 1.88 MB (baseline 1.88 MB) • 🟢 -347 BStores, services, APIs, and repositories
Status: 36 added / 36 removed / 6 unchanged Utilities & Hooks — 2.42 MB (baseline 2.42 MB) • 🔴 +110 BHelpers, composables, and utility bundles
Status: 48 added / 48 removed / 35 unchanged Vendor & Third-Party — 9.69 MB (baseline 9.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.7 MB (baseline 34.7 MB) • 🟢 -493 BBundles that do not match a named category
Status: 112 added / 112 removed / 629 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T19:41:03.550Z",
"gitSha": "167be523e0bd39c73f18d4e1c5951c52a545f9eb",
"branch": "dante/topup-limit-server-message",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.4100000000215,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.921,
"layouts": 8,
"layoutDurationMs": 2.006,
"taskDurationMs": 508.08799999999997,
"heapDeltaBytes": 1946020,
"heapUsedBytes": 63889772,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.114999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2022.6089999999886,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.947,
"layouts": 10,
"layoutDurationMs": 2.9739999999999998,
"taskDurationMs": 532.721,
"heapDeltaBytes": 5049088,
"heapUsedBytes": 76230000,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 9.722000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.0789999999904,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.025,
"layouts": 9,
"layoutDurationMs": 2.4820000000000007,
"taskDurationMs": 855.3439999999999,
"heapDeltaBytes": 21030032,
"heapUsedBytes": 81145828,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 146.99599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1788.7550000000374,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.381999999999998,
"layouts": 10,
"layoutDurationMs": 2.9,
"taskDurationMs": 895.384,
"heapDeltaBytes": 22984732,
"heapUsedBytes": 84293704,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 155.933,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3950000000154,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.7909999999999995,
"layouts": 10,
"layoutDurationMs": 2.7800000000000002,
"taskDurationMs": 387.58200000000005,
"heapDeltaBytes": 24217832,
"heapUsedBytes": 85716348,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.049,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.9539999999351,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.871,
"layouts": 10,
"layoutDurationMs": 2.8369999999999997,
"taskDurationMs": 409.00699999999995,
"heapDeltaBytes": 23946676,
"heapUsedBytes": 85263880,
"domNodes": 57,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.599000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 645.2030000000093,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.2079999999999997,
"layouts": 8,
"layoutDurationMs": 1.9120000000000001,
"taskDurationMs": 473.187,
"heapDeltaBytes": 3227892,
"heapUsedBytes": 64016864,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 160.785,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 662.488000000053,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.995,
"layouts": 10,
"layoutDurationMs": 3.1220000000000003,
"taskDurationMs": 492.24500000000006,
"heapDeltaBytes": 5692016,
"heapUsedBytes": 66946000,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 164.319,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1192.879999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.783,
"heapDeltaBytes": -12392948,
"heapUsedBytes": 75065976,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 64.29099999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 517,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.2009999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.307,
"heapDeltaBytes": -11803264,
"heapUsedBytes": 75445560,
"domNodes": -191,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 59.115999999999985,
"eventListeners": -106,
"totalBlockingTimeMs": 521,
"frameDurationMs": 32.432432432432435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 944.5049999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.3810000000003,
"heapDeltaBytes": -28994476,
"heapUsedBytes": 66137992,
"domNodes": -191,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 157.678,
"eventListeners": -106,
"totalBlockingTimeMs": 241,
"frameDurationMs": 24.997368421052645,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 906.8550000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.4699999999999,
"heapDeltaBytes": -28600824,
"heapUsedBytes": 66521660,
"domNodes": -191,
"jsHeapTotalBytes": 4849664,
"scriptDurationMs": 155.38199999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 243,
"frameDurationMs": 25.711428571428588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10038.841999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9126.134,
"heapDeltaBytes": 56579792,
"heapUsedBytes": 150573036,
"domNodes": -257,
"jsHeapTotalBytes": 63303680,
"scriptDurationMs": 7121.468999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 335,
"frameDurationMs": 27.715469613259675,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9578.067999999974,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05099999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8774.823,
"heapDeltaBytes": 53871496,
"heapUsedBytes": 134350728,
"domNodes": -257,
"jsHeapTotalBytes": 67760128,
"scriptDurationMs": 6885.004,
"eventListeners": -68,
"totalBlockingTimeMs": 215,
"frameDurationMs": 28.135882352941177,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9873.086999999998,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2829999999999994,
"layouts": 1,
"layoutDurationMs": 0.2930000000000003,
"taskDurationMs": 8954.21,
"heapDeltaBytes": 61103328,
"heapUsedBytes": 140701108,
"domNodes": -257,
"jsHeapTotalBytes": 75624448,
"scriptDurationMs": 7107.741,
"eventListeners": -68,
"totalBlockingTimeMs": 256,
"frameDurationMs": 28.10883190883191,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9575.301000000025,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.40899999999999964,
"layouts": 1,
"layoutDurationMs": 0.3090000000000003,
"taskDurationMs": 8766.804,
"heapDeltaBytes": 56564860,
"heapUsedBytes": 134342288,
"domNodes": -257,
"jsHeapTotalBytes": 68022272,
"scriptDurationMs": 6943.603,
"eventListeners": -68,
"totalBlockingTimeMs": 167,
"frameDurationMs": 28.02017543859649,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "large-combo-open",
"durationMs": 214.03300000000058,
"styleRecalcs": 23,
"styleRecalcDurationMs": 13.809000000000001,
"layouts": 12,
"layoutDurationMs": 3.519,
"taskDurationMs": 155.09699999999998,
"heapDeltaBytes": 14349340,
"heapUsedBytes": 90530440,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.507,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 208.5660000000189,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.346999999999998,
"layouts": 8,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 149.117,
"heapDeltaBytes": 14547564,
"heapUsedBytes": 72135024,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.515,
"eventListeners": 205,
"totalBlockingTimeMs": 2,
"frameDurationMs": 25,
"p95FrameDurationMs": 83.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2056.580999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.221,
"layouts": 9,
"layoutDurationMs": 2.216,
"taskDurationMs": 634.8660000000001,
"heapDeltaBytes": -29717532,
"heapUsedBytes": 61378712,
"domNodes": -257,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 32.559000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.6270000000486,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3080000000000003,
"layouts": 8,
"layoutDurationMs": 2.0930000000000004,
"taskDurationMs": 637.424,
"heapDeltaBytes": -24688396,
"heapUsedBytes": 62131468,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 39.413999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2259.777999999983,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.892,
"layouts": 7,
"layoutDurationMs": 1.7730000000000004,
"taskDurationMs": 1615.9179999999997,
"heapDeltaBytes": -28847404,
"heapUsedBytes": 60689304,
"domNodes": -257,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 787.1049999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588233,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2359.899999999925,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.191,
"layouts": 7,
"layoutDurationMs": 1.7510000000000003,
"taskDurationMs": 1629.3690000000001,
"heapDeltaBytes": -15626124,
"heapUsedBytes": 72043736,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 784.237,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665492957746483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3670.035999999982,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.859999999999998,
"layouts": 64,
"layoutDurationMs": 10.425,
"taskDurationMs": 1759.7690000000005,
"heapDeltaBytes": -21250292,
"heapUsedBytes": 70501624,
"domNodes": -233,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 764.285,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3582.493999999997,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.252999999999998,
"layouts": 64,
"layoutDurationMs": 10.93,
"taskDurationMs": 1749.851,
"heapDeltaBytes": -9762900,
"heapUsedBytes": 65763648,
"domNodes": -233,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 782.829,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2987.9099999999994,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.35,
"layouts": 6,
"layoutDurationMs": 1.5769999999999997,
"taskDurationMs": 1922.8690000000001,
"heapDeltaBytes": -12959980,
"heapUsedBytes": 78842292,
"domNodes": 0,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 969.9510000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.854237288135593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3156.270000000063,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.741,
"layouts": 6,
"layoutDurationMs": 1.4909999999999997,
"taskDurationMs": 2033.913,
"heapDeltaBytes": -21838236,
"heapUsedBytes": 69729820,
"domNodes": 0,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 1039.814,
"eventListeners": 182,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.022994652406418,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3037.064000000015,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.96,
"layouts": 7,
"layoutDurationMs": 1.971,
"taskDurationMs": 742.8079999999999,
"heapDeltaBytes": -3779256,
"heapUsedBytes": 72072464,
"domNodes": -257,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 333.15299999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3079.3600000000083,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.313,
"layouts": 8,
"layoutDurationMs": 2.1500000000000004,
"taskDurationMs": 771.132,
"heapDeltaBytes": -10193340,
"heapUsedBytes": 79586416,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 348.045,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576086956522,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.3890000000001,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8409999999999997,
"layouts": 7,
"layoutDurationMs": 1.7429999999999997,
"taskDurationMs": 646.5179999999999,
"heapDeltaBytes": -25016808,
"heapUsedBytes": 64881640,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 32.370000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.8720000000785,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2449999999999997,
"layouts": 7,
"layoutDurationMs": 2.009,
"taskDurationMs": 648.045,
"heapDeltaBytes": -24119636,
"heapUsedBytes": 65678424,
"domNodes": -257,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 33.076,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2997.856000000013,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.235,
"layouts": 8,
"layoutDurationMs": 1.8539999999999999,
"taskDurationMs": 598.4300000000001,
"heapDeltaBytes": -12411008,
"heapUsedBytes": 80188920,
"domNodes": -245,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 172.99800000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2991.7560000000094,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.198,
"layouts": 6,
"layoutDurationMs": 1.687,
"taskDurationMs": 605.6420000000002,
"heapDeltaBytes": -19913684,
"heapUsedBytes": 72937912,
"domNodes": -247,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 182.15599999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3213.808,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8660000000000005,
"layouts": 7,
"layoutDurationMs": 1.617,
"taskDurationMs": 922.3059999999999,
"heapDeltaBytes": -13313000,
"heapUsedBytes": 76467012,
"domNodes": -257,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 353.093,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614583333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3272.997000000032,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.470999999999999,
"layouts": 7,
"layoutDurationMs": 1.9429999999999994,
"taskDurationMs": 949.483,
"heapDeltaBytes": -14191320,
"heapUsedBytes": 75237708,
"domNodes": -257,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 364.726,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751282051282054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.1929999999907,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.946,
"layouts": 9,
"layoutDurationMs": 2.2950000000000004,
"taskDurationMs": 428.14300000000003,
"heapDeltaBytes": -1382540,
"heapUsedBytes": 60634044,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 145.969,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.2679999999955,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.375,
"layouts": 9,
"layoutDurationMs": 2.481,
"taskDurationMs": 450.4560000000001,
"heapDeltaBytes": -1302276,
"heapUsedBytes": 60663732,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 151.04899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.5199999999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4729999999999994,
"layouts": 9,
"layoutDurationMs": 2.31,
"taskDurationMs": 505.46099999999996,
"heapDeltaBytes": 845500,
"heapUsedBytes": 62966500,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.072,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2022.3909999999705,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.257,
"layouts": 9,
"layoutDurationMs": 2.2669999999999995,
"taskDurationMs": 500.85400000000004,
"heapDeltaBytes": 564912,
"heapUsedBytes": 63192424,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.364,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.7620000000397,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.249999999999998,
"layouts": 9,
"layoutDurationMs": 2.1609999999999996,
"taskDurationMs": 771.98,
"heapDeltaBytes": 19088320,
"heapUsedBytes": 80942692,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 96.666,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.5980000000045,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.636,
"layouts": 10,
"layoutDurationMs": 2.361,
"taskDurationMs": 770.775,
"heapDeltaBytes": -5651344,
"heapUsedBytes": 67581408,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 98.418,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.9779999999732,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.451,
"layouts": 5,
"layoutDurationMs": 15.566,
"taskDurationMs": 1112.63,
"heapDeltaBytes": 11792544,
"heapUsedBytes": 104263812,
"domNodes": 16030,
"jsHeapTotalBytes": 16912384,
"scriptDurationMs": 29.026999999999997,
"eventListeners": 3246,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8322.014000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.482,
"layouts": 9,
"layoutDurationMs": 2.297,
"taskDurationMs": 5746.086,
"heapDeltaBytes": -6262464,
"heapUsedBytes": 80800760,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2614.674,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8585.515000000101,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.997000000000003,
"layouts": 7,
"layoutDurationMs": 1.9620000000000002,
"taskDurationMs": 5819.7390000000005,
"heapDeltaBytes": -12197396,
"heapUsedBytes": 75883848,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 2663.3630000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23661.591999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23180.902,
"heapDeltaBytes": -16631392,
"heapUsedBytes": 277967480,
"domNodes": -3343,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 346.25899999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.944117647058825,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23671.018000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23279.530000000002,
"heapDeltaBytes": -19986860,
"heapUsedBytes": 282306820,
"domNodes": -3343,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 360.82899999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.51777378815081,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 28739.153999999984,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.080000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28418.996000000003,
"heapDeltaBytes": -47956292,
"heapUsedBytes": 254869400,
"domNodes": -3343,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 880.787,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 54.75980952380952,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 28447.41799999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.541999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28134.92,
"heapDeltaBytes": -31535304,
"heapUsedBytes": 270984300,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 860.719,
"eventListeners": -651,
"totalBlockingTimeMs": 16,
"frameDurationMs": 55.67279843444227,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8590.847999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.550999999999995,
"layouts": 20,
"layoutDurationMs": 24.271,
"taskDurationMs": 8439.395,
"heapDeltaBytes": -23060696,
"heapUsedBytes": 265267800,
"domNodes": -3343,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 160.602,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.68333333333332,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8334.109000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.02600000000001,
"layouts": 20,
"layoutDurationMs": 33.36099999999999,
"taskDurationMs": 8222.221,
"heapDeltaBytes": -33858260,
"heapUsedBytes": 257885760,
"domNodes": -3343,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 148.23600000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.90842696629214,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11912.734999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11635.118999999999,
"heapDeltaBytes": -27824736,
"heapUsedBytes": 251700100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.92300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.297769516728636,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11541.540000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11312.056999999999,
"heapDeltaBytes": -19678252,
"heapUsedBytes": 255300756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.0349999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.248571428571424,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 144.0380000000232,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.92,
"layouts": 9,
"layoutDurationMs": 3.9629999999999996,
"taskDurationMs": 112.70700000000002,
"heapDeltaBytes": 4945056,
"heapUsedBytes": 65293428,
"domNodes": 132,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.441,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 138.13599999991766,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.873,
"layouts": 10,
"layoutDurationMs": 3.892,
"taskDurationMs": 98.03299999999999,
"heapDeltaBytes": 4568128,
"heapUsedBytes": 73224088,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.155,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 532.071999999971,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.864,
"layouts": 76,
"layoutDurationMs": 15.448,
"taskDurationMs": 467.56000000000006,
"heapDeltaBytes": -3930864,
"heapUsedBytes": 40436064,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 219.899,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 435.7479999999896,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6669999999999999,
"layouts": 76,
"layoutDurationMs": 14.391,
"taskDurationMs": 389.98299999999995,
"heapDeltaBytes": -4737096,
"heapUsedBytes": 38552612,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 182.207,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 500.1039999999648,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.811,
"layouts": 76,
"layoutDurationMs": 14.989,
"taskDurationMs": 462.847,
"heapDeltaBytes": -199888,
"heapUsedBytes": 90375540,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 176.631,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 626.5690000000177,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7810000000000001,
"layouts": 76,
"layoutDurationMs": 16.256,
"taskDurationMs": 585.473,
"heapDeltaBytes": 1534812,
"heapUsedBytes": 102975172,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 235.14200000000002,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.118918918918933,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3138 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since bd959df7db854d5c3ce25608ef4428c72534f120
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (235)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22072 +/- ##
==========================================
- Coverage 87.25% 87.25% -0.01%
==========================================
Files 2949 2949
Lines 158941 158960 +19
Branches 43195 43204 +9
==========================================
+ Hits 138683 138696 +13
- Misses 19388 19394 +6
Partials 870 870
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at exact head c0055221ad3f86f2fbddd0ff6a6e9abeb5025bca: the refusal classifier, terminal-attempt behavior, and host copy projection match the two served purchase-refusal contracts.
Full context for agent readers
The exact-head diff and changed files are sound. The regression coverage exercises billing-web and both Cloud top-up rails, all checks are settled with no executed failure, and there are no unresolved review threads.
|
|
|
|
… when a top-up is rate limited or purchases are paused (#22072) (#22150) ## Why Manual backport of #22072 to `cloud/1.59` for the 1.59 release. The bot's cherry-pick conflicted. ## Root cause Same as #22072: a rate-limited or paused top-up showed a generic error instead of the server's sentence. ## How Cherry-pick of d669320. Conflicts resolved: - `TopUpCreditsDialogContentWorkspace.vue`: kept both `TOPUP_AMOUNT_PRESETS_USD` (branch) and `PURCHASE_REFUSAL_SERVER_CODES` (#22072) in the billing import. - `topupOperationView.test.ts`: kept the branch's `WorkspaceApiError` import path (`@/platform/workspace/api/workspaceApi`) and added `readBillingErrorCode`. - `TopUpCreditsDialogContentWorkspace.test.ts`: the new checkout-refusal test spies on `workspaceApi.createTopupCheckout`, which is what this branch's dialog calls (main uses `billingApi`). Tests: `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts` (131 passed), `apps/billing-web` `FullPageTopupView.test.ts` (39 passed). ## AS IS / TO BE See #22072; behavior is identical on this branch.
…when a top-up is rate limited or purchases are paused (#22072) (#22149) ## Why Manual backport of #22072 to `core/1.59` for the 1.59 release. The bot's cherry-pick conflicted. ## Root cause Same as #22072: a rate-limited or paused top-up showed a generic error instead of the server's sentence. ## How Cherry-pick of d669320. Conflicts resolved: - `TopUpCreditsDialogContentWorkspace.vue`: kept both `TOPUP_AMOUNT_PRESETS_USD` (branch) and `PURCHASE_REFUSAL_SERVER_CODES` (#22072) in the billing import. - `topupOperationView.test.ts`: kept the branch's `WorkspaceApiError` import path (`@/platform/workspace/api/workspaceApi`) and added `readBillingErrorCode`. - `TopUpCreditsDialogContentWorkspace.test.ts`: the new checkout-refusal test spies on `workspaceApi.createTopupCheckout`, which is what this branch's dialog calls (main uses `billingApi`). Tests: `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts` (131 passed), `apps/billing-web` `FullPageTopupView.test.ts` (39 passed). ## AS IS / TO BE See #22072; behavior is identical on this branch.
…when a top-up is rate limited or purchases are paused (#22072) (#22151) ## Why Manual backport of #22072 to `core/1.58`: the backend's `TOPUP_RATE_LIMITED` / `TOPUP_PURCHASES_PAUSED` refusals are live in prod, and 1.58 shows a generic error for them. The bot's cherry-pick conflicted. ## Root cause Same as #22072: a rate-limited or paused top-up showed a generic error instead of the server's sentence. ## How Cherry-pick of d669320, adapted to 1.58: - The Cloud dialog and SDK files live under `src/platform/workspace/` on this branch; the changes are applied there. - `account-core/billing/index.ts`: kept the branch's `.js` import specifiers and added `isPurchaseRefusal` / `PURCHASE_REFUSAL_SERVER_CODES`. - The `apps/billing-web` part is left out: the pay-once top-up it fixes (`topupRequest.ts`) does not exist on 1.58, and billing-web deploys from main. - The new checkout-refusal test spies on `workspaceApi.createTopupCheckout`, which is what this branch's dialog calls. Tests: `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts` (124 passed). ## AS IS / TO BE See #22072 (Cloud Add credits dialog rows); behavior is identical on this branch.
… when a top-up is rate limited or purchases are paused (#22072) (#22152) ## Why Manual backport of #22072 to `cloud/1.58`: the backend's `TOPUP_RATE_LIMITED` / `TOPUP_PURCHASES_PAUSED` refusals are live in prod, and 1.58 shows a generic error for them. The bot's cherry-pick conflicted. ## Root cause Same as #22072: a rate-limited or paused top-up showed a generic error instead of the server's sentence. ## How Cherry-pick of d669320, adapted to 1.58: - The Cloud dialog and SDK files live under `src/platform/workspace/` on this branch; the changes are applied there. - `account-core/billing/index.ts`: kept the branch's `.js` import specifiers and added `isPurchaseRefusal` / `PURCHASE_REFUSAL_SERVER_CODES`. - The `apps/billing-web` part is left out: the pay-once top-up it fixes (`topupRequest.ts`) does not exist on 1.58, and billing-web deploys from main. - The new checkout-refusal test spies on `workspaceApi.createTopupCheckout`, which is what this branch's dialog calls. Tests: `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts` (124 passed). ## AS IS / TO BE See #22072 (Cloud Add credits dialog rows); behavior is identical on this branch.
…ep this tab's decline card (Comfy-Org#22085) ## Why On staging, every new-card top-up on billing-web's pay-once form failed. `POST /api/billing/topup/interactive` answered `pending`, the operation sat at `authentication_state: processing` for ~165s, then ended `failed` / `topup_invoice_payment_failed` with nothing charged. The decline test card failed the same way instead of declining at once, and when the operation finally failed the page went back to the form with no "Payment declined" card. ## Root cause 1. `StripePaymentForm` built the pay-once Elements in automatic mode with the served `paymentMethodConfiguration`, while the backend creates the top-up invoice PaymentIntent with `payment_method_types=['card']`. Stripe rejects a confirmation token from automatic-mode Elements against that PaymentIntent; the worker's ten retries explain the delay (traced on the Stripe test-mode requests). 2. When this tab's own Pay outlived its watch (`payRejectedAsPending`), the re-read landed in `waitingInCapture`, which always marked the operation `sibling: true`. A sibling's verdict belongs to another tab, so the decline reset the form with no card. ## How - Pay-once Elements: `paymentMethodTypes: ['card']`, no `paymentMethodConfiguration`, and `wallets.link: 'never'` on the Payment Element (without the card-only configuration Stripe otherwise adds Link's bank, Klarna and crypto options, which the card-only invoice would refuse). The subscription form is unchanged; the backend card-only / no-future-use guards stay. - `waitingInCapture`: an operation this tab awaited (`awaitedHere`) is not a sibling, so its verdict lands on its own card. Part of FE-3562 ## Tests - `StripePaymentForm.test.ts`: paying once mounts card-only Elements with no configuration and Link off (red before the fix). - `checkoutPage.test.ts`: this tab's own Pay whose watch lapsed declines onto its card once the re-read settles (red before the fix). ## AS IS / TO BE Local billing-web against staging, Stripe test mode. | | AS IS | TO BE | | --- | --- | --- | | New card form | _pending_ | _pending_ | | New card 4242 Pay | _pending_ | _pending_ | | Decline 4000…0002 | _pending_ | _pending_ | ## Plan position | Item | PR | Status | | --- | --- | --- | | Top-up limit server message | Comfy-Org#22072 | In review | | **Pay-once card-only Elements + own decline card** | **this PR** | **In review** | | New-card payment acceptance on staging | (after this PR) | Blocked on this PR | ```mermaid graph LR A["Card-only Elements (this PR)"] --> B["New-card acceptance on staging"] style A fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
…Org#22171) ## Why QA (1.59, `unified_billing_settings` on) found that on a paused Team the Billing tab plan row reads only "Your plan", with no line and no plan name. The paused banner and Credits card are right; only the plan row is blank. ## Root cause `derivePlanRow` returned its `unknown` state for any workspace with `billing_status: paused`. `unknown` renders the generic "Your plan" title and no line. `/api/billing/status` serves no pause date, so the row had nothing to say, and the agreed date-free paused copy was never added. ## How - Add a `paused` plan row state that keeps the plan name. - Render the agreed date-free line: "Paused. The renewal payment didn't go through." A dated "Paused since {date}" waits until `paused_at` is served. - The action stays Manage, the same as before, gated by `can_open_plans`. - The Credits card is unchanged: it already zeroes plan credits for paused workspaces. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | _screenshot pending_ | _screenshot pending_ | ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | M4 Billing tab code-complete | M4 | merged PRs | done | | Top-up refusal server message | FE-3647 | Comfy-Org#22072 | merged | | Pay-once card-only form | FE-3562 | Comfy-Org#22085 | merged | | **Paused plan row copy** | QA 1.59 | **this PR** | **open** | | Paused-since date | BE (`paused_at`) | follow-up | blocked on BE | ```mermaid graph LR A["M4 Billing tab"] --> B["PR 22072 top-up refusal"] A --> C["PR 22085 card-only form"] A --> D["This PR: paused plan row"] D --> E["Paused-since date, needs paused_at"] style D fill:#f9d71c,stroke:Comfy-Org#333 ```
Why
The backend now refuses credit top-ups with two new errors, live in prod for a share of buyers (BE-23802):
TOPUP_RATE_LIMITED: "Too many top-ups in a short time. Try again later or contact support."TOPUP_PURCHASES_PAUSED: "Credit purchases are paused right now. Try again later or contact support."Each message is written to be shown as-is. Today customers see:
Root cause
account-core keeps
serverCodeandserverMessage, but buckets a 403 asACCESS_DENIEDand a 429 asREQUEST_FAILED. Each host words those buckets with its own copy, and billing-web'ssettlesAttempttreats any 429 as transient and keeps the purchase on its key.How
PURCHASE_REFUSAL_SERVER_CODESandisPurchaseRefusalname the two codes once.settlesAttempttreats them as a final answer (the next Pay is a new purchase, no re-read); the refusal carries the server code, anduseHostedCopy.refusalshows the served message for it.serverMessage; the dialog shows the served sentence in the purchase toast and in place of the checkout-open failure for these codes.No flag: this is a production fix.
SUBSCRIBE_ATTEMPTS_LIMITED(coming next) already shows the server message on billing-web subscribe.Fixes FE-3647
AS IS / TO BE
Local app builds (origin/main vs this branch), with
POST /api/billing/topupanswered by the server's refusal: 429TOPUP_RATE_LIMITED/ 403TOPUP_PURCHASES_PAUSED.Cloud: Add credits dialog, Pay with a saved card
billing-web: full-page top-up (
/v1/top-up), PayOn billing-web the 429 message already showed on the first Pay; this branch changes what happens next: the refused attempt is treated as answered, so the next Pay is a new purchase instead of a resend under the same key.
Tests
FullPageTopupView.test.ts: a pay-once Pay refused with each code shows the served sentence, triggers no re-read, and the next Pay is a new purchase (fails with the fix reverted).TopUpCreditsDialogContentWorkspace.test.ts: hosted checkout refused for now shows the served sentence; a rate-limited purchase toast shows it.topupOperationView.test.ts: the SDK error carries the served message.