Repository navigation
[backport core/1.59] fix(settings): admit Members when the server says the actor can manage them - #22094
Conversation
…e them (#22073) ## Why An Enterprise workspace owner could not see or manage members ([FE-3618](https://linear.app/comfyorg/issue/FE-3618)). He was signed in to a Cloud workspace from a non-Cloud bundle, and in that state the Members entry does not exist. ## Root cause `useSettingUI.ts` gated the Workspace section and the Members entry inside it on two different axes: ```ts const shouldShowWorkspacePanel = computed(() => isLoggedIn.value) // login only const workspacePanels = isCloud ? [planPanel, membersPanel] : [planPanel] // build-time constant ``` `isCloud` is `__DISTRIBUTION__ === 'cloud'`, statically replaced at build and unable to change at runtime. So a user signed in to a Cloud workspace from a non-Cloud bundle gets the Workspace section, gets Plan & Credits — their real Cloud billing, which is why the reporter's screenshot shows 41,419 Cloud credits — and never gets Members. That is the code's intended output, not a regression: the same gate is on `main`, `cloud/1.58`, `1.57` (prod) and `1.56`. On 1.57/1.56 it is formatted across lines, which is worth knowing if you grep for it. The server already owns this decision and publishes it as `can_manage_members` in the generated ingest contract, and the panel itself consumes it (`useMembersPanel.ts:134`, `MembersPanelContent.vue:150,195`). Only the nav entry ignored it, so a build-time constant stood in for a server-owned permission and refused a user the server considers a full owner. ## How ```diff -const workspacePanels = isCloud ? [planPanel, membersPanel] : [planPanel] +const canViewMembers = pendingServerFact( + 'BE-24066', + isCloud || canManageMembers.value +) +const workspacePanels = canViewMembers ? [planPanel, membersPanel] : [planPanel] ``` **The expression is wrapped because the fact it needs does not exist.** The server-fact gate rejected the first version of this PR, correctly: ADR-API-SERVER-FACTS-0042 rule 1 says a gate renders one server fact as received, and rule 2 says `isCloud` decides which build ships, not what a user may do. `isCloud || canManageMembers.value` is a derivation — the same pattern that shipped the two billing P0s in the ADR's own context, one of which (#15675) also lost member management for Enterprise owners. Viewing the roster is not `can_manage_members`: viewing is gated on `membersLoaded`, the capability gates the actions inside the panel, so Cloud non-owners read a roster today while it is false. Substituting it is exactly what rule 4 warns against. So this is rule 4's case — [BE-24066](https://linear.app/comfyorg/issue/BE-24066) asks the owning team which field should answer it, and `pendingServerFact` makes the gap expire: CI fails once that ticket closes, until the shipped field is rendered and this wrapper is deleted. **Additive, not a replacement, and that distinction is the point.** Viewing the roster is gated on `membersLoaded`, not on `can_manage_members` (`useMembersPanel.ts:143`), so Cloud members who are not owners see a read-only list today. Gating the entry on the capability alone would have silently taken that away from every Cloud non-owner — fixing one bug by introducing another. | | before | after | | --- | --- | --- | | Cloud owner | shown | shown | | Cloud non-owner | shown (read-only) | shown (read-only) | | non-Cloud, server permits | **hidden** | **shown** | | non-Cloud, server refuses | hidden | hidden | `canManageMembers` resolves through `receiveServerFact('can_manage_members', … ?? false)`, so it fails closed: if capabilities do not resolve, the entry stays hidden, which is today's behaviour. ## Tests `useSettingUI.test.ts`: `shows Members off Cloud when the server says the actor can manage them`. Mutation-checked — dropping `|| canManageMembers.value` fails it with `expected [ { id: 'workspace' } ] to deeply equal [ …, { id: 'workspace-members' } ]`. The two existing local cases still assert `workspace-members` is null and now mean "local and the server refuses", since the capability auto-mock defaults to false. 21/21 in that file. Repo typecheck (`scripts/vue-tsc-native.ts`) reports zero `src/` errors; oxlint `--type-aware` and oxfmt clean. ## Not verified here, and it gates the Desktop half Whether `workspaceApi.listMembers` actually serves a **Desktop-origin session**. The capability read works there — Plan & Credits proves the same auth and workspace context resolve — but that is inference, not proof, and I could not run a Desktop build. This is the one case where the change could be worse than today: if the capability is true but `listMembers` does not serve that session, the entry appears and the panel degrades to its minimal layout (`membersLoaded` false → `showMinimalMemberLayout`). No crash, but an entry that leads nowhere. **Please confirm on a real Desktop build signed into a Cloud workspace before merging.** If it does not serve, this becomes a product scope decision and FE-3618 should be retitled to "member management is unavailable on Desktop/local" instead. Cloud is unaffected either way — that path is unchanged. Tracks [FE-3645](https://linear.app/comfyorg/issue/FE-3645).
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T23:40:37.253Z",
"gitSha": "238b5c5d21a57f252ab4fcc56eba4265002fe72b",
"branch": "backport-22073-to-core-1.59",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.5950000000091,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.498,
"layouts": 10,
"layoutDurationMs": 3.13,
"taskDurationMs": 440.07,
"heapDeltaBytes": 4797584,
"heapUsedBytes": 76006820,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 11.568999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.0870000000127,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1179999999999994,
"layouts": 9,
"layoutDurationMs": 2.63,
"taskDurationMs": 436.25900000000007,
"heapDeltaBytes": 1819872,
"heapUsedBytes": 62996012,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 12.031000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.8980000000008,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.316,
"layouts": 10,
"layoutDurationMs": 3.109,
"taskDurationMs": 742.349,
"heapDeltaBytes": 23242972,
"heapUsedBytes": 84133972,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 128.941,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.201000000021,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.517000000000001,
"layouts": 10,
"layoutDurationMs": 2.8120000000000003,
"taskDurationMs": 769.2529999999999,
"heapDeltaBytes": -6386344,
"heapUsedBytes": 73060292,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 132.651,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.9019999999664,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.760000000000001,
"layouts": 11,
"layoutDurationMs": 2.876,
"taskDurationMs": 333.156,
"heapDeltaBytes": 24279132,
"heapUsedBytes": 85104508,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.428999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.0099999999975,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.201,
"layouts": 10,
"layoutDurationMs": 3.029,
"taskDurationMs": 357.21999999999997,
"heapDeltaBytes": 24405788,
"heapUsedBytes": 84933320,
"domNodes": 56,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.878,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 567.6019999999937,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.04,
"layouts": 9,
"layoutDurationMs": 2.5249999999999995,
"taskDurationMs": 414.419,
"heapDeltaBytes": 428732,
"heapUsedBytes": 62538544,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 138.18,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 600.7569999999873,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.908,
"layouts": 9,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 419.253,
"heapDeltaBytes": 6268752,
"heapUsedBytes": 76955936,
"domNodes": 0,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 139.769,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1100.4159999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 760.766,
"heapDeltaBytes": -11906436,
"heapUsedBytes": 75341072,
"domNodes": -191,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 51.593,
"eventListeners": -106,
"totalBlockingTimeMs": 419,
"frameDurationMs": 29.72972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1065.5049999999733,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 723.9929999999999,
"heapDeltaBytes": -13991508,
"heapUsedBytes": 75005432,
"domNodes": -191,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 49.285999999999994,
"eventListeners": -106,
"totalBlockingTimeMs": 380,
"frameDurationMs": 28.82972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.4869999999742,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.1849999999999,
"heapDeltaBytes": -21966424,
"heapUsedBytes": 66467456,
"domNodes": -191,
"jsHeapTotalBytes": 2752512,
"scriptDurationMs": 106.67599999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 113,
"frameDurationMs": 21.294444444444455,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 780.5169999999748,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.508,
"heapDeltaBytes": -27154728,
"heapUsedBytes": 66502724,
"domNodes": -191,
"jsHeapTotalBytes": 4587520,
"scriptDurationMs": 112.27100000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 119,
"frameDurationMs": 21.75555555555555,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8263.821000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9100000000000003,
"layouts": 2,
"layoutDurationMs": 0.7049999999999998,
"taskDurationMs": 7273.893,
"heapDeltaBytes": 59834712,
"heapUsedBytes": 131595600,
"domNodes": -257,
"jsHeapTotalBytes": 66449408,
"scriptDurationMs": 5459.869000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 106,
"frameDurationMs": 24.625970149253735,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7812.520000000006,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5260000000000005,
"layouts": 2,
"layoutDurationMs": 0.5239999999999997,
"taskDurationMs": 6886.336,
"heapDeltaBytes": 69712620,
"heapUsedBytes": 142322632,
"domNodes": -257,
"jsHeapTotalBytes": 63041536,
"scriptDurationMs": 5045.4439999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 47,
"frameDurationMs": 23.707294832826747,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7511.211000000003,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9199999999999998,
"layouts": 3,
"layoutDurationMs": 0.833,
"taskDurationMs": 6646.924,
"heapDeltaBytes": -12162876,
"heapUsedBytes": 79846324,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 4960.829000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 124,
"frameDurationMs": 24.58950819672131,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7609.2049999999745,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.699,
"layouts": 2,
"layoutDurationMs": 0.46099999999999963,
"taskDurationMs": 6738.022,
"heapDeltaBytes": -20264868,
"heapUsedBytes": 72195976,
"domNodes": -257,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 5059.132,
"eventListeners": -68,
"totalBlockingTimeMs": 85,
"frameDurationMs": 24.202547770700637,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 190.79700000000344,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.754,
"layouts": 11,
"layoutDurationMs": 3.4829999999999997,
"taskDurationMs": 139.992,
"heapDeltaBytes": 14391648,
"heapUsedBytes": 90826504,
"domNodes": 936,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.747999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 235.79599999999346,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.280999999999999,
"layouts": 12,
"layoutDurationMs": 3.5250000000000004,
"taskDurationMs": 180.738,
"heapDeltaBytes": 14501996,
"heapUsedBytes": 84800912,
"domNodes": 936,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8.426000000000002,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181826,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-graph-idle",
"durationMs": 2025.129000000021,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6690000000000005,
"layouts": 9,
"layoutDurationMs": 2.4549999999999996,
"taskDurationMs": 516.3820000000001,
"heapDeltaBytes": -9281640,
"heapUsedBytes": 65572384,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 30.233000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2024.0269999999896,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.636,
"layouts": 8,
"layoutDurationMs": 2.438,
"taskDurationMs": 515.461,
"heapDeltaBytes": -13522772,
"heapUsedBytes": 60206968,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 29.708000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2186.6749999999797,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.241999999999999,
"layouts": 7,
"layoutDurationMs": 1.739,
"taskDurationMs": 1410.033,
"heapDeltaBytes": -2349492,
"heapUsedBytes": 72720840,
"domNodes": -257,
"jsHeapTotalBytes": 5595136,
"scriptDurationMs": 658.591,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665648854961834,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2154.76799999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.45,
"layouts": 7,
"layoutDurationMs": 1.5119999999999998,
"taskDurationMs": 1379.8120000000001,
"heapDeltaBytes": 9832440,
"heapUsedBytes": 85293416,
"domNodes": -257,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 645.608,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3444.9240000000145,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.404,
"layouts": 66,
"layoutDurationMs": 12.473999999999998,
"taskDurationMs": 1580.083,
"heapDeltaBytes": 6377116,
"heapUsedBytes": 82483740,
"domNodes": -233,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 655.76,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3291.594000000032,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.468,
"layouts": 64,
"layoutDurationMs": 12.246,
"taskDurationMs": 1528.611,
"heapDeltaBytes": -3074552,
"heapUsedBytes": 73585564,
"domNodes": -233,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 631.721,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66548223350254,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2383.466999999996,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.905,
"layouts": 7,
"layoutDurationMs": 1.6929999999999996,
"taskDurationMs": 1608.4410000000003,
"heapDeltaBytes": 13019124,
"heapUsedBytes": 91672688,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 778.058,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78439716312057,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2569.012999999984,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.734999999999999,
"layouts": 8,
"layoutDurationMs": 2.0560000000000005,
"taskDurationMs": 1665.274,
"heapDeltaBytes": 13933328,
"heapUsedBytes": 92276112,
"domNodes": 0,
"jsHeapTotalBytes": 7233536,
"scriptDurationMs": 816.4119999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66623376623377,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3039.5070000000146,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0539999999999994,
"layouts": 7,
"layoutDurationMs": 1.909,
"taskDurationMs": 686.075,
"heapDeltaBytes": 11422168,
"heapUsedBytes": 87392488,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 317.224,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3051.017999999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.184,
"layouts": 7,
"layoutDurationMs": 1.9880000000000002,
"taskDurationMs": 703.0340000000001,
"heapDeltaBytes": 7472968,
"heapUsedBytes": 81637320,
"domNodes": -257,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 316.17900000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666120218579234,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.7070000000067,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9789999999999999,
"layouts": 7,
"layoutDurationMs": 1.8520000000000003,
"taskDurationMs": 507.915,
"heapDeltaBytes": -10306100,
"heapUsedBytes": 66534924,
"domNodes": -257,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 30.179000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.6450000000314,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4290000000000007,
"layouts": 8,
"layoutDurationMs": 2.244,
"taskDurationMs": 527.3770000000001,
"heapDeltaBytes": -16418208,
"heapUsedBytes": 64358764,
"domNodes": -257,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 32.767,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2676.3710000000174,
"styleRecalcs": 26,
"styleRecalcDurationMs": 13.045000000000002,
"layouts": 7,
"layoutDurationMs": 1.8840000000000003,
"taskDurationMs": 560.213,
"heapDeltaBytes": -13763988,
"heapUsedBytes": 64724268,
"domNodes": -249,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 164.275,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583850931677,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2849.055000000021,
"styleRecalcs": 25,
"styleRecalcDurationMs": 12.102000000000002,
"layouts": 6,
"layoutDurationMs": 1.7150000000000003,
"taskDurationMs": 571.224,
"heapDeltaBytes": 37484,
"heapUsedBytes": 76192560,
"domNodes": -252,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 174.00900000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66608187134503,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3150.6629999999805,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9609999999999992,
"layouts": 7,
"layoutDurationMs": 1.824,
"taskDurationMs": 836.481,
"heapDeltaBytes": -6238872,
"heapUsedBytes": 86696032,
"domNodes": -257,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 303.65,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137564,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-topology-cadence",
"durationMs": 3151.147999999978,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.064000000000001,
"layouts": 7,
"layoutDurationMs": 1.7479999999999996,
"taskDurationMs": 840.708,
"heapDeltaBytes": 7394768,
"heapUsedBytes": 83714344,
"domNodes": -257,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 305.713,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137564,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.1719999999896,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.015,
"layouts": 9,
"layoutDurationMs": 2.1449999999999996,
"taskDurationMs": 369.37299999999993,
"heapDeltaBytes": -994304,
"heapUsedBytes": 60324732,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 124.44200000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.3159999999671,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.794,
"layouts": 9,
"layoutDurationMs": 2.5610000000000004,
"taskDurationMs": 381.081,
"heapDeltaBytes": -1030772,
"heapUsedBytes": 60424900,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 127.47,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.0719999999937,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2189999999999994,
"layouts": 9,
"layoutDurationMs": 2.906,
"taskDurationMs": 438.51400000000007,
"heapDeltaBytes": 2583320,
"heapUsedBytes": 64443624,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.716000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.1430000000278,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.862000000000001,
"layouts": 10,
"layoutDurationMs": 2.949,
"taskDurationMs": 327.181,
"heapDeltaBytes": 24353308,
"heapUsedBytes": 85209872,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.346000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.4369999999935,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.479,
"layouts": 9,
"layoutDurationMs": 2.274,
"taskDurationMs": 691.926,
"heapDeltaBytes": 17755072,
"heapUsedBytes": 79753192,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 97.042,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.9379999999833,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.151,
"layouts": 10,
"layoutDurationMs": 2.2050000000000005,
"taskDurationMs": 672.427,
"heapDeltaBytes": -10113108,
"heapUsedBytes": 71116276,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 93.307,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.5690000000322,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.615,
"layouts": 5,
"layoutDurationMs": 9.806,
"taskDurationMs": 896.3789999999998,
"heapDeltaBytes": 38273360,
"heapUsedBytes": 113950196,
"domNodes": 16030,
"jsHeapTotalBytes": 14553088,
"scriptDurationMs": 30.21299999999999,
"eventListeners": 3246,
"totalBlockingTimeMs": 144,
"frameDurationMs": 19.44166666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8232.304,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.74700000000001,
"layouts": 8,
"layoutDurationMs": 1.9579999999999997,
"taskDurationMs": 5086.824,
"heapDeltaBytes": 2521240,
"heapUsedBytes": 76539684,
"domNodes": -257,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 2282.577,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665991902834012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8239.71899999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.196,
"layouts": 9,
"layoutDurationMs": 1.902,
"taskDurationMs": 5161.722999999999,
"heapDeltaBytes": -9093348,
"heapUsedBytes": 64653120,
"domNodes": -257,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 2357.6409999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16875.494000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16283.526000000002,
"heapDeltaBytes": 12545572,
"heapUsedBytes": 289622588,
"domNodes": -3343,
"jsHeapTotalBytes": 36954112,
"scriptDurationMs": 242.909,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.76491228070176,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17415.453999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16736.976,
"heapDeltaBytes": 20978608,
"heapUsedBytes": 302054940,
"domNodes": -3343,
"jsHeapTotalBytes": 41934848,
"scriptDurationMs": 260.311,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.637901861252114,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 22285.882000000016,
"styleRecalcs": 169,
"styleRecalcDurationMs": 27.611000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21899.950999999997,
"heapDeltaBytes": -11989012,
"heapUsedBytes": 280124440,
"domNodes": -3343,
"jsHeapTotalBytes": 16699392,
"scriptDurationMs": 866.0980000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 41.15674676524954,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20481.865000000085,
"styleRecalcs": 156,
"styleRecalcDurationMs": 23.163000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20098.098,
"heapDeltaBytes": -15376016,
"heapUsedBytes": 267263688,
"domNodes": -3343,
"jsHeapTotalBytes": 18866176,
"scriptDurationMs": 790.25,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.46973684210526,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6321.493000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.97600000000002,
"layouts": 20,
"layoutDurationMs": 25.42499999999999,
"taskDurationMs": 6254.246999999999,
"heapDeltaBytes": -45524856,
"heapUsedBytes": 250834080,
"domNodes": -3343,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 121.102,
"eventListeners": -653,
"totalBlockingTimeMs": 16,
"frameDurationMs": 36.301149425287356,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6282.177000000047,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.606,
"layouts": 20,
"layoutDurationMs": 24.212999999999997,
"taskDurationMs": 6165.994,
"heapDeltaBytes": 3901504,
"heapUsedBytes": 281189440,
"domNodes": -3343,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 97.08500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 11,
"frameDurationMs": 37.978181818181824,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8977.397999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8555.818000000001,
"heapDeltaBytes": 7301848,
"heapUsedBytes": 265248200,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.77099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.19097222222222,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8717.423000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8506.956,
"heapDeltaBytes": 21965920,
"heapUsedBytes": 304188140,
"domNodes": 0,
"jsHeapTotalBytes": 16515072,
"scriptDurationMs": 134.95600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.612152777777776,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 482.9429999999775,
"styleRecalcs": 19,
"styleRecalcDurationMs": 11.591,
"layouts": 13,
"layoutDurationMs": 4.719,
"taskDurationMs": 144.388,
"heapDeltaBytes": 7282852,
"heapUsedBytes": 76188356,
"domNodes": 138,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.424,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 446.80400000004283,
"styleRecalcs": 15,
"styleRecalcDurationMs": 9.516,
"layouts": 14,
"layoutDurationMs": 4.146,
"taskDurationMs": 109.26899999999999,
"heapDeltaBytes": 6784968,
"heapUsedBytes": 67360736,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.177999999999999,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 365.96800000006624,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.679,
"layouts": 76,
"layoutDurationMs": 12.860999999999999,
"taskDurationMs": 316.38100000000003,
"heapDeltaBytes": -5161348,
"heapUsedBytes": 36099132,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 138.519,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 432.3470000000498,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.703,
"layouts": 76,
"layoutDurationMs": 16.267,
"taskDurationMs": 380.68199999999996,
"heapDeltaBytes": -4388420,
"heapUsedBytes": 36594680,
"domNodes": 4,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 167.77999999999997,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 353.75900000008187,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.6520000000000001,
"layouts": 76,
"layoutDurationMs": 11.889000000000001,
"taskDurationMs": 318.09999999999997,
"heapDeltaBytes": -626936,
"heapUsedBytes": 89098848,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 111.622,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66363636363634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 367.89699999997083,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.7650000000000001,
"layouts": 76,
"layoutDurationMs": 12.113000000000001,
"taskDurationMs": 334.452,
"heapDeltaBytes": -1018072,
"heapUsedBytes": 92384204,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 118.948,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669565217391288,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 60.4% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3115 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4efc681ee0891fb906730fbe410b9cbb189007be
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (210)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.59 #22094 +/- ##
=============================================
- Coverage 87.61% 87.48% -0.13%
=============================================
Files 2784 2945 +161
Lines 154811 155857 +1046
Branches 39984 39987 +3
=============================================
+ Hits 135630 136355 +725
- Misses 18507 18827 +320
- Partials 674 675 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 337 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #22073 to
core/1.59Automatically created by backport workflow.