Repository navigation
[backport core/1.57] fix(agent): catalog-mismatch toast says the next message rebuilds the workflow (FE-3493) - #22045
Conversation
… workflow (FE-3493) (#21677) The catalog-mismatch sync toast now says what to do: a node changed, your canvas is untouched, and your next message lets the agent rebuild its copy. Before, it said "incompatible node catalog" with no way forward. Fixes https://linear.app/comfyorg/issue/FE-3493 - Copy in `src/locales/en/main.json`, plus a one-line change to `formatWorkflowSyncErrorDetail` so the host's raw message is not appended for this code (see the note on the frozen directory below) - The existing refused-follower e2e case now runs for `catalog_mismatch` too, and checks the toast copy and that the next message carries the canvas - The formatter no longer appends the host's raw message for `catalog_mismatch`, so the toast does not end by saying retrying will not help <details><summary>Full context for agent readers</summary> **Why the promise is true.** A `catalog_mismatch` `doc_subscribed` refusal is permanent (`PERMANENT_DOC_SUBSCRIBE_REFUSAL_CODES`), so the follower latches `terminal = 'refused'` and the toast fires once. `AgentPanelRoot.targetWorkflowDraft()` only withholds the canvas when the bound canvas may be stale, and a refusal does not mark it stale, so the next prompt posts the draft. On the server, `ensureDoc` treats a `catalog_mismatch` like a stale schema and re-mints from a posted canvas (`reseedCauseOf` / `canReseedStaleSchema` in `services/agent/internal/loop/crdt.go`). That re-mint is shared by hosted and local. On local, Comfy-Org/cloud#14302 (ING-213, merged 2026-10-19) is what makes the subscribe refuse in the first place, so a local build that shows this toast already has the recovery. **Hosted wording.** Hosted subscribe is a state-vector resync without a catalog check, so hosted rarely or never sends this refusal on subscribe. If it does, the same re-mint applies, so the copy still holds. **When the rebuild still fails closed** (server side, unchanged): the prompt targets a workflow the panel is not showing (no canvas posted), the canvas is empty, or `AGENT_STALE_SCHEMA_RESEED=off`. The copy says the next message *sends your canvas so the agent can rebuild*, which is what this frontend guarantees. It does not promise the server outcome. **The raw host message, resolved in this PR (was listed here as a leftover).** `formatWorkflowSyncErrorDetail` used to append the host's raw `message` for every code. For this one the local agent sends `the document was minted under a different widget catalog; retrying will not help` (`catalogMismatchMessage`, `services/agent/local/internal/server/events_doc_frames.go:349`), and the hosted path sends the identical string from `socketDocCode` (`services/agent/server/events_doc_frames.go:637`), so the rendered toast ended by contradicting the new copy. The formatter now returns the localized detail alone for `catalog_mismatch` and still appends the raw message for every other code, which covers both senders where a cloud-side wording change would have needed two edits. Raised by @dante01yoon in review and fixed in `391fb7ad`. **Note on the frozen directory.** That fix edits `src/workbench/extensions/agent/crdt/`, which the informal remote-ops/ECS freeze names. It is copy formatting rather than remote-apply or reconcile work, and the refactor the freeze was protecting landed in #18700, but flagging it so a reviewer can weigh it rather than discover it. **Verification** - `pnpm exec playwright test browser_tests/tests/agent/boundCanvasReadPath.spec.ts --project=cloud`: 4 passed locally (DISTRIBUTION=cloud dev server, own ComfyUI container) - Mutation check: pointing `catalog_mismatch` at the generic detail key fails the new case on the detail assertion; reverted - Mutation check on the formatter: reverting the `catalog_mismatch` arm turns `workflowSyncErrorDetail.test.ts` red and fails the browser case on the rendered toast text; reverted - Toast rendered and inspected: title plus the full new detail, no truncation - `pnpm typecheck:browser`, oxfmt, oxlint green (pre-commit + pre-push) Other locales are regenerated by the i18n workflow, as usual. </details> (cherry picked from commit 740e609)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T03:28:28.024Z",
"gitSha": "0df40d030768acf8a49a30497013d50686671233",
"branch": "backport-21677-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.4719999999788,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5980000000000003,
"layouts": 8,
"layoutDurationMs": 2.473,
"taskDurationMs": 511.443,
"heapDeltaBytes": 22034124,
"heapUsedBytes": 87593884,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.700000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.8819999999714,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0089999999999995,
"layouts": 9,
"layoutDurationMs": 2.7940000000000005,
"taskDurationMs": 521.559,
"heapDeltaBytes": -905920,
"heapUsedBytes": 74220284,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.852999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2037.1670000000108,
"styleRecalcs": 85,
"styleRecalcDurationMs": 17.891,
"layouts": 8,
"layoutDurationMs": 2.7230000000000003,
"taskDurationMs": 1112.998,
"heapDeltaBytes": 15664340,
"heapUsedBytes": 81565428,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 177.353,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.3709999999555,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.322,
"layouts": 9,
"layoutDurationMs": 2.559,
"taskDurationMs": 894.338,
"heapDeltaBytes": -2872984,
"heapUsedBytes": 72254004,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 169.15099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.1209999999583,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.879999999999999,
"layouts": 12,
"layoutDurationMs": 3.6559999999999997,
"taskDurationMs": 447.401,
"heapDeltaBytes": -4083588,
"heapUsedBytes": 70944048,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 15.384999999999996,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.8650000000698,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.271,
"layouts": 11,
"layoutDurationMs": 3.361,
"taskDurationMs": 441.9409999999999,
"heapDeltaBytes": -4508820,
"heapUsedBytes": 70562580,
"domNodes": 47,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 15.035999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 692.1739999999659,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.8069999999999995,
"layouts": 9,
"layoutDurationMs": 2.5269999999999997,
"taskDurationMs": 493.982,
"heapDeltaBytes": 1983312,
"heapUsedBytes": 76955092,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 171.709,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 656.0359999999719,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1780000000000004,
"layouts": 6,
"layoutDurationMs": 2.032,
"taskDurationMs": 469.2579999999999,
"heapDeltaBytes": 26503760,
"heapUsedBytes": 92366712,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 177.349,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.56756756756758,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.8340000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 939.7589999999999,
"heapDeltaBytes": 1301088,
"heapUsedBytes": 81679396,
"domNodes": -212,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 72.07200000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 557,
"frameDurationMs": 32.89210526315789,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1228.3489999999802,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 936.7840000000001,
"heapDeltaBytes": -13218244,
"heapUsedBytes": 81428308,
"domNodes": -212,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 72.767,
"eventListeners": -106,
"totalBlockingTimeMs": 532,
"frameDurationMs": 32.45526315789474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.3699999999849,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.89499999999987,
"heapDeltaBytes": -4788796,
"heapUsedBytes": 76052876,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.284,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 871.5000000000828,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.1100000000004,
"heapDeltaBytes": -5525144,
"heapUsedBytes": 75548968,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.086,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 25.49117647058823,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10510.036000000015,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.053000000000000096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9565.501999999999,
"heapDeltaBytes": -2644908,
"heapUsedBytes": 97060144,
"domNodes": -278,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 7710.284,
"eventListeners": -68,
"totalBlockingTimeMs": 1020,
"frameDurationMs": 31.485628742514965,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9856.03900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9092.027,
"heapDeltaBytes": -17270656,
"heapUsedBytes": 83190344,
"domNodes": -278,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7326.093,
"eventListeners": -68,
"totalBlockingTimeMs": 823,
"frameDurationMs": 31.222468354430383,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11288.57899999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10531.734999999999,
"heapDeltaBytes": 2558372,
"heapUsedBytes": 90107472,
"domNodes": -258,
"jsHeapTotalBytes": 9039872,
"scriptDurationMs": 8737.064,
"eventListeners": -68,
"totalBlockingTimeMs": 1457,
"frameDurationMs": 31.872316384180788,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10618.017000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9782.654,
"heapDeltaBytes": -25866952,
"heapUsedBytes": 73549400,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 7917.662,
"eventListeners": -68,
"totalBlockingTimeMs": 985,
"frameDurationMs": 31.50237388724036,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 232.47000000003482,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.632,
"layouts": 11,
"layoutDurationMs": 3.5420000000000003,
"taskDurationMs": 175.51000000000002,
"heapDeltaBytes": -8148804,
"heapUsedBytes": 79290868,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.092,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 232.62399999998706,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.375,
"layouts": 11,
"layoutDurationMs": 3.486,
"taskDurationMs": 174.546,
"heapDeltaBytes": 13065376,
"heapUsedBytes": 92216052,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.541,
"eventListeners": 195,
"totalBlockingTimeMs": 2,
"frameDurationMs": 25.922222222222143,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2056.7459999999755,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.456,
"layouts": 8,
"layoutDurationMs": 2.536,
"taskDurationMs": 685.1489999999999,
"heapDeltaBytes": -25385712,
"heapUsedBytes": 71964412,
"domNodes": -278,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 40.877,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.598999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.685000000000001,
"layouts": 8,
"layoutDurationMs": 2.627,
"taskDurationMs": 673.5369999999999,
"heapDeltaBytes": -26413564,
"heapUsedBytes": 71089124,
"domNodes": -278,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 32.794000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2806.0650000000464,
"styleRecalcs": 65,
"styleRecalcDurationMs": 5.643,
"layouts": 4,
"layoutDurationMs": 1.261,
"taskDurationMs": 1808.259,
"heapDeltaBytes": -20382848,
"heapUsedBytes": 77595372,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 860.472,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.969090909090912,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2235.859000000005,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.173,
"layouts": 7,
"layoutDurationMs": 2.138,
"taskDurationMs": 1551.622,
"heapDeltaBytes": -12590412,
"heapUsedBytes": 67943124,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 825.511,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79172932330827,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4037.963999999988,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.06,
"layouts": 64,
"layoutDurationMs": 11.695,
"taskDurationMs": 1983.705,
"heapDeltaBytes": 8318212,
"heapUsedBytes": 90265868,
"domNodes": -254,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 865.001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.735123966942147,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3819.458000000054,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.8580000000000005,
"layouts": 63,
"layoutDurationMs": 10.923,
"taskDurationMs": 1879.288,
"heapDeltaBytes": -144616,
"heapUsedBytes": 81406812,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 809.326,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.739035087719298,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3207.885000000033,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.551999999999999,
"layouts": 3,
"layoutDurationMs": 1.1089999999999998,
"taskDurationMs": 2045.9870000000003,
"heapDeltaBytes": -740548,
"heapUsedBytes": 77799080,
"domNodes": 0,
"jsHeapTotalBytes": 3235840,
"scriptDurationMs": 1004.9820000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.106878306878308,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3098.8459999999804,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.342,
"layouts": 5,
"layoutDurationMs": 1.202,
"taskDurationMs": 1961.9379999999999,
"heapDeltaBytes": 10243252,
"heapUsedBytes": 88202372,
"domNodes": 0,
"jsHeapTotalBytes": 5206016,
"scriptDurationMs": 960.5649999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84728260869565,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2049.52099999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.3299999999999996,
"layouts": 7,
"layoutDurationMs": 2.356,
"taskDurationMs": 464.68999999999994,
"heapDeltaBytes": -2565640,
"heapUsedBytes": 78753908,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 32.882999999999996,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2062.3669999999947,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.725999999999999,
"layouts": 8,
"layoutDurationMs": 2.459,
"taskDurationMs": 702.4959999999999,
"heapDeltaBytes": -27114024,
"heapUsedBytes": 71904236,
"domNodes": -278,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 34.757999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.928999999996,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.914,
"layouts": 9,
"layoutDurationMs": 2.4250000000000003,
"taskDurationMs": 483.358,
"heapDeltaBytes": 21572280,
"heapUsedBytes": 88950432,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 149.727,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.5540000000728,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.443,
"layouts": 9,
"layoutDurationMs": 2.97,
"taskDurationMs": 401.34600000000006,
"heapDeltaBytes": 21625800,
"heapUsedBytes": 89045776,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 154.32199999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.1430000000046,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3379999999999996,
"layouts": 10,
"layoutDurationMs": 3.077,
"taskDurationMs": 566.7420000000001,
"heapDeltaBytes": 3919396,
"heapUsedBytes": 81280896,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 12.33,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.0870000000796,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.3299999999999996,
"layouts": 10,
"layoutDurationMs": 2.9259999999999997,
"taskDurationMs": 533.8259999999999,
"heapDeltaBytes": 22507764,
"heapUsedBytes": 89043356,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.246,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.2069999999921,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.051999999999996,
"layouts": 10,
"layoutDurationMs": 3.2800000000000002,
"taskDurationMs": 871.2879999999999,
"heapDeltaBytes": -7273152,
"heapUsedBytes": 69694316,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 116.402,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.3660000000882,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.072000000000003,
"layouts": 9,
"layoutDurationMs": 2.9520000000000004,
"taskDurationMs": 731.739,
"heapDeltaBytes": 10937416,
"heapUsedBytes": 77860548,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 120.67099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1446.7039999999542,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.839000000000002,
"layouts": 5,
"layoutDurationMs": 16.77,
"taskDurationMs": 1082.8679999999997,
"heapDeltaBytes": 9701692,
"heapUsedBytes": 104788184,
"domNodes": 15953,
"jsHeapTotalBytes": 17702912,
"scriptDurationMs": 28.07099999999999,
"eventListeners": 3244,
"totalBlockingTimeMs": 162,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10461.259999999982,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.932000000000002,
"layouts": 9,
"layoutDurationMs": 2.7329999999999997,
"taskDurationMs": 6356.9259999999995,
"heapDeltaBytes": -13393020,
"heapUsedBytes": 84810816,
"domNodes": -278,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 2895.028,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69249201277955,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10023.267999999916,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.433,
"layouts": 7,
"layoutDurationMs": 2.0979999999999994,
"taskDurationMs": 6303.322999999999,
"heapDeltaBytes": 12559108,
"heapUsedBytes": 92807700,
"domNodes": -278,
"jsHeapTotalBytes": 3465216,
"scriptDurationMs": 2908.262,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.721535893155256,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23181.223000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22582.992,
"heapDeltaBytes": -47598776,
"heapUsedBytes": 253308328,
"domNodes": -3330,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 328.676,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.969655172413795,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22989.078000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22412.879,
"heapDeltaBytes": -5846048,
"heapUsedBytes": 285535832,
"domNodes": -3330,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 316.17699999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.17902097902098,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19407.21199999996,
"styleRecalcs": 162,
"styleRecalcDurationMs": 12.58200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19011.644999999997,
"heapDeltaBytes": -13885048,
"heapUsedBytes": 281414728,
"domNodes": -3330,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 818.1610000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 35.17373188405797,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28233.275999999933,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.753000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27932.601,
"heapDeltaBytes": -33469676,
"heapUsedBytes": 262284352,
"domNodes": -3330,
"jsHeapTotalBytes": 7327744,
"scriptDurationMs": 910.698,
"eventListeners": -651,
"totalBlockingTimeMs": 16,
"frameDurationMs": 54.156238003838766,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 8336.424000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.97399999999998,
"layouts": 20,
"layoutDurationMs": 22.153000000000006,
"taskDurationMs": 8211.559,
"heapDeltaBytes": -23712104,
"heapUsedBytes": 271144356,
"domNodes": -3330,
"jsHeapTotalBytes": 19124224,
"scriptDurationMs": 129.612,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.62622950819672,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 8219.453999999929,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.85899999999998,
"layouts": 20,
"layoutDurationMs": 21.48499999999999,
"taskDurationMs": 8131.4299999999985,
"heapDeltaBytes": -37533532,
"heapUsedBytes": 263619828,
"domNodes": -307,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 115.46999999999998,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.493641618497115,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11456.391000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11184.326000000001,
"heapDeltaBytes": -4341804,
"heapUsedBytes": 269425116,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.962,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.07713310580204,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8038.140999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7478.546000000001,
"heapDeltaBytes": 2669760,
"heapUsedBytes": 256146764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.37699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.51027397260274,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 124.77300000000469,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.431000000000003,
"layouts": 8,
"layoutDurationMs": 3.5610000000000004,
"taskDurationMs": 93.737,
"heapDeltaBytes": -11214716,
"heapUsedBytes": 68697764,
"domNodes": 120,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 7.9940000000000015,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 480.5179999999609,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.077000000000002,
"layouts": 12,
"layoutDurationMs": 4.111,
"taskDurationMs": 133.243,
"heapDeltaBytes": -13109876,
"heapUsedBytes": 70512320,
"domNodes": 121,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 10.603,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 414.01600000006056,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.008,
"layouts": 76,
"layoutDurationMs": 14.564,
"taskDurationMs": 369.729,
"heapDeltaBytes": -22233960,
"heapUsedBytes": 71762276,
"domNodes": 4,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 173.426,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668000000000028,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 515.5109999999468,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.909,
"layouts": 76,
"layoutDurationMs": 14.824,
"taskDurationMs": 463.16700000000003,
"heapDeltaBytes": -21026860,
"heapUsedBytes": 71792388,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 223.066,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 574.8889999999847,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.853,
"layouts": 76,
"layoutDurationMs": 15.331,
"taskDurationMs": 535.141,
"heapDeltaBytes": 896672,
"heapUsedBytes": 124430316,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 223.59699999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 512.205999999992,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8010000000000002,
"layouts": 76,
"layoutDurationMs": 15.517,
"taskDurationMs": 469.11800000000005,
"heapDeltaBytes": 156300,
"heapUsedBytes": 128672012,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 191.251,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2281 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2e3341f4dd1beb27dd9631a09f04280d367a77d9
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #22045 +/- ##
=============================================
- Coverage 84.14% 84.09% -0.05%
=============================================
Files 2842 2985 +143
Lines 158280 159124 +844
Branches 38526 40692 +2166
=============================================
+ Hits 133181 133815 +634
- Misses 24710 24919 +209
- Partials 389 390 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 286 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21677 to core/1.57 with a justified test adaptation.
I compared this head against merged source 740e609, which is on current main. The locale, formatter, and formatter regression test have identical changed lines.
The only adaptation omits the source's browser-test changes. I verified that core/1.57 lacks both the bound-canvas read-path spec and its permanent-subscribe-refusal helper. Leaving that helper unchanged avoids importing the absent test setup; the formatter regression test is retained. The target still passes its serialized canvas with the next message, and its sync-error toast calls the changed formatter.
With core/1.57's own locked dependencies, I ran the formatter, document-lifecycle, and follower suites: 160 tests passed across three files, including all seven formatter cases. Targeted type-aware oxlint and diff whitespace checks passed. CI on this head has no failed or pending checks.
Backport of #21677 to
core/1.57.Full context for agent readers
Auto-backport failed on conflicts in test files only (
browser_tests/tests/agent/agentPanelMocks.ts,browser_tests/tests/agent/boundCanvasReadPath.spec.ts).src/locales/en/main.json,workflowSyncErrorDetail.tsand its unit test applied cleanly.Tests: Unit test for the toast text. The e2e spec
boundCanvasReadPath.spec.tsdoes not exist on this branch, so its change is dropped;agentPanelMocks.tsis unchanged.vitest run workflowSyncErrorDetail.test.ts: 7 passed locally;pnpm typecheck:browserpassed on the 1.58 branch.Why backport: local agent users on ComfyUI stable run older frontend trains. The local agent fix this copy describes (Comfy-Org/cloud#14302) ships in the local agent package, so without this they see the old dead-end message.