Repository navigation
[backport cloud/1.58] fix: restore a run's outputs when it finished while the socket was down (PM-2123) (#21282) - #22036
Conversation
…e job (#21300) ## Summary Frames from a job queued in a background tab paint the visible tab's canvas: progress bars, previews, outputs and progress text land on whichever nodes share an id. This gates every path that writes to the visible canvas on one predicate, `belongsToActiveWorkflow(jobId)`, which compares the workflow instance that queued the job (already recorded by `storeJob`) with `workflowStore.activeWorkflow`. Per-job bookkeeping (`queuedJobs`, `nodeProgressStatesByJob`, workflow tab status, job previews) still accepts every frame. ```diff execution_start per-job bookkeeping, tab status + if owned: activeJobId, locator cache, start errors progress_state nodeProgressStatesByJob + if owned: nodeProgressStates mirror, executing progress progress if owned: executingNodeProgress executed if owned: activeJob.nodes, node outputs, onExecuted execution_cached if owned: activeJob.nodes b_preview_with_meta jobPreviewStore + if owned: node previews progress_text if owned: text preview widget +activeWorkflow change + adopt that workflow's started job as activeJobId + restore its mirror from nodeProgressStatesByJob, or clear the mirror ``` Jobs whose owner is unknown (queued by another client, or before a reload) keep today's behaviour: admitted unless a different job is already active. Terminal frames (`execution_success`, `execution_error`, `execution_interrupted`) are unchanged and still reset global state for any job. This is the minimal cut of #20045. It leaves out the `workflow_metadata` wire field, the graph-id and path fallbacks, queue-poll eviction, `api.lastExecutingMessage` and the backend simulator. Each can follow as its own PR if it turns out to be needed. Fixes #1293 Fixes #2660 Fixes #6730 ## Verification - `pnpm test:unit src/stores/executionStore.test.ts src/composables/node/useProgressTextPreviews.test.ts src/scripts/app.test.ts`: 293 passed. - With the source changes stashed, the 8 new tests fail (background `execution_start` becomes active, background `progress_state` reaches the mirror, background `executed`/`execution_cached` mark the active job, no adoption on tab switch, background outputs/previews/text reach the visible nodes); the unknown-owner test passes on both sides. - Not covered: a two-tab Playwright run against a real backend. The tests fire the same frames the server sends through `api`'s event listeners. Known gap, unchanged from main: with two jobs running at once across tabs (Cloud), a foreign job's terminal frame clears the visible mirror until the next `progress_state` frame of the visible job. ## Merge Danger **Door:** two-way. Revert restores the previous behaviour; no persisted data or wire format changes. **Blast Radius:** execution display Extensions that read `executionStore.activeJobId` or `executingNodeId` now see the visible tab's job rather than whichever job last started. `node.onExecuted` no longer fires on the visible graph for a background job's node. --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> (cherry picked from commit d3193bb)
Restores completed-run outputs after reconnect. Justification: named human approval covered the substantive code; the only post-approval delta removed prohibited comments, exact-head required checks are green, and the eight-commit main delta has zero file overlap. (cherry picked from commit 0ce4863)
…(PM-2219) (#21889) Justification: approved at exact head ed221f1 by dante01yoon (frontend reviewer) plus comfy-greenlight-bot and coderabbitai; required checks test, lint-and-format, e2e-status, website-e2e all SUCCESS at that head; the single failing job upload-e2e-coverage / package is not a required status check on ProtectMain. Remaining review threads are explicitly non-blocking and are being answered and routed to follow-ups. (cherry picked from commit 8ce7211)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-27T02:11:16.196Z",
"gitSha": "2cb368d7c0d57d3f912da67b338b11a285cabbe4",
"branch": "backport-21282-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.0359999999628,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6240000000000006,
"layouts": 8,
"layoutDurationMs": 2.281,
"taskDurationMs": 619.2840000000001,
"heapDeltaBytes": 837084,
"heapUsedBytes": 91126840,
"domNodes": -201,
"jsHeapTotalBytes": 581632,
"scriptDurationMs": 10.938999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2041.4839999999685,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4739999999999998,
"layouts": 10,
"layoutDurationMs": 3.352,
"taskDurationMs": 454.927,
"heapDeltaBytes": 4789376,
"heapUsedBytes": 95102556,
"domNodes": -201,
"jsHeapTotalBytes": -204800,
"scriptDurationMs": 11.108,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.0789999999856,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.654,
"layouts": 9,
"layoutDurationMs": 2.6730000000000005,
"taskDurationMs": 864.961,
"heapDeltaBytes": 623968,
"heapUsedBytes": 90919320,
"domNodes": -200,
"jsHeapTotalBytes": 3203072,
"scriptDurationMs": 177.96900000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665094339622637,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1908.1049999999777,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.256,
"layouts": 9,
"layoutDurationMs": 2.448,
"taskDurationMs": 983.6569999999999,
"heapDeltaBytes": -380912,
"heapUsedBytes": 89879272,
"domNodes": -200,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 173.403,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684207,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4469999999978,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.940000000000001,
"layouts": 11,
"layoutDurationMs": 4.083,
"taskDurationMs": 375.938,
"heapDeltaBytes": -1448044,
"heapUsedBytes": 88918492,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 16.65,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.7710000000088,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.984999999999999,
"layouts": 12,
"layoutDurationMs": 3.645,
"taskDurationMs": 360.51599999999996,
"heapDeltaBytes": 205068,
"heapUsedBytes": 99802848,
"domNodes": 47,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 15.584999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 718.1380000000104,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0230000000000006,
"layouts": 9,
"layoutDurationMs": 2.763,
"taskDurationMs": 516.5840000000001,
"heapDeltaBytes": 4148048,
"heapUsedBytes": 93949876,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 171.307,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.5660000000616,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6959999999999997,
"layouts": 8,
"layoutDurationMs": 2.455,
"taskDurationMs": 500.72700000000003,
"heapDeltaBytes": 3951852,
"heapUsedBytes": 103849736,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 172.79,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669047619047628,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1300.2630000000295,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 970.4750000000001,
"heapDeltaBytes": -14290200,
"heapUsedBytes": 103173488,
"domNodes": -211,
"jsHeapTotalBytes": 15007744,
"scriptDurationMs": 86.86499999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 610,
"frameDurationMs": 35.132432432432445,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1272.2109999999702,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 974.4419999999999,
"heapDeltaBytes": -14163580,
"heapUsedBytes": 103200120,
"domNodes": -216,
"jsHeapTotalBytes": 16318464,
"scriptDurationMs": 83.87400000000001,
"eventListeners": -168,
"totalBlockingTimeMs": 559,
"frameDurationMs": 33.331578947368406,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.6019999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.40999999999985,
"heapDeltaBytes": -3985992,
"heapUsedBytes": 97326024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.99400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.3089999999765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.7330000000003,
"heapDeltaBytes": -3971388,
"heapUsedBytes": 97451520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.522,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10682.651000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9818.534,
"heapDeltaBytes": 49164648,
"heapUsedBytes": 152256396,
"domNodes": -296,
"jsHeapTotalBytes": 38068224,
"scriptDurationMs": 8113.893000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1231,
"frameDurationMs": 32.51920731707317,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9846.089000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9032.852,
"heapDeltaBytes": 23126464,
"heapUsedBytes": 137016968,
"domNodes": -296,
"jsHeapTotalBytes": 24793088,
"scriptDurationMs": 7429.1359999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 846,
"frameDurationMs": 31.772580645161284,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9994.114000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9183.212,
"heapDeltaBytes": 70595608,
"heapUsedBytes": 158674768,
"domNodes": -276,
"jsHeapTotalBytes": 38535168,
"scriptDurationMs": 7631.118,
"eventListeners": -130,
"totalBlockingTimeMs": 1000,
"frameDurationMs": 31.591772151898727,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10563.443000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9790.907000000001,
"heapDeltaBytes": 30723236,
"heapUsedBytes": 144707224,
"domNodes": -296,
"jsHeapTotalBytes": 32657408,
"scriptDurationMs": 7826.055,
"eventListeners": -130,
"totalBlockingTimeMs": 925,
"frameDurationMs": 31.353709198813053,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 257.6970000000074,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.387000000000002,
"layouts": 12,
"layoutDurationMs": 3.743,
"taskDurationMs": 197.61,
"heapDeltaBytes": 13341856,
"heapUsedBytes": 118812628,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.914,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999997,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 277.1180000000868,
"styleRecalcs": 28,
"styleRecalcDurationMs": 15.350000000000001,
"layouts": 12,
"layoutDurationMs": 4.051000000000001,
"taskDurationMs": 220.02,
"heapDeltaBytes": 13343296,
"heapUsedBytes": 118750916,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 11.855999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.515384615384672,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2074.0280000000553,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.995,
"layouts": 8,
"layoutDurationMs": 2.8059999999999996,
"taskDurationMs": 755.784,
"heapDeltaBytes": -27807068,
"heapUsedBytes": 92915008,
"domNodes": -296,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 43.129,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870972,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.824000000006,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6750000000000003,
"layouts": 8,
"layoutDurationMs": 2.698,
"taskDurationMs": 699.7180000000001,
"heapDeltaBytes": -19177332,
"heapUsedBytes": 102087512,
"domNodes": -296,
"jsHeapTotalBytes": -1478656,
"scriptDurationMs": 35.138,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2296.259999999961,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.656,
"layouts": 6,
"layoutDurationMs": 1.433,
"taskDurationMs": 1553.5230000000001,
"heapDeltaBytes": -10643672,
"heapUsedBytes": 112422576,
"domNodes": -296,
"jsHeapTotalBytes": -634880,
"scriptDurationMs": 817.002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2280.177999999978,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.652,
"layouts": 6,
"layoutDurationMs": 1.8770000000000002,
"taskDurationMs": 1591.7050000000002,
"heapDeltaBytes": -1324636,
"heapUsedBytes": 112548096,
"domNodes": -296,
"jsHeapTotalBytes": -147456,
"scriptDurationMs": 818.553,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.166917293233087,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3639.870999999971,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.562000000000001,
"layouts": 65,
"layoutDurationMs": 11.488,
"taskDurationMs": 1720.144,
"heapDeltaBytes": -20309108,
"heapUsedBytes": 92763984,
"domNodes": -273,
"jsHeapTotalBytes": 188416,
"scriptDurationMs": 844.866,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3582.039000000009,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.792000000000002,
"layouts": 64,
"layoutDurationMs": 11.369,
"taskDurationMs": 1699.8439999999998,
"heapDeltaBytes": -21202420,
"heapUsedBytes": 91390672,
"domNodes": -252,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 809.969,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348838,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3174.856000000034,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.198,
"layouts": 5,
"layoutDurationMs": 1.4070000000000003,
"taskDurationMs": 1973.1609999999998,
"heapDeltaBytes": -10827172,
"heapUsedBytes": 92270600,
"domNodes": 0,
"jsHeapTotalBytes": -1814528,
"scriptDurationMs": 1086.964,
"eventListeners": 182,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.203763440860214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3069.611000000009,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.0409999999999995,
"layouts": 6,
"layoutDurationMs": 1.9780000000000002,
"taskDurationMs": 1906.3609999999999,
"heapDeltaBytes": -11098108,
"heapUsedBytes": 103945976,
"domNodes": 0,
"jsHeapTotalBytes": 6819840,
"scriptDurationMs": 1017.286,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.849450549450548,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2048.549000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.4479999999999995,
"layouts": 8,
"layoutDurationMs": 2.64,
"taskDurationMs": 633.502,
"heapDeltaBytes": 472564,
"heapUsedBytes": 113014336,
"domNodes": -296,
"jsHeapTotalBytes": -991232,
"scriptDurationMs": 39.603,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2088.8069999999743,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.361,
"layouts": 7,
"layoutDurationMs": 2.3649999999999998,
"taskDurationMs": 753.193,
"heapDeltaBytes": -32461396,
"heapUsedBytes": 86665752,
"domNodes": -297,
"jsHeapTotalBytes": -1216512,
"scriptDurationMs": 37.36299999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666399999999996,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.4049999999984,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.550999999999999,
"layouts": 9,
"layoutDurationMs": 2.6879999999999997,
"taskDurationMs": 487.97200000000004,
"heapDeltaBytes": -567948,
"heapUsedBytes": 90610040,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 146.656,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 674.1719999999987,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.685999999999999,
"layouts": 10,
"layoutDurationMs": 3.134,
"taskDurationMs": 476.553,
"heapDeltaBytes": 2946204,
"heapUsedBytes": 109861420,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 155.64799999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.607000000036,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8840000000000003,
"layouts": 11,
"layoutDurationMs": 3.703,
"taskDurationMs": 460.414,
"heapDeltaBytes": 4120536,
"heapUsedBytes": 105880088,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 11.025999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.440999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7489999999999997,
"layouts": 8,
"layoutDurationMs": 2.9149999999999996,
"taskDurationMs": 650.0550000000001,
"heapDeltaBytes": -5184056,
"heapUsedBytes": 89884856,
"domNodes": -218,
"jsHeapTotalBytes": 10113024,
"scriptDurationMs": 10.487,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2005.5439999999862,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.805999999999997,
"layouts": 10,
"layoutDurationMs": 2.982,
"taskDurationMs": 994.5970000000001,
"heapDeltaBytes": 1413224,
"heapUsedBytes": 92665264,
"domNodes": -210,
"jsHeapTotalBytes": 2416640,
"scriptDurationMs": 119.685,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.7059999999692,
"styleRecalcs": 88,
"styleRecalcDurationMs": 15.965,
"layouts": 10,
"layoutDurationMs": 3.019,
"taskDurationMs": 1094.89,
"heapDeltaBytes": -6836372,
"heapUsedBytes": 94630864,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 115.353,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.8859999999531,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.892,
"layouts": 5,
"layoutDurationMs": 17.039,
"taskDurationMs": 903.6989999999998,
"heapDeltaBytes": 4741080,
"heapUsedBytes": 122249668,
"domNodes": 16030,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 34.120000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 168,
"frameDurationMs": 19.632876712328777,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.320999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.333000000000002,
"layouts": 7,
"layoutDurationMs": 2.0750000000000006,
"taskDurationMs": 5468.619,
"heapDeltaBytes": 703944,
"heapUsedBytes": 113063856,
"domNodes": -296,
"jsHeapTotalBytes": 638976,
"scriptDurationMs": 2746.8309999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.733064516129033,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.657000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.407,
"layouts": 8,
"layoutDurationMs": 2.34,
"taskDurationMs": 5389.0199999999995,
"heapDeltaBytes": -21043408,
"heapUsedBytes": 89475772,
"domNodes": -296,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 2718.303,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699596774193548,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22874.776999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22297.93,
"heapDeltaBytes": -35164516,
"heapUsedBytes": 275031916,
"domNodes": -3344,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 308.451,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.11543859649123,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16345.36300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15373.009000000002,
"heapDeltaBytes": -8668064,
"heapUsedBytes": 300991992,
"domNodes": -3344,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 243.10700000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.237132987910194,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 19498.03099999997,
"styleRecalcs": 153,
"styleRecalcDurationMs": 15.64299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19041.55,
"heapDeltaBytes": -22964508,
"heapUsedBytes": 307838900,
"domNodes": -3344,
"jsHeapTotalBytes": 14073856,
"scriptDurationMs": 796.779,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 36.01201478743068,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19485.980999999923,
"styleRecalcs": 151,
"styleRecalcDurationMs": 15.812999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18979.246,
"heapDeltaBytes": -13185480,
"heapUsedBytes": 287464296,
"domNodes": -3344,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 814.593,
"eventListeners": -651,
"totalBlockingTimeMs": 20,
"frameDurationMs": 35.81341911764706,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6031.889999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.25599999999997,
"layouts": 20,
"layoutDurationMs": 29.682,
"taskDurationMs": 5887.508000000001,
"heapDeltaBytes": -22211104,
"heapUsedBytes": 287716212,
"domNodes": -3344,
"jsHeapTotalBytes": 15978496,
"scriptDurationMs": 121.25699999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 19,
"frameDurationMs": 33.7977653631285,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8312.53599999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.20100000000001,
"layouts": 20,
"layoutDurationMs": 24.34400000000002,
"taskDurationMs": 8185.4000000000015,
"heapDeltaBytes": -11962164,
"heapUsedBytes": 293287556,
"domNodes": -3344,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 122.726,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.55307262569833,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8181.134000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7602.014,
"heapDeltaBytes": 18897052,
"heapUsedBytes": 303281280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.57700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.738644067796614,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8223.471000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7642.228000000001,
"heapDeltaBytes": -8656332,
"heapUsedBytes": 281029580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.31000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.003401360544217,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 111.66800000000876,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.879,
"layouts": 8,
"layoutDurationMs": 3.6210000000000004,
"taskDurationMs": 89.39300000000001,
"heapDeltaBytes": 4843148,
"heapUsedBytes": 95495784,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.889,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68571428571431,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.7250000000204,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.243999999999998,
"layouts": 11,
"layoutDurationMs": 3.3759999999999994,
"taskDurationMs": 116.818,
"heapDeltaBytes": 6900112,
"heapUsedBytes": 97040576,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.578999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 471.5119999999615,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.704,
"layouts": 76,
"layoutDurationMs": 15.798,
"taskDurationMs": 429.77099999999996,
"heapDeltaBytes": -14298040,
"heapUsedBytes": 81238444,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 206.164,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 494.25699999994777,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.767,
"layouts": 76,
"layoutDurationMs": 15.692000000000002,
"taskDurationMs": 446.032,
"heapDeltaBytes": -14510592,
"heapUsedBytes": 81442728,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 213.626,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 574.9400000000833,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.821,
"layouts": 76,
"layoutDurationMs": 14.266,
"taskDurationMs": 543.7189999999999,
"heapDeltaBytes": 951460,
"heapUsedBytes": 117967304,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 222.271,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 596.8699999999671,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.593,
"layouts": 76,
"layoutDurationMs": 15.011,
"taskDurationMs": 563.5609999999999,
"heapDeltaBytes": 974024,
"heapUsedBytes": 118447216,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 231.762,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.13055555555555,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2981 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c4d2189ee305d5404e24e8bfd3ec18a423cc53ec
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (124)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.58 #22036 +/- ##
=============================================
Coverage ? 85.93%
=============================================
Files ? 2592
Lines ? 135284
Branches ? 41320
=============================================
Hits ? 116253
Misses ? 18614
Partials ? 417
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21282 to cloud/1.58 with its execution-ownership prerequisite and toolbar-stop regression fix.
I reapplied the merged diffs in order: #21300 at d3193bb, #21282 at 0ce4863, then #21889 at 8ce7211. All are merged on current main. The resulting tree matches this head except for the socket counter and disconnect hook borrowed from #21497, whose shared fixture changes are absent from cloud/1.58. Those test-only hooks provide the missing reconnect controls. All source changes and tests are retained.
Using cloud/1.58's locked dependencies, I ran the seven changed unit suites: 451 passed and one skipped. All ten affected browser cases passed with retries disabled across the cloud and Chromium projects. Browser typechecking, targeted type-aware lint, and whitespace checks passed. The branch's required lint-and-format, test, and e2e-status checks passed. The advisory coverage-packaging job failed because lcov rejected duplicate inner_clicked records in unchanged LGraphCanvas.ts; the coverage merger is also unchanged by this PR. I am not treating that packaging failure as a backport divergence.
Backport of #21282 to
cloud/1.58: after a dropped connection, a run that finished while offline now shows its output without a page reload (PM-2123).It brings two PRs it depends on:
Full context for agent readers
Commits, in order (cherry-picked with
-x, all clean):d3193bb81dfix(execution): scope execution frames to the workflow that queued the job0ce48633ddfix: restore a run's outputs when it finished while the socket was downcomfyConnectionCount()anddisconnectComfySocket()tobrowser_tests/fixtures/agentFollowerHostSocket.ts. On main these came with test: pin agent wire identity across a /ws reconnect #21497, which is not on 1.58; the PM-2123 spec needs only these two hooks.8ce7211485fix(queue): enable the toolbar stop control for an Agent-started runLocal checks on Node 26.8.2:
pnpm typecheckandpnpm typecheck:browserclean; vitest over actionbar, queue, stores, reconnect, jobs, app and progress-preview tests: 103 files pass. The browser specsagentOutputAfterSocketDrop,actionbarCancelAgentRunandqueue/runProgressBarhave not run on 1.58 yet; this PR's CI is their first run.Adversarial review: a fresh Claude subagent (Codex CLI login is expired on this host). Verdict SHIP-WITH-CHANGES; the only required change is running those specs on 1.58 (CI). Its findings:
useReconnectQueueRefresh.ts,useInterruptibleJob.ts,fetchJobs.tsandqueueStore.tsare byte-identical to main after the picks;executionStore.tsdiffers only by fix(execution): report when execution_start rejects a job with no known owner #21761 (diagnostic) and fix(agent): keep an Agent run's outputs on the tab it ran for (PM-2275) #21666 (PM-2275), neither called here.Not carried: #21666 (feature, not a regression fix), #21761 (diagnostic).