Repository navigation
test(agent): [repro] agent asks for run approval twice — prose offer, then run_approval card (PM-2122) - #21283
christian-byrne wants to merge 2 commits into
Conversation
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 10 minutes for your next included review. View limit details
Comment |
📦 Bundle: 11.6 MB gzip 🟢 -2 BDetailsSummary
Category Glance App Entry Points — 6.86 kB (baseline 6.86 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.4 MB (baseline 3.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 787 kB (baseline 787 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 32 unchanged User & Accounts — 151 kB (baseline 151 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 359 kB (baseline 359 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 217 kB (baseline 217 kB) • ⚪ 0 BReusable component library chunks Status: 29 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 43 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 77 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.5 MB (baseline 20.5 MB) • ⚪ 0 BBundles that do not match a named category
Status: 2 added / 2 removed / 683 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T07:50:51.614Z",
"gitSha": "cb2cc9e0ac123c9af596070ea640588b64e289dd",
"branch": "glary/pm-2122-double-run-approval-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.9909999999904,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2950000000000004,
"layouts": 10,
"layoutDurationMs": 3.528,
"taskDurationMs": 628.552,
"heapDeltaBytes": 4020088,
"heapUsedBytes": 102366796,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 13.698000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2012.4519999999393,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9050000000000002,
"layouts": 9,
"layoutDurationMs": 2.987,
"taskDurationMs": 476.359,
"heapDeltaBytes": 3473080,
"heapUsedBytes": 94682788,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.001999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2027.5629999999865,
"styleRecalcs": 82,
"styleRecalcDurationMs": 16.918,
"layouts": 9,
"layoutDurationMs": 3.1200000000000006,
"taskDurationMs": 1084.1260000000002,
"heapDeltaBytes": -11597300,
"heapUsedBytes": 91892168,
"domNodes": -176,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 184.21400000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1795.3489999999874,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.337999999999997,
"layouts": 9,
"layoutDurationMs": 2.664,
"taskDurationMs": 854.7790000000001,
"heapDeltaBytes": -11480256,
"heapUsedBytes": 92174612,
"domNodes": -176,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 171.733,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.602000000024,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.370999999999999,
"layouts": 12,
"layoutDurationMs": 3.842,
"taskDurationMs": 503.336,
"heapDeltaBytes": 1798480,
"heapUsedBytes": 105359384,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 18.15,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.137999999978,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.852,
"layouts": 11,
"layoutDurationMs": 3.456,
"taskDurationMs": 467.04999999999995,
"heapDeltaBytes": 1876556,
"heapUsedBytes": 105780020,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 16.564,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 667.6219999999944,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.528999999999999,
"layouts": 10,
"layoutDurationMs": 3.124,
"taskDurationMs": 465.773,
"heapDeltaBytes": 9643600,
"heapUsedBytes": 108357856,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 175.3,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 826.8850000000612,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.386,
"layouts": 10,
"layoutDurationMs": 3.1519999999999997,
"taskDurationMs": 573.453,
"heapDeltaBytes": 6945644,
"heapUsedBytes": 110905220,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 181.038,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448985,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1280.2560000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1030.6760000000002,
"heapDeltaBytes": -1255372,
"heapUsedBytes": 101831348,
"domNodes": -206,
"jsHeapTotalBytes": 7843840,
"scriptDurationMs": 75.127,
"eventListeners": -168,
"totalBlockingTimeMs": 593,
"frameDurationMs": 34.68378378378379,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1283.7610000000268,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1000.099,
"heapDeltaBytes": -2288140,
"heapUsedBytes": 102286184,
"domNodes": -206,
"jsHeapTotalBytes": 9416704,
"scriptDurationMs": 79.72100000000002,
"eventListeners": -168,
"totalBlockingTimeMs": 589,
"frameDurationMs": 34.68378378378379,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.6249999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.3929999999994,
"heapDeltaBytes": -4172780,
"heapUsedBytes": 97400728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.118,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4559999999892,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.28099999999984,
"heapDeltaBytes": -5065688,
"heapUsedBytes": 95938448,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.35,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11809.476999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10971.75,
"heapDeltaBytes": -6228916,
"heapUsedBytes": 117408508,
"domNodes": -272,
"jsHeapTotalBytes": 12029952,
"scriptDurationMs": 8831.073999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1494,
"frameDurationMs": 32.68559556786703,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11612.83800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10824.822999999999,
"heapDeltaBytes": 52807556,
"heapUsedBytes": 156775496,
"domNodes": -272,
"jsHeapTotalBytes": 45625344,
"scriptDurationMs": 8747.336000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1223,
"frameDurationMs": 31.779452054794522,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10284.62399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9473.794,
"heapDeltaBytes": 22269844,
"heapUsedBytes": 143282288,
"domNodes": -272,
"jsHeapTotalBytes": 33722368,
"scriptDurationMs": 7771.75,
"eventListeners": -130,
"totalBlockingTimeMs": 1098,
"frameDurationMs": 31.160606060606067,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11787.778000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10982.748,
"heapDeltaBytes": 43977748,
"heapUsedBytes": 148947644,
"domNodes": -272,
"jsHeapTotalBytes": 35622912,
"scriptDurationMs": 8765.357999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 1630,
"frameDurationMs": 31.470478723404256,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 228.2369999999787,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.191,
"layouts": 10,
"layoutDurationMs": 3.269,
"taskDurationMs": 172.33599999999998,
"heapDeltaBytes": 13246916,
"heapUsedBytes": 118416624,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.515999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 255.9680000000526,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.035,
"layouts": 11,
"layoutDurationMs": 3.3379999999999996,
"taskDurationMs": 204.798,
"heapDeltaBytes": 13327372,
"heapUsedBytes": 117563304,
"domNodes": 917,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 9.120000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.010000000000037,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2055.5439999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9630000000000005,
"layouts": 8,
"layoutDurationMs": 2.521,
"taskDurationMs": 762.7199999999999,
"heapDeltaBytes": -13175472,
"heapUsedBytes": 108186200,
"domNodes": -273,
"jsHeapTotalBytes": -2940928,
"scriptDurationMs": 38.262,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.1560000000154,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.569,
"layouts": 7,
"layoutDurationMs": 2.4520000000000004,
"taskDurationMs": 760.6,
"heapDeltaBytes": -1294924,
"heapUsedBytes": 99357360,
"domNodes": -292,
"jsHeapTotalBytes": -1929216,
"scriptDurationMs": 36.681,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2920.603999999969,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.8309999999999995,
"layouts": 7,
"layoutDurationMs": 2.1339999999999995,
"taskDurationMs": 1857.8449999999998,
"heapDeltaBytes": -2870764,
"heapUsedBytes": 108047960,
"domNodes": -272,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 870.6550000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714287,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2985.783999999967,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.055000000000001,
"layouts": 6,
"layoutDurationMs": 1.9300000000000004,
"taskDurationMs": 1956.5960000000002,
"heapDeltaBytes": 1641864,
"heapUsedBytes": 104231788,
"domNodes": -292,
"jsHeapTotalBytes": -1703936,
"scriptDurationMs": 911.333,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.854802259887002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3707.6529999999934,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.940000000000001,
"layouts": 63,
"layoutDurationMs": 11.828000000000001,
"taskDurationMs": 1764.211,
"heapDeltaBytes": -10074788,
"heapUsedBytes": 95329536,
"domNodes": -268,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 833.688,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765766,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3964.466000000016,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.842999999999999,
"layouts": 64,
"layoutDurationMs": 10.938999999999998,
"taskDurationMs": 1906.467,
"heapDeltaBytes": 5778592,
"heapUsedBytes": 110871076,
"domNodes": -268,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 821.704,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.736708860759492,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3269.6090000000027,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.984,
"layouts": 3,
"layoutDurationMs": 0.9349999999999996,
"taskDurationMs": 2209.593,
"heapDeltaBytes": -948352,
"heapUsedBytes": 105394120,
"domNodes": -292,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 1017.4720000000002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.924870466321245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3224.872000000005,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.8999999999999995,
"layouts": 4,
"layoutDurationMs": 1.238,
"taskDurationMs": 2010.1820000000002,
"heapDeltaBytes": -3724252,
"heapUsedBytes": 103780972,
"domNodes": -292,
"jsHeapTotalBytes": 4386816,
"scriptDurationMs": 1076.3749999999998,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.9282722513089,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.5679999999975,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.72,
"layouts": 7,
"layoutDurationMs": 2.575,
"taskDurationMs": 557.475,
"heapDeltaBytes": 361864,
"heapUsedBytes": 103276996,
"domNodes": -292,
"jsHeapTotalBytes": -6123520,
"scriptDurationMs": 37.405,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.9919999999693,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8210000000000006,
"layouts": 5,
"layoutDurationMs": 1.6099999999999999,
"taskDurationMs": 706.3719999999998,
"heapDeltaBytes": -1251656,
"heapUsedBytes": 102055888,
"domNodes": -292,
"jsHeapTotalBytes": -2453504,
"scriptDurationMs": 35.85000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 712.1940000000109,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.712999999999999,
"layouts": 10,
"layoutDurationMs": 3.0309999999999997,
"taskDurationMs": 509.71299999999997,
"heapDeltaBytes": 2665288,
"heapUsedBytes": 108574336,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 154.00599999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.661904761904744,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 550.7699999999431,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.266,
"layouts": 10,
"layoutDurationMs": 2.8569999999999998,
"taskDurationMs": 398.63500000000005,
"heapDeltaBytes": 3026560,
"heapUsedBytes": 109092316,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 148.60299999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2057.3699999999917,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2680000000000002,
"layouts": 9,
"layoutDurationMs": 2.8810000000000002,
"taskDurationMs": 685.0269999999999,
"heapDeltaBytes": -9794112,
"heapUsedBytes": 90759548,
"domNodes": -214,
"jsHeapTotalBytes": 7245824,
"scriptDurationMs": 13.103,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.463000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.131000000000001,
"layouts": 9,
"layoutDurationMs": 3.183,
"taskDurationMs": 593.653,
"heapDeltaBytes": -6963028,
"heapUsedBytes": 94244280,
"domNodes": -214,
"jsHeapTotalBytes": 6983680,
"scriptDurationMs": 16.601,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2040.4350000000022,
"styleRecalcs": 87,
"styleRecalcDurationMs": 18.136,
"layouts": 10,
"layoutDurationMs": 3.4010000000000002,
"taskDurationMs": 1100.063,
"heapDeltaBytes": -17627804,
"heapUsedBytes": 88258740,
"domNodes": -206,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 132.411,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1803.384000000051,
"styleRecalcs": 56,
"styleRecalcDurationMs": 14.344000000000001,
"layouts": 7,
"layoutDurationMs": 2.1369999999999996,
"taskDurationMs": 852.0210000000001,
"heapDeltaBytes": 18753960,
"heapUsedBytes": 110558040,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 121.544,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814818,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1535.997000000009,
"styleRecalcs": 19,
"styleRecalcDurationMs": 29.13099999999999,
"layouts": 5,
"layoutDurationMs": 17.925000000000004,
"taskDurationMs": 1260.502,
"heapDeltaBytes": 7128864,
"heapUsedBytes": 124674228,
"domNodes": 15950,
"jsHeapTotalBytes": 19275776,
"scriptDurationMs": 33.253,
"eventListeners": 3244,
"totalBlockingTimeMs": 195,
"frameDurationMs": 20.173684210526314,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 11100.876000000027,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.076999999999998,
"layouts": 8,
"layoutDurationMs": 2.693,
"taskDurationMs": 6425.152000000001,
"heapDeltaBytes": 7721536,
"heapUsedBytes": 109108200,
"domNodes": -272,
"jsHeapTotalBytes": -950272,
"scriptDurationMs": 2846.05,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.690827067669172,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8389.669999999911,
"styleRecalcs": 249,
"styleRecalcDurationMs": 22.206,
"layouts": 7,
"layoutDurationMs": 1.8800000000000001,
"taskDurationMs": 5457.946,
"heapDeltaBytes": 972588,
"heapUsedBytes": 103433436,
"domNodes": -292,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 2803.9590000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23440.84700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22930.912,
"heapDeltaBytes": -15150340,
"heapUsedBytes": 295833768,
"domNodes": -3330,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 341.702,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.47046632124353,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 23539.608000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23047.65,
"heapDeltaBytes": -55680368,
"heapUsedBytes": 273449064,
"domNodes": -3330,
"jsHeapTotalBytes": -3420160,
"scriptDurationMs": 337.20700000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.57327586206897,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 29062.190999999984,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.522999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28729.980999999996,
"heapDeltaBytes": -39930912,
"heapUsedBytes": 271056948,
"domNodes": -3330,
"jsHeapTotalBytes": 7065600,
"scriptDurationMs": 945.4729999999998,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.924860853432286,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 28178.164000000037,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.916999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27809.592,
"heapDeltaBytes": -15269780,
"heapUsedBytes": 295759428,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 895.7080000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 52.7756554307116,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 6380.120999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.37400000000002,
"layouts": 20,
"layoutDurationMs": 25.924000000000003,
"taskDurationMs": 6254.677999999999,
"heapDeltaBytes": -22580192,
"heapUsedBytes": 282927292,
"domNodes": -3330,
"jsHeapTotalBytes": 4182016,
"scriptDurationMs": 118.72700000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.76629213483146,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6088.357000000087,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.11700000000003,
"layouts": 20,
"layoutDurationMs": 34.596000000000004,
"taskDurationMs": 5942.752,
"heapDeltaBytes": -25821320,
"heapUsedBytes": 285064352,
"domNodes": -3330,
"jsHeapTotalBytes": 6541312,
"scriptDurationMs": 125.82099999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 21,
"frameDurationMs": 35.16184971098266,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12075.234000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11656.672999999997,
"heapDeltaBytes": -8801388,
"heapUsedBytes": 281069492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.11599999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.37979452054794,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11933.74700000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11516.378999999999,
"heapDeltaBytes": -20545772,
"heapUsedBytes": 267635924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.24399999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.80890410958903,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 480.0250000000119,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.979,
"layouts": 11,
"layoutDurationMs": 5.936999999999999,
"taskDurationMs": 141.65800000000002,
"heapDeltaBytes": 7171824,
"heapUsedBytes": 98519844,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.619,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 482.61999999999716,
"styleRecalcs": 18,
"styleRecalcDurationMs": 11.363999999999999,
"layouts": 11,
"layoutDurationMs": 4.345,
"taskDurationMs": 125.28800000000001,
"heapDeltaBytes": -13080728,
"heapUsedBytes": 88179360,
"domNodes": 121,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.453,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 515.0479999999789,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9,
"layouts": 76,
"layoutDurationMs": 17.26,
"taskDurationMs": 472.75199999999995,
"heapDeltaBytes": -14350776,
"heapUsedBytes": 80028260,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 224.855,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 531.4309999999978,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.919,
"layouts": 76,
"layoutDurationMs": 16.965,
"taskDurationMs": 488.26800000000003,
"heapDeltaBytes": 12367960,
"heapUsedBytes": 82996824,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 230.626,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 648.9380000000438,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5500000000000003,
"layouts": 76,
"layoutDurationMs": 16.644,
"taskDurationMs": 617.3439999999999,
"heapDeltaBytes": 1780436,
"heapUsedBytes": 122530028,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 250.76899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.094871794871814,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 663.2730000000038,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.544,
"layouts": 76,
"layoutDurationMs": 17.937,
"taskDurationMs": 626.15,
"heapDeltaBytes": 906964,
"heapUsedBytes": 118049612,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 251.93899999999996,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2288 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e7fc8af32cb77c88ae5a88ffe782c2b91287093e
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21283 +/- ##
==========================================
+ Coverage 86.59% 87.40% +0.81%
==========================================
Files 3765 2688 -1077
Lines 177963 149295 -28668
Branches 47022 38838 -8184
==========================================
- Hits 154104 130491 -23613
+ Misses 21792 18414 -3378
+ Partials 2067 390 -1677
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Fix lives in the cloud agent prompt: https://github.com/Comfy-Org/cloud/pull/14194 (agent stops asking "want me to run it?" before the Run/Cancel card). This replay can't go green from the frontend; close it once that lands and the eval case in https://github.com/Comfy-Org/evals/pull/1331 confirms the behaviour. |
|
Agreed. This replay only puts the server frames on screen, so no frontend change can turn it green. I've linked Comfy-Org/cloud#14194 to PM-2122 as the fix. I'm leaving this PR open as a draft so it can be closed once #14194 lands and the eval case in Comfy-Org/evals#1331 confirms the agent asks once. No code changes on this branch. |
|
Verified 72c6530 locally:
Results on 72c6530:
I had a local commit overlapping this one, but I dropped it rather than push a duplicate. No new commits from me. |
|
Re CodeRabbit 4306534809 (overlapping-reconnect test): fixed in 0c3320f. The first queue snapshot now lists
Results:
The other three CodeRabbit threads (new-run detection, rerun on reconnect, and the |
|
Fix landed in cloud, not here: https://github.com/Comfy-Org/cloud/pull/14194 (merged 460950a848).
|
|
About CodeRabbit's outside-diff comment ("replay the completion transition for completed jobs"): I'm not taking it in this PR, per @christian-byrne's scoping. This PR restores outputs only. Replaying the missed terminal status, telemetry and I had a local attempt at it. Over four review rounds it kept running into one problem: the live |
|
I've addressed all three CodeRabbit findings in 154bd48:
Verified against a local cloud build of this branch:
|
|
I've addressed both CodeRabbit nitpicks in 3dcd9f4:
|
|
Agreed, and thanks for the pointer. The fix is Comfy-Org/cloud#14194 (merged as 460950a848). Its regression guard is |
|
@christian-byrne I've addressed all three points in 2ca4364, using the patch shape you suggested:
Verified against a local cloud build of this branch, run twice: the control test passes and the re-subscribing repro is reported as an expected failure. |
|
Re CodeRabbit 4306818704 (validate the seed from the second read): fixed in 07e808d. The Run step now uses one The step still runs before |
|
@christian-byrne Thanks, makes sense. #21335 now carries this spec without |
|
@christian-byrne I checked the fixes you listed against the branch head; they're all there. No further changes from me.
|
|
@christian-byrne Thanks. I'm making no further changes on this branch. What's left is the frontend-devs approval. The late |
|
Following up on review threads 4311022825 and 4311023019 here, because GitHub returns 404 when replying to either thread. 4311023019 (expected-failure window): already on the branch in 4311022825 (readiness probe): this is now done in commit What I said last round was wrong. The commit changes three things:
Checks:
|
|
@coderabbitai, about review comment 4311128876 (remove the added code comments). Posting here because replying to the thread returns 404. Agreed. All five are removed: the four inline comment blocks and the JSDoc on
Both commits sit on top of These commits are not on the PR yet. The bot's push tool currently fails with "Could not determine the current git branch". They will be pushed once it works. |
|
Closing this draft as a non-carrier. The fix merged in https://github.com/Comfy-Org/cloud/pull/14194 at |
|
Agreed, closing makes sense. This replay only plays back canned server frames, so the backend fix in Comfy-Org/cloud#14194 ( |
|
Re: the
|
|
Re: the
|
|
Re: the
|
|
Re: the
|
|
Re: the
|
|
Re: the
|
|
Re: the The reconnect and queue tests passed on e58a492 in the previous round (105/105). Nothing else to change on my side. |
|
Re: the The reconnect and queue tests passed on e58a492 (105/105). Nothing else to change on my side. |
|
Re: the custom event-bus comment in The reconnect and queue tests passed on e58a492 (105/105). Nothing else to change on my side. |
|
Replying here to the latest batch of inline comments, since those threads return "not found" for inline replies. Thanks. I checked each fix on the branch tip (e58a492):
|
|
Re: the inline "followed run" check in
|
|
Re: the active-job mutation table in
|
|
Re: the test name
|
|
@christian-byrne, about the |
|
@christian-byrne, about renaming |
|
@dante01yoon, about the unreadable active run being dropped on the first refresh: you were right. Fixed in 3fe47f6. An I also turned the give-up test into a table that runs it for a queued-only run and for a One trade-off to be aware of: refreshes only happen on (I posted this as a general comment because the inline reply returned 404.) |
|
@christian-byrne, about the narrowing in 409f161: I agree. The retry budget is for runs that history says ended but whose outputs we can't read yet. A run that's missing from both the queue and history is stale, so the #12067 One small thing: 409f161 adds a two-line About the remaining gap: I agree that telling a 404 apart from a transport failure on (I posted this as a general comment because the inline reply returned 404.) |
|
@christian-byrne, about removing the comment: thanks. I checked e2a0033. It only deletes those two lines, and |
|
@christian-byrne, about the "keep showing as running until the next retry" trade-off: agreed. Keeping it as the approved behaviour, noted under "Known trade-off", is the right scope for this PR. Releasing |
|
@christian-byrne Agreed, closing as superseded is the right call. I confirmed that |
|
Re: backports on hold (comment 6373897095). Agreed, no code change from me. The dependency is real: the reconnect replay uses I support the default, (b): ship in the 1.59 line. If @christian-byrne decides the drop-recovery fix is needed on 1.58, do (a) in order: #21300 first, then this PR. I can do the cherry-picks and resolve the conflicts in |
|
@christian-byrne Thanks for the update. I'm making no changes on this branch, since the fix is already in v1.60.0 and the backports are handled in #22035 (core/1.58) and #22036 (cloud/1.58). Your summary matches my understanding. #21282 depends on #21300 because the follower-socket fixture changed there, which is why the auto-backport failed until #21300 was picked first. For 1.57, the conflict in I agree that the first CI run of the browser specs on 1.58 is the gate before merging the backports. |
|
@christian-byrne Thanks, noted. This PR needs no code changes for this. The backport status is 1.58 only (#22035 core, #22036 cloud, first shipping in 1.58.2). 1.57 and 1.56 are skipped because the port conflicts and would also need #21300. The labels can be re-added if a 1.57 port is wanted later. The remaining follow-up (replayed outputs of expanded nodes on reconnect, FE-3481 gap 2) will go in its own PR, not this one. |
PR Created by the Glary-Bot Agent
Repro only, no fix. This adds a browser spec that is expected to fail (
test.fail) for PM-2122, from B. Elliott Baker's rc34 local agent session. The agent asks "want me to run it?" in chat. After he says yes, it asks again with the run approval card ("do you approve the run?"). He suggested it validate once.What the spec does
browser_tests/tests/agent/agentDoubleRunApproval.spec.ts, with run mode pinned toask_approval:runon arun_approvalcard, the frame the cloud agent sends in Ask mode.test.failis declared after setup, so a setup break still fails the spec for real.Important limitation
The second ask comes from the cloud agent: the run gate parks
runin Ask mode, and the prompt also offers the run in prose. This spec replays those server frames, so a backend fix cannot turn it green on its own. When the agent stops sending the second ask, update the replay. The frontend must not hide a parkedrun_approvalask to make this pass, because that strands the turn. A real regression test for the fix belongs next to the cloud agent's run gate or prompt.Fixture changes (test only)
In
agentTurnLockFixture:turnTextEvent(delta, turnId?)is new.runApprovalEventFor(turnId)is new;RUN_APPROVAL_EVENTis now built from it and is unchanged.acceptNextTurnAs(turnId)lets a follow-up turn get its own id. The default single-id behaviour is unchanged.All six specs that use this fixture still pass.
Verification
The spec ran against a local cloud build with
--project=cloudand failed as expected only at the final assertion (2 prompts vs 1).oxlint,oxfmtandpnpm typecheck:browserare clean.Linear: PM-2122
Screenshots