Repository navigation
[backport core/1.58] fix: restore a run's outputs when it finished while the socket was down (PM-2123) (#21282) - #22035
Conversation
…e job (#21300) ## Summary Frames from a job queued in a background tab paint the visible tab's canvas: progress bars, previews, outputs and progress text land on whichever nodes share an id. This gates every path that writes to the visible canvas on one predicate, `belongsToActiveWorkflow(jobId)`, which compares the workflow instance that queued the job (already recorded by `storeJob`) with `workflowStore.activeWorkflow`. Per-job bookkeeping (`queuedJobs`, `nodeProgressStatesByJob`, workflow tab status, job previews) still accepts every frame. ```diff execution_start per-job bookkeeping, tab status + if owned: activeJobId, locator cache, start errors progress_state nodeProgressStatesByJob + if owned: nodeProgressStates mirror, executing progress progress if owned: executingNodeProgress executed if owned: activeJob.nodes, node outputs, onExecuted execution_cached if owned: activeJob.nodes b_preview_with_meta jobPreviewStore + if owned: node previews progress_text if owned: text preview widget +activeWorkflow change + adopt that workflow's started job as activeJobId + restore its mirror from nodeProgressStatesByJob, or clear the mirror ``` Jobs whose owner is unknown (queued by another client, or before a reload) keep today's behaviour: admitted unless a different job is already active. Terminal frames (`execution_success`, `execution_error`, `execution_interrupted`) are unchanged and still reset global state for any job. This is the minimal cut of #20045. It leaves out the `workflow_metadata` wire field, the graph-id and path fallbacks, queue-poll eviction, `api.lastExecutingMessage` and the backend simulator. Each can follow as its own PR if it turns out to be needed. Fixes #1293 Fixes #2660 Fixes #6730 ## Verification - `pnpm test:unit src/stores/executionStore.test.ts src/composables/node/useProgressTextPreviews.test.ts src/scripts/app.test.ts`: 293 passed. - With the source changes stashed, the 8 new tests fail (background `execution_start` becomes active, background `progress_state` reaches the mirror, background `executed`/`execution_cached` mark the active job, no adoption on tab switch, background outputs/previews/text reach the visible nodes); the unknown-owner test passes on both sides. - Not covered: a two-tab Playwright run against a real backend. The tests fire the same frames the server sends through `api`'s event listeners. Known gap, unchanged from main: with two jobs running at once across tabs (Cloud), a foreign job's terminal frame clears the visible mirror until the next `progress_state` frame of the visible job. ## Merge Danger **Door:** two-way. Revert restores the previous behaviour; no persisted data or wire format changes. **Blast Radius:** execution display Extensions that read `executionStore.activeJobId` or `executingNodeId` now see the visible tab's job rather than whichever job last started. `node.onExecuted` no longer fires on the visible graph for a background job's node. --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> (cherry picked from commit d3193bb)
Restores completed-run outputs after reconnect. Justification: named human approval covered the substantive code; the only post-approval delta removed prohibited comments, exact-head required checks are green, and the eight-commit main delta has zero file overlap. (cherry picked from commit 0ce4863)
…(PM-2219) (#21889) Justification: approved at exact head ed221f1 by dante01yoon (frontend reviewer) plus comfy-greenlight-bot and coderabbitai; required checks test, lint-and-format, e2e-status, website-e2e all SUCCESS at that head; the single failing job upload-e2e-coverage / package is not a required status check on ProtectMain. Remaining review threads are explicitly non-blocking and are being answered and routed to follow-ups. (cherry picked from commit 8ce7211)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-27T02:11:26.935Z",
"gitSha": "af8d13af953e83964f3af795919aa1d6a7177fec",
"branch": "backport-21282-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.0560000000112,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4709999999999996,
"layouts": 10,
"layoutDurationMs": 2.936,
"taskDurationMs": 495.225,
"heapDeltaBytes": 3338020,
"heapUsedBytes": 93532828,
"domNodes": -200,
"jsHeapTotalBytes": 1630208,
"scriptDurationMs": 11.712,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.497999999975,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2889999999999997,
"layouts": 10,
"layoutDurationMs": 3.374,
"taskDurationMs": 583.0659999999999,
"heapDeltaBytes": 4158484,
"heapUsedBytes": 104016488,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 11.304000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1791.690999999986,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.127,
"layouts": 11,
"layoutDurationMs": 3.06,
"taskDurationMs": 840.5740000000001,
"heapDeltaBytes": -4350968,
"heapUsedBytes": 92067888,
"domNodes": -201,
"jsHeapTotalBytes": 1105920,
"scriptDurationMs": 174.233,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.2900000000368,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.942000000000002,
"layouts": 10,
"layoutDurationMs": 2.8360000000000003,
"taskDurationMs": 865.461,
"heapDeltaBytes": -352620,
"heapUsedBytes": 90017972,
"domNodes": -200,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 177.234,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.2359999999717,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.532,
"layouts": 11,
"layoutDurationMs": 3.164,
"taskDurationMs": 334.975,
"heapDeltaBytes": 25384256,
"heapUsedBytes": 115631832,
"domNodes": 47,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 12.925999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.0920000000688,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.68,
"layouts": 10,
"layoutDurationMs": 3.106,
"taskDurationMs": 466.052,
"heapDeltaBytes": 21585868,
"heapUsedBytes": 112799780,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 14.693999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 759.2290000000048,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.8020000000000005,
"layouts": 8,
"layoutDurationMs": 2.2580000000000005,
"taskDurationMs": 512.3829999999999,
"heapDeltaBytes": 3801604,
"heapUsedBytes": 93614936,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 174.992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 742.4730000000181,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.309,
"layouts": 9,
"layoutDurationMs": 2.9389999999999996,
"taskDurationMs": 525.282,
"heapDeltaBytes": 4143444,
"heapUsedBytes": 94485564,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 177.134,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1234.5109999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.282,
"heapDeltaBytes": -14945668,
"heapUsedBytes": 102123024,
"domNodes": -211,
"jsHeapTotalBytes": 15794176,
"scriptDurationMs": 70.007,
"eventListeners": -168,
"totalBlockingTimeMs": 551,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1253.2500000000368,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 976.248,
"heapDeltaBytes": -16662728,
"heapUsedBytes": 102296188,
"domNodes": -230,
"jsHeapTotalBytes": 15794176,
"scriptDurationMs": 78.28200000000002,
"eventListeners": -168,
"totalBlockingTimeMs": 545,
"frameDurationMs": 32.89473684210526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.1540000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.0469999999997,
"heapDeltaBytes": -4575976,
"heapUsedBytes": 96812196,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.13300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.1119999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.8160000000004,
"heapDeltaBytes": -3579392,
"heapUsedBytes": 97784068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.56900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12686.520000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11718.668,
"heapDeltaBytes": 69644748,
"heapUsedBytes": 172575440,
"domNodes": -276,
"jsHeapTotalBytes": 59039744,
"scriptDurationMs": 9887.933,
"eventListeners": -130,
"totalBlockingTimeMs": 2437,
"frameDurationMs": 35.086426592797785,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10854.551999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9986.76,
"heapDeltaBytes": 34201484,
"heapUsedBytes": 143836944,
"domNodes": -296,
"jsHeapTotalBytes": 42524672,
"scriptDurationMs": 8332.483000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 1542,
"frameDurationMs": 32.679518072289156,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11121.652000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10341.995,
"heapDeltaBytes": 35919768,
"heapUsedBytes": 139862028,
"domNodes": -296,
"jsHeapTotalBytes": 38068224,
"scriptDurationMs": 8266.381000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 1240,
"frameDurationMs": 30.964623955431758,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10698.99700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9898.219,
"heapDeltaBytes": 45276040,
"heapUsedBytes": 155127976,
"domNodes": -276,
"jsHeapTotalBytes": 38068224,
"scriptDurationMs": 7867.117,
"eventListeners": -130,
"totalBlockingTimeMs": 937,
"frameDurationMs": 31.285087719298247,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 217.48199999998974,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.568,
"layouts": 11,
"layoutDurationMs": 3.8859999999999997,
"taskDurationMs": 165.74699999999999,
"heapDeltaBytes": 13236076,
"heapUsedBytes": 120667576,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.264000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 99.90000000000055
},
{
"name": "large-combo-open",
"durationMs": 285.94299999997475,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.968000000000004,
"layouts": 11,
"layoutDurationMs": 3.3729999999999998,
"taskDurationMs": 244.605,
"heapDeltaBytes": 13393832,
"heapUsedBytes": 121363596,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.312000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 4,
"frameDurationMs": 24.991666666666713,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2025.242999999989,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.903,
"layouts": 8,
"layoutDurationMs": 2.2700000000000005,
"taskDurationMs": 593.7300000000001,
"heapDeltaBytes": 739820,
"heapUsedBytes": 110958668,
"domNodes": -276,
"jsHeapTotalBytes": -1515520,
"scriptDurationMs": 35.901999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6672131147541,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.569999999965,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7849999999999993,
"layouts": 8,
"layoutDurationMs": 2.8060000000000005,
"taskDurationMs": 605.12,
"heapDeltaBytes": -26991640,
"heapUsedBytes": 96314448,
"domNodes": -296,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 39.105000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2640.7199999999875,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.736999999999998,
"layouts": 7,
"layoutDurationMs": 2.056,
"taskDurationMs": 1820.0189999999998,
"heapDeltaBytes": -3020388,
"heapUsedBytes": 108607396,
"domNodes": -296,
"jsHeapTotalBytes": -503808,
"scriptDurationMs": 844.8990000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.879487179487185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2881.907999999953,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.755999999999998,
"layouts": 6,
"layoutDurationMs": 2.06,
"taskDurationMs": 1902.732,
"heapDeltaBytes": -3147520,
"heapUsedBytes": 108414540,
"domNodes": -296,
"jsHeapTotalBytes": -241664,
"scriptDurationMs": 882.297,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76337209302326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3802.251999999953,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.044999999999998,
"layouts": 64,
"layoutDurationMs": 10.894999999999998,
"taskDurationMs": 1853.9699999999998,
"heapDeltaBytes": -4870620,
"heapUsedBytes": 101881716,
"domNodes": -272,
"jsHeapTotalBytes": -1277952,
"scriptDurationMs": 797.663,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.739207048458155,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3634.5469999999978,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.238,
"layouts": 65,
"layoutDurationMs": 11.731,
"taskDurationMs": 1731.7609999999997,
"heapDeltaBytes": -19669916,
"heapUsedBytes": 95788528,
"domNodes": -272,
"jsHeapTotalBytes": -765952,
"scriptDurationMs": 819.862,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3091.99000000001,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.785000000000001,
"layouts": 5,
"layoutDurationMs": 1.3760000000000006,
"taskDurationMs": 1884.3670000000002,
"heapDeltaBytes": 22068464,
"heapUsedBytes": 136826696,
"domNodes": 0,
"jsHeapTotalBytes": 8286208,
"scriptDurationMs": 1009.984,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.027027027027028,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3256.3080000001037,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.799,
"layouts": 4,
"layoutDurationMs": 1.1810000000000003,
"taskDurationMs": 2153.419,
"heapDeltaBytes": -8433660,
"heapUsedBytes": 98775156,
"domNodes": 0,
"jsHeapTotalBytes": 688128,
"scriptDurationMs": 1033.3400000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.013020833333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2043.8449999999762,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2310000000000003,
"layouts": 7,
"layoutDurationMs": 2.1820000000000004,
"taskDurationMs": 698.2099999999999,
"heapDeltaBytes": -833160,
"heapUsedBytes": 103237680,
"domNodes": -296,
"jsHeapTotalBytes": -1765376,
"scriptDurationMs": 35.733,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.8970000000018,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.658000000000001,
"layouts": 7,
"layoutDurationMs": 2.224,
"taskDurationMs": 608.8,
"heapDeltaBytes": 541672,
"heapUsedBytes": 113307488,
"domNodes": -300,
"jsHeapTotalBytes": -729088,
"scriptDurationMs": 39.666,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 664.1539999999964,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.9079999999999995,
"layouts": 9,
"layoutDurationMs": 2.432,
"taskDurationMs": 482.11199999999997,
"heapDeltaBytes": 25599088,
"heapUsedBytes": 116417352,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 149.763,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.2240000000775,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.56,
"layouts": 9,
"layoutDurationMs": 2.7320000000000007,
"taskDurationMs": 416.36199999999997,
"heapDeltaBytes": -972648,
"heapUsedBytes": 90758768,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 156.964,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.7490000000337,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2310000000000003,
"layouts": 9,
"layoutDurationMs": 2.691,
"taskDurationMs": 491.807,
"heapDeltaBytes": 5205916,
"heapUsedBytes": 96561836,
"domNodes": -218,
"jsHeapTotalBytes": 1368064,
"scriptDurationMs": 11.146,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.9219999999277,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.603,
"layouts": 10,
"layoutDurationMs": 3.2250000000000005,
"taskDurationMs": 576.975,
"heapDeltaBytes": 4495516,
"heapUsedBytes": 107187388,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.549000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2009.1269999999781,
"styleRecalcs": 86,
"styleRecalcDurationMs": 15.823,
"layouts": 9,
"layoutDurationMs": 2.3390000000000004,
"taskDurationMs": 1161.9460000000001,
"heapDeltaBytes": -4947904,
"heapUsedBytes": 85910700,
"domNodes": -210,
"jsHeapTotalBytes": 2154496,
"scriptDurationMs": 121.323,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.3560000000489,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.665999999999999,
"layouts": 9,
"layoutDurationMs": 2.748,
"taskDurationMs": 799.597,
"heapDeltaBytes": 5437436,
"heapUsedBytes": 95905020,
"domNodes": -190,
"jsHeapTotalBytes": 2940928,
"scriptDurationMs": 120.37299999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.7520000000518,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.127,
"layouts": 5,
"layoutDurationMs": 16.463,
"taskDurationMs": 1119.7089999999998,
"heapDeltaBytes": 16343684,
"heapUsedBytes": 137551860,
"domNodes": 16030,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 30.95,
"eventListeners": 3244,
"totalBlockingTimeMs": 158,
"frameDurationMs": 20.04459459459461,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8342.151000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.13,
"layouts": 7,
"layoutDurationMs": 2.049,
"taskDurationMs": 5520.34,
"heapDeltaBytes": 2843200,
"heapUsedBytes": 113383656,
"domNodes": -296,
"jsHeapTotalBytes": -12288,
"scriptDurationMs": 2798.4259999999995,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.799999999999997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8357.547999999952,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.993999999999996,
"layouts": 8,
"layoutDurationMs": 2.3579999999999997,
"taskDurationMs": 5581.223,
"heapDeltaBytes": 1522232,
"heapUsedBytes": 112303964,
"domNodes": -296,
"jsHeapTotalBytes": -12288,
"scriptDurationMs": 2780.413,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732665330661323,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16663.442000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15703.336999999998,
"heapDeltaBytes": 2019964,
"heapUsedBytes": 302570128,
"domNodes": -3373,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 266.63000000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.86297577854672,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 24071.670000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23425.145999999997,
"heapDeltaBytes": -36338328,
"heapUsedBytes": 273320188,
"domNodes": -3344,
"jsHeapTotalBytes": -13381632,
"scriptDurationMs": 386.914,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.249649122807014,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 19902.693,
"styleRecalcs": 154,
"styleRecalcDurationMs": 15.50399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19470.503,
"heapDeltaBytes": 4318056,
"heapUsedBytes": 315098276,
"domNodes": -3344,
"jsHeapTotalBytes": 24297472,
"scriptDurationMs": 822.376,
"eventListeners": -651,
"totalBlockingTimeMs": 55,
"frameDurationMs": 35.984086799276675,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 20418.962999999963,
"styleRecalcs": 150,
"styleRecalcDurationMs": 18.145999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20112.8,
"heapDeltaBytes": -22688152,
"heapUsedBytes": 297036032,
"domNodes": -3344,
"jsHeapTotalBytes": 21483520,
"scriptDurationMs": 865.441,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 37.807222222222215,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 8446.68299999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.64600000000002,
"layouts": 20,
"layoutDurationMs": 23.30900000000001,
"taskDurationMs": 8339.153999999999,
"heapDeltaBytes": -40567880,
"heapUsedBytes": 283569448,
"domNodes": -3344,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 131.53900000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.465517241379324,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8673.10299999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.51000000000002,
"layouts": 20,
"layoutDurationMs": 25.979000000000003,
"taskDurationMs": 8535.764000000001,
"heapDeltaBytes": -31040412,
"heapUsedBytes": 293311296,
"domNodes": -3344,
"jsHeapTotalBytes": 4706304,
"scriptDurationMs": 142.487,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.617142857142866,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8251.891,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7859.324999999998,
"heapDeltaBytes": 10008024,
"heapUsedBytes": 280623520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.32600000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.845104895104896,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8347.488999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8025.767999999999,
"heapDeltaBytes": 4320376,
"heapUsedBytes": 266419400,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.57200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.75017182130584,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 482.4820000000045,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.523,
"layouts": 11,
"layoutDurationMs": 3.651,
"taskDurationMs": 122.29499999999999,
"heapDeltaBytes": 7106328,
"heapUsedBytes": 103921968,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.246999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 129.1879999999992,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.781,
"layouts": 9,
"layoutDurationMs": 3.8720000000000003,
"taskDurationMs": 79.528,
"heapDeltaBytes": 4679308,
"heapUsedBytes": 94882156,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.8420000000000005,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 492.9929999999558,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.679,
"layouts": 76,
"layoutDurationMs": 15.594999999999999,
"taskDurationMs": 440.944,
"heapDeltaBytes": -14250048,
"heapUsedBytes": 81267464,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 208.74699999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 543.0039999999963,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.053,
"layouts": 76,
"layoutDurationMs": 16.910999999999998,
"taskDurationMs": 494.427,
"heapDeltaBytes": 12512100,
"heapUsedBytes": 83138668,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 238.443,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 680.5249999999887,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5469999999999997,
"layouts": 76,
"layoutDurationMs": 17.214,
"taskDurationMs": 641.239,
"heapDeltaBytes": 1549028,
"heapUsedBytes": 119169280,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 269.513,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 585.5300000000625,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.155,
"layouts": 76,
"layoutDurationMs": 14.372,
"taskDurationMs": 545.829,
"heapDeltaBytes": 1118108,
"heapUsedBytes": 118222928,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 218.846,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2977 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 555b8e2ececa8ead94faebc3c7573f29a90bcef7
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (118)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.58 #22035 +/- ##
=============================================
+ Coverage 84.58% 84.60% +0.02%
=============================================
Files 2935 2936 +1
Lines 161159 161373 +214
Branches 39255 41517 +2262
=============================================
+ Hits 136313 136527 +214
Misses 24455 24455
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Faithful backport of #21282 with its execution-ownership prerequisite and toolbar-stop regression fix.
I reapplied the merged diffs in order: #21300 at d3193bb, #21282 at 0ce4863, then #21889 at 8ce7211. All are merged on current main. The resulting tree matches this head except for the socket counter and disconnect hook borrowed from #21497, whose shared fixture changes are absent from core/1.58. Those test-only hooks supply exactly what the retained reconnect regression needs. All source changes and tests are carried.
With the target's locked dependencies, I ran the seven changed unit suites: 451 passed and one skipped. All ten affected browser cases passed with retries disabled across the cloud and Chromium projects. Browser typechecking, targeted type-aware lint, and whitespace checks passed. The branch's required lint-and-format, test, and e2e-status checks also passed. The advisory coverage-packaging job failed because lcov rejected duplicate inner_clicked records in unchanged LGraphCanvas.ts; the coverage merger is also unchanged by this PR. I am not treating that packaging failure as a backport divergence.
Backport of #21282 to
core/1.58: after a dropped connection, a run that finished while offline now shows its output without a page reload (PM-2123).It brings two PRs it depends on:
Full context for agent readers
Commits, in order (cherry-picked with
-x, all clean):d3193bb81dfix(execution): scope execution frames to the workflow that queued the job0ce48633ddfix: restore a run's outputs when it finished while the socket was downcomfyConnectionCount()anddisconnectComfySocket()tobrowser_tests/fixtures/agentFollowerHostSocket.ts. On main these came with test: pin agent wire identity across a /ws reconnect #21497, which is not on 1.58; the PM-2123 spec needs only these two hooks.8ce7211485fix(queue): enable the toolbar stop control for an Agent-started runLocal checks on Node 26.8.2:
pnpm typecheckandpnpm typecheck:browserclean; vitest over actionbar, queue, stores, reconnect, jobs, app and progress-preview tests: 103 files pass. The browser specsagentOutputAfterSocketDrop,actionbarCancelAgentRunandqueue/runProgressBarhave not run on 1.58 yet; this PR's CI is their first run.Adversarial review: a fresh Claude subagent (Codex CLI login is expired on this host). Verdict SHIP-WITH-CHANGES; the only required change is running those specs on 1.58 (CI). Its findings:
useReconnectQueueRefresh.ts,useInterruptibleJob.ts,fetchJobs.tsandqueueStore.tsare byte-identical to main after the picks;executionStore.tsdiffers only by fix(execution): report when execution_start rejects a job with no known owner #21761 (diagnostic) and fix(agent): keep an Agent run's outputs on the tab it ran for (PM-2275) #21666 (PM-2275), neither called here.Not carried: #21666 (feature, not a regression fix), #21761 (diagnostic).